Commit graph

156 commits

Author SHA1 Message Date
Alf Eaton
8921b8484e Merge pull request #18140 from overleaf/ae-log-rules
Add new regular expressions for matching compiler error messages

GitOrigin-RevId: ab6e17951c29c2a68b385b7e0cb77abf2d22281d
2024-05-01 08:04:27 +00:00
Jakob Ackermann
e100d85940 Merge pull request #17422 from overleaf/jpa-avoid-resize-observer-loop
[web] avoid ResizeObserver loop when opening logs pane

GitOrigin-RevId: fb9c54e137785b34af01d031e182b66969711e41
2024-04-17 08:03:59 +00:00
Antoine Clausse
d35204033f Merge pull request #17909 from overleaf/ac-tear-down-compile-timeout-tests-2
[web]  Remove split-tests `compile-backend-class*` and `compile-timeout-20s*` (attempt 2)

GitOrigin-RevId: 5658f2977d3e7089eec5bbe7a33eee81c153e41d
2024-04-16 08:04:08 +00:00
Antoine Clausse
491bc2628d Merge pull request #17899 from overleaf/revert-17700-ac-tear-down-compile-timeout-tests
Revert "[web] Remove split-tests `compile-backend-class*` and `compile-timeout-20s*`"

GitOrigin-RevId: d5070ced06adbd435e782a44b7ef767e395bd6a0
2024-04-15 08:04:37 +00:00
Antoine Clausse
2dd10c7fee [web] Remove split-tests compile-backend-class* and compile-timeout-20s* (#17700)
* Remove split-tests of `compile-timeout-20s` and `compile-timeout-20s-existing-users`

* Remove `NEW_COMPILE_TIMEOUT_ENFORCED_CUTOFF` variables

* Revert timeout override `60` -> `20`

* Update settings.overrides.saas.js: `compileTimeout: 20`

* Remove `compile-backend-class-n2d`

* Remove `force_new_compile_timeout`

* Remove `showNewCompileTimeoutUI`

* Remove `compileTimeChanging`

* Simplify code by removing segmentation object

* Remove `CompileTimeoutChangingSoon`

* Remove `user.features.compileTimeout = '20 (with 10s prompt)'`

* Remove `CompileTimeWarning`

* Remove `TimeoutUpgradePrompt` (old)

* Remove `compile-backend-class`

* Remove unused translations

* Update tests

* Fix: Show `CompileTimeout` even if `!window.ExposedSettings.enableSubscriptions`

* Create script to migrate users to 20s compileTimeout

* migration script: exclude `compileTimeout: 20` from the match

* migration script: use `batchedUpdate`

* Remove `showFasterCompilesFeedbackUI` and `FasterCompilesFeedback`

Helped-by: Jakob Ackermann <jakob.ackermann@overleaf.com>

* Remove `_getCompileBackendClassDetails`, simplify definition of `limits` object

* Remove `Settings.apis.clsi.defaultBackendClass`

* Remove unnecessary second scan of the whole user collection in dry mode

* Override `timeout` to 20 for users having `compileGroup === 'standard' && compileTimeout <= 60`

* Remove second `logCount`: re-run the script in dry-mode if you want to see that count

* Use secondary readPreference when counting users

* Fix script setup and exit 0

* Fix: Remove `user.` from query path!

* Add acceptance test on script migration_compile_timeout_60s_to_20s.js

GitOrigin-RevId: 3cb65130e6d7fbd9c54005f4c213066d0473e9d8
2024-04-15 08:04:24 +00:00
Antoine Clausse
8e0e2041a7 Move "reducing_compile_timeout" notice to the bottom of the box (#17840)
GitOrigin-RevId: 6dc28cb41af28947c4e43ab57d26518c0c0a3245
2024-04-11 08:03:29 +00:00
Antoine Clausse
92a58c8f3b [web] Paywall CTA split-test (#17555)
* Fix `{splitTest.requiredCohortSize && (...)}` can display `0`

* Get `paywall-cta` assignment in ProjectController.js

* CTA change: "Get Dropbox Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286026

* CTA change: "Get GitHub Sync"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get Git integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286283

* CTA change: "Add more collaborators"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763884855

* CTA change: "Get track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764030761

* Update wording and position: "Already subscribed? Try refreshing the page."

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764366969

* Casing update: "Upgrade to track changes"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764209961

* CTA changes: "Get Mendeley integration" + "Get Zotero integration"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547424

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547269

* CTA change: "Get full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762005

* Casing update: "full project history"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762280

* CTA change: "Get more compile time" in timeout-upgrade-prompt-new.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get more compile time" in compile-timeout-warning.tsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762726

* CTA change: "Get advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969087

* Update casing and wording: "advanced reference search"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969412

* CTA change: "Get Symbol Palette"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765128906

* Update title: "Subscribe to find the symbols you need faster"

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765289664

* Revert use of `satisfies`: it doesn't work with our version of prettier (https://github.com/prettier/prettier/issues/13516)

* CTA change: "Get more compile time" in compile-timeout-changing-soon.tsx

⚠️ not in miro

* Rename `paywallCtaAssignment`, remove useless export and comment

Addressing Fahru's review

* Add alternative texts in `/registration/try-premium` page

* CTA change: "Get more compile time" in timeout-upgrade-prompt.jsx

https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563

* CTA change: "Get GitHub Sync" in import-project-from-github-modal-content.tsx

Not in Miro, but related to: https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736

* CTA change: "Get more compile time" in compile-time-warning.tsx

Not in Miro, but related to others

* Fix compile-time-warning style (spacings, overflows out of window)

* `npm run format:fix`

GitOrigin-RevId: 0d8d1808b5901c2761d35494c49713d26721bcfd
2024-04-03 08:04:16 +00:00
Alf Eaton
362a947c5a Add prototype compile assistant (#17402)
GitOrigin-RevId: 07547f2a83aec8cfda75c589ed24cdc85fe15b59
2024-03-26 09:04:28 +00:00
Alf Eaton
6cc2db3cdd Merge pull request #17525 from overleaf/ae-upgrade-prettier
Upgrade Prettier to v3

GitOrigin-RevId: 6f1338f196408f3edb4892d5220ad3665ff1a5bc
2024-03-26 09:04:05 +00:00
Alf Eaton
e9dbaf20b8 Wrap useResizeObserver dependency in useCallback (#16972)
GitOrigin-RevId: fd4a10a2897878361a87bb02c5c6e8e6abfa8f26
2024-02-12 09:03:11 +00:00
Alf Eaton
0cde5be165 Merge pull request #14709 from overleaf/ae-context-typescript
Convert React context providers to TypeScript [don't squash!]

GitOrigin-RevId: d92a91798286978410956ab791d73c17c5086d86
2024-01-29 09:03:04 +00:00
Alf Eaton
3de9efb1bb Fix stripe alignment on Recompile button (#16643)
GitOrigin-RevId: 504bc90889e89c62727777eedc81dfa192094e75
2024-01-24 09:04:11 +00:00
Alf Eaton
aa1e29aa19 Add event tracking for log entry source link click (#16600)
GitOrigin-RevId: a4b4a3f5cf4cbf6ac93ef9a8637028726f6cf161
2024-01-24 09:03:31 +00:00
Alf Eaton
a50ca25f3a Throttle PDF.js resize listener (#16402)
GitOrigin-RevId: 5c1498d21197b09865930e1b2deff049022d2d17
2024-01-09 09:03:49 +00:00
Jakob Ackermann
6470afaec3 Merge pull request #15844 from overleaf/jpa-download-events
[web] change isMobileDevice segmentation to isSmallDevice

GitOrigin-RevId: 1fcaf6ececc1fa75fd681ef2497bfa5e5567143d
2023-11-27 09:04:08 +00:00
Jakob Ackermann
6b2daed903 Merge pull request #15843 from overleaf/jpa-download-events
[web] add additional event tracking

GitOrigin-RevId: 877f92db41efff017db370ec75b8d1f861eed4f2
2023-11-21 09:04:28 +00:00
Thomas
3cd0cefd30 Gradual rollout of new compile timeout to existing users (#15478)
* Rollout compile timeout to existing users

* Update copy for compile timeout messages

GitOrigin-RevId: bada02efb3fc506ae6e35bdb7871a58ef4295cbe
2023-10-31 09:04:11 +00:00
Alf Eaton
221d16f4e4 Disable transSupportBasicHtmlNodes in react-i18next config (#15430)
* Set transSupportBasicHtmlNodes to false
* Update ESLint rule
* Convert Trans to t
* Convert shouldUnescape={true}
* Convert some arrays to objects
* Update translations

GitOrigin-RevId: 64a50318388abcada408f72d949de148129a9f63
2023-10-31 09:04:04 +00:00
Tim Down
13f246a85e Merge pull request #15342 from overleaf/td-remove-file-tree-manager-in-react
Remove use of FileTreeManager in React code

GitOrigin-RevId: f15bc9b4f84e0f65709b9850ed8cc5d3637efa7f
2023-10-27 08:03:10 +00:00
Alf Eaton
3bf468f599 Add Storybook stories for compile timeout messages (#15371)
GitOrigin-RevId: 91206fcfea0dc0ef18d435e2f58284e5837d4b4d
2023-10-25 08:04:29 +00:00
Alf Eaton
fa2afb7807 Ensure that strong component is defined for translations (#15370)
GitOrigin-RevId: 729ac6ac56285d97340e07861a5f47c273ebd131
2023-10-24 08:03:21 +00:00
Alf Eaton
7755203ff7 Enable ESLint rule that enforces t when preferable to Trans (#15253)
GitOrigin-RevId: d11b3f587b462d400a8d68128dc8be342415bf7d
2023-10-20 08:03:34 +00:00
Alf Eaton
0c81bccfca Ensure that translation values are correctly escaped (#15252)
GitOrigin-RevId: 5a38b4c01921fd4d95dbdb7b9e756443fdb00b80
2023-10-20 08:03:31 +00:00
Tim Down
3be937c503 Migrate layout context to TypeScript (#15275)
Migrate layout context to TypeScript

GitOrigin-RevId: ce453bfb67f7c36176fa24144413b556cd3c117e
2023-10-19 08:03:01 +00:00
Jakob Ackermann
83cf21d8cf Merge pull request #15271 from overleaf/jpa-lazy-loading
[web] lazy load big optional UI elements

GitOrigin-RevId: 18d723c66834be3984b74c3c89cfb46e2fffbfc1
2023-10-18 08:04:05 +00:00
Rebeka Dekany
968407f859 Merge pull request #15181 from overleaf/rd-compile-timeout-date
Extend the compile timeout date

GitOrigin-RevId: 44627c311110f1acce15a49e1448ae92b16cb889
2023-10-10 07:57:58 +00:00
Jakob Ackermann
9daa8f5d98 Merge pull request #15040 from overleaf/jpa-js-to-jsx
[web] rename all the JSX files to .jsx/.tsx

GitOrigin-RevId: 82056ae47e017523722cf258dcc83c8a925a28f7
2023-09-29 08:04:29 +00:00
Alf Eaton
04900349e6 Add PdfPreviewProvider and preserve PDF viewer loading error (#14970)
GitOrigin-RevId: ac305633c7c0bc13f5f670b71890cfd30a3cbffd
2023-09-29 08:04:10 +00:00
Jakob Ackermann
1213709578 Merge pull request #14980 from overleaf/jpa-debug-console
[web] migrate frontend logging to debugConsole

GitOrigin-RevId: b03ff9030b03fff059738d2270bc4b4912e79f16
2023-09-28 08:04:12 +00:00
Thomas
c8c2f661b3 Merge pull request #14898 from overleaf/tm-remove-debug-logs-pdf-detach-error
Remove debug statements that call potentially undefined logger

GitOrigin-RevId: b317a023057d271611cafbf65bbc192a4b82bfdd
2023-09-20 08:03:36 +00:00
Thomas
b39effbb4b Merge pull request #14896 from overleaf/tm-compile-time-warning-would-display
Use standard paywall-types, extend paywall to include variant in segmentation

GitOrigin-RevId: 17a154c525fed3b05a5208a34f374608f045872f
2023-09-20 08:03:32 +00:00
Thomas
31e4e16c0b Merge pull request #14882 from overleaf/tm-compile-time-warning-would-display
Fix unreachable 'compile time warning would display' event

GitOrigin-RevId: 3734ef69062d11cdde851447c657a58259d00acf
2023-09-20 08:03:28 +00:00
Thomas
31cb9e336b Implement test to reduce compile timeout to 20 seconds (#14705)
Compile timeout reduction to 20s for treatment users

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>
GitOrigin-RevId: 54f70fe4b1fc631cef966deb0c1d28c904dd3a44
2023-09-19 08:03:52 +00:00
Rebeka Dekany
dc937f4bc8 Merge pull request #14819 from overleaf/rd-report-link-purpose
Accessibility - make view togglers and download button accessible

GitOrigin-RevId: 792cec60d953db7928e30dc7e7187deba59573d0
2023-09-15 08:05:39 +00:00
Rebeka Dekany
9184c0135f Merge pull request #14795 from overleaf/rd-report-zoom-pdf-visible-focus
Accessibility - make the PDF controls accessible by tab navigation

GitOrigin-RevId: 46eee6fda68861884e602eb341dfdb0c5a4903b0
2023-09-15 08:05:31 +00:00
Jimmy Domagala-Tang
3aa6346ab3 Merge pull request #14674 from overleaf/jdt-prevent-menu-item-drags
feat: force all menuitems to be undraggable, and make home button und…
GitOrigin-RevId: 5b04a07aaca43b1eff8b50958d74356663b6d416
2023-09-13 08:04:01 +00:00
Alf Eaton
8bf5790cdc Allow improvedTitle to return an additional JSX element (#14728)
GitOrigin-RevId: ff2c5b9d12b7ef47f658e501ccb2c69b3d5c4cf3
2023-09-12 08:04:12 +00:00
Jimmy Domagala-Tang
b2e74464a2 Merge pull request #14207 from overleaf/jdt-editor-events
editor events

GitOrigin-RevId: 8d74576d4f8117ecca47402afcc9cee229dd0dca
2023-08-23 08:05:23 +00:00
Alf Eaton
930cec2189 Calculate overflow when languageName or visual change (#13872)
GitOrigin-RevId: f2d200d0d34e810688defe78b8143829f095df9f
2023-07-19 08:04:20 +00:00
Alf Eaton
29f67a3985 Merge pull request #13525 from overleaf/jpa-teardown-compile-domain-test
[web] start tear down of split test for new compile domain

GitOrigin-RevId: 405bba924a37f56614b0744f47914306f420a028
2023-07-17 10:43:01 +00:00
M Fahru
ed42d0c9ca Make the switch to editor/pdf button to have the same height (#12110)
GitOrigin-RevId: 5ceaad73c6c6b74ce2b6e8bbc79563bfad6ab34b
2023-07-17 10:26:34 +00:00
Alf Eaton
1f7d317db9 Upgrade pdf.js to 3.6.172 (#13112)
GitOrigin-RevId: 030528343f271a1fc1e07c3bba358873173bec76
2023-05-18 08:04:03 +00:00
Alf Eaton
fefc8384fb Ensure unique ids for tooltips (#13079)
GitOrigin-RevId: 9b6e5c60dade356549bb1b3fd9c6254ab00ace56
2023-05-17 08:04:48 +00:00
Mathias Jakobsen
0bfd1fc852 Merge pull request #13016 from overleaf/dk-syncToEntry-detached
fix: navigate to error location for detached PDF mode
GitOrigin-RevId: 238f163f961e23e57d170180f918d8106b05c23e
2023-05-16 08:04:20 +00:00
June Kelly
17109393c5 Merge pull request #12387 from overleaf/jk-split-button-tweaks
[web] Split-menu style tweaks

GitOrigin-RevId: a04121981c4fe240c247cf03da5be7052c26f541
2023-04-12 08:04:28 +00:00
Alf Eaton
f375362894 Always use mockable location methods (#11929)
* Always use mockable location methods
* Add eslint rules for window.location calls/assignment
* Add useLocation hook
* Update tests

GitOrigin-RevId: eafb846db89f884a7a9a8570cce7745be605152c
2023-03-17 09:05:21 +00:00
Jakob Ackermann
df3c7e48ab Merge pull request #12198 from overleaf/jpa-force-new-compile-domain
[web] changes for force-new-compile-domain test

GitOrigin-RevId: a4ceaf46fdcebed156d155385cbbc2f06405d31f
2023-03-17 09:04:49 +00:00
Miguel Serrano
9ecc84f0b0 [web] download-pdf-button-click event tracking (#12059)
* [web] `download-pdf-button-click` event tracking

GitOrigin-RevId: 20baae4fff989b5120ae03f81cc47f7d6874dd7b
2023-03-14 09:04:44 +00:00
M Fahru
b62cb86bf8 Create new SplitMenu component and implement it for the pdf compile button (detached & non-detached) (#11772)
* Create a new shared `SplitMenu` component.

* Refactor the pdf compile button & detached compile button:
    - Rename `detach-compile-button` to `detach-compile-button-wrapper`
    - Rename `pdf-compile-button-inner` to `detach-compile-button`
    - Move some of the logic from `detach-compile-button-wrapper` to `detach-compile-button`
    - Create a new `compile-button.less` to centralize all of the compile button (detached/non-detached) custom styles rule.
    - Extract the animated striped CSS definition to the dedicated CSS file, change the class from `btn-recompile-group-has-changes` to `btn-striped-animated`
    - Refactor other className(s) appropriately according to the new component name
    - Delete the unused `changes-to-autocompile` css rule since it has not been used anywhere

* Implement the new pdf compile button with the new `SplitMenu` component.

GitOrigin-RevId: d1d055bffd311923fc47b4681605ce8ba8e26f25
2023-02-22 09:04:42 +00:00
Alf Eaton
31d0d10cfc Merge pull request #11877 from overleaf/mj-undefined-control-sequence-help
[web] Improve error messages around missing packages

GitOrigin-RevId: d6f59f452cdc8a5a7e59b9809f68bd18f629ba32
2023-02-21 09:05:04 +00:00