Commit graph

282 commits

Author SHA1 Message Date
Jakob Ackermann
ae0c347f27 Merge pull request #6542 from overleaf/jpa-em-code-sharing-workspaces
[misc] npm workspaces

GitOrigin-RevId: 87aa72db6637fb238d7cd35b0a48ac3ed58ab3eb
2022-02-16 11:31:07 +00:00
Jakob Ackermann
2ed696b3e0 Merge pull request #6517 from overleaf/jpa-node-fetch-2-6-7
[misc] upgrade node-fetch from 2.6.x to 2.6.7

GitOrigin-RevId: 5a43e82e23d78fd6e68a38655dab4665a401a9db
2022-02-01 09:03:24 +00:00
Jakob Ackermann
8789296f5a Merge pull request #6481 from overleaf/jpa-node-14-18-3
[misc] upgrade node version from 14.18.1 to 14.18.3

GitOrigin-RevId: 976542fcc0271e323695c59a987dcf1614ee633e
2022-01-28 09:03:53 +00:00
Tim Alby
d5c574360f remove uses of this in tests
GitOrigin-RevId: 2eea02c91358a7bb5e1d32c8990f793d6f794ac4
2022-01-14 09:03:14 +00:00
Tim Alby
5798011bce always check response's status code in tests
GitOrigin-RevId: 46ed4912a6508aa3ce2048ff8d887af4d8907d6a
2022-01-14 09:03:11 +00:00
Tim Alby
795ed56034 asyncify tests
GitOrigin-RevId: 62f875bb121a599fab830a3244959596796cd6e1
2022-01-14 09:03:08 +00:00
Tim Alby
67ce7c3c75 asyncify MessageHttpController
GitOrigin-RevId: 678a22807f1cbb51a8c1c9bd11b34e1c045d9361
2022-01-14 09:03:06 +00:00
Tim Alby
01cdb4025e asyncify MessageManager
GitOrigin-RevId: 6b89b70f7c19fc9e71d60b634808030f324f40fe
2022-01-14 09:03:03 +00:00
Tim Alby
49e2e02105 asyncify ThreadManager
GitOrigin-RevId: 24fc2d5e04238a7e4e23826a19b69a9fbb2f9637
2022-01-14 09:03:00 +00:00
Tim Alby
f3a5e8a0e8 move module functions to top level
GitOrigin-RevId: 73524dcec49faa05d1fd4dd4ffa6950803175f33
2022-01-14 09:02:57 +00:00
Tim Alby
b5d2122f05 decaf cleanup: remove unnecessary callback fallbacks
GitOrigin-RevId: a6b347e121a30221a305116327e42ad070e81977
2022-01-14 09:02:55 +00:00
Tim Alby
ea8e0af551 decaf cleanup: rewrite code to no longer use __guard__
GitOrigin-RevId: 591dbefe98423ead89505250c4f46c8ad2610305
2022-01-14 09:02:52 +00:00
Tim Alby
291f28a655 decaf cleanup: remove unnecessary use of Array.from
GitOrigin-RevId: 78c835929c9d7c38e0231f8fbb3e16a35efb7498
2022-01-14 09:02:50 +00:00
Tim Alby
efc131175c decaf cleanp: consider shorter variations of null checks
GitOrigin-RevId: 393297eb7d674e2c801701db87e5d7eb876186f0
2022-01-14 09:02:47 +00:00
Tim Alby
87544fc5a5 decaf cleanup: consider reworking code to avoid use of IIFEs
GitOrigin-RevId: 8d60da088deac4a19c6b6a03083765af547d9570
2022-01-14 09:02:44 +00:00
Tim Alby
0a0722a8f8 decaf cleanup: remove unnecessary code created because of implicit returns
GitOrigin-RevId: 9717a14d34a662c9740aa50446d0699c6afd3222
2022-01-14 09:02:41 +00:00
Tim Alby
d56b49d529 fix eslint violations
GitOrigin-RevId: c2ee81487ab2fd66890ac5fda60f396bb537e0e1
2022-01-14 09:02:39 +00:00
Eric Mc Sween
f3f0be5c56 Merge pull request #6211 from overleaf/em-code-sharing
Change directory layout in service containers

GitOrigin-RevId: 09ff19db2a123cbf7691d51e9ce9be6eee264287
2022-01-07 09:03:22 +00:00
Jakob Ackermann
729cbf3fce Merge pull request #6224 from overleaf/jpa-cache-install-deps
[misc] add docker image caching for install_deps, pre-fetch node image

GitOrigin-RevId: b52e52351c62b780538e0668b99fc1c28723addc
2022-01-06 09:03:07 +00:00
Jakob Ackermann
4b308553be Merge pull request #6120 from overleaf/jpa-same-linting-packages
[misc] move the linting setup to the root of the monorepo

GitOrigin-RevId: 1633e2a58598add0b727738cd3bfba0ab7bae781
2021-12-17 09:03:06 +00:00
Eric Mc Sween
f7275a6c4b Merge pull request #6079 from overleaf/em-upgrade-logger
Upgrade logger and metrics in all services

GitOrigin-RevId: 2baf63eeeab77fb3559cf763ddacfbf4b745cd0b
2021-12-15 09:04:25 +00:00
Jakob Ackermann
05cb9c49bf Merge pull request #5819 from overleaf/jpa-chat-race
[chat] fix race condition of concurrent delete operations

GitOrigin-RevId: 149c5121791af54cd6c27c3458d81641fb522b3d
2021-11-22 09:03:17 +00:00
Jakob Ackermann
2261e761f4 Merge pull request #5705 from overleaf/jpa-node-14
[misc] upgrade node version from 12 to 14

GitOrigin-RevId: 15c465c7bb5e42b0c71e2dedb09cf4fe9f1d8ec6
2021-11-19 09:02:56 +00:00
Jakob Ackermann
159eff2097 Merge pull request #5700 from overleaf/jpa-re-generate-build-scripts
[misc] set mongo version in build_script templates and re-generate files

GitOrigin-RevId: 3338084025374f451b1208109407c688ddb68f0a
2021-11-08 09:03:20 +00:00
Jakob Ackermann
638fbd5510 Merge pull request #5573 from overleaf/jpa-prefer-regex-literals
[misc] fix eslint violations for prefer-regex-literals

GitOrigin-RevId: 216288af22b9eeb18cddace7ec285e0a8046f94a
2021-10-28 08:03:41 +00:00
Jakob Ackermann
f6795a324a Merge pull request #5572 from overleaf/jpa-no-path-concat
[misc] fix eslint violations for node/no-path-concat

GitOrigin-RevId: 5122826fb9ae23c373e8c5a6802ebb35eb20314f
2021-10-28 08:03:37 +00:00
Jakob Ackermann
669606f797 Merge pull request #5568 from overleaf/jpa-node-no-callback-literal
[misc] fix eslint violations for node/no-callback-literal

GitOrigin-RevId: af5aace52e1476b1b0ee48cc8be2aabbe04efac6
2021-10-28 08:03:33 +00:00
Jakob Ackermann
489df8360e Merge pull request #5523 from overleaf/jpa-no-loss-of-precision
[misc] fix eslint violations for no-loss-of-precision

GitOrigin-RevId: 06ecbeb5f10569933e99a472a92fd3efbe546278
2021-10-28 08:03:30 +00:00
Jakob Ackermann
7f9fd00bda Merge pull request #5367 from overleaf/jpa-node-handle-callback-err
[misc] fix eslint violations for node/handle-callback-err

GitOrigin-RevId: 83a4900e8861010df1917bff49382bd9c93375bd
2021-10-28 08:03:26 +00:00
Jakob Ackermann
5862359ff0 Merge pull request #5518 from overleaf/jpa-no-empty
[misc] fix eslint violations for no-empty

GitOrigin-RevId: 8fc1688ac28ccf29b830ba43cd6091e64b5e3b07
2021-10-27 08:03:14 +00:00
Jakob Ackermann
4cefebec5d Merge pull request #5517 from overleaf/jpa-no-dupe-else-if
[misc] fix eslint violations for no-dupe-else-if

GitOrigin-RevId: 5f72eb1d033322b2d419c1dbad29ea378ee776f5
2021-10-27 08:03:09 +00:00
Jakob Ackermann
0f529df1e4 Merge pull request #5360 from overleaf/jpa-array-callback-return
[misc] fix eslint violations for array-callback-return

GitOrigin-RevId: 4104342239f4da32c541855d6fc7032c4c96004f
2021-10-27 08:03:05 +00:00
Jakob Ackermann
a6f05109a3 Merge pull request #5352 from overleaf/jpa-no-var
[misc] fix eslint violations for `no-var`

GitOrigin-RevId: c52e82f3a8a993b8662cc5aa56e7b95ca3c55832
2021-10-27 08:03:00 +00:00
Brian Gough
43c381e4d5 Merge pull request #5552 from overleaf/bg-node-upgrade-other
upgrade node to v12.22.7 (other services)

GitOrigin-RevId: 889cf9a77173119fec8f200eeef9ddeefca0720b
2021-10-26 08:03:13 +00:00
Jakob Ackermann
9e24affe7a Merge pull request #5161 from overleaf/jpa-drop-errorhandler
[misc] drop errorhandler middleware

GitOrigin-RevId: e95628b6ba5808e4bf4c1df291b6d9eb91d9bc10
2021-09-21 08:03:17 +00:00
Henry Oswald
8197411cdf Merge pull request #4891 from overleaf/ho-web-mongo-4-2
bump mongo to 4.2.15

GitOrigin-RevId: 1ac2057f264bd6dbe042d8f999a4ab1054c9edf5
2021-09-15 08:03:54 +00:00
Brian Gough
e687230f8a Merge pull request #4992 from overleaf/bg-chat-npm-upgrades
upgrade chat dependencies

GitOrigin-RevId: 4497ae4f8b50d5432b62432bb973c0e1ecb872bb
2021-09-09 08:02:53 +00:00
dependabot[bot]
f4b2c083b0 Bump glob-parent from 5.1.0 to 5.1.2
Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.0 to 5.1.2.
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](https://github.com/gulpjs/glob-parent/compare/v5.1.0...v5.1.2)

---
updated-dependencies:
- dependency-name: glob-parent
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-07-13 14:23:35 +00:00
Jakob Ackermann
4893772089 [misc] upgrade node version to latest v12 LTS version 12.22.3 2021-07-13 12:26:35 +01:00
Jakob Ackermann
6bc592f829 [misc] temporary override a few new/changed eslint rules 2021-07-13 12:24:42 +01:00
Jakob Ackermann
1b7e5e6206 [misc] run format_fix and lint:fix 2021-07-13 12:04:48 +01:00
Jakob Ackermann
d6aee00057 [misc] upgrade build scripts to version 3.11.0 and cleanup packages
```
npm uninstall prettier-eslint-cli eslint-plugin-standard eslint-plugin-jsx-a11y eslint-plugin-react eslint-config-standard-jsx eslint-config-standard-react babel-eslint
npm dedupe
```
2021-07-13 11:55:19 +01:00
Jakob Ackermann
d840574084 [misc] run npm dedupe 2021-07-12 17:51:06 +01:00
Jakob Ackermann
b1123d3179 [misc] switch from settings-sharelatex to @overleaf/settings 2021-07-12 17:47:21 +01:00
Jakob Ackermann
91b130665a [misc] install bunyan as production dependency
```
Error: Cannot find module 'bunyan'
Require stack:
- .../node_modules/@google-cloud/logging-bunyan/build/src/middleware/express.js
- .../node_modules/@google-cloud/logging-bunyan/build/src/index.js
- .../node_modules/logger-sharelatex/logging-manager.js
- .../node_modules/logger-sharelatex/index.js
- .../app.js
```
2021-07-12 17:35:51 +01:00
nate stemen
0b5b8f56cb Merge pull request #73 from overleaf/dependabot-npm_and_yarn-hosted-git-info-2.8.9
Bump hosted-git-info from 2.8.8 to 2.8.9
2021-05-17 08:10:57 -04:00
nate stemen
a7c31132fe Merge pull request #72 from overleaf/dependabot-npm_and_yarn-lodash-4.17.21
Bump lodash from 4.17.20 to 4.17.21
2021-05-17 08:10:50 -04:00
nate stemen
007141f545 Merge pull request #71 from overleaf/jpa-explicit-dependencies
[misc] add linting for missing explicit dependencies and fix any errors
2021-05-17 08:10:43 -04:00
nate stemen
d1c2dd6cf1 Merge pull request #70 from overleaf/dependabot-npm_and_yarn-y18n-4.0.1
Bump y18n from 4.0.0 to 4.0.1
2021-05-17 08:10:32 -04:00
nate stemen
227b9e9ed8 Merge pull request #66 from overleaf/dependabot-npm_and_yarn-ini-1.3.8
Bump ini from 1.3.5 to 1.3.8
2021-05-17 08:10:17 -04:00
nate stemen
9b234e5946 Merge pull request #65 from overleaf/dependabot-npm_and_yarn-dot-prop-4.2.1
Bump dot-prop from 4.2.0 to 4.2.1
2021-05-17 08:10:08 -04:00
dependabot[bot]
fc48f8dd98 Bump hosted-git-info from 2.8.8 to 2.8.9
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9.
- [Release notes](https://github.com/npm/hosted-git-info/releases)
- [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md)
- [Commits](https://github.com/npm/hosted-git-info/compare/v2.8.8...v2.8.9)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-11 08:45:50 +00:00
dependabot[bot]
785a69bdb4 Bump lodash from 4.17.20 to 4.17.21
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.20...4.17.21)

Signed-off-by: dependabot[bot] <support@github.com>
2021-05-10 17:09:32 +00:00
Jakob Ackermann
6e123b873d [misc] add linting for missing explicit dependencies and fix any errors 2021-04-29 15:30:53 +01:00
dependabot[bot]
28b2d0ad87 Bump y18n from 4.0.0 to 4.0.1
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1.
- [Release notes](https://github.com/yargs/y18n/releases)
- [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md)
- [Commits](https://github.com/yargs/y18n/commits)

Signed-off-by: dependabot[bot] <support@github.com>
2021-03-31 03:00:58 +00:00
Eric Mc Sween
262385da84 Merge pull request #68 from overleaf/jpa-metrics-module-3-5-1
[misc] bump the version of the metrics module to 3.5.1
2021-03-18 11:32:45 -04:00
Eric Mc Sween
8b6f1f5750 Upgrade to Node 12 2021-03-12 14:44:55 -05:00
Jakob Ackermann
1705d3d133 [misc] bump the version of the metrics module to 3.5.1 2021-02-16 15:10:09 +00:00
Jakob Ackermann
9eb32e5900 [misc] bump the node version to 10.23.1 2021-01-05 18:38:55 +00:00
dependabot[bot]
3ea6677de8 Bump ini from 1.3.5 to 1.3.8
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
- [Release notes](https://github.com/isaacs/ini/releases)
- [Commits](https://github.com/isaacs/ini/compare/v1.3.5...v1.3.8)

Signed-off-by: dependabot[bot] <support@github.com>
2020-12-11 22:52:34 +00:00
dependabot[bot]
14466f7d85 Bump dot-prop from 4.2.0 to 4.2.1
Bumps [dot-prop](https://github.com/sindresorhus/dot-prop) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/sindresorhus/dot-prop/releases)
- [Commits](https://github.com/sindresorhus/dot-prop/compare/v4.2.0...v4.2.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-11-25 18:49:09 +00:00
Jakob Ackermann
8a93c6fea0 Merge pull request #64 from overleaf/jpa-bump-metrics-module
[misc] bump metrics module to 3.4.1
2020-11-25 17:20:21 +00:00
Jakob Ackermann
d482e0e4ee [misc] bump metrics module to 3.4.1
- renamed package from `metrics-sharelatex` to `@overleaf/metrics`
- drop support for statsd backend
- decaffeinate
- compress `/metrics` response using gzip
- bump debugging agents to latest versions
- expose prometheus interfaces for custom metrics (custom tags)
- cleanup of open sockets metrics
- fix deprecation warnings for header access
2020-11-25 11:57:24 +00:00
Eric Mc Sween
e3c1854eb4 Upgrade build-scripts to 3.4.0
This version fixes docker-compose health checks for dependent services. See
https://github.com/overleaf/dev-environment/pull/409 for details.
2020-11-24 08:03:28 -05:00
Simon Detheridge
8d8adba38c Merge pull request #55 from overleaf/dependabot-npm_and_yarn-lodash-4.17.20
Bump lodash from 4.17.15 to 4.17.20
2020-09-18 09:35:20 +01:00
Simon Detheridge
3c0ae226c4 Merge pull request #58 from overleaf/dependabot-npm_and_yarn-bl-2.2.1
Bump bl from 2.2.0 to 2.2.1
2020-09-18 09:35:11 +01:00
Simon Detheridge
8dd1082316 Merge pull request #61 from overleaf/dependabot-npm_and_yarn-node-fetch-2.6.1
Bump node-fetch from 2.6.0 to 2.6.1
2020-09-18 09:35:00 +01:00
Jakob Ackermann
f7879711ee [misc] bump the dev-env to 3.3.4 and bump the node version to 10.22.1 2020-09-17 13:36:26 +01:00
dependabot[bot]
ef11f1a1d1 Bump node-fetch from 2.6.0 to 2.6.1
Bumps [node-fetch](https://github.com/bitinn/node-fetch) from 2.6.0 to 2.6.1.
- [Release notes](https://github.com/bitinn/node-fetch/releases)
- [Changelog](https://github.com/node-fetch/node-fetch/blob/master/docs/CHANGELOG.md)
- [Commits](https://github.com/bitinn/node-fetch/compare/v2.6.0...v2.6.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-12 09:13:18 +00:00
Jakob Ackermann
918cd0bfbe [misc] mongodb: use the new db connector by default
mongojs was enabling it by default as well.
2020-09-10 10:09:30 +01:00
Jakob Ackermann
f6083a2d51 [misc] mongodb: refactor the process of setting up the db construct
Co-Authored-By: John Lees-Miller <jdleesmiller@gmail.com>
2020-09-10 10:08:30 +01:00
Jakob Ackermann
0cf5cad3b8 [misc] mongodb: drop the getCollection helper 2020-09-10 10:08:30 +01:00
Jakob Ackermann
4080784310 [misc] simplify mongodb collection access using a shared db construct
Resolve the getCollection Promises once and store the result in a shared
 `db` object which can get imported by all the call-sites.

The http server is starting only after a Promise of `waitForDb()`
 resolves. This covers the app code and the acceptance tests:
REF: 586706a9439c3591fc9613dc877f055096ca073a
REF: d026569d2eb4123e30c771a55a001b42d5ade72f
2020-09-10 10:08:30 +01:00
Jakob Ackermann
a52c0fe9fb [misc] mongodb: drop intermediate dbPromise
It would confuse the logic of a follow-up commit.
2020-09-10 10:08:23 +01:00
Jakob Ackermann
1b70189fb1 [misc] wait for the mongo connection before starting acceptance tests 2020-09-10 10:08:23 +01:00
dependabot[bot]
525216380e Bump bl from 2.2.0 to 2.2.1
Bumps [bl](https://github.com/rvagg/bl) from 2.2.0 to 2.2.1.
- [Release notes](https://github.com/rvagg/bl/releases)
- [Commits](https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-10 08:35:12 +00:00
Brian Gough
e08865646f upgrade from metrics-sharelatex to @overleaf/metrics 2020-09-09 10:37:56 +01:00
Jakob Ackermann
39ea30355e [misc] simplify the naming around waiting for a mongo connection
Co-Authored-By: Eric Mc Sween <eric.mcsween@overleaf.com>
Co-Authored-By: Miguel Serrano <mserranom@gmail.com>
Co-Authored-By: Simon Detheridge <s@sd.ai>
2020-08-24 17:41:03 +01:00
dependabot[bot]
851d4bda46 Bump lodash from 4.17.15 to 4.17.20
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.20.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.20)

Signed-off-by: dependabot[bot] <support@github.com>
2020-08-20 15:07:10 +00:00
Jakob Ackermann
959b5853a6 [misc] complete the connection setup before starting the http server 2020-08-19 13:06:22 +01:00
Jakob Ackermann
0c8f04a011 [misc] migrate to native mongo driver 2020-08-19 13:04:47 +01:00
Jakob Ackermann
4b3ed5e9b1 [misc] get rid of unsafe Buffer usage 2020-08-19 12:59:33 +01:00
Christopher Hoskin
0b1f61cb02 [misc] bump logger-sharelatex to version 2.2.0 2020-08-12 12:48:05 +01:00
Jakob Ackermann
e992166680 [misc] bump the dev-env to 3.3.2 2020-08-10 17:01:11 +01:00
Brian Gough
1dd24d1a4b update buildscript.txt to node 10.21.0 2020-06-03 11:09:57 +01:00
Brian Gough
c3345d6551 update to node 10.21.0 2020-06-03 10:22:19 +01:00
Ersun Warncke
686f0f0102 [misc] fix express deprecations
Co-Authored-By: Jakob Ackermann <jakob.ackermann@overleaf.com>
2020-04-15 18:43:23 +02:00
Jakob Ackermann
db30170228 [misc] bump logger-sharelatex to 1.9.1 2020-03-23 16:18:07 +01:00
mserranom
6f90684fa6 Removed morgan logger 2020-03-17 17:23:17 +01:00
mserranom
2afc0894bc updated to express 4 2020-03-06 19:33:17 +01:00
mserranom
d5e3f9b4c8 make format_fix 2020-03-06 19:17:40 +01:00
mserranom
3eb217402b fixed mongodb 3.x change requiring 2020-03-06 19:15:21 +01:00
mserranom
9bbc8c7483 updated mongojs 2020-03-06 17:47:30 +01:00
mserranom
5926aa511a updated mocha 2020-03-06 17:39:43 +01:00
mserranom
3f066ea757 updated ajv 2020-03-06 17:32:59 +01:00
mserranom
aaf68cd898 updated acorn and sinon 2020-03-06 17:31:40 +01:00
mserranom
d27275a3ab fixed linting 2020-03-06 17:03:17 +01:00
mserranom
6f931ee52b npm audit fix and minor+patch version upgrades 2020-03-06 17:00:47 +01:00
mserranom
267607995e updated build scripts to 1.4.0 2020-03-06 16:50:14 +01:00
Jakob Ackermann
2b276cdeba Merge pull request #38 from overleaf/jpa-dependencies-cleanup
[misc] cleanup dependencies
2020-02-14 10:55:36 +01:00