Commit graph

706 commits

Author SHA1 Message Date
M Fahru
8227199dcb Implement new users micro survey for project dashboard page on react and non-react version (#11347)
* Implement new users micro survey for project dashboard page on react and non-react version

* Add 'new-users-micro-survey-click' and 'new-users-micro-survey-prompt' new event for the analytics

GitOrigin-RevId: 9aabe931987638b38995d404aa90ac4d40b2f3b5
2023-01-20 14:13:53 +00:00
M Fahru
29fbc253fd Clean up link sharing upgrade prompt test and keep the default variant
GitOrigin-RevId: d34ed081bbc61dfc74a7117c0ba633db4b5a0bad
2023-01-20 14:13:51 +00:00
Eric Mc Sween
16627a18ef Merge pull request #11325 from overleaf/em-project-upload
Increase the upload project modal timeout

GitOrigin-RevId: 2c1ba1e792bb778c59c0a8bbadf96a0f84de96f7
2023-01-20 09:04:34 +00:00
Jessica Lawshe
7075a1e513 Merge pull request #11259 from overleaf/jel-react-subscriptions-dash-free
[web] Migrate institution free plan subscription dash to React

GitOrigin-RevId: 5f488bdeeb6db4a0895fe99218122220a2ee9561
2023-01-18 15:09:36 +00:00
Jessica Lawshe
c8ef5e6f65 Merge pull request #11231 from overleaf/jel-react-subscriptions-dash-commons
[web] Migrate institution memberships dash to React

GitOrigin-RevId: 75bb8e7d7338418733a836a8e654fe5b0a9fceff
2023-01-18 15:09:28 +00:00
Jakob Ackermann
59e587320a Merge pull request #11246 from overleaf/jpa-user-content-domain-access-check
[misc] prepare migration to user content domain

GitOrigin-RevId: 581ccab6d39ec021fb44a555a09e55441c35d0d1
2023-01-18 09:05:14 +00:00
Alf Eaton
f89361c02b Fix sorting for output files in PDF preview (#11267)
GitOrigin-RevId: 8e8c478c34bf5d58cdb5e44009b918d13ab6a104
2023-01-18 09:04:44 +00:00
Eric Mc Sween
56726053e8 Merge pull request #11158 from overleaf/em-recompile-pdf-split-test
Recompile PDF split test

GitOrigin-RevId: b02b3fb5b7a979ac299358e276ed432d736c7a03
2023-01-17 09:06:12 +00:00
Brian Gough
95bb5ca4e4 Merge pull request #11002 from overleaf/msm-fix-email-suggestion
[web] Fix clearing suggestions in email input

GitOrigin-RevId: c821114e2112bf066f4ee5f01304321db983bc4e
2023-01-17 09:04:43 +00:00
Jakob Ackermann
6154db8f92 Merge pull request #11236 from overleaf/jpa-pdf-caching-fix-size-estimation
[web] pdf-caching: fix estimation of multipart response size

GitOrigin-RevId: 5929cc1e413befb3f931889b38a4b21a7ed4cea8
2023-01-17 09:04:05 +00:00
M Fahru
e855b96953 Only disable closing the modal by clicking outside of its element when inflight
GitOrigin-RevId: 9e9f24aed6442a892ed95c1ee598fc82ec931a1b
2023-01-13 09:05:00 +00:00
ilkin-overleaf
7e68b4f0d5 Merge pull request #11147 from overleaf/ii-subscriptions-pages-react-split-test
[web] React subscription split test

GitOrigin-RevId: 6656b3895030bc677483a3e30d5e998f5f7d1458
2023-01-13 09:04:52 +00:00
Alf Eaton
017f0b49a0 [rich-text] Add "rich-text" split test (#11180)
GitOrigin-RevId: 8df79f3c70020c8dba0793c8b548fd1f1e1fbf76
2023-01-13 09:04:31 +00:00
Jessica Lawshe
fe34b650e3 Merge pull request #11132 from overleaf/jel-btn-info
[web] Use new button style for download button in file view in editor

GitOrigin-RevId: 33e8c1aeb21a6ba083a5b9ada3d3135916e64e26
2023-01-12 09:03:43 +00:00
M Fahru
82cd2d2a77 perform null check on the old value instead of the new one since to follow the non-react version behaviour
GitOrigin-RevId: 33ef74e1b1da41db8a86fc79ae04fbe49ed194df
2023-01-11 09:10:00 +00:00
M Fahru
94ab78b427 Log error in a promise catch block
GitOrigin-RevId: 09756d52bd6351c55051a74f22f38c450af9a275
2023-01-11 09:09:51 +00:00
M Fahru
7475237170 Refactor project-wide settings:
- Change api function argument (readability)
- create a new wrapper hooks for saving the project to both server-side and angular scope
- Implement the new save project settings hooks on project-wide settings update
- On spell check language update function, add new comment to give more context about the decision

GitOrigin-RevId: 93d558d1e1d4db265a943eeb4366842430900c43
2023-01-11 09:09:40 +00:00
M Fahru
654144dd40 Refactor saveUserSettings: Move sendMB inside the function and change function from supporting multiple settings to only support single key/value pair.
GitOrigin-RevId: 77b9d8fd5cdcbc78f38fd42329b74cf592615638
2023-01-11 09:09:32 +00:00
M Fahru
4444377b11 fix tsc error by re-creating request body object instead of directly assigning it from function argument
GitOrigin-RevId: b17697c7b52c991a06efcbffa0227b6021c5bc8d
2023-01-11 09:09:25 +00:00
M Fahru
b2cf833e9d Remove scope suffix from variable name in react-related files since it's an angular-specific concept
GitOrigin-RevId: b8eea8c8113a977f6cbe07649e1338eea8281841
2023-01-11 09:09:18 +00:00
M Fahru
03e5614969 Remove _csrf in request body since fetchJSON already have X-Csrf-Token set in request header
GitOrigin-RevId: 9dd2389c47ce3537fc4bb22bd8b6b0b83862c5f4
2023-01-11 09:09:11 +00:00
M Fahru
4548f504f7 standardize the naming for rootDocId.
- Remove the `scope` variable suffix
- change `rootDoc_id` to `rootDocId`

GitOrigin-RevId: d8e646ef5f99ba0dbce84ff63c588e63b956a4ec
2023-01-11 09:09:04 +00:00
M Fahru
bdf3b18d4f Change import to import type for type imports
GitOrigin-RevId: 2061bafeca58d063f83a96650403e5741b863c05
2023-01-11 09:08:57 +00:00
M Fahru
608b75c9db Fix linter error because of wrong variable name and camel case issue
GitOrigin-RevId: a5ea8d6c8332133303fcd8e410cc76ac06c5bb97
2023-01-11 09:08:49 +00:00
M Fahru
e3d0380e6f Remove multiple source of type imports; add type on type imports.
GitOrigin-RevId: a6630bb284c456bfbe61901f7331cdd3c13c7f8b
2023-01-11 09:08:42 +00:00
M Fahru
12f5c845b4 Simplify function by removing generic
GitOrigin-RevId: 7732b6782cd1e0130eb56f6b674c03548b8e8315
2023-01-11 09:08:35 +00:00
M Fahru
10bb724197 Fix wrong hook name
GitOrigin-RevId: 58f98b508cf650a6ecab38772faf9ecd38c9a7bc
2023-01-11 09:08:28 +00:00
M Fahru
f2060b35ad Refactor type by reusing type declaration and avoid multiple source of the same type
GitOrigin-RevId: 492a9a524e566cf70b53158b4e5cc6ad57cb6093
2023-01-11 09:08:21 +00:00
M Fahru
f85d17f894 Remove disabling update while listening on socket (ignoreUpdates state) since the logic is more complicated that was originally thought and it will be tested/revisited on a different PR
GitOrigin-RevId: 70cee2f0fc565aaebfb3ead2dd1a58fc5371c816
2023-01-11 09:08:13 +00:00
M Fahru
677ec173ed Disable updating project-wide settings while socket is currently listening to update project-wide settings in a project.
This may happen if the project is being used by multiple people, and we want to avoid race condition on the update since it's possible for multiple people to update setting value at the same time.

GitOrigin-RevId: cdad6a6456e2d9e4ef1812ebfd6f6ef59f23747f
2023-01-11 09:08:06 +00:00
M Fahru
af01ace5a0 refactor function by simplifying function argument (from two arguments to a single object)
GitOrigin-RevId: e4244a07a4ca196afa226e3fac9de74d30f7d4ea
2023-01-11 09:07:59 +00:00
M Fahru
777beaadc3 Don't send spellCheckLanguage request if the old value is the same as the new one
GitOrigin-RevId: 4ef34be7563ff707b6abd44dc8034293c88d2f72
2023-01-11 09:07:52 +00:00
M Fahru
ae5a08e680 Add 'setting-changed' tracking when user changes user-wide settings
GitOrigin-RevId: 04ed66dcdff7fa04e783fe4028505d981a39b37b
2023-01-11 09:07:45 +00:00
M Fahru
85cbc5b721 Apply prettier
GitOrigin-RevId: 34c7e3b95d061c270c77337c7c82502af289b556
2023-01-11 09:07:38 +00:00
M Fahru
06b0833e33 Add a comment explaining why user settings may be undefined
GitOrigin-RevId: 4460d4184cde5639d326da07121b2728d444c782
2023-01-11 09:07:30 +00:00
M Fahru
5597736057 Fix numerous test fails because of unitialized user settings scope on the test environment
GitOrigin-RevId: a27454285b0c89c6abef560f05c52d35f81fa570
2023-01-11 09:07:23 +00:00
M Fahru
56395d9a95 Save spellCheckLanguage to both project-wide and user-wide setting
GitOrigin-RevId: 059cc64d0fe2e955814a7192f82d4ff8ea4e2572
2023-01-11 09:07:16 +00:00
M Fahru
4bf09e21de Fix tsc lint error by restricting the generic type
GitOrigin-RevId: 11ef7ab4111c7b312b283283829e9b28a80c475c
2023-01-11 09:07:09 +00:00
M Fahru
98fbd330b2 Add socket listener for compiler, imageName, and spellCheckLanguage
GitOrigin-RevId: b12644152387e479e433a014e1a1041ebae36f12
2023-01-11 09:07:02 +00:00
M Fahru
b6b6b9c4b1 Rename "rootDoc_id" to "rootDocId" before sending it to server
GitOrigin-RevId: fc29e152ffd3bf97c00ee817abb07086f6cdfe17
2023-01-11 09:06:54 +00:00
M Fahru
30c32713c6 Add _csrf to request body
GitOrigin-RevId: 87b5a7299fbb795618143421df79375b41f8f921
2023-01-11 09:06:47 +00:00
M Fahru
132bb40a21 replace save project setting hooks with common function and implement set root doc id change
GitOrigin-RevId: e5b204cd93fc188288def529cb22018b3d4f89b6
2023-01-11 09:06:40 +00:00
M Fahru
8ae9839f79 apply prettier
GitOrigin-RevId: dd750756d2bfc625817760510e9bdbade186aef3
2023-01-11 09:06:33 +00:00
M Fahru
c2b0707c2a Change variable declaration location + apply prettier
GitOrigin-RevId: 3237a417c23d5c66c47385e55f8d3cb68bdfc3ca
2023-01-11 09:06:26 +00:00
M Fahru
414540af5c Reduce save/setScope user setting duplication by introducing a new shared hooks
GitOrigin-RevId: 6054143eb042e4ff336b1f325a8cef693ae8c4bd
2023-01-11 09:06:19 +00:00
M Fahru
09b1974a3d Migrate updating overallTheme to react
GitOrigin-RevId: 024ceb3c32c8d90ac0067fbb72d6e7d327b869f0
2023-01-11 09:06:12 +00:00
M Fahru
6c41a65200 migrate user-wide settings post request from angular controller to react
GitOrigin-RevId: b5440178a11b82c5a5840eb310416f1519f85bae
2023-01-11 09:05:57 +00:00
M Fahru
f01a2920cf Migrate editor settings controller to react (this commit includes project-wide settings)
GitOrigin-RevId: 8c47a2699a2f11fda7fd60c5173bf2e29858e37a
2023-01-11 09:05:50 +00:00
M Fahru
67c8fa560e Fix firefox bug where user can't focus on input while renaming file on editor file tree (#11134)
GitOrigin-RevId: daebbe6df4a3fef41cbf25444a31015d306901b3
2023-01-11 09:05:43 +00:00
M Fahru
5f8e10de86 Conform with new design system by changing btn-default to btn-secondary (#10972)
GitOrigin-RevId: 1fac39d3b1e7e68e6feffe467ac21b4cb3253353
2023-01-11 09:05:36 +00:00