Commit graph

1809 commits

Author SHA1 Message Date
Miguel Serrano
78314a0ee0 [web] Fix Null Pointer Error in WikiController in SP (#13393)
* [web] Fix NPE in WikiController

This error prevents the wiki from retrieving
page content in Server Pro

* [web] add `settings.proxyLearn` to SaaS config

GitOrigin-RevId: d137097e08720e8423133a7f59e2fe619fe134be
2023-07-17 10:42:41 +00:00
Domagoj Kriskovic
2ab0779374 [cm6] rename to Code Editor | Visual Editor (#13513)
* [cm6] rename to Code Editor | Visual Editor

* showLegacySourceEditor change

* show info badge

* remove info badge

* display info badge

* use "Visual Editor" in example project

GitOrigin-RevId: 549e25aa4bcfe58522eadc70e35ca35f822317b1
2023-07-17 10:39:10 +00:00
M Fahru
2e77d4ab65 Teardown onboarding video tour test (#13351)
GitOrigin-RevId: 215c26fe047ec037f8d1d878eac406c36dbb656b
2023-07-17 10:32:51 +00:00
ilkin-overleaf
9b930d2849 Merge pull request #13414 from overleaf/ii-review-panel-migration-create-context-api-fix
[web] Create context api for review panel FIX

GitOrigin-RevId: fc6d8adf18d07e71b529a28deab4d49d62c43587
2023-07-17 10:32:07 +00:00
Miguel Serrano
7e6613a1a0 Merge pull request #13327 from overleaf/msm-web-track-changes-cleanup
[web] Cleanup track-changes from web

GitOrigin-RevId: 8cef709ec5e91e4ffe8cd06826038ed84f36ef67
2023-07-17 10:28:12 +00:00
ilkin-overleaf
2fceaa6085 Merge pull request #13343 from overleaf/ii-review-panel-migration-create-feature-flag
[web] Create feature flag for review panel

GitOrigin-RevId: e7e83729a536dce1824f604fb66afe1785f4be25
2023-07-17 10:26:04 +00:00
M Fahru
8c549aa0fa Implement new welcome page UI with split test (#11677)
GitOrigin-RevId: 3028ee5e34802e4f9a29cb752fcfa8ca6d5c284c
2023-06-01 08:05:01 +00:00
ilkin-overleaf
bb815268f2 Merge pull request #13146 from overleaf/ii-history-react-save-last-selected-file-in-local-storage
[web] Save lastly selected file in the file tree

GitOrigin-RevId: 4b4dcdcb1340e253d4cd2003280f67385975d664
2023-05-31 08:04:59 +00:00
M Fahru
3e315eada1 Teardown old project list frontend code (#11950)
* Remove frontend project list angular code (pugfiles + controllers)

* Remove unused translation keys in every language

GitOrigin-RevId: e0514721d6a32ca2de7d1be9433da3476ba1680c
2023-05-26 08:05:02 +00:00
Jakob Ackermann
29b951e705 Merge pull request #13084 from overleaf/ds-jpa-system-messages-html-escape
[web] escape HTML content in system messages as rendered via angular

GitOrigin-RevId: 88e711a1c6f4f9f70c09ca723893a48a0ec262c1
2023-05-16 08:05:30 +00:00
Alexandre Bourdin
caeceba28c [web] INR Geo pricing test (#12976)
* Implement INR geopricing test

* Show again the INR banner after 30 days

* Update INRBanner to direct users to the plans page and add tracking

* Remove local testing hack in GeoIpLookup

* Update formatter for subscription dashboard

* Flip assignment to assign all users and add event segmentations

* Fix linting

* Review suggestions - factorised recommended currency helper function

GitOrigin-RevId: b1616520f8c7ead689a840720057297e67d3f574
2023-05-11 08:03:59 +00:00
Alf Eaton
4e6749966e Add Writefull promo banner to project list (#12843)
GitOrigin-RevId: a41746a29dfba867ff60401cfce1478812358644
2023-05-10 08:05:37 +00:00
Miguel Serrano
c2dce961b9 Merge pull request #12901 from overleaf/msm-oauth-token-flags
[web] Feature flags for Personal Access Tokens

GitOrigin-RevId: cb359b7c41d8875ebae7d78a8839528bc4adc04c
2023-05-08 08:04:55 +00:00
Domagoj Kriskovic
3d5e8c9877 add 'Ace removal' notification (#12800)
* add 'Ace removal' notification

* prettier

* add memo, window.clearTimeout

* remove warning for server pro

* added tracking events

* useCallback for onClick

* fix: event rename

GitOrigin-RevId: 70bce8b93bae233e7183a941abaf2ec7a70ddfb6
2023-04-28 08:04:19 +00:00
Alf Eaton
08ccdb79d3 [cm6] Improve alignment of review panel elements (#12710)
* Use a block widget for top padding
* Update review panel positions when the editor geometry changes
* Remove editorPaddingTop from position calculations
* Recalculate review panel on start adding comment
* Assert on line content rather than index
* Use broadcastChange
* Keep focus in the editor when opening the review panel
* debounce broadcastChange
* Set CULL_AFTER to Infinity

GitOrigin-RevId: a8d7b8967736a9164b5264eeaadf334c15ec95ce
2023-04-25 08:05:02 +00:00
M Fahru
08d2eea47a Decouple history-file-tree styling out of editor file tree:
- Extract/duplicate the style from editor file tree (only extract styling that's being used in history file tree)
- Change some of the class name to avoid duplicated class name from the editor file tree
- Revert change to editor file tree since it has been moved to history file tree

GitOrigin-RevId: 6c3b20080c9b428363024db622f60e3540d919e6
2023-04-21 08:03:36 +00:00
Mathias Jakobsen
c8f7bc54bc [web] Add split test for testing editor switch naming (#12596)
Co-authored-by: Ieva Vaiginyte <95856891+ievaoverleaf@users.noreply.github.com>
GitOrigin-RevId: dafe07bda841dad962ebf2894718750fafe86373
2023-04-18 08:04:59 +00:00
Tim Down
7f37ba737c Move source editor out of module (#12457)
* Update Copybara options in preparation for open-sourcing the source editor

* Move files

* Update paths

* Remove source-editor module and checks for its existence

* Explicitly mention CM6 license in files that contain code adapted from CM6

GitOrigin-RevId: 89b7cc2b409db01ad103198ccbd1b126ab56349b
2023-04-13 08:40:56 +00:00
M Fahru
3f992f9453 Ensure new data are fetched properly whenever history is opened (#12577)
GitOrigin-RevId: e0ae14cdc90c95dbd44b12bd8332bc982ea34a10
2023-04-13 08:04:45 +00:00
ilkin-overleaf
dfda9d0677 Merge pull request #12434 from overleaf/ii-history-react-feature-flag
[web] Fix history view feature flag

GitOrigin-RevId: af2e76074ed43ec1ed1b877a6ffd403abab48ec8
2023-04-04 08:03:50 +00:00
M Fahru
568092e16b Add react file tree UI to history view (#12357)
* Add react file tree UI to history view

* Use history data from API to render react file tree in history view

GitOrigin-RevId: 2b1eb5422f0c91fdf5e87e21d1e5d06defd45e98
2023-03-30 08:04:17 +00:00
Tim Down
e76bcbec8d Merge pull request #12316 from overleaf/td-history-view-shell-and-split-test
Add empty shell for React history view, viewable based on split test

GitOrigin-RevId: 97241d56a052648c7a0d293d323dad4b00ad4159
2023-03-23 09:04:38 +00:00
M Fahru
5ae698ec6c Migrate "Manage Template" in editor left menu to react (#10609)
This feature is only available on server pro

GitOrigin-RevId: 7fc508c8039c2e3afd1a5fca469fce411e9d913a
2023-03-21 09:05:29 +00:00
M Fahru
f7131b720b Implement onboarding video tour split test (#11889)
* Implement onboarding video tour split test:

- Add split test infrastructure
- Create new `OnboardingVideoTourModal` component
- Place the component inside the editor pug template with a split test

* add event segmentation for `onboarding-video-tour-close-button-click` event:

1. video: `first` | `second`
2. firstVideoWatchingTimeInSecond: total time watching first video
2. secondVideoWatchingTimeInSecond: total time watching second video (0 if skipped)

* add event segmentation for:

1.  `onboarding-video-tour-dismiss-button-click`
2. `onboarding-video-tour-next-button-click`
3. `onboarding-video-tour-done-button-click`

with these key/value:

1. firstVideoWatchingTimeInSecond: total time watching first video
2. secondVideoWatchingTimeInSecond: total time watching second video (0 if skipped/not watched yet)

* Use contentful to host video assets

GitOrigin-RevId: 27a6f38d15d7a03b07455e216dda63d99983ca80
2023-03-02 09:05:43 +00:00
Thomas
16b2d27fde Update B2B Groups and Enterprise banners (#11989)
* Tear down B2B banner ad split test and implement updated ads

GitOrigin-RevId: 7d09d54bef7cb4e2b2b597d3834e0f58551b179e
2023-02-28 09:04:31 +00:00
M Fahru
47937c4073 Fix event "left-menu-documentation-click" not being fired properly (#11836)
GitOrigin-RevId: 5e9df12c699ff5c25389e8fb90fda73913e8c747
2023-02-16 09:05:00 +00:00
Davinder Singh
de245c288a Merge pull request #11653 from overleaf/ds-documentation-btn-on-editor
Adding documentation button on the editor

GitOrigin-RevId: e03fd7b931eb0fe7273e6e9d0185c81c384df916
2023-02-15 09:04:37 +00:00
Miguel Serrano
286cbc66a8 Merge pull request #11771 from overleaf/msm-force-ace-sp
[web] Force Ace editor in Server Pro

GitOrigin-RevId: 1ea5675ad1c64a15dc30566c02d694feb2aaed3c
2023-02-10 09:12:26 +00:00
M Fahru
6da0a8ddf7 Clean up old new file modal since it has been migrated fully to react (#11755)
GitOrigin-RevId: f17aea302d4bac932877ed0b2d733633328ff469
2023-02-10 09:03:51 +00:00
M Fahru
5f3ef71e43 Implement 'Add Affiliation' UI on the mobile version of the new react dashboard (#11606)
* Refactor & change `add-affiliation.tsx` file:
    * Change class from `user-profile` to `add-affiliation`
    * Add new optional `className` props for custom styling

* Show affiliation widget on mobile screen:

* Fix bug on use add affiliation hooks: return type should be `boolean`, not `boolean | 0`

GitOrigin-RevId: 800b951e2a012797266b1780993b4ed9a918d565
2023-02-08 09:07:23 +00:00
Alf Eaton
85fbded781 Improve the Rich Text toolbar (#11616)
GitOrigin-RevId: d1999be629ac048058ffd82004865728796a3feb
2023-02-07 09:04:39 +00:00
Miguel Serrano
55bdcf7664 Merge pull request #11583 from overleaf/msm-ace-ce
[web] Force ACE when `modules/source-editor` not available

GitOrigin-RevId: 2b43a048e882d99aa52ee8ead6c67152d4080eb2
2023-02-02 09:03:30 +00:00
M Fahru
772a3efb65 Tear down micro survey for new users (#11569)
GitOrigin-RevId: b86cfa150dd365f3d1da758feb20509d35c7cc56
2023-02-02 09:03:22 +00:00
M Fahru
78304e7c94 Add is-screen-width-less-than-768px to the upgrade-button-click event (#11506)
GitOrigin-RevId: 33ae53d7959863017607d3e1ea237602aed626dc
2023-01-31 09:04:09 +00:00
M Fahru
3507463c4e Add new event tracking to react and angular version of the empty project page (#11472)
GitOrigin-RevId: 28ffe919851121bdba82eea3b6ef29cd6fffeb76
2023-01-31 09:04:01 +00:00
Tim Down
a05438d9c7 Merge pull request #11332 from overleaf/td-remove-ace-split-test
Add handling for source-editor-legacy split test

GitOrigin-RevId: 9575087c34bc3f2e8b490846984bc97641c560aa
2023-01-25 09:06:26 +00:00
M Fahru
435be3073f Add new event segmentations for upgrade button in dashboard to help analytics (#11345)
* Add new event segmentations for the upgrade button in dashboard to help analysis

* Also add an extra check for the upgrade button in the navbar since it's only appeared in the project dashboard react version

GitOrigin-RevId: fca14e3adfbafd0fd143b045ba43588913f7297b
2023-01-24 09:06:09 +00:00
Alf Eaton
cf8051dcad Advertise CM6 Rich Text in the CM5 track changes panel (#11361)
GitOrigin-RevId: 3d2e43263528c64292a01afb3d032e11a6cbbfb9
2023-01-24 09:04:13 +00:00
Alf Eaton
8b610d2d1c Use MathJax v3 on the editor page (#11330)
GitOrigin-RevId: 5e51404c54e49735988f399ea080b6cb4be726d3
2023-01-24 09:03:58 +00:00
M Fahru
8227199dcb Implement new users micro survey for project dashboard page on react and non-react version (#11347)
* Implement new users micro survey for project dashboard page on react and non-react version

* Add 'new-users-micro-survey-click' and 'new-users-micro-survey-prompt' new event for the analytics

GitOrigin-RevId: 9aabe931987638b38995d404aa90ac4d40b2f3b5
2023-01-20 14:13:53 +00:00
Jakob Ackermann
59e587320a Merge pull request #11246 from overleaf/jpa-user-content-domain-access-check
[misc] prepare migration to user content domain

GitOrigin-RevId: 581ccab6d39ec021fb44a555a09e55441c35d0d1
2023-01-18 09:05:14 +00:00
Alf Eaton
017f0b49a0 [rich-text] Add "rich-text" split test (#11180)
GitOrigin-RevId: 8df79f3c70020c8dba0793c8b548fd1f1e1fbf76
2023-01-13 09:04:31 +00:00
Jessica Lawshe
e391a9fc46 Merge pull request #11079 from overleaf/jel-features-link-analytics
[web] Add analytics to features link

GitOrigin-RevId: 80cbba05dfc94bce0b2f0b25a41ac76c8d22eee6
2023-01-12 09:03:38 +00:00
M Fahru
9452bee1b4 add newline
GitOrigin-RevId: f8c4054cbbaf935b50f06f51d19358e3560d0e74
2023-01-11 09:06:05 +00:00
M Fahru
f01a2920cf Migrate editor settings controller to react (this commit includes project-wide settings)
GitOrigin-RevId: 8c47a2699a2f11fda7fd60c5173bf2e29858e37a
2023-01-11 09:05:50 +00:00
Mathias Jakobsen
38cc3394e3 Merge pull request #10793 from overleaf/mj-split-test-cleanup
Split test clean-up

GitOrigin-RevId: 7dd6178487022cbefcbc85797dacc3f3fbfa17e2
2022-12-21 09:04:04 +00:00
Jessica Lawshe
d7233870b9 Merge pull request #10891 from overleaf/jel-features-page-test
[web] Setup split test for new features page

GitOrigin-RevId: c301089f2a251fef6cdc4434ac3c8356bb17545d
2022-12-20 09:04:44 +00:00
M Fahru
bed2596468 Implement groups & enterprise awareness banner on project dashboard (#10818)
- Implement the banner on both react and non-react project dashboard
- Use split test with 4 different variants, `save`, `empower`, `did-you-know`, and `default`, each variant has a different copy, except the `default` which won't show the banner to users

GitOrigin-RevId: ee76769dfd38b8e52de8cc0f201c24e41905d016
2022-12-13 09:05:08 +00:00
Davinder Singh
4adfca52bf Merge pull request #10682 from overleaf/ds-btn-default-to-secondary-in-editor-part-2
Replacing btn-default with btn-secondary in the editor Part-2

GitOrigin-RevId: 708aa29070bb3049afbc8ee1a282eaa1018594a8
2022-12-08 09:03:42 +00:00
Davinder Singh
d6b39c4bb3 Merge pull request #10653 from overleaf/ds-btn-default-to-secondary-in-editor
Replacing `btn-default` with `btn-secondary` in the editor

GitOrigin-RevId: 46aa8c92c9981eb2f253828ee65424bfb7217fb2
2022-12-08 09:03:35 +00:00