Commit graph

22835 commits

Author SHA1 Message Date
Mathias Jakobsen
8c6c67564f Merge pull request #18778 from overleaf/mj-web-chat-restore-tests
[chat+web] Add tests for revert functionality

GitOrigin-RevId: f10a5589d8ee1299949ef3decd8325d8fa1f7d41
2024-06-11 08:04:51 +00:00
Liangjun Song
b9b9090155 [web] implement in-house sha1 hash function (#18769)
* Revert "Revert "[web]implement in-house sha1 hash function (#18651)" (#18703)"

This reverts commit b2be3907439525f3ed49baec0b438ba35ea1663c.

* fix bug

* better tests

GitOrigin-RevId: 4b0e0337687eeee3086ba0ec38d9dc7ccb3f30ea
2024-06-11 08:04:39 +00:00
Liangjun Song
0680a91a70 [web] fix incorrect event group-subscription-left (#18757)
GitOrigin-RevId: aa342dc6575eca032834c2b132d4d0144a4faa27
2024-06-11 08:04:35 +00:00
Mathias Jakobsen
0ea04db53b Merge pull request #18818 from overleaf/revert-18816-revert-18815-revert-18671-mj-left-modal
Revert "[web] Make left menu modal show below other modals"

GitOrigin-RevId: 0b48ac1dc7f24986cc665b63eb5fe097e6a7e703
2024-06-11 08:04:30 +00:00
Mathias Jakobsen
e7f429a5c1 Merge pull request #18816 from overleaf/revert-18815-revert-18671-mj-left-modal
Revert "Revert "[web] Make left menu modal show below other modals""

GitOrigin-RevId: aaa51e251826c713ef0f46616ce8780d525d6430
2024-06-11 08:04:26 +00:00
Mathias Jakobsen
8596fa21f2 Merge pull request #18815 from overleaf/revert-18671-mj-left-modal
Revert "[web] Make left menu modal show below other modals"

GitOrigin-RevId: d48649fadd0c0e1694e295d850e4900aaaac38fd
2024-06-11 08:04:22 +00:00
David
eb9044bc9b Merge pull request #18806 from overleaf/dp-revert-18445
Remove workaround for chrome pdf rendering bug that has since been fixed

GitOrigin-RevId: 622f04d6dad848dc725e0f1776ea37436a60dc63
2024-06-11 08:04:17 +00:00
Jakob Ackermann
fb2e3b3a25 Merge pull request #18770 from overleaf/jpa-fph-migration-docs
[web] add documentation for full project history migration check

GitOrigin-RevId: 4a7e5a734d7fd4a2ca0a4315f57929809937e842
2024-06-11 08:04:13 +00:00
Jakob Ackermann
fb27046936 Merge pull request #18767 from overleaf/jpa-fix-frontend-test-split
[web] fix test_frontend_ct_core/editor split when running locally

GitOrigin-RevId: 657542b684a8d24b931fede056e1b7ffd8f07fb8
2024-06-11 08:04:09 +00:00
Antoine Clausse
262a92083a Don't throw cron job when some PayPal collection fails (#18795)
* Don't throw cron job when some PayPal collection fails

Follow-up of https://github.com/overleaf/internal/pull/18414 and https://github.com/overleaf/internal/pull/18572

This was causing `Heartbeat [cron-web-collect-paypal-prod] is expired.`
And the cron to rerun (altogether three times a day, instead of once a day)

https://cloudlogging.app.goo.gl/W4qBPFDeTUkRQ8J27

* Update tests

GitOrigin-RevId: a6a29cc84c0c72fd86b2e3a9739669d3a5fb0be5
2024-06-11 08:04:04 +00:00
Mathias Jakobsen
c29c151c9f Merge pull request #18803 from overleaf/revert-18801-mj-revert-big-deploy
[web+chat] Redo deploy

GitOrigin-RevId: a056bf20d49a39e71e03db740f57e8506dfc6b71
2024-06-11 08:03:59 +00:00
CloudBuild
e67a2b92a8 auto update translation
GitOrigin-RevId: b30c8a6f7a065d3ff719b323cc7827e135cade0d
2024-06-10 08:04:42 +00:00
John Lees-Miller
05ac4b956d Merge pull request #18812 from overleaf/mj-mathjax-unicode
[web] Disable mathjax unicode package

GitOrigin-RevId: 0c42a7a531576af35c31377068763bee4674394d
2024-06-10 08:04:38 +00:00
Mathias Jakobsen
a26e3d3376 Merge pull request #18801 from overleaf/mj-revert-big-deploy
[web+chat] Revert big deploy

GitOrigin-RevId: f4d068cbea7e5f5d59a3d698e2def2f94c9b6322
2024-06-10 08:04:33 +00:00
Mathias Jakobsen
d470093174 Merge pull request #18737 from overleaf/mj-chat-revert-existing-file
[web] Revert existing file by deleting it first

GitOrigin-RevId: ec9ed5c709c2631ff08dbc2e0f3633d303f12836
2024-06-10 08:04:29 +00:00
Mathias Jakobsen
110b83aea0 Merge pull request #18710 from overleaf/mj-web-chat-send-thread-data
[chat+web] Inform frontend when duplicating threads

GitOrigin-RevId: 285afee8f5a016a8e7ac58e9538cc3ec8362681d
2024-06-10 08:04:25 +00:00
Mathias Jakobsen
0f869f9059 Merge pull request #18654 from overleaf/mj-web-duplicate-threads
[web] Ensure single doc pointing to comment when reverting

GitOrigin-RevId: e86e566e1b21eed18bb08b285befcab0e740ec45
2024-06-10 08:04:20 +00:00
Mathias Jakobsen
304f572f9c Merge pull request #18637 from overleaf/mj-chat-duplicate-threads
[chat] Add endpoint for duplicating comment threads

GitOrigin-RevId: 0b3fb1b836150ccb6d213ab2bba6ce7ff6c69b4a
2024-06-10 08:04:16 +00:00
Mathias Jakobsen
f0eba8e742 Merge pull request #18676 from overleaf/mj-web-linter-document-class
[web] Allow underscore in optional argument in \documentclass

GitOrigin-RevId: c6f8716548411ade03814c8123df76fa8aa70ecc
2024-06-10 08:04:11 +00:00
Mathias Jakobsen
2247f02308 Merge pull request #18671 from overleaf/mj-left-modal
[web] Make left menu modal show below other modals

GitOrigin-RevId: 1f3267ef5e0e6d8152dbe1f74218e72053b41360
2024-06-10 08:04:07 +00:00
David
ca41c42288 Merge pull request #18762 from overleaf/dp-pdf-improvements
PDF Toolbar usability improvements

GitOrigin-RevId: 138e42cad0c9c97cfe45eb00fb123084e0228fdd
2024-06-10 08:03:55 +00:00
CloudBuild
249cb69074 auto update translation
GitOrigin-RevId: a253ed0c7e36f3dd23f7353cf907276e0d7de4e6
2024-06-07 08:04:36 +00:00
M Fahru
671b7fd0d9 Merge pull request #18749 from overleaf/mf-render-new-plans-page-based-on-screen-size
[web] Create a configuration to render new plans page content based on screen width

GitOrigin-RevId: 64e1eba3a44665c6f58b432ff46a8b5e5a9f2cfa
2024-06-07 08:04:32 +00:00
M Fahru
0f783a7346 Merge pull request #18652 from overleaf/mf-create-main-tab-new-plans-page
[web] Create new plans page tabs and period switcher

GitOrigin-RevId: 2dfea413fdcbbca8e90c1ab76844f35b2da4bd62
2024-06-07 08:04:28 +00:00
Tim Down
29837ec838 Merge pull request #18733 from overleaf/td-bs5-button-props
Simplify handling of BS3 props in button wrapper component

GitOrigin-RevId: 12a6b1374da5084e075775f3cef23f0b24d098fc
2024-06-07 08:04:24 +00:00
Eric Mc Sween
c070c036af Merge pull request #18747 from overleaf/em-update-compressor-comment-ids
Propagate commentIds in UpdateCompressor

GitOrigin-RevId: 03315146c2dc816d02e69594df44d0d25f7952ca
2024-06-07 08:04:13 +00:00
CloudBuild
a732130633 auto update translation
GitOrigin-RevId: 4846fd5b557342c25025f6c504fbd14641ac85c4
2024-06-06 08:05:15 +00:00
M Fahru
5b29729e9b Merge pull request #18714 from overleaf/mf-fix-group-plan-modal-hash-plans-table
[web] Fix loading plans page with group plan modal hash (#groups) does not enable the group plan table

GitOrigin-RevId: acd2e683d8e8d3f2b3325c3745856fe27c96eed6
2024-06-06 08:05:10 +00:00
Jessica Lawshe
d7b64ef92e Merge pull request #18718 from overleaf/jel-isSplitTestActive-plans-page
[web] New plans page variants only loadable if test is active

GitOrigin-RevId: 2b29dc8a3ecef6dd8f34dd25e59bf48a9724061b
2024-06-06 08:05:05 +00:00
Jessica Lawshe
3948b6ddb3 Merge pull request #18717 from overleaf/jel-isSplitTestActive
[web] Add helper for checking if test is active

GitOrigin-RevId: 1e8987517915e3947812086863da11fad252daf1
2024-06-06 08:05:01 +00:00
Jessica Lawshe
8fe46feffb Merge pull request #18713 from overleaf/jel-group-plan-modal-defaults
[web] Move group modal defaults for plans page to function

GitOrigin-RevId: 0ebce884f9e984b50318742765b7a768f259a8db
2024-06-06 08:04:56 +00:00
Jessica Lawshe
d28e58a2fc Merge pull request #18686 from overleaf/jel-plans-page-currency
[web] Move `currency` check to `_getRecommendedCurrency`

GitOrigin-RevId: afadd492a2e1db9c91fac027eb3c9783194ff169
2024-06-06 08:04:52 +00:00
Eric Mc Sween
6c9d4fb522 Merge pull request #18716 from overleaf/em-tracked-delete-undo
Fix translation of tracked deletes

GitOrigin-RevId: 4124db6953cbed46eea61f62118fc8e1ddfff4a0
2024-06-06 08:04:43 +00:00
Jakob Ackermann
06607b5c51 Merge pull request #18732 from overleaf/jpa-server-pro-csp
[server-ce] enable CSP by default in Server CE/Pro

GitOrigin-RevId: 8c7664a39f688a748f33e3158b594b9368457661
2024-06-06 08:04:35 +00:00
ilkin-overleaf
dd7970c11d Merge pull request #18644 from overleaf/ii-delete-with-body-teardown-old-routes
[web] Tear down deprecated routes

GitOrigin-RevId: b86e1d9283a30d36f77148eeb782a7f37987854a
2024-06-06 08:04:31 +00:00
Antoine Clausse
e452f1df5b [web] Promisify LdapController (#18500)
* Promisify LdapController

* Update tests LdapControllerTests.js

* Promisify `AuthenticationController.finishLogin`

* Simplify null checks in LdapController

* Fix: don't use spread operator in module.exports

* Make `AuthenticationController.promises.finishLogin` a promise that resolves

* Fixup: `finishLogin` does not call `next` then the promise finishes, it calls it only on errors

* Use `Modules.promises.hooks.fire`

* Revert `processPassportLogin` callback style

* Update error handling: Use `OError.tag` instead of `logger.err`

* Fix unit tests: Rely on callbacks rather than promises

* Fix: Actually call `passport.authenticate` (!!)

* Update test: fixup `passport.authenticate` mocks

This would have caught the bugs that the previous commit is solving

* Remove `.then(() => next())` in `processPassportLogin`

Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>

---------

Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>
GitOrigin-RevId: a7eab5f5289956aeb8f2418408958daef3511ab7
2024-06-06 08:04:23 +00:00
Antoine Clausse
258289e65a [web] Promisify LaunchpadController (#18497)
* Remove unused exports and decaffeinate comment

* Update export format

* Make `launchpadPage` async

* Make `_atLeastOneAdminExists` async

* Make `sendTestEmail` async

* Make `registerExternalAuthAdmin` async

* Make `registerAdmin` async

* Update tests LaunchpadControllerTests.js

* Use `expressify(...)`

* Fix unit tests: export `LaunchpadController`

* Fix unit tests by awaiting expressified functions (could include breaking changes!)

* Call `.exec()` after `User.updateOne(...)`

* Revert promisification of `expressify`

* Revert some `return` removal in tests

GitOrigin-RevId: c73a38bf1cf798830df046fe96d3516178655ea6
2024-06-06 08:04:18 +00:00
Alf Eaton
c24ace801b Remove Angular (#17534)
GitOrigin-RevId: 7a0d45e17d9905fa75569e2d19ca59caa4a41565
2024-06-06 08:04:09 +00:00
Tim Down
b3d33fe813 Merge pull request #18688 from overleaf/td-bs5-dropdown-min-width
Apply min-width rather than width to Bootstrap 5 drop-downs

GitOrigin-RevId: 369b5028fa5c53e7e39986474c27f8b848e70b20
2024-06-05 08:04:05 +00:00
Jakob Ackermann
3b5cfd83f3 Merge pull request #18704 from overleaf/jpa-fix-local-sandboxed-compiles
[server-pro] fix TeXLive versions for running tests locally

GitOrigin-RevId: 08bc769fd97558323011dedae378982d8cefee66
2024-06-05 08:04:01 +00:00
Liangjun Song
432fbd3c40 Revert "[web]implement in-house sha1 hash function (#18651)" (#18703)
This reverts commit aa3f5ab3ff412696c715521381eebf176f503197.

GitOrigin-RevId: b2be3907439525f3ed49baec0b438ba35ea1663c
2024-06-05 08:03:57 +00:00
Eric Mc Sween
55c342134c Merge pull request #18659 from overleaf/em-crop-comments-tracked-deletes
Crop comments when processing tracked deletes

GitOrigin-RevId: 662c9ed86a8ed4959d1671ce466548487f334f45
2024-06-05 08:03:53 +00:00
Liangjun Song
4101f4efeb [web]implement in-house sha1 hash function (#18651)
* implement in-house sha1 hash function

* add comment

* add test description

Co-authored-by: Antoine Clausse <antoine.clausse@overleaf.com>

* add more tests

* dedupe test strings and remove unneeded toString calls

---------

Co-authored-by: Antoine Clausse <antoine.clausse@overleaf.com>
GitOrigin-RevId: aa3f5ab3ff412696c715521381eebf176f503197
2024-06-05 08:03:42 +00:00
CloudBuild
a9cc32e6ed auto update translation
GitOrigin-RevId: 12802865aecee6957eb6b36eafc4500c32512aeb
2024-06-04 08:05:12 +00:00
Tim Down
9f1272d46d Merge pull request #18536 from overleaf/td-bs5-remove-bookmarkable-tab
Move bookmarkable tabs to Bootstrap 3 only

GitOrigin-RevId: 456599e96f6b0ee3862004f74e4b19c5d4d94c93
2024-06-04 08:05:04 +00:00
Jessica Lawshe
22be3928e3 Merge pull request #18614 from overleaf/mf-create-plans-redesign-split-test-config
[web] Create split test configuration for `website-redesign-plans` split test

GitOrigin-RevId: dea88256830897d1ab1f1de64eb21413c823e6ff
2024-06-04 08:04:59 +00:00
Jessica Lawshe
9e99683915 Merge pull request #18568 from overleaf/jel-cms-cards
[web] Add 2 new card style options for CMS

GitOrigin-RevId: d784d3f4860abf9553f1ab68e3edd29b93355a52
2024-06-04 08:04:55 +00:00
Liangjun Song
c22802eac9 implement in-house md5 hash function (#18647)
* implement in-house md5 hash function

* format

* add lisence information

GitOrigin-RevId: 1416654e8c27ec7a0d6ca632e6ece59c830ef561
2024-06-04 08:04:50 +00:00
Tim Down
c0d920f305 Merge pull request #18660 from overleaf/td-rd-bs5-contact-us-modal
Bootstrap 5 contact us modal

GitOrigin-RevId: a4607fab50152109fbe83bc29246b7b4a82539a1
2024-06-04 08:04:46 +00:00
Tim Down
e533bee8a3 Merge pull request #18664 from overleaf/td-bs5-integrations-premium-badge
Position "premium feature" badge correctly on account settings page

GitOrigin-RevId: 82d8a1db739a9836bcfa2c6a56a2bc6198da7f54
2024-06-04 08:04:38 +00:00