Commit graph

7034 commits

Author SHA1 Message Date
M Fahru
6a7f230fa2 Fix "Done" button after accepting group invite button does not work as intended because of href value is not set correctly
the `doneLink` variable on the pug file is expanded in the backend, so this commit will move the href building in the pug file instead of the frontend angular controller to make sure the value exists

GitOrigin-RevId: 74029a03293324955120bca630925a743ee60c22
2023-11-14 09:05:03 +00:00
Rebeka Dekany
1c834cbfaf Merge pull request #15740 from overleaf/dk-odc-newprops
Store ODC form step 3 data in mongo

GitOrigin-RevId: 91311efaddb5ccb9a456ea359140235235530536
2023-11-14 09:04:56 +00:00
Domagoj Kriskovic
9ce9b2c937 Add onboarding-flow in "register" and "user-registered" events (#15651)
* onboarding-flow in register event

* onboarding-flow in user-registered event

* fix typos

GitOrigin-RevId: aff8a7157062db0ec1c99499353a7c08eaa7b8b6
2023-11-13 09:03:57 +00:00
M Fahru
0639f266d8 Merge pull request #14756 from overleaf/mf-group-invite-new-user-redirection
[web] Redirect to invite screen if new user register with a pending group invitations

GitOrigin-RevId: 39aeffd65b9d793c87e53398a700ad140794594e
2023-11-10 09:04:23 +00:00
Alexandre Bourdin
c4bea21ee2 Merge pull request #15669 from overleaf/ab-fix-sso-linking-status
[web] Fix SSO status in group members table

GitOrigin-RevId: e54e7b0c9640f0b96d9692c0208357e3bac2de91
2023-11-10 09:04:15 +00:00
Alf Eaton
b0effa7e4a Trim the project name again after fixing (#15682)
GitOrigin-RevId: 74c87ee1689668a058a162a1f456815e0748b049
2023-11-10 09:04:00 +00:00
Miguel Serrano
7f347be7f3 Merge pull request #15658 from overleaf/msm-team-invite-acceptance
[web] Team invite acceptance tests

GitOrigin-RevId: 755a4c483c93cee1ce4403c04db85fcbf4da06c3
2023-11-10 09:03:38 +00:00
Rebeka Dekany
4dd2635c40 Merge pull request #15685 from overleaf/rd-newsletter-homepage
[web] Hide newsletter checkbox on the homepage when token-confirmation-odc variant is active

GitOrigin-RevId: b5c0c1fdf205c99584ae7b6b461b13a73745fef3
2023-11-09 09:03:26 +00:00
Jessica Lawshe
efc66bb276 Merge pull request #15664 from overleaf/jel-token-hash-prefix
[web] Include more data when logging link sharing token hash mismatches

GitOrigin-RevId: 8f939cf3dd49497d5b21779e354ce5deff07edad
2023-11-09 09:03:13 +00:00
Domagoj Kriskovic
330a9c8e3a Store ODC form results in onboardingDataCollection (#15609)
* registration/onboarding page

* show only if in split test group

* rate limiter, skip errors

* fix storybook logo

* remove skip payload

* fix typos

* prettier

* store ODC form results in onboardingDataCollection

* add userId

* prettier

* pick what properties should be stored

* remove unused props

* remove userId index

* update user profile

* update user profile

* use setOp

* added test

* remove userId from schema

* clean after user delete

* mock unit test

* limit to 255 chars

* updatedAt field

* prettier

* firstName, lastName as separate vars

* move subscribe at the end

* check if user exists

GitOrigin-RevId: 6d76927e97b5f4ed664ffb9b8806b3516c77eb9b
2023-11-09 09:03:04 +00:00
Miguel Serrano
42fe453096 [SP] Prevent rendering of sync section in SP when git disabled (#15647)
GitOrigin-RevId: 0f4c43eeb0182e7288566eff1ceed861bb9c4338
2023-11-07 12:35:08 +00:00
Alf Eaton
e0c8eb98c1 Show the git sync modal to read-only users (#15301)
GitOrigin-RevId: e002815fa7c18d497260e6344a4e8de95d7bacef
2023-11-07 12:35:04 +00:00
Alf Eaton
3912de589f Merge pull request #15629 from overleaf/ae-web-target
Use production `web` dependencies for development

GitOrigin-RevId: e89942d1a24c32bf60b319932c6d74905db74a19
2023-11-07 12:35:00 +00:00
Alexandre Bourdin
8abf8ba956 Merge pull request #15639 from overleaf/ab-fix-group-settings-visibility
[web] Various fixes for Group SSO

GitOrigin-RevId: 0a98d7eed14b2878a6be5e28e54ab1f7ceb9be5f
2023-11-07 12:34:45 +00:00
Jessica Lawshe
780673ed31 Merge pull request #15558 from overleaf/jel-log-token-hash-mismatch
[web] Log the project ID on link sharing token hash prefix mismatches

GitOrigin-RevId: 37d15206f49920f49d61f22479b98dd4d448f6bd
2023-11-07 09:05:12 +00:00
Alexandre Bourdin
d45ca7d401 Merge pull request #15582 from overleaf/msm-sso-linking-reminders
[web] SSO Linking redirects and interstitial info

GitOrigin-RevId: fdad0290ebf2b8b8a77f12b75736c030a4c7b642
2023-11-07 09:05:00 +00:00
Alexandre Bourdin
6852ad2be7 Merge pull request #15569 from overleaf/msm-group-sso-link-errors
[web] Error handling during SSO linking

GitOrigin-RevId: 232ef0672e93dc7c68cd45396306e8b4328a35d9
2023-11-07 09:04:55 +00:00
Alexandre Bourdin
2783e89bc3 Merge pull request #15539 from overleaf/ab-schedule-sso-reminder
[web] Schedule Group SSO account linking reminder after joining the group

GitOrigin-RevId: 5586787fbd268446e441762fd7b4846821f849f6
2023-11-07 09:04:51 +00:00
Brian Gough
ee4e1f5429 Trim project name and validate whitespace (#14976)
* add whitespace check to fixProjectname
* add whitespace check to validateProjectName
* Log a warning if the project name starts or ends with whitespace

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: ba81e0f795e52dbba92c9fbb48cebfd8e547af08
2023-11-06 09:03:55 +00:00
Alexandre Bourdin
e322f4a31f Merge pull request #15418 from overleaf/ds-managedUsersEnabled
Managed users - Adding a managedUsersEnabled flag on subscription model

GitOrigin-RevId: a03dd169ba71255dd1bec5f7bee8ce9609d95a2f
2023-11-03 09:00:26 +00:00
Eric Mc Sween
75c7a58100 Merge pull request #15515 from overleaf/em-promisify-user-controller
Promisify UserController

GitOrigin-RevId: d56ddb32abff2c33f45efa58285c7bf02b578cd2
2023-11-03 09:00:13 +00:00
Brian Gough
d3adcff0f1 Merge pull request #15544 from overleaf/bg-misc-use-literal-paths
Replace APP_ROOT and other variables with literal paths in web imports

GitOrigin-RevId: 138f03ad9355c8c6c92a206b0e54573234a6f65d
2023-11-02 08:53:03 +00:00
Jimmy Domagala-Tang
37817f89f4 Merge pull request #15295 from overleaf/jdt-subs-tbl-tab-access
Add subscription table icons to the tab index

GitOrigin-RevId: 1585cf2c7a114a9cae78c5d4bfbd888756aacf43
2023-11-02 08:52:59 +00:00
Domagoj Kriskovic
af4b22fab5 Confirm email new routes (#15377)
* confirm email routes

* Style the email confirmation template (#15196)

* error handling

* prettier

* error message

* rename variables

* message codes change

* v1 redirect

* fix assigning to session

* rename rate limitter

* rate limitter per email

* add try/catch

* added stub

* prettier

* confirm email acceptance test

* confirm when created

* tests

* added rate limit tests

* new email text

* subscribe to newsletter

* beforeEach/afterEach test both variants

* move tests to OverleafAuthenticationTests

* Revert "move tests to OverleafAuthenticationTests"

This reverts commit 3c745382815da1594044a811882ba3daa24a7a3a.

* cacheflow reset after each

* remove test archive request

* use crypto for random code

* rate limit in userEmailsConfirmationHandler

* ratelimiter per type

* req.session.pendingUserRegistration

* spy in before/after each

* without deleteMany

* delete staffUser in afterEach

* stub response, format

* rate limiter outside userEmailConfirmationHandler

* mock ratelimitter

* fix subscribe promise

* add email to logger

* logger calls

* using tsscmp

* fix lint

* resendConfirmationCode rate limiter in router

* remove redirect

---------

Co-authored-by: Rebeka Dekany <50901361+rebekadekany@users.noreply.github.com>
GitOrigin-RevId: 786c477966cf2c5f6e28417fe486146ee5c10884
2023-11-02 08:52:48 +00:00
Miguel Serrano
220998839b Merge pull request #15504 from overleaf/msm-fix-import-sp
[web] Replace module import breaking Server Pro

GitOrigin-RevId: 23f65b06d14019d1878c61abdf71b6b556192dc4
2023-11-01 09:03:25 +00:00
Miguel Serrano
e22e8ff7a8 [web] SSO linking for existing group members (#15471)
* [web] SSO linking for existing group users

GitOrigin-RevId: 22a5a5a28a213860f88ae0284c1ef51a31bb268f
2023-11-01 09:03:19 +00:00
Miguel Serrano
1f56441184 Merge pull request #15514 from overleaf/jpa-single-webpack-runtime
[web] enable webpack option runtimeChunk=single in dev-env

GitOrigin-RevId: 905b362496fc5df896632db920c91aee75c30b46
2023-11-01 09:03:16 +00:00
Miguel Serrano
d62f2c6a40 Merge pull request #15509 from overleaf/jpa-ide-react-pug-tweaks
[web] editor: use CSS/JavaScript loading primitives from base template

GitOrigin-RevId: fb570f62e37517f2a4444d469435e854fd890db6
2023-11-01 09:03:14 +00:00
Miguel Serrano
93b7e65f6c Merge pull request #15405 from overleaf/msm-remove-redundant-check
[web] Remove redundant check

GitOrigin-RevId: 035adf436c0d694fcb7817cd27e743683eb1252d
2023-11-01 09:03:08 +00:00
Jakob Ackermann
6906c6a28c Merge pull request #15513 from overleaf/jpa-consistent-return-type
[web] ExpressLocals: avoid returning undefined from getCssThemeModifier

GitOrigin-RevId: f5256719c2b4f06e2957f6bc971d3c895bdff5d2
2023-11-01 09:02:51 +00:00
Brian Gough
a12699133d Merge pull request #15420 from overleaf/bg-group-sso-handle-errors
handle errors in group sso login

GitOrigin-RevId: dcfba6bc4f7aec8aa9d27945b297154594368d92
2023-10-31 09:04:48 +00:00
Jessica Lawshe
8a0f2dbe1d Merge pull request #15419 from overleaf/em-error-request-logging
Use the request logger for errors in web

GitOrigin-RevId: f654fc69e0bbdab8b16d23b007aefbad08925358
2023-10-31 09:04:36 +00:00
Jessica Lawshe
1054b2d6fa Merge pull request #15491 from overleaf/jel-token-hash-log-user-id
[web] Log the user ID on token hash prefix mismatches

GitOrigin-RevId: 78d298051a9c1794ed38422bef24c852dcee3bb2
2023-10-31 09:04:26 +00:00
Jessica Lawshe
a3251394e1 Merge pull request #15473 from overleaf/jel-remove-encoded-hash
[web] Remove encoded hashtag when checking token hash prefix

GitOrigin-RevId: 2b9c369beceb7897d0f6f165b4c3a70b79c14469
2023-10-31 09:04:22 +00:00
Thomas
3cd0cefd30 Gradual rollout of new compile timeout to existing users (#15478)
* Rollout compile timeout to existing users

* Update copy for compile timeout messages

GitOrigin-RevId: bada02efb3fc506ae6e35bdb7871a58ef4295cbe
2023-10-31 09:04:11 +00:00
Alf Eaton
1314f9082c Improve detection of folder move into subfolder (#15422)
GitOrigin-RevId: 200d6e10a6e92ca85de24cae6d20f50c697ca584
2023-10-31 09:04:00 +00:00
Alexandre Bourdin
cd27ee3c8f Merge pull request #15446 from overleaf/ab-tie-user-enrollment
[web] Prevent a user from becoming managed by another group after linking group SSO

GitOrigin-RevId: d8cb763a68ca38b4aaf1518a5f93ac5a61cec28c
2023-10-30 09:04:47 +00:00
Alexandre Bourdin
c71301ac9a Merge pull request #15223 from overleaf/ab-sso-multiple-certificates-ui
[web] Support multiple certificates in group SSO settings

GitOrigin-RevId: 5f014eb82b7e0820040941fdd2bded8d33958316
2023-10-30 09:04:38 +00:00
Jessica Lawshe
16e859e40a Merge pull request #15429 from overleaf/jel-token-hash-metrics
[web] Log mismatched link sharing token hash prefixes

GitOrigin-RevId: 5ba690f4209987fccef859c858686c465e972f62
2023-10-27 08:03:27 +00:00
Davinder Singh
f97689aa87 Group SSO - Adding the SSO invite link reminder button in the dropdown (#15289)
GitOrigin-RevId: 9641946e65ede2d52645caf8876d7587a24e7dfc
2023-10-26 08:03:21 +00:00
Jessica Lawshe
21514418e5 Merge pull request #14881 from overleaf/ab-beta-program-async-await
[web] Convert BetaProgramController to async/await

GitOrigin-RevId: 2423cb00b78b2f3fddb7bcd317d34ed4dbc12b95
2023-10-25 08:05:03 +00:00
Jessica Lawshe
8da063d640 Merge pull request #15326 from overleaf/jel-link-sharing
[web] Add prefix of token hash to link sharing URLs

GitOrigin-RevId: 4b764c076a335768ab261dd1e181d90ce00fd1a2
2023-10-25 08:04:59 +00:00
Jakob Ackermann
488825efc4 Merge pull request #15383 from overleaf/jpa-remove-unused-angular-deps
[web] remove unused angular dependencies

GitOrigin-RevId: 58efeb5755b5f7d0f893e343b319bc4f1a6a3d76
2023-10-25 08:04:08 +00:00
Jakob Ackermann
347da4e6bb Merge pull request #15247 from overleaf/jpa-submission-backend-class
[web] use n2d instances for compiling submissions

GitOrigin-RevId: 57eb27af230b994c3816c0476673ea558226ac1e
2023-10-25 08:04:03 +00:00
Alf Eaton
774a0a3f18 Merge pull request #15354 from overleaf/ae-i18next-compatibility
Set compatibilityJSON to v3 for plural suffixes

GitOrigin-RevId: 8da0fc5a2777dbdc9abe9d72a47adab029ab91ef
2023-10-23 08:04:01 +00:00
Davinder Singh
3b48b32754 Revert "Revert "Group SSO - Adding a bug fix for sending emails"" (#15307)
* Revert "Revert "Group SSO - Adding a bug fix for sending emails""
* adding conditional rendering of columns and styling fixes for each render mode with some cypress test

GitOrigin-RevId: 168011503ffacff61c8f37bee4c4bfb012909c1f
2023-10-20 08:04:08 +00:00
Eric Mc Sween
680ebae30b Merge pull request #15172 from overleaf/em-promise-utils
Move util/promises from web into a shared library

GitOrigin-RevId: fe1980dc57b9dc8ce86fa1fad6a8a817e9505b3d
2023-10-20 08:04:05 +00:00
Alf Eaton
6f2b24706a Merge pull request #15198 from overleaf/ae-compliance-footer
Add Compliance link to footer

GitOrigin-RevId: 2b89c2e4ff5a114469316a071068eb20667a7873
2023-10-20 08:03:54 +00:00
Alf Eaton
ef3e8f666b Merge pull request #15214 from overleaf/ae-legacy-source-editor
Remove legacy source editor option from Server CE/Pro

GitOrigin-RevId: 32a7bf9b54c0082f3ab3ffb5fa11f5b4f2a3bf64
2023-10-20 08:03:51 +00:00
Alf Eaton
749aef1c6f Add optional personal access tokens for git bridge (#15209)
GitOrigin-RevId: 50d4c0e11728e014e81172c062a3b22fefa6286c
2023-10-20 08:03:27 +00:00