Commit graph

556 commits

Author SHA1 Message Date
Tim Down
1b2385dfce Merge pull request #21259 from overleaf/td-bs5-editor-search
[BS5] Migrate Editor search panel

GitOrigin-RevId: 37605845d4efc27d6c0c3a11de12387e8e3262f4
2024-10-24 08:05:58 +00:00
ilkin-overleaf
2646fefce4 Merge pull request #21289 from overleaf/ii-bs5-figure-modal-improvements
[web] BS5 fix form text colour

GitOrigin-RevId: 8ff03f41cc3490eff0ea4c65a376ac572003fb9c
2024-10-24 08:05:54 +00:00
ilkin-overleaf
5c3d9117c5 Merge pull request #21240 from overleaf/ii-bs5-review-panel-old
[web] BS5 review panel old

GitOrigin-RevId: da018b8f2946afb21ab63da0003453e20781f04c
2024-10-24 08:05:41 +00:00
David
d74981775c Merge pull request #21283 from overleaf/dp-keyboard-shortcuts
Add missing keyboard shortcuts to new review panel

GitOrigin-RevId: 78e3a63284b62c90e8a3803bd81fdf273f1a2ec9
2024-10-24 08:05:17 +00:00
David
1c5f5950fa Merge pull request #21208 from overleaf/dp-accept-reject-all-changes
Add options to accept/reject all changes to review tooltip

GitOrigin-RevId: 1cea76926d59d0354c8abaa6ba69b7e99c02fbe0
2024-10-24 08:05:08 +00:00
Alf Eaton
98bf2ac055 Disable spell check setting when doc is read-only (#21253)
GitOrigin-RevId: 1053fefd953d4f60b1c2aef4170f99c6885c265d
2024-10-23 08:05:18 +00:00
Alf Eaton
9fdbd5cfb5 Add state.Prec to editor:extensions export (#21222)
GitOrigin-RevId: b8680926a9885f19ebc9227de678674da1765158
2024-10-22 08:06:29 +00:00
Alf Eaton
6c4fac68ca Use Intl.Segmenter when available for identifying words to spell check (#21225)
GitOrigin-RevId: f261ae331e0b1f87f4e88a512b25c8798f0b02c6
2024-10-22 08:06:25 +00:00
Domagoj Kriskovic
1e16de13bc Fix change and insert range decorations background color (#21131)
GitOrigin-RevId: 4bbc7abdc4c52ea31e26ea3fd8cf43d8c9620d47
2024-10-22 08:05:42 +00:00
Domagoj Kriskovic
42eea0017d Update track change decoration to be cursor-like (#21047)
* Update track change decoration to be cursor-like

* use red-50 color

GitOrigin-RevId: 8c8a2cb9c6abc99aa1d2dace705dba3feeda07fa
2024-10-22 08:05:24 +00:00
David
87f714f7c3 Merge pull request #21164 from overleaf/dp-add-comment-keyboard-shortcut
Add keyboard shortcut (cmd+shift+c) for adding a new comment

GitOrigin-RevId: 20359426f45e90b09cbc887bac3096adf1b3141a
2024-10-22 08:05:15 +00:00
David
a2ea76f19f Merge pull request #21201 from overleaf/dp-toolbar-ui
Style adjustments for add comment tooltip

GitOrigin-RevId: 7fdc008fea4a191ff8bacca9a77e23cd55faac5a
2024-10-22 08:04:57 +00:00
ilkin-overleaf
8bc374c916 Merge pull request #21115 from overleaf/ii-bs5-review-panel
[web] BS5 review panel new

GitOrigin-RevId: c65d17d0053858bd74984ba746a620b89d900606
2024-10-21 08:04:37 +00:00
Alf Eaton
1b2f5af1c0 Display current spell check language and option to change it (#21138)
GitOrigin-RevId: 87cf140a7e3e719125eb6d2df23d6c6bd6631fe8
2024-10-18 08:05:48 +00:00
Alf Eaton
978ef6bd92 Enable remaining client-side dictionaries (#21192)
GitOrigin-RevId: da45ae4a93e99a0bb720e09a37c8e291c057cab9
2024-10-18 08:05:29 +00:00
Alf Eaton
a238b8eee4 Use ol_spell_check_language tag for error reporting (#21126)
GitOrigin-RevId: 11580f8dca22b0d4858dc5db36827b69a3637371
2024-10-17 08:05:55 +00:00
Alf Eaton
ecb94d6525 Improve spellcheck error handling and types (#21012)
GitOrigin-RevId: 0227122154f139401793aae2c8ca9c9960fe5e98
2024-10-14 11:09:46 +00:00
Rebeka Dekany
0131178491 Merge pull request #21002 from overleaf/rd-icon-updates
[web] Material icon changes in toolbars

GitOrigin-RevId: f0a36b2f0c2bc56a7fccfe6491ea4538a997c486
2024-10-14 11:09:41 +00:00
Alf Eaton
b81472329e Use cls for documentclass completion type (#20981)
GitOrigin-RevId: 938eaac212c7e08600db111563094c0447fafb9b
2024-10-14 11:09:21 +00:00
David
b1d1432183 Update add comment tooltip to match new designs (#20913)
* Update add comment tooltip to match new designs

* Rename AddCommentTooltip to ReviewTooltipMenu

* Split off add-comment-button specific padding

GitOrigin-RevId: 12a69b13b52b007eb97ba7ad6f290e3a98d741cd
2024-10-14 11:08:26 +00:00
Mathias Jakobsen
ee2e95ec01 Merge pull request #20987 from overleaf/mj-write-and-cite-settings-icons
[web] Add setting icons to Write and Cite section headers

GitOrigin-RevId: 18e5eefeb1271d17812b83f152e4d464a66185f8
2024-10-14 11:08:09 +00:00
Antoine Clausse
b054342ddb [web] Update bsVersion to return its arguments types (#20963)
* [web] Update `bsVersion` to return its arguments types

* [web] Remove `as string` after `bsVersion` calls

GitOrigin-RevId: 604ce87aaccd709299124a986e98cf45874484bb
2024-10-14 11:07:45 +00:00
Alf Eaton
53d6b4dfd0 Set workerPublicPath in webpack config (#20629)
GitOrigin-RevId: 3fba33a6b52bf2a91f3126efc9d76f6f1dfbc1c4
2024-10-14 11:06:45 +00:00
ilkin-overleaf
92eade7502 Merge pull request #20708 from overleaf/ii-bs5-pdf-toolbar
[web] BS5 pdf toolbar

GitOrigin-RevId: a04091c9e936e52f47c3977b3149ffe613d43bb9
2024-10-14 11:06:17 +00:00
Mathias Jakobsen
58b52db56d Merge pull request #20903 from overleaf/mj-load-write-and-cite-with-autocomplete
[web] Load Write and Cite with AutoComplete

GitOrigin-RevId: b496874447b00723410df01a96ea66aa8ec4da3c
2024-10-14 11:05:39 +00:00
Alf Eaton
139fde750a Add feedback link in spelling suggestion footer (#20867)
GitOrigin-RevId: 3bef428f810b88f56a76e3645cebcf22dd5ad9e3
2024-10-14 11:05:21 +00:00
Alf Eaton
e99ae3a459 Add Hunspell README (#20872)
GitOrigin-RevId: 0b02a1a03e467d0857766e70e3a3862f939c773c
2024-10-14 11:05:17 +00:00
Alf Eaton
a1ea50ded3 Load hunspell.wasm from the CDN (#20856)
GitOrigin-RevId: 0fcbc2102e280222ab4b9279f02c820a3b904496
2024-10-14 11:05:12 +00:00
David
175a4d024d Merge pull request #20805 from overleaf/dk-fix-focus-highlight
Fix focus highlight decoration for new review panel

GitOrigin-RevId: c69ba8dd8527b6c3797b1e986cfd87c1ca87da6d
2024-10-14 11:02:55 +00:00
David
b2dab4b1c0 Merge pull request #20709 from overleaf/dp-search-wrapping
Wrap search controls on small editor widths

GitOrigin-RevId: 513d046ba2951daf13385f48b73704e6feccd7d0
2024-10-14 11:02:40 +00:00
Alf Eaton
df6147bb4d Convert PDF.js code to TypeScript
GitOrigin-RevId: 840bc48816d78497131b927522b4f6f7940bb0c4
2024-10-14 11:00:45 +00:00
David
2117bfe29d Merge pull request #20541 from overleaf/dk-delete-widgets
Handle highlight/focus effects for track deletes in new review panel

GitOrigin-RevId: 102eed9e8af04599823c1bcf0598a0328901bdba
2024-10-14 10:59:47 +00:00
David
46198cd780 Merge pull request #20688 from overleaf/dk-fix-wrong-rangesdata
Fix "RangeError" when switching files using new review panel

GitOrigin-RevId: 399c8722584053c62acf5c413572fbbcdd1896cc
2024-10-14 10:59:33 +00:00
David
13545140ee Merge pull request #20681 from overleaf/dp-highlight-height
Add padding to change highlight/focus styles

GitOrigin-RevId: 6543fe6545ff8e7baff23d5262b941a5473be19e
2024-10-14 10:59:25 +00:00
Mathias Jakobsen
aba4694377 [web] Move ARS Write and Cite behind separate feature flag (#20631)
* [web] Move ARS Write and Cite behind separate feature flag

* [web] Use isSplitTestEnabled function

* [web] Only load Write and Cite if project has ARS access

* [web] Enable Write and Cite ARS by default

* [web] Fix condition for loading write and cite ref sources

* [web] Remove references settings button in free projects

GitOrigin-RevId: c4f3b7c60da9864409c788dcf34bdc77347441a8
2024-10-14 10:59:11 +00:00
Alf Eaton
24c8629cd4 Use Hunspell for client-side spellchecking (#20286)
GitOrigin-RevId: c4d0d9e06fe0cc9d7cb7a058fd0768eb024e44f5
2024-10-14 10:58:36 +00:00
ilkin-overleaf
35728d7681 Merge pull request #20436 from overleaf/ii-bs5-editor-toolbar
[web] BS5 editor toolbar

GitOrigin-RevId: a517fd52d648d165e89231d6f5551c026a951c43
2024-10-01 08:04:42 +00:00
Alf Eaton
c6633632d6 Move CodeMirror contexts into a separate file (#20643)
GitOrigin-RevId: 8425454a75ff8160a03fda1be5bda2242b41f6cd
2024-09-30 08:04:48 +00:00
David
06e24c9081 Merge pull request #20606 from overleaf/dk-add-comment-on-mouseup
show Add comment button on mouse up event

GitOrigin-RevId: 2c87f11fab9f9fb7e11637bb9eac2ca1ab9b298b
2024-09-27 08:04:39 +00:00
Alf Eaton
6f8a9a0f81 [visual] Improve cursor position in empty list items (#20611)
GitOrigin-RevId: 08a83b509e217573f680ca4a635d9480ade9b1ae
2024-09-26 08:05:32 +00:00
Alf Eaton
53e46632a9 Improve editor focus events (#20263)
GitOrigin-RevId: 710f42eb633289b43858b8f283735ed0aced5c0b
2024-09-26 08:05:25 +00:00
Alf Eaton
ca72351c8e Improve detection of pasted Excel table in Safari (#20374)
GitOrigin-RevId: 92b9c485b57f753f4fe161e582817f72244436e1
2024-09-26 08:05:21 +00:00
Alf Eaton
77ad90d59a Refactor to texOrPdfString function
GitOrigin-RevId: b084966a4fc13de4708973685844b2d9d2405e9b
2024-09-26 08:05:13 +00:00
Copybot
2a2bb3f064 Merge pull request #1245 from AnessZurba:tex-or-pdf
GitOrigin-RevId: 096f7e5bb581c3984db8dc74e7a4c525de862cce
2024-09-26 08:05:08 +00:00
David
22e4c2de2c Merge pull request #20411 from overleaf/dk-highlight-focus-ranges
Highlight and focus ranges in editor for new review panel

GitOrigin-RevId: 4fef31a8c9e6dc974519d925c7478665e0c8cc29
2024-09-20 08:05:13 +00:00
David
a323f3af75 Implement a floating "Add comment" button for the redesigned review panel (#19891)
* Implement floating Add comment button

* Fix comment typo

* Remove unused imports

* Make tooltip always appear above cursor

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

* Refactor how new comment form is positioned

* Add missing file

* Create new map when rendering positions

* Use codemirror state to manage ranges and allow for mutliple in-progress comments

* Memoise sorting

* Create new ranges map each time it is changed

* Add back mutation observer

* Only allow single tooltip

* Fix typo

* Convert state field to store a single tooltip

* Make add comment tooltip content a react component

* Refactor to remove usages of !important

* Use RangeSet to keep track of new comment ranges

* Fix logic broken in rebase

* Map ranges through document changes

* Add decorations for in-progress comments

* Use set-review-panel-open rather than an editor event to open review panel

* Implement new designs for add comment form

* Add padding to textarea

* Fix bug where comment was being submitted for incorrect range

* Add missing key to ReviewPanelAddComment

* Store new comment ranges as a DecorationSet

* Small refactor to how ReviewPanelAddCommens are rendered

* Make op prop to ReviewPanelEntry required

* Add handling for disabling of add comemnt form buttons

* Move viewer check inside AddCommentTooltip

* Ensure that add comment button doesn't reshow when collaborators edit the document

* Remove unneeded op check in ReviewPanelEntry

* Update services/web/frontend/js/features/review-panel-new/components/review-panel-add-comment.tsx

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 3110845f6a557310f3bf72014689e2f2ab53e966
2024-09-17 08:04:58 +00:00
David
9cf94e57d3 Include \def, \let, \newenvironment and \renewenvironment commands in the math preview (#20197)
* Include \def commands in command definitions

* Allow command name to be in CtrlSym

* Pull nodeIntersectsChange check out of branches

* Fix \def handling

* Add handling for \newenvironment and \renewenvironment

* Allow \def to have optional arguments

* :x
Revert "Add handling for \newenvironment and \renewenvironment"

This reverts commit a70d3a0a13ed552daf3b761893e3f8609f0b0fc8.

* Add let commands to defintions

* Add environment names to math preview

* Ignore let command definitions in autocomplete

* Move nodeIntersectsChange check back into each block

* Add childOfNodeWithType utility and use to get command names

* commandNameText -> commandName

* Only include environment definitions

* Rename documentEnvironmentNames to documentEnvironments

* EnvironmentName -> Environment

* Format

GitOrigin-RevId: 9c5d701423ae786e5ff91960b4bcd94cd35d21c8
2024-09-17 08:04:53 +00:00
Alf Eaton
0230a296ac Remove underline from lint range highlight (#20243)
GitOrigin-RevId: 29c91fa8297cb92ceba3a088bff22c847b73455d
2024-09-13 08:05:05 +00:00
Alf Eaton
0e40011e14 Remove setTimeout from spell check results dispatch (#20342)
GitOrigin-RevId: 9973b216d60b20c2b6aaf5205c13e2db69cbd589
2024-09-13 08:04:55 +00:00
Alf Eaton
26af3e1ecf Use estimated height of math widget (#20359)
GitOrigin-RevId: b412e429b26ae51c83f84b855084b36a0015838d
2024-09-13 08:04:50 +00:00