Commit graph

14867 commits

Author SHA1 Message Date
M Fahru
666c10860e Merge pull request #20151 from overleaf/mf-add-canonical-light-design-plans
[web] Add necessary config for canonical link and suppressing alternate links for different languages in plans light design

GitOrigin-RevId: f903b3c1eb31276ea8ffadc43ac240a4c16bcbbc
2024-08-29 08:04:51 +00:00
roo hutton
837b5a4b9b Merge pull request #19914 from overleaf/rh-viewer-comments
[web] Allow Viewers to access chat and view comments/tracked changes

GitOrigin-RevId: 72be0444afdf5e0ad5937bf25718a7566bad001a
2024-08-28 11:35:22 +00:00
ilkin-overleaf
446e19424d Merge pull request #20105 from overleaf/ii-bs5-ide-page-setup
[web] Initialize BS5 in ide page

GitOrigin-RevId: 96ceb77ec68f86b9946fc2a2bafb54b96f2a116e
2024-08-28 11:35:17 +00:00
ilkin-overleaf
6437059783 Merge pull request #20063 from overleaf/ii-bs5-system-notifications
[web] BS5 system notifications

GitOrigin-RevId: a5a17a418193e325c0f561708c99240191cff8e7
2024-08-28 11:35:13 +00:00
roo hutton
db4d23d2df Merge pull request #20080 from overleaf/rh-lost-edit-access-modal
[web] Show modal to pending editors

GitOrigin-RevId: 63dfed45a1483e835978dc7ac76cd0f37b4e1f50
2024-08-28 08:04:34 +00:00
CloudBuild
8e0a4808e1 auto update translation
GitOrigin-RevId: b5a593bdcfc6ae80770cadfa9d7387f9b2a1de53
2024-08-27 08:05:12 +00:00
Jimmy Domagala-Tang
f64b7a56c4 Merge pull request #19965 from overleaf/jdt-fake-door-cleanup
feat: clean up uneeded fake door pages and routes
GitOrigin-RevId: 1d7ad3d43fda0f7852e3e5abbe5a8287d73d910d
2024-08-27 08:05:01 +00:00
Jakob Ackermann
a98fefd24b Merge pull request #20129 from overleaf/jpa-handle-partial-deletion
[misc] improve handling of document deletion

GitOrigin-RevId: bd6b225b91ab38365e9ff272c50ece995e767bf2
2024-08-27 08:04:53 +00:00
roo hutton
2dcf87e3f6 [web] Share modal shows downgraded editors (#20015)
* add hasBeenDowngraded prop for EditMember

* reduce padding on share modal collab row, add prompt to hasBeenDowngraded Select

* share modal select styling tweaks to allow for inline warning icon

* always show editor limit subtitle when in downgraded state

* add AccessLevelsChanged warning, tweak owner row styling

* conditionally set hasBeenDowngraded prop. make invited member row styling more consistent between warning/enforcement

* add an info state for access level changed notification

* add notification for lost edit access on collaborator share modal, TSify SendInvitesNotice

* fix member privilege alignment in collaborator share modal

* show blue upgrade CTA when some pending editors have been resolved

* automatically show share modal to owners when has pending editors or is over collab limit

* only show lost edit access warning in read-only share modal to pending editors

---------

Co-authored-by: Thomas <thomas-@users.noreply.github.com>
GitOrigin-RevId: e3b88052a48b8f598299ffc55b7c24cb793da151
2024-08-27 08:04:49 +00:00
Thomas
3e06c0086e Merge pull request #20090 from overleaf/tm-link-sharing-enforcement-add-more-editors
Update the notification shown when at max collaborators for users in the link-sharing-enforcement stage

GitOrigin-RevId: 7699491b217e963bcbd919b3763d8c8d31b5361f
2024-08-27 08:04:45 +00:00
Thomas
95aa79e95d Merge pull request #20089 from overleaf/tm-link-sharing-enforcement-in-frontend
Make ol-linkSharingEnforcement available to the frontend

GitOrigin-RevId: b64ce29f528c5b02c0cee400c73dc364d8e6da47
2024-08-27 08:04:40 +00:00
Eric Mc Sween
8b4b454b97 Merge pull request #20052 from overleaf/em-tracked-deletes-limit
Include tracked deletes when limiting document size

GitOrigin-RevId: 9d7b2870001fb942eaa92db78993fee1ddb3937c
2024-08-27 08:04:31 +00:00
Jakob Ackermann
e643a8ea32 Merge pull request #20131 from overleaf/jpa-mongoose-query-is-promise
[web] eslint: consider promise-like interfaces in no-floating-promises

GitOrigin-RevId: c179f4a27c1c576d18abdec0e27433b846d7f620
2024-08-27 08:04:27 +00:00
CloudBuild
a6598b0899 auto update translation
GitOrigin-RevId: 1701dc82182ee9477f4b03e2a68f4d8798fef6e1
2024-08-26 08:05:33 +00:00
CloudBuild
3f8f5e89e1 auto update translation
GitOrigin-RevId: 3005cd9926459469113fdfd4b4ec27493debe3c5
2024-08-26 08:05:28 +00:00
Brian Gough
dbf977a93c Merge pull request #20087 from overleaf/bg-clean-up-web-crash-tests
read crash test files from a directory

GitOrigin-RevId: 3e498bd73dc9ca97cbe96899f9c1661d430a7d75
2024-08-26 08:05:23 +00:00
Liangjun Song
3f1edfc1c9 Merge pull request #19954 from overleaf/ls-access-token-gradual-rollout-cleanup
Update git bridge modal for pw auth deprecation

GitOrigin-RevId: 2e764922bf350ddcba29bf9f3baa220ed1f48e40
2024-08-26 08:05:15 +00:00
Domagoj Kriskovic
cab58d87dd extracted rejectChanges to a separate file
GitOrigin-RevId: 83c55c4823f6e18f22dbd6bc1fa7ec010c509e30
2024-08-26 08:05:10 +00:00
Domagoj Kriskovic
ea20f82ad6 remove callout widget from ranges extension
GitOrigin-RevId: fa7f36cb0270228b57162404ce5a17523790e396
2024-08-26 08:05:06 +00:00
Domagoj Kriskovic
be47b27d98 remove clearChanges and buildChanges effects from ranges extension
GitOrigin-RevId: 4782725bfaf50153007bbd9ae5c8146cca769cde
2024-08-26 08:05:01 +00:00
Domagoj Kriskovic
dc70054caf trackDetachedComments as separate extension
GitOrigin-RevId: 8039de3f9766b072e9bb2170b50e683073105748
2024-08-26 08:04:56 +00:00
Domagoj Kriskovic
ec6b17eb01 revert trackChanges extension to a version before redesign
GitOrigin-RevId: fc12968a3971cfee7594720076bb4dc271178e73
2024-08-26 08:04:52 +00:00
Domagoj Kriskovic
6547ce6aa1 remove updateRangesEffect and rejectChanges from trackChanges extension
GitOrigin-RevId: b93751421d235fd61a80ce64f47aec7998e4f6cf
2024-08-26 08:04:47 +00:00
Domagoj Kriskovic
3bdfd36613 copied track-changes.ts extension
GitOrigin-RevId: 95e383223c6e4e7a10112ebfaff4d3bda9530a01
2024-08-26 08:04:43 +00:00
Davinder Singh
e19e5ae29a Interstitial Page - Adding geo banners for India and latin america (#20046)
* adding geo banners on interstitial page

* adding a new class .interstitial-new-design-content-spacing to match the spacing of 13

GitOrigin-RevId: 0b72f321356a899f02efcf4bd2719d7762e7b524
2024-08-26 08:04:22 +00:00
Jakob Ackermann
1459ae9b65 Merge pull request #20082 from overleaf/jpa-limit-local-storage
[web] disable local storage of ro-mirror for admin site/debug copies

GitOrigin-RevId: 33a65cb17a09e4e7f9b5e8e4fce1b4e1ba6c38f8
2024-08-23 08:04:53 +00:00
Jakob Ackermann
1182049d89 Merge pull request #20057 from overleaf/jpa-readonly-tuning
[web] tuning for readonly mirror on client

GitOrigin-RevId: c0ecc8923cdec6c515da17750133632ebc430e8d
2024-08-23 08:04:48 +00:00
Alexandre Bourdin
4997b7f1ee Merge pull request #20062 from overleaf/ab-saas-authentication-module-renaming
[web] Rename overleaf-integration module to saas-authentication

GitOrigin-RevId: 7d69e06a19da9855fa9a0962114ad97b45ad8875
2024-08-23 08:04:43 +00:00
ilkin-overleaf
0e71084600 Merge pull request #19840 from overleaf/ii-bs5-project-tools
[web] BS5 project tools

GitOrigin-RevId: 3181c62985b6db4051292b484f53178a0736fa75
2024-08-22 14:01:43 +00:00
Thomas
22fb9973fa Merge pull request #20083 from overleaf/tm-fix-mongodb-legacy-collaborators-getter
Update CollaboratorsInviteGetter to use mongodb-legacy instead of mongodb

GitOrigin-RevId: 06eb6f89725c06f759e19f73c4a4d1ade5703b4f
2024-08-22 14:01:39 +00:00
Thomas
abf04c5d6c Merge pull request #20036 from overleaf/tm-collab-limit-link-sharing
Enforce collaborator limit for link sharing

GitOrigin-RevId: b724dca0c616ef15e5bd6d07e9d898d34dd46acd
2024-08-22 14:01:34 +00:00
Thomas
98a914bb94 Merge pull request #20034 from overleaf/tm-collab-limit-edit-invites
Enforce collaborator limit when accepting project invites

GitOrigin-RevId: 94f281113fe7c7b6d0a5ef43e11ab579400d9e56
2024-08-22 14:01:30 +00:00
roo hutton
5e2662adc4 [web] Enforce collaborator limit (#19619)
* Enables collaborator limit enforcement

* Add pendingEditor_refs for editors downgraded during limit enforcement

* Add isPendingEditor to useEditorContext

---------

Co-authored-by: Thomas Mees <thomas.mees@overleaf.com>
GitOrigin-RevId: b622213f6282ccd8ee85a23ceb29b8c6f8ff6a96
2024-08-22 14:01:25 +00:00
Alf Eaton
18ee2bc87a Delete unused Bootstrap LESS files (#19849)
GitOrigin-RevId: 80f802c67164f317ab68c13ef4e4e7dcf6fbc7ea
2024-08-22 14:01:21 +00:00
Alf Eaton
e61eb1b220 Merge pull request #20008 from overleaf/ae-review-panel-empty-state
Improve calculations of empty state, mini state and sizes variables in review panel

GitOrigin-RevId: 41bcb3b67c9f0019c11b4de0e4590b0407e04e66
2024-08-22 14:01:16 +00:00
Jakob Ackermann
989c48978a Merge pull request #20067 from overleaf/jpa-fix-old-blob-download
[web] project-history expects history-v1 id in blob requests

GitOrigin-RevId: d9170a12fc6070811c188b346dbac32accabbfd7
2024-08-22 14:01:12 +00:00
Miguel Serrano
0346ba2698 [web] CE script to verify TexLive versions on startup (#19653)
* [web] CE script to verify TexLive versions on startup

---------

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: b99001d38468a775991a7284611aa333e956b919
2024-08-22 14:01:07 +00:00
ilkin-overleaf
b4ad1ed35d Merge pull request #19961 from overleaf/td-contact-modal-sp-ce-fix
Fix SP and CE builds broken by Contact Us changes

GitOrigin-RevId: fb9099ed7d755b30ab8706facd6f0d95aefbad1e
2024-08-22 14:00:54 +00:00
CloudBuild
d4f808152e auto update translation
GitOrigin-RevId: 9995a6ce69703a5237790765af8ec656b8942dde
2024-08-22 08:06:07 +00:00
Jessica Lawshe
753d46a755 Merge pull request #20050 from overleaf/jel-contact-us-modal
[web] Open correct modal from plans FAQ

GitOrigin-RevId: aac42e88aefbfa71bda1869056a202d5536a0e33
2024-08-22 08:06:02 +00:00
Jessica Lawshe
eacd21adae Merge pull request #20049 from overleaf/jel-plans-accessibility
[web] Add tab container role for accessibility on plans page

GitOrigin-RevId: 697aba9fc64c2f08463c4d4e85a48b4cc1272e26
2024-08-22 08:05:57 +00:00
Jessica Lawshe
493bdc92d5 Merge pull request #20048 from overleaf/jel-plans-light-touch
[web] Plans page light touch redesign updates

GitOrigin-RevId: 71bb1a594e1767fe406bb63334534fd73b3d368a
2024-08-22 08:05:53 +00:00
Jessica Lawshe
cabf9b40d8 Merge pull request #20028 from overleaf/jel-plans-mobile
[web] Fix margin for card on student tab on mobile

GitOrigin-RevId: e9f4e61a85af99139cabfce7977c824bdfbcfd1f
2024-08-22 08:05:48 +00:00
Jessica Lawshe
b5a8481f51 Merge pull request #20020 from overleaf/jel-translation-fix
[web] Add missing "by" to translation

GitOrigin-RevId: aea106928b62b46753af845e37280297058cc42e
2024-08-22 08:05:40 +00:00
Jessica Lawshe
2b463f3062 Merge pull request #20004 from overleaf/jel-plans-tests
[web] Add unit tests for new plans page

GitOrigin-RevId: 8e5978d901d9faf123efbdd21ece65aad373cd94
2024-08-22 08:05:35 +00:00
Jessica Lawshe
8d63d56a6f Merge pull request #19992 from overleaf/jel-cms-quote
[web] Add new quote option to CMS

GitOrigin-RevId: 5c66620eb755fc9af9c8ba22d64ff969c5c140ca
2024-08-22 08:05:30 +00:00
Jessica Lawshe
130a04e9c2 Merge pull request #19990 from overleaf/jel-cms-pattern-cards
[web] Add new card options to CMS

GitOrigin-RevId: ca19f155a3b4da120f3e3a78800a0b0e5154468e
2024-08-22 08:05:25 +00:00
Jakob Ackermann
577497b655 Merge pull request #19842 from overleaf/jpa-ro-mirror-on-client
[misc] add readonly mirror of full project content on the client

GitOrigin-RevId: 940bd93bfd587f83ca383d10fc44579b38fc3e88
2024-08-22 08:05:13 +00:00
Jakob Ackermann
de842c61c3 Merge pull request #19863 from overleaf/jpa-log-noise-pro
[web] gracefully handle missing "getUserGroupsSSOEnrollmentStatus" hook

GitOrigin-RevId: 3e37a9caf4ccc54ec89c9a274bd4a55c503a3f43
2024-08-22 08:05:08 +00:00
Tim Down
d5643d53b3 Merge pull request #18996 from overleaf/td-bs5-nav-react
Main navigation React component

GitOrigin-RevId: c99a4b4a2f6fd02618689f829681118b2b64aa8d
2024-08-22 08:05:03 +00:00
Miguel Serrano
2296287e61 Merge pull request #19947 from overleaf/msm-ce-survey
[web] Temporary CE Survey

GitOrigin-RevId: 874febba1d61f7b9ba333b2de399c9bcc7f3bcc2
2024-08-22 08:04:54 +00:00
Miguel Serrano
1175b3b080 Merge pull request #19922 from overleaf/msm-fix-reversedHostname-launchpad
[web] Add missing `reversedHostname` for admins in CE/SP

GitOrigin-RevId: 2ce273e963a7471c514289cc042890bd1a14d4d2
2024-08-22 08:04:49 +00:00
CloudBuild
5db9bc63b7 auto update translation
GitOrigin-RevId: 93b259ff07e2988c39c2e2db614673a2899b7f68
2024-08-21 08:05:47 +00:00
M Fahru
41e2d1bba7 Merge pull request #20005 from overleaf/mf-view-events-plans-page
[web] Implement plans page and interstitial payment page view events for plans redesign test

GitOrigin-RevId: 023338acffe149db93b37d94cf06e8102ffcff8f
2024-08-21 08:05:43 +00:00
M Fahru
8e602b6ec6 Merge pull request #20027 from overleaf/mf-fix-mobile-group-cta
[web][new plans page] Fix mobile group CTA href

GitOrigin-RevId: ce4893d6a11b570cf7186909a23bc9c0e0c7e175
2024-08-21 08:05:32 +00:00
David
de3661f7c3 Merge pull request #20035 from overleaf/dp-pdf-fit-height
Update zoom on window resize when pdf zoom is set to page-height

GitOrigin-RevId: 19b963ffbd9da95c0c97642c7cd2195578c295d3
2024-08-21 08:05:20 +00:00
Mathias Jakobsen
52ff5ec4a7 Merge pull request #20030 from overleaf/mj-autocomplete-upgrade
[web] Upgrade codemirror/autocomplete version

GitOrigin-RevId: 3c2beebdd0217422d0c24defeb54ad62b5b0f0bf
2024-08-21 08:05:12 +00:00
Mathias Jakobsen
654d96ace6 Merge pull request #19743 from overleaf/mj-restore-project
[web+project-history] Add project version reverting

GitOrigin-RevId: 0f77cec730393187d531c0c6561faaa652bebf29
2024-08-21 08:05:08 +00:00
Davinder Singh
54f0c24633 Tear Down - Tearing down of registration and login pages redesign tests (#19750)
* tearing down the test for registration page

* deleting files that were used in delete register.pug file

* removing usage of websiteRedesignAssignmentVariant from remaining files

* deleting files for login page except ligh version

* removing the usage of websiteRedesignAssignmentVariant in remaining files

* moving light design to views folder because app was breaking, also renaming the file to login.pug and moving the two related files to views folder

* running make cleanup_unused_locales

* updating the acceptance test to reflect the change

* tested the deleted register files and rmeoved the classes that were only being used in the deleted register files

* adding delete comments on classes for these files _registration_user_password _registration_sso

* combining the two .login-register-form-focus into one within website-redesign

* fixing the positioning of the validation message

* moving register files out of website-redesign

* adding back AnalyticsManager for view events

GitOrigin-RevId: 028bd65824c4d09cc6ad9950159a404af55ff97e
2024-08-21 08:05:03 +00:00
andrew rumble
777acc4040 Refactor mongodb infra module to remove unneeded code
GitOrigin-RevId: f907753dffd67ed279815693c37498ec255f1353
2024-08-21 08:04:59 +00:00
andrew rumble
da350a52fd Check that we are using same ObjectId as mongoose
GitOrigin-RevId: 95812e15365bea740dfd02215e706f8014239840
2024-08-21 08:04:50 +00:00
andrew rumble
d4cc50bc21 Placate the linter
GitOrigin-RevId: 064d796a5c3c49cfdacee5cf1a461d38f08425b3
2024-08-21 08:04:46 +00:00
andrew rumble
4e2bfd58a1 Handle removal of mongoose callback API for UserMemberships
GitOrigin-RevId: 0bdfaf4bfb357d75ee05513cf524540eef7fcec4
2024-08-21 08:04:42 +00:00
andrew rumble
330868ff0c Handle Mongoose callback api removal in test helpers
GitOrigin-RevId: 00b8128aed7727e7a1b6f8d2d92a5fbc3a7775fb
2024-08-21 08:04:37 +00:00
andrew rumble
5cd5c1bffc Use new ObjectId instead of ObjectId()
GitOrigin-RevId: bfbf9f1d6b84a13f32fce127f01a49b1deaee6fe
2024-08-21 08:04:33 +00:00
andrew rumble
e08c60424d Allow independent pools to be used for mongo/mongoose
GitOrigin-RevId: c0c7d8e3388fd9402d7b22b70eda9455b4ecc205
2024-08-21 08:04:29 +00:00
andrew rumble
032deaf05c Switch to mongodb-legacy
GitOrigin-RevId: 11e09528c153de6b7766d18c3c90d94962190371
2024-08-21 08:04:24 +00:00
andrew rumble
04b46fa5ff Install new mongodb-legacy and mongoose
GitOrigin-RevId: 66000d8c4752fcd51152854ff1eb255f7382607c
2024-08-21 08:04:19 +00:00
Alf Eaton
ee8b8d0692 Merge pull request #20007 from overleaf/ae-review-panel-container-ref
Fix event listener attachment to review panel container

GitOrigin-RevId: ceb1023d7be48d9b88e725963124cd04e98127bd
2024-08-20 08:04:59 +00:00
Tim Down
7e187d903b Merge pull request #20021 from overleaf/td-bs3-contact-missing-options
Fix for missing select options in contact form in BS3

GitOrigin-RevId: a6be34114da53caef0fb3a8c9c8bab04663e7a62
2024-08-20 08:04:52 +00:00
David
ced42ec748 Merge pull request #19998 from overleaf/dp-presentation-mousewheel
Navigate pdf pages in presentation mode using mousewheel/trackpad

GitOrigin-RevId: 960e3456bb02e2286776632638ad1e3892f59c6a
2024-08-20 08:04:40 +00:00
David
9416e69647 Merge pull request #19985 from overleaf/dp-resolved-threads
Implement redesigned resolved threads popover

GitOrigin-RevId: 4e462eb26a2f2f3194fca89c39d5f9d08ea2e33c
2024-08-20 08:04:35 +00:00
David
93ba9fa28a Merge pull request #20001 from overleaf/dp-math-preview-split-test-badge
Add split test badge to math preview tooltip

GitOrigin-RevId: 9dfd30502f4b023bc7f640660904b0d3e7f4ce62
2024-08-20 08:04:31 +00:00
Alexandre Bourdin
a6c97cd506 Merge pull request #19946 from overleaf/ac-remove-ol-int-imports-from-tests
[web] Remove overleaf-integration imports from tests

GitOrigin-RevId: 96a3afaab386c486c948d35999f2acf4cedc77cf
2024-08-20 08:04:27 +00:00
Rebeka Dekany
0e43a18bc6 Merge pull request #19881 from overleaf/rd-filetree-context-menu
[web] Context menu should receive focus in the filetree on keyboard navigation

GitOrigin-RevId: aeec3713b32792bd5aef1756929a4fc893f30274
2024-08-20 08:04:18 +00:00
Rebeka Dekany
674300ed61 Merge pull request #19995 from overleaf/rd-remove-requirejs
Remove unused requirejs library

GitOrigin-RevId: fcdfe089d9a6f901b0470880dc1c260978646f14
2024-08-20 08:04:13 +00:00
CloudBuild
05cb96dc16 auto update translation
GitOrigin-RevId: 36aaf28d72c9426ffc717c51a32c479a47c130b6
2024-08-19 08:05:00 +00:00
Brian Gough
cb2434d29c Merge pull request #19777 from overleaf/bg-issue19430-implement-wiki-caching
support conditional requests for learn wiki images

GitOrigin-RevId: fb77ab632c325f88dfed1624a5abad8f2e52ee3d
2024-08-19 08:04:44 +00:00
CloudBuild
d78f7a3b19 auto update translation
GitOrigin-RevId: f5c7fcdddb5c63c6928de3788516dcf724f175fb
2024-08-16 08:05:14 +00:00
M Fahru
1184df03cc Merge pull request #19983 from overleaf/ds-features-table-header-fix
Plans page - fixing the features table header padding

GitOrigin-RevId: 6dd64493a0ad2b7e6c2778f82f79357b3bb65df4
2024-08-16 08:05:02 +00:00
M Fahru
ac91544752 Merge pull request #19958 from overleaf/jel-mobile-member-dropdown
[web] Fix "Contact Sales" link placement in license dropdown on mobile

GitOrigin-RevId: bd8363ed3fe8ee0ff239b0113fd560aab669f337
2024-08-16 08:04:58 +00:00
M Fahru
9cf4cd36cf Merge pull request #19942 from overleaf/mf-group-dropdown-connect-button-cta
[web] Connect license dropdown to CTA href and pricing header on new plans page group tab

GitOrigin-RevId: b3bdd05cc3efccc17883205de51232e31ee71c58
2024-08-16 08:04:53 +00:00
ilkin-overleaf
5f85e13033 Merge pull request #19899 from overleaf/ii-bs5-loading-page
[web] BS5 projects page loading screen

GitOrigin-RevId: d204c05b7245393b0d9e10fa885e844e4ce43e62
2024-08-16 08:04:48 +00:00
M Fahru
02adb4077d Merge pull request #19889 from overleaf/mf-group-member-dropdown-update-all
[web][new plans page] Synchronize all group member picker elements with the same plan type

GitOrigin-RevId: 33956784474c25383c66465da8a1025f3fe6131c
2024-08-16 08:04:31 +00:00
Alf Eaton
acba1b8956 Rebuild review panel entries when the editor viewport changes (#19962)
GitOrigin-RevId: af144a278a3338bffb58e40a91ddbeb204959dee
2024-08-16 08:04:27 +00:00
Domagoj Kriskovic
ad7abee39a Remove extra padding for off-screen review panel entries (#19841)
* Remove extra padding for off-screen review panel entries

* use document.activeElement

* cleanup editor padding cases

* using isSelectionWithinOp

* fix formatting

* focusHandler function

* 1px border for focused entry

* use constants

* using isFirstEntry

GitOrigin-RevId: 4509f803b6cb907b40f1745a6fc7f3b1edfe145c
2024-08-16 08:04:22 +00:00
Jimmy Domagala-Tang
b3d9ea5ad3 Merge pull request #19966 from overleaf/revert-19424-jdt-batch-spelling-line-tracker-updates
Revert "Line changes spread into array (avoiding max call stack)"

GitOrigin-RevId: 5039d4182aeeb5d8c3aed13af45af177755a3823
2024-08-15 08:06:03 +00:00
M Fahru
5065bb78ea Merge pull request #19904 from overleaf/ds-plans-page-new-design-adding-geo-banners
Plans page new design - Implement geo banner for India and latin america users

GitOrigin-RevId: 4b0ca2e6e290672c5ae1f41cde904a4d48197a33
2024-08-15 08:05:58 +00:00
M Fahru
50b11da587 Merge pull request #19855 from overleaf/mf-interstitial-new-plans-page-redesign
[web] Implement plans table for the new interstitial payment page

GitOrigin-RevId: 28b6a0c8c42d709d5be067d79f7f852fe188a3cf
2024-08-15 08:05:54 +00:00
Jimmy Domagala-Tang
cb6deab3a9 Merge pull request #19424 from overleaf/jdt-batch-spelling-line-tracker-updates
Line changes spread into array (avoiding max call stack)

GitOrigin-RevId: a60520b2aff18603bfe96b92abf305576661223a
2024-08-15 08:05:49 +00:00
Alf Eaton
806250a30e Refocus the PDF viewer after zooming with a keyboard shortcut (#19959)
GitOrigin-RevId: 61961ca4d5e6362923c7157296308c213649d4f3
2024-08-15 08:05:45 +00:00
Jessica Lawshe
692b3c0a2b Merge pull request #19909 from overleaf/jel-link-icon
[web] Add options for styling `Element | Link`

GitOrigin-RevId: 23db6df3b994f8106872771328b0b674a8fe381c
2024-08-15 08:05:33 +00:00
Jessica Lawshe
4b6872b737 Merge pull request #19935 from overleaf/jel-faq-plans
[web] Remove padding on inline buttons

GitOrigin-RevId: bb2f458b47d4ee48b93048490b1e60a8ff5f1ac0
2024-08-15 08:05:28 +00:00
Jessica Lawshe
ac06b0530c Merge pull request #19937 from overleaf/jel-new-period-toggle
[web] Add space between options in new plans period toggle

GitOrigin-RevId: fee13d4e933a5f2d16f14bbd1fd0b9b130a0084e
2024-08-15 08:05:24 +00:00
Jessica Lawshe
5496e13640 Merge pull request #19886 from overleaf/jel-plans-headers
[web] Separate column header pieces into new rows on new plans page

GitOrigin-RevId: db7f316ce8b7c983e7e000f95eb870962fc0bc9f
2024-08-15 08:05:19 +00:00
Mathias Jakobsen
a46219b055 Merge pull request #19308 from overleaf/mj-mendeley-search
[web+third-party-references] Add Mendeley search to Write & Cite

GitOrigin-RevId: 97c32076a178a71e37b0b57c543e98e44ef84f44
2024-08-15 08:05:11 +00:00
Alf Eaton
654090b1b3 Transpile PDF.js v4 with Babel (#19846)
GitOrigin-RevId: 1338dbae0683d72ab84ee58d1128d22754d14567
2024-08-15 08:05:06 +00:00
M Fahru
dfa8eee981 Merge pull request #19811 from overleaf/mf-group-tab-educational-discount-new-plans-page
[web] Implement educational discount for group plans in new plans page

GitOrigin-RevId: bd8c76c3bbcdad25ac0b1f2353c52b318db55c83
2024-08-15 08:05:02 +00:00
M Fahru
23dbf31a95 Plans page light touch: Remove unused CSS rules about hiding monthly-annual-switch on mobile for group tab.
This is removed because monthly-annual-switch is already hidden on all screen size for group tab.

(in the current plans page, monthly-annual-switch will be disabled on desktop and will be hidden on mobile)

GitOrigin-RevId: bdb682b97844b6e3fb50be3c65eb6bd945d73648
2024-08-15 08:04:57 +00:00
M Fahru
87e3459563 Fix aria-hidden attribute by adding explicit "true" to its value
GitOrigin-RevId: 173f2e2d18a993ee81506d420b120231e4f40574
2024-08-15 08:04:52 +00:00
Antoine Clausse
8e68f10523 [web] In _deleteV1Account: Add response?.statusCode optional chaining, await request before getting response (#19936)
* Add optional chaining in `response.statusCode` in `_deleteV1Account` error handling

Should fix https://overleaf.sentry.io/issues/5708988236/

* Add another `response?.statusCode`

* Await `V1Api.promises.request` before getting the response

GitOrigin-RevId: 52a156680845516357b11943bee8c33a5a023514
2024-08-15 08:04:44 +00:00
andrew rumble
019562cb5a Update promises to use async functions directly
GitOrigin-RevId: f6a5d235ee259a4cf00f1e8d5c089b2d1d24a842
2024-08-15 08:04:39 +00:00
andrew rumble
f13cb88f02 Update unit tests
GitOrigin-RevId: b7a0b6265fefae775f0ce8a61e57e5231930dc50
2024-08-15 08:04:35 +00:00
andrew rumble
7af4980a4d Promisify ProjectEntityUpdateHandler functions
Promisify wrapWithLock

Promisify getDocContext

Promisify updateDocLines

Promisify setRootDoc

Promisify unsetRootDoc

Promisify addDoc and addDocWithRanges

Promisify addFile

Promisify upsertFile

Promisify upsertDocWithPath

Promisify deleteEntity

Promisify deleteEntityWithPath

Promisify mkdirp and mkdirpWithExactCase

Promisify moveEntity

Promisify renameEntity

Promisify addFolder

Promisify convertDocToFile

Promisify resyncProjectHistory

Promisify _addDocAndSendToTpds

Promisify _replaceFile

Promisify _checkFiletree

Promisify _cleanupEntity

Promisify _updateProjectStructureWithDeletedEntity

Promisify _cleanUpDoc and _cleanUpFile

Promisify upsertFileWithPath

Promisify upsertDoc

Promisify _uploadFile

Promisify _addFileAndSendToTpds

GitOrigin-RevId: 56a7de0ae79efedd5ad48abae2db22a4028c0c12
2024-08-15 08:04:30 +00:00
andrew rumble
c4d7da87a6 Move functions to be promisified
Moving these first will make later commits have a cleaner diff. There
are no substantive code changes in the moved functions.

GitOrigin-RevId: 06e0c5bb02f300942c8fbe80e81484c4d717dbc9
2024-08-15 08:04:25 +00:00
Alexandre Bourdin
10ef61a02b Merge pull request #19901 from overleaf/ac-confirm-institution-domain-queue-in-institution-module
[web] Add `start` function to modules. Move `confirm-institution-domain` queue to institution module

GitOrigin-RevId: 0d36ff3dcc529e77c76d72d0a67bbdb9310b42fd
2024-08-14 08:05:39 +00:00
Alexandre Bourdin
0071439866 Merge pull request #19929 from overleaf/ac-test-show-upgrade-prompt
[web] Add acceptance test checking `showUpgradePrompt` in `/project/:id`

GitOrigin-RevId: 825c5c364bea07f9f3886443633f9022413d030f
2024-08-14 08:05:34 +00:00
Alexandre Bourdin
61891e3c80 Merge pull request #19861 from overleaf/ab-overleaf-integration-delete-flow
[web] Remove /user/delete override from overleaf-integration

GitOrigin-RevId: 4f679f6835522c2325fe7b0368f58e7a952ee73d
2024-08-14 08:05:30 +00:00
Brian Gough
cf83990459 add tests for unwanted 500 responses from invalid urls (#19612)
* add acceptance tests for bad urls

* fix 500 from health check when smoke test userId is undefined

* handle exception from invalid urls in ExpressLocals middleware

* Add return statement before `next()`

* Cleaned up list of crash_test_urls.txt

* Return 400 instead of 404 on parsing errors

---------

Co-authored-by: mserranom <mserranom@gmail.com>
GitOrigin-RevId: dac35b07d1f12bd9ceb70e3064ec2ef8393f99b5
2024-08-14 08:05:16 +00:00
ilkin-overleaf
ca802eab82 Merge pull request #19892 from overleaf/ii-bs5-projects-geo-banners
[web] BS5 projects page banners

GitOrigin-RevId: f5ceccbb7009c010f2917e0c34b7d3f02d7511f1
2024-08-14 08:05:11 +00:00
Jessica Lawshe
0f5184ac27 Merge pull request #18986 from overleaf/jel-faq-tabs-match-figma
[web] Style updates to new tab style to match Figma

GitOrigin-RevId: d78101cc53e00f309e52798214b9bc97d047828f
2024-08-14 08:05:07 +00:00
Eric Mc Sween
c117483761 Merge pull request #19882 from overleaf/mj-tcblisting
[web] Mark tcblisting as verbatim

GitOrigin-RevId: a64602b2b0d41c32e5f8612f190c6f5f8382f94b
2024-08-14 08:04:59 +00:00
Eric Mc Sween
e10478f256 Merge pull request #19867 from overleaf/em-hide-history-resync-details
Hide history resync changes

GitOrigin-RevId: a36876ff637d0a4c34150b21f4b4e623dff0ab03
2024-08-14 08:04:54 +00:00
M Fahru
40f3db3772 Merge pull request #19888 from overleaf/mf-new-plans-page-container-width-1280px
[web] Set new container width (1280px) and new main grid horizontal padding (16px) for all plans page redesign pages

GitOrigin-RevId: d266a8318dd4c2c90d9051bb58cca459799fca44
2024-08-14 08:04:50 +00:00
Davinder Singh
90c32aacee Merge pull request #19869 from overleaf/mf-plans-faq-button-use-material-symbols
[web] Use material symbols on plans FAQ's button

GitOrigin-RevId: 934f3627027a297fa39a835c98ff337f2a93d1d1
2024-08-14 08:04:46 +00:00
Davinder Singh
3a084d9606 Plans Page new design - Implement href for all of the CTA buttons for mobile screen (#19858)
* simplifying the logic of button rendering that matches the desktop version

* removing the plans_page_new_btn_buy_now_free mixin and adding the class .plans-cta-buttons-gap

* adding .plans-cta-buttons-gap to the desktop version

* changing table-header to mobile-card while calling the function

* adding styling into .plans-new-table-cta and removing plans-cta-buttons-gap usage from desktop version

* moving .plans-cta-buttons-gap into  .plans-card-cta-container-monthly-annual

* renaming the gap class to .plans-card-cta-buttons-container and using nth-child approach

* using the nth-child approach in .plans-new-table-cta

GitOrigin-RevId: 692814af8d8cf4dda0ea53dea9a3fe4adcf1dcd3
2024-08-14 08:04:42 +00:00
Tim Down
34fc43d59a Merge pull request #19126 from overleaf/td-bs5-contact-modal-react
React version of Contact Us modal

GitOrigin-RevId: 0bef3095f36daa88afdc6172a5531ed11e892047
2024-08-14 08:04:37 +00:00
Antoine Clausse
fb114a7c44 Merge pull request #19545 from overleaf/ac-remove-login-route-override
[web] Remove `/login` route override from overleaf-integration

GitOrigin-RevId: a22d0698e5039a8e77fb7ebb620500ad40a9a630
2024-08-14 08:04:26 +00:00
Rebeka Dekany
92a2debc9a Merge pull request #19557 from overleaf/rd-left-menu-dropdown
[web] Migrate the left menu on the project dashboard part #2

GitOrigin-RevId: 55b213352dd850650668bb4e507e11607aee0107
2024-08-13 08:04:42 +00:00
Jessica Lawshe
c636089939 Merge pull request #19822 from overleaf/jel-plans-notifications
[web] Show geo banners on light touch redesign of plans page

GitOrigin-RevId: 08ee6827cc16ec9326e5dbb1a165602be9cfe86d
2024-08-13 08:04:38 +00:00
Jessica Lawshe
47ad169781 Merge pull request #19758 from overleaf/jel-modal-light-touch
[web] Update group modal on plans page light touch redesign

GitOrigin-RevId: 26cce2996bed263c46d06b1b1fced8206fc9d8c1
2024-08-13 08:04:33 +00:00
Jessica Lawshe
214f093eb7 Merge pull request #19749 from overleaf/jel-fix-first-feature-row-border
[web] Fix first feature row border radius on light touch plans redesign

GitOrigin-RevId: 2ef5b1cbb13284a95d6c5d9370cd003f4ccf7f48
2024-08-13 08:04:29 +00:00
Jessica Lawshe
c4c36c9cea Merge pull request #19725 from overleaf/jel-interstitial-page-light-touch
[web] Interstitial payment page for light touch redesign

GitOrigin-RevId: ff83df760dd552d001ad8815f0a34cae5e13e6ff
2024-08-13 08:04:25 +00:00
Alf Eaton
2304536844 Add review panel context providers and components (#19490)
* Tidy up review panel components

* Add ReviewPanel providers

* [web] new design for review panel track change (#19544)

* [web] new design for review panel track change

* fixed mini view

* mini icon style change

* fix icon size

* format date

* useRangesUserContext hook

* remove useRangesUserContext hook

* using full class names

* fix action icons hover

* change wording for tooltips

* added ReviewPanelChangeUser component

* Update header in new review panel

* Extract ReviewPanelTrackChangesMenuButton as a separate component

* Remove wrapper div

* Replace h2 with div for review panel label

* Rename ReviewPanelTools to ReviewPanelHeader

* Rename trackChangesExpanded -> trackChangesMenuExpanded

* Dont break memoisation of ReviewPanelTrackChangesMenuButton

* Fix the width of the track changes arrow icon

* Update how prop types are declared

* Remove new empty state from old review panel

* Add empty state to new review panel

* Add project members and owner to ChangesUsers context (#19624)

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>

* Redesign comment entry in review panel (#19678)

* Redesign comment entry in review panel

* ReviewPanelCommentOptions component

* remove unused prop

* Tidying

* Add conditional import

* Optional changeManager

* Add more split test compatibility

* More split test compatibility

* Fixes

* Improve overview scrolling

* Fix overview scrolling

* Fix & simplify track changes toggle

* Fix overview scrolling

* Fix current file container

* ExpandableContent component for messages in review panel (#19738)

* ExpandableContent component for messages in review panel

* remove isExpanded dependancy

* Delete comment option for new review panel (#19772)

* Delete comment option for new review panel

* dont show thread warning if there are no replies

* fix hasReplies issue

* Implement initial collapsing overview files

* Fix positioning of overview panel

* Small styling changes

* Add count of unresolved comments and tracked chanegs

* More style adjustments

* Move review-panel-overview styles into css file

* Remove unused var

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
Co-authored-by: David Powell <david.powell@overleaf.com>
Co-authored-by: David <33458145+davidmcpowell@users.noreply.github.com>
GitOrigin-RevId: e67463443d541f88445a86eed5e2b6ec6040f9c7
2024-08-13 08:04:20 +00:00
Antoine Clausse
8736bee460 [web] Move confirm_university_domain to institutions module, and /api/clsi/compile/* to publish-modal module (#19797)
* Move `/api/institutions/confirm_university_domain` to institutions module

* Move `confirmDomain` to institutions module

* Move `/api/clsi/compile/*` endpoints to `publish-modal` module

* Move ApiClsiTests to publish-modal module

* Revert move of MockClsiApi. It's still needed in the main acceptance tests

GitOrigin-RevId: b59c2921e03b94546d72d21e60a688eb1ae1d05e
2024-08-12 08:05:16 +00:00
CloudBuild
4bb4601d9d auto update translation
GitOrigin-RevId: 0e47a561a715d5a12cbffc3b20076cf1c932cfa8
2024-08-12 08:05:08 +00:00
ilkin-overleaf
16cdf5140a Merge pull request #19626 from overleaf/ii-invite-remove-unncecessary-fields
[web] Clean up props exposed to the /invite and /invites endpoints

GitOrigin-RevId: dc4163e04d5785e141d5e322bfb0a626e67d637f
2024-08-12 08:05:04 +00:00
Rebeka Dekany
57b3871c1c Merge pull request #19823 from overleaf/rd-navbar-pug-a11y
[web] Announce buttons as menu items in the navigation bar and allow tabbing within the menu

GitOrigin-RevId: 138fef3369bf5c89487e673ab42c06b7c13bcf48
2024-08-12 08:04:54 +00:00
Alexandre Bourdin
972fbb7c67 Merge pull request #19818 from overleaf/ab-fix-split-test-archived-notification-comment
[web] Skip sending last versions comment with archived test notification

GitOrigin-RevId: 997111220161eaf7588cac8809024ac4a09bc037
2024-08-09 08:04:38 +00:00
M Fahru
b1cfb00e30 Merge pull request #19760 from overleaf/mf-more-than-50-group-member-picker
[web] Create group member picker footer with a link that opens contact sales modal on new plans page

GitOrigin-RevId: 1dc1dce726cc0222bbbef911a016f1eb6a881aeb
2024-08-09 08:04:34 +00:00
Thomas
a16db120c0 Implement free trial limits (#19507)
* Add additional validations for subscription trials

GitOrigin-RevId: 1cb821c62e02d3eaa5b2bcacaee63b6bc7a63311
2024-08-08 08:05:05 +00:00
Jakob Ackermann
3836323724 Merge pull request #19817 from overleaf/jpa-types
[overleaf-editor-core] stronger type checking via web

GitOrigin-RevId: 427019f40e2905f2e0ec11dc09f5fccdbb1f905b
2024-08-08 08:05:01 +00:00
Rebeka Dekany
bd87e1b41b Merge pull request #19578 from overleaf/rd-focus-input
[web] Override the Bootstrap 5 default invalid focus style on Form Control elements

GitOrigin-RevId: 8a352eac4d1fb2848b5449975700e194b074cdd2
2024-08-08 08:04:56 +00:00
Davinder Singh
d9744bc35c Plans page (New design Mobile) - Adding group member picker dropdown in groups plans card in mobile screen (#19718)
* adding group_member_picker mixin on mobile screen

* renaming screenSize to device

* adding a Separator before device name

* removing period argument passing from plans-cat mixin

* creating a z-index z-index-group-member-picker-list to avoid the overlap of the dropdown menu on the list above it

GitOrigin-RevId: 538f08064f72cbc85343ee3b44645231b894b9d4
2024-08-08 08:04:42 +00:00
Mathias Jakobsen
39f10a82bb Merge pull request #19834 from overleaf/mj-cite-key-search-teardown
[web] Tear down cite-key-search event

GitOrigin-RevId: 24cc18c276f166fbe474c99e384f8572ce7ee0ec
2024-08-08 08:04:30 +00:00
Alf Eaton
a71e61791c Merge pull request #19830 from overleaf/ae-iterator-polyfill
Always use ReadableStream asyncIterator polyfill

GitOrigin-RevId: 660a7316a549fe4ce4fc6bd1ef1a7d7e58759f14
2024-08-08 08:04:26 +00:00
Alf Eaton
901d79dd55 Merge pull request #19757 from overleaf/ae-eslint-upgrade
Upgrade `@typescript-eslint` dependencies

GitOrigin-RevId: b953e795d705b817ec3669b04cd6a289be12b20d
2024-08-08 08:04:09 +00:00
Alf Eaton
6ec26060e4 Move updateListener out of sourceOnly wrapper (#19573)
GitOrigin-RevId: 3633b7c9763eac05793c2099124bd78369f90a73
2024-08-07 08:05:50 +00:00
Alf Eaton
049f8af680 Merge pull request #19684 from overleaf/ae-members-list
Allow all collaborators to access the project `members` endpoint

GitOrigin-RevId: 2e5911146c61f368f85e6b57a9c5f12a35e7b294
2024-08-07 08:05:45 +00:00
Alf Eaton
5067c0b22d Merge pull request #19712 from overleaf/ae-fetch-first-log-part
Stream and truncate large log files

GitOrigin-RevId: 9d9058d1cc0b3c7a56b25ff34f7a41bfe3e59772
2024-08-07 08:05:37 +00:00
Jimmy Domagala-Tang
4bfcb666e3 Merge pull request #19640 from overleaf/jdt-integrations-anchor
Add Id to integrations section in settings

GitOrigin-RevId: 347102cd4050e8d56904bf2462f530f73e3f1fc4
2024-08-07 08:05:17 +00:00
Thomas
2ee528a9d2 Merge pull request #19814 from overleaf/tm-link-sharing-project-joined-event-for-treatment
Add project-joined event when adding as Editor via link sharing

GitOrigin-RevId: 40f538376b90a45877859be9e48a0b4c45c9641d
2024-08-07 08:05:12 +00:00
Jakob Ackermann
d2464abc7c Merge pull request #19816 from overleaf/jpa-type-tweaks
[web] minor typescript tweaks

GitOrigin-RevId: df459d2c00652a3d183cae123f39a01dd17c7ec6
2024-08-07 08:05:08 +00:00
Antoine Clausse
a278e70b27 [web] Fix UpgradePrompt in Editor - Retrieve isMember from userIsMemberOfGroupSubscription (#19810)
* Fix: Retrieve `isMember` from `userIsMemberOfGroupSubscription`

* Inline `userIsMemberOfGroupSubscription` call

GitOrigin-RevId: b8b339bbce3934b0b83bf6d805ab6ef6225d43e7
2024-08-07 08:05:03 +00:00
M Fahru
2113a94aff Merge pull request #19784 from overleaf/mf-interstitial-payment-new-design-switcher
[web] Implement new interstitial payment page period switcher and header

GitOrigin-RevId: cd60909bad3c597661ba99a785ca49ed85b75af3
2024-08-07 08:04:52 +00:00
Jakob Ackermann
eede7fe313 Merge pull request #19791 from overleaf/jpa-enable-synctex-test
[server-ce] tests: re-enable test for sync to pdf

GitOrigin-RevId: fd111ba1ff846acfe82735b4bc47f68929266254
2024-08-07 08:04:37 +00:00
Jakob Ackermann
399e834e36 Merge pull request #19764 from overleaf/jpa-server-pro-cache
[server-pro] faster local build

GitOrigin-RevId: d71abde37253e4c0398afa6935290af79a1204be
2024-08-07 08:04:24 +00:00
Mathias Jakobsen
7aaa78e635 Merge pull request #19788 from overleaf/mj-cite-key-search-ref-providers
[web] Add ref provider info to cite-key-search event

GitOrigin-RevId: 1f3828e3f5305f06190332b637860fde606f7484
2024-08-07 08:04:19 +00:00
David
d2289379cd Merge pull request #19633 from overleaf/dp-tooltip-colour
Update styling for math-preview tooltip in dark editor themes

GitOrigin-RevId: bfd02793d1438cfeee173210f57b1fbb4c28ccc3
2024-08-06 08:05:16 +00:00
Alexandre Bourdin
34e7f3182b Merge pull request #19747 from overleaf/ab-v1-project-import-module
[web] Extract code to v1-projects module

GitOrigin-RevId: 8f8a99891d3a1505aafca08f06fb439d4b596899
2024-08-06 08:05:11 +00:00