Antoine Clausse
5f2718cf29
[web] Make rate-limit on login consistent, prevent "trim/case bypass" ( #19555 )
...
* Replace `LoginRateLimiter.processLoginRequest` call by use of `RateLimiterMiddleware`
* Lowercase the email to avoid rate-limit bypass
* Remove unit test "when the users rate limit"
* Use `EmailHelper.parseEmail` to normalize email in `processLoginRequest`
This should address the `trim()` bypass
* Use `.trim().toLowerCase()` instead of `EmailHelper.parseEmail`
We can't use `EmailHelper.parseEmail`, else it breaks the test (and feature): "with username that does not look like an email"
* Add acceptance test for rate limit
* Add comment on rate limits
* Rename `rateLimiter` to `rateLimiterLoginEmail` for clarity
* Make the login rate limits configurable from the settings
GitOrigin-RevId: cf1c3a416745f2b007c85014a5084570d4a049a7
2024-07-30 08:04:26 +00:00
Antoine Clausse
7212c16dde
[web] Fix: sendConfirmationEmail promise (!!!) ( #19629 )
...
* Fix `sendConfirmationEmail` promise (!!!)
* Fix: No nested promises, and `sendConfirmationEmail`->`sendReconfirmationEmail`
* Add integration test on `/user/emails/send-reconfirmation`
* Update integration test: use the previously generated token
GitOrigin-RevId: f6386abeb06888351eec22fbcb1d3c614ff5c5c5
2024-07-29 08:04:41 +00:00
Antoine Clausse
afd965c04b
[web] Remove overleaf-integration overrides for /user/emails/delete & /user/emails/resend_confirmation ( #19438 )
...
* Use hooks to call `clearSamlSession`
* Promisify `UserEmailsController.remove`
* Use hook for `userDeleteEmailMiddleware`
* Remove `/user/emails/delete` override
* Remove "removeRoute of `/user/emails/resend-secondary-confirmation`"
That route isn't defined elsewhere
* Promisify `UserEmailsController.resendConfirmation`
* Promisify `UserEmailsController.sendReconfirmation`
* Use hook for `resendConfirmationEmailMiddleware`
* Remove `/user/emails/resend_confirmation` override
* Promisify `tryDeleteUser`
* Proxy `clearSamlSession` through `SAMLHelper`
* Revert "Use hook for `resendConfirmationEmailMiddleware`"
This reverts commit f028d9c8
* Inject `SAMLMiddleware.resendConfirmationEmailMiddleware` in `/user/emails/resend_confirmation`
* Update `middleware` syntax and grammar
* Update tests
* Use Module middleware instead of hook for `userDeleteEmailMiddleware`
* Remove "promises" export of tryDeleteUser
GitOrigin-RevId: 211e194fc1ef82dc452ee4e837dcddd9b23690a0
2024-07-29 08:04:24 +00:00
Jessica Lawshe
606f9eaec7
Merge pull request #19594 from overleaf/jel-light-touch-table-checkmark
...
[web] Add new green checkmark to plans light touch redesign
GitOrigin-RevId: f6c38e819fdd784ccf39ab09109a33fcd58f23d8
2024-07-26 08:05:02 +00:00
Jessica Lawshe
1f432ca5a9
Merge pull request #19447 from overleaf/jel-light-touch-table-final-bits
...
[web] Updates for the light touch redesign of the plans table
GitOrigin-RevId: 44ba4fde9b192f3792bf295557fa1018c83a2119
2024-07-26 08:04:53 +00:00
Jessica Lawshe
85ec182859
Merge pull request #19446 from overleaf/jel-light-touch-file-reorg
...
[web] File reorganization of light touch redesign
GitOrigin-RevId: 6ea13a5d0053bdfd71f9d29d417f73f06a492d49
2024-07-26 08:04:48 +00:00
Jessica Lawshe
72821743fc
Merge pull request #19415 from overleaf/jel-highlighted-col
...
[web] Update highlighted column for plans page light touch redesign
GitOrigin-RevId: 98a0d6c34762bb7f4530da9cd6d954c2ae1aae56
2024-07-26 08:04:44 +00:00
Jimmy Domagala-Tang
918c3e7e33
Merge pull request #19301 from overleaf/jdt-collaborator-ai-usage
...
Prevent AI usage on projects where collaborators have a blocking policy
GitOrigin-RevId: 93bdd9c5accff51a14f0585249e13ed7f1fa4e53
2024-07-26 08:04:35 +00:00
David
d7357b4d62
Merge pull request #19400 from overleaf/dp-duplicate-file-folder-name
...
Improvements to handling of file/folder upload conflicts
GitOrigin-RevId: 526edf30dfbaec7ee1e03ffd156365f09be25e86
2024-07-25 08:05:08 +00:00
David
c07d2f3fa2
Merge pull request #19528 from overleaf/dp-equation-preview
...
Equation Preview
GitOrigin-RevId: 98e71e5d2c1a83d6c9fa685eeee1f4b93a5a3da1
2024-07-25 08:05:04 +00:00
M Fahru
394d07d03e
Merge pull request #19509 from overleaf/mf-contact-support-faq
...
Implement contact support link below FAQ section
GitOrigin-RevId: 5c22c9807522b3ba88169b759520feb165f3f499
2024-07-25 08:04:51 +00:00
Alf Eaton
7e136131c0
Promisify Metadata feature ( #19361 )
...
GitOrigin-RevId: 962aa9dbbc41a49c2c3120af9a1254a4db85387b
2024-07-24 08:05:19 +00:00
Alexandre Bourdin
8e79d72cc2
Merge pull request #19465 from overleaf/ab-modules-middlewares
...
[web] Support injecting middlewares from modules
GitOrigin-RevId: efbf68d885f839b92f2e601553c7ce54b9d4b6d3
2024-07-24 08:05:09 +00:00
Mathias Jakobsen
34422b1428
Merge pull request #19418 from overleaf/mj-write-and-cite-custom-render
...
[web] Write & Cite autocomplete prototype
GitOrigin-RevId: f51edb9b1ab9cc2ac8f18277cb291ee87650c213
2024-07-24 08:05:04 +00:00
Rebeka Dekany
6cb956b1ff
Merge pull request #19472 from overleaf/rd-stylelint-ci
...
[web] Add Stylelint formatting to the CI
GitOrigin-RevId: f31139f9f6f70aa96214b59db37ad1f79cd1e733
2024-07-23 08:04:09 +00:00
David
277ac91f0e
Merge pull request #19390 from overleaf/dp-pdf-tools-teardown
...
Remove `pdf-controls` feature flag and old controls
GitOrigin-RevId: 807ee0aa6384df354809f4d59b10d00dadef898c
2024-07-22 08:04:22 +00:00
roo hutton
523e340a0d
Merge pull request #19398 from overleaf/rh-rm-ieee-notification
...
[web] Remove IEEE Collabratec notification
GitOrigin-RevId: 14ec3e50ed4913b815620f5215df59b17fc03054
2024-07-18 08:04:41 +00:00
Jimmy Domagala-Tang
168f83277b
Merge pull request #19328 from overleaf/jdt-global-metrics
...
Allow for site wide metrics and counters
GitOrigin-RevId: e788488bdd673aef4ba0e45a9e39832d6203c44c
2024-07-18 08:04:27 +00:00
andrew rumble
f54b257022
Remove special code for handling RequestFailedErrors
...
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: 821826fa56b89176b615e026f11db0b7fcfcbd30
2024-07-17 08:05:05 +00:00
andrew rumble
0e89857a9f
Remove unneeded/confusing assignment
...
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: 2aa48249cf216bc8cca7e95153695095923c0b86
2024-07-17 08:05:01 +00:00
andrew rumble
15ea69995a
Replace request with fetch-utils in ExpressLocals
...
GitOrigin-RevId: 85c112a2124aeca128753e40c70869517c7026f6
2024-07-17 08:04:57 +00:00
Jessica Lawshe
0ea17a1c5a
Merge pull request #19414 from overleaf/jel-light-touch-col-headers
...
[web] Update column header styling for light touch redesign of plans table
GitOrigin-RevId: d6b24f1c355256a5dcb2c75255eec610e064fd03
2024-07-16 08:05:15 +00:00
Jessica Lawshe
300e46a28d
Merge pull request #19379 from overleaf/jel-light-touch-separate-rows
...
[web] Separate column header sections into new rows
GitOrigin-RevId: cffe39933f877eaf07a9e772fd76b8e18dd95d3e
2024-07-16 08:05:10 +00:00
Jessica Lawshe
fada0b80eb
Merge pull request #19395 from overleaf/jel-light-touch-restructure-mixins
...
[web] Restructure column header mixins for light touch design
GitOrigin-RevId: b8f6d9084b7a0190a0ba421d1e3ba819358c7fa2
2024-07-16 08:05:05 +00:00
Jessica Lawshe
3084ff921b
Merge pull request #19376 from overleaf/jel-light-touch-remove-unused
...
[web] Remove unused code for light touch plans page redesign
GitOrigin-RevId: 9e160ed59eec5f8a700b88c0591fb0200c2dc403
2024-07-16 08:05:01 +00:00
Jessica Lawshe
ccac1047d6
Merge pull request #19332 from overleaf/jel-light-touch-plans-border
...
[web] Update border style for light touch redesign of plans page
GitOrigin-RevId: ba3df408ce626f4b2a3eb634de93d8879f3e9611
2024-07-16 08:04:56 +00:00
Jessica Lawshe
68e42efb20
Merge pull request #19331 from overleaf/jel-light-touch-rename-css
...
[web] Rename CSS variables for light touch redesign
GitOrigin-RevId: 8a56c56e2a743e935d70bd585d8c62a93faba0eb
2024-07-16 08:04:51 +00:00
Liangjun Song
f4a7b1f298
bypass linking sharing admin redirect for internal projects ( #19314 )
...
* disable linking sharing admin redirect
* address comments
* remove ignoreSiteAdmin
* load admin domains from settings
* add acceptance test
* more tests
* fix tests and restore admin domain
* use adminDomains as array
GitOrigin-RevId: 5acb62e1b6ada0aaeceab6db6a6635f82e30833f
2024-07-16 08:04:35 +00:00
Alf Eaton
1e1a8c0bb3
Add translated messages for more connection error states ( #19392 )
...
GitOrigin-RevId: 981de624f3964ebe3ff1f0c751fcef9158864d5e
2024-07-15 09:32:55 +00:00
ilkin-overleaf
b442a74f54
Merge pull request #19249 from overleaf/ii-invite-token-response
...
[web] Fix share modal resend status code
GitOrigin-RevId: 303f7b6c49d9522df6317789bb7c3c69d774715f
2024-07-15 09:05:02 +00:00
M Fahru
3304aaddf3
Merge pull request #18962 from overleaf/mf-interstitial-payment-new-plans-page-config
...
[web] Implement website-redesign-plans split test config on interstitial payment page
GitOrigin-RevId: 6ea51d5f89ac6b633b5ce6dfbb81c258d668ce13
2024-07-15 09:04:53 +00:00
Jimmy Domagala-Tang
ffad592f8d
Merge pull request #19317 from overleaf/jdt-fake-foor-test
...
AI error assistant fake door test
GitOrigin-RevId: 9ba5480a50d9881fa0ce2f3632f94ffe57d7a152
2024-07-15 09:04:48 +00:00
Thomas
ab4a4df931
Merge pull request #19348 from overleaf/tm-link-sharing-changes-events-fixes
...
Link sharing changes events fixes for collaborator sharing-updates prompt and project open event
GitOrigin-RevId: 45449f0dd27e07de189a9c2620b0aa9a8849dc41
2024-07-15 09:04:44 +00:00
David
0c7a32b4f2
Merge pull request #19346 from overleaf/dp-review-panel-empty-state
...
Add empty state to review panel
GitOrigin-RevId: 47d7b676e9868942567fc02db234b0827ac86ba3
2024-07-15 09:04:27 +00:00
Mathias Jakobsen
1f0e346bbc
Merge pull request #19373 from overleaf/mj-comment-regex-fix
...
[web] Fix regex in comment matching
GitOrigin-RevId: e341f13a9ccbe2fbc1ec6c6c1d8a7a11c4dd4e37
2024-07-15 09:04:07 +00:00
Alf Eaton
87d1c08e2f
Merge pull request #19325 from overleaf/ae-metadata-packages
...
Include all package names in the project metadata
GitOrigin-RevId: dd30eb254806248484c9c6d9210f38c7c69a0ba1
2024-07-15 09:03:32 +00:00
Eric Mc Sween
f63de6779d
Merge pull request #19329 from overleaf/em-migration-progress-logs
...
Log progress during history migration
GitOrigin-RevId: a3af8722b40af2b0ffe9603b6d6dcea02cee833d
2024-07-15 09:02:31 +00:00
Jimmy Domagala-Tang
e47a790af9
Merge pull request #19292 from overleaf/jdt-mj-imported-at
...
copying a project should preserve a linked files created timestamp
GitOrigin-RevId: d82506db1fb3f54567e638346179413468419b82
2024-07-15 09:02:08 +00:00
Eric Mc Sween
0be042e331
Merge pull request #19318 from overleaf/mj-revert-check-ranges-support
...
[web] Check that project has ranges support when reverting
GitOrigin-RevId: 761e435e9d640c08f27dd4ad2cef95934c0cc48b
2024-07-15 09:02:03 +00:00
Miguel Serrano
b5e5d39c3a
[web] Tighten check for spelling language ( #19297 )
...
* [web] Tighten check for spelling language
* spelling proxy only for `/check` requests
GitOrigin-RevId: c678e93cca9ad39682ec7ce6e49804ea74741acc
2024-07-15 09:01:45 +00:00
Eric Mc Sween
fbdf245517
Merge pull request #19273 from overleaf/em-history-migration-concurrency
...
Add concurrency option to history ranges support migration script
GitOrigin-RevId: 8707abc9b76116090332b6abb11030adb17ceb4e
2024-07-15 09:00:46 +00:00
Eric Mc Sween
1b84f005cc
Merge pull request #19271 from overleaf/em-really-skip-projects-without-history
...
Refine check for existence of history in migration script
GitOrigin-RevId: 8ad5706525f5043694e516d585a7aef85a1e5566
2024-07-05 08:04:39 +00:00
Eric Mc Sween
01ce2721c0
Merge pull request #19255 from overleaf/em-increase-timeout-docstore-has-ranges
...
Handle docstore timeouts during history migration
GitOrigin-RevId: 9b00aa039fc9646c24e69bfca51dd8e784434fc6
2024-07-05 08:04:26 +00:00
Eric Mc Sween
194d778c28
Merge pull request #19242 from overleaf/em-api-error-handlers
...
Handle more errors in the global API error handler
GitOrigin-RevId: add31e2de067e8534f2eb3932623c2413c4ce6d8
2024-07-04 08:05:31 +00:00
Eric Mc Sween
898f6c81c8
Merge pull request #19250 from overleaf/em-skip-no-history
...
Skip projects without history when migrating
GitOrigin-RevId: d38539fbc1b6e406b833f849276c3829ad722d91
2024-07-04 08:05:26 +00:00
Jakob Ackermann
9406b2bd31
Merge pull request #19245 from overleaf/jpa-fix-invite
...
[web] use project invite token from request path
GitOrigin-RevId: d2670c3f10f8c9a15420fab7506f9ebdf4108c6c
2024-07-04 08:05:04 +00:00
ilkin-overleaf
f9245b8c08
Merge pull request #19071 from overleaf/ii-invite-token-remove-token-field
...
[web] Remove the token field from `projectInvites` collection
GitOrigin-RevId: fe8395e1d1a0ba2daad600b7e3be657f40151a8e
2024-07-04 08:05:00 +00:00
Jakob Ackermann
88457a6655
Merge pull request #19220 from overleaf/jpa-precompile-pug
...
[web] precompile pug templates in CI
GitOrigin-RevId: 6ec2b85a357fa3d5c35d8e7eb1a2e81ac5f3b447
2024-07-04 08:04:51 +00:00
Eric Mc Sween
a95c0bbfc3
Merge pull request #19151 from overleaf/em-history-ranges-quick-migration
...
Add quick history ranges support migration
GitOrigin-RevId: 8446beb6bcd7384c32fc1b216e4b72d8f5d91500
2024-07-03 08:04:44 +00:00
Jimmy Domagala-Tang
f77894c427
Merge pull request #19238 from overleaf/jdt-use-ai-project-fix
...
feat: matching rename to checkPermissions within projectController
GitOrigin-RevId: ea05800c145858237fb0b236f9a19837c6c4a9a2
2024-07-03 08:04:36 +00:00
