Commit graph

369 commits

Author SHA1 Message Date
ilkin-overleaf
9b930d2849 Merge pull request #13414 from overleaf/ii-review-panel-migration-create-context-api-fix
[web] Create context api for review panel FIX

GitOrigin-RevId: fc6d8adf18d07e71b529a28deab4d49d62c43587
2023-07-17 10:32:07 +00:00
Alf Eaton
480ec139ab Merge pull request #13408 from overleaf/ae-revert-resolve-comment
Revert "create context api for review panel"

GitOrigin-RevId: 3be70d7afbe4f238a27149ab2de38175cf1bf029
2023-07-17 10:30:27 +00:00
ilkin-overleaf
1918ef3767 Merge pull request #13378 from overleaf/ii-review-panel-migration-create-context-api
[web] Create context api for review panel

GitOrigin-RevId: 3d550e2f3c14ecd0586d088f4ecb75acd44aa782
2023-07-17 10:29:53 +00:00
ilkin-overleaf
2fceaa6085 Merge pull request #13343 from overleaf/ii-review-panel-migration-create-feature-flag
[web] Create feature flag for review panel

GitOrigin-RevId: e7e83729a536dce1824f604fb66afe1785f4be25
2023-07-17 10:26:04 +00:00
Alf Eaton
08ccdb79d3 [cm6] Improve alignment of review panel elements (#12710)
* Use a block widget for top padding
* Update review panel positions when the editor geometry changes
* Remove editorPaddingTop from position calculations
* Recalculate review panel on start adding comment
* Assert on line content rather than index
* Use broadcastChange
* Keep focus in the editor when opening the review panel
* debounce broadcastChange
* Set CULL_AFTER to Infinity

GitOrigin-RevId: a8d7b8967736a9164b5264eeaadf334c15ec95ce
2023-04-25 08:05:02 +00:00
Mathias Jakobsen
462837b44d Merge pull request #12701 from overleaf/dk-cm6-autocomplete-item-space
[cm6] Add space after item autocomplete

GitOrigin-RevId: 6fff77c0c0563530af981bbac73b1d88e02bb759
2023-04-21 08:03:08 +00:00
Tim Down
7f37ba737c Move source editor out of module (#12457)
* Update Copybara options in preparation for open-sourcing the source editor

* Move files

* Update paths

* Remove source-editor module and checks for its existence

* Explicitly mention CM6 license in files that contain code adapted from CM6

GitOrigin-RevId: 89b7cc2b409db01ad103198ccbd1b126ab56349b
2023-04-13 08:40:56 +00:00
Alf Eaton
9c78422efa Jump to line after the stored scroll position has been restored (#12324)
GitOrigin-RevId: 82265c6b0cab1ed3a34343efc5d47648e72dc41e
2023-03-30 08:03:25 +00:00
Tim Down
e76bcbec8d Merge pull request #12316 from overleaf/td-history-view-shell-and-split-test
Add empty shell for React history view, viewable based on split test

GitOrigin-RevId: 97241d56a052648c7a0d293d323dad4b00ad4159
2023-03-23 09:04:38 +00:00
Tim Down
fec6b8e4f1 Merge pull request #11961 from overleaf/mj-helpful-graphics-error-alternatives
[web] Handle more types of undefined control sequence error messages

GitOrigin-RevId: c6fc0c4d87febcda2521e182df56dcebaed58293
2023-03-02 09:04:53 +00:00
ilkin-overleaf
44b1f555f1 Merge pull request #12001 from overleaf/ae-backspace
Remove BackspaceHighjack

GitOrigin-RevId: 7b20bff7d52b20152c437ba8bc773c4f37ad1fc3
2023-03-01 09:03:11 +00:00
M Fahru
b62cb86bf8 Create new SplitMenu component and implement it for the pdf compile button (detached & non-detached) (#11772)
* Create a new shared `SplitMenu` component.

* Refactor the pdf compile button & detached compile button:
    - Rename `detach-compile-button` to `detach-compile-button-wrapper`
    - Rename `pdf-compile-button-inner` to `detach-compile-button`
    - Move some of the logic from `detach-compile-button-wrapper` to `detach-compile-button`
    - Create a new `compile-button.less` to centralize all of the compile button (detached/non-detached) custom styles rule.
    - Extract the animated striped CSS definition to the dedicated CSS file, change the class from `btn-recompile-group-has-changes` to `btn-striped-animated`
    - Refactor other className(s) appropriately according to the new component name
    - Delete the unused `changes-to-autocompile` css rule since it has not been used anywhere

* Implement the new pdf compile button with the new `SplitMenu` component.

GitOrigin-RevId: d1d055bffd311923fc47b4681605ce8ba8e26f25
2023-02-22 09:04:42 +00:00
Alf Eaton
31d0d10cfc Merge pull request #11877 from overleaf/mj-undefined-control-sequence-help
[web] Improve error messages around missing packages

GitOrigin-RevId: d6f59f452cdc8a5a7e59b9809f68bd18f629ba32
2023-02-21 09:05:04 +00:00
Alf Eaton
6175df9f95 Show preview for PDF image (#11793)
GitOrigin-RevId: 5c7dde42cdfcf9952e47487358f7e2b52658cc59
2023-02-17 09:04:35 +00:00
M Fahru
47937c4073 Fix event "left-menu-documentation-click" not being fired properly (#11836)
GitOrigin-RevId: 5e9df12c699ff5c25389e8fb90fda73913e8c747
2023-02-16 09:05:00 +00:00
Miguel Serrano
55bdcf7664 Merge pull request #11583 from overleaf/msm-ace-ce
[web] Force ACE when `modules/source-editor` not available

GitOrigin-RevId: 2b43a048e882d99aa52ee8ead6c67152d4080eb2
2023-02-02 09:03:30 +00:00
Mathias Jakobsen
83e4a2fab6 [web] Try various file extensions for preview urls (#11467)
GitOrigin-RevId: 1dd8001c337b10450c83a58b4ab0904867a21250
2023-01-26 11:39:08 +00:00
Tim Down
a05438d9c7 Merge pull request #11332 from overleaf/td-remove-ace-split-test
Add handling for source-editor-legacy split test

GitOrigin-RevId: 9575087c34bc3f2e8b490846984bc97641c560aa
2023-01-25 09:06:26 +00:00
Mathias Jakobsen
fce0a45128 Merge pull request #11234 from overleaf/ae-editor-type-rich-text
Record `cm6-rich-text` editorType in editing session pings

GitOrigin-RevId: 32d8cb60361348123bf5825961eb7e8b6e740ce8
2023-01-17 09:05:05 +00:00
Alf Eaton
017f0b49a0 [rich-text] Add "rich-text" split test (#11180)
GitOrigin-RevId: 8df79f3c70020c8dba0793c8b548fd1f1e1fbf76
2023-01-13 09:04:31 +00:00
Alf Eaton
9f1f62b9be Add rich-text mode to CM6 (#10775)
Co-Authored-By: Mathias Jakobsen <3295293+hrjakobsen@users.noreply.github.com>
GitOrigin-RevId: 00e015cb216bb8a52d083e71b34dbe91a7cd6cc5
2022-12-13 09:03:54 +00:00
Tim Down
08567c290e Add second CM6 switch-away survey (#10789)
Restart CM6 switch-away survey

GitOrigin-RevId: 1d62aaf27834cb3919f6ca30c269a1ef3c2e9a5e
2022-12-07 09:04:35 +00:00
Tim Down
fd2863bf7a Merge pull request #10747 from overleaf/as-ace-perf-measurement
Add perf measurement of Ace editor

GitOrigin-RevId: b33eeac9f7c7f85355a9e8f34833aa94bee2f70a
2022-12-07 09:04:21 +00:00
Tim Down
fde8ab422b Merge pull request #10794 from overleaf/td-resize-while-loading
Ensure editor is the correct size after window resize during load

GitOrigin-RevId: 0677ef6aa5d1dd7b6aea9158343b8ccbb3a6562b
2022-12-07 09:04:14 +00:00
Alf Eaton
65b0fd73ea Improve "compile" keyboard shortcut handling (#10624)
* Improve "compile" keypress handling
* Remove "compile" keypress handling from PDF preview
* Remove compile shortcuts from CM6
* Use an event for Vim keybindings
* Remove event handlers from Angular/Ace
* Move useCompileTriggers into DetachCompileProvider

GitOrigin-RevId: 7f0e667b5106a849458e06ebb0f7a413d5d63430
2022-11-29 09:04:04 +00:00
M Fahru
ff944917a6 Don't force user to cm6 if they have ace as editor preference
GitOrigin-RevId: 78390fe420eb28b5731cb1cc719a0b53913509e1
2022-11-10 09:04:40 +00:00
Mathias Jakobsen
8ddfd958d2 Merge pull request #10348 from overleaf/mj-outline-fixes-redo
[cm6] File outline improvements

GitOrigin-RevId: 9f4859cb35476d4baf0b3e3c2c2cb5d1678fd4a8
2022-11-09 09:04:08 +00:00
M Fahru
19dd2f67e2 Implement "switch away survey" when users switching back to ace from cm6 (#10201)
Implement legacy source editor survey:

* Force user to switch to cm6 if they haven't seen switch away survey

* Only show user switch away survey if they open ace from another editor

* We need to wait 3 seconds until the survey is being shown

* Add comment to explain the reasoning of not showing cm6 switch away survey for rich text users

* Use localstorage `editor.has_seen_cm6_switch_away_survey` setter to not show the survey if user has seen the survey

* the `editor.has_seen_cm6_switch_away_survey` will have the value `true` even if user is not interacting with it, so update comment to reflect that

* Add `once: true` option to keydown event to avoid unnecessary callback invocation upon key presses

GitOrigin-RevId: c26be2bb39efac2dff112c821fca893e5993dcbf
2022-11-04 09:05:50 +00:00
Mathias Jakobsen
bcad89fd28 Merge pull request #10273 from overleaf/ae-docname-apply
Add a `$scope.$applyAsync` wrapper around the "open a new document" code

GitOrigin-RevId: 7c63338379053d20bd86f10d9db6855cb5c23fc3
2022-11-04 09:05:25 +00:00
Mathias Jakobsen
a54b633726 Merge pull request #10111 from overleaf/mj-lezer-file-outline
[web] Parser backed file outline

GitOrigin-RevId: 0825f4887ba4dae24a14dd1880d07b791d0b4cd9
2022-11-04 09:04:33 +00:00
Tim Down
cbc3aef728 Merge pull request #10109 from overleaf/ds-switch-component
Modifying the Switch

GitOrigin-RevId: 93b8483aa4aa164ea0be5fc2b4ccc5cfb17eae3c
2022-11-02 09:04:07 +00:00
Alf Eaton
5b9261e13e Dispatch doc:changed and doc:saved events in a debounced timeout (#10024)
GitOrigin-RevId: a55602b448d8b97f224c658fee0a97d2473f8cd1
2022-11-01 09:04:45 +00:00
M Fahru
797b9b2532 Migrate download menu in editor left menu to react (#10046)
* Initialize left menu react migration and migration download menu UI to react

* Add test case to DownloadMenu react component

* Update test description and add an href check to one of the download link

* Extract storybook document mock to its own fixture file

* Add mockCompileOnLoad config on storybook editor scope
  - if mockCompileOnLoad: true (default), then the default compile mock will be used
  - If mockCompileOnLoad: false, then we have to provide a compile mock on the storybook component

* Create download menu storybook component

* Use a single "editor-left-menu" controller on the editor left menu migrations

* Remove the form import from the react version of the left menu

* Change inline style to utility class name

GitOrigin-RevId: 5357c7bfc78bf40f52b9b308df8f2b60d793fbf7
2022-10-25 08:04:19 +00:00
Eric Mc Sween
7d099acfdd Merge pull request #9150 from overleaf/em-share-ranges-tracker
Move RangesTracker to shared lib

GitOrigin-RevId: 62da7208f0b453dd7272c06873c7e415ed887817
2022-10-05 13:26:01 +00:00
Tim Down
8388d808a5 Merge pull request #9678 from overleaf/ta-td-galileo-week6
Galileo Integration Banch Week 6

GitOrigin-RevId: 78fffeefdf350042a4c2400823fb2a668ee0f592
2022-09-22 08:03:55 +00:00
Timothée Alby
ac3bc987d9 Merge pull request #9297 from overleaf/ta-galileo-module
Create Galileo Module

GitOrigin-RevId: 0d9dfeebc150bd6a0d828f55be47f9d9f1a70d66
2022-08-19 08:04:56 +00:00
Alf Eaton
982897dcb9 Merge pull request #9142 from overleaf/ae-outline-pane-height-fix
Ensure that the outline pane has appropriate height when collapsed

GitOrigin-RevId: 806d5cbeacbeed5df05712a5f3d85ee535442147
2022-08-08 08:04:06 +00:00
ilkin-overleaf
c331e7c73b Merge pull request #9027 from overleaf/ae-file-tree-outline-default-size
Set a default size for the outline pane

GitOrigin-RevId: d06ede6cf026b1aff04e2eb4e05c69f40dd406e4
2022-08-08 08:03:45 +00:00
Jessica Lawshe
e3758f2060 Merge pull request #8804 from overleaf/jel-rich-text-pos
[web] Fix stored rich text position

GitOrigin-RevId: 7ef916919220d63d88f66ee261f91a5af08dcefb
2022-07-28 08:03:30 +00:00
Miguel Serrano
e9f7f19ca0 [web] SL history: fix incorrect var->let replacement (#8994)
GitOrigin-RevId: ea90be7d89f6c31156a30af3278218f93f1d5c6a
2022-07-27 12:18:13 +00:00
Timothée Alby
7b8d277437 Merge pull request #8898 from overleaf/ta-change-redundant-controls
Change Redundant Layout Controls

GitOrigin-RevId: b50d71b1f75d202334442b3f6cb5037ed0d8a411
2022-07-21 08:04:25 +00:00
Jakob Ackermann
f11e1a83cd Merge pull request #8776 from overleaf/jpa-drop-service-worker
[web] goodbye service worker

GitOrigin-RevId: ce85d4850faba15c5877ce1f3e78026de30c6eae
2022-07-11 08:03:57 +00:00
Alf Eaton
0b942bd8a8 Merge pull request #8708 from overleaf/ae-loading-threads-fix
Only dispatch the loaded_threads event once

GitOrigin-RevId: d9b8bf4a84d115fcc00edbf1901565ddb407c8be
2022-07-05 08:04:02 +00:00
Alf Eaton
4657465c0d Merge pull request #8703 from overleaf/ae-threads-loaded
Ensure that the loaded_threads event isn't dispatched for read-only link sharing users

GitOrigin-RevId: e03581f29f1a0aff122c3c16f4f6a3b70293c301
2022-07-05 08:03:56 +00:00
Alf Eaton
5c94bd81e7 Merge pull request #8699 from overleaf/ae-comment-threads
Show tracked changes highlights if comment threads are not loaded

GitOrigin-RevId: 1aabe62e1aea0b63336ab33cbf199c3f24471495
2022-07-05 08:03:15 +00:00
Alf Eaton
78df903b69 Merge pull request #8639 from overleaf/ae-loading-threads
[cm6] Improve interaction between review panel and CM6

GitOrigin-RevId: 2f15a4821d4edfb5ee00013c74c7ae35fa59559c
2022-07-04 08:03:30 +00:00
Jakob Ackermann
b04bc4798e Merge pull request #8473 from overleaf/ii-cm6-missing-keyboard-shortcuts-2
[cm6] Add missing keyboard shortcuts 2

GitOrigin-RevId: 29f68cd2eb9d0ad931fff463f76ddb91b5275516
2022-06-22 08:05:20 +00:00
John Lees-Miller
fcf9c92160 Split test for log parser changes
GitOrigin-RevId: efe9fb29c5ae56889b686692f8533ae0ae4a3b1d
2022-06-22 08:04:55 +00:00
Eric Mc Sween
4c546adbb1 Add non-capturing groups
GitOrigin-RevId: 313e62d4add4bd0694efd98927032edf6114f8e5
2022-06-22 08:04:36 +00:00
Copybot
f5da397d5c Merge pull request #1024 from gucci-on-fleek:main
GitOrigin-RevId: 759fff1f03907613b225c82d07f31fa691cfd967
2022-06-22 08:04:31 +00:00