Commit graph

89 commits

Author SHA1 Message Date
Christopher Hoskin
5bbe427ed0 Merge branch 'main' of github.com:overleaf/internal
GitOrigin-RevId: b0a13b4b4f7ede46d5ac5478dd03642d59e11a98
2023-05-22 08:04:01 +00:00
Alf Eaton
b35db4827d Merge pull request #13120 from overleaf/dk-drawselection-cm-patch
[cm6] apply cm patch for drawSelection bug

GitOrigin-RevId: 3adfcdbea4cc18d2cc197c153323fc62bafc364f
2023-05-19 08:04:34 +00:00
Alf Eaton
40eac4bd67 Remove fontWeight: bold from matched completion text (#13078)
GitOrigin-RevId: c375765ce0ca14200ba11c54ae1ac2c99a09961f
2023-05-19 08:04:17 +00:00
Mathias Jakobsen
47b1a731fb Merge pull request #13118 from overleaf/mj-fix-centering-editable-graphics
[web] Always update centering in editablegraphics updateDOM

GitOrigin-RevId: 366a109c2006dea3cd3660f7a380fbbc0e203cca
2023-05-17 09:27:43 +00:00
Mathias Jakobsen
988fc57574 Merge pull request #13077 from overleaf/mj-figure-modal-tests
[web] Add cypress tests for figure modal

GitOrigin-RevId: 4debae1c665a68fd7bfa9f0dcfc150bec38a7c64
2023-05-17 08:06:33 +00:00
Mathias Jakobsen
c754eaf5c5 Merge pull request #13108 from overleaf/mj-figure-modal-translations
[web] Translate figure modal

GitOrigin-RevId: b9f2c2e9ba3141dfee15c0af572a022a2b21fd47
2023-05-17 08:06:16 +00:00
Mathias Jakobsen
f747cb000f Merge pull request #13097 from overleaf/mj-figure-modal-alpha-changes
[cm6+rt] Figure Modal alpha rollout changes

GitOrigin-RevId: f7591893e8f74aa9c9b41f4b98babecaac4b3c8c
2023-05-17 08:06:08 +00:00
Alf Eaton
c7544531c1 Add needsRefresh to lint source config (#13050)
GitOrigin-RevId: bc6880f87bc81c7f0f022268a4d070c267421c46
2023-05-17 08:05:36 +00:00
Alf Eaton
c8a72e96d4 [cm6] Improve keyboard shortcuts for toggling line comments (#13067)
GitOrigin-RevId: dd08778ea3621eefa75f306b2dada3f2c484f76c
2023-05-17 08:05:28 +00:00
Alf Eaton
60370d5227 [cm6] Consolidate loose extensions (#13086)
GitOrigin-RevId: ff937418be5092b2b5197435e9cd60bc61f41b2c
2023-05-17 08:04:40 +00:00
Mathias Jakobsen
e306369b9a Merge pull request #13085 from overleaf/mj-figure-rt-flicker
[cm6+rt] Reduce flickering of rendered figure

GitOrigin-RevId: a88845621228fa3a78ced023d5b5480ed600256a
2023-05-16 08:04:28 +00:00
Mathias Jakobsen
5fd4504f51 Merge pull request #13061 from overleaf/mj-cm6-translations
[web] Make translations accessible to CM6

GitOrigin-RevId: ef617638419597548e6e0545bac3ac94216177de
2023-05-16 08:04:11 +00:00
Mathias Jakobsen
31190b967b [cm6] Add figure modal (#12751)
GitOrigin-RevId: 3043d1369ed85b38b1fec7479385b123a304c05b
2023-05-16 08:04:02 +00:00
Domagoj Kriskovic
47f541690f [cm6] fix spell check issue, use new document range (#13035)
GitOrigin-RevId: 01b642dc867705c5de828fce439f424d7816d175
2023-05-15 08:02:57 +00:00
Domagoj Kriskovic
8c12bce5b6 fix outline issue: allow Ref in Math in latex.grammar (#13054)
* added failing test

* latex.grammar update: allow Ref in Math

GitOrigin-RevId: 340bf40cf4804e7693965a29b16b869a54a467d7
2023-05-15 08:02:53 +00:00
Alf Eaton
cc47299f62 Merge pull request #13033 from overleaf/ae-autocomplete-description
[cm6] Style the completion info to match the autocomplete tooltip

GitOrigin-RevId: d1a4db49fb0fff93e2004521ba8837131d321550
2023-05-11 08:05:46 +00:00
Alf Eaton
ea996582bf [cm6] Improve begin environment autocompletion (#12982)
GitOrigin-RevId: 42731e6f2261f7ed9b85523a550c636968698fc3
2023-05-11 08:05:37 +00:00
Alf Eaton
d445ddd410 Unset closeOnBlur
GitOrigin-RevId: 481c530c112f02562b7c01fad22cfe42ddfa62eb
2023-05-11 08:05:20 +00:00
Dom Kriskovic
eafa8589c5 Revert "[cm6] close autocomplete menu on blur"
This reverts commit d47648044ca15cf29cc0c87479ba2a204f232a86.

GitOrigin-RevId: dc6bbcc30126d46a3b602896bfc18477fd07ab34
2023-05-11 08:05:04 +00:00
Dom Kriskovic
4c2537a753 [cm6] close autocomplete menu on blur
GitOrigin-RevId: e1475e1a1b4a0f05ab2926cfc5612abb3b9f39e8
2023-05-11 08:04:56 +00:00
Alf Eaton
466011df86 [cm6] Account for line shifts when updating the spelling line tracker (#13015)
* Use lineShift

* Use fromA instead of fromB

* Only check the update doc

* Always use oldDoc

* Copy tests

GitOrigin-RevId: 05e5516b09ee4a25d8ac2b5f2994a034f35c9e82
2023-05-11 08:04:48 +00:00
Alf Eaton
f2f7f6b7d6 [cm6] Add beginEnvironmentCompletionSource (#12913)
GitOrigin-RevId: eb4582606103268f1f2c90da7d372a0a33926e36
2023-05-08 08:04:26 +00:00
Domagoj Kriskovic
27ffe1c814 [cm6] Display non-standard spaces as special chars (#12927)
* [cm6] Display non-standard spaces as special chars

* specialChar background color

* removed Ideographic Space

* fix: lint error

* added Ideographic Space

* display only for source editor

GitOrigin-RevId: d94942cdc6a0aa17045b1783ac95de601f6ae15a
2023-05-08 08:04:18 +00:00
Alf Eaton
b1929cf16d [cm6] Improve symbol completion ranking (#12902)
GitOrigin-RevId: 8ccc87c2b86636bd37a3472d36873ade9a190209
2023-05-08 08:04:09 +00:00
Alf Eaton
009a108c71 Wrap setCursorHighlights in setTimeout (#12951)
GitOrigin-RevId: 204bf073bc2f4a014d9498c6a802fe38e52b22c5
2023-05-08 08:04:00 +00:00
Alf Eaton
0fba9dc374 Add a $CtrlSym group to the latex language (#12919)
GitOrigin-RevId: 4ee8ba7fe85f37dbe4cab04dae699b2a66007a2d
2023-05-08 08:03:51 +00:00
Rebeka
0c54e6605b Remove deprecated uses of badge style
GitOrigin-RevId: 47234e95acd42d7e5d23de8e3b67edca2bdd98d1
2023-05-04 08:05:40 +00:00
Alf Eaton
680a02892c Duplicate the cloneSelectionVertically key mapping to re-allow Ctrl on macOS (#12918)
GitOrigin-RevId: 747e8889b5e3b34dd9ffef888f4a1d42fea1af74
2023-05-04 08:05:31 +00:00
Alf Eaton
2093d85a5f Exclude CtrlSym commands from completion (#12905)
GitOrigin-RevId: f6d1813eba6c17444d2371b024f538137c244963
2023-05-04 08:05:23 +00:00
Alf Eaton
b010d6a5d3 Handle unset editor theme (#12892)
GitOrigin-RevId: 0e3413c08c6fd0752cd90ee868fec9b0f9f77437
2023-05-04 08:05:14 +00:00
Alf Eaton
09c5bf72d2 [cm6] Use Cmd on macOS for cloneSelectionVertically (#12855)
GitOrigin-RevId: ea72da47f2ebb377cf22af061ab616a021950502
2023-05-04 08:04:57 +00:00
Alf Eaton
8a12c34fce [cm6] Emacs: close search form when Enter is pressed in "Find" input (#12841)
GitOrigin-RevId: a4c974f45e0dbb13d96b9b424f056768449791fb
2023-05-04 08:04:49 +00:00
Alf Eaton
6c21f0821c [cm6] Handle multiple selection ranges when applying snippets (#12830)
* Use fork of @codemirror/autocomplete
* Handle multiple selection ranges when applying snippets

GitOrigin-RevId: 04afc087ac127206463ea3d4950284a50308364a
2023-05-04 08:04:39 +00:00
Alf Eaton
05582567b4 Improve performance of search match counting (#12808)
GitOrigin-RevId: 70cd1aaf5b079cbd540c4a9f92a04fcb2786b308
2023-05-04 08:04:30 +00:00
Alf Eaton
e0d9069131 [cm6] Add "within selection" option to the search form (#12798)
* Use forked @codemirror/search
* Use getPanel to get the search panel
* Remove layer-based highlightSelectionMatches
* Add "within selection" option to the search form
* Add test for "replace all within selection"
* Fix tests

GitOrigin-RevId: 95ce76fd017f96278b04c16a1fd34f785f7504a3
2023-05-01 08:05:02 +00:00
Alf Eaton
2606c76aec Merge pull request #12805 from overleaf/ae-markdown-types
[cm6] Fix type for Markdown language loader

GitOrigin-RevId: 725e1b28dd73e9090638f5d682e48e658c957a04
2023-05-01 08:04:45 +00:00
Alf Eaton
1da94f029c [cm6] Avoid selecting a search match when re-opening the search panel (#12797)
GitOrigin-RevId: 32bb03b71ce56cc0dbe6f7c92cc6d85151ef1971
2023-05-01 08:04:36 +00:00
Alf Eaton
40cbfc451a [cm6] Improve search match scrolling into view (#12787)
GitOrigin-RevId: 6ce9b86253a9c3a2c6ff44c10f78204ff16bd6e2
2023-05-01 08:04:27 +00:00
Alf Eaton
c53411ff1d Merge pull request #12776 from overleaf/ae-search-close-tooltip
[cm6] Add tooltip to search panel close button

GitOrigin-RevId: ba7f4ca5d672580054cb6214be94497fd5141730
2023-05-01 08:04:17 +00:00
Domagoj Kriskovic
3d5e8c9877 add 'Ace removal' notification (#12800)
* add 'Ace removal' notification

* prettier

* add memo, window.clearTimeout

* remove warning for server pro

* added tracking events

* useCallback for onClick

* fix: event rename

GitOrigin-RevId: 70bce8b93bae233e7183a941abaf2ec7a70ddfb6
2023-04-28 08:04:19 +00:00
Domagoj Kriskovic
cd689e4e1f [cm6] Show Regex errors in find & replace (#12720)
* [cm6] Show Regex errors in find & replace

* cleanup, isInvalidRegExp function

* no state variable, less color var

* use @brand-dager

* using var(--ol-cm-search-form-focus-shadow)

* using state-danger-border

GitOrigin-RevId: 844c9dfee5a56d2a7494cd86c266acbe9eacd033
2023-04-27 08:05:14 +00:00
Brian Gough
70072481f4 Merge pull request #12783 from overleaf/ae-dev-tools-localstorage
[cm6] Use customLocalStorage in CM6 dev tools

GitOrigin-RevId: df4c40868b5a7b24b30483d55d1fbe75b5703776
2023-04-26 08:04:12 +00:00
Mathias Jakobsen
17ca11fae0 [cm6] Add save command to emacs (recompiles doc) (#12742)
GitOrigin-RevId: 10cda3f14411147d0d900f688d9b5017f49d2db2
2023-04-25 08:05:35 +00:00
Alf Eaton
f409b96f00 Fix padding in emptyLineFiller and lineWrappingIndentation extensions (#12736)
GitOrigin-RevId: 8b6a2ad0beb802d917f3e998c378792c6156836a
2023-04-25 08:05:27 +00:00
Alf Eaton
8537a7a5d0 Handle mode: 'none' in keybindings (#12717)
GitOrigin-RevId: 77d040352b1de2311f663a8b33bd0d20d79a30ae
2023-04-25 08:05:18 +00:00
Alf Eaton
4bb582bdd8 [cm6] Improve Tab behaviour in read-only mode (#12715)
* Improve Tab behaviour in read-only mode
* Remove Tab shortcuts from Markdown configuration

GitOrigin-RevId: 9eb804fcf820b37b371b1c351cfbdf7bff1ced89
2023-04-25 08:05:10 +00:00
Alf Eaton
08ccdb79d3 [cm6] Improve alignment of review panel elements (#12710)
* Use a block widget for top padding
* Update review panel positions when the editor geometry changes
* Remove editorPaddingTop from position calculations
* Recalculate review panel on start adding comment
* Assert on line content rather than index
* Use broadcastChange
* Keep focus in the editor when opening the review panel
* debounce broadcastChange
* Set CULL_AFTER to Infinity

GitOrigin-RevId: a8d7b8967736a9164b5264eeaadf334c15ec95ce
2023-04-25 08:05:02 +00:00
Alf Eaton
acf6abb0fb [cm6] Use a block widget for padding at the top of the editor (#12705)
GitOrigin-RevId: 000ce9c90ea6b2ca72ab969704354a19fcea7a87
2023-04-25 08:04:53 +00:00
Mathias Jakobsen
81a8fa2ce3 Merge pull request #12672 from overleaf/ae-emacs-compile-keydown
[cm6] Stop propagation of Ctrl-s when Emacs keybindings are enabled

GitOrigin-RevId: 32bebefb583ad813931af221cce7498d40fdbaf1
2023-04-21 08:03:11 +00:00
Mathias Jakobsen
462837b44d Merge pull request #12701 from overleaf/dk-cm6-autocomplete-item-space
[cm6] Add space after item autocomplete

GitOrigin-RevId: 6fff77c0c0563530af981bbac73b1d88e02bb759
2023-04-21 08:03:08 +00:00