Alf Eaton
dfaed70297
Replace symbol palette tabs with a custom tablist ( #19034 )
...
GitOrigin-RevId: 69d8a8dd8980e287b484b915b1f92e57af5324cb
2024-06-26 11:11:35 +00:00
Antoine Clausse
de959fb7b9
Fix institution metrics sendAll
cron ( #19127 )
...
* Don't send status 200 in the beginning: we may throw later
This was causing `Error [ERR_HTTP_HEADERS_SENT]: Cannot set headers after they are sent to the client`
https://cloudlogging.app.goo.gl/Bchegw2iCYLxhPNk8
* Continue when failing to send one email, but log the error
* Revert "Don't send status 200...", log error instead
This reverts commit 3e13559704f822e330a18a68567f46491649f222.
* Fix `logger.error` params
* Fixup: good syntax for `logger.error`
* Remove useless `OError` import
* Update services/web/modules/metrics/app/src/MetricsEmailController.js
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
* Update services/web/modules/metrics/app/src/MetricsEmailController.js
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
* Update services/web/modules/metrics/app/src/MetricsEmailController.js
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
* Update services/web/scripts/recurly/collect_paypal_past_due_invoice.js
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
---------
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: c68bc677326729fc6c39b7c2f027e35ebb776bd2
2024-06-26 08:05:11 +00:00
Antoine Clausse
fc34b41b5b
[web] Promisify two-factor-authentication ( #19004 )
...
* Fixup typos
* Promisify `getPendingUser`
* Promisify `getPendingUserWithExpectations`
* Add promises to `AccessTokenEncryptor`
* Promisify `TwoFactorAuthenticationHandler`
* Promisify/Expressify `TwoFactorAuthenticationController`
* Centralise `unprocessableEntity` error handling into a function
* Fixup: entralise `unprocessableEntity` error handling into a function
Avoid "responding to the query twice"
* Remove unnecessary try/catch
* Fixup: Add `async` to AccessTokenEncryptor promises
* Add tests on `AccessTokenEncryptor.promises`
* Revert "Fixup: entralise `unprocessableEntity` error handling into a function"
This reverts commit 23bd9d73260733062908b98961846733c61171e9.
* Revert "Centralise `unprocessableEntity` error handling into a function"
This reverts commit 197ca3da02412d5224d411b29df1d7b9e5327d01.
GitOrigin-RevId: 1a2864d28e87fd5e48cd3723a3da8047b79a1596
2024-06-26 08:05:06 +00:00
CloudBuild
375ff968c5
auto update translation
...
GitOrigin-RevId: c597b7ebda7a250220e7227211d7f3cd64816b90
2024-06-26 08:05:02 +00:00
Jimmy Domagala-Tang
50b19c7793
Merge pull request #18850 from overleaf/ac-promisify-resync-subscriptions
...
Promisify resync_subscriptions
GitOrigin-RevId: c23a99683a22104815525b179d4e46d3ad568f94
2024-06-26 08:04:57 +00:00
Jimmy Domagala-Tang
86e2abc90b
Merge pull request #19106 from overleaf/jdt-center-labels
...
vertically align text within spans
GitOrigin-RevId: 820313b179751a1a7c538712cf9dfd6b9ce0ff3d
2024-06-26 08:04:52 +00:00
Jimmy Domagala-Tang
b0344ec550
Merge pull request #19132 from overleaf/jdt-ai-policy-migration
...
feat: add migration for adding new policy to all existing groupPolicies
GitOrigin-RevId: ea3188b6059c2e96afd0058a191d18b26d68adbd
2024-06-26 08:04:48 +00:00
roo hutton
e0c879bd9a
Merge pull request #19120 from overleaf/rh-link-share-styles
...
[web] Fix share modal styling regressions
GitOrigin-RevId: efeffa3d6451ed47137106e0ad296c518a5c0608
2024-06-26 08:04:43 +00:00
roo hutton
bf90932f40
Merge pull request #18936 from overleaf/rh-viewer-no-comment
...
[web] Remove access to commenting/chat for collaborators with Viewer permission
GitOrigin-RevId: 03957cb8c04866318a4b94bdb72843e7d7a5a003
2024-06-26 08:04:38 +00:00
Jakob Ackermann
ce9b531892
Merge pull request #19098 from overleaf/jpa-graceful-shutdown-tests
...
[server-ce] add test for graceful shutdown
GitOrigin-RevId: 5e72e0073169009d2e3ece5a79cbd62051f6ad5b
2024-06-25 11:12:43 +00:00
Tim Down
956aad7e43
Merge pull request #18764 from overleaf/td-bs5-dashboard-feature-flag
...
Create new feature flag for BS5 project dashboard page
GitOrigin-RevId: a523bd7df94c411805ac2f5234135bc7a56d25bb
2024-06-25 11:12:35 +00:00
Tim Down
8897e439ae
Merge pull request #18928 from overleaf/td-bs5-nav-admin-missing-href
...
Bootstrap 5: add missing href to nav admin link
GitOrigin-RevId: 5339fa2ef465a6319d87cba6201e682dea1a98a6
2024-06-25 11:12:31 +00:00
David
62c432b997
Merge pull request #19101 from overleaf/dp-presentation-additional-keys
...
Add PageUp/PageDown/Backspace options for presentation page navigation
GitOrigin-RevId: 59b8c3b22ff205c8fe1009c120358c913db3cbe5
2024-06-25 11:12:27 +00:00
David
b2e3002992
Merge pull request #19103 from overleaf/dp-presentation-events
...
Add event for entering presentation mode
GitOrigin-RevId: 6d9006005264f69d1a37baa363b338caf0d29c6c
2024-06-25 11:12:23 +00:00
Mathias Jakobsen
ddfdafd54c
Merge pull request #19050 from overleaf/mj-lezer-parse-comments-in-unknown-commands
...
[lezer] Introduce hasMoreArguments token for argument parsing
GitOrigin-RevId: a5898a2be01c19a39de15c784f184fe61140799a
2024-06-25 11:12:18 +00:00
Mathias Jakobsen
46a160f127
Merge pull request #19072 from overleaf/mj-known-commands-reuse
...
[web] Parse known commands in math mode
GitOrigin-RevId: e7937fc46320f13c716d1612eca36aa67c8fb967
2024-06-25 11:12:14 +00:00
Mathias Jakobsen
283c972842
Merge pull request #19032 from overleaf/mj-lezer-mathdelim
...
[lezer] Remove custom tokeniser for MathDelimiter
GitOrigin-RevId: acbbbe439d51a8a9d5b30b91c55c8f8ef8c3b9fb
2024-06-25 11:12:10 +00:00
Mathias Jakobsen
884eebd82d
Merge pull request #19102 from overleaf/mj-more-cite-ref
...
[lezer] Add more cite and ref command variants
GitOrigin-RevId: e402f92d9948eba857dbe0851f039f4d7313df81
2024-06-25 11:12:06 +00:00
Mathias Jakobsen
e48e4293a6
Merge pull request #19090 from overleaf/mj-web-metadata
...
[web] Ignore commented content when parsing metadata
GitOrigin-RevId: 78f9b0d6549e60fca4ba8929beb677341d885655
2024-06-25 11:12:02 +00:00
roo hutton
64d9792fe3
Merge pull request #18861 from overleaf/rh-editor-limit-exceeded
...
[web]: Handle exceeded editor limit in share modal
GitOrigin-RevId: 23a15805ca98327ae4a7fc731bbca3982c90bad5
2024-06-25 08:04:46 +00:00
Jimmy Domagala-Tang
04432478e1
Merge pull request #19053 from overleaf/ab-split-tests-first-time-assignments
...
[web] Return isFirstTimeAssignment flag with split test assignments
GitOrigin-RevId: 70954470fbd9430749d83d8d1e08a3969d4a09e6
2024-06-25 08:04:37 +00:00
Alf Eaton
6db455d63e
Show modal for error renaming project ( #19040 )
...
GitOrigin-RevId: 229e64775897d646ed8c13f12d3bcc9400f2a3b9
2024-06-24 12:05:59 +00:00
Alf Eaton
bee698c01d
Updates to the AI error assistant ( #19065 )
...
* Only show the AI error assistant to users with write permission on the project
* Fix line number in searchDocLines
* Abort the request after 60 seconds
* Move comment
* Jump to file + line when suggestion line number is clicked
* Set tool_choice: 'required'
* Fix handling of suggestLineChange
* Tidy up getDocLines
* Avoid showing Suggest Fix button in gutter marker for typesetting warnings
* Log request errors
* Fix prefixed function name
* Update tool description
* Tweak the prompt in an attempt to improve the line number
* Reject if the total message content is too large
* Change the structure of the suggested change
* Reduce line highlight
* Fix change highlighting on deletion
GitOrigin-RevId: afde096e547050b8518195ef51b68983bc3b0be3
2024-06-24 12:05:51 +00:00
Miguel Serrano
1697087425
Merge pull request #18970 from overleaf/msm-clean-features-templates
...
[web] Cleanup `features.templates`
GitOrigin-RevId: 7c9f7bc827700e4255a5ba8a46de70318afdaae4
2024-06-24 12:05:43 +00:00
David
8d2b006d60
Merge pull request #19070 from overleaf/dp-remove-useWaitForGrammarlyCheck
...
Remove grammarly check in writefull promo
GitOrigin-RevId: 30994c1960232afe3bede1fd6649606e191dd3d4
2024-06-24 12:05:35 +00:00
Davinder Singh
c70e676cbc
Merge pull request #19035 from overleaf/plans-list-mobile
...
[web] Begin configured features list for new plans page mobile view
GitOrigin-RevId: ba09f1a2e24f3a2eec4b20e55a0afada9e359264
2024-06-24 12:05:30 +00:00
Mathias Jakobsen
23a7e19e8e
Merge pull request #18991 from overleaf/mj-table-generator-promotion-teardown
...
[web] Tear down table generator promotion
GitOrigin-RevId: 361215bdd792042ae68762fa20ae60286db5bab3
2024-06-24 12:05:18 +00:00
Mathias Jakobsen
bc9bb05c8f
Merge pull request #19033 from overleaf/mj-lezer-unused-rule
...
[lezer] Remove unused rule
GitOrigin-RevId: 53402a3004d0ca781b29f16eaf4e7eae086450d3
2024-06-24 12:05:14 +00:00
Mathias Jakobsen
40bddf72dc
Merge pull request #18937 from overleaf/mj-lezer-upgrade
...
[web] Update lezer packages
GitOrigin-RevId: 349b18e7f03c12aae736c6a8c4d3234c828b14ca
2024-06-24 12:05:09 +00:00
CloudBuild
a0d2d30b48
auto update translation
...
GitOrigin-RevId: 3c003f3e221c7186d5a944791caae8027d65cd05
2024-06-24 12:05:00 +00:00
Jakob Ackermann
c851be7809
Merge pull request #19061 from overleaf/jpa-fix-e2e-test
...
[server-ce] update tests for new notifications style on project-dash
GitOrigin-RevId: 7fe6aadfee348ad0513e49d601812b90ceb6aaa8
2024-06-24 12:04:56 +00:00
Jimmy Domagala-Tang
790f90e97d
Merge pull request #19036 from overleaf/jdt-labs-alpha-only
...
feat: only allow alpha users on labs page currently
GitOrigin-RevId: 5136d77789fa27a0bd9fe6f17c8937998bc74259
2024-06-24 12:04:51 +00:00
Mathias Jakobsen
94694a6385
Merge pull request #19057 from overleaf/mj-benchmark-seed-random
...
[web] Add quick and dirty PRNG for seeding benchmark runs
GitOrigin-RevId: 079f9b565f17b44d7062f6b93c26f694e486c6b9
2024-06-24 12:04:46 +00:00
David
a8cb423078
Merge pull request #19030 from overleaf/dp-presentation-mode-flag
...
Add separate feature flag for presentation mode
GitOrigin-RevId: a996fa313c101dd822ad83109ba77fa95f99f644
2024-06-24 12:04:34 +00:00
Antoine Clausse
3d5418611b
Add an ESLint rule enforcing kebab-case in URL paths ( #18913 )
...
* Add a tsconfig.json to the eslint-plugin folder so it can be linted too
* Create eslint rule `prefer-kebab-url`
* Add prefer-kebab-url to service/web
* Ignore lowercased strings
Prevents from trying to change `v0` to `v-0`
* Ignore parts between brackets or parenthesis
* Record in URL paths by case
lower: 241
kebab: 60
snake: 43
camel: 22
other: 5
* Revert "Record in URL paths by case"
This reverts commit 262f483aafb0daa1a01e9025488cdc33f31ef67c.
* Showcase how the autofix would change the code
* Revert "Showcase how the autofix would change the code"
This reverts commit f045292bf01623de2df5b89fc0d68737a39913dc.
* Add ignored words so we don't have to update old code
* Change the rule so it suggests instead of fixing
This prevents eslint autofix from creating bugs
* Move list of ignored words to its own file
Per https://github.com/overleaf/internal/pull/18913#discussion_r1644204034
* Add comment explaining the ignore list
GitOrigin-RevId: d13918b0bcba9d77120f1b61b354a79dc8fb4b4e
2024-06-24 12:04:26 +00:00
Antoine Clausse
2c7df10b9a
[web] Refactor ProjectController.loadEditor
p-props promises ( #18823 )
...
* Move unawaited promises out of `p-props`: `User.updateOne`
* Move unawaited promises out of `p-props`: `sessionMaintenance`
* Move unawaited promises out of `p-props`: `reactivateProjectIfRequired`
* Move unawaited promises out of `p-props`: `markAsOpened`
* Move unawaited promises out of `p-props`: `flushProjectToTpdsIfNeeded`
This was actually awaited, but is it necessary?
* Use `getUserValues`: `user`
* Use `getUserValues`: `learnedWords`
* Use `getUserValues`: `projectTags`
* Use `getUserValues`: `userHasInstitutionLicence`
* Use `getUserValues`: `subscription`
* Use `getUserValues`: `isTokenMember`
* Use `getUserValues`: `isInvitedMember`
* Update `splitTestAssignments` syntax
* Remove `mapValues` in `pProps`
* Await unused promises again: `flushProjectToTpdsIfNeeded` and `reactivateProjectIfRequired`
* Remove error page file committed by mistake 🤦
GitOrigin-RevId: 6529445c364a6af660bc8ab6dfc836a4ddf7a040
2024-06-24 12:04:18 +00:00
Jimmy Domagala-Tang
271700893a
Merge pull request #18784 from overleaf/bg-allow-combined-group-policies
...
allow combined group policies
GitOrigin-RevId: b23fb0454f794e9094e8e15e732b4322a48ac1ee
2024-06-24 12:04:13 +00:00
Jimmy Domagala-Tang
e5aa917f54
Merge pull request #18682 from overleaf/jdt-ai-labs
...
Re-Release Labs Page for AI Error-Correction
GitOrigin-RevId: 2eef85dd3b5f86bedcf3339559a5fbbae2d4da87
2024-06-24 12:04:08 +00:00
Jakob Ackermann
ac7916fb29
Merge pull request #19023 from overleaf/jpa-issue-19016
...
[web] lock down legacy endpoint for creating projects from zip
GitOrigin-RevId: 0c6b29d34c601d316b184d50d93e8e17f59bfcfb
2024-06-24 12:04:00 +00:00
Mathias Jakobsen
922822d487
Merge pull request #18997 from overleaf/mj-fix-uncategorized-title
...
[web] Correct title when viewing uncategorized projects
GitOrigin-RevId: 6f284c437563f10125974eac7f6da6c92526e436
2024-06-24 12:03:51 +00:00
Mathias Jakobsen
69205629bf
Merge pull request #19024 from overleaf/mj-mobile-rename-modal
...
[web] Update project name in rename modal when project name changes
GitOrigin-RevId: 080d97b4d279fe54cc9530cea3efb1212da3041c
2024-06-24 12:03:47 +00:00
M Fahru
381795c5a2
Create an organizations icon section on the new plans page
...
GitOrigin-RevId: 9c58fa1dadb66a8ab91102484bc6b937e568c40b
2024-06-24 12:03:42 +00:00
M Fahru
b197aee92e
Merge pull request #18879 from overleaf/ds-plans-page-new-design-mobile-plans-2
...
Website redesign - Plans page new-design mobile screen plans card (2)
GitOrigin-RevId: d74f4d0769ae7a248226d2369a5419e26946e26d
2024-06-24 12:03:37 +00:00
Jessica Lawshe
900f11dae2
Merge pull request #18949 from overleaf/jel-faq-spacing
...
[web] Add spacing to left of FAQ accordion icon
GitOrigin-RevId: 71004270bbc9725b63c92dfb685b759057049265
2024-06-24 12:03:33 +00:00
Jessica Lawshe
2547294353
Merge pull request #18909 from overleaf/mf-new-plans-page-table-highlighted-column
...
[web] Implement highlighted column based on hardcoded column id on new plans page table
GitOrigin-RevId: 241913c81670ea158f436c29060bd9e1836ed4fc
2024-06-24 12:03:24 +00:00
Mathias Jakobsen
46d687855e
Merge pull request #18981 from overleaf/mj-mobile-dropdown
...
[web] Add rename button to project list mobile view
GitOrigin-RevId: 4ca3c68dcaf4e0d5e97f501084b9f850f9a4e867
2024-06-24 12:03:20 +00:00
ilkin-overleaf
7b47acc486
Merge pull request #18763 from overleaf/ii-bs5-projects-notifications
...
[web] BS5 notifications in projects and welcome pages
GitOrigin-RevId: 25780bb64660ef41c41c007f94f70df273cac716
2024-06-24 12:03:15 +00:00
ilkin-overleaf
34311ce0dc
Merge pull request #18789 from overleaf/ii-invite-token-lookup-by-hmac-token
...
[web] Lookup project invitations by HMAC token
GitOrigin-RevId: b631445e18f83ddb5e7708388a57a0fac0f73bd2
2024-06-24 12:03:10 +00:00
David
2a6b84596e
Merge pull request #19006 from overleaf/dp-pdf-click
...
Add click listener to pdf presentation mode to go to next page
GitOrigin-RevId: add7ddb18ef63774bbb78f6337088bd59b087db1
2024-06-24 12:03:06 +00:00
Jakob Ackermann
bd9f3cb07a
Merge pull request #19017 from overleaf/jpa-server-pro-footer
...
[web] fix spacing for thin-footer as used in Server Pro/CE
GitOrigin-RevId: 8a20d93f10c5bce156647f67de991ff41a8a2017
2024-06-24 12:03:01 +00:00