Commit graph

424 commits

Author SHA1 Message Date
Alf Eaton
78df903b69 Merge pull request #8639 from overleaf/ae-loading-threads
[cm6] Improve interaction between review panel and CM6

GitOrigin-RevId: 2f15a4821d4edfb5ee00013c74c7ae35fa59559c
2022-07-04 08:03:30 +00:00
Jakob Ackermann
b04bc4798e Merge pull request #8473 from overleaf/ii-cm6-missing-keyboard-shortcuts-2
[cm6] Add missing keyboard shortcuts 2

GitOrigin-RevId: 29f68cd2eb9d0ad931fff463f76ddb91b5275516
2022-06-22 08:05:20 +00:00
John Lees-Miller
fcf9c92160 Split test for log parser changes
GitOrigin-RevId: efe9fb29c5ae56889b686692f8533ae0ae4a3b1d
2022-06-22 08:04:55 +00:00
Eric Mc Sween
4c546adbb1 Add non-capturing groups
GitOrigin-RevId: 313e62d4add4bd0694efd98927032edf6114f8e5
2022-06-22 08:04:36 +00:00
Copybot
f5da397d5c Merge pull request #1024 from gucci-on-fleek:main
GitOrigin-RevId: 759fff1f03907613b225c82d07f31fa691cfd967
2022-06-22 08:04:31 +00:00
ilkin-overleaf
41c715c40d Merge pull request #8378 from overleaf/ii-cm6-three-way-toggle
[cm6] Make cm6 as the default source editor

GitOrigin-RevId: b56724d2c147792c55ce01cf272fbcce16f87916
2022-06-15 08:05:18 +00:00
Tim Down
ca5f438290 Merge pull request #8373 from overleaf/td-review-panel-scroll
Scroll incrementally in response to mouse wheel in review panel

GitOrigin-RevId: 2c1f119ae8dfd09b378a3b265c3543f88e2d1f65
2022-06-13 08:03:55 +00:00
Tim Down
fef395f431 Fix layout shift by nearly always applying overflow-y hidden on review panel (#8174)
* Always hide vertical overflow on the review panel, not just when it's expanded, which prevents it scrolling slightly when scrolling the PDF in some circumstances
* Fix layout shift by always applying overflow-y hidden on review panel and make entry visible in minimized review panel by making the overflow visible while hovering over the entry

GitOrigin-RevId: 854ee47a762ee2cf78fbbb5856afddb3b723d679
2022-06-13 08:03:37 +00:00
Tim Down
c0292d96a1 Add vertical padding to CM6 editor content to deal with overflowing entries in the review panel (#8321)
GitOrigin-RevId: 9f8265dba773008ba8f97053ce66f23dc4b7121f
2022-06-13 08:03:32 +00:00
Timothée Alby
ae207f7559 Merge pull request #8326 from overleaf/ta-pdf-detach-redundant-controls
Bring Back Redundant Layout Controls

GitOrigin-RevId: a725e8742ab41612b285bcab23054ba9da15b60f
2022-06-09 08:02:34 +00:00
Alf Eaton
917d87257d [cm6] Improve LaTeX autocomplete extension (#8317)
* Upgrade CodeMirror packages

* Merge Metadata types

* Move symbol completions to the symbol-palette module

* Update categories.js

* squash metadata type

* Add open-autocomplete extension

* Increase delay for doc metadata request

* Add metadata state field

* Add bibliographyStyle completions

* Add class names

* Decrease score of usePackage completion

* Improve autocomplete

* Tidy comments

* Use CompletionSource type

* Use sourceEditorCompletionSources

* Update package-lock.json

* Update package.json

* Add tests

* Update window.ts

* Update open-autocomplete.ts

* Tidying

* Update complete.ts

* Fix test

* Add test

* Update top-hundred-snippets.ts

GitOrigin-RevId: 0d8721975893b76d9604b6123576b3a68f178e65
2022-06-09 08:02:32 +00:00
Eric Mc Sween
cb657d1f1c Merge pull request #8297 from overleaf/em-halt-on-error-logs
Stop on first error info box in logs pane

GitOrigin-RevId: cf11f65d582d98bea93c6506393940d9a6144c0d
2022-06-08 08:03:12 +00:00
Miguel Serrano
430b7528b2 Merge pull request #8073 from overleaf/ta-td-dictionary
Add UI to Remove Words from Dictionary

GitOrigin-RevId: a28d865e3c968d6fff113237fcf4143b77af046e
2022-05-25 08:09:45 +00:00
Timothée Alby
5a1ff8149d Merge pull request #8001 from overleaf/ta-td-refactor-learned-words
Refactor Learned Words Class

GitOrigin-RevId: eae6558b5d4eb03b95df511d1cd9ba35b22bb344
2022-05-24 08:04:54 +00:00
Alf Eaton
44d4d8b15d Ensure that file tree re-opens on page load (#8061)
GitOrigin-RevId: ec3d6a43a34aefa2e9574ef7b1b61f8a53b74263
2022-05-24 08:03:58 +00:00
Alf Eaton
1f24160005 Switch layouts using custom divider toggle (#7995)
GitOrigin-RevId: 15e517f448165a25df616fd956967202491b15cc
2022-05-23 08:03:30 +00:00
Alf Eaton
77ac1514fd Reduce calls to jQuery layout() (#7994)
GitOrigin-RevId: 2cfac1e22187bc9f5185724f05f6f92f18c16baa
2022-05-23 08:03:27 +00:00
Max Chernoff
92c18d0ff4
Parse class/expl3/luatexbase warnings
See overleaf/overleaf#1023.

Signed-off-by: Max Chernoff <49086429+gucci-on-fleek@users.noreply.github.com>
2022-05-22 22:36:06 -06:00
Alf Eaton
9062d4ce5d Merge pull request #7983 from overleaf/td-cm6-smooth-scroll-between-comments
Enable animation when positioning comments in CM6

GitOrigin-RevId: 9a5355c3c2105a3dfa26590c2b007571b55c9dcc
2022-05-19 08:03:42 +00:00
Alf Eaton
5a5436d38f Run $digest in a timeout (#7996)
GitOrigin-RevId: e3c0e9f3cdf917f6a112064086454d64fea489cf
2022-05-19 08:03:25 +00:00
Alf Eaton
5d05b2b21d Restore "layout-left" styles for collapsed review panel comment popover (#7999)
GitOrigin-RevId: 230e202496c8bc7e4929fca9c35b7f8eba25653b
2022-05-19 08:03:08 +00:00
Jakob Ackermann
f0bd6dda23 Merge pull request #7986 from overleaf/jpa-eslint-8
[misc] upgrade eslint packages to the latest version everywhere

GitOrigin-RevId: f1480d4a171acef82fb26c4aa54be3a6088b0ab3
2022-05-17 08:05:59 +00:00
Alf Eaton
3a81428ef3 Merge pull request #7795 from overleaf/ae-history-view
Avoid switching away from v1 history view when a file is selected

GitOrigin-RevId: 7b7d75f5e4c63bf899fc7f1f5c7c17119863177b
2022-05-10 08:03:54 +00:00
Alf Eaton
e096bf051a Open the correct doc on tracked change click in overview (#7622)
GitOrigin-RevId: 7bef9341c315f350c5428f8c94ce84cbc4f850c5
2022-04-25 08:04:12 +00:00
Alf Eaton
b70e63e893 Focus the editor after restoring a stored cursor position (#7628)
GitOrigin-RevId: d4564f14503957a0fc8a02cef21064777e2e961d
2022-04-25 08:03:56 +00:00
Timothée Alby
a110c4d7bd Merge pull request #7323 from overleaf/ta-synctex-disable-multi-one-way
Don't Disable Synctex PDF-to-Code Button

GitOrigin-RevId: 90328e0fea8cb5358217ce866839f5e1a4a73b94
2022-04-13 08:03:36 +00:00
Alf Eaton
69a2283984 Upgrade to webpack v5 (#7249)
GitOrigin-RevId: 69dc5f9aad3e045cc6904e3663e9965094eced76
2022-04-07 08:03:46 +00:00
Jakob Ackermann
862ff734c6 Merge pull request #7278 from overleaf/jpa-block-track-changes-access
[web] block restricted token users from accessing track-changes details

GitOrigin-RevId: f2e734b48aaa1d1cae6d5db0e0312a78d42165de
2022-04-05 12:21:09 +00:00
Timothée Alby
3c01402bbd Merge pull request #7034 from overleaf/ta-pdf-detach-full
PDF Detach v2

GitOrigin-RevId: 3deb76474185f9176cde23ab32ef51b90df6e8e9
2022-04-05 12:19:23 +00:00
ilkin-overleaf
ea729ca2af Merge pull request #7075 from overleaf/ta-mutli-selection-ui-fix
Bring Multi-Selection UI Back

GitOrigin-RevId: a0e086da98bb1de88cb2e96ddc2acfd5240a01a7
2022-03-22 09:03:40 +00:00
ilkin-overleaf
be0774be8f Merge pull request #7060 from overleaf/ii-5273-latex-log-parsers
Clean up log parsers code

GitOrigin-RevId: 7dc4dbbb07bba72dda63d75502602570620fe07d
2022-03-22 09:03:14 +00:00
June Kelly
837ad6002f Merge pull request #6911 from overleaf/ta-layout-dropdown-view-fix
Fix Layout Dropdown in History and File Views

GitOrigin-RevId: 17792e6ec516ac9d72c050d5e2b83066fa34ed6d
2022-03-16 09:03:14 +00:00
Alf Eaton
9f969d07e0 Delete unused PDF-related code (#6334)
* Remove new logs UI code
* Remove unused preview components
* Move metrics file
* Remove Angular PDF controllers
* Move the service worker util functions
* Remove the ide/pdfng folder
* Remove vendored pdf.js
* Remove showNewPdfPreview
* Use mockCompile
* Remove split test code

GitOrigin-RevId: 723b7440c62cda51f6ad8bb9c691900882166d21
2022-03-16 09:03:04 +00:00
Tim Down
64dd07a50f Merge pull request #7052 from overleaf/td-suppress-comment-page-up-down
Suppress Page Up/Down keypresses in comment textarea

GitOrigin-RevId: 244bfdc4f1a1470870180a166ba7d2b2792fe614
2022-03-14 09:04:22 +00:00
June Kelly
9702346edc Merge pull request #6628 from overleaf/jk-heartbeat-editor-type-metadata
Add editor metadata to editing-session pings

GitOrigin-RevId: f42be772c13f71380d59bae7c447645fe0e16a17
2022-03-02 09:02:34 +00:00
Alf Eaton
1e7ab75cbc Remove unused "file upload complete" code (#6874)
GitOrigin-RevId: 64bbca60db983df6dba48c3c8b849cb1ec3e0243
2022-03-01 09:03:49 +00:00
Brian Gough
fde4f72adf Merge pull request #6779 from overleaf/ae-cm-editor-switch
[web] [cm6] Add a three-way switch for editor choice

GitOrigin-RevId: fff788ddad8d10488e8446de7f1503702da0985f
2022-02-22 09:03:05 +00:00
Timothée Alby
4a70dfa921 Merge pull request #6705 from overleaf/ta-ms-doc-too-long-modal
Improve handling of "Document Too Long" Errors

GitOrigin-RevId: 6a5e200014609e2a94f896840757487564d41176
2022-02-16 11:40:16 +00:00
Brian Gough
f23cc433a4 Merge pull request #6742 from overleaf/bg-cm6-chaos-monkey
[web] extend chaosmonkey for cm6

GitOrigin-RevId: d030952c9f0c8d3441321354f1ae61e5a6bc4d53
2022-02-16 11:38:54 +00:00
Eric Mc Sween
8e4b85c6f3 Merge pull request #6731 from overleaf/em-logs-ui-split-test
Move new logs UI to a split test

GitOrigin-RevId: 2ebd5afbbda273e7c3092416c64754a56e628b05
2022-02-16 11:38:42 +00:00
Alf Eaton
753be43c53 [web] [cm6] Add a source editor toggle (#6674)
* Add a source editor toggle
* Only show the toggle if in split test variant (or query param override)
* Change labels
* Add check for this.editor
* Update toolbar.pug

GitOrigin-RevId: ee00e31db334fc562b00d28a8c2de5d03456f749
2022-02-16 11:37:33 +00:00
Eric Mc Sween
46d2b84103 Merge pull request #6727 from overleaf/em-revert-logs-ui-split-test
Revert "Move new logs UI toggle to a split test"

GitOrigin-RevId: 5f2aecb53d2df21c89da594b0a64c8cf8ca04bc6
2022-02-16 11:36:26 +00:00
Eric Mc Sween
4df657db4b Merge pull request #6640 from overleaf/em-alpha-beta-split-tests
Move alpha/beta feature toggles to split tests

GitOrigin-RevId: e64387d9bde2db9c4e96ea7f5992c877ad16b9a9
2022-02-16 11:36:20 +00:00
Alf Eaton
5f9cc7512a [web] [cm6] Fix alignment of tracked changes/comments with review panel (#6557)
GitOrigin-RevId: 65416f32874da1cc866e4949244c4934aeabe804
2022-02-16 11:35:32 +00:00
Alf Eaton
34a296747b Merge pull request #6695 from overleaf/ae-cm6-review-panel-timing
[web] [cm6] Improve track changes extension timings

GitOrigin-RevId: 6e374b785daf14bd4d4576747faa0a9b20c4d346
2022-02-16 11:35:10 +00:00
Timothée Alby
01f63e810a Merge pull request #6679 from overleaf/ta-undefined-references-hint
Update Human Readable Hint Regex for Undefined References

GitOrigin-RevId: 326ed206f3321d43580031ec2b46bc3117c6c4e9
2022-02-16 11:34:51 +00:00
Jakob Ackermann
f5a74a014f Merge pull request #6663 from overleaf/jk-cm6-spelling-ignore-words-dedupe
[web] Spelling: de-duplicate ignored-misspellings list

GitOrigin-RevId: 9888c35dde01fb733247fba38846c07b43a3e924
2022-02-16 11:33:54 +00:00
June Kelly
926f69d331 Merge pull request #6630 from overleaf/bg-spelling-tex-related-words
[web] add TeX-related words to IGNORED_MISSPELLINGS

GitOrigin-RevId: 10471b1e45e9b4f054871eb11b27410ccbacb59d
2022-02-16 11:32:39 +00:00
June Kelly
ab5135957a Merge pull request #6633 from overleaf/jk-cm6-spelling-ignore-commands
[web] Ace/CM6 Spelling: don't send commands to backend

GitOrigin-RevId: 7fbd14240facb71b6d110eb95e271b07fced76b1
2022-02-16 11:32:26 +00:00
June Kelly
ef4e137676 Merge pull request #6610 from overleaf/jk-better-editing-heartbeat
[web] CM6: improvements to editor heartbeat

GitOrigin-RevId: b0e5379d221cba76c91d6d21863ca8355749d18e
2022-02-16 11:32:19 +00:00
Alf Eaton
ae7c7edc69 [web] [cm6] Trigger metadata reload if edited text contains metadata-related command (#6371)
GitOrigin-RevId: 4180ef0b7720b38ca1511c4f96de14e03b0a3ea5
2022-02-07 09:03:32 +00:00
June Kelly
e92cc8a4b1 Merge pull request #6592 from overleaf/jk-cm6-switch-focus
[web] CM6: focus editor when switching back to doc

GitOrigin-RevId: 1ef63dbcbd3befc2a2a7c4b43dc3a357489e5a11
2022-02-04 09:03:30 +00:00
June Kelly
4b14a14819 Merge pull request #6573 from overleaf/jk-cm6-heartbeat
[web] Move on-scroll heartbeat tracking from ace to IDE

GitOrigin-RevId: e39bc9ebffde228c4a2d6045837fae3b64219bed
2022-02-04 09:03:23 +00:00
Timothée Alby
30cd3d2961 Merge pull request #6551 from overleaf/bg-remove-unused-flag
[web] remove unused keepEditorContents flag

GitOrigin-RevId: 9c20469e9200ee9aad19fdd0d1567a6eea704741
2022-02-03 09:04:20 +00:00
Timothée Alby
74d9937816 Merge pull request #6536 from overleaf/bg-cm6-size-check
Add editor max doc length checks to codemirror

GitOrigin-RevId: 0a458fc3aa23f22b078c6607ee4347bc76c371e9
2022-02-03 09:04:12 +00:00
Alf Eaton
4cad876173 [web] CodeMirror 6 track changes extension (#6455)
GitOrigin-RevId: 038f375c40e7bc8009ee423016b711a2252f52fa
2022-01-31 09:03:19 +00:00
Brian Gough
89268bee2c Merge pull request #6485 from overleaf/bg-remove-op-from-timeout-error
[web] remove unnecessary content from timeout errors

GitOrigin-RevId: c4913956e6f990afbd4c8f225c6d7c51e6d77e75
2022-01-27 09:03:30 +00:00
Brian Gough
b43a3a6861 Merge pull request #6486 from overleaf/bg-remove-google-analytics-from-errors
[web] remove google analytics for editor errors

GitOrigin-RevId: cac318316780e84cd8d076624a4e3f39b7cf2725
2022-01-27 09:03:26 +00:00
Jakob Ackermann
5701cc9e4b Merge pull request #6351 from overleaf/jk-cm6-context-menu-revamp
[web] Spelling: use button instead of `a` tag

GitOrigin-RevId: e63a89eb781bbecf33c49cfcd83e8ff7612fa554
2022-01-20 09:03:11 +00:00
Miguel Serrano
35396ab61a Add limit to log parsing for react log viewer (#6213)
* Add limit to log parsing for react log viewer

GitOrigin-RevId: e2e5ffd6eaf1c207cc4f49fb5c637457990c328e
2022-01-12 09:03:59 +00:00
Alf Eaton
6dec7fab63 Scroll editor line into view after inserting a symbol (#6164)
GitOrigin-RevId: 20f80ec93148d36f951c956a942021f01490d120
2022-01-11 09:03:49 +00:00
Alf Eaton
50df230846 [web] Upgrade Prettier to match version in monorepo root (#6231)
GitOrigin-RevId: 02f97af1b9704782eee77a0b7dfc477ada23e34d
2022-01-11 09:03:23 +00:00
Jakob Ackermann
9207a42571 Merge pull request #6235 from overleaf/jpa-spelling-client-side-ignore-list
[web] spelling: bootstrap the ignore-list with more special words

GitOrigin-RevId: a7a4ab7eccbebd89994c7a9c9b169573292b1030
2022-01-07 09:03:07 +00:00
Jakob Ackermann
17eb841b31 Merge pull request #6151 from overleaf/jpa-jel-ta-spelling-client-cache
[misc] filter out saved words from users dict client side

GitOrigin-RevId: 01b496c60d25954c8e65a71c06fd90a6c428a698
2022-01-05 09:02:59 +00:00
Timothée Alby
b11d4b002c Merge pull request #6056 from overleaf/msm-remove-unnecessary-pdf-event-tracking
Cleanup PDF Preview event tracking

GitOrigin-RevId: 8fadaee2759f60e70e27ac417593d35cc73e8b68
2021-12-22 09:03:27 +00:00
Timothée Alby
c96bb1551c Merge pull request #6011 from overleaf/jel-toggle-switch
Move style for selected toggle item

GitOrigin-RevId: 516e77839c708c77510ad0e77137dd45f54ff3ed
2021-12-15 09:05:14 +00:00
Timothée Alby
cf0a488a30 Merge pull request #6035 from overleaf/msm-remove-redundant-bibtex-error
Remove redundant >100 bibtex errors message

GitOrigin-RevId: b2487aaf3b31c469b5780f6d05e4cd124666adf5
2021-12-15 09:04:58 +00:00
June Kelly
1bc376be33 Merge pull request #6048 from overleaf/jk-client-error-report-content
[web] Remove `recent_events` from error report

GitOrigin-RevId: e8cf716da1aee245c9ce52e403fa67d6a706070f
2021-12-10 09:03:15 +00:00
Alf Eaton
1fd0a26d29 Merge pull request #6005 from overleaf/ae-fix-prop-types
[web] Fix some missing/incorrect props and propTypes

GitOrigin-RevId: 27aac8d6675e0070633d0d3d45b27746ebcf62a0
2021-12-08 09:03:20 +00:00
Timothée Alby
f6fc3d468c Merge pull request #5854 from overleaf/ta-pdf-detach-v2
PDF Detach Updates

GitOrigin-RevId: c09c4fe37a922b041cfa1376e110a264a88177c8
2021-12-01 09:03:41 +00:00
Jakob Ackermann
fc086fba29 Merge pull request #5856 from overleaf/revert-5749-ab-ide-panels-minsize
Revert "Set a minimum width for editor and PDF panels"

GitOrigin-RevId: 6dbf7256526aedfbfac8377c69499d9e1c6b577d
2021-11-22 09:03:11 +00:00
Alf Eaton
1fc57aadcf Merge pull request #5721 from overleaf/hb-fix-log-line-parsing
Improve file line error log parser regex

GitOrigin-RevId: d3fbb39b4a6d99e339c1d6e6eb81d9cfb3ec5935
2021-11-17 09:03:25 +00:00
Alf Eaton
07361a8f68 Merge pull request #5749 from overleaf/ab-ide-panels-minsize
Set a minimum width for editor and PDF panels

GitOrigin-RevId: cc63e56df6f37c74995c00d1855dc3a0feccc32a
2021-11-17 09:03:19 +00:00
Alf Eaton
dd733fda84 [web] Add autocomplete to LaTeX language for CodeMirror 6 (#5780)
GitOrigin-RevId: 90f1f3b680a68f8eb14828c9e5db94587974a6d4
2021-11-17 09:03:12 +00:00
Alf Eaton
205d853cea Merge pull request #5743 from overleaf/jk-cm-realtime-integration
[web] CodeMirror 6 integration with real-time / ShareJs

GitOrigin-RevId: e8507ea1365828140948472625b3de6ab8a227c5
2021-11-16 09:02:39 +00:00
Alf Eaton
3feca1ffc6 Move symbol palette to module and add overlay (#5396)
GitOrigin-RevId: 649dd56aaecd60662bd2bf534bda323ee541874f
2021-11-11 09:03:05 +00:00
Miguel Serrano
f97f753b1e Merge pull request #5499 from overleaf/msm-remove-angular-nav-toolbar
Remove Angular Navigation UI

GitOrigin-RevId: a71da3da665515ec6ce74ae41ff1f0b47b86134e
2021-11-09 09:04:16 +00:00
Jakob Ackermann
8ba1803972 Merge pull request #5625 from overleaf/jpa-block-update-loop
[web] block a loop of failing rootDoc update requests

GitOrigin-RevId: 1388024fc125ee1e80e45a7bbbc787306cb60d1d
2021-11-03 09:03:09 +00:00
Jakob Ackermann
7f9fd00bda Merge pull request #5367 from overleaf/jpa-node-handle-callback-err
[misc] fix eslint violations for node/handle-callback-err

GitOrigin-RevId: 83a4900e8861010df1917bff49382bd9c93375bd
2021-10-28 08:03:26 +00:00
Jakob Ackermann
a6f05109a3 Merge pull request #5352 from overleaf/jpa-no-var
[misc] fix eslint violations for `no-var`

GitOrigin-RevId: c52e82f3a8a993b8662cc5aa56e7b95ca3c55832
2021-10-27 08:03:00 +00:00
Alf Eaton
913a62fbc8 Migrate synctex controls to React (#5503)
GitOrigin-RevId: 80362a00ae6b73616a6fa9b3193b9b9974b5fd35
2021-10-22 08:03:43 +00:00
Alf Eaton
ffc72416ff Move clsiServerId and compileGroup from ide to ide.$scope.pdf (#5314)
GitOrigin-RevId: 6050898614b4fc9dee52e893149acfda17c324a0
2021-10-11 08:03:10 +00:00
Alf Eaton
4adf32cb43 Filter out "source: compile' annotations (#5324)
GitOrigin-RevId: f0febf42fa46a28b357b2c4c2768f2a9b543e609
2021-10-11 08:03:00 +00:00
Eric Mc Sween
060fa5cfe2 Merge pull request #5322 from overleaf/em-disable-file-line-errors
Disable file line errors

GitOrigin-RevId: b62b8f98c1cb48659e0320daec458443f7f40877
2021-10-01 08:03:45 +00:00
Alf Eaton
73bc3418a2 Add React version of the PDF preview pane (#5135)
GitOrigin-RevId: fcc88a362c3e97c9fddf85d47c3a83a0a0b89432
2021-10-01 08:03:12 +00:00
Brian Gough
91c31b2523 Merge pull request #5206 from overleaf/bg-roll-out-file-line-errors-all
roll out file line errors all users

GitOrigin-RevId: a7335217e20f9532521a094793f0d7d377cc8f8c
2021-10-01 08:03:08 +00:00
Hugh O'Brien
9c83d58caa Merge pull request #5104 from overleaf/hb-move-log-parsers-to-web
Move log parsers to web

GitOrigin-RevId: c9983e168aba6e690809f45c2a056228dc69e0f3
2021-09-29 08:03:21 +00:00
Brian Gough
7bdd5c8e98 Merge pull request #5205 from overleaf/bg-roll-out-file-line-errors-beta
[web] roll out file line errors to beta users

GitOrigin-RevId: 7a404295532cfd0c3b0b28af424d0e9c7b8cae0d
2021-09-28 08:03:12 +00:00
Brian Gough
f5fce04e34 Merge pull request #5175 from overleaf/bg-enable-file-line-errors-for-alpha
[web] enable file-line-errors for alpha group

GitOrigin-RevId: 95579162410be25d9908b74816d240ec95432463
2021-09-24 08:02:55 +00:00
Brian Gough
cc1b73336a Merge pull request #4944 from overleaf/bg-use-file-line-errors
use file line errors in log output

GitOrigin-RevId: 6732b19552fe15431a70fbefbc572253c389c64e
2021-09-22 08:03:25 +00:00
Alf Eaton
d9d7382e80 Merge pull request #5139 from overleaf/ae-pdfjs-viewer-tabindex
Add tabindex to pdfjs-viewer element

GitOrigin-RevId: be7bcba5e3c462b712dcb4deabe3ff8cf3d0233b
2021-09-20 08:03:01 +00:00
Timothée Alby
c5f883ad83 Merge pull request #5031 from overleaf/ab-paywall-events
Merge paywall-prompt and paywall-click events

GitOrigin-RevId: d567631d08b89565f9a3049f9b88cc2d14a799c1
2021-09-17 08:03:12 +00:00
Jakob Ackermann
dd291da265 Merge pull request #5113 from overleaf/em-compile-error-link
Fix compile error link in TeX Live 2021

GitOrigin-RevId: d1193e638d6f41c2b8045350b16296c42944ff0c
2021-09-16 08:03:50 +00:00
Hugh O'Brien
ab736aecc6 Merge pull request #5044 from overleaf/hb-roll-out-react-file-view
Roll out react file view to all users

GitOrigin-RevId: 714246e8de39d1f686c3c07ff298d2c236cbdb8b
2021-09-15 08:03:47 +00:00
Hugh O'Brien
f7900b474b Merge pull request #4799 from overleaf/hb-eslint-rules
Re-enable some eslint rules

GitOrigin-RevId: 16153adb839bb61784bb40fbc8e43da281fe090d
2021-09-15 08:03:43 +00:00
Alf Eaton
49b1356976 Merge pull request #5081 from overleaf/ae-webpack-libs-alias
Remove webpack alias for vendor/libs

GitOrigin-RevId: ab84b21402236143ad4d5d988b01fbbbcc081532
2021-09-15 08:03:39 +00:00
Alf Eaton
eede3a26b6 Merge pull request #4953 from overleaf/ae-resize-sidebar-layout
Fix editor resizing when editor is hidden

GitOrigin-RevId: 1baf4c88bec459b1669d708609d4425891ebfd05
2021-09-06 08:03:03 +00:00
Alf Eaton
1736c998bf Merge pull request #4952 from overleaf/ae-resize-layout
Fix vertical editor pane resizing when layout changes

GitOrigin-RevId: d6e01326f919994725778392ff3aa291f3b8c1ea
2021-09-06 08:02:59 +00:00
Alf Eaton
7ba6776b2e Merge pull request #4942 from overleaf/ae-synctex-controller
Move PdfSynctexController and synctex factory to a separate module

GitOrigin-RevId: 0fdd87425159bbdec21ab5c82c9f4abb47f82d07
2021-09-06 08:02:56 +00:00
Miguel Serrano
296ce0e460 Simplify error hint when symbols are used outside of math mode (#4301)
* Simplify error hint when symbols are used outside of math mode

* Fix rendering and added option to skip rendering on plain mode

* Remove unnecessary WikiLink as it is automatically added

* Remove unused skipPlainRendering prop

Co-authored-by: Alasdair Smith <ali@alasdairsmith.co.uk>
GitOrigin-RevId: 7091873beaa05b04f534628cbdd9a559020cfc8e
2021-08-04 02:05:37 +00:00
Jakob Ackermann
86099725ad Merge pull request #4293 from overleaf/jpa-pdf-js-error-handling
[frontend] fix broken PDF preview caused by missing error handling

GitOrigin-RevId: a7bba8d1b351a53fb20eb670d2ae4c6d215d0d85
2021-07-28 02:06:15 +00:00
Jakob Ackermann
97da586877 Merge pull request #4326 from overleaf/pr-avoid-double-stringify-compile-events
Remove controller-level `stringify` for compile events

GitOrigin-RevId: 1b33b5204a846dc4f25dcfbad02c1edc1e010e9f
2021-07-20 11:33:33 +00:00
Paulo Jorge Reis
51c6d90c17 Handle PDF rendering errors in the new logs UI (#4280)
* Handle PDF rendering errors in the new logs UI

* Remove new logs UI specific code from the PDFController

* Only change view with errors and validation issues in the new logs UI

GitOrigin-RevId: 0761ac224db39fdacbb61692c1aa35c3da82a76b
2021-07-07 02:05:48 +00:00
Paulo Jorge Reis
db8173011e Revert "Revert "Handle PDF failure error case""
This reverts commit 946838e51feaff28025c4a4d733e0dd89a29e890.

GitOrigin-RevId: 63f130c8cfecfb512ec97bda62c6ea1cad2c8fed
2021-07-07 02:05:36 +00:00
Alf Eaton
34ba76aa76 Merge pull request #4286 from overleaf/jpa-clear-clsi-unavailable-state
[frontend] PdfController: clear clsiUnavailable state for new responses

GitOrigin-RevId: 7a89a24db6c8f0e62e775befcb4148e749ce8b4e
2021-07-06 02:05:46 +00:00
Jakob Ackermann
343ab44172 Merge pull request #4279 from overleaf/bg-revert-async-apply-in-pdfcontroller
revert async apply in PdfController

GitOrigin-RevId: 20628ca8c9ba06528271e1323ba062d6b563e08e
2021-07-01 12:29:45 +00:00
Paulo Jorge Reis
4e384e0c3b Revert "Handle PDF failure error case"
This reverts commit 902a97f6f454f09345ba4017b50623fd46e57110.

GitOrigin-RevId: 946838e51feaff28025c4a4d733e0dd89a29e890
2021-06-29 02:05:56 +00:00
Paulo Reis
07f44b99f4 Handle PDF failure error case
GitOrigin-RevId: 902a97f6f454f09345ba4017b50623fd46e57110
2021-06-25 02:06:16 +00:00
Alf Eaton
9b9d6f679e Wrap recompile response handlers in $applyAsync (#4253)
GitOrigin-RevId: 80e5652b88ba70b3ea1aef2cf24430597574353e
2021-06-24 02:07:19 +00:00
Alf Eaton
7c97f8ab6e Switch to new JSX runtime (#4225)
* Use new JSX runtime and update Babel Node target
* Update .eslintrc
* Remove React imports

GitOrigin-RevId: 559de0267f8f2934c56a860ea8701bb522aa861a
2021-06-24 02:06:59 +00:00
Jakob Ackermann
b2bc589ad1 Merge pull request #4236 from overleaf/jpa-cleanup-metrics
[PdfJsMetrics] drop unused metrics

GitOrigin-RevId: 377cb4c97746bb81b9cf90e1d48e0050a8d05893
2021-06-23 02:05:52 +00:00
Timothée Alby
866e2f0aab Merge pull request #4223 from overleaf/bg-load-server-worker-timeout
add timeout on loading of service worker

GitOrigin-RevId: d2153c9abf1dbd6eee3b2fcfd770a21766ebb84e
2021-06-22 02:07:16 +00:00
Jakob Ackermann
a6cce9d2f6 Merge pull request #4210 from overleaf/jpa-pdf-caching-5-percent
[misc] pdf caching out of beta with 5%/5% control/treatment split test

GitOrigin-RevId: 06a741f56510b866be3380a99304d8ee67f849dd
2021-06-17 02:09:15 +00:00
Jakob Ackermann
e8bb0114f8 Merge pull request #4203 from overleaf/bg-admin-disable-service-worker
disable service worker via admin page

GitOrigin-RevId: 96ec9f07b32b831f5271827ab345ad831044f831
2021-06-17 02:09:06 +00:00
Alf Eaton
6ab9fffb49 Remove Angular file tree modal code (#4198)
GitOrigin-RevId: feeae54575cce8b315b4e6bb0df3e17405025855
2021-06-16 02:05:58 +00:00
Jakob Ackermann
d9cd12db4e Merge pull request #4197 from overleaf/jpa-compile-metrics-version
[misc] PdfJsMetrics: add a version number to the compile segmentation

GitOrigin-RevId: 18d1481fe120f12895633adfd06a4036eca62de0
2021-06-15 02:06:29 +00:00
Jakob Ackermann
3b3f1fbb73 Merge pull request #4196 from overleaf/jpa-compile-metrics-version
[misc] PdfJsMetrics: add a version number to the event segmentation

GitOrigin-RevId: 4c5e1df9e3513edbfeae0f47303ce9512a25c118
2021-06-15 02:06:25 +00:00
Shane Kilkelly
05e427624b Merge pull request #4180 from overleaf/ae-new-file-button
Open the new file modal with an event

GitOrigin-RevId: 1eca8faf63bdd2011b931868b0e1073bb047266e
2021-06-12 02:08:36 +00:00
Alf Eaton
8b40e760ca Merge pull request #4133 from overleaf/ae-project-too-large
Display project-too-large error

GitOrigin-RevId: 9078b4f24d3380a4554f9fd91fe0254524763830
2021-06-11 02:06:51 +00:00
Alf Eaton
3ab0aee30c Merge pull request #4131 from overleaf/ae-uneditable-file-outline
Notify the outline manager when a file is opened

GitOrigin-RevId: 246da98f1b9a433aeeb8e5b420ad0999544778c3
2021-06-11 02:06:46 +00:00
Alf Eaton
764234e42b Merge pull request #4158 from overleaf/ae-rename-file-view
Rename `binary-file` components to `file-view`

GitOrigin-RevId: b960d4e6f154ee1a5847782a1fcb1e4e61159603
2021-06-11 02:06:38 +00:00
Jakob Ackermann
c774ddd111 Merge pull request #4169 from overleaf/jpa-pdf-caching-full-beta
[misc] change pdf caching split test for beta users to 50/50 roll out

GitOrigin-RevId: 3153448db82a9f0fa821da9d6cf5255e1feaaf28
2021-06-11 02:06:24 +00:00
Alexandre Bourdin
c634f51eee Merge pull request #4116 from overleaf/ab-paywall-prompt-events
Add paywall prompt events

GitOrigin-RevId: 6b1b3b384590f14828f37210b2e14047e2ee33d6
2021-06-11 02:05:54 +00:00
Jessica Lawshe
4c6933b5b8 Merge pull request #4162 from overleaf/jpa-service-worker-error-reporting
[misc] serviceWorker: add error reporting using postMessage API

GitOrigin-RevId: db021d4f5cd5b7b8a0026b92d412112f60499c0b
2021-06-10 02:05:28 +00:00
Alf Eaton
cce0051be6 Merge pull request #4140 from overleaf/ae-react-share-modal
Remove Angular share modal code

GitOrigin-RevId: 136b10c7b9768f2d8de13e48b16fd71947506624
2021-06-08 02:05:34 +00:00
Eric Mc Sween
568e99ad47 Merge pull request #4125 from overleaf/em-analytics-keepalive
Use keepalive when sending analytics events

GitOrigin-RevId: c4e5884483313cdc67abe98e18852680692ac229
2021-06-04 02:08:19 +00:00
Jakob Ackermann
862f7f413a Merge pull request #4137 from overleaf/jpa-fix-metrics-collection
[PdfJsMetrics] fix metrics collection with disabled service worker

GitOrigin-RevId: 607ecd15a3b95b33a45506c489557e5116168c3d
2021-06-03 02:08:56 +00:00
Jakob Ackermann
58c7b6188f Merge pull request #4123 from overleaf/jpa-pdf-caching-one-split-test
[misc] rework roll-out of pdf caching

GitOrigin-RevId: 98ff50918050fe8e9fb5bfecb862657d48cd2726
2021-06-02 02:05:50 +00:00
Jakob Ackermann
e1516aab2c Merge pull request #4110 from overleaf/jpa-omit-skewed-render-latency
[frontend] PdfJsMetrics: omit render time in case we detect hidden page

GitOrigin-RevId: b1ae3b29dbb9764cf67f2f1b1e2f93c83fe67426
2021-06-02 02:05:46 +00:00
Jakob Ackermann
5988e03dac Merge pull request #4108 from overleaf/jpa-lean-pdf-caching-metrics
[frontend] PdfJsMetrics: submit a subset of data points, flatten nested

GitOrigin-RevId: a98ede58f5823020a4c78f46b9800369185f1336
2021-06-02 02:05:43 +00:00
Jakob Ackermann
0015002e53 Merge pull request #4107 from overleaf/jpa-compile-time-client-e2e
[frontend] PdfController: track the e2e compile time seen by the client

GitOrigin-RevId: 1d7c8b815735fd3c0ad9a32284c37c621798fbd3
2021-06-02 02:05:40 +00:00
Jakob Ackermann
6140b53493 Merge pull request #4081 from overleaf/msm-symbol-toggle-styling
Added 'active' styling to Symbol Palette toggle button

GitOrigin-RevId: a1a51e42a08cd3627d0bc4610e6895e111d951f9
2021-06-01 02:05:37 +00:00
Jakob Ackermann
b93761f275 Merge pull request #4094 from overleaf/jpa-tag-pdf-caching-traffic
[frontend] PdfController: tag traffic that uses the pdf caching logic

GitOrigin-RevId: ab0d847ff1fe31131428c782ce95b3a5b3dff4fd
2021-05-27 02:05:59 +00:00
Alf Eaton
823960f763 Merge pull request #4079 from overleaf/ae-ace-replace-range-symbol
Replace all selected ranges when inserting symbol into source editor

GitOrigin-RevId: bc0d7548f61fd740a87b34bb181516e8dc21fff1
2021-05-26 02:05:17 +00:00
Jakob Ackermann
fa914af56c Merge pull request #4083 from overleaf/bg-avoid-multiple-pdf-renders-on-loading
ignore pdf rendering before loading has completed

GitOrigin-RevId: 3ad435507045decf49c3678abe3bfadd07d0cbca
2021-05-22 02:05:59 +00:00
Jakob Ackermann
f0b3d8a26a Merge pull request #4076 from overleaf/jpa-events-split-test
[misc] submit events and prepare roll-out for pdf caching w/ split test

GitOrigin-RevId: a7b7af65e1adf5bf003b65d96f1641a343b4b09c
2021-05-22 02:05:44 +00:00
Jakob Ackermann
f49a539c91 Merge pull request #4073 from overleaf/jpa-verify-chunks
[misc] serviceWorker: add optional verification of chunk

GitOrigin-RevId: 7fe9619ab9a928409cdf665d938734bb6a77f853
2021-05-22 02:05:41 +00:00
Jakob Ackermann
dfabc3a93b Merge pull request #4072 from overleaf/jpa-pdfjs-metrics
[frontend] PdfController: observe PDF.js fetch/render performance

GitOrigin-RevId: bdd81ba06dabaa944b64266d0c36700d16790a30
2021-05-22 02:05:38 +00:00
Jessica Lawshe
fefb588d71 Merge pull request #3973 from overleaf/as-clean-up-hue-generator
Clean up hue generator

GitOrigin-RevId: 1b7fad05d7c2f6519efbbe0379f2449c273e4f4b
2021-05-19 02:06:15 +00:00
Miguel Serrano
73c47fa0e0 Layout divider for Symbol Palette (#4036)
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: e22635978c16646060c80ceb8376a560bfbf6527
2021-05-18 02:08:12 +00:00
Jakob Ackermann
7db7cd4a49 [misc] merge pdf caching into main (#4033)
* [frontend] WIP: pdf caching using service worker -- squashed

Ref: 920fbaa00b31530f7c457a2d93bad5e553798057
Co-Authored-By: Brian Gough <brian.gough@overleaf.com>
Co-Authored-By: Eric Mc Sween <eric.mcsween@overleaf.com>

* [misc] add contentId into the URL for protecting PDF stream contents

* [misc] gracefully handle missing ranges in serviceWorker

* [misc] support PDF stream caching for anonymous users

* [misc] polish header names and add URL to error message when fetch fails

* [misc] polish event handler registration

* [misc] limit serviceWorker scope to /project/ -- trailing slash

This will block the service worker from intercepting requests on the
 project dashboard.

* [misc] add per-request feature flag for enabling PDF stream caching

* [misc] expose compile stats and timings to the frontend

* [misc] serviceWorker: support clsiServerId and compileGroup url params

* [misc] serviceWorker: polish header maps

* [misc] serviceWorker: drop TODO for p-limit -- the browser has a queue

* [misc] serviceWorker: drop verbose log message on every fetch

* [misc] cut down size of diff in backend code

* [misc] add test case for forwarding of pdf caching and metrics details

* [misc] serviceWorker: drop all the log lines

* [misc] serviceWorker: add boundary guards to the compile request regex

Co-authored-by: Brian Gough <brian.gough@overleaf.com>
Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>
GitOrigin-RevId: 4b291b4a4f2866cf07bccf8ec9068f33bbfdc916
2021-05-18 02:07:57 +00:00
Miguel Serrano
bb88af80cf Merge pull request #3947 from overleaf/msm-reenable-eslint-rules
Reenable `eslint` rules

GitOrigin-RevId: a0aa5f941ba1bc49ff758b5256f91d696f442c6d
2021-05-14 02:09:45 +00:00
Miguel Serrano
f9871103bf Merge pull request #3949 from overleaf/msm-reenable-eslint-const-rule
Reenable eslint `prefer-const` rule

GitOrigin-RevId: 4f3825be8b8dff381095209085a36eaab76260d5
2021-05-06 02:09:14 +00:00
Alf Eaton
dbc909ae54 Merge pull request #3970 from overleaf/ae-remove-filetreereactbridge
Remove showReactAddFilesModal, showReactFileTree, useFileTreeAngularListener and FileTreeReactBridge

GitOrigin-RevId: 61fc54efe761922137b032b9b532975fc101264d
2021-05-01 02:13:18 +00:00
Chrystal Maria Griffiths
3dfcb95802 Merge pull request #3960 from overleaf/cmg-binary-file
[BinaryFile] Reopening of Binary file React migration

GitOrigin-RevId: 050e66e3321bd6579d44932b669fc0a31df06d18
2021-04-29 02:09:38 +00:00
Jakob Ackermann
adfde7d26b Merge pull request #3950 from overleaf/msm-reenable-lint-prefer-regex-literals
Reenable `prefer-regex-literals` eslint rule

GitOrigin-RevId: 3c576d92a08dfcb745d447b1bf8c7b828753010d
2021-04-29 02:09:10 +00:00
Miguel Serrano
8fbd4e3340 Merge pull request #3963 from overleaf/revert-3819-msm-update-pdfjs-2-6
Revert "Update `pdf.js` to `2.6.347`"

GitOrigin-RevId: 62402d8e0b99b302206f0edc61411c9477d29249
2021-04-28 02:10:27 +00:00
Miguel Serrano
bac110ee46 Merge pull request #3819 from overleaf/msm-update-pdfjs-2-6
Update `pdf.js` to `2.6.347`

GitOrigin-RevId: fd2a6708077e574a909ff05105ab70ea7c99daf5
2021-04-28 02:10:23 +00:00
Alf Eaton
1be43911b4 Merge pull request #3942 from overleaf/prettier-trailing-comma
Set Prettier's "trailingComma" setting to "es5"

GitOrigin-RevId: 9f14150511929a855b27467ad17be6ab262fe5d5
2021-04-28 02:10:01 +00:00
Chrystal Maria Griffiths
4e9d7c36ff Merge pull request #3952 from overleaf/revert-cmg-binary-file
Revert "Merge pull request #3526 from overleaf/cmg-binary-file"

GitOrigin-RevId: 5f539f26992fefd01b07922b1f43a3a3bc753141
2021-04-24 02:10:12 +00:00