Commit graph

5652 commits

Author SHA1 Message Date
James Allen
311ebf89c4 Refactor to always use req.externalAuthenticationSystemUsed 2017-11-20 10:10:23 +00:00
Nate Stemen
f00dbf3d56 fixing popup and code folding issues 2017-11-17 16:25:45 -05:00
James Allen
ca0982a909 Enable the external auth switches when OL OAuth in use 2017-11-17 17:16:12 +00:00
Alasdair Smith
154943ba68 Don't check for linting errors if code check is disabled
There are a couple of reasons for this:

1. Some linting errors are returned from the server after a compile is run,
replacing client-side linting errors. If code check is disabled this does not
happen, and therefore linting errors persist until the next compile. This makes
it appear as though autocompile is not running

2. It is likely that if code check is disabled, the user is deliberately
ignoring linting errors and therefore the linting check is pointless
2017-11-17 16:38:44 +00:00
Nate Stemen
00e3e8da9f adding last labels configuration 2017-11-16 14:59:04 -05:00
Nate Stemen
c78a0ae209 removing comment 2017-11-16 14:49:29 -05:00
Nate Stemen
c051316aac adding deleted file 2017-11-16 14:45:20 -05:00
Alasdair Smith
b6289f03e3 Conditional check 2017-11-16 15:58:32 +00:00
Alasdair Smith
8cafda8419 Merge pull request #129 from sharelatex/as-allow-force-rollout
Allow user to force themselves to be part of autocompile rollout
2017-11-16 15:49:28 +00:00
Brian Gough
bd09ef81f2 added comments 2017-11-16 15:41:16 +00:00
Alasdair Smith
b889a8bb4d Allow user to force themselves to be part of autocompile rollout 2017-11-16 15:38:51 +00:00
Alasdair Smith
38ad023927 Merge pull request #111 from sharelatex/as-autocompile-rollout-5
Increase autocompile rollout to 5%
2017-11-16 13:52:42 +00:00
Alasdair Smith
0fda7aa070 Merge pull request #116 from sharelatex/as-autocompile-image
Change autocompile onboarding image to not imply that it is on
2017-11-16 13:52:36 +00:00
Alasdair Smith
2b88d2bc4e Change autocompile onboarding image to not imply that it is on
We have a theory that the image shown in the autocompile onboarding implies
that it is already switched on. This changes the image to show the switch
as off, hopefully fixing it
2017-11-16 13:35:06 +00:00
Brian Gough
dc6110db8d put ace in readonly mode when changing session
if the session fails to attach successfully (e.g due to an exception in
the changeSession event handler) the editor will be left in a state
where the user will not be able to enter any text.  This should at least
cause them to reload the editor.
2017-11-16 11:32:08 +00:00
Alasdair Smith
a5bb76b2be Increase rollout to 5% 2017-11-16 10:36:35 +00:00
Brian Gough
f001c6745e Merge pull request #110 from sharelatex/bg-ace-exception-temporary-fix
temporarily avoid exception in ace event handler
2017-11-15 16:32:45 +00:00
Brian Gough
125a5ec606 temporarily avoid exception in ace event handler
full fix will be to use the angular $http cancellation mechanism
2017-11-15 16:28:31 +00:00
Nate Stemen
a78330877b fixing services call 2017-11-15 10:14:31 -05:00
Shane Kilkelly
2a7e68e37b Merge pull request #109 from sharelatex/sk-token-access-redirect-fix
Set redirect when bouncing away from token route; Fixes overleaf/sharelatex#250
2017-11-15 14:56:42 +00:00
Alasdair Smith
c21b5ca1cc Merge pull request #108 from sharelatex/as-5-pc-rollout
Increase autocompile rollout to 3%
2017-11-15 14:44:40 +00:00
Nate Stemen
428ae3aa53 adding labels service back 2017-11-15 09:27:46 -05:00
Alasdair Smith
b1bae4aaae Change to 3% rollout 2017-11-15 13:47:05 +00:00
Shane Kilkelly
5df4556e9c Set redirect when bouncing away from token route
This ensures that when the user logs in they will be redirected back
to this token, the page they wanted to access in the first place.
2017-11-15 13:30:40 +00:00
Alasdair Smith
0d566f8c39 Increase autocompile rollout to 5% 2017-11-15 12:01:47 +00:00
Shane Kilkelly
a15cb64418 Increase link-sharing rollout to 40% 2017-11-15 10:25:17 +00:00
Paulo Reis
6913d28abb Editor header styling. 2017-11-13 12:03:28 +00:00
Shane Kilkelly
a0c7295b36 Merge branch 'master' of github.com:sharelatex/web-sharelatex-internal 2017-11-13 10:45:29 +00:00
Shane Kilkelly
bc87bceb5f Update the linksharing rollout to 10% 2017-11-13 10:27:27 +00:00
Hayden Faulds
d084b57d5a Merge pull request #90 from sharelatex/hof-version-renames
version entity renames/moves
2017-11-13 10:13:34 +00:00
Shane Kilkelly
aea8e77f8a Merge branch 'as-fix-rollout-2' 2017-11-13 09:50:46 +00:00
Shane Kilkelly
8ba9073606 Merge branch 'sk-link-sharing-onboarding' 2017-11-13 09:31:44 +00:00
Shane Kilkelly
e63f452807 Merge branch 'sk-smarter-percentage-rollout' 2017-11-13 09:24:11 +00:00
Brian Gough
fe12a341e1 Merge pull request #89 from sharelatex/bg-slow-connection-fix
increase allowed op backlog and flush tolerance
2017-11-13 09:22:18 +00:00
Shane Kilkelly
cac39134cd Remove stray test lines 2017-11-10 16:20:59 +00:00
Shane Kilkelly
600191b2af Ensure that different features produce different results 2017-11-10 16:19:43 +00:00
Shane Kilkelly
3a4edeaf4c Add a unit test for _isInPercentageRollout 2017-11-10 16:13:27 +00:00
Shane Kilkelly
00f095da3c Merge branch 'master' into sk-smarter-percentage-rollout 2017-11-10 16:00:02 +00:00
Shane Kilkelly
032400905d Fix a silly assignment mistake 2017-11-10 15:59:11 +00:00
Shane Kilkelly
df31748148 Distinguish between separate percentage rollouts 2017-11-10 15:50:17 +00:00
Shane Kilkelly
23814d25ac Merge pull request #101 from sharelatex/sk-bypass-percentage-rollout
Option to bypass percentage rollouts (for on-site deploys)
2017-11-10 15:33:28 +00:00
Shane Kilkelly
0539930906 Use the common _isInPercentageRollout function for autocompile 2017-11-10 14:16:00 +00:00
Shane Kilkelly
22d1693f38 Add option to bypass percentage-based rollouts 2017-11-10 14:15:43 +00:00
Shane Kilkelly
87e4303aac Thin out the border around link-sharing onboarding popover arrow 2017-11-10 13:25:59 +00:00
Shane Kilkelly
42c0974671 Place the linksharing popover from the right, not the left.
This ensures the popover reflows properly with window resize.
2017-11-10 12:05:12 +00:00
Shane Kilkelly
faf6178fa8 Restrict link-sharing onboarding popup to admins.
Only people with admin permission to the Project can see the Share
button and dialog. It doesn't make sense to alert users who can't
interact with the feature anyway.
2017-11-10 11:09:46 +00:00
Shane Kilkelly
666ee0669a Alter position of link-sharing popover, and better image 2017-11-10 10:24:36 +00:00
Shane Kilkelly
44420b41d6 Remove stray console log 2017-11-09 15:13:58 +00:00
Shane Kilkelly
766c8d6f0f Add a general 'ide:loaded' event, to init popover 2017-11-09 15:12:55 +00:00
Shane Kilkelly
470ad36218 Add onboarding popup for link-sharing 2017-11-09 14:28:11 +00:00