Commit graph

1384 commits

Author SHA1 Message Date
Timothée Alby
2e70803492 Merge pull request #9798 from overleaf/ta-em-gs-best-subscription-fix
Fix Best Subscription Check

GitOrigin-RevId: a7ea5063d4287a421b96222763a59c15652c8d6f
2022-10-18 08:03:01 +00:00
Alexandre Bourdin
dce00bbefe Merge pull request #9789 from overleaf/ab-tags-controller-async-await
[web] Cleanup and move TagsController to async/await

GitOrigin-RevId: 9684e341146e533e5a06eb6001997adf56ecced0
2022-10-13 08:04:32 +00:00
Eric Mc Sween
da30da76b2 Merge pull request #9894 from overleaf/em-node-fetch-web
Replace request-promise with node-fetch in web

GitOrigin-RevId: 07dbb6db7fd42326807aaeb18e5ee39f7c3d4668
2022-10-13 08:04:24 +00:00
Thomas Mees
37b598fa5a Teardown premium features discoverability and implement variant
GitOrigin-RevId: 46dfa1aae117e1862c828bed568085dcd59acd8b
2022-10-12 08:04:51 +00:00
Jakob Ackermann
37c69ec830 Merge pull request #9493 from overleaf/jpa-dropbox-create-project-action
[misc] create new project (folder) when creating project in dropbox/web

GitOrigin-RevId: 4235b6ed66d0957bf45cb6f6009201ee02e188ca
2022-10-05 13:25:22 +00:00
Jakob Ackermann
ac91f40c08 Merge pull request #9316 from overleaf/jpa-dropbox-sync-detached-from-project-name
[misc] detach dropbox sync from project names

GitOrigin-RevId: 57b3a131aec81bc97ff4da57497950d6658eaeff
2022-10-05 13:25:08 +00:00
Miguel Serrano
74f44e655a Merge pull request #9617 from overleaf/msm-audit-log-collections
Move project/user audit logs to their own collections

GitOrigin-RevId: f6f89b3e2815c0fe5691a79eceb35b77b3c370d8
2022-09-30 08:04:17 +00:00
Jakob Ackermann
13acf0dbd7 Merge pull request #9755 from overleaf/jpa-dropbox-use-project-id-from-web
[misc] let web feed back projectId to resolve "unknown project" updates

GitOrigin-RevId: d005370e7a1e7a4a5d9e54d62e47dfff3541f8f1
2022-09-28 08:07:32 +00:00
June Kelly
3288f87dbe [web] Password set/reset: reject current password (redux) (#8956)
* [web] set-password: reject same as current password

* [web] Add 'peek' operation on tokens

This allows us to improve the UX of the reset-password form,
by not invalidating the token in the case where the new
password will be rejected by validation logic.

We give up to three attempts before invalidating the token.

* [web] Add hide-on-error feature to async forms

This allows us to hide the form elements when certain
named error conditions occur.

* [web] reset-password: handle same-password rejection

We also change the implementation to use the new
peekValueFromToken API, and to expire the token explicitely
after it has been used to set the new password.

* [web] Validate OneTimeToken when loading password reset form

* [web] Rate limit GET: /user/password/set

Now that we are peeking at OneTimeToken when accessing this page,
we add rate to the GET request, matching that of the POST request.

* [web] Tidy up pug layout and mongo query for token peeking

Co-authored-by: Mathias Jakobsen <mathias.jakobsen@overleaf.com>
GitOrigin-RevId: 835205cc7c7ebe1209ee8e5b693efeb939a3056a
2022-09-28 08:06:54 +00:00
Mathias Jakobsen
b5e2604041 [web] Upgrade restricted user access if they are invited members (#9401)
* [web] Upgrade restricted user access if they are invited members

Previously, if a user joined a project via a read-only link and later on
joined the project via an invite, we would still treat them as
restricted users, disabling chat and commenting. This patch changes
that, so that we do *not* consider an invited user restricted.

GitOrigin-RevId: e2acdfd29cc0687cb7276310a9c96d697087b21a
2022-09-28 08:06:44 +00:00
Eric Mc Sween
33d9f08599 Merge pull request #9696 from overleaf/em-fix-dropbox-top-level
Fix Dropbox metadata collection for top level folders

GitOrigin-RevId: a6262968f206cfd3459f2bae628f156d22bccd91
2022-09-22 08:04:29 +00:00
Eric Mc Sween
a6307d8497 Merge pull request #9658 from overleaf/em-dropbox-folder-sync
Sync folder creation from Dropbox to Overleaf

GitOrigin-RevId: a2749ab8d9db7dd312818b46d6e72f1dbaaaff2e
2022-09-22 08:04:22 +00:00
Eric Mc Sween
59cdcccc26 Merge pull request #9647 from overleaf/bg-dropbox-to-overleaf-existing-doc
handle updates to existing doc in dropbox to overleaf metadata

GitOrigin-RevId: e82955a4a76e62fb649263a94103fdb7f322de85
2022-09-22 08:04:11 +00:00
Eric Mc Sween
76e0265ed7 Merge pull request #9587 from overleaf/em-dropbox-to-overleaf
Record metadata on Dropbox-to-Overleaf updates

GitOrigin-RevId: 34eb774a52d1c683fb1dddecc1c4c646bfc9eb2e
2022-09-22 08:04:04 +00:00
Davinder Singh
70e63ca0e3 Merge pull request #9614 from overleaf/ab-limit-tag-length
[web] Restrict the length of tags to 50 characters

GitOrigin-RevId: fc20227e3e2171bf9e27c983105ecc7b198cf882
2022-09-16 08:04:41 +00:00
Thomas
db9fad7cf8 Merge onboarding experiments integration branch (#9571)
* Add onboarding survey page

* Add onboarding new analytics events to mixpanel allowlist

* [web] Try Premium prompt

* moved try-premium code to overleaf-integration

* fixed sheet styling

* Add onboarding flow redirect handling to registration handlers (#9462)

* Add redirect logic for onboarding flow after registration

* Update UPGRADE_PROMPT_URL

* Cleanup style of OverleafAuthenticationController

* Refactor finishLogin calls to call wrapped function in OverleafAuthenticationController

* Refactor user properties/onboarding flow redirect into finishLogin wrapper

* Fix async/await calls after refactoring

* Update tests for finishLogin refactoring

* Don't redirect to upgrade prompt if user has premium via commons

Co-authored-by: Miguel Serrano <mserranom@users.noreply.github.com>
GitOrigin-RevId: 7c392aa6949f99fa909f9ca4e4baad4c4d4ff6be
2022-09-15 08:04:06 +00:00
Alexandre Bourdin
a0fabee3b4 Merge pull request #9245 from overleaf/integration-project-dashboard-react-migration
[Integration branch] Project Dashboard React Migration

GitOrigin-RevId: 3c3db39109a8137c57995f5f7c0ff8c800f04c4e
2022-09-14 08:04:03 +00:00
Eric Mc Sween
19c73cbd73 Merge pull request #9563 from overleaf/em-tpds-merge-metadata
Return metadata from TPDS update endpoint in web

GitOrigin-RevId: 9154be67f7f975807c6e986a5d6fb66013c9a384
2022-09-13 08:05:50 +00:00
Eric Mc Sween
dc2097e684 Merge pull request #9535 from overleaf/em-promisify-update-merger
Promisify UpdateMerger

GitOrigin-RevId: 5aca78225b524d95f0c47ae872df64edd2685b01
2022-09-08 08:03:52 +00:00
Eric Mc Sween
6b8dc91f9f Merge pull request #9526 from overleaf/em-promisify-tpdsupdatehandler
Promisify TpdsUpdateHandler

GitOrigin-RevId: 3955a535e8d0b702751883d05c21c4c78717fed5
2022-09-08 08:03:46 +00:00
Eric Mc Sween
ff9c2c23b7 Merge pull request #9514 from overleaf/em-send-deleted-ids-to-tpds
Send a list of deleted entities to TPDS

GitOrigin-RevId: 41813c31846338edc36c6ec6abc8c5a9e96731f4
2022-09-07 08:04:05 +00:00
Eric Mc Sween
e3a51ee385 Merge pull request #9472 from overleaf/em-promisify-tpdscontroller
Promisify TpdsController

GitOrigin-RevId: 35d1db628c44d39ee71bb3127cb25ece6d184457
2022-09-02 08:05:16 +00:00
Brian Gough
af3629687b Merge pull request #9335 from overleaf/bg-queue-polling
combine dropbox polls and updates into one queue

GitOrigin-RevId: b966f706af9000ce80977b78cd84207a22db25a2
2022-09-02 08:04:55 +00:00
Eric Mc Sween
e3303bb276 Merge pull request #9409 from overleaf/em-send-more-metadata-to-tpds
Send more metadata to TPDS

GitOrigin-RevId: e6a76a9974fbd8a7fc6a6b861c88ff4728301bc3
2022-08-31 08:03:45 +00:00
Mathias Jakobsen
6169ba55e5 Merge pull request #9389 from overleaf/mj-angular-settings-cleanup
[web] Angular settings removal

GitOrigin-RevId: a7efdf31d488aa782e0ad400f05169645e1731d0
2022-08-30 08:03:52 +00:00
Eric Mc Sween
8b2f8ce243 Merge pull request #9383 from overleaf/em-file-tree-histories
Track source for all file tree operations

GitOrigin-RevId: ff95ea8e99bfa30203a2a42968519bbaba65e708
2022-08-26 08:03:30 +00:00
Mathias Jakobsen
f5b2cdc3cb Merge pull request #9319 from overleaf/mj-deferred-recurly-email
[web] Use bull queues for deferred cancellation email

GitOrigin-RevId: a104f9940badcffc15f1f237a1cefd5dd912f4e0
2022-08-24 08:04:36 +00:00
Alf Eaton
e741eb0cb8 Remove PDF detach split test (#9275)
GitOrigin-RevId: 9e227fe45d874e01c4282ebbe489d7bd6d2250ac
2022-08-19 08:03:47 +00:00
Alf Eaton
09cea1cb85 Keep existing docs as docs when re-importing, regardless of file extension (#9104)
GitOrigin-RevId: b44129e87e97db4a18a77edda7e59631aa222dd5
2022-08-15 08:03:12 +00:00
Alf Eaton
19db9c2583 Fix ProjectEntityHandler.getAllEntities callback in _findExistingFileType (#9108)
GitOrigin-RevId: fe29488b44fa5e738c23f2939297057fb2832758
2022-08-10 08:04:30 +00:00
Simon Detheridge
9953822175 Merge pull request #6661 from overleaf/spd-local-tests
Move acceptance test mocks to nonstandard ports and add options for running locally

GitOrigin-RevId: bd8f70ac8d80599daccc51cfe7b90a2ad8d8c3d8
2022-08-10 08:03:45 +00:00
Jessica Lawshe
f1ee27a518 Merge pull request #9074 from overleaf/jel-saml-log-tests
[web] Add tests for SAML log

GitOrigin-RevId: 7bc5b25461063b32d3471b7f4ab966f2caa4e70c
2022-08-09 08:03:05 +00:00
Miguel Serrano
b7a28f10fe [web] Enable PDF Detach and Dictionary editor in SP (#8959)
GitOrigin-RevId: a02d35d5bc30b25e8be02943f6c1fdee3f6ddaad
2022-07-27 12:18:19 +00:00
Mathias Jakobsen
e0c23d83da [web] Add auditing of email removals (#8904)
* [web] Add auditing of email removals

* [web] Improve auditing of email removal from script

GitOrigin-RevId: ccb948f01616a0bcb2d8f718d6b9e69585e8bb89
2022-07-27 12:17:31 +00:00
M Fahru
eb63eadca1 Fix link sharing upgrade prompt show/hide logic
GitOrigin-RevId: 58c1fbdea566b48e770f9f7c7fd5f926fb1fdb37
2022-07-27 08:05:29 +00:00
Thomas Mees
fc65e54718 Check features before showing upgrade prompts
GitOrigin-RevId: 6f0ed9eca88197e1160b149cb304e27075aa0627
2022-07-26 08:04:14 +00:00
June Kelly
d99be63877 Merge pull request #8945 from overleaf/jel-decaf-cleanup
[web] decaf cleanup a test file

GitOrigin-RevId: 55b1d8df2d6f22204712360bb30b5548abd0d933
2022-07-22 08:04:41 +00:00
M Fahru
66998e2a00 Refactor createSubscription in SubscriptionController to use async/await (#8938)
GitOrigin-RevId: 47fd56f35ac1d5727c7e53eeecedf200738c4e11
2022-07-21 08:03:37 +00:00
Jakob Ackermann
3c0bb25249 Merge pull request #8886 from overleaf/jpa-pdf-caching-alpha
[web] prepare alpha release of pdf caching

GitOrigin-RevId: 5617dd443da57b7077db793c2bc39be35ec44ef1
2022-07-21 08:03:10 +00:00
Henry Oswald
5f1abee345 Merge pull request #8939 from overleaf/revert-8882-jk-web-reject-same-password
Revert "[web] Password set/reset: reject current password"

GitOrigin-RevId: f14f970fe93064658a8659537c5cb417e34e2751
2022-07-20 08:04:00 +00:00
June Kelly
d04ea76081 Merge pull request #8882 from overleaf/jk-web-reject-same-password
[web] Password set/reset: reject current password

GitOrigin-RevId: 2c40dda4926d9c68564ae5126b3393b9286bb661
2022-07-20 08:03:36 +00:00
Jakob Ackermann
daa9302fd3 Merge pull request #8895 from overleaf/jpa-allow-empty-segmentation-val
[web] allow empty event segmentation values again

GitOrigin-RevId: a02fd5085697bf7e2f2d4a5c2dc93dfebcd6e140
2022-07-19 08:03:04 +00:00
Alf Eaton
451c910fe3 Merge pull request #8837 from overleaf/mj-fix-default-group-account-translation
Rephrase "Group Account" to "Group Subscription" on subscription management page

GitOrigin-RevId: 899a6f27fbe7533b93345b7c27a4d427d40c5e1a
2022-07-18 08:04:23 +00:00
Jakob Ackermann
97624d0c6c Merge pull request #8847 from overleaf/jpa-emit-start-of-xref-table
[clsi] try to emit the start of the xref table

GitOrigin-RevId: 6d8348a349572cc997ac5924664428228c00fed1
2022-07-18 08:04:17 +00:00
June Kelly
34a7d3598f Merge pull request #8787 from overleaf/msm-force-doc-flush
[web] script to force flushing docs to mongo

GitOrigin-RevId: 6ce3c1e456b92610fe4f90993b373db2070ab392
2022-07-11 08:04:42 +00:00
Jakob Ackermann
f11e1a83cd Merge pull request #8776 from overleaf/jpa-drop-service-worker
[web] goodbye service worker

GitOrigin-RevId: ce85d4850faba15c5877ce1f3e78026de30c6eae
2022-07-11 08:03:57 +00:00
Timothée Alby
5bfb1b8781 Merge pull request #8704 from overleaf/ta-multiple-invites-fix
Fix UX on Duplicate Group Invites

GitOrigin-RevId: e51c406d578b130972024065f9b8bdb2503944a9
2022-07-08 08:03:30 +00:00
Timothée Alby
8f41431719 Merge pull request #8620 from overleaf/ta-analytics-attributes-validate
Ignore Invalid Analytics Attributes

GitOrigin-RevId: 6e3ffc1dcc6088966480ad0704a988174e4fd3fb
2022-07-08 08:03:10 +00:00
Jakob Ackermann
64184a7f56 Merge pull request #8730 from overleaf/jpa-refactor-pdf-caching
[web] refactor pdf caching

GitOrigin-RevId: af6b871fad652f757d8c465085b33a79b955cd6b
2022-07-07 08:03:28 +00:00
Brian Gough
5a3318f5b3 Merge pull request #8701 from overleaf/bg-simple-iterable-paths
simple iterable paths

GitOrigin-RevId: f6906016888ccfc95c88858bdac4d2633fc1c5f4
2022-07-05 08:03:43 +00:00
Jakob Ackermann
3b84710d75 Merge pull request #8649 from overleaf/jpa-halt-on-error-flag
[web] record stopOnFirstError in compile-result-backend event

GitOrigin-RevId: f194daa1cb377e095acf7a280ff5ba7859b8736b
2022-07-01 08:04:05 +00:00
Jakob Ackermann
4660029e38 Merge pull request #8535 from overleaf/jpa-missing-return
[web] add a missing return statement from an error branch

GitOrigin-RevId: 282972cee23f6b426413ede0885695e386fc9352
2022-06-24 08:05:08 +00:00
Eric Mc Sween
318cf770a7 Merge pull request #8556 from overleaf/em-tl-image-alpha-only
Show new TeX Live images to alpha users

GitOrigin-RevId: 4a4a96cc1a6661720fcc14dd1ffae275d19a004a
2022-06-23 08:03:08 +00:00
Jakob Ackermann
51c870c285 Merge pull request #8505 from overleaf/jpa-compile-result-full
[web] collect compile-result for ALL compiles

GitOrigin-RevId: 5ba29fb352bc29d14c22e7e80fa556148d862137
2022-06-23 08:02:46 +00:00
Alexandre Bourdin
3d26c4bb6f [web] Add new admin tool for surveys (#8356)
* Setup survey module and admin page skeleton

* Replace survey staff access permission with admin-only

* Manage survey config with admin tool

* Display configurable survey in project list + add preview in admin

* Fix linting errors and unit tests

* Add acceptance tests for survey module

* Move survey-form to survey components

* Add configuration option for Recurly group subscription users on surveys

* Change survey pre-link text to a lighter gray for accessibility

* Cleanup survey options implementation after review

GitOrigin-RevId: 8f621951efeae458d1ab081fe98b8d0d539cca1a
2022-06-23 08:02:37 +00:00
Jakob Ackermann
c999033eb4 Merge pull request #8534 from overleaf/jpa-fix-downloads
[web] double down on passing compileBackendClass to clsi

GitOrigin-RevId: 6e035a885caa31e55ff0cf63c584f3f03629f1cf
2022-06-22 08:05:40 +00:00
Jakob Ackermann
bfad0841a4 Merge pull request #8483 from overleaf/jpa-faster-compiles-feedback-ui
[web] faster compiles feedback UI

GitOrigin-RevId: 9feea47503aa6bddf51adb73b8c9fbef394fda14
2022-06-22 08:05:14 +00:00
June Kelly
a450a74351 Upgrade async package to 3.2.2 (#8447)
* Revert "Revert "Bump async to 3.2.2 (#7618)""

This reverts commit 75153a555211d654744c2e61e27fe21085826c22.

* [web] fix usage of async.queue.drain in script

* [clsi] fix usage of async.queue.drain

* [spelling] fix usage of async.queue.drain

* [redis-wrapper] fix usage of async.queue.drain

* [web] Test that LockManager queue is cleared

This protects against a regression found when upgrading the
async package. Here we test that the `queue.drain` callback
is really getting called, and the lock is being removed from
the LOCK_QUEUES map.

* [redis-wrapper] Upgrade async to 3.2.2

GitOrigin-RevId: df921e6d7f1d505bd467f22e58600ba1aff48869
2022-06-22 08:03:35 +00:00
M Fahru
c54c048e35 Implement premium features discoverability on successful subscription page with split test (#8336)
GitOrigin-RevId: 362fa289fa6e009e316dcaceae0587f5fc18162c
2022-06-20 08:04:06 +00:00
Brian Gough
2970a09d19 Merge pull request #8423 from overleaf/briangough-issue8388
increase lock and timeout for history resync to 6 minutes

GitOrigin-RevId: 2aea0cbc26c92ed0aad8f815ccd41a2abc0b752e
2022-06-20 08:04:03 +00:00
Alexandre Bourdin
57114c4503 [web] Display the current plan in the project list dashboard (#8293)
* Display the current plan in the project list dashboard

* Add unit tests for SubscriptionViewModelBuilder#getBestSubscription

* Handle free trial for group subscriptions

* Reuse the info-badge icon for the plan labels

* Do not display subscription status when projects are selected

* Custom tooltip for group subscriptions with team name

GitOrigin-RevId: 40982f70cf9fb7c92058e417b73c84af1648c33e
2022-06-17 08:03:40 +00:00
Davinder Singh
c30ec5fa7c Merge pull request #8422 from overleaf/ta-silent-error
Silence Error If AffiliationUnchecked Flag Cannot Be Unset

GitOrigin-RevId: 1e0ffc401dfcc1ac9ae1a3d1de850ab899b4ce8e
2022-06-17 08:03:28 +00:00
Jakob Ackermann
b19c56ccaf Merge pull request #8396 from overleaf/jpa-split-test-mongo-user
[web] implement split test assignment based on mongo user

GitOrigin-RevId: d3e2dff6a5e925cfd0426e9ebfeb7b64dc803f42
2022-06-16 08:03:20 +00:00
Jakob Ackermann
8cdb746628 Merge pull request #8434 from overleaf/revert-7618-dependabot-npm_and_yarn-async-3.2.2
Revert "Bump async to 3.2.2"

GitOrigin-RevId: a5deaea558011fa5a2e1aebe07856e8b0c87c4fc
2022-06-16 08:03:10 +00:00
dependabot[bot]
d55f4dfafa Bump async to 3.2.2 (#7618)
[all] Upgrade async package to 3.2.2

- [web] Fix usages of async library
- [project-history] Fix usage of async library
- [third-party-references] Fix usage of async library
- [track-changes] Fix usage of async library

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: June Kelly <june.kelly@overleaf.com>
GitOrigin-RevId: 90cf132f13da53b2bd6690ee3cdf4d6c8563ecd2
2022-06-16 08:02:49 +00:00
Jessica Lawshe
365250b3c6 Merge pull request #8250 from overleaf/jel-get-saml-user
[web] Lookup SAML users by ID and attribute

GitOrigin-RevId: 874cc1647522257a941a49bc737f0f40833edef6
2022-06-15 08:05:24 +00:00
M Fahru
0204d7947f Refactor successful subcription to use async/await (#8377)
GitOrigin-RevId: 5748486848c6e0576c974e5595acbcdee3daf7f3
2022-06-15 08:04:54 +00:00
Timothée Alby
825c06a3b4 Merge pull request #8376 from overleaf/jpa-delete-zonal-downloads-split-test
[web] tear down split test on zonal downloads -- keep zonal variant

GitOrigin-RevId: a7e1f48cdc64175e4fc28828ad9a46b0a28383b5
2022-06-15 08:04:18 +00:00
Timothée Alby
7794e03dcb Merge pull request #8363 from overleaf/jel-affiliation-check
[web] Handle when no affiliation found for redundant subscription check

GitOrigin-RevId: c0e653b944b994c5eafaa2d4f2d54f3cb57d67fa
2022-06-15 08:04:12 +00:00
M Fahru
73cf4116b6 Interstitial Payment Page UI + Route (#8305)
GitOrigin-RevId: a31f7094db819e0dad4ff3f09c17544d40260dd4
2022-06-14 08:02:16 +00:00
Timothée Alby
e6c7025813 Merge pull request #8289 from overleaf/ta-redundant-subscription-email
Create Redundant Subscription Notification on Email Confirmation

GitOrigin-RevId: 77baab93ebaae85d09681051641e663bb680c17e
2022-06-09 08:02:41 +00:00
Jessica Lawshe
8c816b3b23 Merge pull request #6509 from overleaf/jel-migrate-sso-id
[v1 and web] Migrate institution SSO external user ID

GitOrigin-RevId: f31cd50fbada9a2704df1c837d695f2ff547420d
2022-06-08 08:03:22 +00:00
Timothée Alby
b26c491eb5 Merge pull request #8290 from overleaf/ta-redundant-subscription-saml
Don't Create Redundant Subscription Notification on SAML for Group Plans

GitOrigin-RevId: 99e66201c9423ff7e849b2d68d96651ad6015fd0
2022-06-07 08:02:32 +00:00
Eric Mc Sween
baaf4d4240 Merge pull request #8286 from overleaf/em-halt-on-error-backend
Stop on first error backend implementation

GitOrigin-RevId: 497b1ed2c13f544760d8ad8d029359db75275389
2022-06-07 08:02:21 +00:00
Thomas
f4ef8a3ea0 Allow setting plans page currency with url param (#8263)
* Allow setting plans page currency with url param

GitOrigin-RevId: 5ae977d9872cf5f5b1a234d1273c70c2dd0e14e9
2022-06-06 08:03:52 +00:00
Eric Mc Sween
98f73fe35c Merge pull request #8253 from overleaf/em-decaf-cleanup-compile-controller
Decaf cleanup CompileController and CompileManager

GitOrigin-RevId: 97384c9f76a2487c04f3d8d6a384cefdfcd083d4
2022-06-03 08:03:32 +00:00
Thomas
5e2933e2fe Merge pull request #8240 from overleaf/tm-teardown-persistent-upgrade-test
Teardown persistent upgrade prompt split test and fix styling

GitOrigin-RevId: 8776231c3308c5f08b91232c962c9796a5f4afa0
2022-06-02 08:02:45 +00:00
Timothée Alby
00fa5b2d96 Merge pull request #8162 from overleaf/ae-orcid-capital
Fix ORCID capitalisation

GitOrigin-RevId: 56136473482568e303570c9679a13e5d032d6d34
2022-05-27 08:04:22 +00:00
Jakob Ackermann
a78bcee15f Merge pull request #8135 from overleaf/jpa-refactor-zonal-download
[misc] refactor handling of zone prefix in compile response

GitOrigin-RevId: f1f33d7d257854176f383bb5d786710f6b09f737
2022-05-26 08:03:53 +00:00
M Fahru
43a069edca Improve SubscriptionHelperTests unit test by decoupling the test logic from the code and make the test price different for each case (#8089)
GitOrigin-RevId: 4db0f474817651e8d17c35c529d53a5266ca4b1e
2022-05-25 08:10:09 +00:00
Jakob Ackermann
2c62ba29c7 Merge pull request #8094 from overleaf/jpa-handle-missing-output-files
[web] handle missing outputFiles array

GitOrigin-RevId: 9b1210ff620888f45ec1a3b38c9f91b5a3e22778
2022-05-24 08:04:36 +00:00
Jakob Ackermann
716aa174fb Merge pull request #8070 from overleaf/jpa-web-zonal-traffic-test
[web] add split test for rollout of zonal clsi-lb downloads

GitOrigin-RevId: 67fb843ffb0c5902419a4e5c7d2ff9d35cf93470
2022-05-24 08:04:30 +00:00
Jessica Lawshe
fc9bfa84cd Merge pull request #7721 from overleaf/jel-td-notify-commons
Only handle confirmed users via commons script

GitOrigin-RevId: 0d00147943228bff6c435848ff88481c5c184a8a
2022-05-24 08:04:17 +00:00
Alf Eaton
80f6662957 Add option for parsing valid RFC5322 email addresses (#8065)
GitOrigin-RevId: 6af8ae850bd8075e6bf0ebcafd2731177cdf49ad
2022-05-24 08:03:52 +00:00
Christopher Hoskin
51f5f80e2d Merge pull request #7630 from overleaf/csh-issue-7543-rails-v1-run-in-GKE
Run rails-v1 on GKE

GitOrigin-RevId: b8138a40da6279b7df68e3b9e0d308939c843679
2022-05-23 08:04:00 +00:00
M Fahru
dceb6910c9 New plans page: Show initial price value upon first render for group price data (#7974)
* New plans page: Show initial price value upon first render

* fix wrong test on SubscriptionController and add new tests on SubscriptionHelper

GitOrigin-RevId: a339a97cff2df0728ba35885af8953c8a0e0b7c8
2022-05-20 08:03:16 +00:00
Thomas
2d8e832be7 Subscription code decaf cleanup (#7918)
GitOrigin-RevId: 43adff9af7ca347808980823ac641db05129a79b
2022-05-18 08:04:31 +00:00
Jakob Ackermann
f0bd6dda23 Merge pull request #7986 from overleaf/jpa-eslint-8
[misc] upgrade eslint packages to the latest version everywhere

GitOrigin-RevId: f1480d4a171acef82fb26c4aa54be3a6088b0ab3
2022-05-17 08:05:59 +00:00
Eric Mc Sween
e0d91eaa26 Merge pull request #7906 from overleaf/em-downgrade-logs
Downgrade all INFO logs to DEBUG

GitOrigin-RevId: 05ed582ef0721fcada059f0ad158565f50feca27
2022-05-17 08:05:26 +00:00
Alf Eaton
d68180bc4e Merge pull request #7961 from overleaf/jpa-shorter-clsi-persistence
[web] lower clsi persistence duration

GitOrigin-RevId: 72929de084c5c5aac5f2382ad91a7665e96742a8
2022-05-17 08:04:25 +00:00
Timothée Alby
4b87568e4f Merge pull request #7810 from overleaf/ta-settings-intermediate-pages
[SettingsPage] Github and Dropbox Linking Flow Improvements

GitOrigin-RevId: 4fd69e7e3a8989b2478299751582007635f9e0b0
2022-05-17 08:03:29 +00:00
Jakob Ackermann
52073a13a9 Merge pull request #7867 from overleaf/jpa-compile-group
[web] pass compileGroup to clsi-lb

GitOrigin-RevId: c15adbff27e702b3e0f29be5b57f7a9520d8d02f
2022-05-16 08:03:36 +00:00
Alexandre Bourdin
5c00fe09e4 Merge pull request #7806 from overleaf/ab-group-memberships-bigquery
[web] [analytics] Send group memberships information to analytics & import baseline data

GitOrigin-RevId: a15c3131f7b55225ae3949933578475668a195a0
2022-05-12 10:40:30 +00:00
Thomas
ba3d278bd9 Fix subscription check for upgrade prompts in editor (#7799)
* Fix subscription check for upgrade prompts in editor

GitOrigin-RevId: ec6d117748e4017ae189038e56363c4a7366f2b4
2022-04-29 08:03:26 +00:00
Thomas
8472ac6fc6 Add split test for persistent upgrade prompts project dash and editor header (#7590)
* Add Upgrade buttons on project dash and editor header

GitOrigin-RevId: 16325ffb2e63beeaff914e0b95db3faddcdf241a
2022-04-28 08:04:32 +00:00
Eric Mc Sween
a1ff7d8274 Merge pull request #7752 from overleaf/em-promisify-user-updater
Finish promisification of UserUpdater

GitOrigin-RevId: 8f32b2248cfd0db4232bd808f337c17bd7f7dbf4
2022-04-28 08:03:54 +00:00
Timothée Alby
f0ac0f3e7a Merge pull request #7742 from overleaf/ta-email-preferences-page
Create Email Preferences Page

GitOrigin-RevId: 371a62e8423e5cbebff83e61bf35a8b3b638c398
2022-04-28 08:03:12 +00:00
Timothée Alby
f771119cb1 Merge pull request #7712 from overleaf/jpa-email-copy-changes
[web] make copy changes to trial onboarding email

GitOrigin-RevId: 027ba8d471c0cac56dff7c56135d091a96817cf3
2022-04-26 08:04:31 +00:00
Timothée Alby
b289afe23c Merge pull request #7725 from overleaf/ta-settings-fixes
[SettingsPage] Misc Fixes

GitOrigin-RevId: 56f58d2bb5830f7e0584a83c98efc9989ae2bd42
2022-04-26 08:04:18 +00:00
Timothée Alby
cf2dfc6bf1 Merge pull request #7593 from overleaf/ta-settings-migration
[SettingsPage] Integration Branch

GitOrigin-RevId: 5a3c26b2a02d716c4ae3981e3f08b811ae307725
2022-04-25 08:05:12 +00:00
Tim Down
35480a3c7d Merge pull request #7545 from overleaf/td-split-test-data-sentry
Record split-test state in Sentry metadata from web clients

GitOrigin-RevId: 66dd195c546bd9fb0aedac52844200846c5012ca
2022-04-25 08:04:45 +00:00
Tim Down
dc706b4942 Merge pull request #7293 from overleaf/td-email-change-notifications
Send primary email address change notification to latest confirmed addresses

GitOrigin-RevId: ba4aba38a2d8785ee24156449c612ff05cd66fc7
2022-04-15 08:03:10 +00:00
June Kelly
90303f2f8c Merge pull request #7367 from overleaf/tm-add-singapore-currency-mapping
Add Singapore/Singapore Dollar to currency mappings

GitOrigin-RevId: 1ba2cf35435a8a7ce31ac92c9dd0d92a2cf2e4bf
2022-04-14 08:03:07 +00:00
Davinder Singh
b3d55fa65e Move admin register to user activate module
Move admin register to user activate module

Co-authored-by: John Lees-Miller <jdleesmiller@gmail.com> & Davinder Singh
GitOrigin-RevId: 79428f2932783086435bdad9b1efb5300c467511
2022-04-08 08:04:45 +00:00
Eric Mc Sween
c776bf208c Merge pull request #7408 from overleaf/em-malformed-file-tree
Prevent malformed file trees

GitOrigin-RevId: 59104077bed80dd87a7c3813e06581bb6d9bd8d9
2022-04-07 08:04:10 +00:00
Alexandre Bourdin
b28271082c Merge pull request #7246 from overleaf/ab-references-handler-unhandled-error
[web] Fix unhandled error in ReferencesHandler

GitOrigin-RevId: 1b7f2f186780b3ed79434a509ce3dc54e1c38f07
2022-04-07 08:04:03 +00:00
Alexandre Bourdin
997bffc9b1 Merge pull request #7166 from overleaf/ab-decaf-user-info-controller
[web] Decaf cleanup UserInfoController

GitOrigin-RevId: c1bc531ed2923f05652090d792b7f1e7b4c1275c
2022-04-07 08:04:00 +00:00
Jessica Lawshe
ad7b3c89f4 Merge pull request #6840 from overleaf/jel-onboard-non-sso-notify
[web] Include trial users when notifying commons users

GitOrigin-RevId: 439e9b0f55e5a376dc9f621b8ba76468e1e843e0
2022-04-06 08:04:38 +00:00
Jakob Ackermann
4d18dcb377 Merge pull request #7210 from overleaf/jpa-switch-to-admin
[web] add a button for switching to the admin domain from www.

GitOrigin-RevId: 7e14b9c1415ef6cad5f369d77530599bac3148e7
2022-04-05 12:19:00 +00:00
Jakob Ackermann
c8866bbda0 Merge pull request #7094 from overleaf/jpa-redirect-admin-requests
[web] redirect admin users from admin endpoints to the admin domain

GitOrigin-RevId: a4bd7d4f998615efcb46ae9866868af9489c94f5
2022-04-05 12:18:51 +00:00
Jakob Ackermann
c881829e04 Merge pull request #6729 from overleaf/jpa-cleanup-staff-access
[web] admin privilege does not imply staffAccess

GitOrigin-RevId: 89760c7a9a8f0b0c82ebee40ca3236e9894ab9fa
2022-04-05 12:18:33 +00:00
Jakob Ackermann
e82a053c85 Merge pull request #6614 from overleaf/jpa-msm-separate-admin-app
[misc] move admin capability from www. to admin. subdomain

GitOrigin-RevId: e0daeacf3c06b856ffb9fd35dce76e71f14e8459
2022-04-05 12:18:24 +00:00
Jakob Ackermann
64ffd66fa4 Merge pull request #7307 from overleaf/jpa-notify-editor-restore-doc
[web] notify the editor after restoring a deleted doc

GitOrigin-RevId: 4bd316958827c83a56a82f9ff72f5ff803d32631
2022-04-05 12:18:15 +00:00
Alf Eaton
a079aa1fae Merge pull request #7251 from overleaf/jpa-convert-doc-to-file-script
[web] convert convert-to-file endpoint into a script

GitOrigin-RevId: 5babebae5df8510b83f09ec4a2bb4064cca5ec75
2022-04-05 12:17:00 +00:00
Thomas
1aae979398 Send delete request to chat when expiring deleted projects (#6997)
* Send delete request to chat when expiring deleted projects

* Add script to clean-up orphaned chat of previously expired projects

GitOrigin-RevId: 157d100bd51b6204a9e31733b5164b8e7036ef01
2022-03-28 08:04:29 +00:00
Jakob Ackermann
c192002f53 Merge pull request #6837 from overleaf/jpa-drop-v1-subscription-lookup
[web] drop support for v1 subscriptions

GitOrigin-RevId: ddffa60398d5319959f9e5455520a61fa58fab37
2022-03-25 09:03:48 +00:00
June Kelly
4e11fa73cb Merge pull request #7106 from overleaf/ab-analytics-controller-async
Convert AnalyticsController to async/await

GitOrigin-RevId: a38194b2970a15b06fe6a3d95048681d7927bfc3
2022-03-24 14:58:47 +00:00
June Kelly
e536ed1661 Merge pull request #7125 from overleaf/jk-project-rename-strip-ends
[web] Rename project: trim whitespace on ends

GitOrigin-RevId: 2499d9e206ed5c929870a0f50cccd07ce3ec5ba7
2022-03-24 14:58:44 +00:00
June Kelly
b5677742a2 Merge pull request #7062 from overleaf/jk-fix-file-type-detection
[web] Fix file-type detection for `latexmkrc`

GitOrigin-RevId: d51363d2b7d2b1fcc4b783cb3e91f33ab450abba
2022-03-24 14:58:40 +00:00
Timothée Alby
0703c6d21d Merge pull request #7142 from overleaf/ii-6756-gmail-flags-emails-as-dangerous
Change security email title

GitOrigin-RevId: d33c9d7998ada059dac61ba0d13eefedd66237fc
2022-03-24 09:03:38 +00:00
Alf Eaton
9f969d07e0 Delete unused PDF-related code (#6334)
* Remove new logs UI code
* Remove unused preview components
* Move metrics file
* Remove Angular PDF controllers
* Move the service worker util functions
* Remove the ide/pdfng folder
* Remove vendored pdf.js
* Remove showNewPdfPreview
* Use mockCompile
* Remove split test code

GitOrigin-RevId: 723b7440c62cda51f6ad8bb9c691900882166d21
2022-03-16 09:03:04 +00:00
Eric Mc Sween
11a81007f5 Merge pull request #6918 from overleaf/em-v1-timeouts
Reducing timeout for v1 calls for endpoints

GitOrigin-RevId: 0f28569a1401e2fad7434df2a68a230ceb0f4aca
2022-03-08 09:03:42 +00:00
Jakob Ackermann
264b107e39 Merge pull request #6927 from overleaf/jpa-split-clsi-metrics
[misc] split clsi metrics into multiple categories

GitOrigin-RevId: 964ab57b344b92383a2937beff50139bae273a0e
2022-03-02 09:02:52 +00:00
June Kelly
9702346edc Merge pull request #6628 from overleaf/jk-heartbeat-editor-type-metadata
Add editor metadata to editing-session pings

GitOrigin-RevId: f42be772c13f71380d59bae7c447645fe0e16a17
2022-03-02 09:02:34 +00:00
Eric Mc Sween
5ded04eaea Merge pull request #6785 from overleaf/em-split-tests-analytics-enabled
Add "analytics enabled" setting to split tests

GitOrigin-RevId: 9ddfda9e246cac7a13361b2d3df6884212583000
2022-03-01 09:04:15 +00:00
Eric Mc Sween
8e4b85c6f3 Merge pull request #6731 from overleaf/em-logs-ui-split-test
Move new logs UI to a split test

GitOrigin-RevId: 2ebd5afbbda273e7c3092416c64754a56e628b05
2022-02-16 11:38:42 +00:00
Miguel Serrano
1fb8f15005 add segmentation to user-registered event (#6711)
* add segmentation to `user-registered` event

GitOrigin-RevId: 9ba40c0a81aea488439758b992caeb7855c27f67
2022-02-16 11:38:09 +00:00
Eric Mc Sween
46d2b84103 Merge pull request #6727 from overleaf/em-revert-logs-ui-split-test
Revert "Move new logs UI toggle to a split test"

GitOrigin-RevId: 5f2aecb53d2df21c89da594b0a64c8cf8ca04bc6
2022-02-16 11:36:26 +00:00
Eric Mc Sween
4df657db4b Merge pull request #6640 from overleaf/em-alpha-beta-split-tests
Move alpha/beta feature toggles to split tests

GitOrigin-RevId: e64387d9bde2db9c4e96ea7f5992c877ad16b9a9
2022-02-16 11:36:20 +00:00
Thomas
45ac55c7f0 Merge pull request #6559 from overleaf/tm-teardown-onboarding-email-split-test
Implement 'send-email' variant for trial onboarding email for all users

GitOrigin-RevId: f53b86d875a1a4e146dc57603b7a83ac098f9cdf
2022-02-16 11:36:02 +00:00
Timothée Alby
1b4d675b0a Merge pull request #6690 from overleaf/ta-max-dictionary-size
Add Dictionary Size Limit

GitOrigin-RevId: f3b8be11de5a1480c8bc1a7fe26e9d67bd047757
2022-02-16 11:34:58 +00:00
Timothée Alby
c0fae79ad7 Merge pull request #6693 from overleaf/jpa-error-is-manager
[web] refactor error handling for rejected manager removal

GitOrigin-RevId: 48be3bf254de74c2799d1368aee329fd9038dfa6
2022-02-16 11:34:25 +00:00
Jakob Ackermann
ae0c347f27 Merge pull request #6542 from overleaf/jpa-em-code-sharing-workspaces
[misc] npm workspaces

GitOrigin-RevId: 87aa72db6637fb238d7cd35b0a48ac3ed58ab3eb
2022-02-16 11:31:07 +00:00
Jakob Ackermann
42d78528ae Merge pull request #6572 from overleaf/jpa-web-unit-tests-npm-workspaces
[web] adjust unit test setup for npm workspaces

GitOrigin-RevId: 4c6f6debbc082301570173345cc366984a9c59f1
2022-02-16 11:31:03 +00:00
Miguel Serrano
176ead8983 Primary Email Check (#6471)
* added primary-email-check page, route and controllers
* add `#add-email` internal link in settings to display new email form
* added primary-email-check redirection with split test
* update `lastPrimaryEmailCheck` when the default email address is set
* added `lastPrimaryCheck` to admin panel
* translations for primary-email-check
* acceptance tests for primary-email-check
* [web] multi-submit for primary email check
* Using `confirmedAt` to prevent from displaying primary-email-check page

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
Co-Authored-By: Miguel Serrano <mserranom@gmail.com>
GitOrigin-RevId: d8e3a280439da08038a4487d8bfd7b3b0596e3b5
2022-02-04 09:03:34 +00:00
Alexandre Bourdin
215725e0a7 Merge pull request #6569 from overleaf/ab-recurly-webhook-filter
Add a failfast for invalid userId on recurly webhook

GitOrigin-RevId: 94e7c5fd756f5fbc592a9c346fca157883625396
2022-02-03 09:03:23 +00:00
Eric Mc Sween
57228c5589 Merge pull request #6442 from overleaf/em-split-tests-user-admin
Show split test assignments in user admin

GitOrigin-RevId: 4563a4899d5278a0ef84188ae25cb5dfd3d5cb57
2022-01-27 09:04:06 +00:00
Jakob Ackermann
d812b88e76 Merge pull request #6457 from overleaf/jpa-harden-login
[web] harden login process

GitOrigin-RevId: 5c0b7cc725efd5e3e879067ad8a42fe46a47b60d
2022-01-27 09:03:38 +00:00
Jessica Lawshe
6a0da3d204 Merge pull request #6375 from overleaf/jel-reconfirm-check
[web] Use v1 date for reconfirm notification check

GitOrigin-RevId: e14f1b6a1a6ab629628858d962a3757a6078cf79
2022-01-26 09:03:50 +00:00
Jessica Lawshe
7653b46719 Merge pull request #6356 from overleaf/jel-user-admin-panel
[web] v2 admin affiliations tab shows data used for licenses

GitOrigin-RevId: 1038b042a0728b118d3204515ed9f69e35746b18
2022-01-26 09:03:43 +00:00
Jakob Ackermann
cfaec97a3d Merge pull request #6393 from overleaf/ta-backfill-user-properties
Backfill User Properties

GitOrigin-RevId: ea2ffeaaf71d5ce41c76a1bfb2f0014006ef0d08
2022-01-26 09:03:06 +00:00
Jakob Ackermann
b2e18c92a6 Merge pull request #6418 from overleaf/ta-ga-optimize-remove
Cleanup Google Optimize

GitOrigin-RevId: d8cf8008179ad2c355c09f06d947fb2b89cf5a3c
2022-01-26 09:03:02 +00:00
Alexandre Bourdin
4c49edd89b Assignment by id for recurly webhook (#6465)
* Allow split test assignment by ID for recurly webhook

* Small refactoring of assignment logic

* Add tests for getAssignmentForUser

* Cleanup following review comments

* Provide default value for sync option in split test handler

GitOrigin-RevId: 828cad3a1f3a0f3efd25f427d00a3c530ae2f087
2022-01-25 09:04:05 +00:00
Alexandre Bourdin
1b954fa720 Merge pull request #6332 from overleaf/ab-split-test-param-overrides
Split tests query param overrides

GitOrigin-RevId: 8112710d057ddc22cebf37a619dfc969be57b6cc
2022-01-25 09:03:04 +00:00
Tim Alby
bbac46156b convert price_in_unit to price_in_cents
GitOrigin-RevId: bae030e9c90f8286d6e6550744849984fe81f63d
2022-01-21 09:03:29 +00:00
Tim Alby
3e70546e18 rename price attributes to price_in_cents or price_in_unit
GitOrigin-RevId: 8045472c96862078583fcb522099ad78926281dc
2022-01-21 09:03:23 +00:00
Jakob Ackermann
1fc0b3e4aa Merge pull request #6349 from overleaf/jpa-password-strength-checking
[web] data collection for password strength using HaveIBeenPwned api

GitOrigin-RevId: 7e4d57a979c29027fb7ca5294f3935500a0b4cf3
2022-01-20 09:03:07 +00:00
Jakob Ackermann
220daff655 Merge pull request #6384 from overleaf/jpa-fix-proxying-of-json
[web] fix proxying of responses from other services

GitOrigin-RevId: ac1ecc02c06e353f8379fadb47824a46672610e5
2022-01-18 09:03:30 +00:00
Jakob Ackermann
d720d6affa Merge pull request #6317 from overleaf/jpa-send-explicit-content-type
[web] send explicit content type in responses

GitOrigin-RevId: d5aeaba57a7d2fc053fbf5adc2299fb46e435341
2022-01-18 09:03:18 +00:00
Jakob Ackermann
c97e95aeba [web] confirmDomain: skip fetching affiliations per user
Nothing is looking at either
 - `user.emails[i].affiliation` or
 - `user.emails[i].emailHasInstitutionLicence`
So we might as well skip fetching the data.

This eliminates N v1 calls and N mongo calls from the endpoint.

GitOrigin-RevId: bb1d077df19910b9dfb7ef06562cf35ce5302290
2022-01-14 09:03:33 +00:00