Commit graph

2700 commits

Author SHA1 Message Date
David
46198cd780 Merge pull request #20688 from overleaf/dk-fix-wrong-rangesdata
Fix "RangeError" when switching files using new review panel

GitOrigin-RevId: 399c8722584053c62acf5c413572fbbcdd1896cc
2024-10-14 10:59:33 +00:00
David
a331ac6116 Merge pull request #19796 from overleaf/dp-more-comments-2
Add More Comments buttons

GitOrigin-RevId: 3cd6539683cbc53ceb63488ab9e9b0ffe53e079c
2024-10-14 10:59:29 +00:00
David
13545140ee Merge pull request #20681 from overleaf/dp-highlight-height
Add padding to change highlight/focus styles

GitOrigin-RevId: 6543fe6545ff8e7baff23d5262b941a5473be19e
2024-10-14 10:59:25 +00:00
David
df2e3c1119 Merge pull request #20728 from overleaf/dp-state-field-error
Safeguard against addCommentStateField not existing

GitOrigin-RevId: 06f5f72bc12552b9668892a50d9789d6dfc45a9e
2024-10-14 10:59:16 +00:00
Mathias Jakobsen
aba4694377 [web] Move ARS Write and Cite behind separate feature flag (#20631)
* [web] Move ARS Write and Cite behind separate feature flag

* [web] Use isSplitTestEnabled function

* [web] Only load Write and Cite if project has ARS access

* [web] Enable Write and Cite ARS by default

* [web] Fix condition for loading write and cite ref sources

* [web] Remove references settings button in free projects

GitOrigin-RevId: c4f3b7c60da9864409c788dcf34bdc77347441a8
2024-10-14 10:59:11 +00:00
Alf Eaton
7daebe2f42 Store the scroll position of the PDF per root doc (#20376)
GitOrigin-RevId: 561c38b7258df40f0e738fdc2575e23d9d15102a
2024-10-14 10:59:04 +00:00
Alf Eaton
2c6aa3d4a7 Merge pull request #20381 from overleaf/ae-api-settings
Add "settings" object to global scope store

GitOrigin-RevId: 1d5c7c3a1b417be0726c4a5e95e611ded47c13c4
2024-10-14 10:58:59 +00:00
Alf Eaton
24c8629cd4 Use Hunspell for client-side spellchecking (#20286)
GitOrigin-RevId: c4d0d9e06fe0cc9d7cb7a058fd0768eb024e44f5
2024-10-14 10:58:36 +00:00
Jessica Lawshe
50aad92eb9 Merge pull request #20692 from overleaf/ar-limit-length-of-user-editable-fields
[web] limit length of user editable fields

GitOrigin-RevId: 239398dd05dcde7fea0ac8415e41396ef01c2b74
2024-10-14 10:57:56 +00:00
Antoine Clausse
9997c4874f [web] Migrate /user/subscription to BS5 (#20513)
* [web] Initialize BS5 in subscription page

* [web] Update subscription-dashboard.tsx for BS5

* [web] Update row-link.tsx for BS5

* [web] Update modals

* [web] Add `btn` to `btn-inline-link` classes

* [web] Update circle change-to-group circle price element

* [web] Replace `list-item-with-margin-bottom` with `mb-3`

* [web] Update form elements to BS5

* [web] Use `useContactUsModal`

* [web] Adjust tables margin/padding, and more

* [web] Update change-to-group-modal.tsx

* [web] Add gap to subscription buttons

* [web] Remove subscription page colspan for md and above

* [web] Use Notification component

* [web] Update "leave group" buttons

* [web] Fix tests: add `ol-user` meta tag

* [web] Nest .hover-highlight in #subscription-dashboard-root

* [web] Update to OLRow/OLCol

* [web] Update to OLButtons

* [web] Update to OLFormGroup

* [web] Naming: use BSversion prefix

* [web] Set CancelSubscriptionButton as ghost directly in component

* [web] Set "Plan" font size

* [web] Simplify cancel-subscription buttons

* [web] Remove `--neutral-10` ModalFooter background

* [web] Simplify circle styles

* [web] Center discount badge

* [web] Update fieldset label

* [web] Add `<ul>` around RowLink

* [web] Define SCSS for row-link component

* [web] Remove some use of utility classes

* [web] Revert and update `fieldset` changes (fixes tests)

* [web] Fixup some more OLButtons

* [web] Fixup use of OLRow/OLCol

* [web] Reduce spacing below "legend-as-label"

* [web] Use h5 instead of small in OLModalTitle

* [web] Revert OLCol removal on lg screens

I had removed them by mistake because I wasn't using the proper breakpoints

* [web] Add backdrop to nested modal ContactUsModal

* [web] Don't prefill project URL in ContactUsModal

* [web] Fix lint

* [web] Share `className` prop in BS5 and BS3 modals

* [web] Set sub-title font sans serif (BS3)

* [web] Update remaining Alerts to OLNotification

GitOrigin-RevId: 7fd975ae3e992cebfaf71d4e182f8e13ec886d09
2024-10-01 08:05:14 +00:00
Antoine Clausse
d4bf47932e [web] Migrate /subscription/invites/:token to BS5 (#20640)
* [web] Wiring work for `/subscription/invites/:token` BS5 migration

* [web] Add SCSS for .enrollment-invite

* [web] Update invite_logged_out PUG file for BS5

* [web] Update `GroupInviteViews` (and children) to BS5

* [web] Update `InviteManaged` to BS5

* [web] Update Logout button

* [web] Update subtitles

This removes the `text-overflow:ellipsis`. I think it's better without it, because it can be an accessibility issue.

* [web] Add margin on inner-card

* [web] Style action buttons in InviteManaged

* [web] Add missing container around Row

This was causing the row to overflow the body.

Increased the col width to compensate.

* [web] Fixup lint

* [web] Fix `ManagedUserCannotJoin` title in BS3 (!)

I checked all the other `OLNotification`: we don't use `title` anywhere else

* [web] Put title in OLNotification content

See https://github.com/overleaf/internal/pull/20640#discussion_r1777551257

* [web] Use translations for "aria-label="Email address""

* [web] Handle OLButton `isLoading` in `bs3Props`

* [web] Remove duplicated `btn` class

* [web] Add margin-bottom to InviteManaged title and fix logout button CSS in BS3

* [web] Adjust col class in Pug file for BS3 and BS5

* [web] Revert migration to OLNotification

Revert back to `@/shared/components/notification`

* [web] Add note to remove .team-invite-name after BS5 migration

* [web] Set `btn-link-logout` in BS3 only

* [web] Update OLButton so other classNames automatically get passed to the BS3 implementation

* [web] Revert OLButton changes for BS3 classnames

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>

* [web] Update services/web/modules/group-settings/frontend/js/components/invite-managed.tsx

Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>

* [web] Use OLFormGroup `controlId`

---------

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>
Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>
GitOrigin-RevId: 64b3f79c83002a9c9585bfb8e344e80b2e8eac5c
2024-10-01 08:05:09 +00:00
Antoine Clausse
246157cf63 [web] Migrate /subscription/invites to BS5 (#20652)
* [web] Wiring work for `/subscription/invites` BS5 migration

* [web] Migrate group-invites.tsx to BS5

* [web] Migrate group-invites-item.tsx to BS5

GitOrigin-RevId: a12aafce3ad0040dc500f5f29b1a20fbae4a748e
2024-10-01 08:05:04 +00:00
ilkin-overleaf
35728d7681 Merge pull request #20436 from overleaf/ii-bs5-editor-toolbar
[web] BS5 editor toolbar

GitOrigin-RevId: a517fd52d648d165e89231d6f5551c026a951c43
2024-10-01 08:04:42 +00:00
Eric Mc Sween
918d0f24eb Merge pull request #20547 from overleaf/em-assist-plan
Add a button for buying standalone Overleaf Assist

GitOrigin-RevId: 50baea48ea990eba38ef564b71a79a76bbd45dfc
2024-09-30 08:04:52 +00:00
Alf Eaton
c6633632d6 Move CodeMirror contexts into a separate file (#20643)
GitOrigin-RevId: 8425454a75ff8160a03fda1be5bda2242b41f6cd
2024-09-30 08:04:48 +00:00
David
dae40941ee Merge pull request #20638 from overleaf/dk-review-subview-mini
Always use current file sub view when review panel is collapsed

GitOrigin-RevId: 536476a11a9e54c79c2fe930d74639c6e676870e
2024-09-27 08:04:47 +00:00
David
06e24c9081 Merge pull request #20606 from overleaf/dk-add-comment-on-mouseup
show Add comment button on mouse up event

GitOrigin-RevId: 2c87f11fab9f9fb7e11637bb9eac2ca1ab9b298b
2024-09-27 08:04:39 +00:00
David
2801b3baad Merge pull request #20583 from overleaf/dk-review-gotoposition
Goto position when clicking on review entry in Overview tab

GitOrigin-RevId: 17c9cefed339537afa994778ffbc01cfb294bf46
2024-09-27 08:04:34 +00:00
David
2a051700b5 Merge pull request #20586 from overleaf/dp-resoled-comments-tooltip
Add tooltips for resolved comments toggle and reopen/delete thread buttons

GitOrigin-RevId: 6e043d0ca83418f4362ec1b49994c4ceed24742b
2024-09-27 08:04:26 +00:00
Rebeka Dekany
ac74ba9e8c Merge pull request #20501 from overleaf/rd-filetree-toolbar
Migrate the file tree toolbar to Bootstrap 5

GitOrigin-RevId: 00ebe585206bf163bf9a00aa56b52d43effd5605
2024-09-26 08:05:47 +00:00
Rebeka Dekany
abb59e4603 Merge pull request #20298 from overleaf/rd-ide-filetree
[web] Migrate the file tree on the editor page to Bootstrap 5

GitOrigin-RevId: e2efec26242c8cdab37a54bc182b83bfb0f1eb3c
2024-09-26 08:05:43 +00:00
Alf Eaton
6f8a9a0f81 [visual] Improve cursor position in empty list items (#20611)
GitOrigin-RevId: 08a83b509e217573f680ca4a635d9480ade9b1ae
2024-09-26 08:05:32 +00:00
Alf Eaton
53e46632a9 Improve editor focus events (#20263)
GitOrigin-RevId: 710f42eb633289b43858b8f283735ed0aced5c0b
2024-09-26 08:05:25 +00:00
Alf Eaton
ca72351c8e Improve detection of pasted Excel table in Safari (#20374)
GitOrigin-RevId: 92b9c485b57f753f4fe161e582817f72244436e1
2024-09-26 08:05:21 +00:00
Alf Eaton
77ad90d59a Refactor to texOrPdfString function
GitOrigin-RevId: b084966a4fc13de4708973685844b2d9d2405e9b
2024-09-26 08:05:13 +00:00
Copybot
2a2bb3f064 Merge pull request #1245 from AnessZurba:tex-or-pdf
GitOrigin-RevId: 096f7e5bb581c3984db8dc74e7a4c525de862cce
2024-09-26 08:05:08 +00:00
Antoine Clausse
44103dd6a5 [web] Migrate /user/subscription/canceled to BS5 (#20590)
* [web] Initialize BS5 in subscription page

* [web] Backend wiring for `/user/subscription/canceled` to BS5

* [web] Backend `Canceled` to BS5

GitOrigin-RevId: 660458145c06e0d2dd1343186d31b6a7662b01a0
2024-09-26 08:05:04 +00:00
Antoine Clausse
6b4c483269 [web] Migrate /user/subscription/thank-you to BS5 (#20588)
* [web] Initialize BS5 in subscription page

* [web] Backend wiring for `user/subscription/thank-you` to BS5

* [web] Update `SuccessfulSubscription` to BS5

GitOrigin-RevId: 45162664c116eb04b73e16443c84fa24ea8b220c
2024-09-26 08:04:59 +00:00
Antoine Clausse
d480faf60b [web] Make the welcome page cards all have the same widths (implementation 2) (#20570)
* welcome page adjusted columns in BS5

* [web] Fix card color

* [web] Fixup card width in BS3

* [web] Fix lint

* [web] Fix cards text color in BS3

* [web] Fix cards positioning in BS3

* [web] Prevent cards from becoming too large on big screens

---------

Co-authored-by: Ilkin Ismailov <ilkin.ismailov@overleaf.com>
GitOrigin-RevId: 9b91c073a62dae7cad4402908a34f9880ecdb0ac
2024-09-26 08:04:55 +00:00
Thomas
5ebeab3d42 Merge pull request #20514 from overleaf/tm-pending-editor-sorting
Sort members in share modal list by editors > pending > viewers

GitOrigin-RevId: 7e2e3acb69ffaddbddc7bacfe3258e149c717aeb
2024-09-26 08:04:30 +00:00
Mathias Jakobsen
267109aa9a Merge pull request #20519 from overleaf/mj-write-and-cite-settings
[web] Add a settings menu for Write & Cite

GitOrigin-RevId: 670d8db8fa1363308a6d4d35f3717a886fb24c49
2024-09-25 08:06:34 +00:00
Davinder Singh
248fc3699a CMS Bootstrap 5 migration - Tabs using bootstrap 5 classes (#20478)
* adding classes according to bootstrap 5 tabs

* adding JS for tabs handeling in BS5

* adding styling for tabs to match the redesign styling

* making sure tabs are being highlighted when active

* adding a scroll-margin-top to have some extra space

* removing extra import, it is not needed here because we already import it in bootstrap-x.js files

* using the media-breakpoint-down for a media query styling

* introducing .nav-tabs-container to make the tab triggers horizontally scrollable

* creating a mixin box-shadow-button-input under scss for bootstrap-5

* moving border-width-base to tabs.scss

* aligning tabs to the left under screen size of 768px

* removing focus-style mixin from scss files becuase it was a duplicate

GitOrigin-RevId: 45780c62681fc9b61961f5436d2d55de66a976b6
2024-09-25 08:05:21 +00:00
David
7002d1e4bf Merge pull request #20511 from overleaf/dp-review-panel-footer
Update UI for new review panel footer

GitOrigin-RevId: 8beb554f78fa5876d5349981d96b44a16ab5567c
2024-09-25 08:05:07 +00:00
David
ab43a44b76 Merge pull request #20526 from overleaf/dp-mini-review-panel
Styling updates for mini review panel

GitOrigin-RevId: 1bbf7f1d2e02f5d6f3f50937d2b7b9cdc5a0878f
2024-09-25 08:05:02 +00:00
David
9d3841a46d Merge pull request #20517 from overleaf/dp-overview-edit-actions
Don't allow tracked changes to be edited in the overview tab in new review panel

GitOrigin-RevId: 132771c4105096034bf58bc3d4a7ba23c3d088b7
2024-09-25 08:04:57 +00:00
andrew rumble
3fa35ef03a Share ignore logic between web and clsi
GitOrigin-RevId: c4ae306413efb71989d2db410c3859cb69b3d5de
2024-09-24 08:05:01 +00:00
Eric Mc Sween
250acbf33c Merge pull request #20520 from overleaf/em-ts-import
Use new import JSDoc syntax for Typescript annotations

GitOrigin-RevId: 782456d637fc8f2de6163b5d70fabf06c1d74964
2024-09-23 08:04:47 +00:00
David
af6ffdcf7c Merge pull request #20409 from overleaf/dk-selectLineOnFocus-fix
Fix scroll issue when focusing a change in new review panel

GitOrigin-RevId: 55784de415f65935ad9b1a8cd3ad82ea3ddac3c1
2024-09-20 08:05:17 +00:00
David
22e4c2de2c Merge pull request #20411 from overleaf/dk-highlight-focus-ranges
Highlight and focus ranges in editor for new review panel

GitOrigin-RevId: 4fef31a8c9e6dc974519d925c7478665e0c8cc29
2024-09-20 08:05:13 +00:00
David
8a0bed71e1 Merge pull request #20475 from overleaf/dk-fix-positionItems
Change focused item index to be per docId in new review panel

GitOrigin-RevId: af4b91cdc7128302a75f25d11c2afc5a2861abdd
2024-09-20 08:05:08 +00:00
David
8685d87920 Merge pull request #20494 from overleaf/dp-zero-message-thread
Don't show comment threads with zero messages

GitOrigin-RevId: e9efdf4fc1119b8fdafdd8a93c7cd9caed91a276
2024-09-20 08:05:03 +00:00
David
08a6caab80 Merge pull request #20405 from overleaf/dp-fix-empty-state-position
Fix positioning of review panel empty state

GitOrigin-RevId: d1c93e1a8bef59ad68e9f3e62106a949b7f9efdd
2024-09-20 08:04:57 +00:00
Mathias Jakobsen
edf2c68c51 Merge pull request #20326 from overleaf/mj-filetree-restore-importtime
[web] Use importedAt timestamp for linked files if present

GitOrigin-RevId: 2132dfede83778a018e02fdba3d40180838f37af
2024-09-19 08:04:38 +00:00
Jimmy Domagala-Tang
5b73f08703 Merge pull request #20435 from overleaf/jdt-hide-wf-promo-from-wf-commons
Hide Writefull Promo From Writefull Commons Users

GitOrigin-RevId: 7adcb8f6e71c9c5b27da248e025b14a51fab703b
2024-09-18 08:05:00 +00:00
Mathias Jakobsen
a807a810e6 Merge pull request #20297 from overleaf/mj-stream-bib-log
[web] Stream .blg files before parsing

GitOrigin-RevId: 2e7a16a19e62fc32bbcb7fe35bed745b938e6963
2024-09-18 08:04:51 +00:00
Jimmy Domagala-Tang
d41e069c69 Merge pull request #20404 from overleaf/revert-20389-jdt-add-writefull-commons-to-v1
Revert "Add writefull commons to v1"

GitOrigin-RevId: 703e2873cb64059f6a3881d6fc7f3c475caf5abd
2024-09-17 08:05:41 +00:00
Jimmy Domagala-Tang
aca9466c49 Merge pull request #20389 from overleaf/jdt-add-writefull-commons-to-v1
Add writefull commons to v1

GitOrigin-RevId: 36d1022f41b4db3701c6b8fa2120b035b05b38ba
2024-09-17 08:05:37 +00:00
Jimmy Domagala-Tang
e039d020a3 Merge pull request #20202 from overleaf/jdt-labs-widget-button-markup
fixing button style for labs widgets

GitOrigin-RevId: d2e8ce9b1efe1bfc0c5a021470b38107d5f1b6b8
2024-09-17 08:05:32 +00:00
David
a323f3af75 Implement a floating "Add comment" button for the redesigned review panel (#19891)
* Implement floating Add comment button

* Fix comment typo

* Remove unused imports

* Make tooltip always appear above cursor

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

* Refactor how new comment form is positioned

* Add missing file

* Create new map when rendering positions

* Use codemirror state to manage ranges and allow for mutliple in-progress comments

* Memoise sorting

* Create new ranges map each time it is changed

* Add back mutation observer

* Only allow single tooltip

* Fix typo

* Convert state field to store a single tooltip

* Make add comment tooltip content a react component

* Refactor to remove usages of !important

* Use RangeSet to keep track of new comment ranges

* Fix logic broken in rebase

* Map ranges through document changes

* Add decorations for in-progress comments

* Use set-review-panel-open rather than an editor event to open review panel

* Implement new designs for add comment form

* Add padding to textarea

* Fix bug where comment was being submitted for incorrect range

* Add missing key to ReviewPanelAddComment

* Store new comment ranges as a DecorationSet

* Small refactor to how ReviewPanelAddCommens are rendered

* Make op prop to ReviewPanelEntry required

* Add handling for disabling of add comemnt form buttons

* Move viewer check inside AddCommentTooltip

* Ensure that add comment button doesn't reshow when collaborators edit the document

* Remove unneeded op check in ReviewPanelEntry

* Update services/web/frontend/js/features/review-panel-new/components/review-panel-add-comment.tsx

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 3110845f6a557310f3bf72014689e2f2ab53e966
2024-09-17 08:04:58 +00:00
David
9cf94e57d3 Include \def, \let, \newenvironment and \renewenvironment commands in the math preview (#20197)
* Include \def commands in command definitions

* Allow command name to be in CtrlSym

* Pull nodeIntersectsChange check out of branches

* Fix \def handling

* Add handling for \newenvironment and \renewenvironment

* Allow \def to have optional arguments

* :x
Revert "Add handling for \newenvironment and \renewenvironment"

This reverts commit a70d3a0a13ed552daf3b761893e3f8609f0b0fc8.

* Add let commands to defintions

* Add environment names to math preview

* Ignore let command definitions in autocomplete

* Move nodeIntersectsChange check back into each block

* Add childOfNodeWithType utility and use to get command names

* commandNameText -> commandName

* Only include environment definitions

* Rename documentEnvironmentNames to documentEnvironments

* EnvironmentName -> Environment

* Format

GitOrigin-RevId: 9c5d701423ae786e5ff91960b4bcd94cd35d21c8
2024-09-17 08:04:53 +00:00