Commit graph

6187 commits

Author SHA1 Message Date
Thomas
45ac55c7f0 Merge pull request #6559 from overleaf/tm-teardown-onboarding-email-split-test
Implement 'send-email' variant for trial onboarding email for all users

GitOrigin-RevId: f53b86d875a1a4e146dc57603b7a83ac098f9cdf
2022-02-16 11:36:02 +00:00
Thomas
1c5949f715 Merge pull request #6595 from overleaf/tm-avoid-logging-tokens
Clean up log lines that include tokens

GitOrigin-RevId: 3b6acc9cdda4a91b9b10ce85a0650ccdeeea79a4
2022-02-16 11:35:51 +00:00
Alexandre Bourdin
3b9da1d57e Merge pull request #6587 from overleaf/ab-split-test-create-edit
Split tests admin - create/edit

GitOrigin-RevId: a256bf6fe8350214b1ef01ff5e6fa68a812a59be
2022-02-16 11:35:39 +00:00
Timothée Alby
1b4d675b0a Merge pull request #6690 from overleaf/ta-max-dictionary-size
Add Dictionary Size Limit

GitOrigin-RevId: f3b8be11de5a1480c8bc1a7fe26e9d67bd047757
2022-02-16 11:34:58 +00:00
Timothée Alby
0a27b3711f Merge pull request #6599 from overleaf/ta-new-subscription-split-test
Payment Page Split Test

GitOrigin-RevId: bb43cbf4e5722bd18076f2f8bf1014816bce1df0
2022-02-16 11:34:44 +00:00
Timothée Alby
21c92a045d Merge pull request #6672 from overleaf/ta-router-apply-signature-fix
Use Correct Router Apply Function Signature

GitOrigin-RevId: 567ff9a4c59834ae200bba860e265abe2e0173e5
2022-02-16 11:34:37 +00:00
Timothée Alby
c0fae79ad7 Merge pull request #6693 from overleaf/jpa-error-is-manager
[web] refactor error handling for rejected manager removal

GitOrigin-RevId: 48be3bf254de74c2799d1368aee329fd9038dfa6
2022-02-16 11:34:25 +00:00
Timothée Alby
62b662f07a Merge pull request #6561 from overleaf/tm-subscription-cancel-button-split-test
Update copy for subscription cancellation, in split test variant

GitOrigin-RevId: ab5847238b950099bf41b9d4c08f325ffce1051d
2022-02-16 11:34:08 +00:00
Jakob Ackermann
4bdcd520de Merge pull request #6604 from overleaf/msm-jpa-add-go-to-settings-email-confirmation
Added "go to settings" button in email confirmation page

GitOrigin-RevId: 4449f05e9934fdb09ca07804171881b04f3e8bdb
2022-02-16 11:33:34 +00:00
Jakob Ackermann
ae0c347f27 Merge pull request #6542 from overleaf/jpa-em-code-sharing-workspaces
[misc] npm workspaces

GitOrigin-RevId: 87aa72db6637fb238d7cd35b0a48ac3ed58ab3eb
2022-02-16 11:31:07 +00:00
Brian Gough
f92e44a261 Merge pull request #6596 from overleaf/bg-initial-cm6-split-test
[web] initial split test for cm6 source editor

GitOrigin-RevId: 05d0f9db8abcd93ea66326378854b23f27dc9d73
2022-02-04 09:04:09 +00:00
Alexandre Bourdin
6ce0df3106 Merge pull request #6597 from overleaf/ab-send-events-ga4
Send some events to GA4

GitOrigin-RevId: 7927cea14e6717aea033faa3d5f3e0f9efd6e672
2022-02-04 09:03:49 +00:00
Miguel Serrano
176ead8983 Primary Email Check (#6471)
* added primary-email-check page, route and controllers
* add `#add-email` internal link in settings to display new email form
* added primary-email-check redirection with split test
* update `lastPrimaryEmailCheck` when the default email address is set
* added `lastPrimaryCheck` to admin panel
* translations for primary-email-check
* acceptance tests for primary-email-check
* [web] multi-submit for primary email check
* Using `confirmedAt` to prevent from displaying primary-email-check page

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
Co-Authored-By: Miguel Serrano <mserranom@gmail.com>
GitOrigin-RevId: d8e3a280439da08038a4487d8bfd7b3b0596e3b5
2022-02-04 09:03:34 +00:00
Miguel Serrano
0f7948cfdf Highlight SSO in register/login/home pages (#6396)
* Highlight SSO in register and login pages
* Highlight SSO in home page
* updated split test request to new APIs
* reordered SSO buttons when highlighting SSO in login
* Updated copy for institutional login and fixed indentation
* increased SSO button size in homepage for highlight-sso variant
* prefill email in registration page
* added `register` and `register-success` events

GitOrigin-RevId: 2822afc15c27856ca713002ed804e1f42a2d955c
2022-02-03 09:04:45 +00:00
Alexandre Bourdin
215725e0a7 Merge pull request #6569 from overleaf/ab-recurly-webhook-filter
Add a failfast for invalid userId on recurly webhook

GitOrigin-RevId: 94e7c5fd756f5fbc592a9c346fca157883625396
2022-02-03 09:03:23 +00:00
Thomas
347649ebaa Merge pull request #6570 from overleaf/revert-6352-tm-dropbox-webhook-signature-verification
Revert "Add dropbox webhook signature verification and decaf cleanup"

GitOrigin-RevId: eb1fab093d7979a010700f0bc3e1e696f3cba6ae
2022-02-02 09:03:18 +00:00
Thomas
bbb97bed26 Merge pull request #6558 from overleaf/tm-wfh2021-ended
Remove notifications for WFH2021 offer, revert side-bar to old Upgrade notice

GitOrigin-RevId: d5f0bb34b40605a335d48b1d2db54df8fab9224a
2022-02-02 09:03:14 +00:00
Thomas
635a478f36 Add plans page split test variant with new layout (#6450)
* Add plans page split test variant with new layout

* Set itm_content to toggle if group modal clicked through via variant view toggle button

* Change split test name to be more specific

GitOrigin-RevId: 0fa48b1b74eea84f15e630e3a62b36be5549da9e
2022-02-02 09:03:11 +00:00
Thomas
1777c075ea Merge pull request #6423 from overleaf/tm-plans-new-events
Add new analytics events to plans page/subscription flow

GitOrigin-RevId: 7b70ee30749ebc671cf2445f3cbdae91a7278b01
2022-02-02 09:03:07 +00:00
Thomas
7a445eb489 Add dropbox webhook signature verification and decaf cleanup (#6352)
* Decaf: move functions to top level, removing unused vars

* Decaf: fix camelcase identifiers

* Decaf: remove unnecessary code created because of implicit returns

* Decaf: remove next() fallback callbacks

* Decaf: shorten null checks, remove decaf/eslint comments

* Add signature verification for Dropbox webhook

* Add overleaf dropbox app secret to web (staging+prod)

* Add simple acceptance test for dropbox webhook events processing

* Add method for modules to register app middleware prior to bodyParser call, move rawBody middleware to Dropbox module

GitOrigin-RevId: 736f489e2eb5906f7b202c1049c4ce143deea74e
2022-02-02 09:03:03 +00:00
Alexandre Bourdin
931c53d04c Split Tests Admin UI - test list (#6411)
* Admin page to list split tests

Admin page to list split tests

Update split test model

Display optional split test fields + Only display link in admin menu in SaaS mode

Add a separate endpoint to update split test info (to avoid creating a new version)

Fix split test tests after rebase

Add name and activeOnly filtering to split test list

Sort split tests by descending order of last modification

Fix lint build error

Add buttons to copy variant assignment as query string

* Move react components to follow our file structure guidelines

* Cleanup and improvements from review

* Small change of report URLs display

* Improve filters display for small screens

GitOrigin-RevId: 498531a1f080419de017883e33d6afed05a3f5c9
2022-01-31 09:03:42 +00:00
June Kelly
542207b6f9 Merge pull request #6488 from overleaf/ta-survey-future-remove
Remove Product Survey 2021

GitOrigin-RevId: 3db6686a951d192ef86c58ac99e8b3e40947c5b2
2022-01-28 09:03:28 +00:00
Eric Mc Sween
57228c5589 Merge pull request #6442 from overleaf/em-split-tests-user-admin
Show split test assignments in user admin

GitOrigin-RevId: 4563a4899d5278a0ef84188ae25cb5dfd3d5cb57
2022-01-27 09:04:06 +00:00
Jakob Ackermann
d812b88e76 Merge pull request #6457 from overleaf/jpa-harden-login
[web] harden login process

GitOrigin-RevId: 5c0b7cc725efd5e3e879067ad8a42fe46a47b60d
2022-01-27 09:03:38 +00:00
Jakob Ackermann
8e77ada424 Merge pull request #6417 from overleaf/jpa-device-history
[web] add cookie/JWE based device history for skipping captcha challenge

GitOrigin-RevId: b091564bfd93f7e587d396c860fd864f220f4b63
2022-01-27 09:03:34 +00:00
Jessica Lawshe
6a0da3d204 Merge pull request #6375 from overleaf/jel-reconfirm-check
[web] Use v1 date for reconfirm notification check

GitOrigin-RevId: e14f1b6a1a6ab629628858d962a3757a6078cf79
2022-01-26 09:03:50 +00:00
Jessica Lawshe
7653b46719 Merge pull request #6356 from overleaf/jel-user-admin-panel
[web] v2 admin affiliations tab shows data used for licenses

GitOrigin-RevId: 1038b042a0728b118d3204515ed9f69e35746b18
2022-01-26 09:03:43 +00:00
Jakob Ackermann
cfaec97a3d Merge pull request #6393 from overleaf/ta-backfill-user-properties
Backfill User Properties

GitOrigin-RevId: ea2ffeaaf71d5ce41c76a1bfb2f0014006ef0d08
2022-01-26 09:03:06 +00:00
Jakob Ackermann
b2e18c92a6 Merge pull request #6418 from overleaf/ta-ga-optimize-remove
Cleanup Google Optimize

GitOrigin-RevId: d8cf8008179ad2c355c09f06d947fb2b89cf5a3c
2022-01-26 09:03:02 +00:00
Jakob Ackermann
a13dee04c6 Merge pull request #6424 from overleaf/jpa-multi-submit-async-form
[web] add support for async-form inside a multi-submit page

GitOrigin-RevId: 801363aeacc6c10411aceaf2c09a5e4b3b90fcf7
2022-01-26 09:02:55 +00:00
Alexandre Bourdin
4c49edd89b Assignment by id for recurly webhook (#6465)
* Allow split test assignment by ID for recurly webhook

* Small refactoring of assignment logic

* Add tests for getAssignmentForUser

* Cleanup following review comments

* Provide default value for sync option in split test handler

GitOrigin-RevId: 828cad3a1f3a0f3efd25f427d00a3c530ae2f087
2022-01-25 09:04:05 +00:00
Alexandre Bourdin
1b954fa720 Merge pull request #6332 from overleaf/ab-split-test-param-overrides
Split tests query param overrides

GitOrigin-RevId: 8112710d057ddc22cebf37a619dfc969be57b6cc
2022-01-25 09:03:04 +00:00
Tim Alby
bbac46156b convert price_in_unit to price_in_cents
GitOrigin-RevId: bae030e9c90f8286d6e6550744849984fe81f63d
2022-01-21 09:03:29 +00:00
Tim Alby
3e70546e18 rename price attributes to price_in_cents or price_in_unit
GitOrigin-RevId: 8045472c96862078583fcb522099ad78926281dc
2022-01-21 09:03:23 +00:00
Tim Alby
3dbd913d97 disambiguate between displayPrice and recurlyPrice
GitOrigin-RevId: 38f4c51b9834c417824c0093096767f50e998cb8
2022-01-21 09:03:16 +00:00
Eric Mc Sween
fd60549482 Merge pull request #6386 from overleaf/em-promisify
Promisify UserAdminController

GitOrigin-RevId: 51bf4ddd0673409006658fb0d8cc60a8b4e1071d
2022-01-20 09:04:15 +00:00
Eric Mc Sween
7446523205 Merge pull request #6358 from overleaf/jel-fix-de-ng-link
[web] Fix modal link in plans FAQ

GitOrigin-RevId: 29137e71f5f0930443660086fb3a1cc3d87b05dd
2022-01-20 09:04:09 +00:00
Alf Eaton
ee00ff3c44 [web] Add the meta[viewport] tag to all pages (#6301)
* Always add the meta[viewport] tag
* Set metadata.viewport to false on projects list page
* Remove setting metadata.viewport = true
* Add viewport: false to editor page

GitOrigin-RevId: 6f9d4c1972e3e6fdf1b6c23cd17d57ba866fcaeb
2022-01-20 09:03:48 +00:00
Alf Eaton
d1e210319b Merge pull request #6389 from overleaf/ae-github-capitalisation
Fix "GitHub" capitalisation

GitOrigin-RevId: 9b47d58a3d92c8dd695ca1c8f3d28ea7d6178da5
2022-01-20 09:03:38 +00:00
Jakob Ackermann
1fc0b3e4aa Merge pull request #6349 from overleaf/jpa-password-strength-checking
[web] data collection for password strength using HaveIBeenPwned api

GitOrigin-RevId: 7e4d57a979c29027fb7ca5294f3935500a0b4cf3
2022-01-20 09:03:07 +00:00
Jakob Ackermann
220daff655 Merge pull request #6384 from overleaf/jpa-fix-proxying-of-json
[web] fix proxying of responses from other services

GitOrigin-RevId: ac1ecc02c06e353f8379fadb47824a46672610e5
2022-01-18 09:03:30 +00:00
Jakob Ackermann
d720d6affa Merge pull request #6317 from overleaf/jpa-send-explicit-content-type
[web] send explicit content type in responses

GitOrigin-RevId: d5aeaba57a7d2fc053fbf5adc2299fb46e435341
2022-01-18 09:03:18 +00:00
Jakob Ackermann
c97e95aeba [web] confirmDomain: skip fetching affiliations per user
Nothing is looking at either
 - `user.emails[i].affiliation` or
 - `user.emails[i].emailHasInstitutionLicence`
So we might as well skip fetching the data.

This eliminates N v1 calls and N mongo calls from the endpoint.

GitOrigin-RevId: bb1d077df19910b9dfb7ef06562cf35ce5302290
2022-01-14 09:03:33 +00:00
June Kelly
c72ec548bb Merge pull request #5976 from overleaf/jk-login-audit-log-type
[web] Add 'method' info to login audit log

GitOrigin-RevId: 093fe885bc1b688aebd640d6762f031c752191d4
2022-01-14 09:02:28 +00:00
Jessica Lawshe
e8a4a88e87 Merge pull request #6238 from overleaf/jel-script-remove-email
[web] Script to remove email

GitOrigin-RevId: c8f1a69259904b08ef39181b8b7e9c3150ea59f0
2022-01-13 09:04:22 +00:00
Jessica Lawshe
1122a83b60 Merge pull request #6254 from overleaf/jel-saml-entitlement
[web] Always update entitlement in v1 after SAML callback

GitOrigin-RevId: 2569d6d8e6142786ad2875c62c9cd4568837654a
2022-01-13 09:04:16 +00:00
Thomas
4792208ed2 Merge pull request #6329 from overleaf/tm-wfh2021-ending-soon
Update WFH offer notification text with offer end date

GitOrigin-RevId: f50b7f7f1b0c04ce20bd4ea45af6d8684f91fc2b
2022-01-13 09:03:52 +00:00
June Kelly
5acaff1ed2 Merge pull request #6259 from overleaf/jpa-cleanup-self
[web] ExportsHandler: replace usage of self with ExportsHandler

GitOrigin-RevId: aa895f955248bf791008afc0d3dfbd61be75f154
2022-01-13 09:03:46 +00:00
June Kelly
b5625fe3df Merge pull request #6227 from overleaf/jpa-de-dupe-feature-refresh
[web] when confirming institution domain, refresh features once per user

GitOrigin-RevId: 3855441848cf0b140a6cf0264b887d8eca7db5ad
2022-01-13 09:03:33 +00:00
June Kelly
02bb2f1c5a Merge pull request #6181 from overleaf/jk-fix-sub-handler-xml-exception
[web] Catch XML errors in RecurlyWrapper

GitOrigin-RevId: bc20146b67e0ceac76f21b5d28ea2b36e2e97f0d
2022-01-13 09:03:23 +00:00