Commit graph

20021 commits

Author SHA1 Message Date
Brian Gough
bdebef91eb Merge branch 'master' into bg-add-compile-groups 2020-06-17 11:58:26 +01:00
Jakob Ackermann
5f7841526f [misc] RoomManager: emitOnCompletion: properly handle Promise rejections
```
result = Promise.all([<Promise that rejects eventually>]) # rejection 1
result.then () -> RoomEvents.emit(eventName)              # rejection 2
result.catch (err) -> RoomEvents.emit(eventName, err)     # handle r1
```
As shown above, the second rejection remains unhandled. The fix is to
 chain the `.catch()` onto the `.then()` Promise.
2020-06-17 09:29:12 +01:00
Jessica Lawshe
9c9993684c Merge pull request #2911 from overleaf/jel-rename-containers
Update migration script for web container name change

GitOrigin-RevId: e3cefe58f571ab4adf8d7e2b28d19148f394cc83
2020-06-17 02:10:42 +00:00
Jessica Lawshe
9c2a6fc371 Merge pull request #2907 from overleaf/jel-events-on-optimize-pages
Send Google Analytics event for Optimize pages

GitOrigin-RevId: b43b0a1fa1565b5a75384e7c3335ed5595e3253f
2020-06-17 02:10:36 +00:00
Jessica Lawshe
a64f9304ab Merge pull request #2903 from overleaf/jel-cards-list-location
Include plans cards list location in itm_content

GitOrigin-RevId: 6919349a7812891e986dbe41af728169c5a36a0a
2020-06-17 02:10:30 +00:00
Ersun Warncke
087919a5f8 add saml cache provider
GitOrigin-RevId: ad9f3e81da37bd932822f13db441ce8afc342eea
2020-06-17 02:10:21 +00:00
Brian Gough
f6fddf2944 Merge pull request #179 from overleaf/bg-fix-synctex-error
fix synctex error
2020-06-16 08:57:54 +01:00
Brian Gough
8b4869a00c Merge pull request #178 from overleaf/bg-use-lodash
migrate from underscore to lodash
2020-06-16 08:57:14 +01:00
Brian Gough
2eb4327256 fix format 2020-06-16 08:45:53 +01:00
Brian Gough
f41b4daca2 Merge branch 'master' into bg-use-lodash 2020-06-16 08:35:17 +01:00
Brian Gough
634fad8c6e Merge pull request #176 from overleaf/ta-epipe-retry-revert
Remove Retries in EPIPE Errors
2020-06-16 08:33:30 +01:00
Jakob Ackermann
1eadf38761 [misc] work around context assignments by i18n that leak across requests
Somewhere in i18next there is an assignment `ctx.lng=someLang` that
 leaks across requests that share the same `ctx` object for calls like
 `req.i18n.translate('locale', ctx)`.

This somewhere is likely here:
6cc8917ed5/src/i18next.translate.js (L338)

GitOrigin-RevId: b05f62fa59a6ffa59724108fbcc68cc7a67cfd8f
2020-06-16 02:10:44 +00:00
Brian Gough
85f4f348dd add default settings to remove wordcount and synctex containers 2020-06-15 15:49:38 +01:00
Brian Gough
2ce03f0554 add initial compileGroup support 2020-06-15 15:28:53 +01:00
Alasdair Smith
3cc72d349c Merge pull request #34 from overleaf/lint-format
Lint & Format
2020-06-15 11:58:55 +01:00
Brian Gough
0914908676 downgrade NotFoundError log-level 2020-06-15 11:06:54 +01:00
Brian Gough
262ea01911 add acceptance test for synctex when project/file does not exist 2020-06-15 10:55:01 +01:00
Chrystal Maria Griffiths
393d7e948d Merge pull request #21 from overleaf/lint-format
Lint & Format
2020-06-15 10:13:08 +01:00
Brian Gough
ede70b6f99 migrate from underscore to lodash 2020-06-15 09:52:21 +01:00
Brian Gough
a078a34e75 Merge pull request #2902 from overleaf/bg-handle-clsi-503
handle 503 unavailable from clsi with retry

GitOrigin-RevId: 2b90aadbe93af5007a5a64ff3d2330b2fffbf56f
2020-06-13 02:11:10 +00:00
Brian Gough
a9fd2de493 Merge pull request #2906 from overleaf/bg-fallback-for-unknown-compile-response
fallback to error case on unknown compile response

GitOrigin-RevId: 30d2d7e282dceaa6291cf9701c024890081898a7
2020-06-13 02:11:04 +00:00
Brian Gough
516f0d04f4 Merge pull request #2905 from overleaf/bg-add-compile-status-metric
add metrics for compile status and errors

GitOrigin-RevId: 37d2257818430086d257e8764a979f416dab033a
2020-06-13 02:10:59 +00:00
Brian Gough
f99023320d use json parsing in request 2020-06-12 15:15:51 +01:00
Brian Gough
5368630754 check output file exists before running synctex 2020-06-12 15:15:27 +01:00
Brian Gough
8fadf9b241 Merge pull request #175 from overleaf/bg-503-on-unavailable
send 503 unavailable response on EPIPE
2020-06-12 09:29:04 +01:00
Brian Gough
69b7ecfd2e Merge pull request #177 from overleaf/bg-add-docker-setting
add missing setting for optimiseInDocker
2020-06-12 09:28:31 +01:00
Brian Gough
603d9fdead Merge pull request #174 from overleaf/bg-error-on-missing-profile
error on missing profile
2020-06-12 09:28:06 +01:00
Jessica Lawshe
d9e4bda90b Merge pull request #2859 from overleaf/ns-cmg-history-labels-deletion
Ensure history label dissapears from UI when deleted

GitOrigin-RevId: fe48cbce9fbd70f7008043dc202a5d985bd6c5fb
2020-06-12 02:10:35 +00:00
Jessica Lawshe
cc018357e1 Merge pull request #2895 from overleaf/jel-groups-itm-content
Include itm_content in redirect to payment page

GitOrigin-RevId: 4dea2777ed9d1d4a45edbe29371971418681375d
2020-06-12 02:10:24 +00:00
Jessica Lawshe
7d98a82208 Merge pull request #2891 from overleaf/jel-remove-unused-feature-flags
Remove unused redirect-sl feature flag and sharelatex-redirects module

GitOrigin-RevId: a13ae586db3b7ab4440f2e941947be3a28d97741
2020-06-12 02:10:18 +00:00
Tim Alby
d3ff214b88 partially revert "[DockerRunner] fix metric incrementing and error logging"
This reverts commits:
- 2b2fcca39ce8dee0fdc0c342aa0d6c822592bcec
- 9e82ab0890c5cc8c7fb95362c3f7edbcaad0cf29
- e3da458b376871c3ce72d6984d14bf1ee668b04b
2020-06-11 12:51:26 +02:00
Brian Gough
f239fc3b5d send 503 unavailable response on EPIPE 2020-06-11 11:12:02 +01:00
Brian Gough
6c98c7af4a error on missing profile 2020-06-10 11:42:07 +01:00
Jakob Ackermann
06a8dc8ec1 Merge pull request #155 from overleaf/jpa-backport-receiveupdate-tests
[backport] 107 and 116: Improve ReceiveUpdate acceptance tests
2020-06-10 11:28:25 +02:00
Jakob Ackermann
10eb30e572 Merge pull request #154 from overleaf/jpa-backport-httpcontroller-tests
[backport] 111 HttpController: 404 for missing clients and add tests
2020-06-10 11:28:17 +02:00
Jakob Ackermann
45ac2bdd97 Merge pull request #153 from overleaf/jpa-backport-drainmanager-tests
[backport] 108 and 112: DrainManager acceptance tests
2020-06-10 11:28:08 +02:00
Jakob Ackermann
cfe37dcbb5 Merge pull request #152 from overleaf/jpa-vendor-cookie
[misc] vendor a patched session.socket.io middleware
2020-06-10 11:27:58 +02:00
Jakob Ackermann
5b85e0154d Merge pull request #151 from overleaf/jpa-perf-parser
[perf] add a few short cuts to the packet decoding
2020-06-10 11:27:50 +02:00
Jakob Ackermann
ef04d252f3 Merge pull request #150 from overleaf/jpa-tests-for-141-147
[misc] add test cases for the validation of the callback argument
2020-06-10 11:27:44 +02:00
Jakob Ackermann
b2e4448992 [misc] test/acceptance: ReceiveUpdateTests: test remotely sent update 2020-06-10 09:53:48 +01:00
Jakob Ackermann
83e3ff0ed7 [misc] test/acceptance: ReceiveUpdateTests: add 2nd project/3rd client
...and check for cross project leakage.
2020-06-10 09:53:29 +01:00
Jakob Ackermann
56fda1f9b0 [misc] test/acceptance: use the correct redis instances 2020-06-10 09:43:15 +01:00
Jakob Ackermann
bc44494466 [HttpController] return 404 in case of a missing client and add tests
Add acceptance tests for the client view.
2020-06-10 09:41:36 +01:00
Hugh O'Brien
f024483aa0 Merge pull request #2889 from overleaf/jpa-ns-disable-spell-check-at-runtime
[misc] disable spellcheck for unsupported languages at runtime

GitOrigin-RevId: 4214981930992abac054e78ce138adacaa99b801
2020-06-10 02:12:46 +00:00
Hugh O'Brien
cedb075b34 Merge pull request #2893 from overleaf/jel-plans-test
Add hidden plans cards at bottom of page for A/B test

GitOrigin-RevId: a44ca8f3ee60a583187126af32dcdfedba4ee41d
2020-06-10 02:12:41 +00:00
Jakob Ackermann
eabff1d6b2 [perf] test/acceptance: DrainManagerTests: cleanup previous clients
...before starting to drain.
2020-06-09 18:02:38 +01:00
Jakob Ackermann
de35fc5ecf [HttpApiController] implement the disconnection of a single client
The http route returns as soon as the client has fully disconnected.
2020-06-09 18:01:08 +01:00
Jakob Ackermann
91e296533f [misc] test/acceptance: add tests for the draining of connections 2020-06-09 18:00:44 +01:00
Simon Detheridge
59551fc140 Merge pull request #121 from overleaf/spd-gcs-byte-range
Fix Filestore returning one-too-many bytes when given a range
2020-06-09 16:32:42 +01:00
Jakob Ackermann
acb7d7df5a [misc] add test cases for the validation of the callback argument
When the user provides a function as last argument for socket.emit,
 socket.io will flag this as an RPC and add a cb as the last argument
 to the client.on('event', ...) handler on the server side.
Without a function as last argument for socket.emit, the callback
 argument on the server side is undefined, leading to invalid function
 calls (`undefined()`) and an unhandled exception.
The user can also provide lots of other arguments, so the 2nd/3rd ...
 argument is of arbitrary type, again leading to invalid function calls
 -- e.g. `1()`.
2020-06-09 16:30:03 +01:00