Commit graph

6378 commits

Author SHA1 Message Date
M Fahru
361f6f245a Refactor new plans page (#8493)
* [web] hide the monthly/annual switch for small screens via css

Co-Authored-By: Jakob Ackermann <jakob.ackermann@overleaf.com>

* [web] merge logic for hiding elements shown in a subset of view

Co-Authored-By: M Fahru <m.fahru@overleaf.com>

* [web] hide the monthly/annual switch for small screens via css

Co-Authored-By: M Fahru <m.fahru@overleaf.com>

* [web] merge logic for hiding elements shown in a subset of view

Co-Authored-By: M Fahru <m.fahru@overleaf.com>

* fix inverted logic on monthly annual checking

* delete some duplicated logic and refactor

* merge switch functions

* move global variable into the main module

* simplify the enable and disable switch

* remove unused parseFloat

* simplify group plan pricing calculation

* simplify discount group plan logic

* simplify sticky header logic

* merge view and period switching

* fix underlining of switch text

* simplify class list toggling

* merging two function of the group plan

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: 5e51690514bbf1dee2639011748c6a8470e1c19a
2022-06-23 08:02:56 +00:00
Jakob Ackermann
51c870c285 Merge pull request #8505 from overleaf/jpa-compile-result-full
[web] collect compile-result for ALL compiles

GitOrigin-RevId: 5ba29fb352bc29d14c22e7e80fa556148d862137
2022-06-23 08:02:46 +00:00
Alexandre Bourdin
3d26c4bb6f [web] Add new admin tool for surveys (#8356)
* Setup survey module and admin page skeleton

* Replace survey staff access permission with admin-only

* Manage survey config with admin tool

* Display configurable survey in project list + add preview in admin

* Fix linting errors and unit tests

* Add acceptance tests for survey module

* Move survey-form to survey components

* Add configuration option for Recurly group subscription users on surveys

* Change survey pre-link text to a lighter gray for accessibility

* Cleanup survey options implementation after review

GitOrigin-RevId: 8f621951efeae458d1ab081fe98b8d0d539cca1a
2022-06-23 08:02:37 +00:00
Alexandre Bourdin
21c8b9a47a Merge pull request #8426 from overleaf/ta-error-pages-style
Update General Error Pages Style

GitOrigin-RevId: 04346784c94d5ce6bf3257fd128a3f00da4c4e9e
2022-06-23 08:02:34 +00:00
Jakob Ackermann
c999033eb4 Merge pull request #8534 from overleaf/jpa-fix-downloads
[web] double down on passing compileBackendClass to clsi

GitOrigin-RevId: 6e035a885caa31e55ff0cf63c584f3f03629f1cf
2022-06-22 08:05:40 +00:00
Jakob Ackermann
bfad0841a4 Merge pull request #8483 from overleaf/jpa-faster-compiles-feedback-ui
[web] faster compiles feedback UI

GitOrigin-RevId: 9feea47503aa6bddf51adb73b8c9fbef394fda14
2022-06-22 08:05:14 +00:00
Jakob Ackermann
9d913a0cea Merge pull request #8522 from overleaf/jpa-rename-event
[web] rename analytics event for server side compile result details

GitOrigin-RevId: c7646918c455f992425013ff517e76a669e5cc46
2022-06-22 08:05:08 +00:00
John Lees-Miller
fcf9c92160 Split test for log parser changes
GitOrigin-RevId: efe9fb29c5ae56889b686692f8533ae0ae4a3b1d
2022-06-22 08:04:55 +00:00
June Kelly
a450a74351 Upgrade async package to 3.2.2 (#8447)
* Revert "Revert "Bump async to 3.2.2 (#7618)""

This reverts commit 75153a555211d654744c2e61e27fe21085826c22.

* [web] fix usage of async.queue.drain in script

* [clsi] fix usage of async.queue.drain

* [spelling] fix usage of async.queue.drain

* [redis-wrapper] fix usage of async.queue.drain

* [web] Test that LockManager queue is cleared

This protects against a regression found when upgrading the
async package. Here we test that the `queue.drain` callback
is really getting called, and the lock is being removed from
the LOCK_QUEUES map.

* [redis-wrapper] Upgrade async to 3.2.2

GitOrigin-RevId: df921e6d7f1d505bd467f22e58600ba1aff48869
2022-06-22 08:03:35 +00:00
Thomas
3a1bba07f7 Merge pull request #8436 from overleaf/tm-update-wording-subscription-dashboard
Update wording on subscription dashboard

GitOrigin-RevId: 4739677fcf46e5de4db3e3fe2411f6ed9898aa2c
2022-06-21 08:03:08 +00:00
M Fahru
4c37d47daf Change British spelling for "customise" and "personalise" to American spelling (#8475)
GitOrigin-RevId: fe5754f08ff337148d8e8717a7495ad1e855fdbf
2022-06-21 08:03:04 +00:00
M Fahru
66c27ae153 Fix interstitial page student plans have wrong button background color (#8489)
GitOrigin-RevId: f9f3ec239c06c9ecc7e608aaf879d69041c0a9a3
2022-06-21 08:02:58 +00:00
ilkin-overleaf
6235f3ea56 Merge pull request #8482 from overleaf/jpa-compile-result-segmentation
[web] simplify segmentation of compile-result event

GitOrigin-RevId: 8cd42bb7712b9cc2385c3681b78d493b3fa138ce
2022-06-21 08:02:54 +00:00
M Fahru
21837fefd7 Change URL for interstitial payment page to /user/subscription/choose-your-plan (#8406)
GitOrigin-RevId: ed1832157b2540bf121e64f20d001d665125924e
2022-06-20 08:04:10 +00:00
M Fahru
c54c048e35 Implement premium features discoverability on successful subscription page with split test (#8336)
GitOrigin-RevId: 362fa289fa6e009e316dcaceae0587f5fc18162c
2022-06-20 08:04:06 +00:00
Brian Gough
2970a09d19 Merge pull request #8423 from overleaf/briangough-issue8388
increase lock and timeout for history resync to 6 minutes

GitOrigin-RevId: 2aea0cbc26c92ed0aad8f815ccd41a2abc0b752e
2022-06-20 08:04:03 +00:00
Alexandre Bourdin
57114c4503 [web] Display the current plan in the project list dashboard (#8293)
* Display the current plan in the project list dashboard

* Add unit tests for SubscriptionViewModelBuilder#getBestSubscription

* Handle free trial for group subscriptions

* Reuse the info-badge icon for the plan labels

* Do not display subscription status when projects are selected

* Custom tooltip for group subscriptions with team name

GitOrigin-RevId: 40982f70cf9fb7c92058e417b73c84af1648c33e
2022-06-17 08:03:40 +00:00
Davinder Singh
c30ec5fa7c Merge pull request #8422 from overleaf/ta-silent-error
Silence Error If AffiliationUnchecked Flag Cannot Be Unset

GitOrigin-RevId: 1e0ffc401dfcc1ac9ae1a3d1de850ab899b4ce8e
2022-06-17 08:03:28 +00:00
Davinder Singh
eba2fe9a3e Merge pull request #8212 from overleaf/ds-remove-registration-field-home-page
Remove registration from home page

GitOrigin-RevId: 3bd04f2f2aa62ef5f3fa8a0cdd09e461c38a27e9
2022-06-17 08:03:10 +00:00
Brian Gough
b6ab0792a9 Merge pull request #8401 from overleaf/bg-use-redis-locker-in-web
extract web LockManager implementation into redis-wrapper

GitOrigin-RevId: 60144d1b1136bab90475cb4b4a6597e1b3f6af22
2022-06-17 08:03:00 +00:00
Jakob Ackermann
b19c56ccaf Merge pull request #8396 from overleaf/jpa-split-test-mongo-user
[web] implement split test assignment based on mongo user

GitOrigin-RevId: d3e2dff6a5e925cfd0426e9ebfeb7b64dc803f42
2022-06-16 08:03:20 +00:00
Jakob Ackermann
8cdb746628 Merge pull request #8434 from overleaf/revert-7618-dependabot-npm_and_yarn-async-3.2.2
Revert "Bump async to 3.2.2"

GitOrigin-RevId: a5deaea558011fa5a2e1aebe07856e8b0c87c4fc
2022-06-16 08:03:10 +00:00
dependabot[bot]
d55f4dfafa Bump async to 3.2.2 (#7618)
[all] Upgrade async package to 3.2.2

- [web] Fix usages of async library
- [project-history] Fix usage of async library
- [third-party-references] Fix usage of async library
- [track-changes] Fix usage of async library

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: June Kelly <june.kelly@overleaf.com>
GitOrigin-RevId: 90cf132f13da53b2bd6690ee3cdf4d6c8563ecd2
2022-06-16 08:02:49 +00:00
Jessica Lawshe
365250b3c6 Merge pull request #8250 from overleaf/jel-get-saml-user
[web] Lookup SAML users by ID and attribute

GitOrigin-RevId: 874cc1647522257a941a49bc737f0f40833edef6
2022-06-15 08:05:24 +00:00
ilkin-overleaf
41c715c40d Merge pull request #8378 from overleaf/ii-cm6-three-way-toggle
[cm6] Make cm6 as the default source editor

GitOrigin-RevId: b56724d2c147792c55ce01cf272fbcce16f87916
2022-06-15 08:05:18 +00:00
M Fahru
1070dd53f3 Remove footer and rightside of the navbar on the interstitial payment page (#8407)
Co-authored with Thomas Mees (thomas.mees@overleaf.com)

GitOrigin-RevId: 270e11f0cfd09830e5c7600d636b8ebbfc6049a2
2022-06-15 08:05:00 +00:00
M Fahru
0204d7947f Refactor successful subcription to use async/await (#8377)
GitOrigin-RevId: 5748486848c6e0576c974e5595acbcdee3daf7f3
2022-06-15 08:04:54 +00:00
Timothée Alby
825c06a3b4 Merge pull request #8376 from overleaf/jpa-delete-zonal-downloads-split-test
[web] tear down split test on zonal downloads -- keep zonal variant

GitOrigin-RevId: a7e1f48cdc64175e4fc28828ad9a46b0a28383b5
2022-06-15 08:04:18 +00:00
Timothée Alby
7794e03dcb Merge pull request #8363 from overleaf/jel-affiliation-check
[web] Handle when no affiliation found for redundant subscription check

GitOrigin-RevId: c0e653b944b994c5eafaa2d4f2d54f3cb57d67fa
2022-06-15 08:04:12 +00:00
Alexandre Bourdin
ad3eb0bfcc Merge pull request #8389 from overleaf/ab-fix-analytics-enabled-flag
Skip persisting assignment when analyticsEnabled is turned off

GitOrigin-RevId: e22b2cc29a5741ad90743ebaf5eb2c91cca0a2f5
2022-06-14 08:02:35 +00:00
M Fahru
73cf4116b6 Interstitial Payment Page UI + Route (#8305)
GitOrigin-RevId: a31f7094db819e0dad4ff3f09c17544d40260dd4
2022-06-14 08:02:16 +00:00
Tim Down
fef395f431 Fix layout shift by nearly always applying overflow-y hidden on review panel (#8174)
* Always hide vertical overflow on the review panel, not just when it's expanded, which prevents it scrolling slightly when scrolling the PDF in some circumstances
* Fix layout shift by always applying overflow-y hidden on review panel and make entry visible in minimized review panel by making the overflow visible while hovering over the entry

GitOrigin-RevId: 854ee47a762ee2cf78fbbb5856afddb3b723d679
2022-06-13 08:03:37 +00:00
M Fahru
61e57e8a6a [web] fix new plans page table header additional link URL (#8302)
GitOrigin-RevId: a377e8012884297e4c555bad465112d575621133
2022-06-10 08:03:37 +00:00
Timothée Alby
e6c7025813 Merge pull request #8289 from overleaf/ta-redundant-subscription-email
Create Redundant Subscription Notification on Email Confirmation

GitOrigin-RevId: 77baab93ebaae85d09681051641e663bb680c17e
2022-06-09 08:02:41 +00:00
Jessica Lawshe
8c816b3b23 Merge pull request #6509 from overleaf/jel-migrate-sso-id
[v1 and web] Migrate institution SSO external user ID

GitOrigin-RevId: f31cd50fbada9a2704df1c837d695f2ff547420d
2022-06-08 08:03:22 +00:00
Timothée Alby
b26c491eb5 Merge pull request #8290 from overleaf/ta-redundant-subscription-saml
Don't Create Redundant Subscription Notification on SAML for Group Plans

GitOrigin-RevId: 99e66201c9423ff7e849b2d68d96651ad6015fd0
2022-06-07 08:02:32 +00:00
Eric Mc Sween
baaf4d4240 Merge pull request #8286 from overleaf/em-halt-on-error-backend
Stop on first error backend implementation

GitOrigin-RevId: 497b1ed2c13f544760d8ad8d029359db75275389
2022-06-07 08:02:21 +00:00
M Fahru
199360afb8 Extract monthly annual switch on new plans page as mixin (#8292)
GitOrigin-RevId: 4634557dff55a747206d3fb355b9924ca769e98c
2022-06-06 08:04:07 +00:00
Thomas
f4ef8a3ea0 Allow setting plans page currency with url param (#8263)
* Allow setting plans page currency with url param

GitOrigin-RevId: 5ae977d9872cf5f5b1a234d1273c70c2dd0e14e9
2022-06-06 08:03:52 +00:00
Thomas
11fddee8e4 Merge pull request #8261 from overleaf/tm-show-correct-price-in-change-plans-list
Show correct prices in change plans list on subscription dashboard

GitOrigin-RevId: 194b516bae92564d33f50e1c0035d21b2ba246a9
2022-06-06 08:03:49 +00:00
M Fahru
b12c108522 [web] Extract reusable table mixin on plans page v2 tables (#8262)
GitOrigin-RevId: 7d8dcff5fd3f0c450de6cca57b428759d44dec7d
2022-06-06 08:03:45 +00:00
M Fahru
4f127f8408 Add new "Premium Features" link on the navbar "Features & Benefits", and hide it behind the "premium-features-discoverability" split test (#8269)
GitOrigin-RevId: 5dae86818a485c74078683422ec44008fd754f27
2022-06-06 08:03:41 +00:00
Eric Mc Sween
2ab5189771 Merge pull request #8237 from overleaf/em-halt-on-error
Stop on first error dropdown UI

GitOrigin-RevId: 5191a37f6c227ff5a91c10ce965832e1702c3931
2022-06-03 08:03:39 +00:00
Eric Mc Sween
98f73fe35c Merge pull request #8253 from overleaf/em-decaf-cleanup-compile-controller
Decaf cleanup CompileController and CompileManager

GitOrigin-RevId: 97384c9f76a2487c04f3d8d6a384cefdfcd083d4
2022-06-03 08:03:32 +00:00
Thomas
5e2933e2fe Merge pull request #8240 from overleaf/tm-teardown-persistent-upgrade-test
Teardown persistent upgrade prompt split test and fix styling

GitOrigin-RevId: 8776231c3308c5f08b91232c962c9796a5f4afa0
2022-06-02 08:02:45 +00:00
M Fahru
df35a67707 fix typo, change recomendedCurrency to recommendedCurrency (#8245)
GitOrigin-RevId: 16d40113d73de10082c3cc7fcb9bd54bbaf5a274
2022-06-02 08:02:40 +00:00
Timothée Alby
a8a26f80a5 Merge pull request #8239 from overleaf/msm-cross-reference-email-comments
Cross reference email RegExp comments

GitOrigin-RevId: d3a076f701568a27683a9f3e9171531c96dca4d6
2022-06-01 08:04:06 +00:00
Alexandre Bourdin
b48529497d Merge pull request #8232 from overleaf/ab-fix-anonymous-users-assignment
Fix the condition to assign anonymous users to default for alpha/beta phases

GitOrigin-RevId: 4ffaf2cceeadbfc76120c874ee2c86f747034e9f
2022-06-01 08:03:22 +00:00
Alexandre Bourdin
5cbb2def77 Split test archiving (#8197)
* Support archiving of split tests

* Do not create variant stripe when rollout percent is 0

* Add acceptance tests for split test archiving

* Review improvements

GitOrigin-RevId: 3c9dd3d88b81b20cacf29966123fcde1c2b0e1a9
2022-05-31 08:04:53 +00:00
Timothée Alby
c66278cf89 Merge pull request #8148 from overleaf/ta-pr-dictionary-style
Polish Dictionary Modal UI

GitOrigin-RevId: 48aceb56c84a218380c619ecc5cd527f5062d3c4
2022-05-27 08:04:16 +00:00