Commit graph

16029 commits

Author SHA1 Message Date
Jakob Ackermann
b25ff076b8 Merge pull request #6962 from overleaf/jpa-clsi-tweak-health-check
[clsi] tweak health check

GitOrigin-RevId: 2caad90d55bb441c7008e3084b34d683b072dfbd
2022-03-03 09:03:19 +00:00
Jakob Ackermann
a3e85f5357 Merge pull request #6959 from overleaf/jpa-clsi-zero-bucket
[clsi] add zero bucket and collect histogram data in timing as well

GitOrigin-RevId: 6390f1c213e4850ceb629dae1e6406f6077759aa
2022-03-03 09:03:16 +00:00
Timothée Alby
f8988e8087 Merge pull request #6958 from overleaf/ta-file-tree-selection-flat-3
Explicitly Distinguish Docs and Files

GitOrigin-RevId: 90738dd47b36342aed0eaf46a3842042d9d0f4b6
2022-03-03 09:02:59 +00:00
Jakob Ackermann
264b107e39 Merge pull request #6927 from overleaf/jpa-split-clsi-metrics
[misc] split clsi metrics into multiple categories

GitOrigin-RevId: 964ab57b344b92383a2937beff50139bae273a0e
2022-03-02 09:02:52 +00:00
Jakob Ackermann
958216d578 Merge pull request #6926 from overleaf/jpa-clsi-bump-logger-metrics
[clsi] upgrade logger and metrics module

GitOrigin-RevId: 85c346b5eed683672a77d86d6a434dc313b7824b
2022-03-02 09:02:50 +00:00
Miguel Serrano
bc4be9ddad [spelling] prune unused aspell packages (#6944)
GitOrigin-RevId: e40d0a3c834352b4130a071753aab2d91c17226f
2022-03-02 09:02:47 +00:00
Alf Eaton
4610734f07 Add new fat footer (#6260)
GitOrigin-RevId: 64c50caac2ec8d56b3f49d6f97c8a1c4d4b3a496
2022-03-02 09:02:45 +00:00
Miguel Serrano
cdf88358d4 [git-bridge] delete newrelic.yml (#6850)
Deleting unused New Relic configuration from git-bridge.

* Delete `newrelic.yml`
* Delete `newrelic.jar`

GitOrigin-RevId: 60fc512d8b60d6905b5a660e44239dd8b5310347
2022-03-02 09:02:42 +00:00
Miguel Serrano
fe35372d27 Merge pull request #6849 from overleaf/msm-git-bridge-log-level
[git-bridge] review logging levels

GitOrigin-RevId: beb6ce89ccdee7c60c4439d7a5252d7858956a9a
2022-03-02 09:02:40 +00:00
June Kelly
9702346edc Merge pull request #6628 from overleaf/jk-heartbeat-editor-type-metadata
Add editor metadata to editing-session pings

GitOrigin-RevId: f42be772c13f71380d59bae7c447645fe0e16a17
2022-03-02 09:02:34 +00:00
Timothée Alby
0edd4b7899 Merge pull request #6934 from overleaf/ab-sso-user-assignment
Fix assignment by user ID for SSO test

GitOrigin-RevId: a487bf45444507246899ea918ffe02ad67e514d4
2022-03-02 09:02:31 +00:00
Timothée Alby
b2e93f7db7 Merge pull request #6800 from overleaf/ta-file-tree-selection-flat-2
File Tree File Selection in Flat PDF View Take 2

GitOrigin-RevId: 0e7732e3a4df0650a6410d202c06c4852666615d
2022-03-02 09:02:27 +00:00
Miguel Serrano
2781f7d8f8 Merge pull request #6857 from overleaf/msm-fix-spelling-image-arm
Adds Ubuntu ports to spelling apt sources in order to fix ARM64 builds

GitOrigin-RevId: bb037c38d26fa001b1779e380bda0c9dfb1f4fcb
2022-03-01 09:04:34 +00:00
Thomas
c47eefae5e Re-add dropbox webhook signature verification and decaf cleanup (#6735)
* Re-apply #6352 dropbox webhook signature verification/ decaf cleanup

* Add verification for Sharelatex legacy dropbox app signature

* Add SL and OL dropbox app secrets to web secrets

GitOrigin-RevId: 0aa2e8371069a09330850218124937d4e03e75bb
2022-03-01 09:04:27 +00:00
Eric Mc Sween
5ded04eaea Merge pull request #6785 from overleaf/em-split-tests-analytics-enabled
Add "analytics enabled" setting to split tests

GitOrigin-RevId: 9ddfda9e246cac7a13361b2d3df6884212583000
2022-03-01 09:04:15 +00:00
Alf Eaton
95eb69c268 Set default props in style guide story (#6865)
GitOrigin-RevId: b5292e644804ba12a72f0513844c64495031c9e5
2022-03-01 09:04:03 +00:00
Alf Eaton
6fb5397cc8 Add webpack:profile npm script to web package.json (#6870)
GitOrigin-RevId: 7ca6c1e667b0eac7dfec182ed6dfe923bb39b0b2
2022-03-01 09:03:56 +00:00
Alf Eaton
1e7ab75cbc Remove unused "file upload complete" code (#6874)
GitOrigin-RevId: 64bbca60db983df6dba48c3c8b849cb1ec3e0243
2022-03-01 09:03:49 +00:00
Alf Eaton
a83c0b4085 Remove border from editor switcher (#6892)
GitOrigin-RevId: c48b348c3840fa0439a7a656b8c33a8c96c20ea5
2022-03-01 09:03:31 +00:00
Henry Oswald
92316a2266 Merge pull request #6920 from overleaf/revert-6917-ho-v1-timeout
Revert "v1 timeout of 2 seconds"

GitOrigin-RevId: e170356d515d68d5e8380b163a71857ce97e8e38
2022-02-25 09:04:12 +00:00
Henry Oswald
85bf61e5fe Merge pull request #6917 from overleaf/ho-v1-timeout
v1 timeout of 2 seconds

GitOrigin-RevId: 810a5b0c104fb3eb2b8878ab184d7a4010828f8c
2022-02-25 09:04:06 +00:00
Jessica Lawshe
1c62f82f9c Merge pull request #6886 from overleaf/jpa-less-verbose-ci
[web] skip HIBP check for all tests but the HIBP specific ones

GitOrigin-RevId: 714e69cc2220e7edcef875d6be487ded571cd977
2022-02-25 09:03:23 +00:00
Jessica Lawshe
f1272166f8 Merge pull request #6900 from overleaf/ds-lato-font
Add lato italic font face

GitOrigin-RevId: b16c5120409ef995b0ca0118028e3a558c57bba1
2022-02-25 09:03:16 +00:00
Alf Eaton
428d82618f Remove unused props from ToolbarHeader (#6864)
GitOrigin-RevId: cef9fb44f9c368084e4a2a7dd017cea8899adbaa
2022-02-24 09:04:07 +00:00
Alf Eaton
bbb9f11c0e Remove debugging code from pdf-preview tests (#6866)
GitOrigin-RevId: 6ae924d112bfceaaecfe41cbac9e9cb3743a58f7
2022-02-24 09:04:01 +00:00
Alf Eaton
7be97fb2e2 [web] Fix Storybook (#6803)
* Move deprecated CLI option to config
* Reduce custom Storybook webpack config
* Upgrade Storybook
* Update package-lock.json

GitOrigin-RevId: e480aa0298e481d3e78a62b91c067b62c05bdeaf
2022-02-24 09:03:32 +00:00
Davinder Singh
726a47421e Merge pull request #6754 from overleaf/ds-subscription-address-length
Updated maxlength of subscription address field

GitOrigin-RevId: b08717a4e0e052e1c2fa92308767dfea56d8ea4d
2022-02-23 09:04:44 +00:00
Miguel Serrano
e9fe9f5397 Merge pull request #6806 from overleaf/msm-remove-docker-cli
[clsi] remove `docker-ce-cli`

GitOrigin-RevId: bb49621091aafd43e9e6f157c5fd3b09ca9d07a8
2022-02-23 09:03:31 +00:00
Brian Gough
fde4f72adf Merge pull request #6779 from overleaf/ae-cm-editor-switch
[web] [cm6] Add a three-way switch for editor choice

GitOrigin-RevId: fff788ddad8d10488e8446de7f1503702da0985f
2022-02-22 09:03:05 +00:00
Miguel Serrano
89f9590823 Adjusted primary-email-check page styling (#6626)
* Adjusted primary-email-check page styling

GitOrigin-RevId: 2f7fee9766cc040cb7d30243f940d8f5c2bf489b
2022-02-18 09:04:14 +00:00
Timothée Alby
4dc4286d1b Merge pull request #6778 from overleaf/ta-revert-file-tree-selection-flat
Revert File Tree File Selection in Flat PDF View

GitOrigin-RevId: c82b0155c4e028ee54345083c97c4ee3b7cc7ed5
2022-02-16 11:40:46 +00:00
Timothée Alby
2d9ceeba49 Merge pull request #6443 from overleaf/ta-github-sync-git-folder-error
Fix GitFolderError Message

GitOrigin-RevId: 4c38474be336125263c79edc8e6055b6ef3f46d9
2022-02-16 11:40:23 +00:00
Timothée Alby
4a70dfa921 Merge pull request #6705 from overleaf/ta-ms-doc-too-long-modal
Improve handling of "Document Too Long" Errors

GitOrigin-RevId: 6a5e200014609e2a94f896840757487564d41176
2022-02-16 11:40:16 +00:00
Timothée Alby
9049691f42 Merge pull request #6683 from overleaf/ta-file-tree-selection-flat
File Tree File Selection in Flat PDF View

GitOrigin-RevId: a6169e7d167e26f4b086ca13acd863988ce07c2f
2022-02-16 11:40:09 +00:00
Timothée Alby
2cab7059ee Merge pull request #6717 from overleaf/ta-ds-deep-compare-memo
Use Deep Comparison for RootFolder Effects

GitOrigin-RevId: fd4dd523f131799eccd5909a7fd42ec7c985ca4e
2022-02-16 11:40:03 +00:00
Timothée Alby
33b3d67753 Merge pull request #6758 from overleaf/jpa-cut-ldap-memory-usage
[web] cut memory usage of ldap container

GitOrigin-RevId: 26bbab4f6f84ecaab7d92869259fdaafa72559c0
2022-02-16 11:39:56 +00:00
Timothée Alby
0f3b73da99 Merge pull request #6760 from overleaf/jpa-v1-subscription-logging
[web] log when v1 returns a non expired personal subscription

GitOrigin-RevId: 4e08e57a380d3d3512faeba93241be7c1590fb27
2022-02-16 11:39:48 +00:00
Miguel Serrano
de20b5b443 Merge pull request #6744 from overleaf/msm-update-async-http-client-vuln
[git-bridge] Bump `async-http-client` and `mockserver-netty`

GitOrigin-RevId: bcea12a01f3bbae6567b9f54567a1187e5a763f3
2022-02-16 11:39:21 +00:00
Miguel Serrano
41475ca14a Merge pull request #6764 from overleaf/msm-fix-toggle-marketing-navbar
Fix collapsed menu toggling in marketing pages

GitOrigin-RevId: f1075d46242ad6265ebaa0e65031e99f902fe503
2022-02-16 11:39:06 +00:00
Brian Gough
f23cc433a4 Merge pull request #6742 from overleaf/bg-cm6-chaos-monkey
[web] extend chaosmonkey for cm6

GitOrigin-RevId: d030952c9f0c8d3441321354f1ae61e5a6bc4d53
2022-02-16 11:38:54 +00:00
Eric Mc Sween
8e4b85c6f3 Merge pull request #6731 from overleaf/em-logs-ui-split-test
Move new logs UI to a split test

GitOrigin-RevId: 2ebd5afbbda273e7c3092416c64754a56e628b05
2022-02-16 11:38:42 +00:00
Miguel Serrano
3510863d37 Merge pull request #6698 from overleaf/msm-fix-sso-existing-user
Fix SSO registration for existing users

GitOrigin-RevId: 4213269c2ed6d6e93ffab6f3fc9307405c5f8d49
2022-02-16 11:38:26 +00:00
Miguel Serrano
1fb8f15005 add segmentation to user-registered event (#6711)
* add segmentation to `user-registered` event

GitOrigin-RevId: 9ba40c0a81aea488439758b992caeb7855c27f67
2022-02-16 11:38:09 +00:00
Miguel Serrano
a3b01659a4 Fix isRequired error in GoToCodeButton.propTypes (#6646)
Skip `PdfSynctexControls` rendering until `position` is set

GitOrigin-RevId: ea40c7f98ea3bbdf3d8689175658d2c014b68436
2022-02-16 11:38:02 +00:00
Jakob Ackermann
fa55598c82 Merge pull request #6721 from overleaf/jpa-back-fill-staff-access
[web] scripts: add a new script for back filling staff access for admins

GitOrigin-RevId: c7eaa5887bdbc1a9594553961bd08fba48a451ed
2022-02-16 11:37:40 +00:00
Alf Eaton
753be43c53 [web] [cm6] Add a source editor toggle (#6674)
* Add a source editor toggle
* Only show the toggle if in split test variant (or query param override)
* Change labels
* Add check for this.editor
* Update toolbar.pug

GitOrigin-RevId: ee00e31db334fc562b00d28a8c2de5d03456f749
2022-02-16 11:37:33 +00:00
Alf Eaton
0097e8344b Add missing space to example doc (#6704)
GitOrigin-RevId: 2fd23a653d2913395da10b8d2d55029e73a0fede
2022-02-16 11:37:16 +00:00
CloudBuild
7efd9560c9 auto update translation
GitOrigin-RevId: 2fdb9fa154b91c77e92988ddc9fff8844595a5fe
2022-02-16 11:36:33 +00:00
Eric Mc Sween
46d2b84103 Merge pull request #6727 from overleaf/em-revert-logs-ui-split-test
Revert "Move new logs UI toggle to a split test"

GitOrigin-RevId: 5f2aecb53d2df21c89da594b0a64c8cf8ca04bc6
2022-02-16 11:36:26 +00:00
Eric Mc Sween
4df657db4b Merge pull request #6640 from overleaf/em-alpha-beta-split-tests
Move alpha/beta feature toggles to split tests

GitOrigin-RevId: e64387d9bde2db9c4e96ea7f5992c877ad16b9a9
2022-02-16 11:36:20 +00:00
Thomas
45ac55c7f0 Merge pull request #6559 from overleaf/tm-teardown-onboarding-email-split-test
Implement 'send-email' variant for trial onboarding email for all users

GitOrigin-RevId: f53b86d875a1a4e146dc57603b7a83ac098f9cdf
2022-02-16 11:36:02 +00:00
Thomas
1c5949f715 Merge pull request #6595 from overleaf/tm-avoid-logging-tokens
Clean up log lines that include tokens

GitOrigin-RevId: 3b6acc9cdda4a91b9b10ce85a0650ccdeeea79a4
2022-02-16 11:35:51 +00:00
Alexandre Bourdin
3b9da1d57e Merge pull request #6587 from overleaf/ab-split-test-create-edit
Split tests admin - create/edit

GitOrigin-RevId: a256bf6fe8350214b1ef01ff5e6fa68a812a59be
2022-02-16 11:35:39 +00:00
Alf Eaton
5f9cc7512a [web] [cm6] Fix alignment of tracked changes/comments with review panel (#6557)
GitOrigin-RevId: 65416f32874da1cc866e4949244c4934aeabe804
2022-02-16 11:35:32 +00:00
Alf Eaton
34a296747b Merge pull request #6695 from overleaf/ae-cm6-review-panel-timing
[web] [cm6] Improve track changes extension timings

GitOrigin-RevId: 6e374b785daf14bd4d4576747faa0a9b20c4d346
2022-02-16 11:35:10 +00:00
Timothée Alby
1b4d675b0a Merge pull request #6690 from overleaf/ta-max-dictionary-size
Add Dictionary Size Limit

GitOrigin-RevId: f3b8be11de5a1480c8bc1a7fe26e9d67bd047757
2022-02-16 11:34:58 +00:00
Timothée Alby
01f63e810a Merge pull request #6679 from overleaf/ta-undefined-references-hint
Update Human Readable Hint Regex for Undefined References

GitOrigin-RevId: 326ed206f3321d43580031ec2b46bc3117c6c4e9
2022-02-16 11:34:51 +00:00
Timothée Alby
0a27b3711f Merge pull request #6599 from overleaf/ta-new-subscription-split-test
Payment Page Split Test

GitOrigin-RevId: bb43cbf4e5722bd18076f2f8bf1014816bce1df0
2022-02-16 11:34:44 +00:00
Timothée Alby
21c92a045d Merge pull request #6672 from overleaf/ta-router-apply-signature-fix
Use Correct Router Apply Function Signature

GitOrigin-RevId: 567ff9a4c59834ae200bba860e265abe2e0173e5
2022-02-16 11:34:37 +00:00
Timothée Alby
c0fae79ad7 Merge pull request #6693 from overleaf/jpa-error-is-manager
[web] refactor error handling for rejected manager removal

GitOrigin-RevId: 48be3bf254de74c2799d1368aee329fd9038dfa6
2022-02-16 11:34:25 +00:00
Timothée Alby
62b662f07a Merge pull request #6561 from overleaf/tm-subscription-cancel-button-split-test
Update copy for subscription cancellation, in split test variant

GitOrigin-RevId: ab5847238b950099bf41b9d4c08f325ffce1051d
2022-02-16 11:34:08 +00:00
Jakob Ackermann
f5a74a014f Merge pull request #6663 from overleaf/jk-cm6-spelling-ignore-words-dedupe
[web] Spelling: de-duplicate ignored-misspellings list

GitOrigin-RevId: 9888c35dde01fb733247fba38846c07b43a3e924
2022-02-16 11:33:54 +00:00
Jakob Ackermann
4bdcd520de Merge pull request #6604 from overleaf/msm-jpa-add-go-to-settings-email-confirmation
Added "go to settings" button in email confirmation page

GitOrigin-RevId: 4449f05e9934fdb09ca07804171881b04f3e8bdb
2022-02-16 11:33:34 +00:00
June Kelly
926f69d331 Merge pull request #6630 from overleaf/bg-spelling-tex-related-words
[web] add TeX-related words to IGNORED_MISSPELLINGS

GitOrigin-RevId: 10471b1e45e9b4f054871eb11b27410ccbacb59d
2022-02-16 11:32:39 +00:00
June Kelly
19edfab153 Merge pull request #6624 from overleaf/bg-cm6-autocompile-lint-check
[web] add cm6 hasLintingError support

GitOrigin-RevId: 9e531526003595cb5139623f929605a7fd0f59f8
2022-02-16 11:32:33 +00:00
June Kelly
ab5135957a Merge pull request #6633 from overleaf/jk-cm6-spelling-ignore-commands
[web] Ace/CM6 Spelling: don't send commands to backend

GitOrigin-RevId: 7fbd14240facb71b6d110eb95e271b07fced76b1
2022-02-16 11:32:26 +00:00
June Kelly
ef4e137676 Merge pull request #6610 from overleaf/jk-better-editing-heartbeat
[web] CM6: improvements to editor heartbeat

GitOrigin-RevId: b0e5379d221cba76c91d6d21863ca8355749d18e
2022-02-16 11:32:19 +00:00
Simon Detheridge
fe1cb010b4 Merge pull request #5718 from overleaf/spd-built-images
Support prebuilt images and add overrides for using mapped folders

GitOrigin-RevId: b1a1f7fe61ead1c08f3b8eef35ef90926ca42f36
2022-02-16 11:31:30 +00:00
Jakob Ackermann
ae0c347f27 Merge pull request #6542 from overleaf/jpa-em-code-sharing-workspaces
[misc] npm workspaces

GitOrigin-RevId: 87aa72db6637fb238d7cd35b0a48ac3ed58ab3eb
2022-02-16 11:31:07 +00:00
Jakob Ackermann
42d78528ae Merge pull request #6572 from overleaf/jpa-web-unit-tests-npm-workspaces
[web] adjust unit test setup for npm workspaces

GitOrigin-RevId: 4c6f6debbc082301570173345cc366984a9c59f1
2022-02-16 11:31:03 +00:00
CloudBuild
ae3f00f608 auto update translation
GitOrigin-RevId: 16f23e5e3d4d7e552491bf32c463f8ac2a4e3a2c
2022-02-07 09:04:11 +00:00
Alf Eaton
22e13d74f6 Ignore missing PDF errors in Sentry error reporting (#6529)
GitOrigin-RevId: fc61a2499ec3e8ff95a7058aea65b9d41ed8bd62
2022-02-07 09:03:46 +00:00
Alf Eaton
e73ad85d0e Add AbortController polyfill to captcha script (#6555)
GitOrigin-RevId: 3a7e8350b4d6d62583a3cb87378605f13cde3728
2022-02-07 09:03:39 +00:00
Alf Eaton
ae7c7edc69 [web] [cm6] Trigger metadata reload if edited text contains metadata-related command (#6371)
GitOrigin-RevId: 4180ef0b7720b38ca1511c4f96de14e03b0a3ea5
2022-02-07 09:03:32 +00:00
Alf Eaton
371270c622 [web] Convert Ace themes to CodeMirror 6 (#6543)
GitOrigin-RevId: 510064f04afb65387ee9ed7d56ad91db4b7a84d3
2022-02-07 09:03:29 +00:00
Alf Eaton
9a87824b12 Update CodeMirror 6 styles (#6577)
GitOrigin-RevId: 91cdfcc9fca899666d6740acbb6cc1c2aa991451
2022-02-07 09:03:24 +00:00
Alf Eaton
07abb8ac99 [web] Add keybindings (vim, emacs) to CodeMirror 6 (#6117)
GitOrigin-RevId: 9ee0b320a29ef3bf99bb414a775a94adce8ca8c1
2022-02-07 09:03:17 +00:00
CloudBuild
7edcc51d92 auto update translation
GitOrigin-RevId: 8cd58fba9921992c3cbaf30fe286bb2ae8b25bf0
2022-02-04 09:04:28 +00:00
Brian Gough
f92e44a261 Merge pull request #6596 from overleaf/bg-initial-cm6-split-test
[web] initial split test for cm6 source editor

GitOrigin-RevId: 05d0f9db8abcd93ea66326378854b23f27dc9d73
2022-02-04 09:04:09 +00:00
Alexandre Bourdin
6ce0df3106 Merge pull request #6597 from overleaf/ab-send-events-ga4
Send some events to GA4

GitOrigin-RevId: 7927cea14e6717aea033faa3d5f3e0f9efd6e672
2022-02-04 09:03:49 +00:00
Miguel Serrano
176ead8983 Primary Email Check (#6471)
* added primary-email-check page, route and controllers
* add `#add-email` internal link in settings to display new email form
* added primary-email-check redirection with split test
* update `lastPrimaryEmailCheck` when the default email address is set
* added `lastPrimaryCheck` to admin panel
* translations for primary-email-check
* acceptance tests for primary-email-check
* [web] multi-submit for primary email check
* Using `confirmedAt` to prevent from displaying primary-email-check page

Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
Co-Authored-By: Miguel Serrano <mserranom@gmail.com>
GitOrigin-RevId: d8e3a280439da08038a4487d8bfd7b3b0596e3b5
2022-02-04 09:03:34 +00:00
June Kelly
e92cc8a4b1 Merge pull request #6592 from overleaf/jk-cm6-switch-focus
[web] CM6: focus editor when switching back to doc

GitOrigin-RevId: 1ef63dbcbd3befc2a2a7c4b43dc3a357489e5a11
2022-02-04 09:03:30 +00:00
June Kelly
4b14a14819 Merge pull request #6573 from overleaf/jk-cm6-heartbeat
[web] Move on-scroll heartbeat tracking from ace to IDE

GitOrigin-RevId: e39bc9ebffde228c4a2d6045837fae3b64219bed
2022-02-04 09:03:23 +00:00
CloudBuild
81ce1d97f2 auto update translation
GitOrigin-RevId: c72258697b4a545f71b39b4418791c77e6dcbd41
2022-02-03 09:05:05 +00:00
Miguel Serrano
0f7948cfdf Highlight SSO in register/login/home pages (#6396)
* Highlight SSO in register and login pages
* Highlight SSO in home page
* updated split test request to new APIs
* reordered SSO buttons when highlighting SSO in login
* Updated copy for institutional login and fixed indentation
* increased SSO button size in homepage for highlight-sso variant
* prefill email in registration page
* added `register` and `register-success` events

GitOrigin-RevId: 2822afc15c27856ca713002ed804e1f42a2d955c
2022-02-03 09:04:45 +00:00
Timothée Alby
30cd3d2961 Merge pull request #6551 from overleaf/bg-remove-unused-flag
[web] remove unused keepEditorContents flag

GitOrigin-RevId: 9c20469e9200ee9aad19fdd0d1567a6eea704741
2022-02-03 09:04:20 +00:00
Timothée Alby
74d9937816 Merge pull request #6536 from overleaf/bg-cm6-size-check
Add editor max doc length checks to codemirror

GitOrigin-RevId: 0a458fc3aa23f22b078c6607ee4347bc76c371e9
2022-02-03 09:04:12 +00:00
Timothée Alby
22ee7d6da2 Merge pull request #6525 from overleaf/jpa-harden-translations-sanitize
[web] scripts/translations: sanitize: double down on angular xss

GitOrigin-RevId: d08deab392942e593e920e648118f0e196af1740
2022-02-03 09:04:05 +00:00
Timothée Alby
58cf92620a Merge pull request #6523 from overleaf/jpa-translations-check-sanitize
[web] scripts/translations: add script for checking html sanitization

GitOrigin-RevId: d4b9c9a7eb1ed0ca9202b0cb6e4c33f3e73bd0e4
2022-02-03 09:03:58 +00:00
Timothée Alby
64423936b9 Merge pull request #6434 from overleaf/ta-github-sync-default-branch-translation
Remove References to Master Branch in GitHub Sync Translations

GitOrigin-RevId: 711885bc6c09f89d9dd052bd5b739024e641a74b
2022-02-03 09:03:50 +00:00
Timothée Alby
189bc52082 Merge pull request #6439 from overleaf/ta-github-sync-workflow-error
Handle Error Caused by Missing Workflow Scope

GitOrigin-RevId: 7f5e6f8c0469d5ce85755e27afdc370b86b7c0b3
2022-02-03 09:03:43 +00:00
Alexandre Bourdin
215725e0a7 Merge pull request #6569 from overleaf/ab-recurly-webhook-filter
Add a failfast for invalid userId on recurly webhook

GitOrigin-RevId: 94e7c5fd756f5fbc592a9c346fca157883625396
2022-02-03 09:03:23 +00:00
CloudBuild
6991a0d7dd auto update translation
GitOrigin-RevId: c4a2f4bdf78bda9e6898e6f3cc24df7985803778
2022-02-02 09:03:40 +00:00
Thomas
347649ebaa Merge pull request #6570 from overleaf/revert-6352-tm-dropbox-webhook-signature-verification
Revert "Add dropbox webhook signature verification and decaf cleanup"

GitOrigin-RevId: eb1fab093d7979a010700f0bc3e1e696f3cba6ae
2022-02-02 09:03:18 +00:00
Thomas
bbb97bed26 Merge pull request #6558 from overleaf/tm-wfh2021-ended
Remove notifications for WFH2021 offer, revert side-bar to old Upgrade notice

GitOrigin-RevId: d5f0bb34b40605a335d48b1d2db54df8fab9224a
2022-02-02 09:03:14 +00:00
Thomas
635a478f36 Add plans page split test variant with new layout (#6450)
* Add plans page split test variant with new layout

* Set itm_content to toggle if group modal clicked through via variant view toggle button

* Change split test name to be more specific

GitOrigin-RevId: 0fa48b1b74eea84f15e630e3a62b36be5549da9e
2022-02-02 09:03:11 +00:00
Thomas
1777c075ea Merge pull request #6423 from overleaf/tm-plans-new-events
Add new analytics events to plans page/subscription flow

GitOrigin-RevId: 7b70ee30749ebc671cf2445f3cbdae91a7278b01
2022-02-02 09:03:07 +00:00
Thomas
7a445eb489 Add dropbox webhook signature verification and decaf cleanup (#6352)
* Decaf: move functions to top level, removing unused vars

* Decaf: fix camelcase identifiers

* Decaf: remove unnecessary code created because of implicit returns

* Decaf: remove next() fallback callbacks

* Decaf: shorten null checks, remove decaf/eslint comments

* Add signature verification for Dropbox webhook

* Add overleaf dropbox app secret to web (staging+prod)

* Add simple acceptance test for dropbox webhook events processing

* Add method for modules to register app middleware prior to bodyParser call, move rawBody middleware to Dropbox module

GitOrigin-RevId: 736f489e2eb5906f7b202c1049c4ce143deea74e
2022-02-02 09:03:03 +00:00
Jakob Ackermann
d90dc2bfae Merge pull request #6519 from overleaf/jpa-lodash-4-17-21
[misc] upgrade lodash from 4.x to 4.17.21

GitOrigin-RevId: 08e03981ffe0f2d3e3d29d9b094d98fcb2d95a6f
2022-02-01 09:03:29 +00:00
Jakob Ackermann
2ed696b3e0 Merge pull request #6517 from overleaf/jpa-node-fetch-2-6-7
[misc] upgrade node-fetch from 2.6.x to 2.6.7

GitOrigin-RevId: 5a43e82e23d78fd6e68a38655dab4665a401a9db
2022-02-01 09:03:24 +00:00
Alexandre Bourdin
931c53d04c Split Tests Admin UI - test list (#6411)
* Admin page to list split tests

Admin page to list split tests

Update split test model

Display optional split test fields + Only display link in admin menu in SaaS mode

Add a separate endpoint to update split test info (to avoid creating a new version)

Fix split test tests after rebase

Add name and activeOnly filtering to split test list

Sort split tests by descending order of last modification

Fix lint build error

Add buttons to copy variant assignment as query string

* Move react components to follow our file structure guidelines

* Cleanup and improvements from review

* Small change of report URLs display

* Improve filters display for small screens

GitOrigin-RevId: 498531a1f080419de017883e33d6afed05a3f5c9
2022-01-31 09:03:42 +00:00
Alf Eaton
4cad876173 [web] CodeMirror 6 track changes extension (#6455)
GitOrigin-RevId: 038f375c40e7bc8009ee423016b711a2252f52fa
2022-01-31 09:03:19 +00:00
Alf Eaton
157a380bad Merge pull request #6491 from overleaf/ae-cm6-upgrade
Upgrade CodeMirror 6 packages

GitOrigin-RevId: 997951d9542eb2ad220416e5dc6ee8c2388b2135
2022-01-31 09:03:09 +00:00
Jakob Ackermann
8789296f5a Merge pull request #6481 from overleaf/jpa-node-14-18-3
[misc] upgrade node version from 14.18.1 to 14.18.3

GitOrigin-RevId: 976542fcc0271e323695c59a987dcf1614ee633e
2022-01-28 09:03:53 +00:00
Jakob Ackermann
409d8cd1a8 Merge pull request #6470 from overleaf/jpa-o-error-3-4
[misc] upgrade o-error to v3.4.0 in all the places

GitOrigin-RevId: 7b7ce1211cbe5e41754ca2ae112d237befdcf40e
2022-01-28 09:03:45 +00:00
June Kelly
cc515afe95 Merge pull request #6484 from overleaf/ta-script-require-fix
Fix Require Path

GitOrigin-RevId: 1525890bd24520d8715cfbc8d617c545ef199314
2022-01-28 09:03:32 +00:00
June Kelly
542207b6f9 Merge pull request #6488 from overleaf/ta-survey-future-remove
Remove Product Survey 2021

GitOrigin-RevId: 3db6686a951d192ef86c58ac99e8b3e40947c5b2
2022-01-28 09:03:28 +00:00
Eric Mc Sween
57228c5589 Merge pull request #6442 from overleaf/em-split-tests-user-admin
Show split test assignments in user admin

GitOrigin-RevId: 4563a4899d5278a0ef84188ae25cb5dfd3d5cb57
2022-01-27 09:04:06 +00:00
Jakob Ackermann
7b4102025e Merge pull request #6493 from overleaf/jpa-flaky-delay
[web] HaveIBeenPwnedApiTests: give background check more time

GitOrigin-RevId: 761b3f402f9284eb56bee29e6e78e759ac42ba86
2022-01-27 09:03:53 +00:00
Jakob Ackermann
3730672c97 Merge pull request #6502 from overleaf/jpa-skip-likely-failing-login-request
[web] skip login re-try request when no captcha response was generated

GitOrigin-RevId: 9edc6e8394914a710020983fe9cbcf09d543a82f
2022-01-27 09:03:48 +00:00
Jakob Ackermann
d812b88e76 Merge pull request #6457 from overleaf/jpa-harden-login
[web] harden login process

GitOrigin-RevId: 5c0b7cc725efd5e3e879067ad8a42fe46a47b60d
2022-01-27 09:03:38 +00:00
Jakob Ackermann
8e77ada424 Merge pull request #6417 from overleaf/jpa-device-history
[web] add cookie/JWE based device history for skipping captcha challenge

GitOrigin-RevId: b091564bfd93f7e587d396c860fd864f220f4b63
2022-01-27 09:03:34 +00:00
Brian Gough
89268bee2c Merge pull request #6485 from overleaf/bg-remove-op-from-timeout-error
[web] remove unnecessary content from timeout errors

GitOrigin-RevId: c4913956e6f990afbd4c8f225c6d7c51e6d77e75
2022-01-27 09:03:30 +00:00
Brian Gough
b43a3a6861 Merge pull request #6486 from overleaf/bg-remove-google-analytics-from-errors
[web] remove google analytics for editor errors

GitOrigin-RevId: cac318316780e84cd8d076624a4e3f39b7cf2725
2022-01-27 09:03:26 +00:00
Brian Gough
e1add75eee Merge pull request #6407 from overleaf/bg-linter
port ace linter to codemirror6

GitOrigin-RevId: 080781bf303ebcd25461e6d07a02e14310ab3d59
2022-01-27 09:03:22 +00:00
Jessica Lawshe
6a0da3d204 Merge pull request #6375 from overleaf/jel-reconfirm-check
[web] Use v1 date for reconfirm notification check

GitOrigin-RevId: e14f1b6a1a6ab629628858d962a3757a6078cf79
2022-01-26 09:03:50 +00:00
Jessica Lawshe
7653b46719 Merge pull request #6356 from overleaf/jel-user-admin-panel
[web] v2 admin affiliations tab shows data used for licenses

GitOrigin-RevId: 1038b042a0728b118d3204515ed9f69e35746b18
2022-01-26 09:03:43 +00:00
Jakob Ackermann
cfaec97a3d Merge pull request #6393 from overleaf/ta-backfill-user-properties
Backfill User Properties

GitOrigin-RevId: ea2ffeaaf71d5ce41c76a1bfb2f0014006ef0d08
2022-01-26 09:03:06 +00:00
Jakob Ackermann
b2e18c92a6 Merge pull request #6418 from overleaf/ta-ga-optimize-remove
Cleanup Google Optimize

GitOrigin-RevId: d8cf8008179ad2c355c09f06d947fb2b89cf5a3c
2022-01-26 09:03:02 +00:00
Jakob Ackermann
a13dee04c6 Merge pull request #6424 from overleaf/jpa-multi-submit-async-form
[web] add support for async-form inside a multi-submit page

GitOrigin-RevId: 801363aeacc6c10411aceaf2c09a5e4b3b90fcf7
2022-01-26 09:02:55 +00:00
Alexandre Bourdin
4c49edd89b Assignment by id for recurly webhook (#6465)
* Allow split test assignment by ID for recurly webhook

* Small refactoring of assignment logic

* Add tests for getAssignmentForUser

* Cleanup following review comments

* Provide default value for sync option in split test handler

GitOrigin-RevId: 828cad3a1f3a0f3efd25f427d00a3c530ae2f087
2022-01-25 09:04:05 +00:00
Alexandre Bourdin
1b954fa720 Merge pull request #6332 from overleaf/ab-split-test-param-overrides
Split tests query param overrides

GitOrigin-RevId: 8112710d057ddc22cebf37a619dfc969be57b6cc
2022-01-25 09:03:04 +00:00
Tim Alby
bbac46156b convert price_in_unit to price_in_cents
GitOrigin-RevId: bae030e9c90f8286d6e6550744849984fe81f63d
2022-01-21 09:03:29 +00:00
Tim Alby
3e70546e18 rename price attributes to price_in_cents or price_in_unit
GitOrigin-RevId: 8045472c96862078583fcb522099ad78926281dc
2022-01-21 09:03:23 +00:00
Tim Alby
3dbd913d97 disambiguate between displayPrice and recurlyPrice
GitOrigin-RevId: 38f4c51b9834c417824c0093096767f50e998cb8
2022-01-21 09:03:16 +00:00
Tim Alby
e98084259a renames prices scope var into groupPlans
GitOrigin-RevId: ef53edd8f9b78eb13fb2d4bb488e30ee02858764
2022-01-21 09:03:11 +00:00
Tim Alby
0421fc58f1 remove old angular plans code
GitOrigin-RevId: 84a1173d300ab3ab2e77c0714b7a1315de59876c
2022-01-21 09:03:08 +00:00
Eric Mc Sween
fd60549482 Merge pull request #6386 from overleaf/em-promisify
Promisify UserAdminController

GitOrigin-RevId: 51bf4ddd0673409006658fb0d8cc60a8b4e1071d
2022-01-20 09:04:15 +00:00
Eric Mc Sween
7446523205 Merge pull request #6358 from overleaf/jel-fix-de-ng-link
[web] Fix modal link in plans FAQ

GitOrigin-RevId: 29137e71f5f0930443660086fb3a1cc3d87b05dd
2022-01-20 09:04:09 +00:00
Alf Eaton
f065a7a909 Improve the Icon component (#6245)
GitOrigin-RevId: fbb23b32c47edbe5a22badc627318accbd09e82a
2022-01-20 09:03:58 +00:00
Alf Eaton
ee00ff3c44 [web] Add the meta[viewport] tag to all pages (#6301)
* Always add the meta[viewport] tag
* Set metadata.viewport to false on projects list page
* Remove setting metadata.viewport = true
* Add viewport: false to editor page

GitOrigin-RevId: 6f9d4c1972e3e6fdf1b6c23cd17d57ba866fcaeb
2022-01-20 09:03:48 +00:00
Alf Eaton
d1e210319b Merge pull request #6389 from overleaf/ae-github-capitalisation
Fix "GitHub" capitalisation

GitOrigin-RevId: 9b47d58a3d92c8dd695ca1c8f3d28ea7d6178da5
2022-01-20 09:03:38 +00:00
Alf Eaton
1dd62570a6 Merge pull request #6390 from overleaf/ae-is-visible-binary
[web] Only run updateOnResize when the PDF viewer is visible

GitOrigin-RevId: 90b5632f45406b66af7710c6e8346cf73ffbebea
2022-01-20 09:03:28 +00:00
Jakob Ackermann
5701cc9e4b Merge pull request #6351 from overleaf/jk-cm6-context-menu-revamp
[web] Spelling: use button instead of `a` tag

GitOrigin-RevId: e63a89eb781bbecf33c49cfcd83e8ff7612fa554
2022-01-20 09:03:11 +00:00
Jakob Ackermann
1fc0b3e4aa Merge pull request #6349 from overleaf/jpa-password-strength-checking
[web] data collection for password strength using HaveIBeenPwned api

GitOrigin-RevId: 7e4d57a979c29027fb7ca5294f3935500a0b4cf3
2022-01-20 09:03:07 +00:00
Jakob Ackermann
220daff655 Merge pull request #6384 from overleaf/jpa-fix-proxying-of-json
[web] fix proxying of responses from other services

GitOrigin-RevId: ac1ecc02c06e353f8379fadb47824a46672610e5
2022-01-18 09:03:30 +00:00
Jakob Ackermann
d720d6affa Merge pull request #6317 from overleaf/jpa-send-explicit-content-type
[web] send explicit content type in responses

GitOrigin-RevId: d5aeaba57a7d2fc053fbf5adc2299fb46e435341
2022-01-18 09:03:18 +00:00
Jakob Ackermann
c97e95aeba [web] confirmDomain: skip fetching affiliations per user
Nothing is looking at either
 - `user.emails[i].affiliation` or
 - `user.emails[i].emailHasInstitutionLicence`
So we might as well skip fetching the data.

This eliminates N v1 calls and N mongo calls from the endpoint.

GitOrigin-RevId: bb1d077df19910b9dfb7ef06562cf35ce5302290
2022-01-14 09:03:33 +00:00
Jakob Ackermann
5a7698ddef [web] refactor updating of scroll position in pdf view
Co-Authored-By: Timothée Alby <tim.alby@overleaf.com>
GitOrigin-RevId: 932c880bcd41e68d231928bdcbbaeb06c60f6fd5
2022-01-14 09:03:28 +00:00
lawshe
212430e430 Run script on primary
GitOrigin-RevId: 655191d2948ce3a1cfedc4e660965ed90c0371ba
2022-01-14 09:03:23 +00:00
Tim Alby
d5c574360f remove uses of this in tests
GitOrigin-RevId: 2eea02c91358a7bb5e1d32c8990f793d6f794ac4
2022-01-14 09:03:14 +00:00
Tim Alby
5798011bce always check response's status code in tests
GitOrigin-RevId: 46ed4912a6508aa3ce2048ff8d887af4d8907d6a
2022-01-14 09:03:11 +00:00
Tim Alby
795ed56034 asyncify tests
GitOrigin-RevId: 62f875bb121a599fab830a3244959596796cd6e1
2022-01-14 09:03:08 +00:00
Tim Alby
67ce7c3c75 asyncify MessageHttpController
GitOrigin-RevId: 678a22807f1cbb51a8c1c9bd11b34e1c045d9361
2022-01-14 09:03:06 +00:00
Tim Alby
01cdb4025e asyncify MessageManager
GitOrigin-RevId: 6b89b70f7c19fc9e71d60b634808030f324f40fe
2022-01-14 09:03:03 +00:00
Tim Alby
49e2e02105 asyncify ThreadManager
GitOrigin-RevId: 24fc2d5e04238a7e4e23826a19b69a9fbb2f9637
2022-01-14 09:03:00 +00:00
Tim Alby
f3a5e8a0e8 move module functions to top level
GitOrigin-RevId: 73524dcec49faa05d1fd4dd4ffa6950803175f33
2022-01-14 09:02:57 +00:00
Tim Alby
b5d2122f05 decaf cleanup: remove unnecessary callback fallbacks
GitOrigin-RevId: a6b347e121a30221a305116327e42ad070e81977
2022-01-14 09:02:55 +00:00
Tim Alby
ea8e0af551 decaf cleanup: rewrite code to no longer use __guard__
GitOrigin-RevId: 591dbefe98423ead89505250c4f46c8ad2610305
2022-01-14 09:02:52 +00:00
Tim Alby
291f28a655 decaf cleanup: remove unnecessary use of Array.from
GitOrigin-RevId: 78c835929c9d7c38e0231f8fbb3e16a35efb7498
2022-01-14 09:02:50 +00:00