Jimmy Domagala-Tang
c0f39267a9
Merge pull request #19150 from overleaf/jdt-ai-promo
...
feat: add labs ai experiment promo
GitOrigin-RevId: 9bf039635b487339caa277b501a8cd99c7c7613f
2024-07-03 08:04:15 +00:00
Thomas
566466185b
Merge pull request #19206 from overleaf/tm-link-sharing-changes-events
...
Implement link sharing warning events by reusing the StartFreeTrial paywall button component from the original modal
GitOrigin-RevId: 9c16407ad8a7b5afc9b5b13be1491ef903ae74a3
2024-07-02 08:04:25 +00:00
Thomas
6a65644778
Merge pull request #19185 from overleaf/tm-validate-can-invite-editor-2
...
Update inviteToProject to check if editor slots are available
GitOrigin-RevId: bb67ae6329130573ba43e9524a3084bf5551ebde
2024-07-01 08:04:21 +00:00
Thomas
a047388b08
Add serverside checks for changing the user access level after link sharing changes ( #19168 )
...
* Add getEditInviteCount to count only edit collaborators
* Add getInvitedEditCollaboratorCount to count joined editors
* Add canAddXEditCollaborators to determine if owner can add more editors
* Update setCollaboratorInfo to check if editor slots are available
GitOrigin-RevId: a88707f102dfbde39322f5a7bbc79d47b6e810d5
2024-07-01 08:04:16 +00:00
Thomas
2ce71b0b4d
Async/awaitify LimitationsManager for link sharing changes ( #19110 )
...
* Move functions to top level
* Async/awaitify LimitationsManager methods
* Promisify LimitationsManagerTests
GitOrigin-RevId: ece7d2ea5160aa95924840044e2f225e1f2848e7
2024-07-01 08:04:12 +00:00
Jimmy Domagala-Tang
d7863bec37
Merge pull request #19108 from overleaf/jdt-ai-rm-alpha-reqs
...
Remove Alpha bypass for AI Error Correction
GitOrigin-RevId: d6b93bc2071dbeeb3d67d48197e61abf4d920944
2024-06-28 08:04:57 +00:00
Domagoj Kriskovic
c3c97d9fb9
[web] return file type in revertFile ( #18995 )
...
* [web] return file type in revertFile
* fix revertFile unit test
* fix formatting
GitOrigin-RevId: e4ac0500ff6c72c7f7fa23a5f61b09ed31a28da0
2024-06-28 08:04:45 +00:00
Antoine Clausse
01188589f8
Add some JSDoc types to @overleaf/logger
( #19153 )
...
* Add some JSDoc types to `@overleaf/logger`
* Update `logger.error` calls
* Fixup `logger.err` JSDoc
* Update `logger.err` calls
* Fix `args` type
* Remove "Error message" description
* Replace `arguments` by actual arguments of the method
* Fix: "ESLint: Unnecessary '.apply()'.(no-useless-call)"
* Add JSDoc params to `debug` `info` `warn`
* Remove extra `args` param in JSDoc so developers aren't invited to use it
Not sure if this is the best thing to do because it creates a warning in the IDE: "Parameter args is not described in JSDoc"
* Add comment about serialization of `err` `req` `res`
* Allow strings as first param in `debug` `info` `warn`
* Fix syntax for optional parameters in JSDoc
* Add 2 signatures, to avoid "string, string" params
* Fix `@signature` names copy-pastes
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
* Revert the double `@param attributes`. It doesn't work
---------
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: 086dee8bbf30d577c5e1f844a9df5e518c46aca7
2024-06-28 08:04:25 +00:00
Antoine Clausse
1dbbe5af9d
[web] Promisify TemplatesController ( #18849 )
...
* Promisify TemplatesController
* Update TemplatesControllerTests
* Fix `templateVersionId` in `getV1Template` (!!)
GitOrigin-RevId: bdaa59ed3cff81d919a8b3d19d5be555a2790f55
2024-06-28 08:04:17 +00:00
Jessica Lawshe
07d1f26731
Merge pull request #19084 from overleaf/jel-light-touch-rename-css
...
[web] Rename CSS variables for light touch redesign
GitOrigin-RevId: c84eb75a45af8270895795ceffef944696037881
2024-06-27 08:04:52 +00:00
Jessica Lawshe
fbc9a557c7
Merge pull request #18959 from overleaf/jel-faq-tabs
...
[web] New tab and accordion more reusable
GitOrigin-RevId: ed8340bc4b6312c4270edf1edf53c74a067aaccf
2024-06-27 08:04:44 +00:00
Jimmy Domagala-Tang
c04fea0fd3
Merge pull request #19162 from overleaf/jpa-flaky-admin-test
...
[web] refresh system message cache after creating/deleting message
GitOrigin-RevId: f7155e94a8bf08b527e7ae69d9d6a41e54c01282
2024-06-27 08:04:39 +00:00
Thomas
94be372b24
Add new interstitial 'Join project' consent page for existing link sharing editors when opening a project ( #19066 )
...
* Add helpers for checking and removing user readwrite token membership
* Add sharing-updates page and handlers
* Redirect read write token members to sharing-updates on project load
GitOrigin-RevId: d552a2cd74a9843c6103923b03f137131a48877a
2024-06-26 11:12:42 +00:00
Thomas
260fdf1307
Add read write token join interstitial variation for link sharing changes ( #19060 )
...
* Add read write join interstitial variation for link sharing changes
GitOrigin-RevId: 41661f43f4ab0f18f6ada5bec0b6af2407f65f07
2024-06-26 11:12:37 +00:00
Thomas
70bf7b2aab
Merge pull request #19109 from overleaf/tm-project-joined-add-project-id
...
Add projectId to project-joined event
GitOrigin-RevId: 222e0acc8764592344e384d1a6a5a2327d4161f5
2024-06-26 11:12:33 +00:00
Jimmy Domagala-Tang
b0344ec550
Merge pull request #19132 from overleaf/jdt-ai-policy-migration
...
feat: add migration for adding new policy to all existing groupPolicies
GitOrigin-RevId: ea3188b6059c2e96afd0058a191d18b26d68adbd
2024-06-26 08:04:48 +00:00
Tim Down
956aad7e43
Merge pull request #18764 from overleaf/td-bs5-dashboard-feature-flag
...
Create new feature flag for BS5 project dashboard page
GitOrigin-RevId: a523bd7df94c411805ac2f5234135bc7a56d25bb
2024-06-25 11:12:35 +00:00
Tim Down
8897e439ae
Merge pull request #18928 from overleaf/td-bs5-nav-admin-missing-href
...
Bootstrap 5: add missing href to nav admin link
GitOrigin-RevId: 5339fa2ef465a6319d87cba6201e682dea1a98a6
2024-06-25 11:12:31 +00:00
Mathias Jakobsen
e48e4293a6
Merge pull request #19090 from overleaf/mj-web-metadata
...
[web] Ignore commented content when parsing metadata
GitOrigin-RevId: 78f9b0d6549e60fca4ba8929beb677341d885655
2024-06-25 11:12:02 +00:00
roo hutton
64d9792fe3
Merge pull request #18861 from overleaf/rh-editor-limit-exceeded
...
[web]: Handle exceeded editor limit in share modal
GitOrigin-RevId: 23a15805ca98327ae4a7fc731bbca3982c90bad5
2024-06-25 08:04:46 +00:00
Jimmy Domagala-Tang
04432478e1
Merge pull request #19053 from overleaf/ab-split-tests-first-time-assignments
...
[web] Return isFirstTimeAssignment flag with split test assignments
GitOrigin-RevId: 70954470fbd9430749d83d8d1e08a3969d4a09e6
2024-06-25 08:04:37 +00:00
Alf Eaton
bee698c01d
Updates to the AI error assistant ( #19065 )
...
* Only show the AI error assistant to users with write permission on the project
* Fix line number in searchDocLines
* Abort the request after 60 seconds
* Move comment
* Jump to file + line when suggestion line number is clicked
* Set tool_choice: 'required'
* Fix handling of suggestLineChange
* Tidy up getDocLines
* Avoid showing Suggest Fix button in gutter marker for typesetting warnings
* Log request errors
* Fix prefixed function name
* Update tool description
* Tweak the prompt in an attempt to improve the line number
* Reject if the total message content is too large
* Change the structure of the suggested change
* Reduce line highlight
* Fix change highlighting on deletion
GitOrigin-RevId: afde096e547050b8518195ef51b68983bc3b0be3
2024-06-24 12:05:51 +00:00
Miguel Serrano
1697087425
Merge pull request #18970 from overleaf/msm-clean-features-templates
...
[web] Cleanup `features.templates`
GitOrigin-RevId: 7c9f7bc827700e4255a5ba8a46de70318afdaae4
2024-06-24 12:05:43 +00:00
Mathias Jakobsen
23a7e19e8e
Merge pull request #18991 from overleaf/mj-table-generator-promotion-teardown
...
[web] Tear down table generator promotion
GitOrigin-RevId: 361215bdd792042ae68762fa20ae60286db5bab3
2024-06-24 12:05:18 +00:00
Jimmy Domagala-Tang
790f90e97d
Merge pull request #19036 from overleaf/jdt-labs-alpha-only
...
feat: only allow alpha users on labs page currently
GitOrigin-RevId: 5136d77789fa27a0bd9fe6f17c8937998bc74259
2024-06-24 12:04:51 +00:00
David
a8cb423078
Merge pull request #19030 from overleaf/dp-presentation-mode-flag
...
Add separate feature flag for presentation mode
GitOrigin-RevId: a996fa313c101dd822ad83109ba77fa95f99f644
2024-06-24 12:04:34 +00:00
Antoine Clausse
2c7df10b9a
[web] Refactor ProjectController.loadEditor
p-props promises ( #18823 )
...
* Move unawaited promises out of `p-props`: `User.updateOne`
* Move unawaited promises out of `p-props`: `sessionMaintenance`
* Move unawaited promises out of `p-props`: `reactivateProjectIfRequired`
* Move unawaited promises out of `p-props`: `markAsOpened`
* Move unawaited promises out of `p-props`: `flushProjectToTpdsIfNeeded`
This was actually awaited, but is it necessary?
* Use `getUserValues`: `user`
* Use `getUserValues`: `learnedWords`
* Use `getUserValues`: `projectTags`
* Use `getUserValues`: `userHasInstitutionLicence`
* Use `getUserValues`: `subscription`
* Use `getUserValues`: `isTokenMember`
* Use `getUserValues`: `isInvitedMember`
* Update `splitTestAssignments` syntax
* Remove `mapValues` in `pProps`
* Await unused promises again: `flushProjectToTpdsIfNeeded` and `reactivateProjectIfRequired`
* Remove error page file committed by mistake 🤦
GitOrigin-RevId: 6529445c364a6af660bc8ab6dfc836a4ddf7a040
2024-06-24 12:04:18 +00:00
Jimmy Domagala-Tang
271700893a
Merge pull request #18784 from overleaf/bg-allow-combined-group-policies
...
allow combined group policies
GitOrigin-RevId: b23fb0454f794e9094e8e15e732b4322a48ac1ee
2024-06-24 12:04:13 +00:00
Jimmy Domagala-Tang
e5aa917f54
Merge pull request #18682 from overleaf/jdt-ai-labs
...
Re-Release Labs Page for AI Error-Correction
GitOrigin-RevId: 2eef85dd3b5f86bedcf3339559a5fbbae2d4da87
2024-06-24 12:04:08 +00:00
Jakob Ackermann
ac7916fb29
Merge pull request #19023 from overleaf/jpa-issue-19016
...
[web] lock down legacy endpoint for creating projects from zip
GitOrigin-RevId: 0c6b29d34c601d316b184d50d93e8e17f59bfcfb
2024-06-24 12:04:00 +00:00
ilkin-overleaf
7b47acc486
Merge pull request #18763 from overleaf/ii-bs5-projects-notifications
...
[web] BS5 notifications in projects and welcome pages
GitOrigin-RevId: 25780bb64660ef41c41c007f94f70df273cac716
2024-06-24 12:03:15 +00:00
ilkin-overleaf
34311ce0dc
Merge pull request #18789 from overleaf/ii-invite-token-lookup-by-hmac-token
...
[web] Lookup project invitations by HMAC token
GitOrigin-RevId: b631445e18f83ddb5e7708388a57a0fac0f73bd2
2024-06-24 12:03:10 +00:00
Eric Mc Sween
8d35177b52
Merge pull request #18985 from overleaf/em-migrate-bulk
...
Bulk history ranges migration
GitOrigin-RevId: 0d1846b412cfcddead63a7bc15bd06a82fbb47f3
2024-06-20 08:05:05 +00:00
Brian Gough
d43292cfe6
Merge pull request #18146 from overleaf/ab-one-time-assignments
...
[web] Handle one-time assignments for split tests
GitOrigin-RevId: 2d7ec2a878055fdc96475db2129aad308abb2fff
2024-06-20 08:04:34 +00:00
Miguel Serrano
f181dfe74f
Merge pull request #18549 from overleaf/msm-system-messages-redirect
...
[web] return redirect on admin actions
GitOrigin-RevId: d6273c01d90230c786cc9d0808f866524e57bc19
2024-06-20 08:04:20 +00:00
Eric Mc Sween
e73fdfba63
Merge pull request #18906 from overleaf/em-migrate-existing-histories-2
...
History ranges migration script - second attempt
GitOrigin-RevId: 60a2c04e2a72e76a58e9e179fefc4186a96fde32
2024-06-19 08:05:02 +00:00
David
c16c806002
Merge pull request #18697 from overleaf/dp-ai-rate-limit
...
Add a rate limiter for the AI Error Assistant
GitOrigin-RevId: d23abc4b3477d13b1bfd4d69db168458ac8c2e51
2024-06-19 08:04:34 +00:00
Jakob Ackermann
aa480a2663
Merge pull request #18898 from overleaf/jpa-no-window
...
[web] migrate from window attributes to getMeta
GitOrigin-RevId: 3dcf1ab6b01155e5e4abeb3e78d0fa9053e055bc
2024-06-19 08:04:21 +00:00
Antoine Clausse
aa7839876a
[web] Promisify MetricsEmailController and InstitutionHubsController (attempt 2) ( #18805 )
...
* Reapply "[web] Promisify MetricsEmailController and InstitutionHubsController …"
This reverts commit ea14df1395f1dc2fa7d41fc7837849f9686425b5.
* Fix changes to node-fetch: `statusCode` -> `status` (!!)
* Update test
* Handle no-content without throwing (!)
Avoid error `Unexpected end of JSON input` when doing `response.json()` on an empty response when status is 204
Related: https://github.com/node-fetch/node-fetch/issues/165
* Also return `204` when no data in departments_data and roles_data
* Revert "Handle no-content without throwing (!)", and return null instead
This reverts commits 3baa779f7a9e64804e54a276faf865ab9252f336 and 51507a3d763d7006c8b01414a7c79bd3f3b6948b.
* Update tests: `assert_nil`
* Fixup: Update tests: assert null
* Use `fetchJSON` in Institution.fetchV1Data
* Proxy errors from server without throwing 500
GitOrigin-RevId: 9c13e293f3fed3abd2accddd1a9060ed02b96ba2
2024-06-19 08:04:02 +00:00
Jessica Lawshe
a343ec1578
Merge pull request #18932 from overleaf/jel-rename-css-light-touch
...
[web] Rename CSS classes for light touch redesign
GitOrigin-RevId: 2e415dcffd04f8783f5b7145827031fdbfc83baf
2024-06-18 08:05:07 +00:00
Jessica Lawshe
1db5593c5a
Merge pull request #18931 from overleaf/jel-new-files-for-light-touch
...
[web] New files for plans light touch redesign
GitOrigin-RevId: beb517543c8341bbd8124fab87b532f62c5a0c11
2024-06-18 08:05:02 +00:00
Jessica Lawshe
a7adfc12da
Merge pull request #18907 from overleaf/jel-faq-css
...
[web] CSS updates to new plans FAQ
GitOrigin-RevId: b00d8b22f62d9a3774eb673501c0b2074dd15d81
2024-06-18 08:04:57 +00:00
Jessica Lawshe
092e49d6ec
Merge pull request #18905 from overleaf/jel-plans-faq
...
[web] Add new plans FAQ to light touch redesign variant
GitOrigin-RevId: a4140a09c94e0374792acb789b4f36ad104841f2
2024-06-18 08:04:53 +00:00
Jessica Lawshe
6e084f389a
Merge pull request #18885 from overleaf/jel-plans-page-quotes
...
[web] Handle hiding/showing quote rows on new plans page variants
GitOrigin-RevId: dd88cce9acdc2ca07d5df1afa7278028820e673d
2024-06-18 08:04:48 +00:00
Domagoj Kriskovic
7e8e2b0585
Send origin metadata through docupdater and project-history when restoring files ( #18721 )
...
* add RestoreFileOrigin in overleaf-editor-core
* support source to be an object
* use sourceOrOrigin as param
* rename to originOrSource so the priority is more clear
* get timestamp from version
* fix test
* include version and min_count in getUpdatesFromHistory
* extractOriginOrSource util function
* fix RestoreManagerTests
GitOrigin-RevId: 0ace05a6ade2794c753a9d0bffb4f858ecc6899a
2024-06-18 08:04:34 +00:00
Alf Eaton
b9a8a7f7ec
Move AI provider usage to the backend ( #18562 )
...
GitOrigin-RevId: 4f66c6576571c4fbb7381d8d0e34f2e468d6f34f
2024-06-18 08:04:09 +00:00
Jakob Ackermann
e36de5a62d
Merge pull request #18856 from overleaf/jpa-server-ce-shutdown
...
[server-ce] improve shutdown procedure
GitOrigin-RevId: 5a99868d17f597c366e42625cd39f05146dcb682
2024-06-18 08:04:04 +00:00
ilkin-overleaf
b34be6bea4
Merge pull request #18653 from overleaf/ii-invite-token-create-hmac
...
[web] Add HMAC tokens for project invitations
GitOrigin-RevId: 02fa01e24790c9a87f57ff9346f5346658d4dd46
2024-06-17 08:04:17 +00:00
andrew rumble
81b0eb7eb5
Remove obsolete comment
...
GitOrigin-RevId: 73da65c200d19ed4b389423e3d9f983c90ea1885
2024-06-17 08:04:09 +00:00
M Fahru
d80046c757
Delete unused code: planFeatures.js
, this config should have been deleted on the first plans page redesign.
...
This config is superseded by `plansFeatures.js` that is imported by `plansConfig.js` which is directly used in the pug template.
GitOrigin-RevId: ae0a0e1ff7c8a64022ab378d17943fe4a7ed3b35
2024-06-14 08:05:03 +00:00
Davinder Singh
05c0cbfd6d
Merge pull request #18883 from overleaf/jel-eyebrow-text
...
[web] Add mixin for eyebrow headline
GitOrigin-RevId: 992acd11e6c22c35499329bb53917a2b1ac79ac5
2024-06-14 08:04:55 +00:00
Davinder Singh
9ff03e9245
Merge pull request #18877 from overleaf/jel-sales-ad
...
[web] Remove 2 sales ad variants and increase probability of FOMO variant
GitOrigin-RevId: 6045dd4255313ae53f255afa528695583171d55b
2024-06-14 08:04:46 +00:00
Jessica Lawshe
87bc0b2aa9
Merge pull request #18857 from overleaf/jel-plans-page-css
...
[web] Add quotes to new plans page variants
GitOrigin-RevId: 794692730a7a6846bf4e43021c34798e9a2605da
2024-06-13 08:04:45 +00:00
Jessica Lawshe
cd9dc12059
Merge pull request #18683 from overleaf/jel-new-styles-quote
...
[web] New quote style for plans page and CMS pages using `Element | Quote`
GitOrigin-RevId: c4a089727f023d5d28a036c6babbdc773d7fc06a
2024-06-13 08:04:36 +00:00
Brian Gough
38ac00ba13
Merge pull request #18775 from overleaf/bg-cookie-session-metrics-middleware
...
add middleware to record session cookie metrics in web
GitOrigin-RevId: f4404455e219d2071d6f0b39e657e9219b7d1c70
2024-06-13 08:04:16 +00:00
M Fahru
d35e11eaef
Merge pull request #18720 from overleaf/jel-begin-light-touch-plans
...
[web] Begin light touch redesign of plans page
GitOrigin-RevId: dda5ab1c0817371400f30f2e4d230f5c3a5728f4
2024-06-12 08:05:19 +00:00
Alf Eaton
af78b914df
Merge pull request #18729 from overleaf/ae-ng-non-bindable
...
Remove unused Angular attributes from Pug templates
GitOrigin-RevId: ab3ed4105ea02994924c6dd190dad65fff106c11
2024-06-12 08:04:27 +00:00
Alf Eaton
7cb0e8c4ea
Remove a few remaining references to the ide-page split test ( #18735 )
...
GitOrigin-RevId: 4f1c6332f8bf49ed1c3fcee153590d0acf72b26f
2024-06-12 08:04:18 +00:00
Jimmy Domagala-Tang
d3c270369d
Merge pull request #18593 from overleaf/jdt-mailchimp-tagging
...
allow adding and removing tags from users in mailchimp
GitOrigin-RevId: 15e491d3346877e86d55fb6eccb45813daa41e88
2024-06-11 08:05:30 +00:00
andrew rumble
3311066363
Add new fields to mongoose subscription schema
...
GitOrigin-RevId: 6b28d7464482a8d5729709f99893b333c3d7f9c2
2024-06-11 08:04:55 +00:00
Liangjun Song
0680a91a70
[web] fix incorrect event group-subscription-left ( #18757 )
...
GitOrigin-RevId: aa342dc6575eca032834c2b132d4d0144a4faa27
2024-06-11 08:04:35 +00:00
Mathias Jakobsen
c29c151c9f
Merge pull request #18803 from overleaf/revert-18801-mj-revert-big-deploy
...
[web+chat] Redo deploy
GitOrigin-RevId: a056bf20d49a39e71e03db740f57e8506dfc6b71
2024-06-11 08:03:59 +00:00
Mathias Jakobsen
a26e3d3376
Merge pull request #18801 from overleaf/mj-revert-big-deploy
...
[web+chat] Revert big deploy
GitOrigin-RevId: f4d068cbea7e5f5d59a3d698e2def2f94c9b6322
2024-06-10 08:04:33 +00:00
Mathias Jakobsen
d470093174
Merge pull request #18737 from overleaf/mj-chat-revert-existing-file
...
[web] Revert existing file by deleting it first
GitOrigin-RevId: ec9ed5c709c2631ff08dbc2e0f3633d303f12836
2024-06-10 08:04:29 +00:00
Mathias Jakobsen
110b83aea0
Merge pull request #18710 from overleaf/mj-web-chat-send-thread-data
...
[chat+web] Inform frontend when duplicating threads
GitOrigin-RevId: 285afee8f5a016a8e7ac58e9538cc3ec8362681d
2024-06-10 08:04:25 +00:00
Mathias Jakobsen
0f869f9059
Merge pull request #18654 from overleaf/mj-web-duplicate-threads
...
[web] Ensure single doc pointing to comment when reverting
GitOrigin-RevId: e86e566e1b21eed18bb08b285befcab0e740ec45
2024-06-10 08:04:20 +00:00
Jessica Lawshe
d7b64ef92e
Merge pull request #18718 from overleaf/jel-isSplitTestActive-plans-page
...
[web] New plans page variants only loadable if test is active
GitOrigin-RevId: 2b29dc8a3ecef6dd8f34dd25e59bf48a9724061b
2024-06-06 08:05:05 +00:00
Jessica Lawshe
3948b6ddb3
Merge pull request #18717 from overleaf/jel-isSplitTestActive
...
[web] Add helper for checking if test is active
GitOrigin-RevId: 1e8987517915e3947812086863da11fad252daf1
2024-06-06 08:05:01 +00:00
Jessica Lawshe
8fe46feffb
Merge pull request #18713 from overleaf/jel-group-plan-modal-defaults
...
[web] Move group modal defaults for plans page to function
GitOrigin-RevId: 0ebce884f9e984b50318742765b7a768f259a8db
2024-06-06 08:04:56 +00:00
Jessica Lawshe
d28e58a2fc
Merge pull request #18686 from overleaf/jel-plans-page-currency
...
[web] Move `currency` check to `_getRecommendedCurrency`
GitOrigin-RevId: afadd492a2e1db9c91fac027eb3c9783194ff169
2024-06-06 08:04:52 +00:00
ilkin-overleaf
dd7970c11d
Merge pull request #18644 from overleaf/ii-delete-with-body-teardown-old-routes
...
[web] Tear down deprecated routes
GitOrigin-RevId: b86e1d9283a30d36f77148eeb782a7f37987854a
2024-06-06 08:04:31 +00:00
Antoine Clausse
e452f1df5b
[web] Promisify LdapController ( #18500 )
...
* Promisify LdapController
* Update tests LdapControllerTests.js
* Promisify `AuthenticationController.finishLogin`
* Simplify null checks in LdapController
* Fix: don't use spread operator in module.exports
* Make `AuthenticationController.promises.finishLogin` a promise that resolves
* Fixup: `finishLogin` does not call `next` then the promise finishes, it calls it only on errors
* Use `Modules.promises.hooks.fire`
* Revert `processPassportLogin` callback style
* Update error handling: Use `OError.tag` instead of `logger.err`
* Fix unit tests: Rely on callbacks rather than promises
* Fix: Actually call `passport.authenticate` (!!)
* Update test: fixup `passport.authenticate` mocks
This would have caught the bugs that the previous commit is solving
* Remove `.then(() => next())` in `processPassportLogin`
Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>
---------
Co-authored-by: Eric Mc Sween <eric.mcsween@overleaf.com>
GitOrigin-RevId: a7eab5f5289956aeb8f2418408958daef3511ab7
2024-06-06 08:04:23 +00:00
Alf Eaton
c24ace801b
Remove Angular ( #17534 )
...
GitOrigin-RevId: 7a0d45e17d9905fa75569e2d19ca59caa4a41565
2024-06-06 08:04:09 +00:00
Jessica Lawshe
22be3928e3
Merge pull request #18614 from overleaf/mf-create-plans-redesign-split-test-config
...
[web] Create split test configuration for `website-redesign-plans` split test
GitOrigin-RevId: dea88256830897d1ab1f1de64eb21413c823e6ff
2024-06-04 08:04:59 +00:00
Tim Down
c0d920f305
Merge pull request #18660 from overleaf/td-rd-bs5-contact-us-modal
...
Bootstrap 5 contact us modal
GitOrigin-RevId: a4607fab50152109fbe83bc29246b7b4a82539a1
2024-06-04 08:04:46 +00:00
Andrew Rumble
d1a58e6b77
Merge pull request #18538 from overleaf/ar-add-download-all-link-in-web
...
[web] add download all link for output files
GitOrigin-RevId: 3d574d75d53e577cb0f8fd3caa4f757d9e1b7889
2024-06-03 08:04:07 +00:00
Tim Down
1b247347e7
Merge pull request #18590 from overleaf/td-ieee-editor-remove-blue
...
Disable IEEE stylesheet in IEEE editor based on feature flag
GitOrigin-RevId: 09b203e3220a868d5f0a0e413bdc4d3ff7a1792e
2024-05-31 08:04:41 +00:00
Jessica Lawshe
3a59883e7a
Merge pull request #18297 from overleaf/jel-remove-angular-group-invite
...
[web] Remove Angular version of group invite
GitOrigin-RevId: bd31cd2ed3c105c9042ae9c42894cfe960459a46
2024-05-31 08:04:27 +00:00
Jakob Ackermann
5a1cff55bc
Merge pull request #18543 from overleaf/jpa-server-pro-test-templates
...
[server-pro] tests: add tests for templates feature
GitOrigin-RevId: b36482af924e306207cbdedc1a8d1d548272ee77
2024-05-30 08:05:30 +00:00
David
55e54ce875
Merge pull request #18435 from overleaf/dp-ae-pdf-viewer-controls
...
Update PDF viewer controls
GitOrigin-RevId: 4e15b7cbd34e878d0175be635369b8d620188203
2024-05-30 08:05:06 +00:00
Tim Down
134232a1a6
Merge pull request #18577 from overleaf/td-bs5-nav-dropdown-item-missing-href
...
Add missing href on Bootstrap 5 nav dropdown items
GitOrigin-RevId: 211a6dbd559ad74a9e49edbace61a51c2cc2f2da
2024-05-30 08:04:48 +00:00
Antoine Clausse
36f0a3e01a
[web] Promisify ProjectController ( #18477 )
...
* Create `promiseAuto` util to replace `async.auto`
* Promisify `BrandVariationsHandler.getBrandVariationById`
* Promisify `updateProjectSettings`
* Promisify `updateProjectAdminSettings`
* Promisify `newProject`
* Promisify `deleteProject`
* Promisify `loadEditor`
* Fix brandVariation loading in promise auto
* Promisify `_refreshFeatures`
* Promisify `_injectProjectUsers`
* Fix `no-inner-declarations`
* Promisify `cloneProject`
* Promisify `userProjectsJson`
* Promisify `projectEntitiesJson`
* Promisify `restoreProject`
* Promisify `renameProject`
* Additional warning fix
* Update unit tests
* Fixup `updateProjectSettings`: call jobs inside the Promise.all
* Use `expressify(...)` instead of manually call `next(err)`
https://github.com/overleaf/internal/pull/18477#discussion_r1613611987
https://github.com/overleaf/internal/pull/18477#discussion_r1613621146
https://github.com/overleaf/internal/pull/18477#discussion_r1613634000
...
* Replace Promise.all by sequencial awaits
https://github.com/overleaf/internal/pull/18477#discussion_r1613852746
https://github.com/overleaf/internal/pull/18477#discussion_r1613611987
* Remove manual throws of 500. Let the generic error handler catch them.
https://github.com/overleaf/internal/pull/18477#discussion_r1613623446
https://github.com/overleaf/internal/pull/18477#discussion_r1613628955
* Promisify `untrashProject`
https://github.com/overleaf/internal/pull/18477#discussion_r1613627783
* Promisify `expireDeletedProjectsAfterDuration`
* Promisify `archiveProject`
* Promisify `unarchiveProject`
* Promisify `trashProject`
* Promisify `expireDeletedProject`
* Use async `setTimeout` from `timers/promise`
https://github.com/overleaf/internal/pull/18477#discussion_r1613843085
* Remove unused `_injectProjectUsers`
https://github.com/overleaf/internal/pull/18477#discussion_r1613855766
* Add missing exec in queries (?)
Not sure if that makes a real difference but it's more consistent with the rest of the code
* Catch floating promises
https://github.com/overleaf/internal/pull/18477#discussion_r1613868876
* Replace custom `promiseAuto` by `p-props` from NPM
https://github.com/overleaf/internal/pull/18477#discussion_r1613393294
* Downgrade `p-props` to v4. Later versions require ESM
* Simplify code around `splitTestAssignments`
GitOrigin-RevId: 84d37f7aa9227b5b9acf9eeb5db1b78afc01b6ee
2024-05-30 08:04:36 +00:00
Domagoj Kriskovic
218a4538c1
[web] support for reverting binary files ( #18033 )
...
* [web] revert binary file
* use addEntityWithName if file was deleted
* todo comments
* only show Revert file in ui even if deleted
* use _revertBinaryFile function
* emit new ids when reverting
* format:fix
* await emitToRoom calls
* use EditorController.upsertFile
* remove _revertBinaryFile function
* binary file check
* mock importFile method in tests
* move findElementByPath stub
* debug ci error
* resolve with empty object as file
* fix tests
* remove await before expect()
* format:fix
* test when binary file exists and when it does not
* use "file-revert" for source
* [web] revert existing file without ranges support (#18107 )
* [web] revert existing file without ranges support
* ignore document_updated_externally if file-revert
* fix test
GitOrigin-RevId: a5e0c83a7635bc7d934dec9debe916bdd4beb51e
2024-05-30 08:04:20 +00:00
Tim Down
3b2e60ece7
Merge pull request #18558 from overleaf/td-bs5-query-string-override
...
Add a mechanism to hide incomplete Bootstrap 5 pages by default
GitOrigin-RevId: 07cc998bf3a0bed9df2f43d1c04c62d167c9b893
2024-05-30 08:04:15 +00:00
Andrew Rumble
22e0e51796
Merge pull request #18464 from overleaf/ar-pass-analytics-id-to-google-analytics
...
Add analytics ID to google analytics when configuring
GitOrigin-RevId: e2372f68217583a90df427a853e62513f1535006
2024-05-30 08:04:07 +00:00
M Fahru
c722dcbc8d
Merge pull request #18419 from overleaf/mf-plans-page-permanent-url
...
[web] Create permanent URL for all plans and switch state in the plans page
GitOrigin-RevId: 5fa0af0e33868f8fa4f6a74627bedb4c22705cb0
2024-05-29 08:05:11 +00:00
Mathias Jakobsen
d95910fc71
[web] Enable history ranges support behind feature flag ( #18429 )
...
GitOrigin-RevId: 2f3b2352d2c157248da350eaf7b1784a605ebf20
2024-05-29 08:04:33 +00:00
Mathias Jakobsen
f14fdc7b7c
Merge pull request #17958 from overleaf/mj-web-revert-file
...
[web] Initial version of file reverting
GitOrigin-RevId: ef500b2c3ddf21b0acb6650c2526edd10ab2cc18
2024-05-29 08:04:16 +00:00
Tim Down
edaba14ed1
Merge pull request #18420 from overleaf/td-bs5-nav
...
Bootstrap 5: Navigation
GitOrigin-RevId: d22683d78c8b3bc3f41bbd276c36f47d480e24ff
2024-05-29 08:04:05 +00:00
ilkin-overleaf
abd57e03cf
Merge pull request #17831 from overleaf/msm-filter-saml-error-log
...
[web] Filter saml error logs by path
GitOrigin-RevId: 4ca9e156657afc893f38fed7ec6b00cbb7a608ef
2024-05-28 08:04:10 +00:00
Eric Mc Sween
3a1560894a
Merge pull request #18516 from overleaf/em-web-resolved-comment-ids
...
Reintroduce resolved comment ids in getDocument()
GitOrigin-RevId: 591589efc643c815c40df440d1297158901f7a79
2024-05-28 08:04:01 +00:00
Eric Mc Sween
ea8f8d0651
Merge pull request #18506 from overleaf/em-revert-web-resolved-comment-ids
...
Revert #18398 - return resolved commentIds with getDocument()
GitOrigin-RevId: c5d2dd91d02d88029eb2702d73ac37cb8dbca32c
2024-05-27 10:24:25 +00:00
Eric Mc Sween
92945f504d
Merge pull request #18496 from overleaf/rd-pug-warning-attributes
...
[web] Fix: "You should not have pug tags with multiple attributes" warning
GitOrigin-RevId: 0adfdf6a130c60966eae3c845011975af7eecc44
2024-05-27 10:24:21 +00:00
Eric Mc Sween
83e1452991
Merge pull request #18398 from overleaf/em-web-resolved-comment-ids
...
Return resolved comment ids with getDocument()
GitOrigin-RevId: 30234f72d52b90b313821290b6c63aa6cc6cb243
2024-05-27 10:24:13 +00:00
Alexandre Bourdin
a0c8cf663a
Merge pull request #18000 from overleaf/ab-dev-enable-toolbar-default
...
[web] Enable the dev-toolbar by default in the dev environment
GitOrigin-RevId: 170e59e9b82268e621fe99ffcc82b7d68467e1b3
2024-05-27 10:23:56 +00:00
Jimmy Domagala-Tang
81903bb79d
Merge pull request #18175 from overleaf/jdt-new-bib-file-prompt
...
[Web] Add opportunistic prompts for third party references
GitOrigin-RevId: d794df16781d0db707423f23ab12f40a13604907
2024-05-27 10:23:41 +00:00
Brian Gough
344b4d0fa0
Merge pull request #18088 from overleaf/ab-session-secret-rotation
...
[web/realtime/history-v1] Support session secret rotation
GitOrigin-RevId: 3c2fa27b1b3e0a8e0c9d1af2e616ce873d54aedf
2024-05-27 10:23:33 +00:00
Antoine Clausse
554be73a36
In collect_paypal_past_due_invoice.js
, iterate over each page instead of gathering data from all pages at first ( #18414 )
...
* Create `getPaginatedEndpointIterator` to iterate each page
* Create `waitMs` util, it will replace `slowCallback`
* Make `handleAPIError` async
* Make `isAccountUsingPaypal` async
* Make `attemptInvoiceCollection` async
* Make `attemptInvoicesCollection` async
* Use `await` instead of `new Promise`
* Remove unused callbackified `attemptInvoiceCollection`
* Run `attemptInvoiceCollection` for each page instead of gathering all pages in the beginning
* Add test on fetching multiple pages of invoice
GitOrigin-RevId: 2674b18c6ca5732b873fb2bc71b515909006f93d
2024-05-27 10:23:18 +00:00
Rebeka Dekany
a0334898db
Merge pull request #18437 from overleaf/rd-bs5-project-dashboard
...
Enable Bootstrap 5 to load for the project dashboard page
GitOrigin-RevId: 4aa74bd4fde98192b2e5b322bb777a8c8beae237
2024-05-27 10:22:58 +00:00
David
029cd4abe7
Merge pull request #18456 from overleaf/dp-fix-main-lint
...
Fix lint by using recordEventForUserInBackground
GitOrigin-RevId: 3412c9a997ce0921b25408fc584060e528843b88
2024-05-27 10:22:44 +00:00
David
635aae7b1f
Merge pull request #18320 from overleaf/dp-add-secondary-prompt-ui
...
Add secondary email form V2 (with Captcha this time)
GitOrigin-RevId: b06216a2c9cb5b3b09305a17992eca506a0047f5
2024-05-27 10:22:40 +00:00
Eric Mc Sween
a22319fe46
Merge pull request #18453 from overleaf/em-fix-floating-promise
...
Fix no-floating-promises lint rule
GitOrigin-RevId: 58f89e0078abf72be65552f9468cb225e5758e3e
2024-05-27 10:22:24 +00:00
Eric Mc Sween
876ee4d967
Merge pull request #18225 from overleaf/em-typescript-eslint
...
Add typescript-eslint rule: no-floating-promises
GitOrigin-RevId: 8c3decdff537c885f5bfeb5250b7805480bc6602
2024-05-27 10:22:20 +00:00
Antoine Clausse
3300811d3a
[web] Simplify removeSessionsFromRedis
signature ( #18440 )
...
* Simplify `removeSessionsFromRedis` signature
* Update usage of `removeSessionsFromRedis`
* Fix tests around `removeSessionsFromRedis`
* Add comments "remove all sessions except the current session"
GitOrigin-RevId: 03bf99c14faf2c8e403bc4bcc16463a70e031284
2024-05-27 10:21:30 +00:00
Antoine Clausse
78a0bc2b05
[web] Convert RecurlyWrapper
functions to async ( #18384 )
...
* Rename `RecurlyWrapper` to `promises`, as it will only contain the promises soon
* Update `apiRequest`
* Update `_parseXml`
* Update `_parseXmlAndGetAttribute`
* Update `_parse*Xml`
* Update `updateAccountEmailAddress`
* Update `checkAccountExists`
* Update `createAccount`
* Update `createBillingInfo`
* Update `setAddressAndCompanyBillingInfo`
* Update `createSubscription`
* Update `_createPaypalSubscription`
* Update `_handle422Response`
* Update `_createCreditCardSubscription`
* Update `createSubscription`
* Update `getSubscriptions`
* Update `getSubscription`
* Update `getPaginatedEndpoint`
* Update `getAccount`
* Update `getAccountActiveCoupons`
* Update `getCoupon`
* Update `getBillingInfo`
* Update `getAccountPastDueInvoices`
* Update `attemptInvoiceCollection`
* Update `updateSubscription`
* Update `createFixedAmmountCoupon`
* Update `lookupCoupon`
* Update `redeemCoupon`
* Update `extendTrial`
* Update `listAccountActiveSubscriptions`
* To find which functions to add as callbackified, I used this Regex:
`RecurlyWrapper\.(?!promises)[^.\s]*`
And after adding callbackified functions, we're left with no results with the Regex:
`RecurlyWrapper\.(?!promises|apiUrl|_buildXml|_parseXml|attemptInvoiceCollection|createFixedAmmountCoupon|getAccountActiveCoupons|getBillingInfo|getPaginatedEndpoint|getSubscription|updateAccountEmailAddress)[^.\s]*`
* Update unit tests
* Test `getSubscription` both as "promise" and as "callback"
I'm not sure if we want to generalize this.
* Fix: add missing `await`s (!!)
* Change `apiRequest` to reject errors instead of resolving it in an object
* Fixup for CollectPayPalPastDueInvoice test
* Fix: callbackify `getSubscriptions` (!!)
* Replace `.then(...)` chain by multiple `await`
* Fixup `attemptInvoicesCollection`: prevent reading length of undefined
* Use `return await` when returning promises
Per https://github.com/overleaf/internal/pull/18384#pullrequestreview-2065738771
GitOrigin-RevId: ceda755b24fd29f97a27e60ac5db9bc7e369f932
2024-05-27 10:21:26 +00:00
ilkin-overleaf
7ca9a5b61b
Merge pull request #18415 from overleaf/ii-delete-with-body
...
[web] Replace delete with post requests when having body
GitOrigin-RevId: b580cfa3bd53c21f46de72f3a36b647fda143b04
2024-05-21 08:04:44 +00:00
Rebeka Dekany
1aa5ee7b21
Merge pull request #18404 from overleaf/rd-bs5-dropdown-fix
...
[web] Fix footer layout on the smallest viewport Bootstrap 5
GitOrigin-RevId: 741540ff5e25fe36021d0a2ef2d433dc63ee3650
2024-05-20 08:04:27 +00:00
Eric Mc Sween
dfd1652c35
Merge pull request #18375 from overleaf/em-promisify-chat-api-handler
...
Promisify ChatApiHandler
GitOrigin-RevId: 83cedb14b5e2b187fb2cb02fcbf888ada5a599b1
2024-05-20 08:04:22 +00:00
Antoine Clausse
25d8e053be
[web] Update revokeAllUserSessions
and rename it to removeSessionsFromRedis
( #18360 )
...
* Fix `revokeAllUserSessions` call in `_cleanupUser`
The user object should be passed, not the _id
* Change `revokeAllUserSessions` signature, take `req` and `stayLoggedIn` arguments
* Update uses of `revokeAllUserSessions`
* Fix promisified `revokeAllUserSessions` args
* Update tests
* Destroy or Regenerate the session in the end of `revokeAllUserSessions`
Per https://github.com/overleaf/internal/issues/17036#issuecomment-1938398570
* Revert "Destroy or Regenerate the session in the end of `revokeAllUserSessions`"
This reverts commit fe30734dbe45b27d2931d2e43a711d591bb85787.
* Rename `revokeAllUserSessions` to `removeSessionsFromRedis`
* Fixup tests
* Fix: add optional chaining in `req.sessionID` (!!)
GitOrigin-RevId: d41676bf00f463230af495e09c65fb9ee521f49f
2024-05-20 08:04:12 +00:00
Christopher Hoskin
3342d672c2
Merge pull request #18397 from overleaf/em-revert-download-all-link
...
Revert "Merge pull request #18190 from overleaf/ar-add-download-all-l…
GitOrigin-RevId: 681eb2734636d76558e682dc85083bfcaa6b7d2d
2024-05-17 08:05:10 +00:00
Rebeka Dekany
f652c49713
Merge pull request #18386 from overleaf/rd-footer-pug
...
[web] Migrate the language dropdown in footer to Bootstrap 5
GitOrigin-RevId: 07a37f59914c543ae8d33312aa313451145cd220
2024-05-17 08:05:02 +00:00
Tim Down
97add91248
Merge pull request #18377 from overleaf/td-metrics-page-fix
...
Move Bootstrap and jQuery imports into metricsApp
GitOrigin-RevId: 3ec1690ca60928e983211792f6c6b63548dfe62c
2024-05-16 08:05:35 +00:00
Jakob Ackermann
dfe587f297
Merge pull request #18294 from overleaf/jpa-td-invite-details
...
[web] avoid content reflection via query parameter on register page
GitOrigin-RevId: 43e7ba6069e0d9f3f12e5e9e680b5960b0673782
2024-05-16 08:05:09 +00:00
Andrew Rumble
105d67bd04
Merge pull request #18190 from overleaf/ar-add-download-all-link
...
[web] Add download all link for output files
GitOrigin-RevId: a275f17b6acf3130250d91462ba01588b93b62f5
2024-05-16 08:05:04 +00:00
Tim Down
0886104862
Merge pull request #18276 from overleaf/td-bs5-load-js
...
Load correct JS for the active Bootstrap version, second attempt
GitOrigin-RevId: ad8748a941691d745db5cd3e986e9c7b188b3ecb
2024-05-16 08:04:59 +00:00
M Fahru
5c44fb8e9d
Merge pull request #18281 from overleaf/mf-decaffeinate-server-admin-controller
...
[web][admin panel] Decaf cleanup of AdminController
GitOrigin-RevId: fca50565e140435b833c303d2a0dfac7449c3e17
2024-05-15 08:05:24 +00:00
M Fahru
ec1ab82789
Merge pull request #17479 from overleaf/mf-clean-up-plans-styling
...
[web] Clean up plans page styling
GitOrigin-RevId: fe05e9a1fd6c29c62941c878fe5e676d062c37de
2024-05-15 08:05:20 +00:00
Antoine Clausse
9419cc3b37
[web] Add tests to collect_paypal_past_due_invoice.js
+ update logging ( #18310 )
...
* Fix: Invoices collected array length comparison
Update the code with the correct condition to respect the intent of the previous implementation ("exit with non zero code when no invoicess were processed").
See 5476f39984
However, I'm not sure if erroring when no invoices are collected is actually what we want to do.
* Wrap `collect_paypal_past_due_invoice` script and export the function
* Fixup typo `accoutns`
* Log invoices collection data before throwing
* Add note: `handleAPIError` is silencing the errors
* Create a test on `collect_paypal_past_due_invoice`
* Replace `console.log` by `@overleaf/logger` (bunyan)
Our `console.warn` show up as Errors (in red) in GCP. For example the following is an error in GCP:
```
Errors in attemptInvoiceCollection with id=2693634 OError: Recurly API returned with status code: 400
```
https://github.com/overleaf/internal/blob/5476f39/services/web/scripts/recurly/collect_paypal_past_due_invoice.js#L9
---
Does it correctly set the levels as warnings if we use `@overleaf/logger`
GitOrigin-RevId: 37c8bdf4afd8cef4706700aafb44480ec8966a74
2024-05-15 08:04:46 +00:00
David
6718729087
Merge pull request #18318 from overleaf/dp-revert-secondary-email
...
Revert "Merge pull request #18139 from overleaf/dp-add-secondary-prompt-ui"
GitOrigin-RevId: d8af37a5c332ac21ddd4c85679553df0bda326f9
2024-05-14 08:04:11 +00:00
David
0630e96d49
Merge pull request #18139 from overleaf/dp-add-secondary-prompt-ui
...
Add UI for secondary email prompt
GitOrigin-RevId: 887b2c7f0047f19b605f03745f7dda83926ec70b
2024-05-14 08:04:01 +00:00
Brian Gough
41cb0859db
Merge pull request #18283 from overleaf/bg-session-secret-use-session-secret-in-web
...
replace SECURITY_SESSION_SECRET with SESSION_SECRET in web
GitOrigin-RevId: f6ff5f13cf04e1b59fe44a394a0888af55ae140f
2024-05-14 08:03:57 +00:00
Jakob Ackermann
9ea6b2f8b1
Merge pull request #18252 from overleaf/jpa-refactor-for-flaky-test
...
[web] refactor background job for setting root doc automatically
GitOrigin-RevId: 719c010eb3e5b692908b7a6fea9d8522b9fc01b9
2024-05-09 08:05:23 +00:00
Copybot
9ee7c86b41
Merge pull request #1208 from tgotowik:hotfix-user-create-mail
...
GitOrigin-RevId: 8e4c159513533598b1ad3eb223a4a7033a2ef736
2024-05-09 08:05:19 +00:00
Jessica Lawshe
c6b88085d5
Merge pull request #18188 from overleaf/jel-react-group-invite
...
[web] Migrate team invite to React
GitOrigin-RevId: 32e968c3b512020aef9a396808c73a7b4859e6d1
2024-05-09 08:05:03 +00:00
Antoine Clausse
eca84b9370
Reintroduce compile sampling for analysis ( #18217 )
...
* Revert "Merge pull request #14143 from overleaf/jlm-unsampled-compiles"
This reverts commit 2457977d61756be52db506d7c84531b22a26abe0, reversing
changes made to 3c452b3943c453707aac90d38e7b5b2ea9df0df4.
* Re-add export of `getPercentile` in SplitTestHandler.js
Was previously removed in aa8c0aadec
GitOrigin-RevId: 42c48829e7246a6bdb9dbb2d075638c1eafdf2f0
2024-05-06 08:04:45 +00:00
Jakob Ackermann
9981be0cc1
Merge pull request #18199 from overleaf/jpa-cleanup-redirects
...
[web] cleanup redirects in session when reaching project dashboard
GitOrigin-RevId: aff131ebf68dda059d7d6949563e72834decd894
2024-05-06 08:04:10 +00:00
Alf Eaton
9729befe59
Merge pull request #18170 from overleaf/ae-token-access-page
...
Convert token access page to React
GitOrigin-RevId: d7434f0de395c47a95d00767727fbe9d43f9abca
2024-05-03 08:05:01 +00:00
Jakob Ackermann
4c49841637
Merge pull request #18153 from overleaf/jpa-validate-session-in-store
...
[web] check for redis connection being out of sync in session store
GitOrigin-RevId: c271e88d4e1fbcb0f7a57f4775e8ef88b70b16a8
2024-05-03 08:04:25 +00:00
Jakob Ackermann
0576e02127
Merge pull request #18152 from overleaf/jpa-stricter-session-validation
...
[web] stricter session validation
GitOrigin-RevId: 3ef916318fde7f31e3e3fd0f7082dde7a2975a27
2024-05-03 08:04:20 +00:00
Tim Down
a452e1e8cd
Merge pull request #18195 from overleaf/revert-18120-td-bs5-load-js
...
Revert "Load correct JS for the active Bootstrap version"
GitOrigin-RevId: 7f6e846b5461cfbacec874ed55bba577e414f3a6
2024-05-03 08:04:16 +00:00
Tim Down
56150d9dbc
Load correct JS for the active Bootstrap version ( #18120 )
...
* Load correct JS for the active Bootstrap version
* Tidy up bootstrapVersion declaration
* Add Bootstrap JS to website redesign layout
* FIx error on interstitial subscriptions page
* Remove unnecessary import of jQuery and Bootstrap
* Use global entrypointScripts in bootstrap-js mixin
GitOrigin-RevId: 6b1977354a72dc69008fc0d2e3baec2f28d97f6b
2024-05-03 08:04:07 +00:00
Jessica Lawshe
ae0abd6445
Merge pull request #18159 from overleaf/jel-group-invite-header
...
[web] Break word on group invite header
GitOrigin-RevId: 790c24e8291f1dbdfa9231e4c9e3d4e531bf2b8f
2024-05-02 08:03:52 +00:00
Rebeka Dekany
62c2937dac
Merge pull request #18164 from overleaf/rd-remove-endpoints
...
[web] Remove publicly accessible endpoints
GitOrigin-RevId: c8e57faf6418274cac36b6e721c97a4ca70a1193
2024-05-01 08:04:46 +00:00
Andrew Rumble
9c3d9ef590
Merge pull request #17935 from overleaf/ar-refactor-compile-async
...
[web] make CompileManager async
GitOrigin-RevId: 617bde1f429fa9aafc7d4bf4ec628b2a22386b19
2024-04-30 08:04:43 +00:00
Brian Gough
29105911c5
Merge pull request #17732 from overleaf/bg-session-mitigation-initial-protoype
...
anonymous cookie-based sessions module
GitOrigin-RevId: 75fe2d48fa384ba8d07c0b478a9a5a907a2b3b67
2024-04-26 08:04:54 +00:00
Jakob Ackermann
90a02ebc2f
Merge pull request #17949 from overleaf/jpa-set-nx-xx
...
[web] stricter writes to redis when creating and updating sessions
GitOrigin-RevId: 79723e0d38884bf723c7a2ba32993e4daa2612a0
2024-04-26 08:04:35 +00:00
Antoine Clausse
ede03daafd
Rename test to local-ccy-format-v2
to restart with clean data ( #18115 )
...
GitOrigin-RevId: 610495f41d69f8cac1a427ef7b8d64886bc5cdba
2024-04-26 08:04:26 +00:00
Antoine Clausse
e32b4f0db1
[web] Handle error cause by currencyDisplay: 'narrowSymbol'
in old browsers ( #18060 )
...
* Handle error cause by `currencyDisplay: 'narrowSymbol'` in old browsers
RangeError
Value narrowSymbol out of range for Number.prototype.toLocaleString options property currencyDisplay
* Make `formatCurrencyLocalized` bulletproof
GitOrigin-RevId: 26e8abc6f9fb7c06c2d14b9d86af2d84fb9f32e3
2024-04-26 08:04:22 +00:00
David
c2448ff3d2
Merge pull request #17947 from overleaf/dp-secondary-email-confirmation-code
...
Add endpoints for secondary email confirmation by code
GitOrigin-RevId: c2829672fd9aeca457f76958d4922b9c95086f26
2024-04-26 08:04:00 +00:00
Jessica Lawshe
8d1885cd50
Merge pull request #18073 from overleaf/jel-sso-disabled-email-alert
...
[web] Send SSO disabled email to non-managed and linked users
GitOrigin-RevId: d5e6739efd432b396dcd7fa3dd37e18d2b9dc933
2024-04-25 08:05:30 +00:00
Jessica Lawshe
0b86bc04ad
Merge pull request #18045 from overleaf/jel-user-settings-sso-groups
...
[web] Use `getUserGroupsSSOEnrollmentStatus` helper
GitOrigin-RevId: 4846d513964a63afb620ee2dbb5b810dd0aa4e60
2024-04-25 08:05:22 +00:00
Jessica Lawshe
7e3dfded2d
Merge pull request #17821 from overleaf/jel-subscription-populate
...
[web] Only populate the required admin data for the subscription
GitOrigin-RevId: 4c2de85ce9f26b337deeff491b40d74756f21702
2024-04-25 08:05:03 +00:00
Jessica Lawshe
94e9456a4b
Merge pull request #17793 from overleaf/jel-password-token-when-managed-linked
...
[web] Check permissions when using password reset token
GitOrigin-RevId: b5339d5ad5322fcae7beaa99fb40a87ffb938b52
2024-04-25 08:04:58 +00:00
David
2a725b3a26
Merge pull request #18077 from overleaf/dp-teardown-share-modal-paywall-split-test
...
Tear down project-share-modal-paywall split test
GitOrigin-RevId: b85e6cdf2243a76d071607e55a33f9909f704b76
2024-04-25 08:04:21 +00:00
Jimmy Domagala-Tang
2c11ad84e0
Merge pull request #18071 from overleaf/jdt-bib-events
...
Bibliography events for 3rd party integrations
GitOrigin-RevId: d8d7f4378d75166481d5265d2e8bef72d75968c3
2024-04-24 08:05:11 +00:00
Antoine Clausse
0c4ca15003
[web] Add #main-content
to some pug pages (fix skip-to-content links) ( #18050 )
...
* Add `#main-content` to some pug pages
This fixes our `skip-to-content` accessibility anchor links. Alternatively or additionally, we can set `suppressSkipToContent = true` in some pages: that will remove the anchor link in the page.
While working on this, I noticed that sometimes we still have a bit of extra nesting or components that should maybe be out of `<main>` or `#main-content`. In a future PR we can maybe update these elements to target the "real core content" of the page.
* Add `suppressSkipToContent` in confirm-email page
GitOrigin-RevId: 6cbf4112f2d1a2d8eff06f142d0c2b4f3a5d9cff
2024-04-24 08:04:43 +00:00
Antoine Clausse
2a5dca0897
[web] Fix thousands separators in plan page for LATAM currencies ( #18068 )
...
Use function from https://github.com/overleaf/internal/blob/e486f2fc/services/web/scripts/plan-prices/plans.js#L123-L135
GitOrigin-RevId: e83ea429112c92e07857ee4d3e5fd43c81fcb871
2024-04-24 08:04:39 +00:00
Mathias Jakobsen
5aee58c6f4
Merge pull request #17956 from overleaf/mj-web-promisify-restore-manager
...
[web] Promisify RestoreManager
GitOrigin-RevId: cd3395f8cb7b90e19828297e1c89c1d3850877a6
2024-04-24 08:04:26 +00:00
David
ce00af7838
Merge pull request #18011 from overleaf/dp-make-_getRedirectFromSession-public
...
Make _getRedirectFromSession a public method
GitOrigin-RevId: 6538e4ec25e607d32beb944370d151d4f1a3709c
2024-04-24 08:04:13 +00:00
Alf Eaton
98cefaa5bd
Remove "upgrade to annual" page ( #18014 )
...
GitOrigin-RevId: b9f92ad038adab7fc7eb5e2a7175461bfefee379
2024-04-24 08:04:04 +00:00
Alexandre Bourdin
1336b2daeb
Merge pull request #18058 from overleaf/ab-split-test-convert-race-cond-fix
...
[web] Prevent failure due to race condition where converting anon assignments
GitOrigin-RevId: 81eb16689724b9ddc2ec7e23df2c3ea55837b83c
2024-04-23 08:05:54 +00:00
Jimmy Domagala-Tang
4fcade16cb
Merge pull request #17888 from overleaf/jdt-async-tpr
...
Async Await the third party references module
GitOrigin-RevId: 58bbc4160cf00bf26b2cd2ea81659ba213f95294
2024-04-23 08:05:50 +00:00
Alf Eaton
1f14746111
Remove latex-log-parser split test ( #17999 )
...
GitOrigin-RevId: 5accb0e5fc4c1ecce563f1d6f991de8c8633308b
2024-04-23 08:05:16 +00:00
Alexandre Bourdin
9fc6fa9b77
Merge pull request #18017 from overleaf/ab-convert-assigned-at-date
...
[web] Transform assignedAt back to date for conversion
GitOrigin-RevId: bd0213b337f765d8512386f9f5d3fc6d03572e33
2024-04-23 08:04:52 +00:00
Alexandre Bourdin
3022f573e9
Merge pull request #18022 from overleaf/revert-18018-revert-17906-ab-split-test-assignments-optim-pt2
...
Revert "Revert "[web] Store anonymous users split test assignments in new format in session""
GitOrigin-RevId: bd48a21c17df91eda1536378d8d999a1933e83a2
2024-04-23 08:04:47 +00:00
Davinder Singh
a179751986
Merge pull request #17866 from overleaf/ds-banner-labels
...
Geo Pricing- Update Banner message on Latam america
GitOrigin-RevId: 7a8adf8e31e7ba4bc1b415a26c492bf6e5867328
2024-04-23 08:04:19 +00:00
roo hutton
06cac44d84
Merge pull request #18021 from overleaf/rh-mailchimp-api
...
[web] Replace node-mailchimp with own MailChimpClient
GitOrigin-RevId: 10207620c48f30ad29f4f0e7ea5193c11d256902
2024-04-22 08:04:33 +00:00
roo hutton
9601fd097a
Merge pull request #17946 from overleaf/rh-promisify-third-party-identity-
...
[web] Promisify ThirdPartyIdentityManager and ThirdPartyIdentityManagerTests
GitOrigin-RevId: f7d24f73213fb0a43eb453aa21749b21ba60b83d
2024-04-22 08:04:28 +00:00
Christopher Hoskin
2100cd14fc
Merge pull request #18012 from overleaf/bg-mongo-upgrade-remove-sort-from-project-deactivation-query
...
Simplify query for old projects in InactiveProjectManager
GitOrigin-RevId: 6c712c3b095abec9c777332a07ed888178947b40
2024-04-22 08:03:55 +00:00
Alexandre Bourdin
14bbc65e99
Merge pull request #18018 from overleaf/revert-17906-ab-split-test-assignments-optim-pt2
...
Revert "[web] Store anonymous users split test assignments in new format in session"
GitOrigin-RevId: 2c1a95031a9d1d99b9dfef54eb4b80264a32ba0d
2024-04-19 08:04:27 +00:00
Alexandre Bourdin
bfe75c7d31
Merge pull request #17906 from overleaf/ab-split-test-assignments-optim-pt2
...
[web] Store anonymous users split test assignments in new format in session
GitOrigin-RevId: a5f71f7dcad7e7b11fc6a391bd5182525b3bdf03
2024-04-19 08:04:23 +00:00
Alexandre Bourdin
e4e054e8bb
Merge pull request #18008 from overleaf/ab-fix-anon-assignment-append
...
[web] Fix anonymous assignment append to session
GitOrigin-RevId: 402cd94ec6250e15f0e35cb69af3977c78ec5a7d
2024-04-19 08:04:19 +00:00
Alexandre Bourdin
cdf4f98c87
Merge pull request #17957 from overleaf/ab-archive-test-slack-notif-date
...
[web] Send correct date for Slack notification when archiving a split test
GitOrigin-RevId: acf39915e3362f90b431b6c973e1191428acd9c9
2024-04-19 08:04:15 +00:00
Alexandre Bourdin
bee4c95c28
Merge pull request #17907 from overleaf/ab-split-test-assignments-optim-pt1
...
[web] Read anonymous split test assignments in session from both old&new fields
GitOrigin-RevId: 5235bb3e7d72d5ff9e89c6543b70fb80e9f1213c
2024-04-19 08:04:11 +00:00
Domagoj Kriskovic
945e51b8ed
[web] add Revert File button behind a feature flag ( #17975 )
...
* [web] add Revert File button behind a feature flag
* improve error message
* use constant for timeout
GitOrigin-RevId: 047c35d22e948351c52d469e48b869719f44ec4f
2024-04-19 08:04:06 +00:00
David
0cf17478fe
Merge pull request #17810 from overleaf/dp-compormised-password-prompt
...
Add compromised password prompt
GitOrigin-RevId: 7910a220943fcb3aa191da6d514d5bc3ae20f5a3
2024-04-19 08:03:58 +00:00
Antoine Clausse
b2ef7a935f
[web] Use localized number formatting for currencies ( #17622 )
...
* Add a unit test on `SubscriptionFormatters.formatPrice`
* Add JSDoc to `formatPrice`
Also: Name the functions before exporting:
This fixes my IDE (WebStorm) navigation
* Make `'USD'` the default param instead of reassigning
* Create `formatCurrency` function
* Use `formatCurrency` in SubscriptionFormatters
* Use an `isNoCentsCurrency` logic for `CLP` `JPY` `KRW` `VND`
And remove custom `CLP` logic and locale
* Add `locale` param to `formatPrice`
* Generate `groups.json` and `localizedPlanPricing.json`
```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```
* Update scripts/plan-prices/plans.js to generate numbers instead of localized amounts
* Generate `groups.json` and `localizedPlanPricing.json`
```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```
* Remove generation of `plans.json`
As /services/web/frontend/js/main/plans.js was removed in https://github.com/overleaf/internal/pull/12593
* Sort currencies in alphabetical order in scripts/plan-prices/plans.js
* Generate `groups.json` and `localizedPlanPricing.json`
```
bin/exec web node ./scripts/recurly/recurly_prices.js --download -o prices.json
bin/exec web node ./scripts/plan-prices/plans.js -f ../../prices.json -o dir
```
* Use `formatCurrency` in price-summary.tsx
* Use `formatCurrency` in Subscription Pug files
* Fix unit tests SubscriptionHelperTests.js
* Remove unused `currencySymbol`
* Change to `formatCurrency` in other React components
* Add `CurrencyCode` JSDoc types
* Duplicate `formatCurrency` into services/web/app/src/util
* Wrap tests in a top-level describe block
* Use `narrowSymbol`
* Fix tests with `narrowSymbol` expects
* Revert deletion of old `formatPrice` in SubscriptionFormatters.js
* Rename `formatCurrency` -> `formatCurrencyLocalized`
* Revert deletion of `CurrencySymbol`
* Add split-test in SubscriptionController.js
* Add split-test in SubscriptionViewModelBuilder.js
* Add split-test in plans
* Add split-test in subscription-dashboard-context.tsx
* Add split-test in 4 more components
* Update tests
* Show currency and payment methods in interstitial page
* Fix `–` being printed. Use `–` instead
* Fix test with NOK
* Storybook: Fix missing `SplitTestProvider`
* Storybook: Revert "Remove unused `currencySymbol`"
This reverts commit e55387d4753f97bbf8e39e0fdc3ad17312122aaa.
* Replace `getSplitTestVariant` by `useSplitTestContext`
* Use parameterize currencyFormat in `generateInitialLocalizedGroupPrice`
* Fixup import paths of `formatCurrencyLocalized`
* Replace `% 1 === 0` by `Number.isInteger`
* Add comment explaining that any combinations of languages/currencies could happen
* Fixup after rebase: import `useSplitTestContext`
* Revert "Remove SplitTestProvider from subscription root"
This reverts commit be9f378fda715b86589ab0759737581c72321d87.
* Revert "Remove split test provider from some tests"
This reverts commit 985522932b550cfd38fa6a4f4c3d2ebaee6ff7df.
GitOrigin-RevId: 59a83cbbe0f7cc7e45f189c654e23fcf9bfa37af
2024-04-19 08:03:54 +00:00
Antoine Clausse
76955c814a
Remove subscription-cancel-button
( #17976 )
...
I believe this was already removed since https://github.com/overleaf/internal/pull/13311
GitOrigin-RevId: e486f2fce794fc9d587da331547834c3b6158ceb
2024-04-19 08:03:49 +00:00
Thomas
52e6ceef67
Merge pull request #17898 from overleaf/tm-remove-twitter-login
...
Remove twitter login code and uninstall passport-twitter
GitOrigin-RevId: 928c877ef2a42d5881652cad7f9d563c7766fd36
2024-04-18 08:04:16 +00:00
roo hutton
d53a3e315e
Merge pull request #17879 from overleaf/rh-refresh-collab
...
Refresh websocket on collaborator change
GitOrigin-RevId: b05444d592f5952a08bad51c9f529ed9183d042f
2024-04-17 08:05:18 +00:00
Alf Eaton
4a68a5f8bc
Discontinue the bonus program ( #17919 )
...
GitOrigin-RevId: d30ace08a340dd17a68c3cfe82e589bb37b5959f
2024-04-17 08:04:58 +00:00
Antoine Clausse
616bd0df16
Merge pull request #17925 from overleaf/jpa-ac-20s-timeout-migration-logging-tweaks
...
[web] timeout 20s split-test teardown cleanups (remove override, remove tests, ...)
GitOrigin-RevId: 8d8c44539cf45d0f5142f84cf8372cecda3bf77a
2024-04-17 08:04:30 +00:00
Jakob Ackermann
ac2ea9f34d
Merge pull request #17865 from overleaf/jpa-open-in-overleaf-session-storage
...
[web] open-in-overleaf: cleanup redis and browser session storage
GitOrigin-RevId: af79bb49ff474545fc0d206d2a6f5a0ffa1416bc
2024-04-17 08:04:04 +00:00
Antoine Clausse
d35204033f
Merge pull request #17909 from overleaf/ac-tear-down-compile-timeout-tests-2
...
[web] Remove split-tests `compile-backend-class*` and `compile-timeout-20s*` (attempt 2)
GitOrigin-RevId: 5658f2977d3e7089eec5bbe7a33eee81c153e41d
2024-04-16 08:04:08 +00:00
Torben
78bd986d0e
Since the creation of the user happens asynchronously, the node process dies before it has created the user or sent the mail.
2024-04-15 14:45:40 +02:00
Alexandre Bourdin
5f8db6ee23
Merge pull request #17799 from overleaf/ab-account-deletion-audit-log
...
[web] Add audit log when user account is deleted or recovered
GitOrigin-RevId: 3d5f99705fbd6192ccae430e040be4b7fcb3f740
2024-04-15 08:04:42 +00:00
Antoine Clausse
491bc2628d
Merge pull request #17899 from overleaf/revert-17700-ac-tear-down-compile-timeout-tests
...
Revert "[web] Remove split-tests `compile-backend-class*` and `compile-timeout-20s*`"
GitOrigin-RevId: d5070ced06adbd435e782a44b7ef767e395bd6a0
2024-04-15 08:04:37 +00:00
Antoine Clausse
2dd10c7fee
[web] Remove split-tests compile-backend-class*
and compile-timeout-20s*
( #17700 )
...
* Remove split-tests of `compile-timeout-20s` and `compile-timeout-20s-existing-users`
* Remove `NEW_COMPILE_TIMEOUT_ENFORCED_CUTOFF` variables
* Revert timeout override `60` -> `20`
* Update settings.overrides.saas.js: `compileTimeout: 20`
* Remove `compile-backend-class-n2d`
* Remove `force_new_compile_timeout`
* Remove `showNewCompileTimeoutUI`
* Remove `compileTimeChanging`
* Simplify code by removing segmentation object
* Remove `CompileTimeoutChangingSoon`
* Remove `user.features.compileTimeout = '20 (with 10s prompt)'`
* Remove `CompileTimeWarning`
* Remove `TimeoutUpgradePrompt` (old)
* Remove `compile-backend-class`
* Remove unused translations
* Update tests
* Fix: Show `CompileTimeout` even if `!window.ExposedSettings.enableSubscriptions`
* Create script to migrate users to 20s compileTimeout
* migration script: exclude `compileTimeout: 20` from the match
* migration script: use `batchedUpdate`
* Remove `showFasterCompilesFeedbackUI` and `FasterCompilesFeedback`
Helped-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
* Remove `_getCompileBackendClassDetails`, simplify definition of `limits` object
* Remove `Settings.apis.clsi.defaultBackendClass`
* Remove unnecessary second scan of the whole user collection in dry mode
* Override `timeout` to 20 for users having `compileGroup === 'standard' && compileTimeout <= 60`
* Remove second `logCount`: re-run the script in dry-mode if you want to see that count
* Use secondary readPreference when counting users
* Fix script setup and exit 0
* Fix: Remove `user.` from query path!
* Add acceptance test on script migration_compile_timeout_60s_to_20s.js
GitOrigin-RevId: 3cb65130e6d7fbd9c54005f4c213066d0473e9d8
2024-04-15 08:04:24 +00:00
roo hutton
03fb015f8f
Merge pull request #17856 from overleaf/rh-deletion-email-update
...
[web] Use securityAlert template for user deletion email
GitOrigin-RevId: 60dfef18946710f5d5df17daca1a0bdc9800519b
2024-04-12 08:06:40 +00:00
roo hutton
754609f379
Merge pull request #17830 from overleaf/rh-reduce-staff-access-session
...
[web] Reduce size of staffAccess field in session
GitOrigin-RevId: 7745dc595e8096caef04fd140b47532f0775f165
2024-04-12 08:06:35 +00:00
Jessica Lawshe
955c860b64
Merge pull request #17841 from overleaf/jel-lint-populate
...
[web] Add linting rule for mongoose `populate`
GitOrigin-RevId: 625b2b5f9db4e88ce0d629752f083b8be71c7766
2024-04-12 08:06:18 +00:00
Jessica Lawshe
0cfcdf5e4d
Merge pull request #17822 from overleaf/jel-dash-usersBestSubscription
...
[web] Limit data sent to dash for best subscription when group
GitOrigin-RevId: d52101bec69cbb7931e9702e085b4aeb65d9d603
2024-04-12 08:06:09 +00:00
Jessica Lawshe
751e079105
Merge pull request #17817 from overleaf/jel-group-subscription-page
...
[web] Only send necesssary group subscription data to frontened
GitOrigin-RevId: bf49245e573bb9a1ec4bafc85cc6d0b7fd5f3e6f
2024-04-12 08:06:04 +00:00
Jakob Ackermann
ea0a99253c
Merge pull request #17864 from overleaf/jpa-fix-redirect
...
[web] fix navigation flow after try premium page when using skip button
GitOrigin-RevId: 1ae7ccdb14f7125919bc97746761a21c6896938f
2024-04-12 08:05:15 +00:00
Tim Down
a345eb42c2
Merge pull request #17712 from overleaf/td-bs5-feature-flag
...
Add feature flag check and per-page opt-in for Bootstrap 5
GitOrigin-RevId: 111474c19f0202efc4e701eef597c7653f8e8b61
2024-04-12 08:05:10 +00:00
David
ce5d190c4a
Merge pull request #17833 from overleaf/dp-add-secondary-prompt
...
Update primary email check form to match new designs
GitOrigin-RevId: b740255e3615bd7807845c533472aabb263d69ea
2024-04-11 08:04:20 +00:00
roo hutton
bf7a18db8b
Merge pull request #17730 from overleaf/rh-acct-delete-email
...
[web] Send email notification on account deletion
GitOrigin-RevId: 03c0effba0ee3b829f5b4fe377fe67d05776ba3f
2024-04-10 08:04:12 +00:00
Domagoj Kriskovic
8bde496da4
Send operations to project-history when resolving/unresolving comments ( #17540 )
...
* Send operations to project-history when resolving/unresolving comments
* small fixes
* added doc_id in web unit test
* Revert "added doc_id in web unit test"
This reverts commit f0b8251abfce17965d5e1b0e45d8784fcf1d9eed.
* fix mocked dependency in test
* wip: web unit tests
* document updater, reopen test
* document-updater tests
* format fix
* fix typo
* fix callsArgWith
* fix reopenThread calls in doc updater tests
* fix typos
* log error if chat api resolve failes
* log error when reopening thread
* sendStatus calls done() in tests
* using OError instead of logging
* removed timers
* preserve legacy endpoints
* update after merge
* Remove timer check in HttpControllerTest
* prettier
* added "legacy" in log
* remove metrics.timer
* fix promisify issues
* remove unused cb
GitOrigin-RevId: 849538c86996973a065c727835e93028e5429344
2024-04-10 08:04:08 +00:00
Davinder Singh
2ba92141ee
Merge pull request #17719 from overleaf/ds-latam-pricing-web-config
...
Latam Geo Pricing V2 - Updating Web configurations file for new prices
GitOrigin-RevId: 0cd7abc565e971dd68f0860f00ea2ed8c1e713f8
2024-04-09 08:04:10 +00:00
Davinder Singh
998d55d159
Merge pull request #17559 from overleaf/ds-latam-v2
...
LATAM Geo Pricing - Introducing split test in LATAM countries Round 2
GitOrigin-RevId: 76ab880262f126f8db7f8e577154d78b5e9abf7a
2024-04-09 08:04:06 +00:00
M Fahru
9e318f24ff
Merge pull request #17594 from overleaf/mf-website-redesign-register
...
[web] Website redesign for register page
GitOrigin-RevId: a8ae7327b1d662cb442e44992c5e2676a23cca3e
2024-04-08 08:04:33 +00:00
roo hutton
8644e239c6
Merge pull request #17596 from overleaf/rh-permissions-policy
...
[web] Add Permissions-Policy header
GitOrigin-RevId: 8934bbbda411102580d9ef8af135dcdc147627f9
2024-04-08 08:04:29 +00:00
roo hutton
67e9a40e87
Merge pull request #17680 from overleaf/rh-promisify-templates-man
...
[web] Promisify TemplatesManager and TemplatesManagerTests
GitOrigin-RevId: 69ff0a5f34ceb7b4c23452bb00963eda35621f3f
2024-04-08 08:04:25 +00:00
David
bedc54e632
Merge pull request #17734 from overleaf/dp-privacy-policy-link
...
Add privacy notice link to registration smallprint
GitOrigin-RevId: 893363b86753b7464f36620cde1952e2b6644a5f
2024-04-08 08:04:08 +00:00
David
b1928cecef
Merge pull request #17530 from overleaf/dp-teardown-onboarding-flow-split-test
...
Teardown onboarding flow split test
GitOrigin-RevId: 48e95e4e736772074cb68d195fc950a9da3aebcf
2024-04-08 08:04:04 +00:00
M Fahru
eaea8a4979
[web] Implement new notification style for homepage registration form ( #17695 )
...
The new notification style is implemented as a separate function (pug mixin), so in order to update all of our forms, we need to explicitly change the function call in the other pug templates. This way, we can update all the other forms with the new notification style gradually.
GitOrigin-RevId: 78b755468e3e70f08500bdfb6280fa79853c3ed1
2024-04-05 08:04:18 +00:00
Domagoj Kriskovic
b3d2d73136
Add externalUserId in ThirdPartyIdentityExistsError info ( #17709 )
...
* Add externalUserId in ThirdPartyIdentityExistsError info
* format fix
GitOrigin-RevId: 85370987ff7a9caa54102bf9013ebc655a2d383b
2024-04-04 08:03:54 +00:00
Antoine Clausse
92a58c8f3b
[web] Paywall CTA split-test ( #17555 )
...
* Fix `{splitTest.requiredCohortSize && (...)}` can display `0`
* Get `paywall-cta` assignment in ProjectController.js
* CTA change: "Get Dropbox Sync"
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286026
* CTA change: "Get GitHub Sync"
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736
* CTA change: "Get Git integration"
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286283
* CTA change: "Add more collaborators"
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763884855
* CTA change: "Get track changes"
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764030761
* Update wording and position: "Already subscribed? Try refreshing the page."
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764366969
* Casing update: "Upgrade to track changes"
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764209961
* CTA changes: "Get Mendeley integration" + "Get Zotero integration"
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547424
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764547269
* CTA change: "Get full project history"
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762005
* Casing update: "full project history"
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762280
* CTA change: "Get more compile time" in timeout-upgrade-prompt-new.tsx
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563
* CTA change: "Get more compile time" in compile-timeout-warning.tsx
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762726
* CTA change: "Get advanced reference search"
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969087
* Update casing and wording: "advanced reference search"
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764969412
* CTA change: "Get Symbol Palette"
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765128906
* Update title: "Subscribe to find the symbols you need faster"
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578765289664
* Revert use of `satisfies`: it doesn't work with our version of prettier (https://github.com/prettier/prettier/issues/13516 )
* CTA change: "Get more compile time" in compile-timeout-changing-soon.tsx
⚠️ not in miro
* Rename `paywallCtaAssignment`, remove useless export and comment
Addressing Fahru's review
* Add alternative texts in `/registration/try-premium` page
* CTA change: "Get more compile time" in timeout-upgrade-prompt.jsx
https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578764762563
* CTA change: "Get GitHub Sync" in import-project-from-github-modal-content.tsx
Not in Miro, but related to: https://miro.com/app/board/uXjVMFLu5J8=/?openComment=3458764578763286736
* CTA change: "Get more compile time" in compile-time-warning.tsx
Not in Miro, but related to others
* Fix compile-time-warning style (spacings, overflows out of window)
* `npm run format:fix`
GitOrigin-RevId: 0d8d1808b5901c2761d35494c49713d26721bcfd
2024-04-03 08:04:16 +00:00
Brian Gough
cdf31ed91c
Merge pull request #17675 from overleaf/bg-session-mitigation-redis-store-metrics
...
add CustomSessionStore class to handle session metrics and logging
GitOrigin-RevId: 49d4cda9fd94a8801adb33e894be239dc38ad544
2024-04-03 08:03:55 +00:00
M Fahru
d836631902
Merge pull request #17548 from overleaf/mf-promisify-render-set-password-form
...
[web] promisify renderSetPasswordForm
GitOrigin-RevId: 3a79a7fd23de2d7ff87a833204298aed6cc303a5
2024-03-29 09:04:26 +00:00
Mathias Jakobsen
192c497508
Merge pull request #17671 from overleaf/mj-project-projection
...
[web] Use projection when fetching project
GitOrigin-RevId: 4c7eb6582dba9ffa81f8d34c4e353faf1dc15c83
2024-03-29 09:04:13 +00:00
Mathias Jakobsen
48f8fe9dd6
[web] Add current history tab to admin panel ( #17482 )
...
* [web] Add current history tab to admin panel
GitOrigin-RevId: 95a479d01bdf2ca65cd9b18077823d895cc12501
2024-03-29 09:04:02 +00:00
Jessica Lawshe
3437ddb203
Merge pull request #17592 from overleaf/jel-sso-enrollment-page
...
[web] Return 403 on group SSO enrollment page if group does not have feature
GitOrigin-RevId: ce6bbf69da2ff332ffa541f8febf8fb298ea743a
2024-03-28 09:04:49 +00:00
Rebeka Dekany
8dd5b2574e
Merge pull request #16261 from overleaf/rd-rate-limiter
...
[web] Add rate limits for subscription requests
GitOrigin-RevId: 3cfdb80713c96d32f7d297f38ec306e2bf6ec9a6
2024-03-28 09:04:06 +00:00
Mathias Jakobsen
44d0b947ce
Merge pull request #17553 from overleaf/mj-admin-history-ranges-enable
...
[web] Add button for adding history ranges support in admin panel
GitOrigin-RevId: fa85b25719fff753f0d0806ccb02ad2f9db2ee82
2024-03-28 09:03:51 +00:00
M Fahru
b874d932c2
Merge pull request #17258 from overleaf/mf-fix-active-state-persisted-navbar-toggle
...
[web] Fix navbar toggle persisted active state on mobile
GitOrigin-RevId: 46e6962bc5ff003fd131419b94d7a04df3b619c6
2024-03-26 09:04:44 +00:00
David
6fef715316
Merge pull request #17611 from overleaf/dp-unlink-sso-script
...
Add script to unlink a third party identifier
GitOrigin-RevId: ded0672121fdf8c6cf30f94580f4491af9321dd7
2024-03-26 09:04:40 +00:00
Alf Eaton
6cc2db3cdd
Merge pull request #17525 from overleaf/ae-upgrade-prettier
...
Upgrade Prettier to v3
GitOrigin-RevId: 6f1338f196408f3edb4892d5220ad3665ff1a5bc
2024-03-26 09:04:05 +00:00
Brian Gough
f2a1b49d48
Merge pull request #17593 from overleaf/bg-account-security-update-hibp-links
...
Update haveibeenpwnd links to use the password check form
GitOrigin-RevId: f67b1ed689c851ad3684becc38cd5eb82b0018a2
2024-03-22 09:03:13 +00:00
Thomas
8a04ec9b75
Merge pull request #17572 from overleaf/tm-email-confirmation-require-login
...
Prevent email confirmation unless logged in to the requesting account
GitOrigin-RevId: 28af875b2887b8bbef8327097635aa01345c682c
2024-03-22 09:03:10 +00:00
Thomas
811173d32d
Merge pull request #17569 from overleaf/tm-account-suspension
...
Add the ability to suspend user accounts
GitOrigin-RevId: 5e57f29941434c78a47354baca83527213f9b9b5
2024-03-22 09:03:06 +00:00
David
3ca09c07a1
Merge pull request #17508 from overleaf/dp-ac-ieee-deprecation-notifications
...
Update notifications for IEEE Retirement
GitOrigin-RevId: f4e02e5fd838c2b1a6227c86f48bb12dd6bdb9a3
2024-03-18 09:04:32 +00:00
Jessica Lawshe
408e1dccd7
Merge pull request #17436 from overleaf/ab-split-test-export-cleanup
...
[web] Fix the split test export format and prune unwanted info
GitOrigin-RevId: 2a8ecbd738338c16fee4bf1d286e724cc25c0008
2024-03-14 09:04:59 +00:00
Jessica Lawshe
310cbe10ba
Merge pull request #17434 from overleaf/ab-allow-analytics-inactive-test
...
[web] Allow analytics to be enabled for inactive tests
GitOrigin-RevId: f854fd6532357c4291f2785b950eac2478cfbae0
2024-03-14 09:04:54 +00:00
Jessica Lawshe
8d4766f5fa
Merge pull request #17234 from overleaf/jel-clear-saml-data
...
[web] Clear linking data for all linked users in group
GitOrigin-RevId: 1b7b3642a37a33c8b1499aee9c98300551bccea0
2024-03-14 09:04:42 +00:00
Brian Gough
8484ae75c7
Merge pull request #17537 from overleaf/bg-session-mitigation-log-session-size
...
Add custom session store to track largest session sizes for anonymous users
GitOrigin-RevId: 23312689d7adb8196e66bb925afcfef78c4c558d
2024-03-13 09:03:44 +00:00
Jimmy Domagala-Tang
5701a1cccd
Merge pull request #17369 from overleaf/jdt-rm-old-wf-prj-list-ad
...
removing old writefull ad from project list and removing uneeded spli…
GitOrigin-RevId: 84722949c4972ba0b7c8e0bf6d2884608e26a613
2024-03-13 09:03:26 +00:00
Domagoj Kriskovic
3e701f1388
Send operations to project-history when deleting comments ( #17198 ) ( #17494 )
...
* Make Operation.fromRaw parse AddComment operations
* Send operations to project-history when deleting comments
* remove RedisManager.updateDocument call
* format fix
* Revert "remove RedisManager.updateDocument call"
This reverts commit 5d45f34b5919bf5a85e8475e5a450bcb213d3f82.
* remove versions from deleteComment op
* pass userId to deleteComment operation
* revert userId from chat service
* revert userid from chat tests
* format:fix
* document updater fix tests
* format:fix
* fix web unit test
* deleteThread test fix
* send only if historyRangesSupport is true
* use headers to pass userId
* set historyRangesSupport in tests
* optional headers
* Revert "use headers to pass userId"
This reverts commit e916c469f95b1ac166e30e12e735171eb814af01.
---------
Co-authored-by: Eric Mc Sween <5454374+emcsween@users.noreply.github.com>
GitOrigin-RevId: 14c10669e43d76883dbaaa8ab55e102b5ebadd38
2024-03-12 09:03:55 +00:00
Jessica Lawshe
d65bba566c
Merge pull request #17315 from overleaf/ab-accounts-settings-sso-status
...
[web] Show Group SSO linking status on the account settings page
GitOrigin-RevId: ae45e1bd7a90a672c5fb023e7f3e603a00e364e5
2024-03-12 09:03:43 +00:00
Jessica Lawshe
814ee0ac62
Merge pull request #17351 from overleaf/jel-async-getUserForPasswordResetToken
...
[web] Promisify getUserForPasswordResetToken
GitOrigin-RevId: 4b0363b390af155f1bae4332fba7cf10c130e1c6
2024-03-12 09:03:35 +00:00
Jessica Lawshe
7a9c2fd644
Merge pull request #17329 from overleaf/jel-async-peekValueFromToken
...
[web] Promisify peekValueFromToken
GitOrigin-RevId: 4a7f6ae793ff0a1bd22c89c963881ef0957e29e8
2024-03-12 09:03:32 +00:00
Jessica Lawshe
b2b100d485
Merge pull request #17090 from overleaf/jel-block-password-reset
...
[web] Block password reset request for managed users linked to SSO
GitOrigin-RevId: 9c990d9fcb7a3286fee733e0fd61c06c09d79367
2024-03-12 09:03:29 +00:00
Miguel Serrano
02d890ef18
Merge pull request #17426 from overleaf/msm-expressify-controllers
...
[web] Expressify controller methods
GitOrigin-RevId: 9784176b53a89beed09f9b38915872a6e7fae465
2024-03-12 09:03:26 +00:00
Miguel Serrano
d2cfa26807
Merge pull request #17418 from overleaf/msm-expressify-usermembershipctlr
...
[web] expressify UserMembershipController
GitOrigin-RevId: 54f8d718bffb52609f055490f2a996f6c007f472
2024-03-12 09:03:20 +00:00
David
1ba5b27e57
Merge pull request #17408 from overleaf/dp-mongoose-callback-autherntication-manager
...
Promisify AuthenticationManager and AuthenticationManagerTests
GitOrigin-RevId: 8120bf55d19380a6ecf5241ffab8722eff2d4fe3
2024-03-12 09:03:14 +00:00
Domagoj Kriskovic
f5b894bc2e
Revert "Send operations to project-history when deleting comments ( #17198 )" ( #17476 )
...
This reverts commit 34ab7e4ea6dd1b5fd749f9accaf4a6e16ae1d840.
GitOrigin-RevId: 005de52bcacbacf62d22cd8617d7a765f56bd72e
2024-03-11 09:04:29 +00:00
Domagoj Kriskovic
4a3a0752a4
Send operations to project-history when deleting comments ( #17198 )
...
* Make Operation.fromRaw parse AddComment operations
* Send operations to project-history when deleting comments
* remove RedisManager.updateDocument call
* format fix
* Revert "remove RedisManager.updateDocument call"
This reverts commit 5d45f34b5919bf5a85e8475e5a450bcb213d3f82.
* remove versions from deleteComment op
* pass userId to deleteComment operation
* revert userId from chat service
* revert userid from chat tests
* format:fix
* document updater fix tests
* format:fix
* fix web unit test
* deleteThread test fix
* send only if historyRangesSupport is true
* use headers to pass userId
* set historyRangesSupport in tests
* optional headers
* Revert "use headers to pass userId"
This reverts commit e916c469f95b1ac166e30e12e735171eb814af01.
---------
Co-authored-by: Eric Mc Sween <5454374+emcsween@users.noreply.github.com>
GitOrigin-RevId: 34ab7e4ea6dd1b5fd749f9accaf4a6e16ae1d840
2024-03-11 09:04:24 +00:00
Miguel Serrano
cf227e2d08
Merge pull request #17450 from overleaf/msm-fix-sp-welcome-page
...
[web] Make wiki and template links configurable in welcome page
GitOrigin-RevId: fab1b8a11f518c5907a5bfa9365ff8e8a130b7c6
2024-03-07 16:30:42 +00:00
Jakob Ackermann
1a6ac06bed
Merge pull request #17432 from overleaf/jpa-wf-switch-split-test
...
[web] fully adopt writefull-oauth-promotion split-test
GitOrigin-RevId: b37491bc18e7cc65ec2fc8e8ced140df9f8a6048
2024-03-06 17:27:52 +00:00
Jakob Ackermann
5415aafaf8
Merge pull request #17353 from overleaf/jdt-wf-oauth-tutorial
...
Writefull Oauth banner
GitOrigin-RevId: cdd8d27b70c9c0f5be326f6861a7c997ca81616e
2024-03-06 17:27:46 +00:00
David
43007539a0
Merge pull request #17380 from overleaf/dp-mongoose-callback-toke-access-handler
...
Promisify TokenAccessHandler and TokenAccessHandlerTests
GitOrigin-RevId: 835081e78977456a59b7e16043fd6dcbdbce3ade
2024-03-06 17:27:40 +00:00
Davinder Singh
511ad1b68f
Adding BRL geo pricing ( #17164 )
...
* BRL geo pricing banners and modals
* format:fix
GitOrigin-RevId: 478435764230e7fea3c8f26e5747562698f78228
2024-03-06 17:27:18 +00:00
Jakob Ackermann
9daacea6cb
Merge pull request #17409 from overleaf/jpa-check-before-hibp
...
[web] check user password before HIBP check
GitOrigin-RevId: 7c1bdc220fb9369733a1ff3bf26bed8cacc8e8d4
2024-03-05 09:03:46 +00:00
Jakob Ackermann
84a2b25a3c
Merge pull request #17401 from overleaf/jpa-skip-hibp-known-device
...
[web] skip HIBP check from known devices
GitOrigin-RevId: 897df02492aafeac010753c7c306e02bde5b1fd8
2024-03-05 09:03:37 +00:00
Jakob Ackermann
001af76f15
Merge pull request #17399 from overleaf/jpa-hibp-login
...
[web] check HIBP on login
GitOrigin-RevId: e052926e4d970f9a15821f1ea9c8af46bdab90cb
2024-03-05 09:03:34 +00:00
David
857a45edeb
Merge pull request #17171 from overleaf/dp-mongoose-callback-project-collabratec
...
Promisify ProjectCollabratecDetailsHandler and ProjectCollabratecDetailsHandlerTest
GitOrigin-RevId: efd911dcbba58f706adfd3b7a5c043280f6cc1af
2024-03-05 09:03:22 +00:00
David
db1508be69
Merge pull request #17075 from overleaf/dp-mongoose-callback-subscription-group-handler
...
Promisify SubscriptionGroupHandler and SubscriptionGroupHandlerTests
GitOrigin-RevId: 998ebb56f9cffe59f7cb490220bccbeedb133a7b
2024-03-05 09:03:19 +00:00
David
6551aba1a5
Merge pull request #17005 from overleaf/dp-mongoose-callback-subscription-handler
...
Promisify SubscriptionHandler and SubscriptionHandlerTests
GitOrigin-RevId: b34328ee2cca4449a02723a587a1bfb887ed847a
2024-03-05 09:03:15 +00:00
M Fahru
920e86e4d0
Merge pull request #17303 from overleaf/mf-fix-plans-page-mobile
...
[web] Fix plans page table styling on both desktop and mobile
GitOrigin-RevId: 252bbaf7245751b1cfe07286a0fe19069219bb5b
2024-03-04 09:04:08 +00:00
M Fahru
5a8a0fb268
Tear down annual-trials
split test:
...
- Use the `default` variant as the winner
- Remove all `annual-trials`-related code
GitOrigin-RevId: 3956f256157f3e86c99e41eec54ef6fd0da39bc3
2024-03-01 09:03:24 +00:00
Jessica Lawshe
cb3f70f7ab
Merge pull request #17289 from overleaf/jel-permissions-controller
...
[web] Move user permissions check to manager
GitOrigin-RevId: 8c59d053da3d8d452cd424b04baa05f5d7d9057a
2024-02-29 09:04:37 +00:00
David
84c3dc1fff
Merge pull request #17268 from overleaf/dp-remove-old-mongo-metrics
...
Remove timeAsyncMethod mongo metrics
GitOrigin-RevId: 1ba3a1fd51b9d0766355c31791ae9836d832afe8
2024-02-29 09:04:19 +00:00
David
6d99f6dfae
Merge pull request #17201 from overleaf/dp-ip-rate-limit
...
Add subnet rate limiter for login rate limit
GitOrigin-RevId: c9f68829887dbc1778eff3b465dbde40bc2073d8
2024-02-29 09:04:15 +00:00
David
3c98e028f5
Merge pull request #17206 from overleaf/dp-mongoose-callback-institutions-manager
...
Promisify InsitutionsManager and InstitutionsManagerTests
GitOrigin-RevId: 0872aabb646ee143f51a92608f91d7901723ec0c
2024-02-29 09:04:11 +00:00
David
6a96e160d9
Merge pull request #17079 from overleaf/dp-mongoose-callback-subscription-locator
...
Promisify SubscriptionLocator and SubscriptionLocatorTests
GitOrigin-RevId: 9956a72d0cd94cb0b89da0fc1ec9c0e06fdcfeea
2024-02-29 09:04:07 +00:00
David
0827139e48
Merge pull request #17155 from overleaf/dp-mongoose-callback-user-registration-handler
...
Promisify UserRegistrationHandler and UserRegistrationHandlerTests
GitOrigin-RevId: b561f5574883b016824077e971aa4613b44a42dd
2024-02-29 09:04:03 +00:00
Jakob Ackermann
642eea2de6
Merge pull request #17318 from overleaf/jpa-create-tokens-first
...
[web] create link-sharing tokens before enabling link-sharing
GitOrigin-RevId: 19a72d57623421681f0de3193572b916a5adeaa9
2024-02-27 17:02:37 +00:00
ilkin-overleaf
b04247dd5a
Merge pull request #17023 from overleaf/ii-token-access-null-values
...
[web] Fix projects token access values
GitOrigin-RevId: f0c6a4993e42320c06753cb65198138afe55b71a
2024-02-26 09:03:13 +00:00
Miguel Serrano
f4454cfe7e
[web] Make SamlLogHandler.log() calls asynchronous ( #17207 )
...
* [web] Refactor exports in ErrorController
* [web] Make SamlLogHandler.log() async
* [web] await for SamlLogHandler.log() in ErrorController
* [web] await for SamlLogHandler.log() in SAMLMiddleware
* [web] await for SamlLogHandler.log() async controllers
* [web] await for SamlLogHandler.log() in SAMLManager
* [web] Remove explicit wait when testing SAML logs
After making the logs asynchronouse the wait
is no longer needed
* [web] Avoid using async with SamlLogHandler.log on callbacks
* Add expressifyErrorHandler to promise-utils
* Tighten assertion in SAMLMiddlewareTests
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
* Updated SamlLogHandler.log to await for promise
---------
Co-authored-by: Jakob Ackermann <jakob.ackermann@overleaf.com>
GitOrigin-RevId: 3645923fae8096a9ba25dc9087f1a36231528569
2024-02-23 09:03:14 +00:00
Brian Gough
c8cc34377f
Merge pull request #17004 from overleaf/bg-mongoose-mongo-compatibility
...
Ensure Mongoose and mongodb modules use the same mongodb instance
GitOrigin-RevId: fb55f3dfcff73919a4c5d26a354ba7c55b1e63c1
2024-02-23 09:03:00 +00:00