Antoine Clausse
3d5418611b
Add an ESLint rule enforcing kebab-case in URL paths ( #18913 )
...
* Add a tsconfig.json to the eslint-plugin folder so it can be linted too
* Create eslint rule `prefer-kebab-url`
* Add prefer-kebab-url to service/web
* Ignore lowercased strings
Prevents from trying to change `v0` to `v-0`
* Ignore parts between brackets or parenthesis
* Record in URL paths by case
lower: 241
kebab: 60
snake: 43
camel: 22
other: 5
* Revert "Record in URL paths by case"
This reverts commit 262f483aafb0daa1a01e9025488cdc33f31ef67c.
* Showcase how the autofix would change the code
* Revert "Showcase how the autofix would change the code"
This reverts commit f045292bf01623de2df5b89fc0d68737a39913dc.
* Add ignored words so we don't have to update old code
* Change the rule so it suggests instead of fixing
This prevents eslint autofix from creating bugs
* Move list of ignored words to its own file
Per https://github.com/overleaf/internal/pull/18913#discussion_r1644204034
* Add comment explaining the ignore list
GitOrigin-RevId: d13918b0bcba9d77120f1b61b354a79dc8fb4b4e
2024-06-24 12:04:26 +00:00
Antoine Clausse
2c7df10b9a
[web] Refactor ProjectController.loadEditor p-props promises ( #18823 )
...
* Move unawaited promises out of `p-props`: `User.updateOne`
* Move unawaited promises out of `p-props`: `sessionMaintenance`
* Move unawaited promises out of `p-props`: `reactivateProjectIfRequired`
* Move unawaited promises out of `p-props`: `markAsOpened`
* Move unawaited promises out of `p-props`: `flushProjectToTpdsIfNeeded`
This was actually awaited, but is it necessary?
* Use `getUserValues`: `user`
* Use `getUserValues`: `learnedWords`
* Use `getUserValues`: `projectTags`
* Use `getUserValues`: `userHasInstitutionLicence`
* Use `getUserValues`: `subscription`
* Use `getUserValues`: `isTokenMember`
* Use `getUserValues`: `isInvitedMember`
* Update `splitTestAssignments` syntax
* Remove `mapValues` in `pProps`
* Await unused promises again: `flushProjectToTpdsIfNeeded` and `reactivateProjectIfRequired`
* Remove error page file committed by mistake 🤦
GitOrigin-RevId: 6529445c364a6af660bc8ab6dfc836a4ddf7a040
2024-06-24 12:04:18 +00:00
Jimmy Domagala-Tang
271700893a
Merge pull request #18784 from overleaf/bg-allow-combined-group-policies
...
allow combined group policies
GitOrigin-RevId: b23fb0454f794e9094e8e15e732b4322a48ac1ee
2024-06-24 12:04:13 +00:00
Jimmy Domagala-Tang
e5aa917f54
Merge pull request #18682 from overleaf/jdt-ai-labs
...
Re-Release Labs Page for AI Error-Correction
GitOrigin-RevId: 2eef85dd3b5f86bedcf3339559a5fbbae2d4da87
2024-06-24 12:04:08 +00:00
Jakob Ackermann
ac7916fb29
Merge pull request #19023 from overleaf/jpa-issue-19016
...
[web] lock down legacy endpoint for creating projects from zip
GitOrigin-RevId: 0c6b29d34c601d316b184d50d93e8e17f59bfcfb
2024-06-24 12:04:00 +00:00
Mathias Jakobsen
922822d487
Merge pull request #18997 from overleaf/mj-fix-uncategorized-title
...
[web] Correct title when viewing uncategorized projects
GitOrigin-RevId: 6f284c437563f10125974eac7f6da6c92526e436
2024-06-24 12:03:51 +00:00
Mathias Jakobsen
69205629bf
Merge pull request #19024 from overleaf/mj-mobile-rename-modal
...
[web] Update project name in rename modal when project name changes
GitOrigin-RevId: 080d97b4d279fe54cc9530cea3efb1212da3041c
2024-06-24 12:03:47 +00:00
M Fahru
381795c5a2
Create an organizations icon section on the new plans page
...
GitOrigin-RevId: 9c58fa1dadb66a8ab91102484bc6b937e568c40b
2024-06-24 12:03:42 +00:00
M Fahru
b197aee92e
Merge pull request #18879 from overleaf/ds-plans-page-new-design-mobile-plans-2
...
Website redesign - Plans page new-design mobile screen plans card (2)
GitOrigin-RevId: d74f4d0769ae7a248226d2369a5419e26946e26d
2024-06-24 12:03:37 +00:00
Jessica Lawshe
900f11dae2
Merge pull request #18949 from overleaf/jel-faq-spacing
...
[web] Add spacing to left of FAQ accordion icon
GitOrigin-RevId: 71004270bbc9725b63c92dfb685b759057049265
2024-06-24 12:03:33 +00:00
Jessica Lawshe
2547294353
Merge pull request #18909 from overleaf/mf-new-plans-page-table-highlighted-column
...
[web] Implement highlighted column based on hardcoded column id on new plans page table
GitOrigin-RevId: 241913c81670ea158f436c29060bd9e1836ed4fc
2024-06-24 12:03:24 +00:00
Mathias Jakobsen
46d687855e
Merge pull request #18981 from overleaf/mj-mobile-dropdown
...
[web] Add rename button to project list mobile view
GitOrigin-RevId: 4ca3c68dcaf4e0d5e97f501084b9f850f9a4e867
2024-06-24 12:03:20 +00:00
ilkin-overleaf
7b47acc486
Merge pull request #18763 from overleaf/ii-bs5-projects-notifications
...
[web] BS5 notifications in projects and welcome pages
GitOrigin-RevId: 25780bb64660ef41c41c007f94f70df273cac716
2024-06-24 12:03:15 +00:00
ilkin-overleaf
34311ce0dc
Merge pull request #18789 from overleaf/ii-invite-token-lookup-by-hmac-token
...
[web] Lookup project invitations by HMAC token
GitOrigin-RevId: b631445e18f83ddb5e7708388a57a0fac0f73bd2
2024-06-24 12:03:10 +00:00
David
2a6b84596e
Merge pull request #19006 from overleaf/dp-pdf-click
...
Add click listener to pdf presentation mode to go to next page
GitOrigin-RevId: add7ddb18ef63774bbb78f6337088bd59b087db1
2024-06-24 12:03:06 +00:00
Jakob Ackermann
bd9f3cb07a
Merge pull request #19017 from overleaf/jpa-server-pro-footer
...
[web] fix spacing for thin-footer as used in Server Pro/CE
GitOrigin-RevId: 8a20d93f10c5bce156647f67de991ff41a8a2017
2024-06-24 12:03:01 +00:00
Alf Eaton
b66d45784a
Merge pull request #19007 from overleaf/ai-error-assistant-updates
...
Updates to the AI error assistant
GitOrigin-RevId: 6ca708b97a7eda81618abf3006b4bcc8d46f3dd4
2024-06-24 12:02:56 +00:00
Alf Eaton
3453f4cb94
Remove trailing slash from log hint ( #18998 )
...
GitOrigin-RevId: d95ffde59c5a7c58aed14a542b8dad3085405c2d
2024-06-24 12:02:52 +00:00
Miguel Serrano
e06621d2f8
Merge pull request #19019 from overleaf/msm-enable-admin-message-e2e
...
[CE] Enable e2e admin message test
GitOrigin-RevId: 5caaea32ace1548d4af0ec281a7bbfffda6befcc
2024-06-24 12:02:47 +00:00
CloudBuild
c90d01afa2
auto update translation
...
GitOrigin-RevId: 42dc0835bfeea53ebb45bb58f8ccd6392861ca9c
2024-06-20 08:05:36 +00:00
Jakob Ackermann
f9846699cb
Merge pull request #18994 from overleaf/jpa-sandboxed-compiles-logs
...
[server-pro] migrate comments to cy.log for sandboxed-compiles tests
GitOrigin-RevId: 2e66089b43c2f37af6e3cd56273df2b3c976a407
2024-06-20 08:05:32 +00:00
Miguel Serrano
548f16e334
[CE/SP] Editor e2e tests ( #18942 )
...
* [CE/SP] Editor e2e tests
GitOrigin-RevId: f761e08ca3ca192076a3723ed476be653b3b5048
2024-06-20 08:05:27 +00:00
ilkin-overleaf
ea6f627490
Merge pull request #18912 from overleaf/ii-remove-deleted-users-from-token-access-refs-script-fix
...
[web] Improve the removal of deleted users from token access refs
GitOrigin-RevId: 7b79e327388e37603a6c4f227f1d4bba743d4730
2024-06-20 08:05:22 +00:00
Eric Mc Sween
8d35177b52
Merge pull request #18985 from overleaf/em-migrate-bulk
...
Bulk history ranges migration
GitOrigin-RevId: 0d1846b412cfcddead63a7bc15bd06a82fbb47f3
2024-06-20 08:05:05 +00:00
David
8c3c9fe53f
Merge pull request #18979 from overleaf/dp-pdf-split-test-badge
...
Add SplitTestBadge to pdf controls toolbar
GitOrigin-RevId: ebbd2f8983aa2168fe03beb8ce69d7da91871a74
2024-06-20 08:05:01 +00:00
David
a4f398b852
Merge pull request #18975 from overleaf/dp-rename-present-presentation-mode
...
Rename present button to "Presentation mode"
GitOrigin-RevId: 15bfe5b2f360929b2cc507f0f15342ffdbefe73b
2024-06-20 08:04:57 +00:00
Jakob Ackermann
b13938ce7d
Merge pull request #18705 from overleaf/jpa-test-synctex
...
[server-pro] add tests for SyncTeX
GitOrigin-RevId: 2c914cd7e3859fb82c6e560fda1248d98415da2f
2024-06-20 08:04:50 +00:00
Jakob Ackermann
8bc9ce3b52
Merge pull request #18993 from overleaf/jpa-test-xelatex
...
[server-pro] add tests for using XeLaTeX
GitOrigin-RevId: 66c602c930a4dd0888e88f2f90bd587ee16a7a64
2024-06-20 08:04:46 +00:00
Brian Gough
be23b7e73b
Merge pull request #18744 from overleaf/jpa-ce-no-events
...
[web] avoid sending events in Server Pro/CE
GitOrigin-RevId: 04d2fa7939c448bc00757c5015e22a46b6b07bb5
2024-06-20 08:04:41 +00:00
Brian Gough
d43292cfe6
Merge pull request #18146 from overleaf/ab-one-time-assignments
...
[web] Handle one-time assignments for split tests
GitOrigin-RevId: 2d7ec2a878055fdc96475db2129aad308abb2fff
2024-06-20 08:04:34 +00:00
Miguel Serrano
f181dfe74f
Merge pull request #18549 from overleaf/msm-system-messages-redirect
...
[web] return redirect on admin actions
GitOrigin-RevId: d6273c01d90230c786cc9d0808f866524e57bc19
2024-06-20 08:04:20 +00:00
Alf Eaton
5e77052b3b
Use DOMPurify for AI error assistant output ( #18944 )
...
GitOrigin-RevId: 06c5b7720668d77b5750f90daa568bd38d22e150
2024-06-20 08:04:16 +00:00
Alf Eaton
231f7778c3
Update AI error assistant ( #18968 )
...
* Update styles to match designs
* Use Notification for errors and update error message
* Add feedback stories and update styles
* Update prompt
* Accept terms after suggest fix started
* Add translations for AI error assistant
* Add tooltips for feedback buttons
* Allow empty file extension
* Handle rate limit response
GitOrigin-RevId: e75c949f3a1b39594e94e300df717de414fdf70c
2024-06-20 08:04:11 +00:00
CloudBuild
6adade191f
auto update translation
...
GitOrigin-RevId: 1d8ec2514af0da765314e63720f22b23cdd6ccd1
2024-06-19 08:05:18 +00:00
M Fahru
34781dce81
Merge pull request #18963 from overleaf/mf-new-plans-page-very-small-screen-fix-tab
...
[web] Fix new plans page tabs overflow on mobile view
GitOrigin-RevId: f40efa386b15c921a17c7c046866c7f54aee083e
2024-06-19 08:05:10 +00:00
M Fahru
5e560e4376
Merge pull request #18908 from overleaf/mf-fix-spacing-page-new-plans-page
...
[web] Change new plans page vertical main heading spacing value to 96px
GitOrigin-RevId: c9746446a15bd0dd2e64a76615cd979654c8609e
2024-06-19 08:05:06 +00:00
Eric Mc Sween
e73fdfba63
Merge pull request #18906 from overleaf/em-migrate-existing-histories-2
...
History ranges migration script - second attempt
GitOrigin-RevId: 60a2c04e2a72e76a58e9e179fefc4186a96fde32
2024-06-19 08:05:02 +00:00
Eric Mc Sween
9f0f42a012
Merge pull request #18930 from overleaf/em-resync-ranges
...
Fix resyncs when diffs move ranges
GitOrigin-RevId: 121c3a16cf19649538445e6ed8bc0a1129735eb9
2024-06-19 08:04:57 +00:00
David
c342dc70a5
Merge pull request #18927 from overleaf/dp-remove-grammarly-promo
...
Remove Grammarly advert
GitOrigin-RevId: 6652cfafc47f8a42efc9acc1745a50e4ab8cc208
2024-06-19 08:04:46 +00:00
David
0b4d9aebe4
Merge pull request #18925 from overleaf/dp-pdf-scroll-bars
...
Remove scroll bar on pdf presentation mode
GitOrigin-RevId: 3d67586859e15a0e3ca77183c9f39bb4ccb38527
2024-06-19 08:04:38 +00:00
David
c16c806002
Merge pull request #18697 from overleaf/dp-ai-rate-limit
...
Add a rate limiter for the AI Error Assistant
GitOrigin-RevId: d23abc4b3477d13b1bfd4d69db168458ac8c2e51
2024-06-19 08:04:34 +00:00
David
7722c44414
Merge pull request #18918 from overleaf/dp-swap-search-arrows
...
Swap order of next/previous arrows in editor search
GitOrigin-RevId: 2c402e177fcd679ebff8e96812faf09d493e9726
2024-06-19 08:04:26 +00:00
Jakob Ackermann
aa480a2663
Merge pull request #18898 from overleaf/jpa-no-window
...
[web] migrate from window attributes to getMeta
GitOrigin-RevId: 3dcf1ab6b01155e5e4abeb3e78d0fa9053e055bc
2024-06-19 08:04:21 +00:00
Mathias Jakobsen
9b1c703f6b
Merge pull request #18901 from overleaf/mj-math-mode-args
...
[lezer] Parse command arguments in math mode
GitOrigin-RevId: 85a35f412de4c7238d735253c2642066ebffb393
2024-06-19 08:04:16 +00:00
Mathias Jakobsen
d2ae97427d
Merge pull request #18782 from overleaf/mj-symbol-palette-inline
...
[web] Move symbol palette icon inline
GitOrigin-RevId: 8d05cbf5211009870b8107c3c620af0e701a04dd
2024-06-19 08:04:12 +00:00
Jakob Ackermann
4087345a2a
Merge pull request #18941 from overleaf/jpa-fix-some-ts-ignore
...
[web] fix a few ts-ignore statements
GitOrigin-RevId: 447a070a8268cffa6ef298b0fe158232c3f6fe8f
2024-06-19 08:04:07 +00:00
Antoine Clausse
aa7839876a
[web] Promisify MetricsEmailController and InstitutionHubsController (attempt 2) ( #18805 )
...
* Reapply "[web] Promisify MetricsEmailController and InstitutionHubsController …"
This reverts commit ea14df1395f1dc2fa7d41fc7837849f9686425b5.
* Fix changes to node-fetch: `statusCode` -> `status` (!!)
* Update test
* Handle no-content without throwing (!)
Avoid error `Unexpected end of JSON input` when doing `response.json()` on an empty response when status is 204
Related: https://github.com/node-fetch/node-fetch/issues/165
* Also return `204` when no data in departments_data and roles_data
* Revert "Handle no-content without throwing (!)", and return null instead
This reverts commits 3baa779f7a9e64804e54a276faf865ab9252f336 and 51507a3d763d7006c8b01414a7c79bd3f3b6948b.
* Update tests: `assert_nil`
* Fixup: Update tests: assert null
* Use `fetchJSON` in Institution.fetchV1Data
* Proxy errors from server without throwing 500
GitOrigin-RevId: 9c13e293f3fed3abd2accddd1a9060ed02b96ba2
2024-06-19 08:04:02 +00:00
Jakob Ackermann
db821620c4
Merge pull request #18955 from overleaf/jpa-re-use-label-value
...
[server-ce] re-use label values for exists/does not exist tests
GitOrigin-RevId: 9ab48a9622294d6f42057cf8d151a06a454a63a2
2024-06-18 08:05:30 +00:00
M Fahru
e549e44ca7
Merge pull request #18889 from overleaf/mf-plans-new-tab-active-green
...
[web] Change text and icon color to green when new plans page tab is active
GitOrigin-RevId: 745b15538aa89afdb35a642f6927ecce0f1b40ee
2024-06-18 08:05:25 +00:00
M Fahru
bdf8927cdf
Fix new plans page table header does not occupy full height for all of its children on Chrome
...
GitOrigin-RevId: a69c20057ff1563e6f6e93c87e4ac3a0c010885d
2024-06-18 08:05:21 +00:00
