Commit graph

56 commits

Author SHA1 Message Date
Antoine Clausse
30860ae9f9 [web] Migrate PDF Logs to BS5 (#21062)
* [web] Migrate Logs components JSX to Bootstrap 5

* [web] Migrate logs.less to logs.scss

* [web] Remove unused class names

* [storybook] Define default Bootstrap version in Storybook

This prevents some warning in the console

* [storybook] Update pdf-preview.stories.jsx

* [storybook] Add pdf-log-entry.stories.tsx

* [storybook] Force re-renders when switching BS version

* [web] Keep files dropdown menu in bounds

* [web] Make files dropdown items not bold in BS5

* [web] Revert unrelated change

* [web] Fixup PreviewLogsPaneMaxEntries

* [web] Add style for log-entry-content-link

* [web] Replace log-entry by OLNotification in `PdfCodeCheckFailedNotice`

* [web] Use `BootstrapVersionSwitcher` instead of `isBootstrap5`

* [web] Rename `DropdownBS3` to `BS3Dropdown`

* [web] Reuse variables for `toolbar-height` and `toolbar-small-height`

* [web] Set `id` on `DropdownToggle` not `Dropdown`

* [web] Set `log-entry-btn-expand-collapse` in BS3 only

* [web] Remove `block: true` from StartFreeTrialButton in BS3

* [web] Remove unnecessary CSS in `.log-entry-header-link`

* [web] Use semantic color names

* Migrate the downloadable pdf file list to Bootstrap 5

* Remove nested BootstrapVersionSwitcher, fix "key" prop

* Update roles to: `<li role="menuitem">` `<a role="link">`

* Update `log-entry-header-link`: variant ghost and fix colors

---------

Co-authored-by: Rebeka <o.dekany@gmail.com>
GitOrigin-RevId: 89848970ab5d8a8c135335386caf24363f69a34c
2024-10-23 08:06:32 +00:00
Rebeka Dekany
f590d6d9a2 Merge pull request #20807 from overleaf/rd-ide-resizer
Migrate the editor resizer and SyncTeX button styles to CSS

GitOrigin-RevId: 94aec89f6f7b9e14d74d1c52111c13075e82ddaa
2024-10-14 11:09:55 +00:00
ilkin-overleaf
92eade7502 Merge pull request #20708 from overleaf/ii-bs5-pdf-toolbar
[web] BS5 pdf toolbar

GitOrigin-RevId: a04091c9e936e52f47c3977b3149ffe613d43bb9
2024-10-14 11:06:17 +00:00
David
277ac91f0e Merge pull request #19390 from overleaf/dp-pdf-tools-teardown
Remove `pdf-controls` feature flag and old controls

GitOrigin-RevId: 807ee0aa6384df354809f4d59b10d00dadef898c
2024-07-22 08:04:22 +00:00
David
1844603a2d Merge pull request #19124 from overleaf/dp-light-hover-bug
Refactor pdf toolbar button styles to fix bug with hovering over active logs button

GitOrigin-RevId: f8034c9daade32cda7c4f08ccd292c86ef6b8454
2024-06-27 08:04:27 +00:00
David
0b4d9aebe4 Merge pull request #18925 from overleaf/dp-pdf-scroll-bars
Remove scroll bar on pdf presentation mode

GitOrigin-RevId: 3d67586859e15a0e3ca77183c9f39bb4ccb38527
2024-06-19 08:04:38 +00:00
David
a70a3fc77e Merge pull request #18514 from overleaf/dp-pdf-toolbar-hover
Add hover state to pdf toolbar buttons

GitOrigin-RevId: d58ad739e6454b9e0cdbdbb93c55e58785a9d672
2024-06-03 08:04:02 +00:00
David
55e54ce875 Merge pull request #18435 from overleaf/dp-ae-pdf-viewer-controls
Update PDF viewer controls

GitOrigin-RevId: 4e15b7cbd34e878d0175be635369b8d620188203
2024-05-30 08:05:06 +00:00
Alf Eaton
6cc2db3cdd Merge pull request #17525 from overleaf/ae-upgrade-prettier
Upgrade Prettier to v3

GitOrigin-RevId: 6f1338f196408f3edb4892d5220ad3665ff1a5bc
2024-03-26 09:04:05 +00:00
Jimmy Domagala-Tang
b6f5f15056 Merge pull request #16334 from overleaf/dk-remove-toolbar-margin
[web] fix alignment of compile button

GitOrigin-RevId: 6e0d39d1f7c558428a96cd1c67b1fbdd008afb72
2024-01-04 09:03:52 +00:00
Thomas
24023dd267 Merge pull request #15901 from overleaf/tm-design-system-updates-teardown
Design system updates test tear down and clean up

GitOrigin-RevId: 743423f7c31c0ba89093bba0107d7e6799e1c309
2023-11-28 09:04:06 +00:00
Alf Eaton
9b4bda32a7 Delete vendored pdfListView and codemirror CSS (#15735)
* Delete pdfListView and codemirror vendor CSS

* Update main-style.less

* Remove plv-text-layer styles

GitOrigin-RevId: b23c5d1fbd9f0ced0d11133dcda21c731f655887
2023-11-15 09:03:06 +00:00
Jakob Ackermann
83cf21d8cf Merge pull request #15271 from overleaf/jpa-lazy-loading
[web] lazy load big optional UI elements

GitOrigin-RevId: 18d723c66834be3984b74c3c89cfb46e2fffbfc1
2023-10-18 08:04:05 +00:00
Thomas
31cb9e336b Implement test to reduce compile timeout to 20 seconds (#14705)
Compile timeout reduction to 20s for treatment users

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>
GitOrigin-RevId: 54f70fe4b1fc631cef966deb0c1d28c904dd3a44
2023-09-19 08:03:52 +00:00
Rebeka Dekany
9184c0135f Merge pull request #14795 from overleaf/rd-report-zoom-pdf-visible-focus
Accessibility - make the PDF controls accessible by tab navigation

GitOrigin-RevId: 46eee6fda68861884e602eb341dfdb0c5a4903b0
2023-09-15 08:05:31 +00:00
M Fahru
ed42d0c9ca Make the switch to editor/pdf button to have the same height (#12110)
GitOrigin-RevId: 5ceaad73c6c6b74ce2b6e8bbc79563bfad6ab34b
2023-07-17 10:26:34 +00:00
Alf Eaton
5c78718729 Fix ordering of PDF preview layers (#13132)
GitOrigin-RevId: 1f9429f7e760035377990b12ce9ef8c39b3d0534
2023-05-19 08:04:08 +00:00
Alf Eaton
1f7d317db9 Upgrade pdf.js to 3.6.172 (#13112)
GitOrigin-RevId: 030528343f271a1fc1e07c3bba358873173bec76
2023-05-18 08:04:03 +00:00
M Fahru
b62cb86bf8 Create new SplitMenu component and implement it for the pdf compile button (detached & non-detached) (#11772)
* Create a new shared `SplitMenu` component.

* Refactor the pdf compile button & detached compile button:
    - Rename `detach-compile-button` to `detach-compile-button-wrapper`
    - Rename `pdf-compile-button-inner` to `detach-compile-button`
    - Move some of the logic from `detach-compile-button-wrapper` to `detach-compile-button`
    - Create a new `compile-button.less` to centralize all of the compile button (detached/non-detached) custom styles rule.
    - Extract the animated striped CSS definition to the dedicated CSS file, change the class from `btn-recompile-group-has-changes` to `btn-striped-animated`
    - Refactor other className(s) appropriately according to the new component name
    - Delete the unused `changes-to-autocompile` css rule since it has not been used anywhere

* Implement the new pdf compile button with the new `SplitMenu` component.

GitOrigin-RevId: d1d055bffd311923fc47b4681605ce8ba8e26f25
2023-02-22 09:04:42 +00:00
Davinder Singh
306b2b7727 Merge pull request #10844 from overleaf/ds-editor-btn-info-to-secondary
Replacing `btn-info` with `btn-secondary-info btn-secondary` in the editor

GitOrigin-RevId: 1e348b0b09bfd08508a3dbee7df882f41fdc16eb
2022-12-19 09:04:17 +00:00
Davinder Singh
4adfca52bf Merge pull request #10682 from overleaf/ds-btn-default-to-secondary-in-editor-part-2
Replacing btn-default with btn-secondary in the editor Part-2

GitOrigin-RevId: 708aa29070bb3049afbc8ee1a282eaa1018594a8
2022-12-08 09:03:42 +00:00
Jessica Lawshe
854c39d3f5 Merge pull request #10526 from overleaf/jel-btn-recompile
[web] `btn-recompile` and `log-btn` for new CSS

GitOrigin-RevId: b92724267a87f5dce8ed0e60e926c1939f64c4f9
2022-11-18 09:05:44 +00:00
Alf Eaton
d905863002 Merge pull request #8747 from overleaf/ae-error-boundary-fallback
Create a generic ErrorBoundaryFallback component

GitOrigin-RevId: 0c9200ddef2be3b90030a32eb8c36a59047cf2b4
2022-08-10 08:03:51 +00:00
Timothée Alby
7b8d277437 Merge pull request #8898 from overleaf/ta-change-redundant-controls
Change Redundant Layout Controls

GitOrigin-RevId: b50d71b1f75d202334442b3f6cb5037ed0d8a411
2022-07-21 08:04:25 +00:00
Eric Mc Sween
a2532ef968 Merge pull request #8354 from overleaf/em-halt-on-error-animation
Animation when setting "Stop on first error"

GitOrigin-RevId: 9639e2c815d1eaf57f3392131f9a484a6a1a0a9e
2022-06-14 08:02:32 +00:00
Timothée Alby
ae207f7559 Merge pull request #8326 from overleaf/ta-pdf-detach-redundant-controls
Bring Back Redundant Layout Controls

GitOrigin-RevId: a725e8742ab41612b285bcab23054ba9da15b60f
2022-06-09 08:02:34 +00:00
Alf Eaton
ef10d95239 Merge pull request #7813 from overleaf/mf-pdf-viewer-review-panel-overflow
[web] force pdfViewer class to have 100% min-height to avoid triggering review-panel overflow bug

GitOrigin-RevId: 69d5840eb471a1d33ee3c2cac6b7e8d8dea68e8e
2022-05-12 08:03:59 +00:00
Alf Eaton
9f40893326 Increase specificity of PDF.js canvas style (#7219)
GitOrigin-RevId: 62e4424b5e5681bcbf1d377394f6bd8587a34ea6
2022-04-05 12:16:48 +00:00
Timothée Alby
5ba970b81e Merge pull request #6986 from overleaf/ta-compile-button-disabled
Disable Compile Button when Compiling

GitOrigin-RevId: c25cbaab3547695919ba62385cffef2a44665fec
2022-03-04 09:03:37 +00:00
Timothée Alby
f6fc3d468c Merge pull request #5854 from overleaf/ta-pdf-detach-v2
PDF Detach Updates

GitOrigin-RevId: c09c4fe37a922b041cfa1376e110a264a88177c8
2021-12-01 09:03:41 +00:00
Timothée Alby
8ca159b4b9 Merge pull request #5797 from overleaf/ta-pdf-detach
PDF Detach

GitOrigin-RevId: f69d8a87d1ba2115ad496a719106dfc7707a6ed5
2021-11-16 09:02:57 +00:00
Alf Eaton
07caf75004 Set overflow-y: scroll for pdf.js viewer container (#5539)
sets overflow-y: scroll for the inner pdf.js viewer container, so that there's always space reserved for the vertical scrollbar, which means there's never a flicker at the point where the PDF height starts to overflow the container height.

GitOrigin-RevId: 6ec4621e723869810eff531c971ee26c4ed86638
2021-11-09 09:03:41 +00:00
Alf Eaton
913a62fbc8 Migrate synctex controls to React (#5503)
GitOrigin-RevId: 80362a00ae6b73616a6fa9b3193b9b9974b5fd35
2021-10-22 08:03:43 +00:00
Alf Eaton
d4035c4f1e Merge pull request #5498 from overleaf/ae-recompile-button
Fix padding on recompile button in hybrid toolbar

GitOrigin-RevId: 36a2433833a76572bcf55c3109931d4e1ca63778
2021-10-22 08:03:20 +00:00
Alf Eaton
5c82945e12 Merge pull request #5453 from overleaf/ae-body-font-smoothing
Fix effect of font-smoothing style on PDF rendering

GitOrigin-RevId: 0b891cb003bf50c62059bf9d85a2da9535a3d625
2021-10-22 08:03:17 +00:00
Alf Eaton
9ffe28649c Improve rendering of errors from pdf.js (#5448)
GitOrigin-RevId: 69836ba213b124e2442b2d0083531dd95be2bf4e
2021-10-18 08:04:06 +00:00
Alf Eaton
4c25dcfb2b Disable overflow: scroll on the outer pdf.js element (#5446)
GitOrigin-RevId: 77485d0dd2af3e4dc6f86f322816e00beee9dfa9
2021-10-18 08:03:52 +00:00
Alf Eaton
7991fc1ebd Visually hide br in text selections (#5447)
GitOrigin-RevId: ee26da17dd8087545022ce704ef98102e7eb9ea0
2021-10-18 08:03:45 +00:00
Alf Eaton
e26d47cb41 Add hybrid toolbar to migrated PDF preview (#5414)
GitOrigin-RevId: 6266028091229c819aee3c8d4bd3bff2e2417125
2021-10-13 08:03:01 +00:00
June Kelly
03e1daa038 Merge pull request #5201 from overleaf/msm-pdf-viewer-error-boundaries
Error boundaries for React PDF viewer

GitOrigin-RevId: 90052fc183f7ece8125ecfb0410a529cf905c13b
2021-10-07 08:03:43 +00:00
Alf Eaton
73bc3418a2 Add React version of the PDF preview pane (#5135)
GitOrigin-RevId: fcc88a362c3e97c9fddf85d47c3a83a0a0b89432
2021-10-01 08:03:12 +00:00
Brian Gough
cc1b73336a Merge pull request #4944 from overleaf/bg-use-file-line-errors
use file line errors in log output

GitOrigin-RevId: 6732b19552fe15431a70fbefbc572253c389c64e
2021-09-22 08:03:25 +00:00
Alf Eaton
d9d7382e80 Merge pull request #5139 from overleaf/ae-pdfjs-viewer-tabindex
Add tabindex to pdfjs-viewer element

GitOrigin-RevId: be7bcba5e3c462b712dcb4deabe3ff8cf3d0233b
2021-09-20 08:03:01 +00:00
Alf Eaton
1ebc8a79cb Merge pull request #3495 from overleaf/ae-prettier-2
Upgrade Prettier to v2

GitOrigin-RevId: 85aa3fa1acb6332c4f58c46165a43d1a51471f33
2021-04-15 02:05:22 +00:00
Paulo Jorge Reis
15f49994bd New compile UI autocompile (#3762)
* Animate recompile button when autocompile is waiting

* Add code-check failed notice to the new compile UI

GitOrigin-RevId: 83b62f41438e8e5b94bd893c222bec37745c0f57
2021-03-19 03:04:50 +00:00
Paulo Jorge Reis
4e74fb2694 Log pane improvements (#3418)
* Ordering of log entries in the new errors UI

* Don't show the expand-collapse widget when not needed; smaller font size in the raw log output

* Expose log actions in the log pane.

* Use "This project" instead of "Your project" in the new errors UI

* Better handling of long log messages; left-ellipsize the file/line number button

* Make log location more button-like; add tooltip when needed.

* Add a PDF expand button to the toolbar.

* Add a stop compilation button to the new compile UI

* Use aria-label for button accessible text; improve handling of long filenames in the log location button

* Set max-height correctly for the logs pane dropdown

* Avoid changing raw logs sizing when expanded and collapsed

* Add comment on the solution for right-to-left text and ellipsis

* Improve logs pane actions

GitOrigin-RevId: 4098d77a9ee6d333644906876b9ff27035b79319
2020-12-03 03:04:28 +00:00
Jessica Lawshe
d7f32179e4 Update download dropdown style (#3399)
* Update translation

* Move dropdown header to top of list

* Do not wrap header in download dropdown

GitOrigin-RevId: 326428272592fc54f9915d5946877e59a60f967e
2020-11-27 03:04:44 +00:00
Jessica Lawshe
21ffe27bdd Merge pull request #3330 from overleaf/jel-toolbar-btns
Hide toolbar text and show tooltip when out of space

GitOrigin-RevId: 5a73b69e7d92695c4f8691a747307908550e3790
2020-11-10 03:04:35 +00:00
Jessica Lawshe
6fe36b6acb Merge pull request #3282 from overleaf/jel-download-dropdown-menu
Add output download dropdown

GitOrigin-RevId: 1f97f0d681679268d28796fbc8251ffbc6e98433
2020-10-21 02:04:32 +00:00
Paulo Jorge Reis
c0cb00e976 Update frontend/stylesheets/app/editor/pdf.less
Co-authored-by: Jessica Lawshe <jessica.lawshe@overleaf.com>
GitOrigin-RevId: 628b83a3b1fd03362853fe9cc2d4b5751c85cae4
2020-10-16 02:05:11 +00:00