Commit graph

44 commits

Author SHA1 Message Date
roo hutton
837b5a4b9b Merge pull request #19914 from overleaf/rh-viewer-comments
[web] Allow Viewers to access chat and view comments/tracked changes

GitOrigin-RevId: 72be0444afdf5e0ad5937bf25718a7566bad001a
2024-08-28 11:35:22 +00:00
Alf Eaton
2304536844 Add review panel context providers and components (#19490)
* Tidy up review panel components

* Add ReviewPanel providers

* [web] new design for review panel track change (#19544)

* [web] new design for review panel track change

* fixed mini view

* mini icon style change

* fix icon size

* format date

* useRangesUserContext hook

* remove useRangesUserContext hook

* using full class names

* fix action icons hover

* change wording for tooltips

* added ReviewPanelChangeUser component

* Update header in new review panel

* Extract ReviewPanelTrackChangesMenuButton as a separate component

* Remove wrapper div

* Replace h2 with div for review panel label

* Rename ReviewPanelTools to ReviewPanelHeader

* Rename trackChangesExpanded -> trackChangesMenuExpanded

* Dont break memoisation of ReviewPanelTrackChangesMenuButton

* Fix the width of the track changes arrow icon

* Update how prop types are declared

* Remove new empty state from old review panel

* Add empty state to new review panel

* Add project members and owner to ChangesUsers context (#19624)

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>

* Redesign comment entry in review panel (#19678)

* Redesign comment entry in review panel

* ReviewPanelCommentOptions component

* remove unused prop

* Tidying

* Add conditional import

* Optional changeManager

* Add more split test compatibility

* More split test compatibility

* Fixes

* Improve overview scrolling

* Fix overview scrolling

* Fix & simplify track changes toggle

* Fix overview scrolling

* Fix current file container

* ExpandableContent component for messages in review panel (#19738)

* ExpandableContent component for messages in review panel

* remove isExpanded dependancy

* Delete comment option for new review panel (#19772)

* Delete comment option for new review panel

* dont show thread warning if there are no replies

* fix hasReplies issue

* Implement initial collapsing overview files

* Fix positioning of overview panel

* Small styling changes

* Add count of unresolved comments and tracked chanegs

* More style adjustments

* Move review-panel-overview styles into css file

* Remove unused var

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
Co-authored-by: David Powell <david.powell@overleaf.com>
Co-authored-by: David <33458145+davidmcpowell@users.noreply.github.com>
GitOrigin-RevId: e67463443d541f88445a86eed5e2b6ec6040f9c7
2024-08-13 08:04:20 +00:00
Alf Eaton
4c76667379 Avoid loading ranges twice for overview panel (#19554)
GitOrigin-RevId: da8cc295fe672a97e76b93cc7e88dc1f6d3d044d
2024-07-30 08:04:59 +00:00
roo hutton
bf90932f40 Merge pull request #18936 from overleaf/rh-viewer-no-comment
[web] Remove access to commenting/chat for collaborators with Viewer permission

GitOrigin-RevId: 03957cb8c04866318a4b94bdb72843e7d7a5a003
2024-06-26 08:04:38 +00:00
Jakob Ackermann
aa480a2663 Merge pull request #18898 from overleaf/jpa-no-window
[web] migrate from window attributes to getMeta

GitOrigin-RevId: 3dcf1ab6b01155e5e4abeb3e78d0fa9053e055bc
2024-06-19 08:04:21 +00:00
Mathias Jakobsen
c29c151c9f Merge pull request #18803 from overleaf/revert-18801-mj-revert-big-deploy
[web+chat] Redo deploy

GitOrigin-RevId: a056bf20d49a39e71e03db740f57e8506dfc6b71
2024-06-11 08:03:59 +00:00
Mathias Jakobsen
a26e3d3376 Merge pull request #18801 from overleaf/mj-revert-big-deploy
[web+chat] Revert big deploy

GitOrigin-RevId: f4d068cbea7e5f5d59a3d698e2def2f94c9b6322
2024-06-10 08:04:33 +00:00
Mathias Jakobsen
110b83aea0 Merge pull request #18710 from overleaf/mj-web-chat-send-thread-data
[chat+web] Inform frontend when duplicating threads

GitOrigin-RevId: 285afee8f5a016a8e7ac58e9538cc3ec8362681d
2024-06-10 08:04:25 +00:00
Alf Eaton
c24ace801b Remove Angular (#17534)
GitOrigin-RevId: 7a0d45e17d9905fa75569e2d19ca59caa4a41565
2024-06-06 08:04:09 +00:00
Alf Eaton
905c9b2c28 Ensure that tracked changes are highlighted in read-only mode (#18036)
GitOrigin-RevId: 5010e1649d8f15014f9c8ef578073be7c6545aa4
2024-04-24 08:04:09 +00:00
Domagoj Kriskovic
8bde496da4 Send operations to project-history when resolving/unresolving comments (#17540)
* Send operations to project-history when resolving/unresolving comments

* small fixes

* added doc_id in web unit test

* Revert "added doc_id in web unit test"

This reverts commit f0b8251abfce17965d5e1b0e45d8784fcf1d9eed.

* fix mocked dependency in test

* wip: web unit tests

* document updater, reopen test

* document-updater tests

* format fix

* fix typo

* fix callsArgWith

* fix reopenThread calls in doc updater tests

* fix typos

* log error if chat api resolve failes

* log error when reopening thread

* sendStatus calls done() in tests

* using OError instead of logging

* removed timers

* preserve legacy endpoints

* update after merge

* Remove timer check in HttpControllerTest

* prettier

* added "legacy" in log

* remove metrics.timer

* fix promisify issues

* remove unused cb

GitOrigin-RevId: 849538c86996973a065c727835e93028e5429344
2024-04-10 08:04:08 +00:00
Alf Eaton
6cc2db3cdd Merge pull request #17525 from overleaf/ae-upgrade-prettier
Upgrade Prettier to v3

GitOrigin-RevId: 6f1338f196408f3edb4892d5220ad3665ff1a5bc
2024-03-26 09:04:05 +00:00
Alf Eaton
749660e168 Refactor review panel context (#17383)
GitOrigin-RevId: 23e7ff8632172ebd0bc544a2297d1d4179010832
2024-03-07 16:30:25 +00:00
Alf Eaton
b608c5eae6 Wrap onCommentEdited in useCallback (#17379)
GitOrigin-RevId: 3171ed2a50502d0771457a3f3547eacec33efa20
2024-03-07 16:30:18 +00:00
Alf Eaton
7b3ffb9fae Standardise types for ranges (#16927)
GitOrigin-RevId: 28dd0eb67e1684e6bd0e452d15315ce1f9e3481a
2024-02-09 09:06:51 +00:00
Alf Eaton
0cde5be165 Merge pull request #14709 from overleaf/ae-context-typescript
Convert React context providers to TypeScript [don't squash!]

GitOrigin-RevId: d92a91798286978410956ab791d73c17c5086d86
2024-01-29 09:03:04 +00:00
ilkin-overleaf
fa314fe5b0 Merge pull request #16509 from overleaf/ii-rp-update-entry-positions
[web] Review panel entry positions and long user names

GitOrigin-RevId: 3a596bd90bab2c87b2efae5eb812ffc5e5a1580f
2024-01-19 09:05:28 +00:00
ilkin-overleaf
fc3fb7318a Merge pull request #16493 from overleaf/ii-rp-mini-page-load
[web] Prevent opening and closing of the mini review panel

GitOrigin-RevId: 25297a24ddfb2654b00efa8d33b825620f859147
2024-01-17 09:03:17 +00:00
ilkin-overleaf
20485b886f Merge pull request #16278 from overleaf/ii-ide-page-prototype-review-panel-entry-hover
[web] Remove entry hover from review panel

GitOrigin-RevId: 6bcfb28e20d7a8826301c34499340b6a7d2745db
2024-01-04 09:03:14 +00:00
ilkin-overleaf
fbed0cb943 Merge pull request #16268 from overleaf/ii-ide-page-prototype-review-panel-layout-to-left
[web] Review panel popovers

GitOrigin-RevId: 4424abab97b197013063679bd8efcac001f458ad
2023-12-18 09:04:18 +00:00
ilkin-overleaf
39e2a8349f Merge pull request #16236 from overleaf/ii-ide-page-prototype-review-panel-issues-2
[web] Enable track changes on page load in react ide page

GitOrigin-RevId: 17e58490703c0d18fc700fde2e770e57a141a537
2023-12-18 09:03:58 +00:00
ilkin-overleaf
ca28b6995b Merge pull request #16173 from overleaf/ii-ide-page-prototype-review-panel-goto-entry
[web] Review panel gotoEntry

GitOrigin-RevId: b08ba8d8539751ea43f6c1a72d4e2043f02bb83c
2023-12-18 09:03:44 +00:00
ilkin-overleaf
aceabf9fa8 Merge pull request #16217 from overleaf/ii-ide-page-prototype-review-panel-issues-3
[web] Review panel add comment, bulk accept/reject and track changes entries fix

GitOrigin-RevId: bbed28f69d5f882c4f29353daab9b2a6613fd654
2023-12-14 09:03:33 +00:00
ilkin-overleaf
b715cb3b16 Merge pull request #16152 from overleaf/ii-ide-page-prototype-review-panel-mini
[web] React ide page mini review panel

GitOrigin-RevId: 4c4ee8095446a2f72371024b93a07dbd1dbd2a63
2023-12-11 09:03:21 +00:00
ilkin-overleaf
91121a82b7 Merge pull request #16147 from overleaf/ii-ide-page-prototype-review-panel-add-last-editor-events
[web] React ide page add missing editor events

GitOrigin-RevId: 070acde5e8b2dd324584c8703941745f8d2e7bb6
2023-12-11 09:03:18 +00:00
ilkin-overleaf
c3689ca6f3 Merge pull request #16138 from overleaf/ii-ide-page-prototype-review-panel-overview-loading
[web] React ide page overview switch

GitOrigin-RevId: 9a24a8ba9ed8e86d486a12a65259d25c1352c864
2023-12-08 09:04:19 +00:00
ilkin-overleaf
ffb24e061e Merge pull request #16139 from overleaf/ii-ide-page-prototype-review-panel-line-height
[web] React ide page line height

GitOrigin-RevId: da8c9cd178bc089fdc208abd1c453f7666ff58b1
2023-12-08 09:04:15 +00:00
Alf Eaton
18ad44c278 Use permissions.write for editor editable state (#16011)
GitOrigin-RevId: b38ce53fa90a739d9e38ddcc57b01dfa0d9a104c
2023-12-06 09:04:09 +00:00
ilkin-overleaf
8035241cc0 Merge pull request #16065 from overleaf/ii-ide-page-prototype-review-panel-add-comment
[web] React ide page add comment

GitOrigin-RevId: 4c2442ccc77760d4a27268551c9dd2d73fcdba84
2023-12-05 09:04:06 +00:00
ilkin-overleaf
2cd10df47e Merge pull request #16030 from overleaf/ii-ide-page-prototype-review-panel-reply
[web] React ide page reply

GitOrigin-RevId: 4c47c5720f8aa019f9b427699d1687f42c090bd6
2023-12-01 09:03:15 +00:00
ilkin-overleaf
de945a432d Merge pull request #15999 from overleaf/ii-ide-page-prototype-review-panel-accept-reject-changes
[web] React ide page accept/reject changes

GitOrigin-RevId: 0bb8e3759c7edbef16be04b2f200ae3686c3a53c
2023-11-30 09:03:43 +00:00
ilkin-overleaf
8ec2b2b42d Merge pull request #15965 from overleaf/ii-ide-page-prototype-review-panel-delete-comment
[web] React ide page delete comment

GitOrigin-RevId: e9ab2afeb7e0053481ccaf3655f8f700707a24f1
2023-11-30 09:03:34 +00:00
ilkin-overleaf
808286dea8 Merge pull request #15968 from overleaf/ii-ide-page-prototype-review-panel-edit-comment
[web] React ide page save edit

GitOrigin-RevId: 79e6a02fecaa3d8923b503d043a1e0b8cc193f7d
2023-11-28 09:04:49 +00:00
ilkin-overleaf
9821498a00 Merge pull request #15944 from overleaf/ii-ide-page-prototype-review-panel-resolve-comment
[web] React ide page resolve comment

GitOrigin-RevId: a55dfd2972bfb94c0e10465f3588be419477e1da
2023-11-28 09:04:27 +00:00
ilkin-overleaf
81f5a1308e Merge pull request #15909 from overleaf/ii-ide-page-prototype-review-panel-refresh-ranges
[web] React ide page refresh ranges

GitOrigin-RevId: 7f79b8f63869ee39fef9a101e6dcc56c39af8df7
2023-11-27 09:04:26 +00:00
ilkin-overleaf
a75b44a6fc Merge pull request #15861 from overleaf/ii-ide-page-prototype-review-panel-delete-thread
[web] React ide page delete thread

GitOrigin-RevId: 46e93d67d597a2277c771bda2a4837a871339224
2023-11-27 09:04:19 +00:00
ilkin-overleaf
e946e27532 Merge pull request #15845 from overleaf/ii-ide-page-prototype-review-panel-reopen-comment
[web]  React ide page reopen comment

GitOrigin-RevId: 9c80dcfeb41481647423e2c376417a2bf26a549e
2023-11-27 09:04:11 +00:00
ilkin-overleaf
e4f5afc0c0 Merge pull request #15829 from overleaf/ii-ide-page-prototype-permissions
[web] React ide page permissions

GitOrigin-RevId: 727d33e0654d4bfefe5e710e553895f793cacb82
2023-11-24 09:04:27 +00:00
ilkin-overleaf
1f39b6d72a Merge pull request #15756 from overleaf/ii-ide-page-prototype-review-panel-entries
[web] init review panel entries for React IDE page

GitOrigin-RevId: f6e6311e20f1673b1d97a3f5dfcab54e16da42e1
2023-11-24 09:04:23 +00:00
Tim Down
86c06d8c99 Merge pull request #15815 from overleaf/td-persist-unsaved-comment
Persist unsaved comment in the front end after not submitting

GitOrigin-RevId: a7ffee6f5fbfb7151a2ef7233ba4412d0db33e19
2023-11-22 09:04:21 +00:00
ilkin-overleaf
7db5d761ea Merge pull request #15557 from overleaf/ii-ide-page-prototype-review-panel-track-changes
Review panel track changes for React IDE page

GitOrigin-RevId: d061596581ff10bd897b286dcd5c280ce79a6384
2023-11-17 09:03:02 +00:00
ilkin-overleaf
71a78c8edd Merge pull request #15784 from overleaf/ii-ide-page-prototype-review-panel-tc-upgrade-modal
[web] Review panel upgrade modal for React IDE page

GitOrigin-RevId: 2ef503427d796d4683581899800462c45b550d36
2023-11-17 09:02:59 +00:00
Tim Down
6f34a84ebd Merge pull request #15684 from overleaf/td-ide-page-main-doc-left-menu
Add docs to FileTreeDataContext to replace 'docs' scope value in React code

GitOrigin-RevId: 430f795eb0cd17f0f4fab9c61e46fb04ff3030b3
2023-11-14 09:04:40 +00:00
ilkin-overleaf
0c403bf8e3 Merge pull request #15397 from overleaf/ii-ide-page-prototype-review-panel
Init review panel for React IDE page

GitOrigin-RevId: fc23201055ae892c5c1d5cb88e472a0bb0cd6c25
2023-11-03 09:00:02 +00:00