Commit graph

58 commits

Author SHA1 Message Date
M Fahru
3324a14202 Merge pull request #15029 from overleaf/mf-remove-angular-settings-dependency-rename-project
[web] Remove angular settings dependency when renaming a project in editor top bar

GitOrigin-RevId: 45a8b71fc84135f5291217f613cc95aea7192c35
2023-09-29 08:04:33 +00:00
Jakob Ackermann
1213709578 Merge pull request #14980 from overleaf/jpa-debug-console
[web] migrate frontend logging to debugConsole

GitOrigin-RevId: b03ff9030b03fff059738d2270bc4b4912e79f16
2023-09-28 08:04:12 +00:00
Davinder Singh
acad014cc9 added Legacy keyword in front of theme names
GitOrigin-RevId: 67153578ba1cdfcc2df45caf4dee185644ec1021
2023-08-28 08:04:36 +00:00
Ilkin Ismailov
52b487e7be display document path instead of file name in the main document settings menu
GitOrigin-RevId: f5e1773b8d20d2ffbfed04c8483c755d0f323cc2
2023-08-24 08:04:15 +00:00
Jimmy Domagala-Tang
b2e74464a2 Merge pull request #14207 from overleaf/jdt-editor-events
editor events

GitOrigin-RevId: 8d74576d4f8117ecca47402afcc9cee229dd0dca
2023-08-23 08:05:23 +00:00
Jimmy Domagala-Tang
f49616b4cf Merge pull request #14110 from overleaf/jdt-editor-left-main-doc-refresh
fix: updating context with new root doc id
GitOrigin-RevId: 87e803554efc20cce4404f4f0f4137ae7fe9c2aa
2023-08-04 08:04:33 +00:00
Rebeka
7f5be3ed04 Make left menu sidebar a Modal
GitOrigin-RevId: 63630c2a98c3abb5c5ebbde0afe25c0aa981282b
2023-07-17 10:53:03 +00:00
Alf Eaton
ac19140362 Unmask the editor when changing editor theme (#12604)
GitOrigin-RevId: 633d12c748cfd615fa72698f886a452c5b2fd2bb
2023-05-25 08:04:57 +00:00
Tim Down
7f37ba737c Move source editor out of module (#12457)
* Update Copybara options in preparation for open-sourcing the source editor

* Move files

* Update paths

* Remove source-editor module and checks for its existence

* Explicitly mention CM6 license in files that contain code adapted from CM6

GitOrigin-RevId: 89b7cc2b409db01ad103198ccbd1b126ab56349b
2023-04-13 08:40:56 +00:00
M Fahru
5ae698ec6c Migrate "Manage Template" in editor left menu to react (#10609)
This feature is only available on server pro

GitOrigin-RevId: 7fc508c8039c2e3afd1a5fca469fce411e9d913a
2023-03-21 09:05:29 +00:00
Alf Eaton
f375362894 Always use mockable location methods (#11929)
* Always use mockable location methods
* Add eslint rules for window.location calls/assignment
* Add useLocation hook
* Update tests

GitOrigin-RevId: eafb846db89f884a7a9a8570cce7745be605152c
2023-03-17 09:05:21 +00:00
M Fahru
47937c4073 Fix event "left-menu-documentation-click" not being fired properly (#11836)
GitOrigin-RevId: 5e9df12c699ff5c25389e8fb90fda73913e8c747
2023-02-16 09:05:00 +00:00
M Fahru
82cd2d2a77 perform null check on the old value instead of the new one since to follow the non-react version behaviour
GitOrigin-RevId: 33ef74e1b1da41db8a86fc79ae04fbe49ed194df
2023-01-11 09:10:00 +00:00
M Fahru
94ab78b427 Log error in a promise catch block
GitOrigin-RevId: 09756d52bd6351c55051a74f22f38c450af9a275
2023-01-11 09:09:51 +00:00
M Fahru
7475237170 Refactor project-wide settings:
- Change api function argument (readability)
- create a new wrapper hooks for saving the project to both server-side and angular scope
- Implement the new save project settings hooks on project-wide settings update
- On spell check language update function, add new comment to give more context about the decision

GitOrigin-RevId: 93d558d1e1d4db265a943eeb4366842430900c43
2023-01-11 09:09:40 +00:00
M Fahru
654144dd40 Refactor saveUserSettings: Move sendMB inside the function and change function from supporting multiple settings to only support single key/value pair.
GitOrigin-RevId: 77b9d8fd5cdcbc78f38fd42329b74cf592615638
2023-01-11 09:09:32 +00:00
M Fahru
4444377b11 fix tsc error by re-creating request body object instead of directly assigning it from function argument
GitOrigin-RevId: b17697c7b52c991a06efcbffa0227b6021c5bc8d
2023-01-11 09:09:25 +00:00
M Fahru
b2cf833e9d Remove scope suffix from variable name in react-related files since it's an angular-specific concept
GitOrigin-RevId: b8eea8c8113a977f6cbe07649e1338eea8281841
2023-01-11 09:09:18 +00:00
M Fahru
03e5614969 Remove _csrf in request body since fetchJSON already have X-Csrf-Token set in request header
GitOrigin-RevId: 9dd2389c47ce3537fc4bb22bd8b6b0b83862c5f4
2023-01-11 09:09:11 +00:00
M Fahru
4548f504f7 standardize the naming for rootDocId.
- Remove the `scope` variable suffix
- change `rootDoc_id` to `rootDocId`

GitOrigin-RevId: d8e646ef5f99ba0dbce84ff63c588e63b956a4ec
2023-01-11 09:09:04 +00:00
M Fahru
bdf3b18d4f Change import to import type for type imports
GitOrigin-RevId: 2061bafeca58d063f83a96650403e5741b863c05
2023-01-11 09:08:57 +00:00
M Fahru
608b75c9db Fix linter error because of wrong variable name and camel case issue
GitOrigin-RevId: a5ea8d6c8332133303fcd8e410cc76ac06c5bb97
2023-01-11 09:08:49 +00:00
M Fahru
e3d0380e6f Remove multiple source of type imports; add type on type imports.
GitOrigin-RevId: a6630bb284c456bfbe61901f7331cdd3c13c7f8b
2023-01-11 09:08:42 +00:00
M Fahru
12f5c845b4 Simplify function by removing generic
GitOrigin-RevId: 7732b6782cd1e0130eb56f6b674c03548b8e8315
2023-01-11 09:08:35 +00:00
M Fahru
10bb724197 Fix wrong hook name
GitOrigin-RevId: 58f98b508cf650a6ecab38772faf9ecd38c9a7bc
2023-01-11 09:08:28 +00:00
M Fahru
f2060b35ad Refactor type by reusing type declaration and avoid multiple source of the same type
GitOrigin-RevId: 492a9a524e566cf70b53158b4e5cc6ad57cb6093
2023-01-11 09:08:21 +00:00
M Fahru
f85d17f894 Remove disabling update while listening on socket (ignoreUpdates state) since the logic is more complicated that was originally thought and it will be tested/revisited on a different PR
GitOrigin-RevId: 70cee2f0fc565aaebfb3ead2dd1a58fc5371c816
2023-01-11 09:08:13 +00:00
M Fahru
677ec173ed Disable updating project-wide settings while socket is currently listening to update project-wide settings in a project.
This may happen if the project is being used by multiple people, and we want to avoid race condition on the update since it's possible for multiple people to update setting value at the same time.

GitOrigin-RevId: cdad6a6456e2d9e4ef1812ebfd6f6ef59f23747f
2023-01-11 09:08:06 +00:00
M Fahru
af01ace5a0 refactor function by simplifying function argument (from two arguments to a single object)
GitOrigin-RevId: e4244a07a4ca196afa226e3fac9de74d30f7d4ea
2023-01-11 09:07:59 +00:00
M Fahru
777beaadc3 Don't send spellCheckLanguage request if the old value is the same as the new one
GitOrigin-RevId: 4ef34be7563ff707b6abd44dc8034293c88d2f72
2023-01-11 09:07:52 +00:00
M Fahru
ae5a08e680 Add 'setting-changed' tracking when user changes user-wide settings
GitOrigin-RevId: 04ed66dcdff7fa04e783fe4028505d981a39b37b
2023-01-11 09:07:45 +00:00
M Fahru
85cbc5b721 Apply prettier
GitOrigin-RevId: 34c7e3b95d061c270c77337c7c82502af289b556
2023-01-11 09:07:38 +00:00
M Fahru
06b0833e33 Add a comment explaining why user settings may be undefined
GitOrigin-RevId: 4460d4184cde5639d326da07121b2728d444c782
2023-01-11 09:07:30 +00:00
M Fahru
5597736057 Fix numerous test fails because of unitialized user settings scope on the test environment
GitOrigin-RevId: a27454285b0c89c6abef560f05c52d35f81fa570
2023-01-11 09:07:23 +00:00
M Fahru
56395d9a95 Save spellCheckLanguage to both project-wide and user-wide setting
GitOrigin-RevId: 059cc64d0fe2e955814a7192f82d4ff8ea4e2572
2023-01-11 09:07:16 +00:00
M Fahru
4bf09e21de Fix tsc lint error by restricting the generic type
GitOrigin-RevId: 11ef7ab4111c7b312b283283829e9b28a80c475c
2023-01-11 09:07:09 +00:00
M Fahru
98fbd330b2 Add socket listener for compiler, imageName, and spellCheckLanguage
GitOrigin-RevId: b12644152387e479e433a014e1a1041ebae36f12
2023-01-11 09:07:02 +00:00
M Fahru
b6b6b9c4b1 Rename "rootDoc_id" to "rootDocId" before sending it to server
GitOrigin-RevId: fc29e152ffd3bf97c00ee817abb07086f6cdfe17
2023-01-11 09:06:54 +00:00
M Fahru
30c32713c6 Add _csrf to request body
GitOrigin-RevId: 87b5a7299fbb795618143421df79375b41f8f921
2023-01-11 09:06:47 +00:00
M Fahru
132bb40a21 replace save project setting hooks with common function and implement set root doc id change
GitOrigin-RevId: e5b204cd93fc188288def529cb22018b3d4f89b6
2023-01-11 09:06:40 +00:00
M Fahru
8ae9839f79 apply prettier
GitOrigin-RevId: dd750756d2bfc625817760510e9bdbade186aef3
2023-01-11 09:06:33 +00:00
M Fahru
c2b0707c2a Change variable declaration location + apply prettier
GitOrigin-RevId: 3237a417c23d5c66c47385e55f8d3cb68bdfc3ca
2023-01-11 09:06:26 +00:00
M Fahru
414540af5c Reduce save/setScope user setting duplication by introducing a new shared hooks
GitOrigin-RevId: 6054143eb042e4ff336b1f325a8cef693ae8c4bd
2023-01-11 09:06:19 +00:00
M Fahru
09b1974a3d Migrate updating overallTheme to react
GitOrigin-RevId: 024ceb3c32c8d90ac0067fbb72d6e7d327b869f0
2023-01-11 09:06:12 +00:00
M Fahru
6c41a65200 migrate user-wide settings post request from angular controller to react
GitOrigin-RevId: b5440178a11b82c5a5840eb310416f1519f85bae
2023-01-11 09:05:57 +00:00
M Fahru
f01a2920cf Migrate editor settings controller to react (this commit includes project-wide settings)
GitOrigin-RevId: 8c47a2699a2f11fda7fd60c5173bf2e29858e37a
2023-01-11 09:05:50 +00:00
M Fahru
5f8e10de86 Conform with new design system by changing btn-default to btn-secondary (#10972)
GitOrigin-RevId: 1fac39d3b1e7e68e6feffe467ac21b4cb3253353
2023-01-11 09:05:36 +00:00
Mathias Jakobsen
38cc3394e3 Merge pull request #10793 from overleaf/mj-split-test-cleanup
Split test clean-up

GitOrigin-RevId: 7dd6178487022cbefcbc85797dacc3f3fbfa17e2
2022-12-21 09:04:04 +00:00
M Fahru
f27562eb12 Data handling for settings in editor left menu react migration (#10470)
- Importing SettingsController from the angular code, which enables post requests for every select menu and socket handler for compiler, texlive version, and main document select option
 - New context for the data handling infrastructure between react and angular. The data is still located in the angular version, and I use the context only as a proxy to fetch/post new data.

GitOrigin-RevId: 59009bceb128d82969a2318e90036aacf79f9887
2022-11-30 09:04:32 +00:00
M Fahru
6dcc22642a Update "go to line" hotkey for cm6 and add new info text in hotkeys modal
* Update "go to line" hotkey for cm6 and add new info text in hotkeys modal

* Differentiate modal title between cm6 and ace hotkeys

* Update test to reflect change in hotkeys modal title

* Add test for hotkeys modal bottom text

* Update test on editor left menu hotkeys button to reflect change in hotkeys modal title

GitOrigin-RevId: 61bae16313ea7a37fa3b9441dbe5a93ab7823d01
2022-11-25 09:04:20 +00:00