Commit graph

261 commits

Author SHA1 Message Date
Tim Down
1dc3d12c1d Merge pull request #14746 from overleaf/td-review-panel-empty-comment-edit
React review panel: populate comment box when editing

GitOrigin-RevId: ba284bd419dd507eef17847b5f4c55b8fd8338f5
2023-09-11 08:05:31 +00:00
Mathias Jakobsen
78a493d78d Merge pull request #14730 from overleaf/mj-table-gen-dark-mode
[visual] Fix dark editor mode for table generator

GitOrigin-RevId: 024a2118fe7557d3ecd2d833a639684463dda707
2023-09-11 08:05:05 +00:00
Mathias Jakobsen
0d7730f37a Merge pull request #14712 from overleaf/mj-table-adjustbox
[visual] Disable caption dropdown when tabular is wrapped in command

GitOrigin-RevId: 08131d27e8bb4cb99eee3060435084f671bc3dd6
2023-09-08 08:04:23 +00:00
Mathias Jakobsen
c5cb344178 Merge pull request #14707 from overleaf/mj-table-gen-toolbar-z-index
[visual] Set higher z-index for table gen toolbar than cm6 cursor

GitOrigin-RevId: 769e33abf84767087b7936f2b3f0a02c80c7dd09
2023-09-08 08:04:19 +00:00
Mathias Jakobsen
d2c9b40ecb Merge pull request #14686 from overleaf/mj-table-generator-copy
[visual] Update copy for table generator

GitOrigin-RevId: ed5693fc3bf04bade2db70c652c7bdcb38e2195e
2023-09-07 08:05:05 +00:00
Mathias Jakobsen
2dec2a0296 Merge pull request #14658 from overleaf/ae-pasted-font-weight
[visual] Use font-weight >= 700 as bold indicator

GitOrigin-RevId: 33307a3139b596868c3460c070f51adc8617cb3a
2023-09-07 08:04:46 +00:00
Mathias Jakobsen
4a157e7086 Merge pull request #14664 from overleaf/ae-paste-rowspan
[visual] Handle rowspan on pasted table cells

GitOrigin-RevId: 53dda99ae1c300b9c4ec8f711b70b16ef66392c8
2023-09-07 08:04:42 +00:00
Mathias Jakobsen
6cde5e2e90 Merge pull request #14690 from overleaf/mj-table-gen-toolbar-wrap
[visual] Wrap table generator toolbar on overflow

GitOrigin-RevId: ef4d5b7f8fe79eefb6d2ad2f89c8ae198e2c701d
2023-09-07 08:04:37 +00:00
Mathias Jakobsen
73d3537f32 Merge pull request #14656 from overleaf/mj-table-generator-analytics
[visual] Add analytics to table generator

GitOrigin-RevId: ab5e9c9a870b76d2d51c74190f386b1de5153bb1
2023-09-07 08:04:33 +00:00
Tim Down
5748ee4496 Merge pull request #14230 from overleaf/td-review-panel-add-comment-reappear
React review panel: ensure that "Add comment" entry reappears after clicking away then back

GitOrigin-RevId: fc1b656304d71876d8a4728648b73e1d3f873817
2023-09-06 08:06:41 +00:00
Tim Down
5cce9683fa Merge pull request #14628 from overleaf/td-review-panel-scroll-jump
Fix scroll jump and improvements to React review panel layout and performance

GitOrigin-RevId: 3123f90abeb1bf9712ba4025a272e13990aebbd9
2023-09-06 08:06:32 +00:00
Mathias Jakobsen
4f977a0ca7 Merge pull request #14618 from overleaf/ae-paragraph-newline
[visual] Add newlines after all paragraphs that aren't inside lists or tables

GitOrigin-RevId: 4e8b5b6ce07845fdf7614f7129aac2a88b3bb723
2023-09-06 08:05:25 +00:00
Mathias Jakobsen
ad38ac233b Merge pull request #14653 from overleaf/mj-column-spacing-parsing
[visual] Support cell spacing declarations

GitOrigin-RevId: 16b4ddc196558679301010378912b14f6295e05f
2023-09-06 08:05:20 +00:00
Mathias Jakobsen
d98288605a Merge pull request #14649 from overleaf/mj-table-gen-remove-columns-left
[visual] Fix removing multiple columns starting from the left in table generator

GitOrigin-RevId: d52adc3cb06e897f82c8ec1157e48e165683a14e
2023-09-06 08:05:15 +00:00
Mathias Jakobsen
5d33e5a658 Merge pull request #14630 from overleaf/mj-table-copy-paste
[visual] Fix copying and pasting with multicolumn

GitOrigin-RevId: 4710cedb40493ed018daf122e68aecfb91e1efc4
2023-09-05 08:05:13 +00:00
Mathias Jakobsen
2eff1bdf36 Merge pull request #14295 from overleaf/mj-table-gen-help-modal
[visual] Add help modal to table generator

GitOrigin-RevId: 48827734d2aa356f4547f1e6638381a1dd96b7e6
2023-09-05 08:04:52 +00:00
Mathias Jakobsen
c8413c6cc6 Merge pull request #14596 from overleaf/mj-manual-cell-widths
[visual] Manually calculate column widths in table generator

GitOrigin-RevId: ce42219098d56cca2fbdb1bef6ad33a11d79fb25
2023-09-05 08:04:47 +00:00
Mathias Jakobsen
2516f271b1 Merge pull request #14559 from overleaf/mj-table-add-row-borders
[visual] Table generator improvements

GitOrigin-RevId: 8d3d1b382c68c13480b3aa50b6764903ff59ae81
2023-09-05 08:04:43 +00:00
Mathias Jakobsen
8e6d6f8689 Merge pull request #14548 from overleaf/mj-early-exit-table-rendering
[visual] Show code when table generator fails rendering

GitOrigin-RevId: 6c1908b0c68cc965e445736f0c320f322d23c988
2023-09-05 08:04:39 +00:00
Alf Eaton
d92dc66e30 Protect special characters in pasted HTML (#14476)
GitOrigin-RevId: 7288f6696ed9af78c1ea4cc94d0e8022da90aacf
2023-09-04 08:04:54 +00:00
Alf Eaton
a0347c53f0 [visual] Decorate backslash-prefixed dollar sign (#14552)
GitOrigin-RevId: 3d846eeb1a25051b794a3673e9f48ac7fe4b2cbf
2023-09-04 08:04:50 +00:00
Alf Eaton
7004b5bacf [visual] Provide UI for toggling between plain text and formatted content after pasting (#14568)
GitOrigin-RevId: 3592d5507090a179d68e8e5f56f9e885639cac76
2023-09-04 08:04:45 +00:00
Alf Eaton
2b7119502c Merge pull request #14588 from overleaf/ae-paste-blockquote
[visual] Handle pasted blockquote

GitOrigin-RevId: 5acc257a464886c1f90daf9192c87cccf158927e
2023-09-04 08:04:40 +00:00
Alf Eaton
aef9821e00 Only end the preamble at MakeTitle if directly inside DocumentEnvironment (#14593)
GitOrigin-RevId: 3252a8260e02728c05b753433e3488b799b18de0
2023-09-04 08:04:36 +00:00
Mathias Jakobsen
28d8c2b135 Merge pull request #14499 from overleaf/mj-table-gen-tests
[visual] Add cypress tests for table generator

GitOrigin-RevId: 03bdd315221f8a5998fd37de4c955635dcc86148
2023-08-30 08:04:40 +00:00
Mathias Jakobsen
a3ee0dcd39 Merge pull request #14495 from overleaf/mj-table-gen-textarea
[visual] Use textarea instead of input in table generator

GitOrigin-RevId: 5d394f9978dc25bebf63f1cbd4f1c39466469843
2023-08-30 08:04:36 +00:00
Alf Eaton
03fbc5e0a8 [visual] Place cursor in editable content when closing the preamble (#14162)
GitOrigin-RevId: 35f146caa4469c7f31fb00dc6047a421b1daadb0
2023-08-30 08:04:27 +00:00
Alf Eaton
1e286c263c [visual] Avoid pasting formatted content into a math container (#14475)
GitOrigin-RevId: e563e27bf80092df7b296878536ca2d4549c4d2a
2023-08-30 08:04:23 +00:00
Alf Eaton
cf319b61b4 [visual] Improved pasted HTML handling (#14384)
* Replace non-breaking spaces added by Chrome on copy
* Ignore text/html from VS Code
* Improve table border handling
* Remove unused cy.spy
* Map em to textit and strong to textbf
* Left-align table cells by default
* Remove "justify" mapping
* Detect border on table row
* Remove protection for special characters in pasted HTML
* If the only pasted HTML content is in a code block, use the plain text version
* Enable paste-html feature in Storybook
* Improve table handling

GitOrigin-RevId: a912aa1fc659089451103e63c5d0fd3ae2a30627
2023-08-30 08:04:19 +00:00
Mathias Jakobsen
8b5278c076 Merge pull request #14428 from overleaf/mj-table-gen-cleanup
[visual] Table generator tweaks and improvements

GitOrigin-RevId: 621820c613924bc201ec85ea249edd6c9b6f88b2
2023-08-25 08:04:12 +00:00
Mathias Jakobsen
b987e59d60 Merge pull request #14340 from overleaf/mj-table-col-span
[visual] Support table multicolumn

GitOrigin-RevId: dd9cd2d5686d72dc9f53beb502a724a36f9c0bcf
2023-08-25 08:04:07 +00:00
Alf Eaton
96195177a3 Remove Grammarly warning (#14423)
GitOrigin-RevId: 623ecffabdce9fc15dfb62361822afb75bd1cfa8
2023-08-24 08:04:02 +00:00
Domagoj Kriskovic
f37ae7a5f8 [cm6] fix toggling ranges next to command (#14183)
GitOrigin-RevId: 4959419a09415b202dc7ce2271e9691d2c2387d4
2023-08-18 12:11:24 +00:00
Domagoj Kriskovic
b126d1f8f6 [cm6] select spell checked word with keyboard (#14257)
GitOrigin-RevId: 88b936a80fd63935c007276393a441a17a79c230
2023-08-18 12:11:19 +00:00
ilkin-overleaf
fc9d3755c2 Merge pull request #14361 from overleaf/ii-add-comment-review-panel
[web] Open current file view mode when adding comment through editor widget

GitOrigin-RevId: 7028ab2a2b6369064712d456c8ae1d33498b8002
2023-08-18 12:11:11 +00:00
Alf Eaton
28a7c13887 Fix path to Lezer LaTeX examples (#14364)
GitOrigin-RevId: bcabe1b73f09078367976456e4d1fddc02688b80
2023-08-18 08:05:18 +00:00
Alf Eaton
c90f4bee62 [visual] Only use the first document environment when calculating the preamble (#14343)
GitOrigin-RevId: fc7cb26f2e71bd1142f0269b7b95cacad3cf10a5
2023-08-18 08:05:13 +00:00
Alf Eaton
06aa92d0fd Only exclude the current command from autocompletion (#14367)
GitOrigin-RevId: 1f1dc0f2c3bcd19b12e06ec56d2d82181b0b5c6d
2023-08-18 08:05:09 +00:00
Alf Eaton
fbb0ab210e [cm6] Configure "4 spaces" as the indent unit for all files (#14366)
GitOrigin-RevId: 5aed6bc5abfd194c11830bdedcbba65ef1ed0522
2023-08-18 08:05:04 +00:00
Mathias Jakobsen
2d15ce8d05 Merge pull request #14317 from overleaf/mj-table-gen-update
[visual] in-place table generator updates

GitOrigin-RevId: 410411fd9158e6c8c6fe6a5300556800732a252a
2023-08-18 08:04:56 +00:00
Mathias Jakobsen
583222d5a5 Merge pull request #14305 from overleaf/mj-table-buttons
[visual] Add toolbar actions to delete table and manage captions

GitOrigin-RevId: 7a6aefd77fc4a66a1b78ae0727d4ece962fdd040
2023-08-18 08:04:47 +00:00
Mathias Jakobsen
8caa1f8e14 Merge pull request #14228 from overleaf/mj-table-icon
[cm6] Change table toolbar icon to table_chart

GitOrigin-RevId: b058919ad8a860a73d08784c86709119bbee4890
2023-08-18 08:04:42 +00:00
Alf Eaton
975ea16317 Avoid handling pasted HTML if there are files on the clipboard (#14321)
GitOrigin-RevId: 8bb258545f1763bf511817665c89e6f948dc0f62
2023-08-16 08:04:06 +00:00
Alf Eaton
a55bb9c4b2 [visual] Improve pasting of a table containing a caption (#14322)
GitOrigin-RevId: 6d7676a9412c5614f85c17e16509c80ad937cc40
2023-08-16 08:04:01 +00:00
Alf Eaton
a8d7306fc4 [cm6] Allow optional parameters in \def macro definition (#14329)
* Allow optional parameters in `\def` macro definition
* Allow whitespace in `\def` macro definition
* [lezer] Add test for optional macro parameter
* [lezer] Add test for whitespace before def csname

---------

Co-authored-by: Mathias Jakobsen <mathias.jakobsen@overleaf.com>
GitOrigin-RevId: 342b1198c90e11a1c6d3f63573d0540dfc5fd9a9
2023-08-16 08:03:57 +00:00
Alf Eaton
ffdb651998 Update unavailable Visual Editor tooltip (#14285)
GitOrigin-RevId: 3f19c2a3c55199c8b25aa5ebe0c4f1222aa84363
2023-08-16 08:03:53 +00:00
Alf Eaton
c8f0885316 Remove CM5 Rich Text module (#11776)
GitOrigin-RevId: 812d3b5f1df7e769c8be732ccb31653e8e9a8aa3
2023-08-16 08:03:35 +00:00
Mathias Jakobsen
421186df1c Merge pull request #14288 from overleaf/mj-table-gen-error-state-rework
[visual] Update look of table generator error state

GitOrigin-RevId: a16787131236ed2a59af48639c4ae5d196b39597
2023-08-15 08:03:08 +00:00
Mathias Jakobsen
5c5c5be594 Merge pull request #14249 from overleaf/mj-delete-row-column
[visual] Enable buttons for deleting and adding columns or rows

GitOrigin-RevId: 5cb68091d79b46eab507510e03180852b97666b9
2023-08-15 08:03:05 +00:00
Mathias Jakobsen
31c285871a Merge pull request #14248 from overleaf/mj-table-cell-alignment
[visual] Enable cell alignment in table generator

GitOrigin-RevId: 31be50712fd6b3b1da37b0906965f70618f6a9b3
2023-08-15 08:03:03 +00:00