Commit graph

32 commits

Author SHA1 Message Date
Antoine Clausse
b2e7477467 [web] Migrate AI Error Assistant to BS5 (#21129)
* [storybook] Rerender story when switching BS3/BS5

* [storybook] Add SCSS loader to storybook

* [storybook] Add some AI error assistant stories

* Rename ai-error-assistant.less to .scss

* Update less variables to sass

* Remove duplicated selector

* Replace react-bootstrap components by `OL...`

* Update Checkboxes after BS5 update

* Add IDs so clicking on labels work
* Add BS5 class name in SCSS

Note: `answer-not-detailed` is used twice in the Radios. I think it's a mistake: there should be another name for the "ai_feedback_the_suggestion_wasnt_the_best_fix_available" radio

* Rename ID `answer-not-detailed` -> `answer-not-best-fix`

* Pass name and value to BS3Radio/BS3Checkbox

* [storybook] Add delay before AI suggestion (shows the animation)

* Add a number after the checkbox/radio IDs, to allow multiple forms to be displayed

Without this, clicks on second form are updating the first form!

Another solution could be to wrap the input in the label, but it comes with other problems. See https://css-tricks.com/html-inputs-and-labels-a-love-story/

* [storybook] Update `LabsAiPromoBanner`

* Use CSS variables instead of hardcoded values

* Make radio input flex

* Replace `blue-10` by `bg-info-03`

* Fix `SuggestFixButton`

* Fix `AiErrorAssistantCopyCode`

* Fix button loading in BS5

* Use OLBadge

* Fix Button variants

* Update `suggestFixAction`

* Migrate Tooltip and Button to BS5 in LabsExperimentWidget

* Update BS3/BS5 button classname in AiErrorAssistantCopyCode

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>

* [storybook] Allow to choose props of `LabsExperimentWidget`

* Fixup `OLTooltip`: Display the tooltip on disabled button in BS5

* Update Tooltips to BS5

---------

Co-authored-by: Rebeka <rebeka.dekany@overleaf.com>
GitOrigin-RevId: 08d594e772c0a3b6db1c6081337cc2d079f478a5
2024-10-23 08:06:36 +00:00
Antoine Clausse
30860ae9f9 [web] Migrate PDF Logs to BS5 (#21062)
* [web] Migrate Logs components JSX to Bootstrap 5

* [web] Migrate logs.less to logs.scss

* [web] Remove unused class names

* [storybook] Define default Bootstrap version in Storybook

This prevents some warning in the console

* [storybook] Update pdf-preview.stories.jsx

* [storybook] Add pdf-log-entry.stories.tsx

* [storybook] Force re-renders when switching BS version

* [web] Keep files dropdown menu in bounds

* [web] Make files dropdown items not bold in BS5

* [web] Revert unrelated change

* [web] Fixup PreviewLogsPaneMaxEntries

* [web] Add style for log-entry-content-link

* [web] Replace log-entry by OLNotification in `PdfCodeCheckFailedNotice`

* [web] Use `BootstrapVersionSwitcher` instead of `isBootstrap5`

* [web] Rename `DropdownBS3` to `BS3Dropdown`

* [web] Reuse variables for `toolbar-height` and `toolbar-small-height`

* [web] Set `id` on `DropdownToggle` not `Dropdown`

* [web] Set `log-entry-btn-expand-collapse` in BS3 only

* [web] Remove `block: true` from StartFreeTrialButton in BS3

* [web] Remove unnecessary CSS in `.log-entry-header-link`

* [web] Use semantic color names

* Migrate the downloadable pdf file list to Bootstrap 5

* Remove nested BootstrapVersionSwitcher, fix "key" prop

* Update roles to: `<li role="menuitem">` `<a role="link">`

* Update `log-entry-header-link`: variant ghost and fix colors

---------

Co-authored-by: Rebeka <o.dekany@gmail.com>
GitOrigin-RevId: 89848970ab5d8a8c135335386caf24363f69a34c
2024-10-23 08:06:32 +00:00
ilkin-overleaf
8bc374c916 Merge pull request #21115 from overleaf/ii-bs5-review-panel
[web] BS5 review panel new

GitOrigin-RevId: c65d17d0053858bd74984ba746a620b89d900606
2024-10-21 08:04:37 +00:00
Antoine Clausse
4a8b79080b [storybook] Update Storybook and add a control for BS3/BS5 (#20948)
* [storybook] Update Storybook to version 8.3.5

* [storybook] Run storybook with `--no-open`. Fixes xdg-utils issue

* [storybook] Create decorator for BS3/BS5

* [storybook] Add `bsVersionDecorator` to stories

* [storybook] Fix bugs in stories

* [storybook] Fixup `useMeta` type. Use `DeepPartial`

* [storybook] Fix types

GitOrigin-RevId: 48c0f0fefb1ab2d4863ab59051b900b1908a613c
2024-10-14 11:07:40 +00:00
ilkin-overleaf
874c0211d7 Merge pull request #20926 from overleaf/ae-storybook-wasm
Add Storybook webpack config for wasm files

GitOrigin-RevId: a5e0e3b6af7865c3f8285c9b7bef8a4efae3a55b
2024-10-14 11:06:22 +00:00
Jakob Ackermann
aa480a2663 Merge pull request #18898 from overleaf/jpa-no-window
[web] migrate from window attributes to getMeta

GitOrigin-RevId: 3dcf1ab6b01155e5e4abeb3e78d0fa9053e055bc
2024-06-19 08:04:21 +00:00
Antoine Clausse
a8f46f1d75 [web] Add with-split-tests util for storybook (#17809)
* Add `with-split-tests` util for storybook

It wraps storybook in a SplitTest context provider with configurable variant values. And it adds controls for them in the storybook UI

* Define `splitTestsArgTypes` in `withSplitTests`

* Revert "Add `with-split-tests` util for storybook"

This reverts commit 3ff351ac

* Edit stories: remove SplitTestProvider and add more digits to amounts

* Create `addon-split-tests` to manage split-tests from Storybook

* Add a `splitTests` parameter to define individual Stories relevant split-tests

* Revert "Add a `splitTests` parameter to define individual Stories relevant split-tests"

This reverts commit 6cbf62729a3d682d695c36e11a86bd576cb7aec1.

* Revert "Create `addon-split-tests` to manage split-tests from Storybook"

This reverts commit d0734a1773c96860e82d81fd62fc9034e2b6e41c.

* Revert "Revert "Add `with-split-tests` util for storybook""

This reverts commit 407fc39b

* Improve types of price-summary.stories.tsx

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>

---------

Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: bcf3d9f317590a00fb633851ef36146eb800fcfc
2024-05-15 08:04:38 +00:00
Alf Eaton
362a947c5a Add prototype compile assistant (#17402)
GitOrigin-RevId: 07547f2a83aec8cfda75c589ed24cdc85fe15b59
2024-03-26 09:04:28 +00:00
Alf Eaton
ad8648871c Upgrade Storybook to v8 (#17522)
GitOrigin-RevId: 9cc61614ef0a5661549a8842b61bc2ead9537939
2024-03-26 09:04:10 +00:00
Tim Down
07e16838b8 Merge pull request #16971 from overleaf/td-bootstrap-5-base
Bootstrap 5 base

GitOrigin-RevId: 2ac614298d31a9cf65430a46d726648a742044f9
2024-02-15 09:04:05 +00:00
Jakob Ackermann
63520c7076 Merge pull request #16859 from overleaf/jpa-sharelatex-cleanup
[misc] ShareLaTeX cleanup - high impact

GitOrigin-RevId: 6dcce9b0f15e30f7afcf6d69c3df36a369f38120
2024-02-09 09:04:11 +00:00
Alf Eaton
76d195cd39 Move Storybook back into web (#13219)
GitOrigin-RevId: 61b69b5fd178dd4f5ab26858c434f959dfc410bc
2023-12-15 09:03:15 +00:00
Alf Eaton
99607d4afc Move Storybook to tools (#7248)
GitOrigin-RevId: 2dd57d9adda07b01ad3d9aeee7a2e9e8986fae24
2022-04-05 12:17:36 +00:00
Alf Eaton
7f4934d619 Add TypeScript file extensions to Storybook config (#7163)
GitOrigin-RevId: f070c8555d570bfdf02958bfbb241def8cacb263
2022-03-23 09:02:51 +00:00
Alf Eaton
9f969d07e0 Delete unused PDF-related code (#6334)
* Remove new logs UI code
* Remove unused preview components
* Move metrics file
* Remove Angular PDF controllers
* Move the service worker util functions
* Remove the ide/pdfng folder
* Remove vendored pdf.js
* Remove showNewPdfPreview
* Use mockCompile
* Remove split test code

GitOrigin-RevId: 723b7440c62cda51f6ad8bb9c691900882166d21
2022-03-16 09:03:04 +00:00
Alf Eaton
7be97fb2e2 [web] Fix Storybook (#6803)
* Move deprecated CLI option to config
* Reduce custom Storybook webpack config
* Upgrade Storybook
* Update package-lock.json

GitOrigin-RevId: e480aa0298e481d3e78a62b91c067b62c05bdeaf
2022-02-24 09:03:32 +00:00
Alf Eaton
2bf422b76d Merge pull request #5522 from overleaf/ae-compile-feature-flag
Only use the React compiler when showNewPdfPreview is set

GitOrigin-RevId: 24bf8dc6a830e670ee8dc30b8e0329127de1a1a8
2021-10-22 08:03:31 +00:00
Alf Eaton
4274782443 Improve LESS loading in Storybook (#5406)
GitOrigin-RevId: ad128b8be645ed54de498b543f655751a6a0799b
2021-10-13 08:03:21 +00:00
Alf Eaton
04347d54ac Merge pull request #5128 from overleaf/ae-storybook-project-id
Set window.project_id in Storybook config

GitOrigin-RevId: 51d43b3be9afcd6b61e86701b00f479e8f32d525
2021-09-20 08:03:04 +00:00
Alf Eaton
7c97f8ab6e Switch to new JSX runtime (#4225)
* Use new JSX runtime and update Babel Node target
* Update .eslintrc
* Remove React imports

GitOrigin-RevId: 559de0267f8f2934c56a860ea8701bb522aa861a
2021-06-24 02:06:59 +00:00
Jakob Ackermann
3f1ae7bff2 Merge pull request #4044 from overleaf/as-file-views-text-extension
Pull text extension list from settings, instead of hard-coding it

GitOrigin-RevId: b5ba956b8f065b852a2f5efc1a775ccb70df3226
2021-05-22 02:05:53 +00:00
Alf Eaton
b777e958d4 Merge pull request #3926 from overleaf/ae-decaffeinate
Decaffeinate settings files

GitOrigin-RevId: e9eed42864d537bb1ff5a46c05d990c819afc8eb
2021-05-20 02:05:15 +00:00
Alf Eaton
e832c9ed70 Add StartFreeTrialButton
GitOrigin-RevId: dd9ab4bb12e8b9071b2a869e2d452945b49d9cd7
2021-05-08 02:09:50 +00:00
Alf Eaton
1be43911b4 Merge pull request #3942 from overleaf/prettier-trailing-comma
Set Prettier's "trailingComma" setting to "es5"

GitOrigin-RevId: 9f14150511929a855b27467ad17be6ab262fe5d5
2021-04-28 02:10:01 +00:00
Alf Eaton
79a520dd1c Use defaultVariables to define variables for all translations (#3815)
GitOrigin-RevId: d7b30f523edba7c384d5207a44643acdbbedc74c
2021-03-26 03:04:45 +00:00
Alf Eaton
ba4300d9e1 Merge pull request #3518 from overleaf/ae-react-create-file-modal
Migrate "Add Files" modal to React

GitOrigin-RevId: fc5235108ee65294e3176da9c327791c34aa5b3c
2021-03-19 03:04:46 +00:00
Alf Eaton
d9576189a3 Merge pull request #3636 from overleaf/ae-share-modal-split
Migrate Share modal to React

GitOrigin-RevId: 96a52df6ffd751cfcca2bbb68eb9e7a6dc31ff28
2021-03-13 03:05:10 +00:00
Alf Eaton
a481ffef17 Merge pull request #3645 from overleaf/ae-import-config
Add config for optional modules

GitOrigin-RevId: 082261eff5d505ce98dfaafe179547b312c0511b
2021-03-04 03:04:21 +00:00
Miguel Serrano
ceab823447 Merge pull request #3620 from overleaf/ae-storybook-theme
Improve Storybook theming

GitOrigin-RevId: f02f0cfc8d13ca1a1510bd840afdc8f326fb6750
2021-02-10 03:04:47 +00:00
Hugh O'Brien
4fe179f69e Merge pull request #3616 from overleaf/ae-storybook-docs
Configure Storybook to render Docs stories in iframes

GitOrigin-RevId: ef96a0fad445375fc33c5875958c4a3170f0818e
2021-02-04 03:04:34 +00:00
Hugh O'Brien
7812a77cd8 Merge pull request #3449 from overleaf/ta-storybook-sentry
Stub ExposedSettings in Storybook

GitOrigin-RevId: 2729b181bba869ab3ce8d896e8cff25d5e42c142
2020-12-10 03:05:02 +00:00
Alasdair Smith
f5449dc4b0 Merge pull request #3191 from overleaf/as-storybook
Set up Storybook and add Outline stories

GitOrigin-RevId: 2635ad142ef152a5ee8023c10cf31f344fbd7e8d
2020-09-27 02:05:38 +00:00