Alf Eaton
08ccdb79d3
[cm6] Improve alignment of review panel elements ( #12710 )
...
* Use a block widget for top padding
* Update review panel positions when the editor geometry changes
* Remove editorPaddingTop from position calculations
* Recalculate review panel on start adding comment
* Assert on line content rather than index
* Use broadcastChange
* Keep focus in the editor when opening the review panel
* debounce broadcastChange
* Set CULL_AFTER to Infinity
GitOrigin-RevId: a8d7b8967736a9164b5264eeaadf334c15ec95ce
2023-04-25 08:05:02 +00:00
Alf Eaton
acf6abb0fb
[cm6] Use a block widget for padding at the top of the editor ( #12705 )
...
GitOrigin-RevId: 000ce9c90ea6b2ca72ab969704354a19fcea7a87
2023-04-25 08:04:53 +00:00
Mathias Jakobsen
81a8fa2ce3
Merge pull request #12672 from overleaf/ae-emacs-compile-keydown
...
[cm6] Stop propagation of Ctrl-s when Emacs keybindings are enabled
GitOrigin-RevId: 32bebefb583ad813931af221cce7498d40fdbaf1
2023-04-21 08:03:11 +00:00
Mathias Jakobsen
462837b44d
Merge pull request #12701 from overleaf/dk-cm6-autocomplete-item-space
...
[cm6] Add space after item autocomplete
GitOrigin-RevId: 6fff77c0c0563530af981bbac73b1d88e02bb759
2023-04-21 08:03:08 +00:00
Mathias Jakobsen
29b056d5a3
Merge pull request #12682 from overleaf/mj-def-whitespace
...
[lezer] Allow whitespace before macro parameter
GitOrigin-RevId: 14bd8428f0a78fb71184bf300dac0b2b1e3abd3c
2023-04-21 08:03:02 +00:00
Mathias Jakobsen
3bd174631a
Merge pull request #12696 from overleaf/mj-rt-skip-more-preamble
...
[cm6+rt] Update skip-preamble-cursor to skip \maketitle and abstract
GitOrigin-RevId: 3c54d8159bfdb431763872790a2b82ac4cffc09f
2023-04-21 08:02:59 +00:00
Mathias Jakobsen
59b3b9b933
Merge pull request #12631 from overleaf/ae-readonly-focus
...
[cm6] Prevent the editor being focused when read-only
GitOrigin-RevId: 7de9f2df2421b57b3315d59d640f7c8b46caf178
2023-04-21 08:02:56 +00:00
Mathias Jakobsen
c2292a8567
Merge pull request #12677 from overleaf/ae-codemirror-view-upgrade
...
[cm6] Upgrade CodeMirror dependencies
GitOrigin-RevId: cc973b1c5b23eca0fc93a9b3a970c832212e47af
2023-04-21 08:02:53 +00:00
Alf Eaton
924012e21f
[cm6] Avoid overwriting themed syntax highlighting colours when editing Markdown ( #12648 )
...
GitOrigin-RevId: ed5d558544839978862004a8b7feb80806a2100d
2023-04-19 08:03:04 +00:00
Alf Eaton
5717f51042
Merge pull request #12643 from overleaf/ae-initial-active-line-highlight
...
[cm6] Fix initial active line highlight
GitOrigin-RevId: 54de6a176e826ed7d7f1016ba6cee7a8803f0be4
2023-04-19 08:02:53 +00:00
Mathias Jakobsen
c8f7bc54bc
[web] Add split test for testing editor switch naming ( #12596 )
...
Co-authored-by: Ieva Vaiginyte <95856891+ievaoverleaf@users.noreply.github.com>
GitOrigin-RevId: dafe07bda841dad962ebf2894718750fafe86373
2023-04-18 08:04:59 +00:00
Alf Eaton
63b2064420
[cm6] Add scrollIntoView when commands are dispatched ( #11678 )
...
GitOrigin-RevId: be005885330b9b29c7ddbfeacaec0a41d96e5e25
2023-04-17 08:05:33 +00:00
Mathias Jakobsen
7d237d0103
[cm6] Only swallow text in autocomplete insertion if node is well-formed ( #12562 )
...
* [cm6] Only swallow text in autocomplete insertion if node is well-formed
* [cm6] Use longest common prefix heuristic for autocompletion in ill-formed nodes
GitOrigin-RevId: 5adf3dc0314d86b267e2142a1250dece3ab29ef8
2023-04-17 08:05:24 +00:00
Mathias Jakobsen
73191f56e1
[cm6+rt] Make formatting commands work after UnknownCommands without arguments ( #12625 )
...
GitOrigin-RevId: 0eb59e6580d6f217c46424ede0fa6f79c8786940
2023-04-17 08:05:16 +00:00
Mathias Jakobsen
4b2cc907e2
[cm6] Change Emacs commands to visual-line-mode ( #12523 )
...
* [cm6] Change Emacs commands to visual-line-mode
* [cm6] Change line deletion commands to visual line mode
GitOrigin-RevId: 7a4f3d66bec611de410b6c1fbafbfe33b974e37b
2023-04-17 08:05:08 +00:00
Alf Eaton
359255b820
[cm6] Use a modified fork of the closeBrackets extension ( #12573 )
...
GitOrigin-RevId: a24020ed216cb10defff989f5876666c29889de2
2023-04-17 08:04:43 +00:00
Alf Eaton
dda9230c6c
[rich text] Add "Insert Citation" and "Insert Cross-reference" buttons ( #12529 )
...
GitOrigin-RevId: fde2f1a281318afede138ccae12f73ade3fa9f65
2023-04-17 08:04:34 +00:00
Alf Eaton
39df55787c
Improve handling of doc:saved events ( #12522 )
...
GitOrigin-RevId: 0ebf198548f6aeecb356405b0c582d3fd64db391
2023-04-17 08:04:26 +00:00
Alf Eaton
a8ed6b65e1
[cm6] Improve "vertical overflow" handling ( #12405 )
...
* Avoid setting style on the editor view whenever overflowPaddingState changes
* Round values in recalculateScreenPositions
* Refactor ignoreGeometryChangesUntil slightly
* Restore the original value
GitOrigin-RevId: 75c57be21dd16a748c0d9b14058386849a80b831
2023-04-17 08:04:18 +00:00
Alf Eaton
ab10fd99f5
Add CodeMirror dev tools extension ( #12142 )
...
GitOrigin-RevId: 148a0fba5faf6dc8f638fcb4666e2fda6c5c6c40
2023-04-17 08:04:09 +00:00
Alf Eaton
161decd67d
Upgrade @codemirror/view ( #12574 )
...
* Upgrade @codemirror/view
* Disable emptyLineFiller extension
GitOrigin-RevId: 57ce4194ece0ea448e24184f0b3a3e13352cb014
2023-04-17 08:04:00 +00:00
Tim Down
7f37ba737c
Move source editor out of module ( #12457 )
...
* Update Copybara options in preparation for open-sourcing the source editor
* Move files
* Update paths
* Remove source-editor module and checks for its existence
* Explicitly mention CM6 license in files that contain code adapted from CM6
GitOrigin-RevId: 89b7cc2b409db01ad103198ccbd1b126ab56349b
2023-04-13 08:40:56 +00:00
Jessica Lawshe
a4586074d7
Merge pull request #12442 from overleaf/jel-bsStyle
...
[web] Add bsStyle to `react-bootstrap` buttons
GitOrigin-RevId: 0059a457cbd8b4c316aa3b34e4d77f1b92bd690e
2023-04-05 08:02:50 +00:00
Alf Eaton
1807f18b7d
Add a tooltip to the disabled Rich Text toggle ( #11843 )
...
GitOrigin-RevId: e7be96c68d87ab1f1ed40c8e9784160689ee8e96
2023-02-17 09:04:15 +00:00
Miguel Serrano
286cbc66a8
Merge pull request #11771 from overleaf/msm-force-ace-sp
...
[web] Force Ace editor in Server Pro
GitOrigin-RevId: 1ea5675ad1c64a15dc30566c02d694feb2aaed3c
2023-02-10 09:12:26 +00:00
June Kelly
035b5cd456
Merge pull request #11263 from overleaf/ae-rich-text-available
...
Only enable the Rich Text option for supported file extensions
GitOrigin-RevId: ae67435b50701bb5be71bab94d8c3c4da4129d88
2023-02-09 09:05:05 +00:00
Tim Down
fd90261313
Merge pull request #11465 from overleaf/td-remove-ace-tooltip
...
Remove info icon next to editor switch for users without Ace option
GitOrigin-RevId: 69fa8af8ddd40c47a58de50eb9aa79cc82629aa8
2023-01-26 09:04:38 +00:00
Tim Down
a05438d9c7
Merge pull request #11332 from overleaf/td-remove-ace-split-test
...
Add handling for source-editor-legacy split test
GitOrigin-RevId: 9575087c34bc3f2e8b490846984bc97641c560aa
2023-01-25 09:06:26 +00:00
Alf Eaton
017f0b49a0
[rich-text] Add "rich-text" split test ( #11180 )
...
GitOrigin-RevId: 8df79f3c70020c8dba0793c8b548fd1f1e1fbf76
2023-01-13 09:04:31 +00:00
Alf Eaton
9f1f62b9be
Add rich-text mode to CM6 ( #10775 )
...
Co-Authored-By: Mathias Jakobsen <3295293+hrjakobsen@users.noreply.github.com>
GitOrigin-RevId: 00e015cb216bb8a52d083e71b34dbe91a7cd6cc5
2022-12-13 09:03:54 +00:00
Davinder Singh
d6b39c4bb3
Merge pull request #10653 from overleaf/ds-btn-default-to-secondary-in-editor
...
Replacing `btn-default` with `btn-secondary` in the editor
GitOrigin-RevId: 46aa8c92c9981eb2f253828ee65424bfb7217fb2
2022-12-08 09:03:35 +00:00
Tim Down
08567c290e
Add second CM6 switch-away survey ( #10789 )
...
Restart CM6 switch-away survey
GitOrigin-RevId: 1d62aaf27834cb3919f6ca30c269a1ef3c2e9a5e
2022-12-07 09:04:35 +00:00
Tim Down
fa67c3fcff
Merge pull request #10797 from overleaf/td-editor-toggle-analytics
...
Add analytics for switching editor
GitOrigin-RevId: 7b44e53105e8669e97cb9c4821dfbc830faff779
2022-12-07 09:04:06 +00:00
M Fahru
31c503be2d
Add 10 seconds delay before showing grammarly warning
...
GitOrigin-RevId: 11bb3ca5704ef5cc782d14eb6f4f10a1fa2a656e
2022-11-25 09:04:33 +00:00
M Fahru
d70e0b1c0e
Implement grammarly warning alert on cm6 users
...
GitOrigin-RevId: ed272bbc385faa69811ec1891075906cdca1c984
2022-11-16 09:06:39 +00:00
Davinder Singh
c6f8b17647
Merge pull request #10286 from overleaf/jel-ds-toggle
...
Fix toggle and `Switch to PDF` aligment
GitOrigin-RevId: d3c77ff34829af875d2b8b9e3797e0e7db867631
2022-11-16 09:04:26 +00:00
Jakob Ackermann
1c529d5dcf
Merge pull request #10339 from overleaf/as-fix-switch-back
...
Fix bug in CM6 switch away survey where going back from Ace to CM6 will still show the survey
GitOrigin-RevId: 5900fafb1a4a5fab7d949b1c70af31e19a764e6e
2022-11-08 09:04:38 +00:00
M Fahru
b593bfa56e
Don't show cm6 switch away survey if cm6 is not available
...
GitOrigin-RevId: e283fc424055f6df85015f02c83ad8314865697d
2022-11-04 09:06:10 +00:00
M Fahru
19dd2f67e2
Implement "switch away survey" when users switching back to ace from cm6 ( #10201 )
...
Implement legacy source editor survey:
* Force user to switch to cm6 if they haven't seen switch away survey
* Only show user switch away survey if they open ace from another editor
* We need to wait 3 seconds until the survey is being shown
* Add comment to explain the reasoning of not showing cm6 switch away survey for rich text users
* Use localstorage `editor.has_seen_cm6_switch_away_survey` setter to not show the survey if user has seen the survey
* the `editor.has_seen_cm6_switch_away_survey` will have the value `true` even if user is not interacting with it, so update comment to reflect that
* Add `once: true` option to keydown event to avoid unnecessary callback invocation upon key presses
GitOrigin-RevId: c26be2bb39efac2dff112c821fca893e5993dcbf
2022-11-04 09:05:50 +00:00
Timothée Alby
7b8d277437
Merge pull request #8898 from overleaf/ta-change-redundant-controls
...
Change Redundant Layout Controls
GitOrigin-RevId: b50d71b1f75d202334442b3f6cb5037ed0d8a411
2022-07-21 08:04:25 +00:00
ilkin-overleaf
41c715c40d
Merge pull request #8378 from overleaf/ii-cm6-three-way-toggle
...
[cm6] Make cm6 as the default source editor
GitOrigin-RevId: b56724d2c147792c55ce01cf272fbcce16f87916
2022-06-15 08:05:18 +00:00
Timothée Alby
ae207f7559
Merge pull request #8326 from overleaf/ta-pdf-detach-redundant-controls
...
Bring Back Redundant Layout Controls
GitOrigin-RevId: a725e8742ab41612b285bcab23054ba9da15b60f
2022-06-09 08:02:34 +00:00
Brian Gough
fde4f72adf
Merge pull request #6779 from overleaf/ae-cm-editor-switch
...
[web] [cm6] Add a three-way switch for editor choice
GitOrigin-RevId: fff788ddad8d10488e8446de7f1503702da0985f
2022-02-22 09:03:05 +00:00