Commit graph

2569 commits

Author SHA1 Message Date
Shane Kilkelly
7f7b10aa09 Sanitize display of system messages.
When showing system-messages, use default Angular sanitizer, also,
on the admin panel itself, show the verbatim text of the message.

This solves a mild Stored-XSS vulnerability whereby a user could
put `<script>` tags in a message. We don't want that, but we do want
to be able to use basic html tags.
2018-08-22 10:15:50 +01:00
Paulo Reis
54e0a7cfd2 Merge branch 'master' into pr-change-free-history-limits 2018-08-21 11:23:28 +01:00
Henry Oswald
7a253e56ef Download all log files from compiles.sharelatex.env (#833)
* add a couple of missing buildPdfDownloadUrl

* only download pdfs from compile server when streaming

* use compiles.env for resonse files

* update config to use clsi_lb
2018-08-21 09:24:48 +01:00
Paulo Reis
042c959d3a Move default email checking logic into the data service. 2018-08-20 12:15:15 +01:00
Paulo Reis
47c51257bb Explicitly set the user default email for the delete account modal controller. 2018-08-20 11:51:12 +01:00
Jessica Lawshe
5b5ece37a5 Handle sixpack timeouts and include variant in metabase segmentation
Render default when sixpack timesout

Only convert when variant exists

Use Angular cookies module to add variant cookie, which is used on the new subscription page.
2018-08-17 10:29:45 -05:00
Paulo Reis
5974afc2e3 Make sure that at least the last update (i.e. the current state) is shown to free users (even if it happened more than 24 hours ago), to allow labelling. 2018-08-17 16:17:53 +01:00
Paulo Reis
96aa418b94 Show upgrade prompts when the free history limit is hit. 2018-08-17 16:04:31 +01:00
Paulo Reis
27823d3e06 Show history entries for the last 24 hours for free users. 2018-08-17 15:31:15 +01:00
Jessica Lawshe
356e31caec Set variant when sixpack request successful 2018-08-17 09:07:34 -05:00
Alasdair Smith
b9e63421a8 Merge pull request #814 from sharelatex/as-fix-delete-modal-copy
Fix delete wording on archive modal
2018-08-16 16:33:30 +01:00
Paulo Jorge Reis
48655afb8b Merge pull request #822 from sharelatex/ho-clsi-googlebackend
download log files using buildPdfDownloadUrl
2018-08-16 15:06:31 +01:00
Henry Oswald
c33192b852 download log files using buildPdfDownloadUrl 2018-08-16 14:25:08 +01:00
Paulo Reis
02701a996d Merge branch 'master' into pr-history-labels-part-2 2018-08-16 11:56:36 +01:00
Paulo Reis
23bb866988 Show an error message when history fails to load updates. 2018-08-16 11:26:34 +01:00
Paulo Reis
6b31268bfa Scroll to selected history update when coming back from the labels view. 2018-08-14 15:27:07 +01:00
Alasdair Smith
bd94e55ce9 Handle archive and leave action 2018-08-13 14:25:38 +01:00
Alasdair Smith
009c5c363b Also fix modal body for archiving projects 2018-08-13 14:25:38 +01:00
Alasdair Smith
5836c029c8 Show archive heading if archiving and on OL 2018-08-13 14:25:38 +01:00
Paulo Reis
2ee42af1de Change strategy to store selected label; improve the history toolbar layout to accomodate larger labels; fix issues with layout not being updated when changing history view modes. 2018-08-13 13:39:25 +01:00
Brian Gough
19dfe5fc8b intial version of user setting for texlive imageName 2018-08-13 10:53:43 +01:00
Alasdair Smith
8f4fe5ec67 Merge pull request #805 from sharelatex/ns-autocomplete-w-escaped-percent
autocomplete escaped % issue
2018-08-13 09:46:38 +01:00
Paulo Reis
a5c6f81573 Merge branch 'master' into pr-history-labels-part-2 2018-08-10 15:57:32 +01:00
Paulo Reis
035ff0a1f0 More bugfixing. 2018-08-10 15:57:10 +01:00
Paulo Reis
c13e0264e5 Fix a few bugs related to keeping the selection when moving from labels to full history. 2018-08-10 14:07:35 +01:00
Paulo Reis
7e86218b21 Allow multiple events to trigger layout external resizes. 2018-08-10 11:28:17 +01:00
Nate Stemen
e80b52509b fix silly paren issue for index var 2018-08-09 08:53:49 -04:00
Paulo Reis
64a66aafd5 Protect against reading the project members list too soon. 2018-08-09 12:16:36 +01:00
Paulo Reis
d59fe61a83 Handle sorting of labels; keep selection between view changes. 2018-08-09 11:03:00 +01:00
James Allen
69e8eddff0 Merge pull request #796 from sharelatex/pr-history-labels-ui
History labels UI
2018-08-09 10:50:28 +01:00
Paulo Reis
f2b957e5b3 Add history labels view. 2018-08-08 13:46:43 +01:00
Paulo Reis
cd853abb3c Load labels list from the backend. 2018-08-08 11:02:14 +01:00
Paulo Reis
7e8e2a89ae Create history labels list component. 2018-08-08 11:01:51 +01:00
Paulo Reis
9a27a39f55 Make tooltip optional in the label component. 2018-08-08 11:01:20 +01:00
Nate Stemen
c26a85c02c get rid of confusing regex 2018-08-07 09:53:38 -04:00
Paulo Reis
b0261970fc Make label removal also work in compare mode. 2018-08-06 11:26:22 +01:00
Paulo Reis
e0707253a7 Remove debug lines and unneeded HTML. 2018-08-06 11:03:15 +01:00
Paulo Reis
bd6dcc007b Remove prototype code. 2018-08-06 11:00:45 +01:00
Paulo Reis
2c2bb4c130 Add i18n; avoid injecting unneeded dependencies. 2018-08-02 16:28:13 +01:00
Paulo Reis
dc235b91d9 Fix some issues with the label tooltip in compare mode. 2018-08-02 16:28:13 +01:00
Paulo Reis
a8ee879746 Use history label component; restrict label deletion to label owners. 2018-08-02 16:28:13 +01:00
Paulo Reis
8c50e4e9ae Add history label component. 2018-08-02 16:28:13 +01:00
Paulo Reis
d21f6ef624 Label handling in compare mode. 2018-08-02 16:28:13 +01:00
Paulo Reis
5a64313e24 Add label delete functionality; styles. 2018-08-02 16:28:13 +01:00
Paulo Reis
3a80c34078 Basic label support (showing labels in the entries list; creating labels via a modal). 2018-08-02 16:28:13 +01:00
Nate Stemen
2dcd2339ed still trigger autocomplete if % is escaped 2018-07-26 15:03:55 -04:00
James Allen
7dc82597e1 Merge pull request #765 from sharelatex/ja-update-email-in-v1
Update email in v1 when setting as default in v2
2018-07-26 10:58:57 +01:00
James Allen
de6a790f3d Merge pull request #780 from sharelatex/ns-autocompile-w-syntax-error
dont stop compiling if user has turned off syntax validation
2018-07-24 10:06:03 +01:00
Alasdair Smith
9af906b7dc Copy across some mathjax config from v1, seems to fix artefacts in rendering 2018-07-23 17:11:55 +01:00
Nate Stemen
8d83da2535 add check to make sure user hasnt turned of syntax validation before stopping autocompile 2018-07-23 12:07:05 -04:00
Alasdair Smith
db518e16aa Don't set config unless needed in directive
Updates mathjax directive to only set config if it is needed. The main
config is now set in base.coffee so isn't needed
2018-07-23 15:32:17 +01:00
Alasdair Smith
99e24db075 Move MathJax config to base so it is always run
This prevents an issue where using MathJax would not be configured
correctly unless using the mathjax directive.
2018-07-23 15:30:58 +01:00
Alasdair Smith
85313f1b5a Check if rich text is enabled before using stored mode 2018-07-18 09:26:03 +01:00
Jessica Lawshe
b9a63fe216 Merge pull request #768 from sharelatex/jel-mathjax-wiki
Add MathJax to wiki pages and max-width for images
2018-07-17 09:37:28 -05:00
Jessica Lawshe
fa2f703c44 Define CMS module controller 2018-07-17 09:36:21 -05:00
Jessica Lawshe
6c9403df0f Merge pull request #758 from sharelatex/jel-mathjax-delimiter
Optional $ MathJax delimiter
2018-07-17 09:32:43 -05:00
Jessica Lawshe
64a257dae2 Merge pull request #708 from sharelatex/jel-mathjax
MathJax - library path, directive, and use `Safe` extension
2018-07-17 09:32:06 -05:00
Jessica Lawshe
ddca090cd7 Add Wiki controller with MathJax directive 2018-07-17 09:09:07 -05:00
James Allen
4435eab423 Update affiliations UI to show specific errors for conflicting emails 2018-07-17 11:12:47 +01:00
James Allen
b150a7b4ae Merge pull request #735 from sharelatex/pr-affiliations-ui-adjustments
Affiliations UI, second round
2018-07-16 10:08:47 +01:00
Jessica Lawshe
120acf4918 Optional $ MathJax delimiter 2018-07-13 15:02:52 -05:00
Alasdair Smith
5eb2410f5d Add event to trigger syncToPdf so can be triggered by key bind 2018-07-13 09:18:28 +01:00
James Allen
d7e0b8c369 Show unconfirmed email status in UI and add link to resend confirmation 2018-07-12 17:13:26 +01:00
Paulo Reis
67e2f6f942 Better handling of affiliation change submission. 2018-07-12 16:37:09 +01:00
Paulo Reis
59008b4a51 Show university custom departments when changing affiliations; fix Features typo. 2018-07-12 16:37:09 +01:00
Paulo Reis
a759828ece Update feature flag for affiliations; use it in the router; minor style adjustments. 2018-07-12 16:37:09 +01:00
Paulo Reis
4d1b6c6ba8 Add error handling. 2018-07-12 16:37:09 +01:00
Paulo Reis
c630c5d952 Preemptively remove front-end data when removing user emails. 2018-07-12 16:37:09 +01:00
Paulo Reis
19b57571bf Basic affiliation change implementation. 2018-07-12 16:37:08 +01:00
Paulo Reis
a64910d409 Make sure to specify which email to set as default. 2018-07-12 16:37:08 +01:00
Paulo Reis
1514e5e071 Isolate affiliations form in a component. 2018-07-12 16:37:08 +01:00
Alasdair Smith
2100633ea1 Merge pull request #748 from sharelatex/as-rt-review-panel-warning
Show warning in review panel when using rich text mode
2018-07-12 11:30:29 +01:00
Alasdair Smith
d33c7f0149 Use string key to initialise editor mode instead of boolean 2018-07-12 10:55:27 +01:00
Alasdair Smith
25b995d3b8 Initialise editor mode from localStorage 2018-07-12 10:55:27 +01:00
Alasdair Smith
b4dd047371 Fix unnecessary right marging being applied to review panel when rich text is open 2018-07-11 15:15:22 +01:00
Timothée Alby
05bc4cc9e9 Merge pull request #729 from sharelatex/as-cursor-position
Abstract cursor position tracking so that it is not bound to Ace
2018-07-11 10:21:42 +02:00
Alasdair Smith
5806101bd0 Trigger events instead of calling cursor manager
This improves readability and prevents race conditions in compat
between Ace/CM
2018-07-10 16:05:01 +01:00
Alasdair Smith
da77c06774 Refactor saving cursor position to not use Ace event
This is will help with triggering CM correctly
2018-07-10 16:05:01 +01:00
Alasdair Smith
ba9fa9a0be Store first visible line instead of scrollTop
scrollTop is affected by changing viewport size and switching between
Ace and CM
2018-07-10 16:05:01 +01:00
Alasdair Smith
6c7e942470 Unbind unload listener when destroying editor 2018-07-10 16:05:01 +01:00
Alasdair Smith
e5ad2a8724 Abstract Ace-specific code to adapter 2018-07-10 16:05:01 +01:00
Alasdair Smith
2dc509f43d Fix memory leak setting up spell check
Switching docs would set up event listeners on Ace without tearing down
any old listeners, which could lead to a memory leak. This tears down
old listeners when detaching from the "old" doc
2018-07-10 12:25:13 +01:00
Hayden Faulds
158cb58e29 Merge pull request #734 from sharelatex/sk-handle-403-linked-files
When refreshing or creating linked files, exempt from 403-error-catcher
2018-07-06 15:09:28 +01:00
Shane Kilkelly
b6880550d5 When refreshing or creating linked files, exempt from 403-error-catcher 2018-07-06 11:29:21 +01:00
James Allen
dad4bad9eb Merge pull request #700 from sharelatex/ew-fix-undefined-last-name
fix undefined last name
2018-07-06 11:06:12 +01:00
Alasdair Smith
b2abcfc3f2 Extract debounced load to service, so can be injected 2018-07-04 15:14:29 +01:00
Alasdair Smith
1f9c1ca6c6 Extracts envs to separate file so they can be exported to rich text 2018-07-04 15:14:29 +01:00
Alasdair Smith
33742d447d Move top hundred snippets to snippets directory
Allows for more snippets in future. Also makes file name consistent
2018-07-04 15:14:29 +01:00
Alberto Fernández-Capel
a1c49b0cf9 Merge pull request #694 from sharelatex/sk-linked-files-warning-when-no-projects
Add a warning message when there are no other projects to choose.
2018-07-03 13:38:33 +01:00
Alasdair Smith
04a98c4d91 Merge pull request #697 from sharelatex/pr-user-affilitations
User affiliations
2018-07-02 11:36:04 +01:00
Paulo Reis
2e46111b4b Add explanation about using template cache directly. 2018-06-28 17:02:04 +01:00
Paulo Reis
d021cd8e3f Add role hints and deparment hints (when not provided by the uni). 2018-06-28 16:37:36 +01:00
Jessica Lawshe
49cf2a8dee Use the MathJax Safe.js extension to prevent XSS 2018-06-27 17:57:07 -05:00
Jessica Lawshe
a739348146 Move MathJax directive to a shared directory
MathJax parsing now on learn pages, and soon to be on the blog, so move
out of the `ide/chat` directive.
2018-06-27 17:46:35 -05:00
Jessica Lawshe
3e8168d32f Remove MathJax dependency injection 2018-06-27 17:31:11 -05:00
Paulo Reis
82392978a7 Improve input suggestions template readability. 2018-06-27 13:47:49 +01:00
Paulo Reis
522084a504 Add Keys enum; use it when detecting keystrokes in the input suggestions component. 2018-06-27 12:21:26 +01:00
Tim Alby
60009c6346 fix delete endpoint 2018-06-26 19:50:12 +02:00
Paulo Reis
3e0ad47873 Avoid suggesting blacklisted emails as university domains. 2018-06-26 16:50:55 +01:00
Paulo Reis
76d8ab11e5 Make sure we infer the university when the user finishes typing his email. 2018-06-26 16:18:53 +01:00