James Allen
|
477278eea5
|
Merge pull request #476 from sharelatex/ja-use-new-comment-button
Fix on the new comment button variation
|
2017-04-05 11:08:59 +01:00 |
|
James Allen
|
ce59307c91
|
Merge pull request #475 from sharelatex/ja-scroll-overflow-in-review-panel
Allow scrolling in the review panel to extend outside of top of text …
|
2017-04-05 11:08:49 +01:00 |
|
Shane Kilkelly
|
0555154a24
|
Merge branch 'sk-fix-folder-creation'
|
2017-04-04 11:01:07 +01:00 |
|
Paulo Reis
|
7855afa0cd
|
Remove unused scope binding.
|
2017-04-04 10:48:31 +01:00 |
|
Paulo Reis
|
15de552c2c
|
Make new add comment button styles as the default; removed old add comment button code.
|
2017-04-04 10:40:53 +01:00 |
|
James Allen
|
567edbfb31
|
Fix on the new comment button variation
|
2017-04-03 17:11:33 +01:00 |
|
James Allen
|
2fa909c707
|
Allow scrolling in the review panel to extend outside of top of text like Ace
|
2017-04-03 16:46:36 +01:00 |
|
James Allen
|
efac6b70f4
|
Merge pull request #468 from sharelatex/ja-allow-overlapping-comments
Allo overlapping comments
|
2017-04-03 14:04:14 +01:00 |
|
James Allen
|
1675185f37
|
Merge pull request #474 from sharelatex/pr-project-name-tooltip
Project name tooltip
|
2017-04-03 14:04:02 +01:00 |
|
Paulo Reis
|
6b9b8480a8
|
Only show the tooltip if the project name is truncated.
|
2017-03-31 16:36:58 +01:00 |
|
Paulo Reis
|
855d37289b
|
Use ISO strings instead of of date type in locally resolved comments.
|
2017-03-31 14:29:28 +01:00 |
|
Shane Kilkelly
|
15d0a40f85
|
When error occurs, unset state.inflight
|
2017-03-31 10:30:28 +01:00 |
|
Shane Kilkelly
|
49446afb82
|
Remove duplicate line
|
2017-03-31 10:30:10 +01:00 |
|
James Allen
|
4c8ce65ce7
|
Allo overlapping comments
|
2017-03-28 16:50:30 +01:00 |
|
Paulo Jorge Reis
|
67943a8906
|
Merge pull request #463 from sharelatex/pr-ab-test-add-comments
PR AB test "add comment" button
|
2017-03-27 09:32:49 +01:00 |
|
Paulo Reis
|
93934b9c8f
|
Use deploy date.
|
2017-03-27 09:32:02 +01:00 |
|
Henry Oswald
|
aa4f768513
|
Merge pull request #455 from sharelatex/ho-bug-fix
multiple small bug fixes
|
2017-03-27 09:28:28 +01:00 |
|
Paulo Reis
|
c72ee95177
|
Refactor AB test participation code; add conversion code.
|
2017-03-23 15:00:43 +00:00 |
|
Paulo Reis
|
254e4953cb
|
Wire-up AB test for adding comments.
|
2017-03-23 12:26:21 +00:00 |
|
James Allen
|
b22ef30876
|
Merge pull request #456 from sharelatex/ja-show-too-many-track-changes-error
Show an explanation error message on too many track changes error
|
2017-03-21 13:15:14 +00:00 |
|
James Allen
|
e705118dfe
|
Merge pull request #457 from sharelatex/pr-new-add-comment-btn
New "add comment" button
|
2017-03-21 13:15:03 +00:00 |
|
Paulo Reis
|
a35f2585c7
|
Remove unused flag.
|
2017-03-20 14:02:25 +00:00 |
|
Paulo Reis
|
0e24d7118d
|
Hide new UI behind query string parameter.
|
2017-03-20 13:56:36 +00:00 |
|
Paulo Reis
|
8951e91e31
|
Remove add comment button from the mini review panel.
|
2017-03-20 11:35:35 +00:00 |
|
Paulo Reis
|
2c2abc3cae
|
Wire up new button with existing UI for adding comments.
|
2017-03-20 11:18:29 +00:00 |
|
Paulo Reis
|
beac43741c
|
New add comment button.
|
2017-03-17 17:05:38 +00:00 |
|
Paulo Reis
|
c74449b2e3
|
Don't show the mini review panel when the only visible entry is the add comment one.
|
2017-03-17 16:28:21 +00:00 |
|
James Allen
|
3c2f5525a1
|
Show an explanation error message on too many track changes error
|
2017-03-17 14:49:32 +00:00 |
|
Henry Oswald
|
9a8ee112a5
|
null check path.split
https://sentry.io/sharelatex-1/sl-web-client-prod/issues/202702369/
|
2017-03-17 10:35:07 +00:00 |
|
James Allen
|
aa36768d8a
|
Remove debugging line
|
2017-03-16 16:01:03 +00:00 |
|
James Allen
|
6c1a15a698
|
Move comments when cutting and pasting
|
2017-03-16 15:48:57 +00:00 |
|
James Allen
|
fb91219661
|
Don't submit comment on clicking cancel
|
2017-03-08 11:38:28 +00:00 |
|
James Allen
|
a6679a1aeb
|
Stop local and remote ops being batched together in the undo manager if they happen in the same flush
|
2017-03-01 16:33:04 +00:00 |
|
James Allen
|
e1cf6229f7
|
Merge branch 'master' into ja-use-dirty-state
|
2017-03-01 10:03:00 +00:00 |
|
Paulo Reis
|
1646496f19
|
Patch overflow behaviour so that z-index is always higher by 1.
|
2017-02-24 14:38:46 +00:00 |
|
Paulo Reis
|
3bdbe7e538
|
Set synctex controls z-index to the minimum working value.
|
2017-02-24 14:36:08 +00:00 |
|
James Allen
|
dd0271e799
|
Only cancel deletes with inserts on undo and reject
|
2017-02-24 14:20:26 +01:00 |
|
James Allen
|
7418d12bf8
|
Defer updates of remote ops until Ace has been updated
|
2017-02-23 11:34:58 +01:00 |
|
James Allen
|
f4bbd8ea10
|
Use dirty state rather events to avoid O(N^2) behaviour
|
2017-02-23 11:27:19 +01:00 |
|
Paulo Reis
|
96c44eec38
|
Support values other than objects in the numKeys filter, returning zero if so.
|
2017-02-21 14:48:21 +00:00 |
|
Paulo Reis
|
7f6941677d
|
Check local storage on load; use explicit condition syntax.
|
2017-02-21 14:43:05 +00:00 |
|
Paulo Reis
|
2e8f917318
|
Support initial closed state.
|
2017-02-21 14:27:57 +00:00 |
|
Paulo Reis
|
5c7fc66964
|
Merge branch 'pr-collapse-overview-entries' of github.com:sharelatex/web-sharelatex into pr-collapse-overview-entries
|
2017-02-21 14:21:10 +00:00 |
|
Paulo Reis
|
33c8bc8684
|
Support saving state to local storage.
|
2017-02-21 14:20:51 +00:00 |
|
James Allen
|
00fce4d2da
|
Merge branch 'master' into pr-collapse-overview-entries
|
2017-02-21 14:25:45 +01:00 |
|
James Allen
|
f1baa1b8ad
|
Merge pull request #432 from sharelatex/ja-hide-offscreen-review-panel-entries
Only render the entries that are visible in the text
|
2017-02-21 10:28:45 +01:00 |
|
James Allen
|
f466be96dd
|
Make sure first change isn't hidden under toolbar
|
2017-02-21 09:58:49 +01:00 |
|
James Allen
|
3af7cdf0a9
|
Merge branch 'ja-scroll-review-panel-past-ace' into ja-hide-offscreen-review-panel-entries
|
2017-02-20 16:24:26 +01:00 |
|
James Allen
|
6c21d19894
|
Increase offscreen lines considered for visibility
|
2017-02-20 16:24:19 +01:00 |
|
James Allen
|
ad05cc288c
|
Do DOM reads first to prevent thrashing
|
2017-02-20 16:22:18 +01:00 |
|
James Allen
|
8c5800ceaf
|
Only render the entries that are visible in the text
|
2017-02-20 16:03:02 +01:00 |
|
James Allen
|
b52e4a5d1c
|
Reset scroll margins when changing document
|
2017-02-20 15:46:53 +01:00 |
|
James Allen
|
995fa6122b
|
Scroll the review panel past the limits of Ace
|
2017-02-20 12:56:26 +01:00 |
|
Paulo Reis
|
1e66c46ca7
|
Add filter to retrieve number of keys in objects.
|
2017-02-17 14:31:50 +00:00 |
|
Paulo Reis
|
cd2c8e7199
|
Add directive based on jQuery animation API.
|
2017-02-17 11:54:33 +00:00 |
|
Paulo Reis
|
0841ab8278
|
Add directive to collapse elements via height.
|
2017-02-17 11:24:21 +00:00 |
|
James Allen
|
31ae2e7124
|
Update RangesTracker
|
2017-02-17 09:24:25 +01:00 |
|
James Allen
|
c8a6555cb1
|
Update RangesTracker
|
2017-02-16 17:07:56 +01:00 |
|
James Allen
|
04b9f8d249
|
Merge branch 'master' into ja-track-changes
|
2017-02-16 17:07:12 +01:00 |
|
Paulo Reis
|
a639f13cb6
|
Bootstrap collapsing behavior in files list. Store state.
|
2017-02-16 15:48:58 +00:00 |
|
Henry Oswald
|
bb7ededaaf
|
announcementClicked -> logAnnouncementClick
|
2017-02-15 12:43:13 +00:00 |
|
Henry Oswald
|
8cd3d21792
|
track read more clicks in announcements
|
2017-02-15 12:17:10 +00:00 |
|
James Allen
|
d01d6a35cf
|
Only create Controller when showing onboarding
|
2017-02-15 09:47:37 +01:00 |
|
James Allen
|
bdee15128b
|
Remove click handler on dismiss
|
2017-02-14 22:31:49 +01:00 |
|
Paulo Reis
|
badc4ecb7a
|
Show add comment tooltip to the left when appropriate.
|
2017-02-14 14:40:21 +00:00 |
|
James Allen
|
4dbc2c3066
|
Merge pull request #418 from sharelatex/pr-review-panel-onboarding
Pr review panel onboarding
|
2017-02-14 15:00:39 +01:00 |
|
James Allen
|
b48f57c2cb
|
Submit comment on blur or selection change
|
2017-02-14 13:41:04 +01:00 |
|
Paulo Reis
|
594f2024d1
|
Style the onboarding prompt as a modal; close it when clicked outside.
|
2017-02-14 12:09:05 +00:00 |
|
Paulo Reis
|
1eed10b4e7
|
Add keyboard navigation
|
2017-02-14 10:21:45 +00:00 |
|
James Allen
|
c08c8e09ff
|
Only show onboarding for users with track changes enabled
|
2017-02-14 11:09:37 +01:00 |
|
James Allen
|
03ecf4b4ae
|
Only show track changes onboarding once based on analytics API events
|
2017-02-14 10:25:46 +01:00 |
|
James Allen
|
61ef158f76
|
Don't show review panel if user doesn't have track changes
|
2017-02-14 09:38:58 +01:00 |
|
James Allen
|
c8baae84da
|
Merge branch 'pr-review-panel-onboarding' of github.com:sharelatex/web-sharelatex into pr-review-panel-onboarding
|
2017-02-13 16:51:16 +01:00 |
|
Paulo Reis
|
7dd9a3fa44
|
Add a dismiss button.
|
2017-02-13 15:49:58 +00:00 |
|
James Allen
|
6a4f0ace3b
|
Merge branch 'master' into pr-review-panel-onboarding
|
2017-02-13 16:19:56 +01:00 |
|
James Allen
|
bf5f5f832d
|
Use correct flag for determining mini panel visibility
|
2017-02-13 14:39:43 +01:00 |
|
James Allen
|
f840a20f5c
|
Merge pull request #417 from sharelatex/pr-track-changes-upgrade-prompt
Turn on track changes for beta users with upgrade prompt
|
2017-02-13 12:44:04 +01:00 |
|
James Allen
|
3334078fe6
|
Merge pull request #415 from sharelatex/ja-track-changes
Don't animate review panel entries on toggle and resize
|
2017-02-13 12:17:45 +01:00 |
|
James Allen
|
e99c9a2065
|
Enable track changes for beta users
|
2017-02-13 12:09:47 +01:00 |
|
James Allen
|
47a66eed50
|
Merge branch 'ja-include-track-changes-feature' into pr-track-changes-upgrade-prompt
|
2017-02-13 11:50:56 +01:00 |
|
James Allen
|
85c2910738
|
Don't animate review panel entries on toggle and resize
|
2017-02-13 09:49:51 +01:00 |
|
Paulo Reis
|
1263532271
|
Add a directive to control the playback state of media elements.
|
2017-02-09 15:44:15 +00:00 |
|
Paulo Reis
|
1ef5cc97fc
|
Rename stuff to refer to the new onboarding feature.
|
2017-02-08 17:19:13 +00:00 |
|
James Allen
|
51b76d2cf9
|
Merge pull request #413 from sharelatex/ja-abort-in-progress-spell-checks
Abort any inprogress spell checks when switching document
|
2017-02-08 11:38:05 +01:00 |
|
James Allen
|
87aea41bed
|
Abort any inprogress spell checks when switching document
|
2017-02-08 11:32:19 +01:00 |
|
James Allen
|
d44a0ece97
|
Merge pull request #411 from sharelatex/ja-fix-cursor-on-resize
Ja fix cursor on resize
|
2017-02-08 11:30:37 +01:00 |
|
James Allen
|
123300cdfb
|
Clear highlighted word manager on session change
|
2017-02-08 11:08:26 +01:00 |
|
James Allen
|
f6743b839f
|
Reflow review panel as editor pane changes size
|
2017-02-07 16:45:45 +01:00 |
|
Paulo Reis
|
d792230bf0
|
Basic onboarding tutorial for track-changes.
|
2017-02-07 15:07:26 +00:00 |
|
James Allen
|
11a104ef96
|
Move spelling marker to back marker layer where it is updated properly by Ace
|
2017-02-07 15:55:00 +01:00 |
|
James Allen
|
c1a2779d9e
|
Merge branch 'master' into ja-fix-cursor-on-resize
|
2017-02-07 15:27:01 +01:00 |
|
James Allen
|
d00619ff3d
|
Keep the cursor in the same position on screen when the editor resizes
|
2017-02-07 15:23:44 +01:00 |
|
James Allen
|
1b06af766d
|
Merge pull request #406 from sharelatex/pr-expandable-text-area-fixes
Expandable text area fixes
|
2017-02-07 09:04:10 +01:00 |
|
James Allen
|
4a80f0de5a
|
Clear selection after creating a comment
|
2017-02-03 15:09:40 +00:00 |
|
James Allen
|
343abfde23
|
Use user feature flags to determine track changes state
|
2017-02-03 14:36:11 +01:00 |
|
James Allen
|
27c48f3790
|
Clear selection after creating a comment
|
2017-02-03 14:17:09 +01:00 |
|
Paulo Reis
|
6ef8d2d46d
|
Merge branch 'master' into pr-expandable-text-area-fixes
|
2017-02-02 14:38:09 +00:00 |
|
Paulo Reis
|
9d1d2df977
|
Disable mocked feature flag behaviour.
|
2017-02-02 12:19:44 +00:00 |
|
Paulo Reis
|
8f9e43f339
|
Handle track changles toggling when the feature is not enabled.
|
2017-02-02 12:12:14 +00:00 |
|
Paulo Reis
|
f50967295d
|
Support disabling the review-panel toggle, like a standard checkbox.
|
2017-02-02 12:08:17 +00:00 |
|