Commit graph

30 commits

Author SHA1 Message Date
Alf Eaton
08ccdb79d3 [cm6] Improve alignment of review panel elements (#12710)
* Use a block widget for top padding
* Update review panel positions when the editor geometry changes
* Remove editorPaddingTop from position calculations
* Recalculate review panel on start adding comment
* Assert on line content rather than index
* Use broadcastChange
* Keep focus in the editor when opening the review panel
* debounce broadcastChange
* Set CULL_AFTER to Infinity

GitOrigin-RevId: a8d7b8967736a9164b5264eeaadf334c15ec95ce
2023-04-25 08:05:02 +00:00
Eric Mc Sween
7d099acfdd Merge pull request #9150 from overleaf/em-share-ranges-tracker
Move RangesTracker to shared lib

GitOrigin-RevId: 62da7208f0b453dd7272c06873c7e415ed887817
2022-10-05 13:26:01 +00:00
Alf Eaton
0b942bd8a8 Merge pull request #8708 from overleaf/ae-loading-threads-fix
Only dispatch the loaded_threads event once

GitOrigin-RevId: d9b8bf4a84d115fcc00edbf1901565ddb407c8be
2022-07-05 08:04:02 +00:00
Alf Eaton
4657465c0d Merge pull request #8703 from overleaf/ae-threads-loaded
Ensure that the loaded_threads event isn't dispatched for read-only link sharing users

GitOrigin-RevId: e03581f29f1a0aff122c3c16f4f6a3b70293c301
2022-07-05 08:03:56 +00:00
Alf Eaton
5c94bd81e7 Merge pull request #8699 from overleaf/ae-comment-threads
Show tracked changes highlights if comment threads are not loaded

GitOrigin-RevId: 1aabe62e1aea0b63336ab33cbf199c3f24471495
2022-07-05 08:03:15 +00:00
Alf Eaton
78df903b69 Merge pull request #8639 from overleaf/ae-loading-threads
[cm6] Improve interaction between review panel and CM6

GitOrigin-RevId: 2f15a4821d4edfb5ee00013c74c7ae35fa59559c
2022-07-04 08:03:30 +00:00
Jakob Ackermann
b04bc4798e Merge pull request #8473 from overleaf/ii-cm6-missing-keyboard-shortcuts-2
[cm6] Add missing keyboard shortcuts 2

GitOrigin-RevId: 29f68cd2eb9d0ad931fff463f76ddb91b5275516
2022-06-22 08:05:20 +00:00
Tim Down
fef395f431 Fix layout shift by nearly always applying overflow-y hidden on review panel (#8174)
* Always hide vertical overflow on the review panel, not just when it's expanded, which prevents it scrolling slightly when scrolling the PDF in some circumstances
* Fix layout shift by always applying overflow-y hidden on review panel and make entry visible in minimized review panel by making the overflow visible while hovering over the entry

GitOrigin-RevId: 854ee47a762ee2cf78fbbb5856afddb3b723d679
2022-06-13 08:03:37 +00:00
Tim Down
c0292d96a1 Add vertical padding to CM6 editor content to deal with overflowing entries in the review panel (#8321)
GitOrigin-RevId: 9f8265dba773008ba8f97053ce66f23dc4b7121f
2022-06-13 08:03:32 +00:00
Alf Eaton
5d05b2b21d Restore "layout-left" styles for collapsed review panel comment popover (#7999)
GitOrigin-RevId: 230e202496c8bc7e4929fca9c35b7f8eba25653b
2022-05-19 08:03:08 +00:00
Alf Eaton
e096bf051a Open the correct doc on tracked change click in overview (#7622)
GitOrigin-RevId: 7bef9341c315f350c5428f8c94ce84cbc4f850c5
2022-04-25 08:04:12 +00:00
Jakob Ackermann
862ff734c6 Merge pull request #7278 from overleaf/jpa-block-track-changes-access
[web] block restricted token users from accessing track-changes details

GitOrigin-RevId: f2e734b48aaa1d1cae6d5db0e0312a78d42165de
2022-04-05 12:21:09 +00:00
Alf Eaton
34a296747b Merge pull request #6695 from overleaf/ae-cm6-review-panel-timing
[web] [cm6] Improve track changes extension timings

GitOrigin-RevId: 6e374b785daf14bd4d4576747faa0a9b20c4d346
2022-02-16 11:35:10 +00:00
Alf Eaton
4cad876173 [web] CodeMirror 6 track changes extension (#6455)
GitOrigin-RevId: 038f375c40e7bc8009ee423016b711a2252f52fa
2022-01-31 09:03:19 +00:00
Alf Eaton
50df230846 [web] Upgrade Prettier to match version in monorepo root (#6231)
GitOrigin-RevId: 02f97af1b9704782eee77a0b7dfc477ada23e34d
2022-01-11 09:03:23 +00:00
Jakob Ackermann
a6f05109a3 Merge pull request #5352 from overleaf/jpa-no-var
[misc] fix eslint violations for `no-var`

GitOrigin-RevId: c52e82f3a8a993b8662cc5aa56e7b95ca3c55832
2021-10-27 08:03:00 +00:00
Timothée Alby
c5f883ad83 Merge pull request #5031 from overleaf/ab-paywall-events
Merge paywall-prompt and paywall-click events

GitOrigin-RevId: d567631d08b89565f9a3049f9b88cc2d14a799c1
2021-09-17 08:03:12 +00:00
Alexandre Bourdin
c634f51eee Merge pull request #4116 from overleaf/ab-paywall-prompt-events
Add paywall prompt events

GitOrigin-RevId: 6b1b3b384590f14828f37210b2e14047e2ee33d6
2021-06-11 02:05:54 +00:00
Eric Mc Sween
568e99ad47 Merge pull request #4125 from overleaf/em-analytics-keepalive
Use keepalive when sending analytics events

GitOrigin-RevId: c4e5884483313cdc67abe98e18852680692ac229
2021-06-04 02:08:19 +00:00
Miguel Serrano
73c47fa0e0 Layout divider for Symbol Palette (#4036)
Co-authored-by: Alf Eaton <alf.eaton@overleaf.com>
GitOrigin-RevId: e22635978c16646060c80ceb8376a560bfbf6527
2021-05-18 02:08:12 +00:00
Miguel Serrano
f9871103bf Merge pull request #3949 from overleaf/msm-reenable-eslint-const-rule
Reenable eslint `prefer-const` rule

GitOrigin-RevId: 4f3825be8b8dff381095209085a36eaab76260d5
2021-05-06 02:09:14 +00:00
Alf Eaton
1be43911b4 Merge pull request #3942 from overleaf/prettier-trailing-comma
Set Prettier's "trailingComma" setting to "es5"

GitOrigin-RevId: 9f14150511929a855b27467ad17be6ab262fe5d5
2021-04-28 02:10:01 +00:00
Alf Eaton
1ebc8a79cb Merge pull request #3495 from overleaf/ae-prettier-2
Upgrade Prettier to v2

GitOrigin-RevId: 85aa3fa1acb6332c4f58c46165a43d1a51471f33
2021-04-15 02:05:22 +00:00
Shane Kilkelly
f013f33c05 Merge pull request #3884 from overleaf/jpa-meta-editor-take-2
[misc] migrate the editor templates to meta tags -- take 2

GitOrigin-RevId: 447d4c6c2197dd2c5f5e182a5edf57313557b8b9
2021-04-10 02:05:05 +00:00
Simon Detheridge
e4f84b9f69 Merge pull request #3854 from overleaf/tm-show-new-editors-with-track-changes
Fix newly added collaborators not showing track-changes as enabled

GitOrigin-RevId: 20a4ca3278cbea8a50b6c285b8fc416a34dfcf52
2021-03-31 02:05:59 +00:00
Alf Eaton
2ff1cf43d6 Merge pull request #3470 from overleaf/eslint
Upgrade and configure ESLint

GitOrigin-RevId: ad5aeaf85e72c847a125ff3a9db99a12855e38aa
2020-12-16 03:08:28 +00:00
Alasdair Smith
8f5270899f Merge pull request #2707 from overleaf/as-transform-esm
Transform frontend module format from AMD to ESM

GitOrigin-RevId: 9adbcdc95e819a54114010c6fd3521d8f58ef2fe
2020-05-20 03:21:38 +00:00
Jessica Lawshe
30a2997b43 Merge pull request #2789 from overleaf/as-fix-no-undef
Enable no-undef linting rule for all frontend files and fix errors

GitOrigin-RevId: bf9c789a381af982bdece55a2f518a2b610c9202
2020-05-13 03:23:18 +00:00
Alasdair Smith
bc1b73d74e Merge pull request #2515 from overleaf/as-transform-absolute-paths
Transform absolute paths in frontend to relative

GitOrigin-RevId: c1914c0fd09d68984ba6c85a1f00aa3e6858d944
2020-04-07 03:18:45 +00:00
Alasdair Smith
e035d526d6 Merge pull request #2287 from overleaf/as-frontend-rearch
Restructure frontend directories

GitOrigin-RevId: 5a1224ca186f4809df45680a80d374c1c318d7bf
2019-11-05 14:22:52 +00:00
Renamed from services/web/public/src/ide/review-panel/controllers/ReviewPanelController.js (Browse further)