Commit graph

2954 commits

Author SHA1 Message Date
Davinder Singh
0ed9626475 Merge pull request #10710 from overleaf/ds-bug-fix-delete-btn
changing delete button to `btn-danger` from `btn-primary`

GitOrigin-RevId: a70f92cce1dc53b48265c4daf383be6dd8972c4b
2022-12-01 09:04:49 +00:00
M Fahru
f27562eb12 Data handling for settings in editor left menu react migration (#10470)
- Importing SettingsController from the angular code, which enables post requests for every select menu and socket handler for compiler, texlive version, and main document select option
 - New context for the data handling infrastructure between react and angular. The data is still located in the angular version, and I use the context only as a proxy to fetch/post new data.

GitOrigin-RevId: 59009bceb128d82969a2318e90036aacf79f9887
2022-11-30 09:04:32 +00:00
Alf Eaton
65b0fd73ea Improve "compile" keyboard shortcut handling (#10624)
* Improve "compile" keypress handling
* Remove "compile" keypress handling from PDF preview
* Remove compile shortcuts from CM6
* Use an event for Vim keybindings
* Remove event handlers from Angular/Ace
* Move useCompileTriggers into DetachCompileProvider

GitOrigin-RevId: 7f0e667b5106a849458e06ebb0f7a413d5d63430
2022-11-29 09:04:04 +00:00
M Fahru
31c503be2d Add 10 seconds delay before showing grammarly warning
GitOrigin-RevId: 11bb3ca5704ef5cc782d14eb6f4f10a1fa2a656e
2022-11-25 09:04:33 +00:00
M Fahru
6dcc22642a Update "go to line" hotkey for cm6 and add new info text in hotkeys modal
* Update "go to line" hotkey for cm6 and add new info text in hotkeys modal

* Differentiate modal title between cm6 and ace hotkeys

* Update test to reflect change in hotkeys modal title

* Add test for hotkeys modal bottom text

* Update test on editor left menu hotkeys button to reflect change in hotkeys modal title

GitOrigin-RevId: 61bae16313ea7a37fa3b9441dbe5a93ab7823d01
2022-11-25 09:04:20 +00:00
ilkin-overleaf
11e789229e Merge pull request #10528 from overleaf/ii-add-modal-before-checkout
[web] Show student confirmation modal for student plans on checkout page

GitOrigin-RevId: 6009bde36adb2ca24d3438def95db3b47f1ce8b2
2022-11-22 09:04:19 +00:00
Jessica Lawshe
024f6ee24e Merge pull request #10467 from overleaf/ds-btn-info-new-css-part-2
Updating`btn-info` to `btn-info-secondary` - part 2

GitOrigin-RevId: 934dd633494454277432810c4a1e70bb17829bd7
2022-11-18 09:05:51 +00:00
Miguel Serrano
75fcdafb15 Merge pull request #10418 from overleaf/msm-fix-itm-campaign
Fix `itm_campaign=undefined` in insterstitial plans page

GitOrigin-RevId: 4826b507a93d3c324d600a938234ba31b4582955
2022-11-17 09:03:56 +00:00
Miguel Serrano
edeaa4baa0 Merge pull request #10435 from overleaf/msm-remove-survey-banner
Remove banner to recruit new joiners for survey

GitOrigin-RevId: c427c57b80d6e38285ddbafc67554b62516ea8b8
2022-11-17 09:03:49 +00:00
M Fahru
d70e0b1c0e Implement grammarly warning alert on cm6 users
GitOrigin-RevId: ed272bbc385faa69811ec1891075906cdca1c984
2022-11-16 09:06:39 +00:00
ilkin-overleaf
87b844aa15 Merge pull request #10438 from overleaf/ii-offer-personal-plan-on-cancellation
[web] Offer personal plan on subscription cancellation

GitOrigin-RevId: a7845fb3f7edc2f169ba237d8b822ff958a5c6a5
2022-11-16 09:06:18 +00:00
Davinder Singh
994736548e Merge pull request #10366 from overleaf/ds-buttons-user-bonus
[web] Use new buttons on bonus page, primary email check, and gallery item page

GitOrigin-RevId: f5ac40f45b0698054f52560b4b722e1c3b18b5c6
2022-11-16 09:04:42 +00:00
Davinder Singh
09be606a4e Merge pull request #10342 from overleaf/ds-buttons-project-page
New buttons on project dashboard

GitOrigin-RevId: 6e6a93a1ca1264dd214ccaf7976b665e45e7b10b
2022-11-16 09:04:34 +00:00
M Fahru
5eff354971 Create settings menu react elements in editor left menu for editor left menu react migration
GitOrigin-RevId: e75581a43a8694398b20bee3dc5ec69b60db86ab
2022-11-15 09:07:01 +00:00
Jessica Lawshe
62cf8c9d61 Merge pull request #10262 from overleaf/jel-ds-btn-secondary
[web] Buttons for new CSS build

GitOrigin-RevId: 9ae4284ba89296b77c37d61ba9b221bcab2f6458
2022-11-15 09:06:25 +00:00
M Fahru
efd2669cc7 Use a hard-coded variable to stop rendering the switch away survey component
GitOrigin-RevId: f3dc9db2c8f24aff941c6ea811e5a8f13e1f2960
2022-11-10 09:04:33 +00:00
M Fahru
0cca76557e Comment out switch away survey to temporary disable it
GitOrigin-RevId: f516af0f016c05cba1d171b1f2ad98aa695447ba
2022-11-10 09:04:25 +00:00
M Fahru
19dd2f67e2 Implement "switch away survey" when users switching back to ace from cm6 (#10201)
Implement legacy source editor survey:

* Force user to switch to cm6 if they haven't seen switch away survey

* Only show user switch away survey if they open ace from another editor

* We need to wait 3 seconds until the survey is being shown

* Add comment to explain the reasoning of not showing cm6 switch away survey for rich text users

* Use localstorage `editor.has_seen_cm6_switch_away_survey` setter to not show the survey if user has seen the survey

* the `editor.has_seen_cm6_switch_away_survey` will have the value `true` even if user is not interacting with it, so update comment to reflect that

* Add `once: true` option to keydown event to avoid unnecessary callback invocation upon key presses

GitOrigin-RevId: c26be2bb39efac2dff112c821fca893e5993dcbf
2022-11-04 09:05:50 +00:00
Mathias Jakobsen
50b346b4ed Merge pull request #10279 from overleaf/jpa-tracing-optimizations
[misc] do not load the tracing module unless enabled

GitOrigin-RevId: 8a3b9da3e9451e3060b852dd44e078c99cf43cfa
2022-11-04 09:05:00 +00:00
Mathias Jakobsen
a54b633726 Merge pull request #10111 from overleaf/mj-lezer-file-outline
[web] Parser backed file outline

GitOrigin-RevId: 0825f4887ba4dae24a14dd1880d07b791d0b4cd9
2022-11-04 09:04:33 +00:00
M Fahru
a30e934692 Migrate "help menu" in editor left menu to react
GitOrigin-RevId: 7ebbfa693205de1f57b1d54e25c46cfb1851acc8
2022-11-03 09:03:49 +00:00
Tim Down
cbc3aef728 Merge pull request #10109 from overleaf/ds-switch-component
Modifying the Switch

GitOrigin-RevId: 93b8483aa4aa164ea0be5fc2b4ccc5cfb17eae3c
2022-11-02 09:04:07 +00:00
ilkin-overleaf
7180ee8700 Merge pull request #10132 from overleaf/ii-dashboard-are-you-affiliated-migration
[web] Project dashboard are you affiliated migration

GitOrigin-RevId: 455ad915dd023c5fab3ce9a5165aa7e960915f1f
2022-11-01 09:05:02 +00:00
Simon Detheridge
3d9c8f80f4 Merge pull request #10227 from overleaf/spd-td-opentelementry
Add opentelemetry to dev environment

GitOrigin-RevId: 31a8234197337a264412b411429692525793c8b0
2022-11-01 09:04:53 +00:00
Miguel Serrano
b299ccf139 Merge pull request #10191 from overleaf/msm-new-joiner-survey
Banner to recruit new joiners for survey

GitOrigin-RevId: f901818cb428f0338de55655885eb8b54e702268
2022-10-28 08:05:22 +00:00
Timothée Alby
2aff826965 Merge pull request #10125 from overleaf/ta-galileo-prompt-size
Add Query Param to Control Galileo Prompt Size

GitOrigin-RevId: 01fbd60ee6c16e93844021cadb201d39d9d65810
2022-10-27 08:05:28 +00:00
Miguel Serrano
c30f887727 Merge pull request #9936 from overleaf/msm-itm-referrer
`itm_referrer` for subscription attribution

GitOrigin-RevId: 2787b55e8b7e9e415e66abef8deb669f3adf0f0d
2022-10-26 08:03:52 +00:00
M Fahru
797b9b2532 Migrate download menu in editor left menu to react (#10046)
* Initialize left menu react migration and migration download menu UI to react

* Add test case to DownloadMenu react component

* Update test description and add an href check to one of the download link

* Extract storybook document mock to its own fixture file

* Add mockCompileOnLoad config on storybook editor scope
  - if mockCompileOnLoad: true (default), then the default compile mock will be used
  - If mockCompileOnLoad: false, then we have to provide a compile mock on the storybook component

* Create download menu storybook component

* Use a single "editor-left-menu" controller on the editor left menu migrations

* Remove the form import from the react version of the left menu

* Change inline style to utility class name

GitOrigin-RevId: 5357c7bfc78bf40f52b9b308df8f2b60d793fbf7
2022-10-25 08:04:19 +00:00
ilkin-overleaf
be000f2572 Merge pull request #10013 from overleaf/ii-dashboard-upgrade-button-tracking-data
[web] Project dashboard upgrade button tracking adjustments

GitOrigin-RevId: 8ec7b1a0914db8e167ec0af49f5d4ebd0e23280f
2022-10-24 08:02:57 +00:00
Thomas
f6a6e767e6 Merge pull request #9947 from overleaf/tm-teardown-bts2022-promo
Teardown Back to School 2022 promo banners

GitOrigin-RevId: b26229af17c7ce272632106850fce504cdca04d2
2022-10-18 08:02:50 +00:00
Alexandre Bourdin
7a20e1376d Merge pull request #9882 from overleaf/ii-dashboard-system-message-migration
[web] Project dashboard system & translation message migration

GitOrigin-RevId: 0c723a3b526980e5c749da44ebe8a0a3edcc66ad
2022-10-13 08:05:38 +00:00
Alexandre Bourdin
cdbf8c1831 Merge pull request #9915 from overleaf/jpa-project-list-api-query-optimizations
[web] optimize db queries of project list api endpoint

GitOrigin-RevId: e1e747858e95cf60003d68e6331dc41839389455
2022-10-13 08:05:31 +00:00
Alexandre Bourdin
2d6e6328a6 Merge pull request #9890 from overleaf/td-grammarly-firefox-layout-shift
Fixed position document element to work around Grammarly-related layout shifts in Firefox

GitOrigin-RevId: 1a69c5d753fbb85f28be50d042e370dd3811278e
2022-10-13 08:05:16 +00:00
M Fahru
39cb74286d Teardown interstitial payment page split test and implement active variant (#9732)
GitOrigin-RevId: 755fd2f8a1be48ab6520aaab34ca2ea5d070302d
2022-10-12 08:04:59 +00:00
Thomas Mees
37b598fa5a Teardown premium features discoverability and implement variant
GitOrigin-RevId: 46dfa1aae117e1862c828bed568085dcd59acd8b
2022-10-12 08:04:51 +00:00
Jessica Lawshe
c832d5cea8 Merge pull request #9861 from overleaf/tm-bts2022-banner-message-end-date
Update banner message with end date for BTS2022 promo

GitOrigin-RevId: 410120c0fc7a8dd976fa0434d120587f2525cc11
2022-10-07 08:04:56 +00:00
Tim Down
ad147e250d Merge pull request #9814 from overleaf/ds-server-pro-word-change
Added overleaf to the left menu

GitOrigin-RevId: 86ab6f338ed0026831b66898d479c9ffe3bb2e07
2022-10-04 08:03:27 +00:00
Tim Down
de7eb43f51 Merge pull request #9792 from overleaf/ds-jpa-remove-stoponfirsterror-split-test
Split Test removal - removed stop-on-first-error split test code

GitOrigin-RevId: 4a5663397d0a967e0fa957453b36d466aa530630
2022-10-04 08:03:24 +00:00
M Fahru
1549bac91a Fix event segmentations for some of the plans-page-click events on the new plans page (#9781)
* change event segmentation to plans-page-layout-v2-annual

* update some new plans page event to have new event key

* add location segmentation key for some of the group plans events

GitOrigin-RevId: 99d8258112d9661955a196e57ca05a017afba0f4
2022-09-30 08:04:43 +00:00
Thomas Mees
a0c87b2ae1 Rename plans-page-layout-v2 to plans-page-layout-v2-annual
GitOrigin-RevId: deeec6bde44d8d99e241d54b02248fe6299af4df
2022-09-28 08:08:13 +00:00
June Kelly
3288f87dbe [web] Password set/reset: reject current password (redux) (#8956)
* [web] set-password: reject same as current password

* [web] Add 'peek' operation on tokens

This allows us to improve the UX of the reset-password form,
by not invalidating the token in the case where the new
password will be rejected by validation logic.

We give up to three attempts before invalidating the token.

* [web] Add hide-on-error feature to async forms

This allows us to hide the form elements when certain
named error conditions occur.

* [web] reset-password: handle same-password rejection

We also change the implementation to use the new
peekValueFromToken API, and to expire the token explicitely
after it has been used to set the new password.

* [web] Validate OneTimeToken when loading password reset form

* [web] Rate limit GET: /user/password/set

Now that we are peeking at OneTimeToken when accessing this page,
we add rate to the GET request, matching that of the POST request.

* [web] Tidy up pug layout and mongo query for token peeking

Co-authored-by: Mathias Jakobsen <mathias.jakobsen@overleaf.com>
GitOrigin-RevId: 835205cc7c7ebe1209ee8e5b693efeb939a3056a
2022-09-28 08:06:54 +00:00
Alexandre Bourdin
7608d37c0a Merge pull request #9622 from overleaf/mf-add-portal-templates-2
Add institution templates to the react version of the new project dropdown

GitOrigin-RevId: 32bf0b1b559ea3da744430902cc016e7c2a918d9
2022-09-27 08:04:00 +00:00
ilkin-overleaf
e12c93c537 Merge pull request #9700 from overleaf/ii-dashboard-mobile-view
[web] Projects dashboard mobile view

GitOrigin-RevId: 84894e19c814a2cc1ce751181952c0ade6b62044
2022-09-26 08:04:38 +00:00
Thomas
135ec8db8f Merge pull request #9705 from overleaf/tm-bts2022-banner-message
Update banner message on back to school 2022 promo

GitOrigin-RevId: e8f2173d466c485b6186485aba49aeb27c094d8e
2022-09-23 08:04:53 +00:00
Tim Down
8388d808a5 Merge pull request #9678 from overleaf/ta-td-galileo-week6
Galileo Integration Banch Week 6

GitOrigin-RevId: 78fffeefdf350042a4c2400823fb2a668ee0f592
2022-09-22 08:03:55 +00:00
Thomas
e84c1740bc Merge pull request #9652 from overleaf/tm-plans-v2-default-monthly
Default to showing Annual plans when rendering the V2 plans variant

GitOrigin-RevId: a709e81de3672959c67f6afd0234fb9277400d9d
2022-09-21 08:04:53 +00:00
Davinder Singh
0c5cdc2023 Merge pull request #9595 from overleaf/ds-SAML-logs
add SAML log access to the Admin dropdown

GitOrigin-RevId: 2c12e728c55d5697708fae42815e392ac85af21d
2022-09-16 08:04:08 +00:00
Thomas
281f222d82 Merge pull request #9612 from overleaf/tm-onboarding-upgrade-prompt-analytics-fix
Fix event tracking for onboarding upgrade prompt page

GitOrigin-RevId: 8122cc7f290cc0ba07c8d38c71d8b762bb760f32
2022-09-15 08:04:27 +00:00
Thomas
db9fad7cf8 Merge onboarding experiments integration branch (#9571)
* Add onboarding survey page

* Add onboarding new analytics events to mixpanel allowlist

* [web] Try Premium prompt

* moved try-premium code to overleaf-integration

* fixed sheet styling

* Add onboarding flow redirect handling to registration handlers (#9462)

* Add redirect logic for onboarding flow after registration

* Update UPGRADE_PROMPT_URL

* Cleanup style of OverleafAuthenticationController

* Refactor finishLogin calls to call wrapped function in OverleafAuthenticationController

* Refactor user properties/onboarding flow redirect into finishLogin wrapper

* Fix async/await calls after refactoring

* Update tests for finishLogin refactoring

* Don't redirect to upgrade prompt if user has premium via commons

Co-authored-by: Miguel Serrano <mserranom@users.noreply.github.com>
GitOrigin-RevId: 7c392aa6949f99fa909f9ca4e4baad4c4d4ff6be
2022-09-15 08:04:06 +00:00
Alexandre Bourdin
a0fabee3b4 Merge pull request #9245 from overleaf/integration-project-dashboard-react-migration
[Integration branch] Project Dashboard React Migration

GitOrigin-RevId: 3c3db39109a8137c57995f5f7c0ff8c800f04c4e
2022-09-14 08:04:03 +00:00