Commit graph

2654 commits

Author SHA1 Message Date
Jimmy Domagala-Tang
d41e069c69 Merge pull request #20404 from overleaf/revert-20389-jdt-add-writefull-commons-to-v1
Revert "Add writefull commons to v1"

GitOrigin-RevId: 703e2873cb64059f6a3881d6fc7f3c475caf5abd
2024-09-17 08:05:41 +00:00
Jimmy Domagala-Tang
aca9466c49 Merge pull request #20389 from overleaf/jdt-add-writefull-commons-to-v1
Add writefull commons to v1

GitOrigin-RevId: 36d1022f41b4db3701c6b8fa2120b035b05b38ba
2024-09-17 08:05:37 +00:00
Jimmy Domagala-Tang
e039d020a3 Merge pull request #20202 from overleaf/jdt-labs-widget-button-markup
fixing button style for labs widgets

GitOrigin-RevId: d2e8ce9b1efe1bfc0c5a021470b38107d5f1b6b8
2024-09-17 08:05:32 +00:00
David
a323f3af75 Implement a floating "Add comment" button for the redesigned review panel (#19891)
* Implement floating Add comment button

* Fix comment typo

* Remove unused imports

* Make tooltip always appear above cursor

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

* Refactor how new comment form is positioned

* Add missing file

* Create new map when rendering positions

* Use codemirror state to manage ranges and allow for mutliple in-progress comments

* Memoise sorting

* Create new ranges map each time it is changed

* Add back mutation observer

* Only allow single tooltip

* Fix typo

* Convert state field to store a single tooltip

* Make add comment tooltip content a react component

* Refactor to remove usages of !important

* Use RangeSet to keep track of new comment ranges

* Fix logic broken in rebase

* Map ranges through document changes

* Add decorations for in-progress comments

* Use set-review-panel-open rather than an editor event to open review panel

* Implement new designs for add comment form

* Add padding to textarea

* Fix bug where comment was being submitted for incorrect range

* Add missing key to ReviewPanelAddComment

* Store new comment ranges as a DecorationSet

* Small refactor to how ReviewPanelAddCommens are rendered

* Make op prop to ReviewPanelEntry required

* Add handling for disabling of add comemnt form buttons

* Move viewer check inside AddCommentTooltip

* Ensure that add comment button doesn't reshow when collaborators edit the document

* Remove unneeded op check in ReviewPanelEntry

* Update services/web/frontend/js/features/review-panel-new/components/review-panel-add-comment.tsx

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>

---------

Co-authored-by: Domagoj Kriskovic <dom.kriskovic@overleaf.com>
GitOrigin-RevId: 3110845f6a557310f3bf72014689e2f2ab53e966
2024-09-17 08:04:58 +00:00
David
9cf94e57d3 Include \def, \let, \newenvironment and \renewenvironment commands in the math preview (#20197)
* Include \def commands in command definitions

* Allow command name to be in CtrlSym

* Pull nodeIntersectsChange check out of branches

* Fix \def handling

* Add handling for \newenvironment and \renewenvironment

* Allow \def to have optional arguments

* :x
Revert "Add handling for \newenvironment and \renewenvironment"

This reverts commit a70d3a0a13ed552daf3b761893e3f8609f0b0fc8.

* Add let commands to defintions

* Add environment names to math preview

* Ignore let command definitions in autocomplete

* Move nodeIntersectsChange check back into each block

* Add childOfNodeWithType utility and use to get command names

* commandNameText -> commandName

* Only include environment definitions

* Rename documentEnvironmentNames to documentEnvironments

* EnvironmentName -> Environment

* Format

GitOrigin-RevId: 9c5d701423ae786e5ff91960b4bcd94cd35d21c8
2024-09-17 08:04:53 +00:00
Alf Eaton
0230a296ac Remove underline from lint range highlight (#20243)
GitOrigin-RevId: 29c91fa8297cb92ceba3a088bff22c847b73455d
2024-09-13 08:05:05 +00:00
Alf Eaton
0e40011e14 Remove setTimeout from spell check results dispatch (#20342)
GitOrigin-RevId: 9973b216d60b20c2b6aaf5205c13e2db69cbd589
2024-09-13 08:04:55 +00:00
Alf Eaton
26af3e1ecf Use estimated height of math widget (#20359)
GitOrigin-RevId: b412e429b26ae51c83f84b855084b36a0015838d
2024-09-13 08:04:50 +00:00
ilkin-overleaf
8b3ffe58fa Merge pull request #20231 from overleaf/ii-bs5-ide-header-light
[web] BS5 IDE light header

GitOrigin-RevId: 39403afae76f267228fb286492ad50e8e88e31be
2024-09-09 08:05:10 +00:00
Mathias Jakobsen
7d80d22e96 Merge pull request #20233 from overleaf/mj-restore-promo
[web] Add promotion for file/project reverting

GitOrigin-RevId: 9f8e66ab2ad945274576800253d288bca5986562
2024-09-09 08:05:01 +00:00
Jimmy Domagala-Tang
707790e51e Merge pull request #20256 from overleaf/jdt-enable-writefull-unset
Differentiate between unset and disabled Writefull

GitOrigin-RevId: 3cf8f12ede851dab5a8067bdbcddba6c69870573
2024-09-06 08:05:52 +00:00
Mathias Jakobsen
663e2304f6 Merge pull request #20272 from overleaf/revert-20268-revert-19885-mj-resizeable-panels
[web] Upgrade react-resizable-panels (2nd attempt)

GitOrigin-RevId: 643a90044dac0daf39245fa29267b16550fd6e69
2024-09-06 08:05:28 +00:00
David
565514a162 Merge pull request #20269 from overleaf/dp-single-math-tooltip
Only show single math tooltip

GitOrigin-RevId: 85608976f2dc6d15748a1bde24c837d2180d3cbe
2024-09-06 08:05:00 +00:00
M Fahru
fe8b613fab Merge pull request #20071 from overleaf/mf-plans-page-click-currency
[web] Add currency segmentation to all of the `plans-page-click` events

GitOrigin-RevId: d886e4e87817092b51f32733c01d7cc3f15115c8
2024-09-05 08:06:26 +00:00
M Fahru
8a7db8ccd5 Add "For government" link to fat footer react
GitOrigin-RevId: bd370a0ad7a63072e19698105dfb4fb54cb242c8
2024-09-05 08:06:02 +00:00
Tim Down
e88b971735 Merge pull request #20169 from overleaf/td-contact-modal-acknowledge
Add acknowledgement message to React contact modal after successful submission

GitOrigin-RevId: a27b968351857997df17fedde3baa9da3f82331a
2024-09-05 08:05:28 +00:00
Mathias Jakobsen
99269d3928 Merge pull request #20268 from overleaf/revert-19885-mj-resizeable-panels
Revert "[web] Upgrade react-resizable-panels"

GitOrigin-RevId: 65b6cf9656c1116f77ae5dc3ceec1106e898d6f9
2024-09-05 08:05:03 +00:00
Mathias Jakobsen
5d57571e96 Merge pull request #20226 from overleaf/mj-restore-file-badge
[web] Add split test badge for file restore

GitOrigin-RevId: 59bbdd4cc5b76141a8bae06c2e7181e5a5c5ccc0
2024-09-05 08:04:53 +00:00
Mathias Jakobsen
2d9e4965f7 Merge pull request #19885 from overleaf/mj-resizeable-panels
[web] Upgrade react-resizable-panels

GitOrigin-RevId: 6b316dfb43ff841e863c83d1393ca88299eeefa2
2024-09-05 08:04:48 +00:00
ilkin-overleaf
86689a6269 Merge pull request #20205 from overleaf/ii-bs5-ide-header
[web] BS5 ide page header

GitOrigin-RevId: b7aad221d458d8403d60ff9950129394c74af856
2024-09-04 08:06:00 +00:00
David
f4c57fce4c Merge pull request #20246 from overleaf/dp-math-preview-closing-delimiter
Don't show math preview tooltip if the node has a parse error

GitOrigin-RevId: 330ebb945c70da4b5fe9ee4ee2f149a95435899b
2024-09-04 08:05:50 +00:00
David
4802d04fb0 Merge pull request #20198 from overleaf/dp-math-preview-improvements
Remove transition from math-preview tooltip to avoid flashing

GitOrigin-RevId: 004c7eeb6d4421a3d11f175a80d217356dfcb2da
2024-09-04 08:05:46 +00:00
Jessica Lawshe
8aa544a5ae Merge pull request #20187 from overleaf/jel-plans-modal-edu-discount
[web] Use notification for when edu discount is applied or not on light touch redesign

GitOrigin-RevId: 38278ac94f5b3cae18a500b3801412ed1b9a7da0
2024-09-04 08:05:37 +00:00
Tim Down
11d8b5162e Merge pull request #20237 from overleaf/td-bs5-contact-nav-item-button
Implement contact form nav item as a button rather than link

GitOrigin-RevId: 00690f70d343077b7884005f2e4ab8f8cc651b23
2024-09-04 08:05:17 +00:00
Rebeka Dekany
39b6b8baed Merge pull request #20172 from overleaf/rd-ide-fileoutline
[web] Migrate the file outline styling from LESS to SCSS

GitOrigin-RevId: 5e485b13a7358e5dcab2c75ee7d36a07e1401e26
2024-09-04 08:05:12 +00:00
Alf Eaton
de8acd2ed8 Upgrade @codemirror dependencies (#20103)
* Upgrade `@codemirror` dependencies
* Set EditorView.EDIT_CONTEXT=false

GitOrigin-RevId: 8024715748102a56f1b22e72be8a2019e80b5a07
2024-09-04 08:05:07 +00:00
Alf Eaton
284a8256d4 Fix tag name overflow in projects list (#20120)
GitOrigin-RevId: 9fc317dbebd8115ab8af97f4753350f5ee79c1cd
2024-09-04 08:04:57 +00:00
Alf Eaton
abfa29e629 Ensure that the correct lines are spell-checked (#19967)
GitOrigin-RevId: f63601288821d37bddcddc776270263e291d3985
2024-09-04 08:04:53 +00:00
Alf Eaton
607b3e3494 feat: making highlighting of errors more specific (#19963)
GitOrigin-RevId: 63bc147e18e80c1e070722bc70114f8fca8509ae
2024-09-04 08:04:48 +00:00
Rebeka Dekany
54fb884aaf Merge pull request #20219 from overleaf/rd-dropdown-alignment
[web] Language picker dropdown should expand to the top

GitOrigin-RevId: 591a6fc013d2a9e841acd09d6881727aed38471b
2024-09-03 08:04:34 +00:00
Tim Down
1f6418f48f Merge pull request #20161 from overleaf/td-bs5-contact-modal-wiki-search-visibility
Fix for learn wiki search results not appearing in BS5 nav contact modal

GitOrigin-RevId: 9f4476163c509ab6ec7fe119600276c906c44f7e
2024-09-02 08:05:49 +00:00
Tim Down
8219957436 Merge pull request #20196 from overleaf/td-notification-html-validity
Remove superfluous elements around notifications on project dashboard

GitOrigin-RevId: 975e6056e6e89703f24b5ae1853c58c998722202
2024-09-02 08:05:44 +00:00
M Fahru
a9af85b6ab Merge pull request #20024 from overleaf/mf-plans-page-click
[web] Implement `plans-page-click` event on new plans page

GitOrigin-RevId: 1dbfc5faa433985c1ad81ba645cdb8f6f3a0b864
2024-09-02 08:05:39 +00:00
Jakob Ackermann
aa45f778c0 Merge pull request #20137 from overleaf/jpa-fix-e2e
[server-pro] fix e2e tests

GitOrigin-RevId: 589d23baf8bc815328f21b140f2086e135d13736
2024-08-30 08:04:46 +00:00
Rebeka Dekany
f6213de83b Merge pull request #20140 from overleaf/rd-footer-react
[web] Migrate the footer to React

GitOrigin-RevId: 9571d7b3ef9a267fb8250956f821b1ee34ce07c7
2024-08-30 08:04:29 +00:00
roo hutton
837b5a4b9b Merge pull request #19914 from overleaf/rh-viewer-comments
[web] Allow Viewers to access chat and view comments/tracked changes

GitOrigin-RevId: 72be0444afdf5e0ad5937bf25718a7566bad001a
2024-08-28 11:35:22 +00:00
ilkin-overleaf
6437059783 Merge pull request #20063 from overleaf/ii-bs5-system-notifications
[web] BS5 system notifications

GitOrigin-RevId: a5a17a418193e325c0f561708c99240191cff8e7
2024-08-28 11:35:13 +00:00
roo hutton
db4d23d2df Merge pull request #20080 from overleaf/rh-lost-edit-access-modal
[web] Show modal to pending editors

GitOrigin-RevId: 63dfed45a1483e835978dc7ac76cd0f37b4e1f50
2024-08-28 08:04:34 +00:00
roo hutton
2dcf87e3f6 [web] Share modal shows downgraded editors (#20015)
* add hasBeenDowngraded prop for EditMember

* reduce padding on share modal collab row, add prompt to hasBeenDowngraded Select

* share modal select styling tweaks to allow for inline warning icon

* always show editor limit subtitle when in downgraded state

* add AccessLevelsChanged warning, tweak owner row styling

* conditionally set hasBeenDowngraded prop. make invited member row styling more consistent between warning/enforcement

* add an info state for access level changed notification

* add notification for lost edit access on collaborator share modal, TSify SendInvitesNotice

* fix member privilege alignment in collaborator share modal

* show blue upgrade CTA when some pending editors have been resolved

* automatically show share modal to owners when has pending editors or is over collab limit

* only show lost edit access warning in read-only share modal to pending editors

---------

Co-authored-by: Thomas <thomas-@users.noreply.github.com>
GitOrigin-RevId: e3b88052a48b8f598299ffc55b7c24cb793da151
2024-08-27 08:04:49 +00:00
Thomas
3e06c0086e Merge pull request #20090 from overleaf/tm-link-sharing-enforcement-add-more-editors
Update the notification shown when at max collaborators for users in the link-sharing-enforcement stage

GitOrigin-RevId: 7699491b217e963bcbd919b3763d8c8d31b5361f
2024-08-27 08:04:45 +00:00
Thomas
95aa79e95d Merge pull request #20089 from overleaf/tm-link-sharing-enforcement-in-frontend
Make ol-linkSharingEnforcement available to the frontend

GitOrigin-RevId: b64ce29f528c5b02c0cee400c73dc364d8e6da47
2024-08-27 08:04:40 +00:00
Eric Mc Sween
8b4b454b97 Merge pull request #20052 from overleaf/em-tracked-deletes-limit
Include tracked deletes when limiting document size

GitOrigin-RevId: 9d7b2870001fb942eaa92db78993fee1ddb3937c
2024-08-27 08:04:31 +00:00
Liangjun Song
3f1edfc1c9 Merge pull request #19954 from overleaf/ls-access-token-gradual-rollout-cleanup
Update git bridge modal for pw auth deprecation

GitOrigin-RevId: 2e764922bf350ddcba29bf9f3baa220ed1f48e40
2024-08-26 08:05:15 +00:00
Domagoj Kriskovic
cab58d87dd extracted rejectChanges to a separate file
GitOrigin-RevId: 83c55c4823f6e18f22dbd6bc1fa7ec010c509e30
2024-08-26 08:05:10 +00:00
Domagoj Kriskovic
ea20f82ad6 remove callout widget from ranges extension
GitOrigin-RevId: fa7f36cb0270228b57162404ce5a17523790e396
2024-08-26 08:05:06 +00:00
Domagoj Kriskovic
be47b27d98 remove clearChanges and buildChanges effects from ranges extension
GitOrigin-RevId: 4782725bfaf50153007bbd9ae5c8146cca769cde
2024-08-26 08:05:01 +00:00
Domagoj Kriskovic
dc70054caf trackDetachedComments as separate extension
GitOrigin-RevId: 8039de3f9766b072e9bb2170b50e683073105748
2024-08-26 08:04:56 +00:00
Domagoj Kriskovic
ec6b17eb01 revert trackChanges extension to a version before redesign
GitOrigin-RevId: fc12968a3971cfee7594720076bb4dc271178e73
2024-08-26 08:04:52 +00:00
Domagoj Kriskovic
6547ce6aa1 remove updateRangesEffect and rejectChanges from trackChanges extension
GitOrigin-RevId: b93751421d235fd61a80ce64f47aec7998e4f6cf
2024-08-26 08:04:47 +00:00
Domagoj Kriskovic
3bdfd36613 copied track-changes.ts extension
GitOrigin-RevId: 95e383223c6e4e7a10112ebfaff4d3bda9530a01
2024-08-26 08:04:43 +00:00