Commit graph

348 commits

Author SHA1 Message Date
Tim Down
08567c290e Add second CM6 switch-away survey (#10789)
Restart CM6 switch-away survey

GitOrigin-RevId: 1d62aaf27834cb3919f6ca30c269a1ef3c2e9a5e
2022-12-07 09:04:35 +00:00
Tim Down
fd2863bf7a Merge pull request #10747 from overleaf/as-ace-perf-measurement
Add perf measurement of Ace editor

GitOrigin-RevId: b33eeac9f7c7f85355a9e8f34833aa94bee2f70a
2022-12-07 09:04:21 +00:00
Tim Down
fde8ab422b Merge pull request #10794 from overleaf/td-resize-while-loading
Ensure editor is the correct size after window resize during load

GitOrigin-RevId: 0677ef6aa5d1dd7b6aea9158343b8ccbb3a6562b
2022-12-07 09:04:14 +00:00
Alf Eaton
65b0fd73ea Improve "compile" keyboard shortcut handling (#10624)
* Improve "compile" keypress handling
* Remove "compile" keypress handling from PDF preview
* Remove compile shortcuts from CM6
* Use an event for Vim keybindings
* Remove event handlers from Angular/Ace
* Move useCompileTriggers into DetachCompileProvider

GitOrigin-RevId: 7f0e667b5106a849458e06ebb0f7a413d5d63430
2022-11-29 09:04:04 +00:00
M Fahru
ff944917a6 Don't force user to cm6 if they have ace as editor preference
GitOrigin-RevId: 78390fe420eb28b5731cb1cc719a0b53913509e1
2022-11-10 09:04:40 +00:00
Mathias Jakobsen
8ddfd958d2 Merge pull request #10348 from overleaf/mj-outline-fixes-redo
[cm6] File outline improvements

GitOrigin-RevId: 9f4859cb35476d4baf0b3e3c2c2cb5d1678fd4a8
2022-11-09 09:04:08 +00:00
M Fahru
19dd2f67e2 Implement "switch away survey" when users switching back to ace from cm6 (#10201)
Implement legacy source editor survey:

* Force user to switch to cm6 if they haven't seen switch away survey

* Only show user switch away survey if they open ace from another editor

* We need to wait 3 seconds until the survey is being shown

* Add comment to explain the reasoning of not showing cm6 switch away survey for rich text users

* Use localstorage `editor.has_seen_cm6_switch_away_survey` setter to not show the survey if user has seen the survey

* the `editor.has_seen_cm6_switch_away_survey` will have the value `true` even if user is not interacting with it, so update comment to reflect that

* Add `once: true` option to keydown event to avoid unnecessary callback invocation upon key presses

GitOrigin-RevId: c26be2bb39efac2dff112c821fca893e5993dcbf
2022-11-04 09:05:50 +00:00
Mathias Jakobsen
bcad89fd28 Merge pull request #10273 from overleaf/ae-docname-apply
Add a `$scope.$applyAsync` wrapper around the "open a new document" code

GitOrigin-RevId: 7c63338379053d20bd86f10d9db6855cb5c23fc3
2022-11-04 09:05:25 +00:00
Mathias Jakobsen
a54b633726 Merge pull request #10111 from overleaf/mj-lezer-file-outline
[web] Parser backed file outline

GitOrigin-RevId: 0825f4887ba4dae24a14dd1880d07b791d0b4cd9
2022-11-04 09:04:33 +00:00
Tim Down
cbc3aef728 Merge pull request #10109 from overleaf/ds-switch-component
Modifying the Switch

GitOrigin-RevId: 93b8483aa4aa164ea0be5fc2b4ccc5cfb17eae3c
2022-11-02 09:04:07 +00:00
Alf Eaton
5b9261e13e Dispatch doc:changed and doc:saved events in a debounced timeout (#10024)
GitOrigin-RevId: a55602b448d8b97f224c658fee0a97d2473f8cd1
2022-11-01 09:04:45 +00:00
M Fahru
797b9b2532 Migrate download menu in editor left menu to react (#10046)
* Initialize left menu react migration and migration download menu UI to react

* Add test case to DownloadMenu react component

* Update test description and add an href check to one of the download link

* Extract storybook document mock to its own fixture file

* Add mockCompileOnLoad config on storybook editor scope
  - if mockCompileOnLoad: true (default), then the default compile mock will be used
  - If mockCompileOnLoad: false, then we have to provide a compile mock on the storybook component

* Create download menu storybook component

* Use a single "editor-left-menu" controller on the editor left menu migrations

* Remove the form import from the react version of the left menu

* Change inline style to utility class name

GitOrigin-RevId: 5357c7bfc78bf40f52b9b308df8f2b60d793fbf7
2022-10-25 08:04:19 +00:00
Eric Mc Sween
7d099acfdd Merge pull request #9150 from overleaf/em-share-ranges-tracker
Move RangesTracker to shared lib

GitOrigin-RevId: 62da7208f0b453dd7272c06873c7e415ed887817
2022-10-05 13:26:01 +00:00
Tim Down
8388d808a5 Merge pull request #9678 from overleaf/ta-td-galileo-week6
Galileo Integration Banch Week 6

GitOrigin-RevId: 78fffeefdf350042a4c2400823fb2a668ee0f592
2022-09-22 08:03:55 +00:00
Timothée Alby
ac3bc987d9 Merge pull request #9297 from overleaf/ta-galileo-module
Create Galileo Module

GitOrigin-RevId: 0d9dfeebc150bd6a0d828f55be47f9d9f1a70d66
2022-08-19 08:04:56 +00:00
Alf Eaton
982897dcb9 Merge pull request #9142 from overleaf/ae-outline-pane-height-fix
Ensure that the outline pane has appropriate height when collapsed

GitOrigin-RevId: 806d5cbeacbeed5df05712a5f3d85ee535442147
2022-08-08 08:04:06 +00:00
ilkin-overleaf
c331e7c73b Merge pull request #9027 from overleaf/ae-file-tree-outline-default-size
Set a default size for the outline pane

GitOrigin-RevId: d06ede6cf026b1aff04e2eb4e05c69f40dd406e4
2022-08-08 08:03:45 +00:00
Jessica Lawshe
e3758f2060 Merge pull request #8804 from overleaf/jel-rich-text-pos
[web] Fix stored rich text position

GitOrigin-RevId: 7ef916919220d63d88f66ee261f91a5af08dcefb
2022-07-28 08:03:30 +00:00
Miguel Serrano
e9f7f19ca0 [web] SL history: fix incorrect var->let replacement (#8994)
GitOrigin-RevId: ea90be7d89f6c31156a30af3278218f93f1d5c6a
2022-07-27 12:18:13 +00:00
Timothée Alby
7b8d277437 Merge pull request #8898 from overleaf/ta-change-redundant-controls
Change Redundant Layout Controls

GitOrigin-RevId: b50d71b1f75d202334442b3f6cb5037ed0d8a411
2022-07-21 08:04:25 +00:00
Jakob Ackermann
f11e1a83cd Merge pull request #8776 from overleaf/jpa-drop-service-worker
[web] goodbye service worker

GitOrigin-RevId: ce85d4850faba15c5877ce1f3e78026de30c6eae
2022-07-11 08:03:57 +00:00
Alf Eaton
0b942bd8a8 Merge pull request #8708 from overleaf/ae-loading-threads-fix
Only dispatch the loaded_threads event once

GitOrigin-RevId: d9b8bf4a84d115fcc00edbf1901565ddb407c8be
2022-07-05 08:04:02 +00:00
Alf Eaton
4657465c0d Merge pull request #8703 from overleaf/ae-threads-loaded
Ensure that the loaded_threads event isn't dispatched for read-only link sharing users

GitOrigin-RevId: e03581f29f1a0aff122c3c16f4f6a3b70293c301
2022-07-05 08:03:56 +00:00
Alf Eaton
5c94bd81e7 Merge pull request #8699 from overleaf/ae-comment-threads
Show tracked changes highlights if comment threads are not loaded

GitOrigin-RevId: 1aabe62e1aea0b63336ab33cbf199c3f24471495
2022-07-05 08:03:15 +00:00
Alf Eaton
78df903b69 Merge pull request #8639 from overleaf/ae-loading-threads
[cm6] Improve interaction between review panel and CM6

GitOrigin-RevId: 2f15a4821d4edfb5ee00013c74c7ae35fa59559c
2022-07-04 08:03:30 +00:00
Jakob Ackermann
b04bc4798e Merge pull request #8473 from overleaf/ii-cm6-missing-keyboard-shortcuts-2
[cm6] Add missing keyboard shortcuts 2

GitOrigin-RevId: 29f68cd2eb9d0ad931fff463f76ddb91b5275516
2022-06-22 08:05:20 +00:00
John Lees-Miller
fcf9c92160 Split test for log parser changes
GitOrigin-RevId: efe9fb29c5ae56889b686692f8533ae0ae4a3b1d
2022-06-22 08:04:55 +00:00
Eric Mc Sween
4c546adbb1 Add non-capturing groups
GitOrigin-RevId: 313e62d4add4bd0694efd98927032edf6114f8e5
2022-06-22 08:04:36 +00:00
Copybot
f5da397d5c Merge pull request #1024 from gucci-on-fleek:main
GitOrigin-RevId: 759fff1f03907613b225c82d07f31fa691cfd967
2022-06-22 08:04:31 +00:00
ilkin-overleaf
41c715c40d Merge pull request #8378 from overleaf/ii-cm6-three-way-toggle
[cm6] Make cm6 as the default source editor

GitOrigin-RevId: b56724d2c147792c55ce01cf272fbcce16f87916
2022-06-15 08:05:18 +00:00
Tim Down
ca5f438290 Merge pull request #8373 from overleaf/td-review-panel-scroll
Scroll incrementally in response to mouse wheel in review panel

GitOrigin-RevId: 2c1f119ae8dfd09b378a3b265c3543f88e2d1f65
2022-06-13 08:03:55 +00:00
Tim Down
fef395f431 Fix layout shift by nearly always applying overflow-y hidden on review panel (#8174)
* Always hide vertical overflow on the review panel, not just when it's expanded, which prevents it scrolling slightly when scrolling the PDF in some circumstances
* Fix layout shift by always applying overflow-y hidden on review panel and make entry visible in minimized review panel by making the overflow visible while hovering over the entry

GitOrigin-RevId: 854ee47a762ee2cf78fbbb5856afddb3b723d679
2022-06-13 08:03:37 +00:00
Tim Down
c0292d96a1 Add vertical padding to CM6 editor content to deal with overflowing entries in the review panel (#8321)
GitOrigin-RevId: 9f8265dba773008ba8f97053ce66f23dc4b7121f
2022-06-13 08:03:32 +00:00
Timothée Alby
ae207f7559 Merge pull request #8326 from overleaf/ta-pdf-detach-redundant-controls
Bring Back Redundant Layout Controls

GitOrigin-RevId: a725e8742ab41612b285bcab23054ba9da15b60f
2022-06-09 08:02:34 +00:00
Alf Eaton
917d87257d [cm6] Improve LaTeX autocomplete extension (#8317)
* Upgrade CodeMirror packages

* Merge Metadata types

* Move symbol completions to the symbol-palette module

* Update categories.js

* squash metadata type

* Add open-autocomplete extension

* Increase delay for doc metadata request

* Add metadata state field

* Add bibliographyStyle completions

* Add class names

* Decrease score of usePackage completion

* Improve autocomplete

* Tidy comments

* Use CompletionSource type

* Use sourceEditorCompletionSources

* Update package-lock.json

* Update package.json

* Add tests

* Update window.ts

* Update open-autocomplete.ts

* Tidying

* Update complete.ts

* Fix test

* Add test

* Update top-hundred-snippets.ts

GitOrigin-RevId: 0d8721975893b76d9604b6123576b3a68f178e65
2022-06-09 08:02:32 +00:00
Eric Mc Sween
cb657d1f1c Merge pull request #8297 from overleaf/em-halt-on-error-logs
Stop on first error info box in logs pane

GitOrigin-RevId: cf11f65d582d98bea93c6506393940d9a6144c0d
2022-06-08 08:03:12 +00:00
Miguel Serrano
430b7528b2 Merge pull request #8073 from overleaf/ta-td-dictionary
Add UI to Remove Words from Dictionary

GitOrigin-RevId: a28d865e3c968d6fff113237fcf4143b77af046e
2022-05-25 08:09:45 +00:00
Timothée Alby
5a1ff8149d Merge pull request #8001 from overleaf/ta-td-refactor-learned-words
Refactor Learned Words Class

GitOrigin-RevId: eae6558b5d4eb03b95df511d1cd9ba35b22bb344
2022-05-24 08:04:54 +00:00
Alf Eaton
44d4d8b15d Ensure that file tree re-opens on page load (#8061)
GitOrigin-RevId: ec3d6a43a34aefa2e9574ef7b1b61f8a53b74263
2022-05-24 08:03:58 +00:00
Alf Eaton
1f24160005 Switch layouts using custom divider toggle (#7995)
GitOrigin-RevId: 15e517f448165a25df616fd956967202491b15cc
2022-05-23 08:03:30 +00:00
Alf Eaton
77ac1514fd Reduce calls to jQuery layout() (#7994)
GitOrigin-RevId: 2cfac1e22187bc9f5185724f05f6f92f18c16baa
2022-05-23 08:03:27 +00:00
Max Chernoff
92c18d0ff4
Parse class/expl3/luatexbase warnings
See overleaf/overleaf#1023.

Signed-off-by: Max Chernoff <49086429+gucci-on-fleek@users.noreply.github.com>
2022-05-22 22:36:06 -06:00
Alf Eaton
9062d4ce5d Merge pull request #7983 from overleaf/td-cm6-smooth-scroll-between-comments
Enable animation when positioning comments in CM6

GitOrigin-RevId: 9a5355c3c2105a3dfa26590c2b007571b55c9dcc
2022-05-19 08:03:42 +00:00
Alf Eaton
5a5436d38f Run $digest in a timeout (#7996)
GitOrigin-RevId: e3c0e9f3cdf917f6a112064086454d64fea489cf
2022-05-19 08:03:25 +00:00
Alf Eaton
5d05b2b21d Restore "layout-left" styles for collapsed review panel comment popover (#7999)
GitOrigin-RevId: 230e202496c8bc7e4929fca9c35b7f8eba25653b
2022-05-19 08:03:08 +00:00
Jakob Ackermann
f0bd6dda23 Merge pull request #7986 from overleaf/jpa-eslint-8
[misc] upgrade eslint packages to the latest version everywhere

GitOrigin-RevId: f1480d4a171acef82fb26c4aa54be3a6088b0ab3
2022-05-17 08:05:59 +00:00
Alf Eaton
3a81428ef3 Merge pull request #7795 from overleaf/ae-history-view
Avoid switching away from v1 history view when a file is selected

GitOrigin-RevId: 7b7d75f5e4c63bf899fc7f1f5c7c17119863177b
2022-05-10 08:03:54 +00:00
Alf Eaton
e096bf051a Open the correct doc on tracked change click in overview (#7622)
GitOrigin-RevId: 7bef9341c315f350c5428f8c94ce84cbc4f850c5
2022-04-25 08:04:12 +00:00
Alf Eaton
b70e63e893 Focus the editor after restoring a stored cursor position (#7628)
GitOrigin-RevId: d4564f14503957a0fc8a02cef21064777e2e961d
2022-04-25 08:03:56 +00:00
Timothée Alby
a110c4d7bd Merge pull request #7323 from overleaf/ta-synctex-disable-multi-one-way
Don't Disable Synctex PDF-to-Code Button

GitOrigin-RevId: 90328e0fea8cb5358217ce866839f5e1a4a73b94
2022-04-13 08:03:36 +00:00