Commit graph

20229 commits

Author SHA1 Message Date
M Fahru
075b83be8a Merge pull request #19696 from overleaf/mf-strikethrough0-text-color-change
[web] Change color of strikethrough text to `neutral-60` to improve color contrast

GitOrigin-RevId: 259bc6370fb2d02c073c7409ead5b97e08dc9724
2024-08-01 08:06:03 +00:00
M Fahru
9622e1924d Merge pull request #18296 from overleaf/mf-reverse-button-containers-buttons
[web][website-redesign] Reverse the position for button pair inside of `.responsive-button-container` element

GitOrigin-RevId: 72e229b37adb390c904abbabaec04e9ee964aba4
2024-08-01 08:05:54 +00:00
M Fahru
596dd87c5a Merge pull request #19611 from overleaf/ds-plans-page-faq-follow-up-finishing
Website redesign - Plans page FAQ section follow up adding modal

GitOrigin-RevId: fac7f0c676fa36e76842ec3f682d759ebcdbafbe
2024-08-01 08:05:49 +00:00
Jessica Lawshe
28c0ab80ad Merge pull request #19662 from overleaf/jel-light-touch-tabs
[web] Update plan tab buttons for light touch redesign

GitOrigin-RevId: 0ee3e7a9c277097abd32dcae2cc49a1a4b01e6f0
2024-08-01 08:05:37 +00:00
Jessica Lawshe
580111b984 Merge pull request #19638 from overleaf/jel-light-touch-payment-methods
[web] Update payment method section on the plans light touch redesign

GitOrigin-RevId: aa55b888b0d02e39cd907de4a675d61836d6aa01
2024-08-01 08:05:33 +00:00
Alf Eaton
6d806ff2a4 Upgrade PDF.js to 4.5.136 (#19690)
GitOrigin-RevId: acd5c9e61bb7df37d82f5a1a5ec81f2b388d3807
2024-08-01 08:05:24 +00:00
M Fahru
686d6066b8 Merge pull request #19047 from overleaf/mf-new-plans-group-member-picker
Group member picker for desktop view on the new plans page

GitOrigin-RevId: ffbbdea404366b647d68167b943cf14565cd12eb
2024-08-01 08:05:16 +00:00
andrew rumble
8af5fa0378 Upper-case for all methods
This is required by the fetch-api.

GitOrigin-RevId: 641c63ad2fe6b9d01c48c28faf669051de8f3271
2024-08-01 08:05:11 +00:00
andrew rumble
2477ac6c50 Upper case PUT for consistency
GitOrigin-RevId: e3ce6b652ee9cee8a719b56d0dddda2faf575968
2024-08-01 08:05:06 +00:00
andrew rumble
cbf8832908 Fix typos
GitOrigin-RevId: 69477e3d95db2862f745f43d97a6f98430a1973c
2024-08-01 08:05:01 +00:00
andrew rumble
67cb9fc1b3 Separate qs out from url
GitOrigin-RevId: 8a1c45d3d71240e63f78f2f1920b324577eb7e6d
2024-08-01 08:04:56 +00:00
andrew rumble
709982ac65 Switch request out for fetch
GitOrigin-RevId: b011976084d113c250b002c1bae23f6b38a3281c
2024-08-01 08:04:52 +00:00
andrew rumble
2ccd39b2fa Switch to using status over statusCode
This is a difference in the request/fetch APIs.

GitOrigin-RevId: bde9adcf4de2ceaabfd9baae7a93bf2b0b5e5a1e
2024-08-01 08:04:47 +00:00
andrew rumble
0a62bc1239 Fix typo in name of method
GitOrigin-RevId: fe8a2bcf5e577c001c4508b7bb010e1738ccc903
2024-08-01 08:04:42 +00:00
Jakob Ackermann
e08b0b3d9e Merge pull request #19686 from overleaf/jpa-fix-ce
[web] sync overleafModuleImports between environments and check in CI

GitOrigin-RevId: c36c41d87d1b6fd687942bca8284a4725bb6c300
2024-08-01 08:04:37 +00:00
Jimmy Domagala-Tang
91125f8b1c Merge pull request #19639 from overleaf/jdt-line-tracker-max-callstack-event
Adding events to line-tracker

GitOrigin-RevId: 97601af3c332244d10a3e97eb22a80a0eb240ad3
2024-07-31 08:05:41 +00:00
M Fahru
b775f26024 Merge pull request #19517 from overleaf/mf-overleaf-common-request-link
Implement "request overleaf common" section in the student tab for plans new design

GitOrigin-RevId: 5ef3987c0d877bee25a4b595c345c550370903d6
2024-07-31 08:05:37 +00:00
M Fahru
e811436dd4 Merge pull request #19648 from overleaf/mf-remove-strike-plans-page
Convert `strike` to `s` because `strike` was already deprecated

GitOrigin-RevId: 48dc9fe1a20c1b354c0935d313b1fc5f515cd1fa
2024-07-31 08:05:33 +00:00
Jessica Lawshe
223a4efd3d Merge pull request #19618 from overleaf/jel-light-touch-btns
[web] Light touch plans redesign CTAs

GitOrigin-RevId: 7b9be331420044fda08eac563567f1cce4c0c1c2
2024-07-31 08:05:29 +00:00
Jessica Lawshe
9e665c3a10 Merge pull request #19616 from overleaf/jel-light-touch-educational
[web] Light touch plans redesign license picker and `?` icon

GitOrigin-RevId: 071842c37e2129cf62981317f7a23b8cd5410dba
2024-07-31 08:05:24 +00:00
Jessica Lawshe
a21c8c6d19 Merge pull request #19601 from overleaf/jel-light-touch-toggle
[web] Update monthly/annual toggle on the light touch plans redesign

GitOrigin-RevId: 46c3ec317b589e5a389336d429c7bba2a61af61c
2024-07-31 08:05:20 +00:00
Jessica Lawshe
06b66c7ccc Merge pull request #19664 from overleaf/jel-plans-js
[web] Fix interstitial payment page when loaded with a hash in the URL

GitOrigin-RevId: 81cdf27cd13aed149f5453a997df05949eb6b01b
2024-07-31 08:05:16 +00:00
Antoine Clausse
1e36db524f [web] Merge authentication error handling (V1LoginController & AuthenticationController) (#19457)
* Promisify `AuthenticationController.doPassportLogin`

* Update tests `AuthenticationController.doPassportLogin`

* Add test on error handling for `AuthenticationController.doPassportLogin`

* Add test on error handling for `V1LoginController.doLogin`

* Extract error handling to `getErrorObject` function

* Simplify code

* Add `Metrics` calls

* Add `password is too long` in AuthenticationController

* Make `info` object consistent with the rest of the codebase

* Move error handling to `AuthenticationManager.handleAuthenticateErrors`

* Move `handleAuthenticateErrors` to other file

I moved this solely because I didn't manage to test it otherwise

* Update tests

* Remove `preDoPassportLogin` hook call

* Remove test on `preDoPassportLogin`

* Use try/catch block instead of `.catch()`

* Revert "Use try/catch block instead of `.catch()`"

This reverts commit 3475afa93ce4af7ad55c91bfc1d7ad3317600ea5.

* Replace `.catch` by `try/catch`

GitOrigin-RevId: 3fba65c30a2c5fc6e5abcd5b83c52801852ed462
2024-07-31 08:05:07 +00:00
Mathias Jakobsen
6d5e503aba Merge pull request #19672 from overleaf/mj-fix-event-segmentation-cite
[web] Fix BQ even segmentation

GitOrigin-RevId: 1332e6dc1214129f1c1d628e138a3ad066c10bf6
2024-07-31 08:04:39 +00:00
Liangjun Song
e2d87f4821 Revert "Revert "log clsi concurrency (#19651)" (#19655)" (#19656)
This reverts commit 3719f468a6336ff4bf5126f3e5d79dcde172b7ea.

GitOrigin-RevId: 6f4809f3c607c62892fc1e110eeaa2a1e7a124a4
2024-07-31 08:04:28 +00:00
Mathias Jakobsen
4eb88a6d1a Merge pull request #19531 from overleaf/mj-cite-key-analytics
[web] Add analytics for cite key searches

GitOrigin-RevId: f9215a6db8defb4d7c8356e997b671223cfcfb70
2024-07-31 08:04:23 +00:00
Liangjun Song
39112dafb7 Revert "log clsi concurrency (#19651)" (#19655)
This reverts commit 504f6f9cc3d4b7386dbcde86f76c1cf3a13e944f.

GitOrigin-RevId: 3719f468a6336ff4bf5126f3e5d79dcde172b7ea
2024-07-30 08:05:52 +00:00
Davinder Singh
08252914f5 Merge pull request #19546 from overleaf/ds-plans-page-groups-tab-plan-cards-mobile
Plans page (New design mobile) - Adding plan cards in groups tab

GitOrigin-RevId: bd11a3edb5899181a1872fd6e77578e284588f83
2024-07-30 08:05:48 +00:00
Davinder Singh
1b23c1da09 Merge pull request #19636 from overleaf/ds-table-header-sticky-2
Plans page - Making the features table header sticky

GitOrigin-RevId: 37976acfbdcc671178ef5613b2e9eb6d02c70296
2024-07-30 08:05:43 +00:00
Jimmy Domagala-Tang
a4992f6970 Merge pull request #19504 from overleaf/jdt-ai-error-feedback-notif
AI Error Assistant Feedback Notification

GitOrigin-RevId: 340427cdca2db75b80f36a0b281af5403faa6f20
2024-07-30 08:05:39 +00:00
Jimmy Domagala-Tang
837fea03b9 Merge pull request #19448 from overleaf/jdt-experiments-max-subscribers
Enforce a maximum participant cap on experiments

GitOrigin-RevId: 1d9263cd34a3d0c831c0ed43867bb4e6430eb06c
2024-07-30 08:05:34 +00:00
Liangjun Song
01b7896717 log clsi concurrency (#19651)
GitOrigin-RevId: 504f6f9cc3d4b7386dbcde86f76c1cf3a13e944f
2024-07-30 08:05:26 +00:00
Alf Eaton
77a78a4458 [visual] Add events for tracking usage of the pasted content menu (#19589)
GitOrigin-RevId: e38add2215b0cd49f6c7c216f141e26ee8e3a179
2024-07-30 08:05:22 +00:00
Alf Eaton
e4d971151b [visual] Add coordsAt to decoration widgets (#19577)
GitOrigin-RevId: d445e68a14bbe819e126b6bf6a2328a00520c39a
2024-07-30 08:05:17 +00:00
Alf Eaton
8821a6d2f4 Work around Safari 15's incomplete support for dvh units (#19567)
GitOrigin-RevId: ff6429d6a918413857dd8116611c9857958f68ed
2024-07-30 08:05:13 +00:00
Alf Eaton
4af10054df Ensure that the visual editor recognises a "drop" event as a "mouseup" (#19560)
GitOrigin-RevId: 967d3c80a1501ffdfe9a7e3e978cba746a54d7b3
2024-07-30 08:05:08 +00:00
Alf Eaton
21e458df2a Improve PDF double-click listener (#19556)
GitOrigin-RevId: 3d8f316481d8be30ffe1a04a270b978b4720ccbe
2024-07-30 08:05:03 +00:00
Alf Eaton
4c76667379 Avoid loading ranges twice for overview panel (#19554)
GitOrigin-RevId: da8cc295fe672a97e76b93cc7e88dc1f6d3d044d
2024-07-30 08:04:59 +00:00
roo hutton
1a535acedd Merge pull request #19650 from overleaf/rh-link-sharing-extension
[web] Change link sharing enforcement date to august 26th

GitOrigin-RevId: f8fd3bfddaa06ad956b576bee13194ccd5d77cb8
2024-07-30 08:04:54 +00:00
Alexandre Bourdin
5bc5b1af2a Merge pull request #19562 from overleaf/ab-modules-dependencies
[web] Modules dependencies

GitOrigin-RevId: d8bbb25a754f2ed58b1b1e924aa760b87d3135c6
2024-07-30 08:04:36 +00:00
Alexandre Bourdin
dcf6e502b9 Merge pull request #19443 from overleaf/ab-overleaf-integration-refacto-move-institutions
[web] Move onboarding related code to onboarding module

GitOrigin-RevId: 405d4c3588f3911867fecd02b36e55fcd7633615
2024-07-30 08:04:31 +00:00
Antoine Clausse
5f2718cf29 [web] Make rate-limit on login consistent, prevent "trim/case bypass" (#19555)
* Replace `LoginRateLimiter.processLoginRequest` call by use of `RateLimiterMiddleware`

* Lowercase the email to avoid rate-limit bypass

* Remove unit test "when the users rate limit"

* Use `EmailHelper.parseEmail` to normalize email in `processLoginRequest`

This should address the `trim()` bypass

* Use `.trim().toLowerCase()` instead of `EmailHelper.parseEmail`

We can't use `EmailHelper.parseEmail`, else it breaks the test (and feature): "with username that does not look like an email"

* Add acceptance test for rate limit

* Add comment on rate limits

* Rename `rateLimiter` to `rateLimiterLoginEmail` for clarity

* Make the login rate limits configurable from the settings

GitOrigin-RevId: cf1c3a416745f2b007c85014a5084570d4a049a7
2024-07-30 08:04:26 +00:00
Antoine Clausse
7212c16dde [web] Fix: sendConfirmationEmail promise (!!!) (#19629)
* Fix `sendConfirmationEmail` promise (!!!)

* Fix: No nested promises, and `sendConfirmationEmail`->`sendReconfirmationEmail`

* Add integration test on `/user/emails/send-reconfirmation`

* Update integration test: use the previously generated token

GitOrigin-RevId: f6386abeb06888351eec22fbcb1d3c614ff5c5c5
2024-07-29 08:04:41 +00:00
David
72c7b946ed Merge pull request #19617 from overleaf/dp-tooltip-alignment
Always render math preview tooltip at start of math content

GitOrigin-RevId: b0af7aa3c0920b2a9b9930f27a580018de1d2f52
2024-07-29 08:04:36 +00:00
Antoine Clausse
afd965c04b [web] Remove overleaf-integration overrides for /user/emails/delete & /user/emails/resend_confirmation (#19438)
* Use hooks to call `clearSamlSession`

* Promisify `UserEmailsController.remove`

* Use hook for `userDeleteEmailMiddleware`

* Remove `/user/emails/delete` override

* Remove "removeRoute of `/user/emails/resend-secondary-confirmation`"

That route isn't defined elsewhere

* Promisify `UserEmailsController.resendConfirmation`

* Promisify `UserEmailsController.sendReconfirmation`

* Use hook for `resendConfirmationEmailMiddleware`

* Remove `/user/emails/resend_confirmation` override

* Promisify `tryDeleteUser`

* Proxy `clearSamlSession` through `SAMLHelper`

* Revert "Use hook for `resendConfirmationEmailMiddleware`"

This reverts commit f028d9c8

* Inject `SAMLMiddleware.resendConfirmationEmailMiddleware` in `/user/emails/resend_confirmation`

* Update `middleware` syntax and grammar

* Update tests

* Use Module middleware instead of hook for `userDeleteEmailMiddleware`

* Remove "promises" export of tryDeleteUser

GitOrigin-RevId: 211e194fc1ef82dc452ee4e837dcddd9b23690a0
2024-07-29 08:04:24 +00:00
Jessica Lawshe
606f9eaec7 Merge pull request #19594 from overleaf/jel-light-touch-table-checkmark
[web] Add new green checkmark to plans light touch redesign

GitOrigin-RevId: f6c38e819fdd784ccf39ab09109a33fcd58f23d8
2024-07-26 08:05:02 +00:00
Jessica Lawshe
d3ee849415 Merge pull request #19568 from overleaf/jel-light-touch-table-mobile
[web] Adjustments for mobile view on light touch plans redesign

GitOrigin-RevId: cadbcad321da8a20733b13c65e3f3aa9302e7ea8
2024-07-26 08:04:58 +00:00
Jessica Lawshe
1f432ca5a9 Merge pull request #19447 from overleaf/jel-light-touch-table-final-bits
[web] Updates for the light touch redesign of the plans table

GitOrigin-RevId: 44ba4fde9b192f3792bf295557fa1018c83a2119
2024-07-26 08:04:53 +00:00
Jessica Lawshe
85ec182859 Merge pull request #19446 from overleaf/jel-light-touch-file-reorg
[web] File reorganization of light touch redesign

GitOrigin-RevId: 6ea13a5d0053bdfd71f9d29d417f73f06a492d49
2024-07-26 08:04:48 +00:00
Jessica Lawshe
72821743fc Merge pull request #19415 from overleaf/jel-highlighted-col
[web] Update highlighted column for plans page light touch redesign

GitOrigin-RevId: 98a0d6c34762bb7f4530da9cd6d954c2ae1aae56
2024-07-26 08:04:44 +00:00