Commit graph

17886 commits

Author SHA1 Message Date
Miguel Serrano
a4027b4fc4 Merge pull request #737 from Soptq/patch-2
Restrict Redis version to 5.0.0
2020-05-18 15:41:13 +02:00
Jakob Ackermann
79ea042959 Merge pull request #137 from overleaf/jpa-backport-strict-sequence
[misc] backport strict sequence of redis (un)subscribe
2020-05-18 12:31:31 +02:00
Jakob Ackermann
4e400dc7da Merge pull request #136 from overleaf/jpa-backport-sinon-v2
[misc] backport sinon v2
2020-05-18 11:18:06 +02:00
Eric Mc Sween
65fe74fd2d Upgrade Sinon 2020-05-15 15:34:14 -04:00
Eric Mc Sween
759d385be8 Decaf cleanup: unused variables 2020-05-15 14:43:05 -04:00
Eric Mc Sween
86747ba64f Decaf cleanup: stub setup in tests 2020-05-15 14:43:03 -04:00
Eric Mc Sween
9e4280916a Decaf cleanup: unnecessary returns 2020-05-15 14:41:04 -04:00
Jakob Ackermann
d13acb8ca3 [ChannelManager] port related and still mostly valid test from v2
I skipped the bulk of verifyConsistentBehaviour tests which are not
 valid for the new implementation -- there is no optimization and
 always cleanup.
2020-05-15 18:39:33 +02:00
Jakob Ackermann
41debfae0f [ChannelManager] rework (un)subscribing to redis
- send a subscribe request on every request
- wait for a pending unsubscribe request before subscribing
- wait for a pending subscribe request before unsubscribing

Co-Authored-By: Brian Gough <brian.gough@overleaf.com>
2020-05-15 18:34:33 +02:00
John Lees-Miller
6cc03cad0c Add coverage 2020-05-15 17:18:01 +01:00
John Lees-Miller
c9d9982615 Update package.json metadata 2020-05-15 16:50:37 +01:00
Brian Gough
3db513cfc9 record latexmk output 2020-05-15 16:08:10 +01:00
Eric Mc Sween
6269ace987 Decaf cleanup: move functions to top level 2020-05-15 09:59:32 -04:00
Eric Mc Sween
3d000bcbe6 Decaf cleanup: use arrow functions for callbacks 2020-05-15 09:59:32 -04:00
Eric Mc Sween
751d9ea718 Decaf cleanup: simplify loops 2020-05-15 09:59:32 -04:00
Eric Mc Sween
7a5a782dc7 Decaf cleanup: camel case variables 2020-05-15 09:59:26 -04:00
John Lees-Miller
676bdb794b Merge pull request #10 from overleaf/v3
Rework to favor tagging over wrapping
2020-05-15 14:53:24 +01:00
Jakob Ackermann
1095851dfe [misc] test/unit: fix typos and assertion of error messages
Sinon does not check the contents of the passed error when checked via
 sinon.stub().calledWith.
```
callback = sinon.stub()
callback(new Error("some message"))
  .calledWith(new Error("completely different message"))
  === true
```

Cherry-pick plus an additional patch for the joinProject bail-out.
(cherry picked from commit d9570fee70701a5f431c39fdbec5f8bc5a7843fe)
2020-05-15 14:46:05 +02:00
Jakob Ackermann
5aad5db40f [checkLogLevel] read the updated tracing end time from disk 2020-05-15 13:39:35 +02:00
John Lees-Miller
d2f47e69a8 Bump version to 3.0.0 2020-05-15 11:25:12 +01:00
John Lees-Miller
fd6ea2bb70 Add typescript types 2020-05-15 11:24:14 +01:00
John Lees-Miller
497f2a7936 Make tag check stricter and use a map 2020-05-15 11:07:08 +01:00
Jakob Ackermann
17d04b9041 [misc] bump sinon to 2.x for promise support with stubs
(cherry picked from commit 3c92b937f9430175d7c51660e03c507635448e88)
2020-05-15 12:01:22 +02:00
John Lees-Miller
4b0060f0b1 Remove HTTPErrors from v3 2020-05-15 10:45:08 +01:00
John Lees-Miller
90494fd75f Fix demo require path 2020-05-15 10:36:00 +01:00
John Lees-Miller
8af22ae878 Improve assertion messages in test utility 2020-05-15 10:32:18 +01:00
Eric Mc Sween
ceb77f4c93 Decaf cleanup: remove unused variables 2020-05-14 16:54:08 -04:00
Eric Mc Sween
6b5760ca28 Decaf cleanup: simplify null checks 2020-05-14 16:53:22 -04:00
Eric Mc Sween
f2c67b66fa Decaf cleanup: remove default callbacks 2020-05-14 16:50:04 -04:00
Eric Mc Sween
2bff83137c Decaf cleanup: unnecessary returns 2020-05-14 16:35:10 -04:00
Eric Mc Sween
819aa378d9 Decaf cleanup: remove Array.from() 2020-05-14 16:32:05 -04:00
Henry Oswald
77e8ba74a7 add pipeUrlToFileWithRetry function to retry file downloads 3 times 2020-05-14 13:24:58 +01:00
Eric Mc Sween
ae82366122 Merge pull request #2827 from overleaf/em-faster-clones
Make a single Mongo update when cloning projects

GitOrigin-RevId: abd4069bd8854d84c413bc8f890583e647b7c18e
2020-05-14 03:26:15 +00:00
Alasdair Smith
0e9e57cd7c Merge pull request #2812 from overleaf/as-upgrade-ace-1.4.10
Upgrade to Ace v1.4.10

GitOrigin-RevId: 1e70b37fd93593d881ae317faa2e2ec146362db2
2020-05-14 03:26:07 +00:00
Jakob Ackermann
b713beb7f0 Merge pull request #135 from overleaf/jpa-skip-leave-project-for-invalid-clients
[WebsocketController] skip leaveProject when joinProject didn't complete
2020-05-13 15:34:41 +02:00
Jakob Ackermann
df9d8ccbbe Merge pull request #134 from overleaf/jpa-handle-redis-subscribe-error-on-join-project
[WebsocketController] handle redis subscribe error on joinProject
2020-05-13 15:34:17 +02:00
Jessica Lawshe
cbba4132e1 Merge pull request #2821 from overleaf/jpa-ns-replace-spellcheck-languages
[script] add a script to replace all unsupported spell check languages

GitOrigin-RevId: 597033b7ae7733f8bc7e5e0f4dfb1a49d0cae3b4
2020-05-13 03:23:28 +00:00
Jessica Lawshe
295264697e Merge pull request #2815 from overleaf/jpa-cmg-project-clone-set-owner
Fix cloning a project putting a question mark next to it

GitOrigin-RevId: beb01e3c4496912beb0478017f14ed889a9a09de
2020-05-13 03:23:23 +00:00
Jessica Lawshe
30a2997b43 Merge pull request #2789 from overleaf/as-fix-no-undef
Enable no-undef linting rule for all frontend files and fix errors

GitOrigin-RevId: bf9c789a381af982bdece55a2f518a2b610c9202
2020-05-13 03:23:18 +00:00
Jessica Lawshe
3778c47aec Merge pull request #2822 from overleaf/spd-oio-moreurls-redux
Allow opening of data URLs and snip arrays in Open-in-Overleaf

GitOrigin-RevId: bf51b1f9e2ef42889825d43303cfb6074fd569a6
2020-05-13 03:23:12 +00:00
Jessica Lawshe
a0c9b12204 Merge pull request #2824 from overleaf/jel-file-count
Exclude deleted files from getFullCount

GitOrigin-RevId: 2d01dc7aee50e8a237fe4c7dc9bbaae27ac53cc1
2020-05-13 03:23:06 +00:00
Jakob Ackermann
55af5e502f [WebsocketController] skip leaveProject when joinProject didn't complete
Also drop dead code:
 - user_id bailout

   There is a check on a completed joinProject call now. It will always
    set a user_id, see Router.coffee which has a fallback `{_id:"..."}`.

 - late project_id bailout

   WebsocketLoadBalancer.emitToRoom will not work without a project_id.
   We have to bail out before the call.
2020-05-12 17:15:08 +02:00
Eric Mc Sween
a4de5848fb Merge pull request #133 from overleaf/em-json-request-size
Make max JSON request size configurable and default to 8 MB
2020-05-12 08:02:25 -04:00
Jakob Ackermann
684cb3903c [WebsocketController] handle redis subscribe error on joinProject
joinProject should not complete when the redis pub/sub subscribe request
 failed.
2020-05-12 13:03:50 +02:00
nate stemen
f298787565 Merge pull request #2809 from overleaf/cmg-references-styling
Remove old ShareLaTeX style on reference search hover

GitOrigin-RevId: e4eed24dacc90a5649e0d994094e11dde316a6ca
2020-05-12 03:26:07 +00:00
nate stemen
186adf8410 Merge pull request #2816 from overleaf/jpa-fix-project-list-for-ce
[misc] fix project list for installations w/o affiliations feature

GitOrigin-RevId: 2fa2cf7ac5418e04ab876c7fffcd9614fe7af0b3
2020-05-12 03:26:00 +00:00
Eric Mc Sween
16c0ed23db Fix tests after decaf cleanup
* Camel casing in logs
* The Express request object always has query and body properties
2020-05-11 11:37:59 -04:00
Eric Mc Sween
0b1c7e90af Decaf cleanup: remove unused variables 2020-05-11 11:26:28 -04:00
Eric Mc Sween
3acb970442 Decaf cleanup: simplify stubbed class 2020-05-11 11:24:07 -04:00
Eric Mc Sween
526ef25fcf Decaf cleanup: unnecessary returns 2020-05-11 11:20:55 -04:00