Commit graph

17886 commits

Author SHA1 Message Date
Hugh O'Brien
b48b937f26 Merge pull request #3133 from overleaf/hb-fix-bibtex-error-crash
Stop bib log parser after 500 iterations per parser

GitOrigin-RevId: 415624c20154b4fd4054f166179cd455a7cc2d4d
2020-08-26 02:04:45 +00:00
Miguel Serrano
7f5ac7a932 Merge pull request #3139 from overleaf/revert-3116-msm-pdfjs-2-4
Revert "Update pdf.js to 2.4.456"

GitOrigin-RevId: 73c9d3fc7b7d746a36ac90c1bf85e2b6d9ca1ec9
2020-08-26 02:04:40 +00:00
Hugh O'Brien
3aaab7270c Merge pull request #3116 from overleaf/msm-pdfjs-2-4
Update pdf.js to 2.4.456

GitOrigin-RevId: 29ce64acd44914b2f890f7b05c77ef890c315d01
2020-08-26 02:04:35 +00:00
Hugh O'Brien
3825475aea Merge pull request #3132 from overleaf/hb-update-leaving-email
Update cancel subscription email

GitOrigin-RevId: c3226a760e5e71483788bdb99fc355e3e8c829eb
2020-08-26 02:04:29 +00:00
Jakob Ackermann
425052ff91 Merge pull request #187 from overleaf/jpa-o-error-tagging
[misc] migrate to OError tagging/wrapping
2020-08-25 11:46:28 +02:00
Jakob Ackermann
64e659bf43 Merge pull request #186 from overleaf/jpa-fix-join-project-error-context
[misc] fix join project error context
2020-08-25 11:46:18 +02:00
Jakob Ackermann
849a1cf416 Merge pull request #185 from overleaf/jpa-doc-id-in-error-context
[misc] add/bring back doc_id in error context
2020-08-25 11:42:41 +02:00
Jakob Ackermann
735027a2b7 Merge pull request #184 from overleaf/jpa-custom-errors
[misc] migrate to custom OErrors
2020-08-25 11:42:19 +02:00
Jakob Ackermann
6df23a9712 Merge pull request #183 from overleaf/jpa-increase-unit-test-timeout
[misc] increase the timeout for unit tests -- CI boxes are too slow
2020-08-25 11:41:53 +02:00
Jakob Ackermann
ed0426478c Merge pull request #66 from overleaf/jpa-mongodb-native
[misc] migrate to the native mongo driver
2020-08-25 11:00:34 +02:00
Jakob Ackermann
2fa09928ee [misc] migrate acceptance tests to the native mongo driver, drop mongojs 2020-08-25 09:41:23 +01:00
Jakob Ackermann
df0747ec48 [misc] migrate the app to the native mongo driver
acceptance tests to follow in a separate commit
2020-08-25 09:40:59 +01:00
Jakob Ackermann
b5e770daff Merge pull request #56 from overleaf/jpa-wait-for-db
[misc] simplify the naming around waiting for a mongo connection
2020-08-25 10:20:37 +02:00
Jessica Lawshe
bde7ef600f Merge pull request #3138 from overleaf/jel-csrf-fix
Fix validateToken signature

GitOrigin-RevId: fbedaa76ec0fa2134a08aa43c28c3756f8a2afe6
2020-08-25 02:04:34 +00:00
CloudBuild
2cd5bcca60 auto update translation
GitOrigin-RevId: cea732cc8dd7106771beecc5d30cd4bffe276698
2020-08-25 02:04:28 +00:00
Timothée Alby
cc218c98c2 Merge pull request #3098 from overleaf/jel-dropbox-tidy
Tidy DropboxUserController and DropboxHandler

GitOrigin-RevId: f492b35af06d02b6401b99467e887a92d5335b56
2020-08-25 02:04:23 +00:00
Timothée Alby
1ff2c6ce00 Merge pull request #3117 from overleaf/sk-block-tpds-update-on-archived-project
Block TPDS update on archived/trashed project

GitOrigin-RevId: 7db41a313b03721b93cbb601add6f91ae31f3f2a
2020-08-25 02:04:17 +00:00
Timothée Alby
750a20491d Merge pull request #3131 from overleaf/pr-fix-context-menu-placement-folders
Fix ellipsis icon placement in folders

GitOrigin-RevId: 4004ed43c8dd138e8f774d660e712bc7076e8b62
2020-08-25 02:04:12 +00:00
Timothée Alby
bc90ffb1e8 Merge pull request #3105 from overleaf/ta-outline-go-to-pdf
[Outline] Go To PDF on Double-Click

GitOrigin-RevId: 0be4207eb26d0712814097b71906b3c9c37d4790
2020-08-25 02:04:05 +00:00
Jakob Ackermann
39ea30355e [misc] simplify the naming around waiting for a mongo connection
Co-Authored-By: Eric Mc Sween <eric.mcsween@overleaf.com>
Co-Authored-By: Miguel Serrano <mserranom@gmail.com>
Co-Authored-By: Simon Detheridge <s@sd.ai>
2020-08-24 17:41:03 +01:00
Jakob Ackermann
ee3d3b09ed [misc] wrap redis errors as tagging does not work with them
ioredis may reuse the error instance for multiple callbacks. E.g. when
 the connection to redis fails, the queue is flushed with the same
 MaxRetriesPerRequestError instance.
2020-08-24 10:12:20 +01:00
Jakob Ackermann
537e97be73 [misc] OError.tag all the errors in async contexts
See the docs of OError.tag:
https://github.com/overleaf/o-error#long-stack-traces-with-oerrortag
(currently at 221dd902e7bfa0ee92de1ea5a3cbf3152c3ceeb4)

I am tagging all errors at each async hop. Most of the controller code
 will only ever see already tagged errors -- or new errors created in
 our app code. They should have enough info that we do not need to tag
 them again.
2020-08-24 10:12:06 +01:00
Jakob Ackermann
8e31cc5c23 [Router] _handleError: joinProject error-context may not have project_id
The ol_context patch changed the priority of client context and rpc
 context.
This lead to the (possibly missing) project_id of the client context
 overwriting the project_id of the rpc context.
REF: f1d55c0a5437a518e9f4617473caed9ba928e648
2020-08-21 13:29:28 +01:00
Jakob Ackermann
f935b1881a [Router] leaveDoc: pass the doc_id into the error-context 2020-08-21 12:47:42 +01:00
Jakob Ackermann
fd88819eec [Router] _handleError: ol_context.doc_id does not exist, drop overwrite 2020-08-21 12:47:42 +01:00
Jakob Ackermann
880056d397 [Router] use a new UnexpectedArgumentsError 2020-08-21 12:47:08 +01:00
Jakob Ackermann
50140f785a [WebsocketController] use a new JoinLeaveEpochMismatchError 2020-08-21 12:47:08 +01:00
Jakob Ackermann
0462e3e437 [WebsocketController] use a new NotJoinedError 2020-08-21 12:47:07 +01:00
Jakob Ackermann
4cb8cc4a85 [DocumentUpdaterManager] use a new ClientRequestedMissingOpsError 2020-08-21 12:47:07 +01:00
Jakob Ackermann
8abfdb87ff [DocumentUpdaterManager] use a new DocumentUpdaterRequestFailedError 2020-08-21 12:47:07 +01:00
Jakob Ackermann
02a2382264 [WebApiManager] use a new CorruptedJoinProjectResponseError 2020-08-21 12:47:07 +01:00
Jakob Ackermann
68bc9d0d23 [WebApiManager] use a new WebApiRequestFailedError 2020-08-21 12:47:06 +01:00
Jakob Ackermann
59c4c884a5 [WebsocketController] use the new NotAuthorizedError 2020-08-21 12:47:06 +01:00
Jakob Ackermann
a8c51de510 [AuthorizationManager] use a new NotAuthorizedError 2020-08-21 12:47:06 +01:00
Jakob Ackermann
de518ea4eb [SessionSockets] use a new MissingSessionError 2020-08-21 12:47:05 +01:00
Jakob Ackermann
6828becb46 [DocumentUpdaterManager] use a new NullBytesInOpError 2020-08-21 12:47:05 +01:00
Jakob Ackermann
af50f9b02c [DocumentUpdaterManager] use a new UpdateTooLargeError 2020-08-21 12:47:05 +01:00
Jakob Ackermann
5950b26a42 [SafeJsonParse] migrate to OError and use a new DataTooLargeToParseError 2020-08-21 12:47:05 +01:00
Jakob Ackermann
f82177a46a [Errors] migrate to OError 2020-08-21 12:47:04 +01:00
Jakob Ackermann
c7b9dadd16 [misc] increase the timeout for unit tests -- CI boxes are too slow 2020-08-21 12:45:30 +01:00
dependabot[bot]
851d4bda46 Bump lodash from 4.17.15 to 4.17.20
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.20.
- [Release notes](https://github.com/lodash/lodash/releases)
- [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.20)

Signed-off-by: dependabot[bot] <support@github.com>
2020-08-20 15:07:10 +00:00
Jakob Ackermann
d345911730 Merge pull request #54 from overleaf/jpa-wait-for-mongo
[misc] complete the connection setup before starting the http server
2020-08-20 17:06:12 +02:00
Jakob Ackermann
9693c349b4 Merge pull request #52 from overleaf/jpa-drop-unsafe-buffer-usage
[misc] get rid of unsafe Buffer usage
2020-08-20 17:04:18 +02:00
Christopher Hoskin
5e4decbfff Merge pull request #3125 from overleaf/csh-issue-3437-copybara-ci-fix
Remove Jenkinsfile, fix cloudbuild.yaml in copybarra exclusions

GitOrigin-RevId: d4ad374da44ff218e6068b84371deed45a4cd828
2020-08-20 10:21:59 +00:00
Jakob Ackermann
694a6937c3 Merge pull request #3123 from overleaf/jpa-hotfix-merge
[misc] fix merge of AuthenticationController

GitOrigin-RevId: 7945a6e3b6f0c5e816db2a02745dc75a30928392
2020-08-20 02:06:37 +00:00
Jakob Ackermann
b61ab62efb Merge pull request #3120 from overleaf/jpa-batched-update-continue
[scripts] batchedUpdate: add support for passing in the tail of the log

GitOrigin-RevId: 50b573ec4f90026c3c2c660a5313fdd62817dbd9
2020-08-20 02:06:31 +00:00
Jakob Ackermann
a22e252666 Merge pull request #3114 from overleaf/msm-remove-logger-warn-controllers
Replaced logger statements with error tagging in Controllers

GitOrigin-RevId: c5231913c82f95a325f4c3ab406d89cb534835a4
2020-08-20 02:06:25 +00:00
Jakob Ackermann
674954f96f Merge pull request #3094 from overleaf/sk-restrict-admin-flag
Check domain of emails on admin users

GitOrigin-RevId: 75de9cff30e3c628249fcd0ea3446a33d51d39b4
2020-08-20 02:06:19 +00:00
Jakob Ackermann
959b5853a6 [misc] complete the connection setup before starting the http server 2020-08-19 13:06:22 +01:00
Jakob Ackermann
0c8f04a011 [misc] migrate to native mongo driver 2020-08-19 13:04:47 +01:00