Commit graph

17886 commits

Author SHA1 Message Date
Jakob Ackermann
41ee63c1f1 [misc] add the dependabot config of the buildscripts
See inline docs for rationals of each (non-trivial) option.
2020-09-04 09:23:20 +01:00
dependabot[bot]
7ee0b2b7e2 Bump bl from 2.2.0 to 2.2.1
Bumps [bl](https://github.com/rvagg/bl) from 2.2.0 to 2.2.1.
- [Release notes](https://github.com/rvagg/bl/releases)
- [Commits](https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-03 20:00:20 +00:00
Eric Mc Sween
67f4a6eeeb Decaf cleanup: normalize functions
Use function keyword for declarations and arrow functions for callbacks.
2020-09-03 15:58:16 -04:00
dependabot[bot]
9d2a30c919 Bump bl from 2.2.0 to 2.2.1
Bumps [bl](https://github.com/rvagg/bl) from 2.2.0 to 2.2.1.
- [Release notes](https://github.com/rvagg/bl/releases)
- [Commits](https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-03 19:54:31 +00:00
Eric Mc Sween
5cd889038e Use _.once() instead of ad hoc implementation 2020-09-03 15:52:09 -04:00
Eric Mc Sween
a853950a99 Fix container monitor cleanup function
The intent here is clearly to clear both the timeout and the interval.
2020-09-03 15:50:45 -04:00
Eric Mc Sween
30a44edded Decaf cleanup: simplify variable declarations 2020-09-03 15:50:12 -04:00
Eric Mc Sween
a282bccd48 Do not instantiate errors at module load time
This prevents the right stack trace from being captured.
2020-09-03 15:34:19 -04:00
Eric Mc Sween
4905e7db2c Decaf cleanup: unused vars 2020-09-03 15:30:07 -04:00
dependabot[bot]
96f909deaa Bump bl from 2.2.0 to 2.2.1
Bumps [bl](https://github.com/rvagg/bl) from 2.2.0 to 2.2.1.
- [Release notes](https://github.com/rvagg/bl/releases)
- [Commits](https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-03 19:15:41 +00:00
Eric Mc Sween
44bf38d6db Decaf cleanup: convert async function to sync
The examineOldContainer() function doesn't need to use callbacks since
it only does synchronous work.
2020-09-03 15:13:04 -04:00
Eric Mc Sween
2584586ba2 Decaf cleanup: camel-case variables 2020-09-03 15:13:04 -04:00
Eric Mc Sween
c52d7d8f02 Decaf cleanup: simplify null checks 2020-09-03 15:13:04 -04:00
Eric Mc Sween
ee4c08868c Decaf cleanup: remove default callbacks 2020-09-03 15:13:04 -04:00
Eric Mc Sween
32f0bbe266 Decaf cleanup: remove IIFEs 2020-09-03 15:13:04 -04:00
dependabot[bot]
cc3ccc2713 Bump bl from 2.2.0 to 2.2.1
Bumps [bl](https://github.com/rvagg/bl) from 2.2.0 to 2.2.1.
- [Release notes](https://github.com/rvagg/bl/releases)
- [Commits](https://github.com/rvagg/bl/compare/v2.2.0...v2.2.1)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-03 19:03:30 +00:00
Miguel Serrano
98fea0f22a Merge pull request #3155 from overleaf/revert-3153-msm-pdfjs-2-4-es5
Revert "updated pdf-js to 2.4.456 using es5 distribution"

GitOrigin-RevId: ee55cb77c6abd7fc766aba378d1a1803ed763ff1
2020-09-03 02:04:20 +00:00
Miguel Serrano
b5adbfc4d9 Merge pull request #3153 from overleaf/msm-pdfjs-2-4-es5
updated pdf-js to 2.4.456 using es5 distribution

GitOrigin-RevId: 6890b26300a6984486c3a624cc20712574d8cbf0
2020-09-03 02:04:14 +00:00
Eric Mc Sween
f650da8675 Decaf cleanup: remove __guard__ 2020-09-02 17:06:35 -04:00
Eric Mc Sween
99648341e2 Decaf cleanup: remove unnecessary returns 2020-09-02 16:58:41 -04:00
Eric Mc Sween
08be54a43e Decaf cleanup: remove unnecessary Array.from() 2020-09-02 16:45:49 -04:00
dependabot[bot]
6b93bbfe09 Bump bl from 4.0.1 to 4.0.3
Bumps [bl](https://github.com/rvagg/bl) from 4.0.1 to 4.0.3.
- [Release notes](https://github.com/rvagg/bl/releases)
- [Commits](https://github.com/rvagg/bl/compare/v4.0.1...v4.0.3)

Signed-off-by: dependabot[bot] <support@github.com>
2020-09-02 16:50:44 +00:00
Jakob Ackermann
a2f5bf463e Merge pull request #190 from overleaf/jpa-socket-io-logger
[misc] socket.io: use a custom logger
2020-09-02 10:46:23 +02:00
Jakob Ackermann
c6f2a3b387 Merge pull request #189 from overleaf/jpa-relevel-log
[misc] re-level expected error log messages
2020-09-02 10:46:08 +02:00
Jakob Ackermann
54c0853aa5 Merge pull request #188 from overleaf/jpa-drop-duplicate-log
[misc] drop duplicate logs
2020-09-02 10:45:57 +02:00
Shane Kilkelly
d284caf1db Merge pull request #82 from overleaf/sk-add-error-to-log
When logging IOException for put, include error
2020-09-02 09:30:36 +01:00
Timothée Alby
d9c435a77a Merge pull request #2957 from overleaf/ew-validate-saml-email
Validate saml email before register

GitOrigin-RevId: 6dcf3bccd280abd7bd3ced2d4fd2f69c590f74c1
2020-09-02 02:05:07 +00:00
Timothée Alby
3d7e6875b2 Merge pull request #3121 from overleaf/ta-outline-remove-survey
[Outline] Replace Survey with Help Article

GitOrigin-RevId: 920a57c053ac7159bd1e83929fc40081bbf2abf9
2020-09-02 02:05:02 +00:00
Miguel Serrano
19a2e40ea9 Merge pull request #3150 from overleaf/revert-3142-msm-pdfjs-2-4
Revert "updated pdfjs to 2.4"

GitOrigin-RevId: 218eb7bebb9be3b0570ae24d24536a4a923d73da
2020-09-02 02:04:57 +00:00
Miguel Serrano
d509b8e3da Merge pull request #3142 from overleaf/msm-pdfjs-2-4
updated pdfjs to 2.4

GitOrigin-RevId: e218d0f355f69c247ef19e34d9cf2e284652f83c
2020-09-02 02:04:52 +00:00
Timothée Alby
5465aef099 Merge pull request #3126 from overleaf/msm-outline-react-style
Update file outline to follow React code style guidelines

GitOrigin-RevId: 8b32e27d20378cbf573d24feb799eb6f99746402
2020-09-02 02:04:47 +00:00
Timothée Alby
1dfdb73a3d Merge pull request #3135 from overleaf/pr-use-character-code-for-vertical-resizer
Use character codes for rendering resizer separators

GitOrigin-RevId: 5687327f0368f005c9ef8b8a14a4b524e47a60bf
2020-09-02 02:04:42 +00:00
Timothée Alby
02d22bef00 Merge pull request #3146 from overleaf/jpa-revert-2938-jpa-simple-sampled-socket-io-error
Revert "[misc] emit 'socket-io-error' event on connection setup errors"

GitOrigin-RevId: 784db67b33c882f2e06a0e0590e2333ed6986918
2020-09-02 02:04:36 +00:00
Timothée Alby
8a327c5692 Merge pull request #3143 from overleaf/jpa-editor-handle-project-not-found
[frontend] ConnectionManager: handle ProjectNotFound err in joinProject

GitOrigin-RevId: 198def9e3e2df223e5cb01e04336074c47df3c33
2020-09-02 02:04:31 +00:00
Timothée Alby
82a0df1fad Merge pull request #3147 from overleaf/jel-sso-email-missing-error
Update default missing SSO email error message

GitOrigin-RevId: 03410a9b5c0f894c236f62148f03cb6243abad7a
2020-09-02 02:04:26 +00:00
Shane Kilkelly
bb7831012b When logging IOException for put, include error 2020-09-01 13:28:35 +01:00
Jakob Ackermann
72282a07df [misc] socket.io: use a custom logger
- forward the previously enabled log messages to our logger-module
- stub the previously disabled logger methods
- drop the log-level config for socket.io
2020-09-01 09:30:11 +01:00
Jakob Ackermann
1d57706d44 [misc] migrate acceptance tests to the native mongo driver, drop mongojs 2020-08-28 17:06:25 +01:00
Jakob Ackermann
f80a92ce46 [misc] migrate the app to the native mongo driver
acceptance tests to follow in a separate commit
2020-08-28 15:12:30 +01:00
Jakob Ackermann
4960bdd6fe [misc] re-level log: 404 from web -> WARN and emit 'project not found'
A stale browser tab tried to join a deleted project.
Emitting 'project not found'/'ProjectNotFound' will trigger a page
 reload in the frontend, upon web can render a 404.
See frontend: ConnectionManager.joinProject callback
2020-08-27 11:51:57 +01:00
Jakob Ackermann
55d938ba14 [misc] add tests for web replying with a 404 for joinProject 2020-08-27 11:51:56 +01:00
Jakob Ackermann
884b340c75 [misc] re-level log: 403 from web goes to WARN and emit 'not authorized'
Users will get redirected to the login page and will see a 'restricted'
 page after logging in again.
See frontend: ConnectionManager.reportConnectionError
2020-08-27 11:51:56 +01:00
Jakob Ackermann
d2a2b9d46e [misc] add tests for web replying with a 403 for joinProject 2020-08-27 11:51:56 +01:00
Jakob Ackermann
1ff9c1e71b [misc] add the rpc-method into the log context in Router._handleError 2020-08-27 11:51:55 +01:00
Jakob Ackermann
0647abf433 [misc] drop info-log in WebApiManager for joinProject being rate-limited
The CodedError is logged at warn-level in Router._handleError.
2020-08-27 11:51:09 +01:00
Jakob Ackermann
2ce7b36c95 [misc] drop duplicate log line for unauthorized applyOtUpdate calls
The violation is logged in Router._handleError.
2020-08-27 10:22:31 +01:00
Jakob Ackermann
dee4749e6d [misc] re-level log: properly silence unauthorized updateClientPosition 2020-08-27 10:11:40 +01:00
Simon Detheridge
4415f77b18 Merge pull request #3140 from overleaf/ho-swallow-deactive-project-err
if deactivateProject errors, continue the deactivateOldProjects jobs

GitOrigin-RevId: b3c2584e0a042cb3c78e609314c320a9b657640c
2020-08-27 02:04:13 +00:00
Simon Detheridge
38cc0488b1 Merge pull request #65 from overleaf/spd-migration-script
Add script to migrate data from S3
2020-08-26 12:58:50 +01:00
Simon Detheridge
f9862081b7 Add script to migrate data from S3 2020-08-26 11:46:40 +01:00