github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-07 20:31:06 -05:00
Code Issues Projects Releases Packages Wiki Activity
20045 commits 3 branches 7 tags 201 MiB
Commit graph

1636 commits

Author SHA1 Message Date
ilkin-overleaf
b0841592c7 Merge pull request #11646 from overleaf/ii-payment-page-payment-preview-panel 
[web] Payment page payment preview panel

GitOrigin-RevId: 35f2e11a9a80e8b240dc8485b8062cf33d5b40b4
 2023-02-09 14:34:18 +00:00
Eric Mc Sween
204e7a0c87 Merge pull request #11719 from overleaf/em-survey-sidebar 
Make survey notification the width of the dashboard sidebar

GitOrigin-RevId: 754ec21692505107e683369628a2b5481e7cef9a
 2023-02-09 09:06:29 +00:00
June Kelly
035b5cd456 Merge pull request #11263 from overleaf/ae-rich-text-available 
Only enable the Rich Text option for supported file extensions

GitOrigin-RevId: ae67435b50701bb5be71bab94d8c3c4da4129d88
 2023-02-09 09:05:05 +00:00
ilkin-overleaf
f6ddb95ae5 Merge pull request #11573 from overleaf/ii-payment-page-migration-three-d-secure 
[web] Payment page migration 3DS

GitOrigin-RevId: b1049882c0f9fd17af2d2974e3f59b01af353c8f
 2023-02-09 09:04:13 +00:00
Thomas
ce79f03b87 Merge pull request #11706 from overleaf/jpa-fix-de-translations 
[web] fix a few German translations

GitOrigin-RevId: a19713144a236e367a28bd443919bd81acbb4656
 2023-02-09 09:03:57 +00:00
M Fahru
49afb315ed Apply new design system style on share modal input (#11415) 
GitOrigin-RevId: b7eb7e1e86786431415d69080a874508de143f22
 2023-02-08 09:07:31 +00:00
M Fahru
5f3ef71e43 Implement 'Add Affiliation' UI on the mobile version of the new react dashboard (#11606) 
* Refactor & change `add-affiliation.tsx` file:
    * Change class from `user-profile` to `add-affiliation`
    * Add new optional `className` props for custom styling

* Show affiliation widget on mobile screen:

* Fix bug on use add affiliation hooks: return type should be `boolean`, not `boolean | 0`

GitOrigin-RevId: 800b951e2a012797266b1780993b4ed9a918d565
 2023-02-08 09:07:23 +00:00
M Fahru
de97ef98c0 Make dropdown menu in welcome page in a center position (react dashboard) 
GitOrigin-RevId: c9c68d41dd00208ddde3400ed04f9fe3425a5613
 2023-02-08 09:07:15 +00:00
M Fahru
3fde2b7207 Remove unnecessary xs={12} props since it's the default 
Co-authored-by: ilkin-overleaf <100852799+ilkin-overleaf@users.noreply.github.com>
GitOrigin-RevId: 1b7139e7a8351da0417ba150cfdeec04441dcfe3
 2023-02-08 09:07:08 +00:00
M Fahru
3ffb7dd7dc Reduce margin on welcome page react version 
GitOrigin-RevId: 40aba2b6cb6b45a6d3d1b23b1d87f4ea8acc805d
 2023-02-08 09:07:00 +00:00
Jessica Lawshe
ccbc0adc06 Merge pull request #11705 from overleaf/jel-free-plan-dash 
[web] Fix displaying free plan React dash

GitOrigin-RevId: 5759ad3489bf43d2a7db57b050fd5cb4aa360140
 2023-02-08 09:06:52 +00:00
Jessica Lawshe
f3d055af86 Merge pull request #11619 from overleaf/jel-react-personal-subscription-dash-change-plan 
[web] Query display price data for change plan UI in React subscription dash

GitOrigin-RevId: e05779d1f289ee55a1b8be17b182905fca66e44f
 2023-02-08 09:06:44 +00:00
Jessica Lawshe
d4057a7bcc Merge pull request #11602 from overleaf/jel-react-personal-subscription-dash-pt-6 
[web] Continue migration of change plan UI to React

GitOrigin-RevId: 4f6176ac101ba3c57134cf5c86329e205f17ab23
 2023-02-08 09:06:37 +00:00
Jessica Lawshe
c7d8e4867d Merge pull request #11560 from overleaf/jel-react-personal-subscription-dash-pt-5 
[web] Continue migration of personal subscription dash to React

GitOrigin-RevId: fb327592ad5031bff20b2a95a83edee4735112e8
 2023-02-08 09:06:29 +00:00
Jessica Lawshe
c36b872ae3 Merge pull request #11509 from overleaf/jel-react-personal-subscription-dash-pt-4 
[web] Continue migration of personal subscription dash to React

GitOrigin-RevId: f2d913099d727725f04697003516c90616faf014
 2023-02-08 09:06:21 +00:00
Jakob Ackermann
ffc9b63ab1 Merge pull request #11676 from overleaf/jpa-faster-access-check 
[web] run all the user-content-domain-access-check probes in parallel

GitOrigin-RevId: 1b5a4756064053639e0dbc899d75ba8c0a5c5557
 2023-02-08 09:06:13 +00:00
Mathias Jakobsen
cd00968699 Merge pull request #11672 from overleaf/ae-noto-weight 
[rich text] Set weight and stretch ranges for Noto Serif

GitOrigin-RevId: 0dc0ad8f7df4f06e191e13f214dcc5d6e0a98955
 2023-02-08 09:05:03 +00:00
ilkin-overleaf
c70fa150b5 Merge pull request #11668 from overleaf/ii-payment-page-migration-add-translations-back 
[web] Add missing translations for checkout payment

GitOrigin-RevId: 8f552587c8d8628f19ae3b44cb79b6a596059f8f
 2023-02-07 09:05:01 +00:00
ilkin-overleaf
7f8d2e37d5 Merge pull request #11530 from overleaf/ii-payment-page-migration-checkout-panel 
[web] Payment page migration checkout panel

GitOrigin-RevId: 04edf9961e0032d6fe3631c255e49dc1d4c3e0ca
 2023-02-07 09:04:53 +00:00
Alf Eaton
85fbded781 Improve the Rich Text toolbar (#11616) 
GitOrigin-RevId: d1999be629ac048058ffd82004865728796a3feb
 2023-02-07 09:04:39 +00:00
Alexandre Bourdin
ed40a87cdc [web] Migrate group management to React (#11293) 
* Rename manage group entry point

* Migrate group management root page to React

* Add cypress tests for the group management react page

* Fix linting

* Add checkbox labels for screen-readers + remove unused classes

* Await on add/remove members calls

* Display the export CSV link for a full group

* Display error message when group is full

* Sort locales

* Handle the managers management page in React version

* Fix missing type in GroupMemberRow

* Split members and managers React pages

* Build API paths on frontend side + add cypress tests for each page

* Fix linting

* Update unit tests

* Review improvements

* Type API errors

GitOrigin-RevId: d124a9d24cbf33de8aacc5d69e9d46e7bcda93c5
 2023-02-07 09:04:18 +00:00
Mathias Jakobsen
9370803f44 [cm6+rt] Decorate preamble and \end{document} (#11598) 
* [cm6+rt] Add preamble decoration

* [cm6+rt] Add end document decoration

* [cm6+rt] Move preamble margin to wrapper padding

* [cm6+rt] Remove info icon from end document decoration

GitOrigin-RevId: 87c08e0c61adfd1cbed36e25fdb97d35ebab9081
 2023-02-06 09:04:56 +00:00
Alf Eaton
73395e008a Fix and run extract-translations (#11622) 
GitOrigin-RevId: b36c70748da800979dbb7f8c11c1b555515cce7b
 2023-02-06 09:04:42 +00:00
Jakob Ackermann
e63b90d288 Merge pull request #11624 from overleaf/jpa-hybrid-download-params 
[web] add split tests for tweaking user content domain access check

GitOrigin-RevId: a5e6959098c10ea230634492b465c2b9dcdd909f
 2023-02-02 18:22:34 +00:00
Jakob Ackermann
635f2969ba Merge pull request #11621 from overleaf/jpa-targeted-access-check 
[web] cut down volume of user content domain access check requests

GitOrigin-RevId: 42011325db9f421e8267c4d0215701dedae652f9
 2023-02-02 18:22:26 +00:00
ilkin-overleaf
db54475bd0 Merge pull request #11525 from overleaf/ii-payment-page-migration-init 
[web] Payment page migration initialisation

GitOrigin-RevId: f33b73a13b96fad3cddf0c0205d05df678ce5300
 2023-02-02 18:21:52 +00:00
M Fahru
1d04aa0315 Editor file uploader design update (#11447) 
* Redesign the styling of conflict state for file upload in the editor

* Change overwrite button style from primary (green) to danger (red)

* Change the idle state and dragging state styling to match the error state new design:

    *remove the double border; only keep the dashed border
    * on idle state, change border color

* Add hardcoded texts to translation file

* Add padding to prevent text is becoming too near to the border when multiple files appear in the conflict file list

* Apply custom file uploader style to smaller screen

GitOrigin-RevId: 266e60bb8575a02c02c1ed1d7fa04cdb101f3dd1
 2023-02-02 09:03:33 +00:00
Miguel Serrano
55bdcf7664 Merge pull request #11583 from overleaf/msm-ace-ce 
[web] Force ACE when `modules/source-editor` not available

GitOrigin-RevId: 2b43a048e882d99aa52ee8ead6c67152d4080eb2
 2023-02-02 09:03:30 +00:00
M Fahru
9795904fac Add nullcheck to tag name to avoid crashing the client (#11519) 
GitOrigin-RevId: 917fcffa672e2626203275ea5e62ce9388366f8e
 2023-02-02 09:03:28 +00:00
M Fahru
772a3efb65 Tear down micro survey for new users (#11569) 
GitOrigin-RevId: b86cfa150dd365f3d1da758feb20509d35c7cc56
 2023-02-02 09:03:22 +00:00
June Kelly
be7b424a63 Merge pull request #11436 from overleaf/jk-increase-password-min-length-to-8 
[web] Increase the minimum password length to 8 characters

GitOrigin-RevId: 94eb3c5605183b5e189babd3342dc308f403ebbd
 2023-02-02 09:02:56 +00:00
Jessica Lawshe
df532c9737 Merge pull request #11494 from overleaf/jel-react-personal-subscription-dash-pt-3 
[web] Continue migration of personal subscription dash to React

GitOrigin-RevId: 412301dad0a04fa6e7b8712ad919c4f67d0bbfe2
 2023-02-01 09:05:35 +00:00
Jessica Lawshe
b7108f7874 Merge pull request #11515 from overleaf/ab-group-membership-dash-react 
[web] Managed groups in React subscription dash

GitOrigin-RevId: 4811d8dd2b42fa9ad83b5c4f12582e7bc04bad40
 2023-02-01 09:05:27 +00:00
Mathias Jakobsen
b42c4e57a7 Merge pull request #11526 from overleaf/mj-ae-selection-changes 
[cm6+rt] Integration of selection changes

GitOrigin-RevId: cd2574ca75eab0f8f1202d3d4b6a009f14fa33b5
 2023-02-01 09:04:57 +00:00
M Fahru
78304e7c94 Add is-screen-width-less-than-768px to the upgrade-button-click event (#11506) 
GitOrigin-RevId: 33ae53d7959863017607d3e1ea237602aed626dc
 2023-01-31 09:04:09 +00:00
M Fahru
3507463c4e Add new event tracking to react and angular version of the empty project page (#11472) 
GitOrigin-RevId: 28ffe919851121bdba82eea3b6ef29cd6fffeb76
 2023-01-31 09:04:01 +00:00
Jakob Ackermann
4eadd92598 Merge pull request #11443 from overleaf/jpa-handle-connection-change 
[web] user-content-domain-access-check: handle connection changes

GitOrigin-RevId: 7858b9e33741fc515dfa96aeba8d0942ce2911a5
 2023-01-30 11:32:16 +00:00
M Fahru
781c1c97c7 Implement new three-way split test for the plans page (#11493) 
* Update split test config and infrastructure for plans-page-layout-v3

* Implement view for `old-plans-page-annual` variant of the new split test:
    - Make `annual` the default view for all elements on the old plans page
    - Change the tooltip background to green for monthly/student view

* Implement a new design for the new plans page:
    - switch annual and monthly locations (annual on the left now)
    - change the tooltip background to green color for all choice
    - make the monthly-annual switch has green background if annual is chosen

* Fix mobile view plans page header style

GitOrigin-RevId: b2b3c6ac6adbe26bf6def7e072493f503793cfcb
 2023-01-30 09:02:45 +00:00
Jessica Lawshe
dad1460d71 Merge pull request #11414 from overleaf/jel-react-personal-subscription-dash-pt-2 
[web] Continue migration of personal subscription dash commons to React

GitOrigin-RevId: 997716f70c953b088f686d4b0f638705ad838520
 2023-01-27 09:05:30 +00:00
Jessica Lawshe
2499ecadcc Merge pull request #11340 from overleaf/jel-react-personal-subscription-dash 
[web] Begin to migrate personal subscription dash commons to React

GitOrigin-RevId: 43c096bd72199c8c0a7b40c8fd84a0a12c108217
 2023-01-27 09:05:22 +00:00
Jessica Lawshe
14039c6729 Merge pull request #11129 from overleaf/jel-survey-link-mobile 
[web] Fix line height for survey text on mobile

GitOrigin-RevId: f96e682b8534d7404c89b45ad4264538bf8a0a2e
 2023-01-27 09:05:14 +00:00
Jakob Ackermann
1f14e08fa1 Merge pull request #11442 from overleaf/jpa-hybrid-pdf-download 
[web] add hybrid download of compile output

GitOrigin-RevId: b9c6dfc86e3af2f7b1728e791f074ec6d5e0badf
 2023-01-27 09:04:12 +00:00
Mathias Jakobsen
83e4a2fab6 [web] Try various file extensions for preview urls (#11467) 
GitOrigin-RevId: 1dd8001c337b10450c83a58b4ab0904867a21250
 2023-01-26 11:39:08 +00:00
Tim Down
fd90261313 Merge pull request #11465 from overleaf/td-remove-ace-tooltip 
Remove info icon next to editor switch for users without Ace option

GitOrigin-RevId: 69fa8af8ddd40c47a58de50eb9aa79cc82629aa8
 2023-01-26 09:04:38 +00:00
Alf Eaton
5c5051d48a Clear performance measures when switching editor modes (#11430) 
GitOrigin-RevId: c1dbfa850e90b94cb5aa1c68fecd784bda099757
 2023-01-25 11:47:14 +00:00
Alf Eaton
640f2cfc8f Move code for loading MathJax v3 into the editor core (#11433) 
GitOrigin-RevId: 14adc6c35d511d6737d0f3b8c0adec00d8a0abb6
 2023-01-25 11:47:06 +00:00
Alf Eaton
adca4980db Read window.MathJax.Hub outside the timeout (#11431) 
GitOrigin-RevId: 6a9f3cd2a7811059b7d1d95b411b37a41cb35b83
 2023-01-25 11:46:58 +00:00
Tim Down
a05438d9c7 Merge pull request #11332 from overleaf/td-remove-ace-split-test 
Add handling for source-editor-legacy split test

GitOrigin-RevId: 9575087c34bc3f2e8b490846984bc97641c560aa
 2023-01-25 09:06:26 +00:00
Alf Eaton
69fe1749ce [rich-text] Improve toolbar button styles (#11419) 
GitOrigin-RevId: 81def8f65591fe9f8f914384db971238faa4483f
 2023-01-25 09:05:26 +00:00
Mathias Jakobsen
f3dac1aa95 [cm6+rt] Move CM6 formatting toolbar to panel (#11395) 
GitOrigin-RevId: 97036c57d63fb7590dda7c98df3347ee83f41ae5
 2023-01-25 09:05:05 +00:00
M Fahru
435be3073f Add new event segmentations for upgrade button in dashboard to help analytics (#11345) 
* Add new event segmentations for the upgrade button in dashboard to help analysis

* Also add an extra check for the upgrade button in the navbar since it's only appeared in the project dashboard react version

GitOrigin-RevId: fca14e3adfbafd0fd143b045ba43588913f7297b
 2023-01-24 09:06:09 +00:00
Alf Eaton
68a3b93eca Merge pull request #11311 from overleaf/jpa-plans-page-tooltip-width 
[web] plans page: allow tooltips to be slightly larger

GitOrigin-RevId: 17bb0c0a1ae6a88efe5e0d2df284bd28f6e5824b
 2023-01-24 09:04:57 +00:00
Alf Eaton
cf8051dcad Advertise CM6 Rich Text in the CM5 track changes panel (#11361) 
GitOrigin-RevId: 3d2e43263528c64292a01afb3d032e11a6cbbfb9
 2023-01-24 09:04:13 +00:00
Alf Eaton
8b610d2d1c Use MathJax v3 on the editor page (#11330) 
GitOrigin-RevId: 5e51404c54e49735988f399ea080b6cb4be726d3
 2023-01-24 09:03:58 +00:00
M Fahru
8227199dcb Implement new users micro survey for project dashboard page on react and non-react version (#11347) 
* Implement new users micro survey for project dashboard page on react and non-react version

* Add 'new-users-micro-survey-click' and 'new-users-micro-survey-prompt' new event for the analytics

GitOrigin-RevId: 9aabe931987638b38995d404aa90ac4d40b2f3b5
 2023-01-20 14:13:53 +00:00
M Fahru
29fbc253fd Clean up link sharing upgrade prompt test and keep the default variant 
GitOrigin-RevId: d34ed081bbc61dfc74a7117c0ba633db4b5a0bad
 2023-01-20 14:13:51 +00:00
Eric Mc Sween
16627a18ef Merge pull request #11325 from overleaf/em-project-upload 
Increase the upload project modal timeout

GitOrigin-RevId: 2c1ba1e792bb778c59c0a8bbadf96a0f84de96f7
 2023-01-20 09:04:34 +00:00
Jessica Lawshe
7075a1e513 Merge pull request #11259 from overleaf/jel-react-subscriptions-dash-free 
[web] Migrate institution free plan subscription dash to React

GitOrigin-RevId: 5f488bdeeb6db4a0895fe99218122220a2ee9561
 2023-01-18 15:09:36 +00:00
Jessica Lawshe
c8ef5e6f65 Merge pull request #11231 from overleaf/jel-react-subscriptions-dash-commons 
[web] Migrate institution memberships dash to React

GitOrigin-RevId: 75bb8e7d7338418733a836a8e654fe5b0a9fceff
 2023-01-18 15:09:28 +00:00
Tim Down
467936e655 Merge pull request #11285 from overleaf/mf-fix-margin-bottom-dashboard 
Add margin bottom to project dashboard search on mobile view

GitOrigin-RevId: e44d567d2848b23cbffc2b0dc487c468e3313bc4
 2023-01-18 15:08:41 +00:00
Miguel Serrano
ed9bd54836 Merge pull request #11308 from overleaf/revert-11289-mj-right-toolbar 
Revert "[web] Change pdf control toolbar alignment for CM6 RT"

GitOrigin-RevId: 71e7941afbdb3e77186760e3d2a0ce3655bdbc1a
 2023-01-18 15:07:50 +00:00
Jakob Ackermann
59e587320a Merge pull request #11246 from overleaf/jpa-user-content-domain-access-check 
[misc] prepare migration to user content domain

GitOrigin-RevId: 581ccab6d39ec021fb44a555a09e55441c35d0d1
 2023-01-18 09:05:14 +00:00
Alf Eaton
f89361c02b Fix sorting for output files in PDF preview (#11267) 
GitOrigin-RevId: 8e8c478c34bf5d58cdb5e44009b918d13ab6a104
 2023-01-18 09:04:44 +00:00
Alf Eaton
a1aa65724a Merge pull request #11289 from overleaf/mj-right-toolbar 
[web] Change pdf control toolbar alignment for CM6 RT

GitOrigin-RevId: c3906df7ebf8da7097c680cdd58fc4bfb3f75704
 2023-01-18 09:04:23 +00:00
Eric Mc Sween
56726053e8 Merge pull request #11158 from overleaf/em-recompile-pdf-split-test 
Recompile PDF split test

GitOrigin-RevId: b02b3fb5b7a979ac299358e276ed432d736c7a03
 2023-01-17 09:06:12 +00:00
Mathias Jakobsen
778aa45e96 Merge pull request #11247 from overleaf/mj-toolbar-overflow 
[cm6+rt] Wrap formatting buttons if editor is too narrow

GitOrigin-RevId: d1b234c721f4bed67f1da567b90139f0c95895f0
 2023-01-17 09:05:27 +00:00
Mathias Jakobsen
f94a325288 Merge pull request #11245 from overleaf/ae-noto-serif-main-style 
Add Noto Serif CSS to "main" style

GitOrigin-RevId: 852220465632233356b27bea93813ef9e41022a1
 2023-01-17 09:05:19 +00:00
Mathias Jakobsen
fce0a45128 Merge pull request #11234 from overleaf/ae-editor-type-rich-text 
Record `cm6-rich-text` editorType in editing session pings

GitOrigin-RevId: 32d8cb60361348123bf5825961eb7e8b6e740ce8
 2023-01-17 09:05:05 +00:00
Brian Gough
95bb5ca4e4 Merge pull request #11002 from overleaf/msm-fix-email-suggestion 
[web] Fix clearing suggestions in email input

GitOrigin-RevId: c821114e2112bf066f4ee5f01304321db983bc4e
 2023-01-17 09:04:43 +00:00
Jakob Ackermann
6154db8f92 Merge pull request #11236 from overleaf/jpa-pdf-caching-fix-size-estimation 
[web] pdf-caching: fix estimation of multipart response size

GitOrigin-RevId: 5929cc1e413befb3f931889b38a4b21a7ed4cea8
 2023-01-17 09:04:05 +00:00
Alf Eaton
ac61596274 Convert Noto Serif fonts to WOFF2 (#11205) 
GitOrigin-RevId: 2564a03b12e01ccda84004c189c0b2e6a9a5b7fa
 2023-01-16 08:42:04 +00:00
M Fahru
86be2afdf1 Remove unused variable declaration on light theme css file 
GitOrigin-RevId: bb838b9c3e7dac72e977ab99c130db917afc5e20
 2023-01-13 09:05:28 +00:00
M Fahru
221bddce42 Remove unused css variable on the old less file 
GitOrigin-RevId: cdb40060540d9173dd11f1653fd8e62b8232dcef
 2023-01-13 09:05:21 +00:00
M Fahru
19e1d50e2e Fix editor overleaf logo on editor disappears if menu button is pressed in light theme 
GitOrigin-RevId: a4f104cf988bfc267ba70cbe546e150bea773691
 2023-01-13 09:05:07 +00:00
M Fahru
e855b96953 Only disable closing the modal by clicking outside of its element when inflight 
GitOrigin-RevId: 9e9f24aed6442a892ed95c1ee598fc82ec931a1b
 2023-01-13 09:05:00 +00:00
ilkin-overleaf
7e68b4f0d5 Merge pull request #11147 from overleaf/ii-subscriptions-pages-react-split-test 
[web] React subscription split test

GitOrigin-RevId: 6656b3895030bc677483a3e30d5e998f5f7d1458
 2023-01-13 09:04:52 +00:00
Alf Eaton
017f0b49a0 [rich-text] Add "rich-text" split test (#11180) 
GitOrigin-RevId: 8df79f3c70020c8dba0793c8b548fd1f1e1fbf76
 2023-01-13 09:04:31 +00:00
Jessica Lawshe
fe34b650e3 Merge pull request #11132 from overleaf/jel-btn-info 
[web] Use new button style for download button in file view in editor

GitOrigin-RevId: 33e8c1aeb21a6ba083a5b9ada3d3135916e64e26
 2023-01-12 09:03:43 +00:00
Jessica Lawshe
1e27f5a49e Merge pull request #11130 from overleaf/jel-css-cleanup 
[web] Remove unused `theme.less` file

GitOrigin-RevId: 241bb43e8d10ac8084189e34bfdf7dabcb6138d5
 2023-01-12 09:03:40 +00:00
Alf Eaton
dbef19d0d6 Improve Rich Text typography (#11157) 
* Replace @fontsource/noto-serif with local Noto Serif fonts
* Make more use of CSS variables in theme
* Make sure the chosen font is used for monospace
* Increase the weight of section headings
* Set link colours
* Rename variable to --source-font-family

GitOrigin-RevId: e14856a619829e075e71bf2df9b799fe0b45acea
 2023-01-12 09:03:19 +00:00
M Fahru
82cd2d2a77 perform null check on the old value instead of the new one since to follow the non-react version behaviour 
GitOrigin-RevId: 33ef74e1b1da41db8a86fc79ae04fbe49ed194df
 2023-01-11 09:10:00 +00:00
M Fahru
94ab78b427 Log error in a promise catch block 
GitOrigin-RevId: 09756d52bd6351c55051a74f22f38c450af9a275
 2023-01-11 09:09:51 +00:00
M Fahru
7475237170 Refactor project-wide settings: 
- Change api function argument (readability)
- create a new wrapper hooks for saving the project to both server-side and angular scope
- Implement the new save project settings hooks on project-wide settings update
- On spell check language update function, add new comment to give more context about the decision

GitOrigin-RevId: 93d558d1e1d4db265a943eeb4366842430900c43
 2023-01-11 09:09:40 +00:00
M Fahru
654144dd40 Refactor saveUserSettings: Move sendMB inside the function and change function from supporting multiple settings to only support single key/value pair. 
GitOrigin-RevId: 77b9d8fd5cdcbc78f38fd42329b74cf592615638
 2023-01-11 09:09:32 +00:00
M Fahru
4444377b11 fix tsc error by re-creating request body object instead of directly assigning it from function argument 
GitOrigin-RevId: b17697c7b52c991a06efcbffa0227b6021c5bc8d
 2023-01-11 09:09:25 +00:00
M Fahru
b2cf833e9d Remove scope suffix from variable name in react-related files since it's an angular-specific concept 
GitOrigin-RevId: b8eea8c8113a977f6cbe07649e1338eea8281841
 2023-01-11 09:09:18 +00:00
M Fahru
03e5614969 Remove _csrf in request body since fetchJSON already have X-Csrf-Token set in request header 
GitOrigin-RevId: 9dd2389c47ce3537fc4bb22bd8b6b0b83862c5f4
 2023-01-11 09:09:11 +00:00
M Fahru
4548f504f7 standardize the naming for rootDocId. 
- Remove the `scope` variable suffix
- change `rootDoc_id` to `rootDocId`

GitOrigin-RevId: d8e646ef5f99ba0dbce84ff63c588e63b956a4ec
 2023-01-11 09:09:04 +00:00
M Fahru
bdf3b18d4f Change import to import type for type imports 
GitOrigin-RevId: 2061bafeca58d063f83a96650403e5741b863c05
 2023-01-11 09:08:57 +00:00
M Fahru
608b75c9db Fix linter error because of wrong variable name and camel case issue 
GitOrigin-RevId: a5ea8d6c8332133303fcd8e410cc76ac06c5bb97
 2023-01-11 09:08:49 +00:00
M Fahru
e3d0380e6f Remove multiple source of type imports; add type on type imports. 
GitOrigin-RevId: a6630bb284c456bfbe61901f7331cdd3c13c7f8b
 2023-01-11 09:08:42 +00:00
M Fahru
12f5c845b4 Simplify function by removing generic 
GitOrigin-RevId: 7732b6782cd1e0130eb56f6b674c03548b8e8315
 2023-01-11 09:08:35 +00:00
M Fahru
10bb724197 Fix wrong hook name 
GitOrigin-RevId: 58f98b508cf650a6ecab38772faf9ecd38c9a7bc
 2023-01-11 09:08:28 +00:00
M Fahru
f2060b35ad Refactor type by reusing type declaration and avoid multiple source of the same type 
GitOrigin-RevId: 492a9a524e566cf70b53158b4e5cc6ad57cb6093
 2023-01-11 09:08:21 +00:00
M Fahru
f85d17f894 Remove disabling update while listening on socket (ignoreUpdates state) since the logic is more complicated that was originally thought and it will be tested/revisited on a different PR 
GitOrigin-RevId: 70cee2f0fc565aaebfb3ead2dd1a58fc5371c816
 2023-01-11 09:08:13 +00:00
M Fahru
677ec173ed Disable updating project-wide settings while socket is currently listening to update project-wide settings in a project. 
This may happen if the project is being used by multiple people, and we want to avoid race condition on the update since it's possible for multiple people to update setting value at the same time.

GitOrigin-RevId: cdad6a6456e2d9e4ef1812ebfd6f6ef59f23747f
 2023-01-11 09:08:06 +00:00
M Fahru
af01ace5a0 refactor function by simplifying function argument (from two arguments to a single object) 
GitOrigin-RevId: e4244a07a4ca196afa226e3fac9de74d30f7d4ea
 2023-01-11 09:07:59 +00:00
M Fahru
777beaadc3 Don't send spellCheckLanguage request if the old value is the same as the new one 
GitOrigin-RevId: 4ef34be7563ff707b6abd44dc8034293c88d2f72
 2023-01-11 09:07:52 +00:00
M Fahru
ae5a08e680 Add 'setting-changed' tracking when user changes user-wide settings 
GitOrigin-RevId: 04ed66dcdff7fa04e783fe4028505d981a39b37b
 2023-01-11 09:07:45 +00:00
M Fahru
85cbc5b721 Apply prettier 
GitOrigin-RevId: 34c7e3b95d061c270c77337c7c82502af289b556
 2023-01-11 09:07:38 +00:00