mirror of
https://github.com/overleaf/overleaf.git
synced 2024-11-21 20:47:08 -05:00
[CompileController] emit status=failure for an empty output.pdf file
This commit is contained in:
parent
fb3966ef35
commit
ffaff1bd72
2 changed files with 44 additions and 1 deletions
|
@ -88,7 +88,7 @@ module.exports = CompileController = {
|
|||
let file
|
||||
status = 'failure'
|
||||
for (file of Array.from(outputFiles)) {
|
||||
if (file.path === 'output.pdf') {
|
||||
if (file.path === 'output.pdf' && file.size > 0) {
|
||||
status = 'success'
|
||||
}
|
||||
}
|
||||
|
|
|
@ -99,6 +99,7 @@ describe('CompileController', function () {
|
|||
{
|
||||
path: 'output.pdf',
|
||||
type: 'pdf',
|
||||
size: 1337,
|
||||
build: 1234
|
||||
},
|
||||
{
|
||||
|
@ -207,6 +208,48 @@ describe('CompileController', function () {
|
|||
})
|
||||
})
|
||||
|
||||
describe('with an empty output.pdf', function () {
|
||||
beforeEach(function () {
|
||||
this.output_files = [
|
||||
{
|
||||
path: 'output.pdf',
|
||||
type: 'pdf',
|
||||
size: 0,
|
||||
build: 1234
|
||||
},
|
||||
{
|
||||
path: 'output.log',
|
||||
type: 'log',
|
||||
build: 1234
|
||||
}
|
||||
]
|
||||
this.CompileManager.doCompileWithLock = sinon
|
||||
.stub()
|
||||
.yields(null, this.output_files, this.stats, this.timings)
|
||||
this.CompileController.compile(this.req, this.res)
|
||||
})
|
||||
|
||||
it('should return the JSON response with status failure', function () {
|
||||
this.res.status.calledWith(200).should.equal(true)
|
||||
this.res.send
|
||||
.calledWith({
|
||||
compile: {
|
||||
status: 'failure',
|
||||
error: null,
|
||||
stats: this.stats,
|
||||
timings: this.timings,
|
||||
outputFiles: this.output_files.map((file) => {
|
||||
return {
|
||||
url: `${this.Settings.apis.clsi.url}/project/${this.project_id}/build/${file.build}/output/${file.path}`,
|
||||
...file
|
||||
}
|
||||
})
|
||||
}
|
||||
})
|
||||
.should.equal(true)
|
||||
})
|
||||
})
|
||||
|
||||
describe('with an error', function () {
|
||||
beforeEach(function () {
|
||||
this.CompileManager.doCompileWithLock = sinon
|
||||
|
|
Loading…
Reference in a new issue