github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Use map instead of hash for metrics

Browse source
This commit is contained in:
Simon Detheridge 2019-10-28 12:40:12 +00:00
parent e0cf10a886
commit feecda8ea8
1 changed files with 13 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
libraries/metrics/prom_wrapper.coffee
View file

@ -1,6 +1,6 @@
prom = require('prom-client') prom = require('prom-client')
registry = require('prom-client').register registry = require('prom-client').register
metrics = {} metrics = new Map()
optsKey = (opts) -> optsKey = (opts) ->
@ -33,16 +33,16 @@ PromWrapper =
registry: registry registry: registry
metric: (type, name) -> metric: (type, name) ->
registry.getSingleMetric(name) || new MetricWrapper(type, name) metrics.get(name) || new MetricWrapper(type, name)
collectDefaultMetrics: prom.collectDefaultMetrics collectDefaultMetrics: prom.collectDefaultMetrics
class MetricWrapper class MetricWrapper
constructor: (type, name) -> constructor: (type, name) ->
metrics[name] = this metrics.set(name, this)
@name = name @name = name
@instances = {} @instances = new Map()
@lastAccess = new Date() @lastAccess = new Date()
@metric = switch type @metric = switch type
when "counter" when "counter"
@ -77,22 +77,22 @@ class MetricWrapper
sweep: () -> sweep: () ->
thresh = new Date(Date.now() - 1000 * 60 * PromWrapper.ttlInMinutes) thresh = new Date(Date.now() - 1000 * 60 * PromWrapper.ttlInMinutes)
for key in Object.keys(@instances) @instances.forEach (instance, key) =>
if thresh > @instances[key].time if thresh > instance.time
if process.env['DEBUG_METRICS'] if process.env['DEBUG_METRICS']
console.log("Sweeping stale metric instance", @name, opts: @instances[key].opts, key) console.log("Sweeping stale metric instance", @name, opts: instance.opts, key)
@metric.remove(optsAsArgs(@instances[key].opts, @metric.labelNames)...) @metric.remove(optsAsArgs(instance.opts, @metric.labelNames)...)
if thresh > @lastAccess if thresh > @lastAccess
if process.env['DEBUG_METRICS'] if process.env['DEBUG_METRICS']
console.log("Sweeping stale metric", @name) console.log("Sweeping stale metric", @name, thresh, @lastAccess)
delete metrics[@name] metrics.delete(@name)
registry.removeSingleMetric(@name) registry.removeSingleMetric(@name)
_execMethod: (method, opts, value) -> _execMethod: (method, opts, value) ->
opts = extendOpts(opts, @metric.labelNames) opts = extendOpts(opts, @metric.labelNames)
key = optsKey(opts) key = optsKey(opts)
@instances[key] = { time: new Date(), opts } unless key == '' @instances.set(key, { time: new Date(), opts }) unless key == ''
@lastAccess = new Date() @lastAccess = new Date()
@metric[method](opts, value) @metric[method](opts, value)
@ -106,8 +106,8 @@ unless PromWrapper.sweepRegistered
if PromWrapper.ttlInMinutes if PromWrapper.ttlInMinutes
if process.env['DEBUG_METRICS'] if process.env['DEBUG_METRICS']
console.log("Sweeping metrics") console.log("Sweeping metrics")
for key in Object.keys(metrics) metrics.forEach (metric, key) =>
metrics[key].sweep() metric.sweep()
60000) 60000)