github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-10-31 21:21:03 -04:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #31 from sharelatex/bg-prevent-logging-of-oprangenotavailable-to-sentry

Browse source 
Reduce logging to sentry (connects to #30)
This commit is contained in:
Brian Gough 2018-04-30 08:57:48 +01:00 committed by GitHub
commit fd80218e51
1 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
services/document-updater/app/coffee/DispatchManager.coffee
View file

@ -2,6 +2,7 @@ Settings = require('settings-sharelatex')
logger = require('logger-sharelatex') logger = require('logger-sharelatex')
Keys = require('./UpdateKeys') Keys = require('./UpdateKeys')
redis = require("redis-sharelatex") redis = require("redis-sharelatex")
Errors = require("./Errors")
UpdateManager = require('./UpdateManager') UpdateManager = require('./UpdateManager')
Metrics = require('./Metrics') Metrics = require('./Metrics')
@ -23,7 +24,14 @@ module.exports = DispatchManager =
# Dispatch this in the background # Dispatch this in the background
backgroundTask = (cb) -> backgroundTask = (cb) ->
UpdateManager.processOutstandingUpdatesWithLock project_id, doc_id, (error) -> UpdateManager.processOutstandingUpdatesWithLock project_id, doc_id, (error) ->
logger.error err: error, project_id: project_id, doc_id: doc_id, "error processing update" if error? # log everything except OpRangeNotAvailable errors, these are normal
if error?
# downgrade OpRangeNotAvailable and "Delete component" errors so they are not sent to sentry
logAsWarning = (error instanceof Errors.OpRangeNotAvailableError) || error.message?.match(/^Delete component/)
if logAsWarning
logger.warn err: error, project_id: project_id, doc_id: doc_id, "error processing update"
else
logger.error err: error, project_id: project_id, doc_id: doc_id, "error processing update"
cb() cb()
RateLimiter.run backgroundTask, callback RateLimiter.run backgroundTask, callback