github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #18994 from overleaf/jpa-sandboxed-compiles-logs

Browse source 
[server-pro] migrate comments to cy.log for sandboxed-compiles tests

GitOrigin-RevId: 2e66089b43c2f37af6e3cd56273df2b3c976a407
This commit is contained in:
Jakob Ackermann 2024-06-19 17:46:53 +02:00 committed by Copybot
parent 548f16e334
commit f9846699cb
2 changed files with 17 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
server-ce/test/helpers/compile.ts
View file

@ -14,6 +14,7 @@ export function throttledRecompile() {
queueReset() queueReset()
return () => return () =>
cy.then(() => { cy.then(() => {
cy.log('Recompile without hitting rate-limit')
const msSinceLastCompile = Date.now() - lastCompile const msSinceLastCompile = Date.now() - lastCompile
cy.wait(Math.max(0, 1_000 - msSinceLastCompile)) cy.wait(Math.max(0, 1_000 - msSinceLastCompile))
cy.findByText('Recompile').click() cy.findByText('Recompile').click()

23
server-ce/test/sandboxed-compiles.spec.ts
View file

@ -5,6 +5,8 @@ import { throttledRecompile } from './helpers/compile'
import { v4 as uuid } from 'uuid' import { v4 as uuid } from 'uuid'
import { waitUntilScrollingFinished } from './helpers/waitUntilScrollingFinished' import { waitUntilScrollingFinished } from './helpers/waitUntilScrollingFinished'
const LABEL_TEX_LIVE_VERSION = 'TeX Live version'
describe('SandboxedCompiles', function () { describe('SandboxedCompiles', function () {
ensureUserExists({ email: 'user@example.com' }) ensureUserExists({ email: 'user@example.com' })
@ -28,23 +30,26 @@ describe('SandboxedCompiles', function () {
cy.visit('/project') cy.visit('/project')
createProject('sandboxed') createProject('sandboxed')
const recompile = throttledRecompile() const recompile = throttledRecompile()
// check produced PDF cy.log('wait for compile')
cy.get('.pdf-viewer').should('contain.text', 'sandboxed') cy.get('.pdf-viewer').should('contain.text', 'sandboxed')
cy.log('Check which compiler version was used, expect 2023')
cy.get('[aria-label="View logs"]').click() cy.get('[aria-label="View logs"]').click()
cy.findByText(/This is pdfTeX, Version .+ \(TeX Live 2023\) /) cy.findByText(/This is pdfTeX, Version .+ \(TeX Live 2023\) /)
cy.log('Switch TeXLive version from 2023 to 2022')
cy.get('header').findByText('Menu').click() cy.get('header').findByText('Menu').click()
cy.findByText('TeX Live version') cy.findByText(LABEL_TEX_LIVE_VERSION)
.parent() .parent()
.findByText('2023') .findByText('2023')
.parent() .parent()
.select('2022') .select('2022')
// close editor menu
cy.get('#left-menu-modal').click() cy.get('#left-menu-modal').click()
// Trigger compile with other TexLive version cy.log('Trigger compile with other TeX Live version')
recompile() recompile()
cy.log('Check which compiler version was used, expect 2022')
cy.get('[aria-label="View logs"]').click() cy.get('[aria-label="View logs"]').click()
cy.findByText(/This is pdfTeX, Version .+ \(TeX Live 2022\) /) cy.findByText(/This is pdfTeX, Version .+ \(TeX Live 2022\) /)
}) })
@ -189,13 +194,17 @@ describe('SandboxedCompiles', function () {
it('should not offer TexLive images and use default compiler', () => { it('should not offer TexLive images and use default compiler', () => {
cy.visit('/project') cy.visit('/project')
createProject('sandboxed') createProject('sandboxed')
// check produced PDF cy.log('wait for compile')
cy.get('.pdf-viewer').should('contain.text', 'sandboxed') cy.get('.pdf-viewer').should('contain.text', 'sandboxed')
cy.log('Check which compiler version was used, expect 2024')
cy.get('[aria-label="View logs"]').click() cy.get('[aria-label="View logs"]').click()
cy.findByText(/This is pdfTeX, Version .+ \(TeX Live 2024\) /) cy.findByText(/This is pdfTeX, Version .+ \(TeX Live 2024\) /)
cy.log('Check that there is no TeX Live version toggle')
cy.get('header').findByText('Menu').click() cy.get('header').findByText('Menu').click()
cy.findByText('Word Count') // wait for lazy loading cy.findByText('Word Count') // wait for lazy loading
cy.findByText('TeX Live version').should('not.exist') cy.findByText(LABEL_TEX_LIVE_VERSION).should('not.exist')
}) })
} }