diff --git a/services/real-time/app/js/Router.js b/services/real-time/app/js/Router.js index 1442903902..a381cd8015 100644 --- a/services/real-time/app/js/Router.js +++ b/services/real-time/app/js/Router.js @@ -13,17 +13,6 @@ const base64id = require('base64id') const { UnexpectedArgumentsError } = require('./Errors') const Joi = require('@hapi/joi') -const basicAuth = require('basic-auth-connect') -const httpAuth = basicAuth(function (user, pass) { - const isValid = - user === settings.internal.realTime.user && - pass === settings.internal.realTime.pass - if (!isValid) { - logger.err({ user, pass }, 'invalid login details') - } - return isValid -}) - const HOSTNAME = require('os').hostname() const JOI_OBJECT_ID = Joi.string() @@ -122,15 +111,13 @@ module.exports = Router = { app.post( '/project/:project_id/message/:message', - httpAuth, bodyParser.json({ limit: '5mb' }), HttpApiController.sendMessage ) - app.post('/drain', httpAuth, HttpApiController.startDrain) + app.post('/drain', HttpApiController.startDrain) app.post( '/client/:client_id/disconnect', - httpAuth, HttpApiController.disconnectClient ) diff --git a/services/real-time/config/settings.defaults.js b/services/real-time/config/settings.defaults.js index 1f8e45ad2e..64ce54db4a 100644 --- a/services/real-time/config/settings.defaults.js +++ b/services/real-time/config/settings.defaults.js @@ -81,8 +81,6 @@ const settings = { realTime: { port: 3026, host: process.env.LISTEN_ADDRESS || 'localhost', - user: 'sharelatex', - pass: 'password', }, }, diff --git a/services/real-time/package-lock.json b/services/real-time/package-lock.json index 6343436ba5..c99f27667f 100644 --- a/services/real-time/package-lock.json +++ b/services/real-time/package-lock.json @@ -695,11 +695,6 @@ "resolved": "https://registry.npmjs.org/base64id/-/base64id-0.1.0.tgz", "integrity": "sha512-DSjtfjhAsHl9J4OJj7e4+toV2zqxJrGwVd3CLlsCp8QmicvOn7irG0Mb8brOc/nur3SdO8lIbNlY1s1ZDJdUKQ==" }, - "basic-auth-connect": { - "version": "1.0.0", - "resolved": "https://registry.npmjs.org/basic-auth-connect/-/basic-auth-connect-1.0.0.tgz", - "integrity": "sha512-kiV+/DTgVro4aZifY/hwRwALBISViL5NP4aReaR2EVJEObpbUBHIkdJh/YpcoEiYt7nBodZ6U2ajZeZvSxUCCg==" - }, "bcrypt-pbkdf": { "version": "1.0.2", "resolved": "https://registry.npmjs.org/bcrypt-pbkdf/-/bcrypt-pbkdf-1.0.2.tgz", diff --git a/services/real-time/package.json b/services/real-time/package.json index 77fa2950ec..65eb273830 100644 --- a/services/real-time/package.json +++ b/services/real-time/package.json @@ -30,7 +30,6 @@ "@overleaf/settings": "^2.1.1", "async": "^0.9.0", "base64id": "0.1.0", - "basic-auth-connect": "^1.0.0", "body-parser": "^1.19.0", "bunyan": "^1.8.15", "connect-redis": "^2.1.0", diff --git a/services/real-time/test/acceptance/js/DrainManagerTests.js b/services/real-time/test/acceptance/js/DrainManagerTests.js index 0f4d67fb3d..499ddc3291 100644 --- a/services/real-time/test/acceptance/js/DrainManagerTests.js +++ b/services/real-time/test/acceptance/js/DrainManagerTests.js @@ -16,16 +16,10 @@ const { expect } = require('chai') const async = require('async') const request = require('request') -const Settings = require('@overleaf/settings') - const drain = function (rate, callback) { request.post( { url: `http://localhost:3026/drain?rate=${rate}`, - auth: { - user: Settings.internal.realTime.user, - pass: Settings.internal.realTime.pass, - }, }, (error, response, data) => callback(error, data) ) diff --git a/services/real-time/test/acceptance/js/helpers/RealTimeClient.js b/services/real-time/test/acceptance/js/helpers/RealTimeClient.js index 0e1a2b61fa..40f2aa6039 100644 --- a/services/real-time/test/acceptance/js/helpers/RealTimeClient.js +++ b/services/real-time/test/acceptance/js/helpers/RealTimeClient.js @@ -104,10 +104,6 @@ module.exports = Client = { request.post( { url: `http://localhost:3026/client/${client_id}/disconnect`, - auth: { - user: Settings.internal.realTime.user, - pass: Settings.internal.realTime.pass, - }, }, (error, response, data) => callback(error, data) )