github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #730 from sharelatex/sk-handle-orphaned-mendeley-linked-files

Browse source 
Add a new error type to LinkedFiles: FileCannotRefreshError
This commit is contained in:
James Allen 2018-07-06 11:06:51 +01:00 committed by GitHub
commit f5ea7f2d77
2 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
services/web/app/coffee/Features/LinkedFiles/LinkedFilesController.coffee
View file

@ -17,7 +17,8 @@ LinkedFilesHandler = require './LinkedFilesHandler'
SourceFileNotFoundError,
NotOriginalImporterError,
FeatureNotAvailableError,
RemoteServiceError
RemoteServiceError,
FileCannotRefreshError
} = require './LinkedFilesErrors'
Modules = require '../../infrastructure/Modules'
@ -138,6 +139,10 @@ module.exports = LinkedFilesController = {
"The remote service produced an error"
)
else if error instanceof FileCannotRefreshError
res.status(400).send(
"This file cannot be refreshed"
)
else
next(error)

11
services/web/app/coffee/Features/LinkedFiles/LinkedFilesErrors.coffee
View file

@ -94,6 +94,14 @@ RemoteServiceError = (message) ->
RemoteServiceError.prototype.__proto__ = Error.prototype
FileCannotRefreshError = (message) ->
error = new Error(message)
error.name = 'RemoteService'
error.__proto__ = FileCannotRefreshError.prototype
return error
FileCannotRefreshError.prototype.__proto__ = Error.prototype
module.exports = {
UrlFetchFailedError,
@ -107,5 +115,6 @@ module.exports = {
SourceFileNotFoundError,
NotOriginalImporterError,
FeatureNotAvailableError,
RemoteServiceError
RemoteServiceError,
FileCannotRefreshError
}