github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #15088 from overleaf/tm-fix-writefull-analytics

Browse source 
Fix writefull logic so promo-prompt is not sent if not shown

GitOrigin-RevId: c08ae63c269ee30aaf4c831fdf46d170df3d45f3
This commit is contained in:
Thomas 2023-10-04 15:30:47 +02:00 committed by Copybot
parent 872904d73e
commit f1f6007cbc
1 changed files with 9 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
services/web/frontend/js/features/project-list/components/notifications/user-notifications.tsx
View file

@ -50,7 +50,7 @@ function UserNotifications() {
// Temporary workaround to prevent also showing groups/enterprise banner
const [showWritefull, setShowWritefull] = useState(() => {
if (isChromium()) {
if (isChromium() && !showBackToSchoolModal) {
const show =
getMeta('ol-showWritefullPromoBanner') &&
!customLocalStorage.getItem('has_dismissed_writefull_promo_banner')
@ -93,9 +93,7 @@ function UserNotifications() {
splitTestName={inrGeoBannerSplitTestName}
/>
) : null}
{showBackToSchoolModal ? (
<BackToSchoolModal />
) : (
{showBackToSchoolModal && <BackToSchoolModal />}
<WritefullPromoBanner
show={showWritefull}
setShow={setShowWritefull}
@ -103,7 +101,6 @@ function UserNotifications() {
setDismissedWritefull(true)
}}
/>
)}
</ul>
</div>
)