github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-21 20:47:08 -05:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #21120 from overleaf/dp-overview-entry-gap

Browse source 
Adjust size of gap between review panel entries to 4px

GitOrigin-RevId: a09a6fde0e8eb15e0c753e436a1c09434581d6d8
This commit is contained in:
David 2024-10-21 09:54:49 +01:00 committed by Copybot
parent af7e388c41
commit efa376f4f4
3 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
services/web/frontend/js/features/review-panel-new/utils/position-items.ts
View file

@ -2,6 +2,7 @@ import { debounce } from 'lodash'
const COLLAPSED_HEADER_HEIGHT = 75 const COLLAPSED_HEADER_HEIGHT = 75
const OFFSET_FOR_ENTRIES_ABOVE = 70 const OFFSET_FOR_ENTRIES_ABOVE = 70
const GAP_BETWEEN_ENTRIES = 4
export const positionItems = debounce( export const positionItems = debounce(
( (
@ -62,7 +63,7 @@ export const positionItems = debounce(
let top = getTopPosition(item, i === 0) let top = getTopPosition(item, i === 0)
const bottom = top + rect.height const bottom = top + rect.height
if (bottom > topLimit) { if (bottom > topLimit) {
top = topLimit - rect.height - 10 top = topLimit - rect.height - GAP_BETWEEN_ENTRIES
} }
item.style.top = `${top}px` item.style.top = `${top}px`
item.style.visibility = 'visible' item.style.visibility = 'visible'
@ -76,7 +77,7 @@ export const positionItems = debounce(
const rect = item.getBoundingClientRect() const rect = item.getBoundingClientRect()
let top = getTopPosition(item, false) let top = getTopPosition(item, false)
if (top < bottomLimit) { if (top < bottomLimit) {
top = bottomLimit + 10 top = bottomLimit + GAP_BETWEEN_ENTRIES
} }
item.style.top = `${top}px` item.style.top = `${top}px`
item.style.visibility = 'visible' item.style.visibility = 'visible'

3
services/web/frontend/stylesheets/app/editor/review-panel-new.less
View file

@ -448,6 +448,9 @@
} }
.review-panel-overview-file-entries { .review-panel-overview-file-entries {
display: flex;
flex-direction: column;
gap: 4px;
overflow: hidden; overflow: hidden;
padding-top: 4px; padding-top: 4px;
padding-bottom: 6px; padding-bottom: 6px;

3
services/web/frontend/stylesheets/bootstrap-5/pages/editor/review-panel-new.scss
View file

@ -461,6 +461,9 @@
} }
.review-panel-overview-file-entries { .review-panel-overview-file-entries {
display: flex;
flex-direction: column;
gap: var(--spacing-02);
overflow: hidden; overflow: hidden;
padding-top: var(--spacing-02); padding-top: var(--spacing-02);
padding-bottom: var(--spacing-03); padding-bottom: var(--spacing-03);