From ef1aab1c27beba0c8ec146103449319ff0da0f90 Mon Sep 17 00:00:00 2001 From: Paulo Reis Date: Tue, 4 Oct 2016 14:42:01 +0100 Subject: [PATCH] Track header AB conversions only on click events. --- services/web/app/views/project/editor/header.jade | 11 +---------- services/web/public/coffee/ide.coffee | 2 +- 2 files changed, 2 insertions(+), 11 deletions(-) diff --git a/services/web/app/views/project/editor/header.jade b/services/web/app/views/project/editor/header.jade index 2dd84db21d..db691265b6 100644 --- a/services/web/app/views/project/editor/header.jade +++ b/services/web/app/views/project/editor/header.jade @@ -96,14 +96,12 @@ div(ng-if="!shouldABTestHeaderLabels") ng-if="permissions.admin", tooltip="#{translate('share')}", tooltip-placement="bottom", - ng-mouseenter="trackHover('share')" ng-click="openShareProjectModal()", ng-controller="ShareController", ) i.fa.fa-fw.fa-group a.btn.btn-full-height( href, - ng-mouseenter="trackHover('track-changes')" ng-click="toggleTrackChanges()", ng-class="{ active: (ui.view == 'track-changes') }" tooltip="#{translate('recent_changes')}", @@ -115,7 +113,6 @@ div(ng-if="!shouldABTestHeaderLabels") tooltip="#{translate('chat')}", tooltip-placement="bottom", ng-class="{ active: ui.chatOpen }", - ng-mouseenter="trackHover('chat')" ng-click="toggleChat()", ng-controller="ChatButtonController", ng-show="!anonymous", @@ -228,7 +225,6 @@ div(ng-if="shouldABTestHeaderLabels") ng-if="permissions.admin", tooltip="#{translate('share')}", tooltip-placement="bottom", - ng-mouseenter="trackHover('share')" ng-click="openShareProjectModal(); trackABTestConversion('share');", ng-controller="ShareController", sixpack-convert="editor-header" @@ -236,7 +232,6 @@ div(ng-if="shouldABTestHeaderLabels") i.fa.fa-fw.fa-group a.btn.btn-full-height( href, - ng-mouseenter="trackHover('track-changes')" ng-click="toggleTrackChanges(); trackABTestConversion('history');", ng-class="{ active: (ui.view == 'track-changes') }" tooltip="#{translate('recent_changes')}", @@ -249,7 +244,6 @@ div(ng-if="shouldABTestHeaderLabels") tooltip="#{translate('chat')}", tooltip-placement="bottom", ng-class="{ active: ui.chatOpen }", - ng-mouseenter="trackHover('chat')" ng-click="toggleChat(); trackABTestConversion('chat');", ng-controller="ChatButtonController", ng-show="!anonymous", @@ -355,8 +349,7 @@ div(ng-if="shouldABTestHeaderLabels") a.btn.btn-full-height( href, ng-if="permissions.admin", - ng-mouseenter="trackHover('share'); trackABTestConversion('share');" - ng-click="openShareProjectModal()", + ng-click="openShareProjectModal(); trackABTestConversion('share');", ng-controller="ShareController", sixpack-convert="editor-header" ) @@ -364,7 +357,6 @@ div(ng-if="shouldABTestHeaderLabels") p.toolbar-label #{translate("share")} a.btn.btn-full-height( href, - ng-mouseenter="trackHover('track-changes')" ng-click="toggleTrackChanges(); trackABTestConversion('history');", ng-class="{ active: (ui.view == 'track-changes') }", sixpack-convert="editor-header" @@ -374,7 +366,6 @@ div(ng-if="shouldABTestHeaderLabels") a.btn.btn-full-height( href, ng-class="{ active: ui.chatOpen }", - ng-mouseenter="trackHover('chat')" ng-click="toggleChat(); trackABTestConversion('chat');", ng-controller="ChatButtonController", ng-show="!anonymous", diff --git a/services/web/public/coffee/ide.coffee b/services/web/public/coffee/ide.coffee index 5c8c90c39d..01f7363c80 100644 --- a/services/web/public/coffee/ide.coffee +++ b/services/web/public/coffee/ide.coffee @@ -84,7 +84,7 @@ define [ $scope.headerLabelsABVariant = chosenVariation $scope.trackABTestConversion = (headerItem) -> - event_tracking.sendMB "header-label-ab-conversion", { + event_tracking.sendMB "header-ab-conversion", { headerItem: headerItem, variant: $scope.headerLabelsABVariant }