github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-10-17 21:05:04 -04:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #20007 from overleaf/ae-review-panel-container-ref

Browse source 
Fix event listener attachment to review panel container

GitOrigin-RevId: ceb1023d7be48d9b88e725963124cd04e98127bd
This commit is contained in:
Alf Eaton 2024-08-20 08:36:18 +01:00 committed by Copybot
parent 7e187d903b
commit ee8b8d0692
1 changed files with 21 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
services/web/frontend/js/features/review-panel-new/components/review-panel-current-file.tsx
View file

@ -100,17 +100,29 @@ const ReviewPanelCurrentFile: FC = () => {
}
}, [state, updatePositions])
const handleContainer = useCallback(
(element: HTMLDivElement | null) => {
containerRef.current = element
if (containerRef.current) {
containerRef.current.addEventListener(
'review-panel:position',
updatePositions
)
}
},
[updatePositions]
)
useEffect(() => {
const element = containerRef.current
if (element) {
element.addEventListener('review-panel:position', updatePositions)
// view.scrollDOM.addEventListener('scroll', positionListener)
return () => {
element.removeEventListener('review-panel:position', updatePositions)
// view.scrollDOM.removeEventListener('scroll', positionListener)
if (containerRef.current) {
containerRef.current.removeEventListener(
'review-panel:position',
updatePositions
)
}
}
}, [view, updatePositions])
}, [updatePositions])
const buildEntries = useCallback(() => {
if (ranges) {
@ -194,7 +206,7 @@ const ReviewPanelCurrentFile: FC = () => {
rangesWithPositions.comments.length === 0
return (
<div ref={containerRef}>
<div ref={handleContainer}>
{selectionCoords && (
<div
className="review-panel-entry"