github/overleaf
1
0
Fork 0
mirror of https://github.com/overleaf/overleaf.git synced 2024-11-14 20:40:17 -05:00
Code Issues Projects Releases Packages Wiki Activity

Improve selection detection for "Add comment" tooltip (#21731)

Browse source 
GitOrigin-RevId: cd13cacea0d6e45015997f3a831d0f127ddf8cd8
This commit is contained in:
Domagoj Kriskovic 2024-11-11 17:24:20 +01:00 committed by Copybot
parent 805c4f8321
commit edb4e3d537
1 changed files with 14 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

25
services/web/frontend/js/features/source-editor/extensions/review-tooltip.ts
View file

@ -43,24 +43,21 @@ export const reviewTooltip = (): Extension => {
return [ return [
reviewTooltipTheme, reviewTooltipTheme,
reviewTooltipStateField, reviewTooltipStateField,
EditorView.domEventHandlers({ EditorView.updateListener.of(update => {
mouseup(event, view) { if (update.selectionSet && !update.state.selection.main.empty) {
if (!view.state.selection.main.empty) { update.view.dispatch({
view.dispatch({ effects: textSelectedEffect.of(update.view),
effects: textSelectedEffect.of(view),
}) })
} } else if (
}, !update.startState.selection.main.empty &&
keyup(event, view) { update.state.selection.main.empty
if (
(event.shiftKey || event.key === 'Meta') &&
!view.state.selection.main.empty
) { ) {
view.dispatch({ update.view.dispatch({
effects: textSelectedEffect.of(view), effects: removeReviewPanelTooltipEffect.of(null),
}) })
} }
}, }),
EditorView.domEventHandlers({
mousedown(event, view) { mousedown(event, view) {
view.dispatch({ view.dispatch({
effects: removeReviewPanelTooltipEffect.of(null), effects: removeReviewPanelTooltipEffect.of(null),